wine-commits March 2017

wine-commits@winehq.org

2 participants
717 discussions

Hans Leidekker : webservices: Implement WS_CHANNEL_PROPERTY_CHANNEL_TYPE.
by Alexandre Julliard 29 Mar '17

29 Mar '17

Module: wine Branch: master Commit: 9716776326df8ece5c810ff1d4fd5bff2d75e6e1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=9716776326df8ece5c810ff1d… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Wed Mar 29 11:14:47 2017 +0200 webservices: Implement WS_CHANNEL_PROPERTY_CHANNEL_TYPE. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/webservices/channel.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/dlls/webservices/channel.c b/dlls/webservices/channel.c index 7e7c409..d44fcc0 100644 --- a/dlls/webservices/channel.c +++ b/dlls/webservices/channel.c @@ -232,7 +232,7 @@ HRESULT WINAPI WsGetChannelProperty( WS_CHANNEL *handle, WS_CHANNEL_PROPERTY_ID ULONG size, WS_ERROR *error ) { struct channel *channel = (struct channel *)handle; - HRESULT hr; + HRESULT hr = S_OK; TRACE( "%p %u %p %u %p\n", handle, id, buf, size, error ); if (error) FIXME( "ignoring error parameter\n" ); @@ -247,7 +247,16 @@ HRESULT WINAPI WsGetChannelProperty( WS_CHANNEL *handle, WS_CHANNEL_PROPERTY_ID return E_INVALIDARG; } - hr = prop_get( channel->prop, channel->prop_count, id, buf, size ); + switch (id) + { + case WS_CHANNEL_PROPERTY_CHANNEL_TYPE: + if (!buf || size != sizeof(channel->type)) hr = E_INVALIDARG; + else *(WS_CHANNEL_TYPE *)buf = channel->type; + break; + + default: + hr = prop_get( channel->prop, channel->prop_count, id, buf, size ); + } LeaveCriticalSection( &channel->cs ); return hr;

1 0

Hans Leidekker : webservices: Move heap support to a separate file.
by Alexandre Julliard 29 Mar '17

29 Mar '17

Module: wine Branch: master Commit: 7c94cf90aef43f07ea6204e43cfc1f3decaf2dc2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7c94cf90aef43f07ea6204e43… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Wed Mar 29 11:14:46 2017 +0200 webservices: Move heap support to a separate file. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/webservices/Makefile.in | 1 + dlls/webservices/heap.c | 356 +++++++++++++++++++++++++++++++++ dlls/webservices/reader.c | 285 -------------------------- dlls/webservices/webservices_private.h | 5 + dlls/webservices/writer.c | 41 ---- 5 files changed, 362 insertions(+), 326 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=7c94cf90aef43f07ea620…

1 0

Hans Leidekker : webservices: Move error support to a separate file.
by Alexandre Julliard 29 Mar '17

29 Mar '17

Module: wine Branch: master Commit: 55e60aab5c71ea7ba6036071622fd666565b850c URL: http://source.winehq.org/git/wine.git/?a=commit;h=55e60aab5c71ea7ba60360716… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Wed Mar 29 11:14:45 2017 +0200 webservices: Move error support to a separate file. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/webservices/Makefile.in | 1 + dlls/webservices/error.c | 234 +++++++++++++++++++++++++++++++++++++++++++ dlls/webservices/reader.c | 204 ------------------------------------- 3 files changed, 235 insertions(+), 204 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=55e60aab5c71ea7ba6036…

1 0

Hans Leidekker : webservices: Use a table in get_header_name.
by Alexandre Julliard 29 Mar '17

29 Mar '17

Module: wine Branch: master Commit: bdbab7b63a46d1a1689ba447196ee09734cc3349 URL: http://source.winehq.org/git/wine.git/?a=commit;h=bdbab7b63a46d1a1689ba4471… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Wed Mar 29 11:14:44 2017 +0200 webservices: Use a table in get_header_name. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/webservices/msg.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/dlls/webservices/msg.c b/dlls/webservices/msg.c index 5e425ee..d15ab85 100644 --- a/dlls/webservices/msg.c +++ b/dlls/webservices/msg.c @@ -457,24 +457,24 @@ static HRESULT get_addr_namespace( WS_ADDRESSING_VERSION ver, WS_XML_STRING *str static const WS_XML_STRING *get_header_name( WS_HEADER_TYPE type ) { - static const WS_XML_STRING action = {6, (BYTE *)"Action"}, to = {2, (BYTE *)"To"}; - static const WS_XML_STRING msgid = {9, (BYTE *)"MessageID"}, relto = {9, (BYTE *)"RelatesTo"}; - static const WS_XML_STRING from = {4, (BYTE *)"From"}, replyto = {7, (BYTE *)"ReplyTo"}; - static const WS_XML_STRING faultto = {7, (BYTE *)"FaultTo"}; + static const WS_XML_STRING headers[] = + { + {6, (BYTE *)"Action"}, + {2, (BYTE *)"To"}, + {9, (BYTE *)"MessageID"}, + {9, (BYTE *)"RelatesTo"}, + {4, (BYTE *)"From"}, + {7, (BYTE *)"ReplyTo"}, + {7, (BYTE *)"FaultTo"}, + }; - switch (type) + if (type < WS_ACTION_HEADER || type > WS_FAULT_TO_HEADER) { - case WS_ACTION_HEADER: return &action; - case WS_TO_HEADER: return &to; - case WS_MESSAGE_ID_HEADER: return &msgid; - case WS_RELATES_TO_HEADER: return &relto; - case WS_FROM_HEADER: return &from; - case WS_REPLY_TO_HEADER: return &replyto; - case WS_FAULT_TO_HEADER: return &faultto; - default: ERR( "unknown type %u\n", type ); return NULL; } + + return &headers[type - 1]; } static HRESULT write_headers( struct msg *msg, const WS_XML_STRING *ns_env, const WS_XML_STRING *ns_addr,

1 0

Hans Leidekker : webservices: No longer prefer native.
by Alexandre Julliard 29 Mar '17

29 Mar '17

Module: wine Branch: master Commit: 5a88f52f3f29d55de78ccf4aed267234eb264122 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5a88f52f3f29d55de78ccf4ae… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Wed Mar 29 11:14:43 2017 +0200 webservices: No longer prefer native. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/webservices/Makefile.in | 1 - dlls/webservices/main.c | 44 -------------------------------------------- 2 files changed, 45 deletions(-) diff --git a/dlls/webservices/Makefile.in b/dlls/webservices/Makefile.in index 8de4f6b..342ecc9 100644 --- a/dlls/webservices/Makefile.in +++ b/dlls/webservices/Makefile.in @@ -4,7 +4,6 @@ IMPORTS = winhttp rpcrt4 user32 C_SRCS = \ channel.c \ - main.c \ msg.c \ proxy.c \ reader.c \ diff --git a/dlls/webservices/main.c b/dlls/webservices/main.c deleted file mode 100644 index f99c5cd..0000000 --- a/dlls/webservices/main.c +++ /dev/null @@ -1,44 +0,0 @@ -/* - * Web Services - * - * Copyright 2013 Alistair Leslie-Hughes - * - * This library is free software; you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public - * License as published by the Free Software Foundation; either - * version 2.1 of the License, or (at your option) any later version. - * - * This library is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA - */ - -#include <stdarg.h> - -#include "windef.h" -#include "winbase.h" -#include "webservices.h" -#include "wine/debug.h" - -WINE_DEFAULT_DEBUG_CHANNEL(webservices); - -BOOL WINAPI DllMain(HINSTANCE instance, DWORD reason, LPVOID reserved) -{ - TRACE("(%p, %u, %p)\n", instance, reason, reserved); - - switch (reason) - { - case DLL_WINE_PREATTACH: - return FALSE; /* prefer native version */ - case DLL_PROCESS_ATTACH: - DisableThreadLibraryCalls(instance); - break; - } - - return TRUE; -}

1 0

Vitaly Lipatov : advapi32/tests: Add test prototype for RegQueryValueEx HKEY_PERFORMANCE_DATA.
by Alexandre Julliard 29 Mar '17

29 Mar '17

Module: wine Branch: master Commit: 7cbaf1f56f6d1932123e4275b5fe6f63e7083674 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7cbaf1f56f6d1932123e4275b… Author: Vitaly Lipatov <lav(a)etersoft.ru> Date: Wed Mar 22 14:03:46 2017 +0300 advapi32/tests: Add test prototype for RegQueryValueEx HKEY_PERFORMANCE_DATA. Signed-off-by: Vitaly Lipatov <lav(a)etersoft.ru> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/advapi32/tests/registry.c | 50 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/dlls/advapi32/tests/registry.c b/dlls/advapi32/tests/registry.c index eb9ab67..4ea0f68 100644 --- a/dlls/advapi32/tests/registry.c +++ b/dlls/advapi32/tests/registry.c @@ -27,6 +27,7 @@ #include "winbase.h" #include "winternl.h" #include "winreg.h" +#include "winperf.h" #include "winsvc.h" #include "winerror.h" #include "aclapi.h" @@ -3480,6 +3481,54 @@ static void test_RegNotifyChangeKeyValue(void) CloseHandle(event); } +static void test_RegQueryValueExPerformanceData(void) +{ + DWORD cbData, len; + BYTE *value; + DWORD dwret; + LONG limit = 6; + PERF_DATA_BLOCK *pdb; + + /* Test with data == NULL */ + dwret = RegQueryValueExA( HKEY_PERFORMANCE_DATA, "Global", NULL, NULL, NULL, &cbData ); + todo_wine ok( dwret == ERROR_MORE_DATA, "expected ERROR_MORE_DATA, got %d\n", dwret ); + + /* Test ERROR_MORE_DATA, start with small buffer */ + len = 10; + value = HeapAlloc(GetProcessHeap(), 0, len); + cbData = len; + dwret = RegQueryValueExA( HKEY_PERFORMANCE_DATA, "Global", NULL, NULL, value, &cbData ); + todo_wine ok( dwret == ERROR_MORE_DATA, "expected ERROR_MORE_DATA, got %d\n", dwret ); + while( dwret == ERROR_MORE_DATA && limit) + { + len = len * 10; + value = HeapReAlloc( GetProcessHeap(), 0, value, len ); + cbData = len; + dwret = RegQueryValueExA( HKEY_PERFORMANCE_DATA, "Global", NULL, NULL, value, &cbData ); + limit--; + } + ok(limit > 0, "too many times ERROR_MORE_DATA returned\n"); + + todo_wine ok(dwret == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %d\n", dwret); + + /* Check returned data */ + if (dwret == ERROR_SUCCESS) + { + todo_wine ok(len >= sizeof(PERF_DATA_BLOCK), "got size %d\n", len); + if (len >= sizeof(PERF_DATA_BLOCK)) { + pdb = (PERF_DATA_BLOCK*) value; + ok(pdb->Signature[0] == 'P', "expected Signature[0] = 'P', got 0x%x\n", pdb->Signature[0]); + ok(pdb->Signature[1] == 'E', "expected Signature[1] = 'E', got 0x%x\n", pdb->Signature[1]); + ok(pdb->Signature[2] == 'R', "expected Signature[2] = 'R', got 0x%x\n", pdb->Signature[2]); + ok(pdb->Signature[3] == 'F', "expected Signature[3] = 'F', got 0x%x\n", pdb->Signature[3]); + /* TODO: check other field */ + } + } + + HeapFree(GetProcessHeap(), 0, value); +} + + START_TEST(registry) { /* Load pointers for functions that are not available in all Windows versions */ @@ -3515,6 +3564,7 @@ START_TEST(registry) test_delete_key_value(); test_RegOpenCurrentUser(); test_RegNotifyChangeKeyValue(); + test_RegQueryValueExPerformanceData(); /* cleanup */ delete_key( hkey_main );

1 0

Vitaly Lipatov : include: Add PERF_DATA_BLOCK struct definition.
by Alexandre Julliard 29 Mar '17

29 Mar '17

Module: wine Branch: master Commit: 2884205db3a1d25d407b7c88e378520606f93578 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2884205db3a1d25d407b7c88e… Author: Vitaly Lipatov <lav(a)etersoft.ru> Date: Wed Mar 22 14:03:45 2017 +0300 include: Add PERF_DATA_BLOCK struct definition. Signed-off-by: Vitaly Lipatov <lav(a)etersoft.ru> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/winperf.h | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/include/winperf.h b/include/winperf.h index b62f24b..dce1a6d 100644 --- a/include/winperf.h +++ b/include/winperf.h @@ -67,4 +67,25 @@ #define PERF_DETAIL_EXPERT 300 #define PERF_DETAIL_WIZARD 400 +/* Performance data structure header + * returned in answer to HKEY_PERFORMANCE_DATA request + */ + +typedef struct _PERF_DATA_BLOCK { + WCHAR Signature[4]; + DWORD LittleEndian; + DWORD Version; + DWORD Revision; + DWORD TotalByteLength; + DWORD HeaderLength; + DWORD NumObjectTypes; + DWORD DefaultObject; + SYSTEMTIME SystemTime; + LARGE_INTEGER PerfTime; + LARGE_INTEGER PerfFreq; + LARGE_INTEGER PerfTime100nSec; + DWORD SystemNameLength; + DWORD SystemNameOffset; +} PERF_DATA_BLOCK, *PPERF_DATA_BLOCK, *LPPERF_DATA_BLOCK; + #endif /* _WINPERF_ */

1 0

Alistair Leslie-Hughes : dpnet: Share message handler between IDirectPlay8ThreadPool objects.
by Alexandre Julliard 29 Mar '17

29 Mar '17

Module: wine Branch: master Commit: 072c58e322fddba772bd87bc79dcf9f7938a1c57 URL: http://source.winehq.org/git/wine.git/?a=commit;h=072c58e322fddba772bd87bc7… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Thu Mar 23 01:57:05 2017 +0000 dpnet: Share message handler between IDirectPlay8ThreadPool objects. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dpnet/dpnet_private.h | 4 ---- dlls/dpnet/tests/thread.c | 8 ++++---- dlls/dpnet/threadpool.c | 17 ++++++++++++----- 3 files changed, 16 insertions(+), 13 deletions(-) diff --git a/dlls/dpnet/dpnet_private.h b/dlls/dpnet/dpnet_private.h index 7b6de4a..44ff289d 100644 --- a/dlls/dpnet/dpnet_private.h +++ b/dlls/dpnet/dpnet_private.h @@ -122,10 +122,6 @@ struct IDirectPlay8ThreadPoolImpl { IDirectPlay8ThreadPool IDirectPlay8ThreadPool_iface; LONG ref; - - PFNDPNMESSAGEHANDLER msghandler; - DWORD flags; - void *usercontext; }; /** diff --git a/dlls/dpnet/tests/thread.c b/dlls/dpnet/tests/thread.c index 99de2be..78515f8 100644 --- a/dlls/dpnet/tests/thread.c +++ b/dlls/dpnet/tests/thread.c @@ -70,7 +70,7 @@ static void create_threadpool(void) ok(hr == S_OK, "got 0x%08x\n", hr); hr = IDirectPlay8ThreadPool_Initialize(pool2, NULL, &DirectPlayThreadHandler, 0); - todo_wine ok(hr == DPNERR_ALREADYINITIALIZED, "got 0x%08x\n", hr); + ok(hr == DPNERR_ALREADYINITIALIZED, "got 0x%08x\n", hr); hr = IDirectPlay8ThreadPool_GetThreadCount(pool1, -1, &threadcnt, 0); ok(hr == S_OK, "got 0x%08x\n", hr); @@ -103,7 +103,7 @@ static void create_threadpool(void) ok(hr == S_OK, "got 0x%08x\n", hr); hr = IDirectPlay8ThreadPool_Close(pool2, 0); - todo_wine ok(hr == DPNERR_UNINITIALIZED, "got 0x%08x\n", hr); + ok(hr == DPNERR_UNINITIALIZED, "got 0x%08x\n", hr); IDirectPlay8ThreadPool_Release(pool1); IDirectPlay8ThreadPool_Release(pool2); @@ -226,13 +226,13 @@ static void test_singleton(void) ok(hr == S_OK, "got 0x%08x\n", hr); hr = IDirectPlay8ThreadPool_Initialize(pool2, NULL, &DirectPlayThreadHandler, 0); - todo_wine ok(hr == DPNERR_ALREADYINITIALIZED, "got 0x%08x\n", hr); + ok(hr == DPNERR_ALREADYINITIALIZED, "got 0x%08x\n", hr); hr = IDirectPlay8ThreadPool_Close(pool1, 0); ok(hr == S_OK, "got 0x%08x\n", hr); hr = IDirectPlay8ThreadPool_Close(pool2, 0); - todo_wine ok(hr == DPNERR_UNINITIALIZED, "got 0x%08x\n", hr); + ok(hr == DPNERR_UNINITIALIZED, "got 0x%08x\n", hr); IDirectPlay8ThreadPool_Release(pool1); IDirectPlay8ThreadPool_Release(pool2); diff --git a/dlls/dpnet/threadpool.c b/dlls/dpnet/threadpool.c index 37a05e2..7e84a5a 100644 --- a/dlls/dpnet/threadpool.c +++ b/dlls/dpnet/threadpool.c @@ -36,6 +36,10 @@ WINE_DEFAULT_DEBUG_CHANNEL(dpnet); +static PFNDPNMESSAGEHANDLER threadpool_msghandler = NULL; +static DWORD threadpool_flags = 0; +static void *threadpool_usercontext = NULL; + static inline IDirectPlay8ThreadPoolImpl *impl_from_IDirectPlay8ThreadPool(IDirectPlay8ThreadPool *iface) { return CONTAINING_RECORD(iface, IDirectPlay8ThreadPoolImpl, IDirectPlay8ThreadPool_iface); @@ -89,12 +93,12 @@ static HRESULT WINAPI IDirectPlay8ThreadPoolImpl_Initialize(IDirectPlay8ThreadPo if(!pfn) return DPNERR_INVALIDPARAM; - if(This->msghandler) + if(threadpool_msghandler) return DPNERR_ALREADYINITIALIZED; - This->msghandler = pfn; - This->flags = dwFlags; - This->usercontext = pvUserContext; + threadpool_msghandler = pfn; + threadpool_flags = dwFlags; + threadpool_usercontext = pvUserContext; return DPN_OK; } @@ -106,7 +110,10 @@ static HRESULT WINAPI IDirectPlay8ThreadPoolImpl_Close(IDirectPlay8ThreadPool *i FIXME("(%p)->(%x)\n", This, dwFlags); - This->msghandler = NULL; + if(!threadpool_msghandler) + return DPNERR_UNINITIALIZED; + + threadpool_msghandler = NULL; return DPN_OK; }

1 0

Andrey Gusev : kernelbase: Add QuirkIsEnabled3 stub.
by Alexandre Julliard 29 Mar '17

29 Mar '17

Module: wine Branch: master Commit: 7584e082bf6669923d9c16ca6d617b767179d410 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7584e082bf6669923d9c16ca6… Author: Andrey Gusev <andrey.goosev(a)gmail.com> Date: Tue Mar 28 17:16:01 2017 +0300 kernelbase: Add QuirkIsEnabled3 stub. Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- .../api-ms-win-core-quirks-l1-1-0.spec | 2 +- dlls/kernelbase/Makefile.in | 3 +++ dlls/kernelbase/kernelbase.spec | 2 +- dlls/kernelbase/main.c | 30 ++++++++++++++++++++++ 4 files changed, 35 insertions(+), 2 deletions(-) diff --git a/dlls/api-ms-win-core-quirks-l1-1-0/api-ms-win-core-quirks-l1-1-0.spec b/dlls/api-ms-win-core-quirks-l1-1-0/api-ms-win-core-quirks-l1-1-0.spec index 761120f..e8f77c7 100644 --- a/dlls/api-ms-win-core-quirks-l1-1-0/api-ms-win-core-quirks-l1-1-0.spec +++ b/dlls/api-ms-win-core-quirks-l1-1-0/api-ms-win-core-quirks-l1-1-0.spec @@ -2,7 +2,7 @@ @ stub QuirkGetData2 @ stub QuirkIsEnabled @ stub QuirkIsEnabled2 -@ stub QuirkIsEnabled3 +@ stdcall QuirkIsEnabled3(ptr ptr) kernelbase.QuirkIsEnabled3 @ stub QuirkIsEnabledForPackage @ stub QuirkIsEnabledForPackage2 @ stub QuirkIsEnabledForProcess diff --git a/dlls/kernelbase/Makefile.in b/dlls/kernelbase/Makefile.in index b9caed0..74df98c 100644 --- a/dlls/kernelbase/Makefile.in +++ b/dlls/kernelbase/Makefile.in @@ -1 +1,4 @@ MODULE = kernelbase.dll + +C_SRCS = \ + main.c diff --git a/dlls/kernelbase/kernelbase.spec b/dlls/kernelbase/kernelbase.spec index ff0e75f..e8cf502 100644 --- a/dlls/kernelbase/kernelbase.spec +++ b/dlls/kernelbase/kernelbase.spec @@ -1225,7 +1225,7 @@ # @ stub QuirkGetData2 # @ stub QuirkIsEnabled # @ stub QuirkIsEnabled2 -# @ stub QuirkIsEnabled3 +@ stdcall QuirkIsEnabled3(ptr ptr) # @ stub QuirkIsEnabledForPackage # @ stub QuirkIsEnabledForPackage2 # @ stub QuirkIsEnabledForPackage3 diff --git a/dlls/kernelbase/main.c b/dlls/kernelbase/main.c new file mode 100644 index 0000000..30cba3f --- /dev/null +++ b/dlls/kernelbase/main.c @@ -0,0 +1,30 @@ +/* + * Copyright 2017 Andrey Gusev + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#include "wine/debug.h" + +WINE_DEFAULT_DEBUG_CHANNEL(kernelbase); + +/*********************************************************************** + * QuirkIsEnabled3 (KERNELBASE.@) + */ +BOOL WINAPI QuirkIsEnabled3(void *unk1, void *unk2) +{ + FIXME("(%p, %p) stub!\n", unk1, unk2); + return FALSE; +}

1 0

Zebediah Figura : user32: Always send WM_CANCELMODE when disabling a window.
by Alexandre Julliard 29 Mar '17

29 Mar '17

Module: wine Branch: master Commit: 0ac74d180a28e9071f6bd711ef53fa16b1140653 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0ac74d180a28e9071f6bd711e… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Mon Mar 27 14:01:41 2017 -0500 user32: Always send WM_CANCELMODE when disabling a window. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/user32/tests/msg.c | 21 ++++++++++++++++++++- dlls/user32/win.c | 24 ++++++++++++------------ 2 files changed, 32 insertions(+), 13 deletions(-) diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c index 19a1f31..fbadf7d 100644 --- a/dlls/user32/tests/msg.c +++ b/dlls/user32/tests/msg.c @@ -1796,11 +1796,24 @@ static const struct message WmEnableWindowSeq_1[] = static const struct message WmEnableWindowSeq_2[] = { + { WM_CANCELMODE, sent|wparam|lparam, 0, 0 }, + { EVENT_OBJECT_STATECHANGE, winevent_hook|wparam|lparam, 0, 0 }, + { 0 } +}; + +static const struct message WmEnableWindowSeq_3[] = +{ { EVENT_OBJECT_STATECHANGE, winevent_hook|wparam|lparam, 0, 0 }, { WM_ENABLE, sent|wparam|lparam, TRUE, 0 }, { 0 } }; +static const struct message WmEnableWindowSeq_4[] = +{ + { EVENT_OBJECT_STATECHANGE, winevent_hook|wparam|lparam, 0, 0 }, + { 0 } +}; + static const struct message WmGetScrollRangeSeq[] = { { SBM_GETRANGE, sent }, @@ -5484,8 +5497,14 @@ static void test_messages(void) EnableWindow(hparent, FALSE); ok_sequence(WmEnableWindowSeq_1, "EnableWindow(FALSE)", FALSE); + EnableWindow(hparent, FALSE); + ok_sequence(WmEnableWindowSeq_2, "EnableWindow(FALSE)", FALSE); + + EnableWindow(hparent, TRUE); + ok_sequence(WmEnableWindowSeq_3, "EnableWindow(TRUE)", FALSE); + EnableWindow(hparent, TRUE); - ok_sequence(WmEnableWindowSeq_2, "EnableWindow(TRUE)", FALSE); + ok_sequence(WmEnableWindowSeq_4, "EnableWindow(TRUE)", FALSE); flush_events(); flush_sequence(); diff --git a/dlls/user32/win.c b/dlls/user32/win.c index 38604b4..5c27a01 100644 --- a/dlls/user32/win.c +++ b/dlls/user32/win.c @@ -2152,23 +2152,23 @@ BOOL WINAPI EnableWindow( HWND hwnd, BOOL enable ) TRACE("( %p, %d )\n", hwnd, enable); - retvalue = !IsWindowEnabled( hwnd ); - - if (enable && retvalue) + if (enable) { - WIN_SetStyle( hwnd, 0, WS_DISABLED ); - SendMessageW( hwnd, WM_ENABLE, TRUE, 0 ); + retvalue = (WIN_SetStyle( hwnd, 0, WS_DISABLED ) & WS_DISABLED) != 0; + if (retvalue) SendMessageW( hwnd, WM_ENABLE, TRUE, 0 ); } - else if (!enable && !retvalue) + else { - SendMessageW( hwnd, WM_CANCELMODE, 0, 0); - - WIN_SetStyle( hwnd, WS_DISABLED, 0 ); + SendMessageW( hwnd, WM_CANCELMODE, 0, 0 ); - if (hwnd == GetFocus()) - SetFocus( 0 ); /* A disabled window can't have the focus */ + retvalue = (WIN_SetStyle( hwnd, WS_DISABLED, 0 ) & WS_DISABLED) != 0; + if (!retvalue) + { + if (hwnd == GetFocus()) + SetFocus( 0 ); /* A disabled window can't have the focus */ - SendMessageW( hwnd, WM_ENABLE, FALSE, 0 ); + SendMessageW( hwnd, WM_ENABLE, FALSE, 0 ); + } } return retvalue; }

1 0

← Newer
1
...
7
8
9
10
11
12
13
...
72
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits March 2017