winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
July 2017
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
632 discussions
Start a n
N
ew thread
Zebediah Figura : msi: Return the correct values from custom actions.
by Alexandre Julliard
11 Jul '17
11 Jul '17
Module: wine Branch: master Commit: 16f0dffd011341201db846546873bddc07d7e06a URL:
http://source.winehq.org/git/wine.git/?a=commit;h=16f0dffd011341201db846546…
Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Tue Jul 11 00:18:33 2017 -0500 msi: Return the correct values from custom actions. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msi/action.c | 35 +++++++++++++++++++++++++---------- dlls/msi/dialog.c | 12 ++++++------ dlls/msi/msipriv.h | 2 +- dlls/msi/tests/package.c | 41 +++++++++++++++++++++++++++++++++++++++++ 4 files changed, 73 insertions(+), 17 deletions(-) diff --git a/dlls/msi/action.c b/dlls/msi/action.c index 3f97c82..2d05ba1 100644 --- a/dlls/msi/action.c +++ b/dlls/msi/action.c @@ -172,7 +172,7 @@ static INT ui_actionstart(MSIPACKAGE *package, LPCWSTR action, LPCWSTR descripti } static void ui_actioninfo(MSIPACKAGE *package, LPCWSTR action, BOOL start, - UINT rc) + INT rc) { MSIRECORD *row; WCHAR template[1024]; @@ -189,9 +189,10 @@ static void ui_actioninfo(MSIPACKAGE *package, LPCWSTR action, BOOL start, if (!row) return; MSI_RecordSetStringW(row, 0, message); MSI_RecordSetStringW(row, 1, action); - MSI_RecordSetInteger(row, 2, start ? package->LastActionResult : !rc); + MSI_RecordSetInteger(row, 2, start ? package->LastActionResult : rc); MSI_ProcessMessage(package, INSTALLMESSAGE_INFO, row); msiobj_release(&row->hdr); + if (!start) package->LastActionResult = rc; } enum parse_state @@ -620,15 +621,30 @@ static UINT ACTION_HandleCustomAction(MSIPACKAGE *package, LPCWSTR action, UINT return ERROR_INSTALL_USEREXIT; ui_actioninfo(package, action, TRUE, 0); arc = ACTION_CustomAction( package, action, script ); + uirc = !arc; if (arc == ERROR_FUNCTION_NOT_CALLED && needs_ui_sequence(package)) - arc = ACTION_ShowDialog(package, action); - - if (arc == ERROR_INSTALL_USEREXIT) /* dialog UI returned -1 */ - return ERROR_SUCCESS; + { + uirc = ACTION_ShowDialog(package, action); + switch (uirc) + { + case -1: + return ERROR_SUCCESS; /* stop immediately */ + case 0: arc = ERROR_FUNCTION_NOT_CALLED; break; + case 1: arc = ERROR_SUCCESS; break; + case 2: arc = ERROR_INSTALL_USEREXIT; break; + case 3: arc = ERROR_INSTALL_FAILURE; break; + case 4: arc = ERROR_INSTALL_SUSPEND; break; + case 5: arc = ERROR_MORE_DATA; break; + case 6: arc = ERROR_INVALID_HANDLE_STATE; break; + case 7: arc = ERROR_INVALID_DATA; break; + case 8: arc = ERROR_INSTALL_ALREADY_RUNNING; break; + case 9: arc = ERROR_INSTALL_PACKAGE_REJECTED; break; + default: arc = ERROR_FUNCTION_FAILED; break; + } + } - ui_actioninfo(package, action, FALSE, arc); - package->LastActionResult = !arc; + ui_actioninfo(package, action, FALSE, uirc); return arc; } @@ -7765,8 +7781,7 @@ static UINT ACTION_HandleStandardAction(MSIPACKAGE *package, LPCWSTR action) { ui_actioninfo( package, action, TRUE, 0 ); rc = StandardActions[i].handler( package ); - ui_actioninfo( package, action, FALSE, rc ); - package->LastActionResult = !rc; + ui_actioninfo( package, action, FALSE, !rc ); if (StandardActions[i].action_rollback && !package->need_rollback) { diff --git a/dlls/msi/dialog.c b/dlls/msi/dialog.c index ac2b29b..6c215b1 100644 --- a/dlls/msi/dialog.c +++ b/dlls/msi/dialog.c @@ -4507,20 +4507,21 @@ static UINT event_reset( msi_dialog *dialog, const WCHAR *argument ) return ERROR_SUCCESS; } -UINT ACTION_ShowDialog( MSIPACKAGE *package, const WCHAR *dialog ) +INT ACTION_ShowDialog( MSIPACKAGE *package, const WCHAR *dialog ) { static const WCHAR szDialog[] = {'D','i','a','l','o','g',0}; MSIRECORD *row; INT rc; - if (!TABLE_Exists(package->db, szDialog)) return ERROR_FUNCTION_NOT_CALLED; + if (!TABLE_Exists(package->db, szDialog)) return 0; row = MSI_CreateRecord(0); - if (!row) return ERROR_OUTOFMEMORY; + if (!row) return -1; MSI_RecordSetStringW(row, 0, dialog); rc = MSI_ProcessMessage(package, INSTALLMESSAGE_SHOWDIALOG, row); msiobj_release(&row->hdr); - if (rc == -1) return ERROR_INSTALL_USEREXIT; + + if (rc == -2) rc = 0; if (!rc) { @@ -4540,9 +4541,8 @@ UINT ACTION_ShowDialog( MSIPACKAGE *package, const WCHAR *dialog ) MSI_ProcessMessage(package, INSTALLMESSAGE_INFO, row); msiobj_release(&row->hdr); - return ERROR_FUNCTION_NOT_CALLED; } - return ERROR_SUCCESS; + return rc; } /* Return ERROR_SUCCESS if dialog is process and ERROR_FUNCTION_FAILED diff --git a/dlls/msi/msipriv.h b/dlls/msi/msipriv.h index 600800c..84e53ff 100644 --- a/dlls/msi/msipriv.h +++ b/dlls/msi/msipriv.h @@ -802,7 +802,7 @@ extern void msi_free_patchinfo( MSIPATCHINFO *patch ) DECLSPEC_HIDDEN; /* action internals */ extern UINT MSI_InstallPackage( MSIPACKAGE *, LPCWSTR, LPCWSTR ) DECLSPEC_HIDDEN; -extern UINT ACTION_ShowDialog( MSIPACKAGE*, LPCWSTR) DECLSPEC_HIDDEN; +extern INT ACTION_ShowDialog( MSIPACKAGE*, LPCWSTR) DECLSPEC_HIDDEN; extern UINT ACTION_DialogBox( MSIPACKAGE*, LPCWSTR) DECLSPEC_HIDDEN; extern UINT ACTION_ForceReboot(MSIPACKAGE *package) DECLSPEC_HIDDEN; extern UINT MSI_Sequence( MSIPACKAGE *package, LPCWSTR szTable ) DECLSPEC_HIDDEN; diff --git a/dlls/msi/tests/package.c b/dlls/msi/tests/package.c index e15dc57..1173c92 100644 --- a/dlls/msi/tests/package.c +++ b/dlls/msi/tests/package.c @@ -9389,6 +9389,11 @@ static const struct externalui_message doaction_custom_fullui_sequence[] = { {0} }; +static const struct externalui_message doaction_custom_cancel_sequence[] = { + {INSTALLMESSAGE_ACTIONSTART, 3, {"", "custom", "", ""}, {0, 1, 1, 1}}, + {0} +}; + static const struct externalui_message doaction_dialog_nonexistent_sequence[] = { {INSTALLMESSAGE_ACTIONSTART, 3, {"", "custom", "", ""}, {0, 1, 1, 1}}, {INSTALLMESSAGE_INFO, 2, {"", "custom", "1"}, {0, 1, 1}}, @@ -9415,6 +9420,22 @@ static const struct externalui_message doaction_dialog_error_sequence[] = { {0} }; +static const struct externalui_message doaction_dialog_3_sequence[] = { + {INSTALLMESSAGE_ACTIONSTART, 3, {"", "dialog", "", ""}, {0, 1, 1, 1}}, + {INSTALLMESSAGE_INFO, 2, {"", "dialog", "0"}, {0, 1, 1}}, + {INSTALLMESSAGE_SHOWDIALOG, 0, {"dialog"}, {1}}, + {INSTALLMESSAGE_INFO, 2, {"", "dialog", "3"}, {0, 1, 1}}, + {0} +}; + +static const struct externalui_message doaction_dialog_12345_sequence[] = { + {INSTALLMESSAGE_ACTIONSTART, 3, {"", "dialog", "", ""}, {0, 1, 1, 1}}, + {INSTALLMESSAGE_INFO, 2, {"", "dialog", "3"}, {0, 1, 1}}, + {INSTALLMESSAGE_SHOWDIALOG, 0, {"dialog"}, {1}}, + {INSTALLMESSAGE_INFO, 2, {"", "dialog", "12345"}, {0, 1, 1}}, + {0} +}; + static const struct externalui_message closehandle_sequence[] = { {INSTALLMESSAGE_TERMINATE, -1}, {0} @@ -9577,6 +9598,11 @@ static void test_externalui_message(void) ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); ok_sequence(doaction_custom_fullui_sequence, "MsiDoAction(\"custom\")", FALSE); + retval = 2; + r = MsiDoActionA(hpkg, "custom"); + ok(r == ERROR_INSTALL_USEREXIT, "Expected ERROR_INSTALL_USEREXIT, got %d\n", r); + ok_sequence(doaction_custom_cancel_sequence, "MsiDoAction(\"custom\")", FALSE); + retval = 0; r = MsiDoActionA(hpkg, "custom"); ok(r == ERROR_FUNCTION_NOT_CALLED, "Expected ERROR_FUNCTION_NOT_CALLED, got %d\n", r); @@ -9595,6 +9621,21 @@ static void test_externalui_message(void) ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); ok_sequence(doaction_dialog_error_sequence, "MsiDoAction(\"error\")", FALSE); + retval = -2; + r = MsiDoActionA(hpkg, "custom"); + ok(r == ERROR_FUNCTION_NOT_CALLED, "Expected ERROR_FUNCTION_NOT_CALLED, got %d\n", r); + ok_sequence(doaction_dialog_nonexistent_sequence, "MsiDoAction(\"custom\")", FALSE); + + retval = 3; + r = MsiDoActionA(hpkg, "dialog"); + ok(r == ERROR_INSTALL_FAILURE, "Expected ERROR_INSTALL_FAILURE, got %d\n", r); + ok_sequence(doaction_dialog_3_sequence, "MsiDoAction(\"dialog\")", FALSE); + + retval = 12345; + r = MsiDoActionA(hpkg, "dialog"); + ok(r == ERROR_FUNCTION_FAILED, "Expected ERROR_INSTALL_FAILURE, got %d\n", r); + ok_sequence(doaction_dialog_12345_sequence, "MsiDoAction(\"dialog\")", FALSE); + MsiCloseHandle(hpkg); ok_sequence(closehandle_sequence, "MsiCloseHandle()", FALSE);
1
0
0
0
Zebediah Figura : msi: Rewrite dump_record().
by Alexandre Julliard
11 Jul '17
11 Jul '17
Module: wine Branch: master Commit: f348c7c04c04946935e5bd4e10c7438fb69a9cd2 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=f348c7c04c04946935e5bd4e1…
Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Tue Jul 11 00:18:32 2017 -0500 msi: Rewrite dump_record(). Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msi/msipriv.h | 1 + dlls/msi/package.c | 1 + dlls/msi/record.c | 25 +++++++++++++++++++++++++ dlls/msi/table.c | 19 ------------------- 4 files changed, 27 insertions(+), 19 deletions(-) diff --git a/dlls/msi/msipriv.h b/dlls/msi/msipriv.h index 71a0873..600800c 100644 --- a/dlls/msi/msipriv.h +++ b/dlls/msi/msipriv.h @@ -840,6 +840,7 @@ extern BOOL MSI_RecordsAreEqual( MSIRECORD *, MSIRECORD * ) DECLSPEC_HIDDEN; extern BOOL MSI_RecordsAreFieldsEqual(MSIRECORD *a, MSIRECORD *b, UINT field) DECLSPEC_HIDDEN; extern UINT msi_record_set_string(MSIRECORD *, UINT, const WCHAR *, int) DECLSPEC_HIDDEN; extern const WCHAR *msi_record_get_string(const MSIRECORD *, UINT, int *) DECLSPEC_HIDDEN; +extern void dump_record(MSIRECORD *) DECLSPEC_HIDDEN; /* stream internals */ extern void enum_stream_names( IStorage *stg ) DECLSPEC_HIDDEN; diff --git a/dlls/msi/package.c b/dlls/msi/package.c index f1d7eff..6c24f61 100644 --- a/dlls/msi/package.c +++ b/dlls/msi/package.c @@ -1860,6 +1860,7 @@ INT MSI_ProcessMessageVerbatim(MSIPACKAGE *package, INSTALLMESSAGE eMessageType, char *msg; TRACE("%x\n", eMessageType); + if (TRACE_ON(msi)) dump_record(record); if ((eMessageType & 0xff000000) == INSTALLMESSAGE_FATALEXIT) log_type |= INSTALLLOGMODE_FATALEXIT; diff --git a/dlls/msi/record.c b/dlls/msi/record.c index 39ef70f..de45191 100644 --- a/dlls/msi/record.c +++ b/dlls/msi/record.c @@ -1077,3 +1077,28 @@ WCHAR *msi_dup_record_field( MSIRECORD *rec, INT field ) } return str; } + +void dump_record(MSIRECORD *rec) +{ + int i; + if (!rec) + { + TRACE("(null)\n"); + return; + } + + TRACE("["); + for (i = 0; i <= rec->count; i++) + { + switch(rec->fields[i].type) + { + case MSIFIELD_NULL: TRACE("(null)"); break; + case MSIFIELD_INT: TRACE("%d", rec->fields[i].u.iVal); break; + case MSIFIELD_WSTR: TRACE("%s", debugstr_w(rec->fields[i].u.szwVal)); break; + case MSIFIELD_INTPTR: TRACE("%ld", rec->fields[i].u.pVal); break; + case MSIFIELD_STREAM: TRACE("%p", rec->fields[i].u.stream); break; + } + if (i < rec->count) TRACE(", "); + } + TRACE("]\n"); +} diff --git a/dlls/msi/table.c b/dlls/msi/table.c index b364d97..45a1814 100644 --- a/dlls/msi/table.c +++ b/dlls/msi/table.c @@ -2410,25 +2410,6 @@ static MSIRECORD *msi_get_transform_record( const MSITABLEVIEW *tv, const string return rec; } -static void dump_record( MSIRECORD *rec ) -{ - UINT i, n; - - n = MSI_RecordGetFieldCount( rec ); - for( i=1; i<=n; i++ ) - { - int len; - const WCHAR *sval; - - if( MSI_RecordIsNull( rec, i ) ) - TRACE("row -> []\n"); - else if( (sval = msi_record_get_string( rec, i, &len )) ) - TRACE("row -> [%s]\n", debugstr_wn(sval, len)); - else - TRACE("row -> [0x%08x]\n", MSI_RecordGetInteger( rec, i ) ); - } -} - static void dump_table( const string_table *st, const USHORT *rawdata, UINT rawsize ) { UINT i;
1
0
0
0
André Hentschel : vcomp: Add ARM64 support.
by Alexandre Julliard
11 Jul '17
11 Jul '17
Module: wine Branch: master Commit: 33a8f192b0678e3fa5b8287dc1759995e6983986 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=33a8f192b0678e3fa5b8287dc…
Author: André Hentschel <nerv(a)dawncrow.de> Date: Sun Jul 9 17:10:59 2017 +0200 vcomp: Add ARM64 support. Signed-off-by: André Hentschel <nerv(a)dawncrow.de> Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/vcomp/main.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/dlls/vcomp/main.c b/dlls/vcomp/main.c index 5206e47..ab51ef2 100644 --- a/dlls/vcomp/main.c +++ b/dlls/vcomp/main.c @@ -229,6 +229,51 @@ __ASM_GLOBAL_FUNC( _vcomp_fork_call_wrapper, "mov SP, r5\n\t" "pop {r4, r5, PC}" ) +#elif defined(__aarch64__) + +extern void CDECL _vcomp_fork_call_wrapper(void *wrapper, int nargs, __ms_va_list args); +__ASM_GLOBAL_FUNC( _vcomp_fork_call_wrapper, + "stp x29, x30, [SP,#-16]!\n\t" + "mov x29, SP\n\t" + "mov x9, x0\n\t" + "cbz w1, 2f\n\t" + "mov w10, w1\n\t" + "mov x11, x2\n\t" + "ldr w12, [x11, #24]\n\t" + "ldr x13, [x11, #8]\n\t" + "ldr x0, [x13, w12, sxtw]\n\t" + "add w12, w12, #8\n\t" + "ldr x1, [x13, w12, sxtw]\n\t" + "add w12, w12, #8\n\t" + "ldr x2, [x13, w12, sxtw]\n\t" + "add w12, w12, #8\n\t" + "ldr x3, [x13, w12, sxtw]\n\t" + "add w12, w12, #8\n\t" + "ldr x4, [x13, w12, sxtw]\n\t" + "add w12, w12, #8\n\t" + "ldr x5, [x13, w12, sxtw]\n\t" + "add w12, w12, #8\n\t" + "ldr x6, [x13, w12, sxtw]\n\t" + "add w12, w12, #8\n\t" + "ldr x7, [x13, w12, sxtw]\n\t" + "add w12, w12, #8\n\t" + "add x13, x13, w12, sxtw\n\t" + "subs w12, w10, #8\n\t" + "b.le 2f\n\t" + "ldr x11, [x11]\n\t" + "lsl w12, w12, #3\n\t" + "sub SP, SP, w12, sxtw\n\t" + "tbz w12, #3, 1f\n\t" + "sub SP, SP, #8\n\t" + "1: sub w12, w12, #8\n\t" + "ldr x14, [x13, w12, sxtw]\n\t" + "str x14, [SP, w12, sxtw]\n\t" + "cbnz w12, 1b\n\t" + "2: blr x9\n\t" + "mov SP, x29\n\t" + "ldp x29, x30, [SP], #16\n\t" + "ret\n" ) + #else static void CDECL _vcomp_fork_call_wrapper(void *wrapper, int nargs, __ms_va_list args)
1
0
0
0
Nikolay Sivov : dwrite: Avoid repeated method calls during run rendering.
by Alexandre Julliard
11 Jul '17
11 Jul '17
Module: wine Branch: master Commit: 18fe44c7af612d02711631c100360114c6a6d09e URL:
http://source.winehq.org/git/wine.git/?a=commit;h=18fe44c7af612d02711631c10…
Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Jul 11 16:57:40 2017 +0300 dwrite: Avoid repeated method calls during run rendering. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dwrite/dwrite_private.h | 1 + dlls/dwrite/font.c | 2 ++ dlls/dwrite/freetype.c | 11 ++++------- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/dlls/dwrite/dwrite_private.h b/dlls/dwrite/dwrite_private.h index 7694b79..9530399 100644 --- a/dlls/dwrite/dwrite_private.h +++ b/dlls/dwrite/dwrite_private.h @@ -260,6 +260,7 @@ extern WCHAR bidi_get_mirrored_char(WCHAR) DECLSPEC_HIDDEN; /* FreeType integration */ struct dwrite_glyphbitmap { IDWriteFontFace4 *fontface; + DWORD simulations; FLOAT emsize; BOOL nohint; UINT16 index; diff --git a/dlls/dwrite/font.c b/dlls/dwrite/font.c index 0332587..114833a 100644 --- a/dlls/dwrite/font.c +++ b/dlls/dwrite/font.c @@ -4862,6 +4862,7 @@ static void glyphrunanalysis_get_texturebounds(struct dwrite_glyphrunanalysis *a memset(&glyph_bitmap, 0, sizeof(glyph_bitmap)); glyph_bitmap.fontface = fontface; + glyph_bitmap.simulations = IDWriteFontFace4_GetSimulations(fontface); glyph_bitmap.emsize = analysis->run.fontEmSize; glyph_bitmap.nohint = is_natural_rendering_mode(analysis->rendering_mode); if (analysis->flags & RUNANALYSIS_USE_TRANSFORM) @@ -4954,6 +4955,7 @@ static HRESULT glyphrunanalysis_render(struct dwrite_glyphrunanalysis *analysis) memset(&glyph_bitmap, 0, sizeof(glyph_bitmap)); glyph_bitmap.fontface = fontface; + glyph_bitmap.simulations = IDWriteFontFace4_GetSimulations(fontface); glyph_bitmap.emsize = analysis->run.fontEmSize; glyph_bitmap.nohint = is_natural_rendering_mode(analysis->rendering_mode); glyph_bitmap.type = analysis->texture_type; diff --git a/dlls/dwrite/freetype.c b/dlls/dwrite/freetype.c index 2ad513e..934ca80 100644 --- a/dlls/dwrite/freetype.c +++ b/dlls/dwrite/freetype.c @@ -636,7 +636,6 @@ static BOOL is_face_scalable(IDWriteFontFace4 *fontface) static BOOL get_glyph_transform(struct dwrite_glyphbitmap *bitmap, FT_Matrix *ret) { - USHORT simulations = IDWriteFontFace4_GetSimulations(bitmap->fontface); FT_Matrix m; ret->xx = 1 << 16; @@ -646,10 +645,10 @@ static BOOL get_glyph_transform(struct dwrite_glyphbitmap *bitmap, FT_Matrix *re /* Some fonts provide mostly bitmaps and very few outlines, for example for .notdef. Disable transform if that's the case. */ - if (!is_face_scalable(bitmap->fontface) || (!bitmap->m && simulations == 0)) + if (!is_face_scalable(bitmap->fontface) || (!bitmap->m && bitmap->simulations == 0)) return FALSE; - if (simulations & DWRITE_FONT_SIMULATIONS_OBLIQUE) { + if (bitmap->simulations & DWRITE_FONT_SIMULATIONS_OBLIQUE) { m.xx = 1 << 16; m.xy = (1 << 16) / 3; m.yx = 0; @@ -667,7 +666,6 @@ static BOOL get_glyph_transform(struct dwrite_glyphbitmap *bitmap, FT_Matrix *re void freetype_get_glyph_bbox(struct dwrite_glyphbitmap *bitmap) { - USHORT simulations = IDWriteFontFace4_GetSimulations(bitmap->fontface); FTC_ImageTypeRec imagetype; FT_BBox bbox = { 0 }; BOOL needs_transform; @@ -688,7 +686,7 @@ void freetype_get_glyph_bbox(struct dwrite_glyphbitmap *bitmap) FT_Glyph glyph_copy; if (pFT_Glyph_Copy(glyph, &glyph_copy) == 0) { - if (simulations & DWRITE_FONT_SIMULATIONS_BOLD) + if (bitmap->simulations & DWRITE_FONT_SIMULATIONS_BOLD) embolden_glyph(glyph_copy, bitmap->emsize); /* Includes oblique and user transform. */ @@ -826,7 +824,6 @@ static BOOL freetype_get_aa_glyph_bitmap(struct dwrite_glyphbitmap *bitmap, FT_G BOOL freetype_get_glyph_bitmap(struct dwrite_glyphbitmap *bitmap) { - USHORT simulations = IDWriteFontFace4_GetSimulations(bitmap->fontface); FTC_ImageTypeRec imagetype; BOOL needs_transform; BOOL ret = FALSE; @@ -847,7 +844,7 @@ BOOL freetype_get_glyph_bitmap(struct dwrite_glyphbitmap *bitmap) if (needs_transform) { if (pFT_Glyph_Copy(glyph, &glyph_copy) == 0) { - if (simulations & DWRITE_FONT_SIMULATIONS_BOLD) + if (bitmap->simulations & DWRITE_FONT_SIMULATIONS_BOLD) embolden_glyph(glyph_copy, bitmap->emsize); /* Includes oblique and user transform. */
1
0
0
0
Stefan Dösinger : msvcp140: Export _Current_set.
by Alexandre Julliard
11 Jul '17
11 Jul '17
Module: wine Branch: master Commit: 8810c88abff72df3c6f51c07b11d2efe55a220dc URL:
http://source.winehq.org/git/wine.git/?a=commit;h=8810c88abff72df3c6f51c07b…
Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Tue Jul 11 12:30:17 2017 +0200 msvcp140: Export _Current_set. Signed-off-by: Stefan Dösinger <stefan(a)codeweavers.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcp140/msvcp140.spec | 2 +- dlls/msvcp140/tests/msvcp140.c | 47 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 48 insertions(+), 1 deletion(-) diff --git a/dlls/msvcp140/msvcp140.spec b/dlls/msvcp140/msvcp140.spec index 10bad33..22871bc 100644 --- a/dlls/msvcp140/msvcp140.spec +++ b/dlls/msvcp140/msvcp140.spec @@ -3635,7 +3635,7 @@ @ stub _Copy_file @ stub _Cosh @ cdecl _Current_get(ptr) -@ stub _Current_set +@ cdecl _Current_set(wstr) tr2_sys__Current_set_wchar @ extern _Denorm _Denorm @ cdecl _Dtest(ptr) _Dtest @ stub _Equivalent diff --git a/dlls/msvcp140/tests/msvcp140.c b/dlls/msvcp140/tests/msvcp140.c index 7f1aae3..7ab1ba5 100644 --- a/dlls/msvcp140/tests/msvcp140.c +++ b/dlls/msvcp140/tests/msvcp140.c @@ -153,6 +153,7 @@ static int (__cdecl *p__Reschedule_chore)(const _Threadpool_chore*); static void (__cdecl *p__Release_chore)(_Threadpool_chore*); static MSVCP_bool (__cdecl *p_Current_get)(WCHAR *); +static MSVCP_bool (__cdecl *p_Current_set)(WCHAR const *); static ULONGLONG (__cdecl *p_File_size)(WCHAR const *); static int (__cdecl *p_To_byte)(const WCHAR *src, char *dst); static int (__cdecl *p_To_wide)(const char *src, WCHAR *dst); @@ -219,6 +220,7 @@ static BOOL init(void) } SET(p_Current_get, "_Current_get"); + SET(p_Current_set, "_Current_set"); SET(p_File_size, "_File_size"); SET(p_To_byte, "_To_byte"); SET(p_To_wide, "_To_wide"); @@ -645,6 +647,50 @@ static void test_Current_get(void) wine_dbgstr_w(origin_path), wine_dbgstr_w(current_path)); } +static void test_Current_set(void) +{ + WCHAR temp_path[MAX_PATH], current_path[MAX_PATH], origin_path[MAX_PATH]; + MSVCP_bool ret; + WCHAR testW[] = {'.','/',0}; + WCHAR not_exit_dirW[] = {'n', 'o', 't', '_', 'e', 'x', 'i', 's', 't', '_', 'd', 'i', 'r', 0}; + WCHAR invalid_nameW[] = {'?', '?', 'i', 'n', 'v', 'a', 'l', 'i', 'd', '_', 'n', 'a', 'm', 'e', '>', '>', 0}; + memset(temp_path, 0, sizeof(temp_path)); + GetTempPathW(MAX_PATH, temp_path); + memset(origin_path, 0, sizeof(origin_path)); + GetCurrentDirectoryW(MAX_PATH, origin_path); + + ok(p_Current_set(temp_path), "p_Current_set to temp_path failed\n"); + memset(current_path, 0, sizeof(current_path)); + ret = p_Current_get(current_path); + ok(ret == TRUE, "p_Current_get returned %u\n", ret); + current_path[wcslen(current_path)] = '\\'; + ok(!wcscmp(temp_path, current_path), "p_Current_get(): expect: %s, got %s\n", + wine_dbgstr_w(temp_path), wine_dbgstr_w(current_path)); + + ok(p_Current_set(testW), "p_Current_set to temp_path failed\n"); + memset(current_path, 0, sizeof(current_path)); + ret = p_Current_get(current_path); + ok(ret == TRUE, "p_Current_get returned %u\n", ret); + current_path[wcslen(current_path)] = '\\'; + ok(!wcscmp(temp_path, current_path), "p_Current_get(): expect: %s, got %s\n", + wine_dbgstr_w(temp_path), wine_dbgstr_w(current_path)); + + errno = 0xdeadbeef; + ok(!p_Current_set(not_exit_dirW), "p_Current_set to not_exist_dir succeed\n"); + ok(errno == 0xdeadbeef, "errno = %d\n", errno); + + errno = 0xdeadbeef; + ok(!p_Current_set(invalid_nameW), "p_Current_set to ??invalid_name>> succeed\n"); + ok(errno == 0xdeadbeef, "errno = %d\n", errno); + + ok(p_Current_set(origin_path), "p_Current_set to origin_path failed\n"); + memset(current_path, 0, sizeof(current_path)); + ret = p_Current_get(current_path); + ok(ret == TRUE, "p_Current_get returned %u\n", ret); + ok(!wcscmp(origin_path, current_path), "p_Current_get(): expect: %s, got %s\n", + wine_dbgstr_w(origin_path), wine_dbgstr_w(current_path)); +} + START_TEST(msvcp140) { if(!init()) return; @@ -658,5 +704,6 @@ START_TEST(msvcp140) test_to_wide(); test_File_size(); test_Current_get(); + test_Current_set(); FreeLibrary(msvcp); }
1
0
0
0
Stefan Dösinger : msvcp140: Implement _Current_get.
by Alexandre Julliard
11 Jul '17
11 Jul '17
Module: wine Branch: master Commit: f3b6c6ac0415010fa22d7d0440cb46f507328407 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=f3b6c6ac0415010fa22d7d044…
Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Tue Jul 11 12:30:16 2017 +0200 msvcp140: Implement _Current_get. Signed-off-by: Stefan Dösinger <stefan(a)codeweavers.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcp140/msvcp140.spec | 2 +- dlls/msvcp140/tests/msvcp140.c | 28 ++++++++++++++++++++++++++++ dlls/msvcp90/ios.c | 10 ++++++++++ 3 files changed, 39 insertions(+), 1 deletion(-) diff --git a/dlls/msvcp140/msvcp140.spec b/dlls/msvcp140/msvcp140.spec index 2d51168..10bad33 100644 --- a/dlls/msvcp140/msvcp140.spec +++ b/dlls/msvcp140/msvcp140.spec @@ -3634,7 +3634,7 @@ @ cdecl _Cnd_wait(ptr ptr) @ stub _Copy_file @ stub _Cosh -@ stub _Current_get +@ cdecl _Current_get(ptr) @ stub _Current_set @ extern _Denorm _Denorm @ cdecl _Dtest(ptr) _Dtest diff --git a/dlls/msvcp140/tests/msvcp140.c b/dlls/msvcp140/tests/msvcp140.c index f555980..7f1aae3 100644 --- a/dlls/msvcp140/tests/msvcp140.c +++ b/dlls/msvcp140/tests/msvcp140.c @@ -152,6 +152,7 @@ static int (__cdecl *p__Schedule_chore)(_Threadpool_chore*); static int (__cdecl *p__Reschedule_chore)(const _Threadpool_chore*); static void (__cdecl *p__Release_chore)(_Threadpool_chore*); +static MSVCP_bool (__cdecl *p_Current_get)(WCHAR *); static ULONGLONG (__cdecl *p_File_size)(WCHAR const *); static int (__cdecl *p_To_byte)(const WCHAR *src, char *dst); static int (__cdecl *p_To_wide)(const char *src, WCHAR *dst); @@ -217,6 +218,7 @@ static BOOL init(void) SET(p__Release_chore, "?_Release_chore@details@Concurrency@@YAXPAU_Threadpool_chore@12@@Z"); } + SET(p_Current_get, "_Current_get"); SET(p_File_size, "_File_size"); SET(p_To_byte, "_To_byte"); SET(p_To_wide, "_To_wide"); @@ -618,6 +620,31 @@ static void test_File_size(void) ok(SetCurrentDirectoryW(origin_path), "SetCurrentDirectoryW to origin_path failed\n"); } +static void test_Current_get(void) +{ + WCHAR temp_path[MAX_PATH], current_path[MAX_PATH], origin_path[MAX_PATH]; + BOOL ret; + memset(origin_path, 0, sizeof(origin_path)); + GetCurrentDirectoryW(MAX_PATH, origin_path); + memset(temp_path, 0, sizeof(temp_path)); + GetTempPathW(MAX_PATH, temp_path); + + ok(SetCurrentDirectoryW(temp_path), "SetCurrentDirectoryW to temp_path failed\n"); + memset(current_path, 0, sizeof(current_path)); + ret = p_Current_get(current_path); + ok(ret == TRUE, "p_Current_get returned %u\n", ret); + current_path[wcslen(current_path)] = '\\'; + ok(!wcscmp(temp_path, current_path), "p_Current_get(): expect: %s, got %s\n", + wine_dbgstr_w(temp_path), wine_dbgstr_w(current_path)); + + ok(SetCurrentDirectoryW(origin_path), "SetCurrentDirectoryW to origin_path failed\n"); + memset(current_path, 0, sizeof(current_path)); + ret = p_Current_get(current_path); + ok(ret == TRUE, "p_Current_get returned %u\n", ret); + ok(!wcscmp(origin_path, current_path), "p_Current_get(): expect: %s, got %s\n", + wine_dbgstr_w(origin_path), wine_dbgstr_w(current_path)); +} + START_TEST(msvcp140) { if(!init()) return; @@ -630,5 +657,6 @@ START_TEST(msvcp140) test_to_byte(); test_to_wide(); test_File_size(); + test_Current_get(); FreeLibrary(msvcp); } diff --git a/dlls/msvcp90/ios.c b/dlls/msvcp90/ios.c index e3ba648..9d62454 100644 --- a/dlls/msvcp90/ios.c +++ b/dlls/msvcp90/ios.c @@ -15530,6 +15530,16 @@ WCHAR* __cdecl tr2_sys__Current_get_wchar(WCHAR *current_path) return current_path; } +/* _Current_get, msvcp140 version */ +BOOL __cdecl _Current_get(WCHAR *current_path) +{ + TRACE("(%s)\n", debugstr_w(current_path)); + + if(!GetCurrentDirectoryW(MAX_PATH, current_path)) + return FALSE; + return TRUE; +} + /* ?_Current_set@sys@tr2@std@@YA_NPB_W@Z */ /* ?_Current_set@sys@tr2@std@@YA_NPEB_W@Z */ MSVCP_bool __cdecl tr2_sys__Current_set_wchar(WCHAR const* path)
1
0
0
0
Stefan Dösinger : msvcp140: Implement _File_size.
by Alexandre Julliard
11 Jul '17
11 Jul '17
Module: wine Branch: master Commit: dc736dae6356f540a7828b75455c71ecd66abfb0 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=dc736dae6356f540a7828b754…
Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Tue Jul 11 12:30:15 2017 +0200 msvcp140: Implement _File_size. Signed-off-by: Stefan Dösinger <stefan(a)codeweavers.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcp140/msvcp140.spec | 2 +- dlls/msvcp140/tests/msvcp140.c | 56 ++++++++++++++++++++++++++++++++++++++++++ dlls/msvcp90/ios.c | 12 +++++++++ 3 files changed, 69 insertions(+), 1 deletion(-) diff --git a/dlls/msvcp140/msvcp140.spec b/dlls/msvcp140/msvcp140.spec index 0216450..2d51168 100644 --- a/dlls/msvcp140/msvcp140.spec +++ b/dlls/msvcp140/msvcp140.spec @@ -3648,7 +3648,7 @@ @ extern _FNan _FNan @ stub _FSinh @ extern _FSnan _FSnan -@ stub _File_size +@ cdecl _File_size(wstr) @ cdecl -ret64 _Getcoll() _Getcoll @ cdecl _Getctype(ptr) _Getctype @ cdecl _Getcvt(ptr) _Getcvt diff --git a/dlls/msvcp140/tests/msvcp140.c b/dlls/msvcp140/tests/msvcp140.c index 7cb75f5..f555980 100644 --- a/dlls/msvcp140/tests/msvcp140.c +++ b/dlls/msvcp140/tests/msvcp140.c @@ -152,6 +152,7 @@ static int (__cdecl *p__Schedule_chore)(_Threadpool_chore*); static int (__cdecl *p__Reschedule_chore)(const _Threadpool_chore*); static void (__cdecl *p__Release_chore)(_Threadpool_chore*); +static ULONGLONG (__cdecl *p_File_size)(WCHAR const *); static int (__cdecl *p_To_byte)(const WCHAR *src, char *dst); static int (__cdecl *p_To_wide)(const char *src, WCHAR *dst); @@ -216,6 +217,7 @@ static BOOL init(void) SET(p__Release_chore, "?_Release_chore@details@Concurrency@@YAXPAU_Threadpool_chore@12@@Z"); } + SET(p_File_size, "_File_size"); SET(p_To_byte, "_To_byte"); SET(p_To_wide, "_To_wide"); @@ -563,6 +565,59 @@ static void test_to_wide(void) } } +static void test_File_size(void) +{ + ULONGLONG val; + HANDLE file; + LARGE_INTEGER file_size; + WCHAR test_f1_W[] = {'w','i','n','e','_','t','e','s','t','_','d','i','r','/','f','1',0}; + WCHAR test_f2_W[] = {'w','i','n','e','_','t','e','s','t','_','d','i','r','/','f','2',0}; + WCHAR test_dir_W[] = {'w','i','n','e','_','t','e','s','t','_','d','i','r',0}; + WCHAR test_ne_W[] = {'w','i','n','e','_','t','e','s','t','_','d','i','r','/','n','e',0}; + WCHAR temp_path[MAX_PATH], origin_path[MAX_PATH]; + + memset(origin_path, 0, sizeof(origin_path)); + memset(origin_path, 0, sizeof(temp_path)); + GetCurrentDirectoryW(MAX_PATH, origin_path); + GetTempPathW(MAX_PATH, temp_path); + ok(SetCurrentDirectoryW(temp_path), "SetCurrentDirectoryW to temp_path failed\n"); + + CreateDirectoryW(test_dir_W, NULL); + + file = CreateFileW(test_f1_W, GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, 0, NULL); + ok(file != INVALID_HANDLE_VALUE, "create file failed: INVALID_HANDLE_VALUE\n"); + file_size.QuadPart = 7; + ok(SetFilePointerEx(file, file_size, NULL, FILE_BEGIN), "SetFilePointerEx failed\n"); + ok(SetEndOfFile(file), "SetEndOfFile failed\n"); + CloseHandle(file); + val = p_File_size(test_f1_W); + ok(val == 7, "file_size is %s\n", wine_dbgstr_longlong(val)); + + file = CreateFileW(test_f2_W, GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, 0, NULL); + ok(file != INVALID_HANDLE_VALUE, "create file failed: INVALID_HANDLE_VALUE\n"); + CloseHandle(file); + val = p_File_size(test_f2_W); + ok(val == 0, "file_size is %s\n", wine_dbgstr_longlong(val)); + + val = p_File_size(test_dir_W); + ok(val == 0, "file_size is %s\n", wine_dbgstr_longlong(val)); + + errno = 0xdeadbeef; + val = p_File_size(test_ne_W); + ok(val == ~(ULONGLONG)0, "file_size is %s\n", wine_dbgstr_longlong(val)); + ok(errno == 0xdeadbeef, "errno = %d\n", errno); + + errno = 0xdeadbeef; + val = p_File_size(NULL); + ok(val == ~(ULONGLONG)0, "file_size is %s\n", wine_dbgstr_longlong(val)); + ok(errno == 0xdeadbeef, "errno = %d\n", errno); + + ok(DeleteFileW(test_f1_W), "expect wine_test_dir/f1 to exist\n"); + ok(DeleteFileW(test_f2_W), "expect wine_test_dir/f2 to exist\n"); + ok(RemoveDirectoryW(test_dir_W), "expect wine_test_dir to exist\n"); + ok(SetCurrentDirectoryW(origin_path), "SetCurrentDirectoryW to origin_path failed\n"); +} + START_TEST(msvcp140) { if(!init()) return; @@ -574,5 +629,6 @@ START_TEST(msvcp140) test_chore(); test_to_byte(); test_to_wide(); + test_File_size(); FreeLibrary(msvcp); } diff --git a/dlls/msvcp90/ios.c b/dlls/msvcp90/ios.c index 8e3376c..e3ba648 100644 --- a/dlls/msvcp90/ios.c +++ b/dlls/msvcp90/ios.c @@ -15471,6 +15471,18 @@ ULONGLONG __cdecl tr2_sys__File_size_wchar(WCHAR const* path) return ((ULONGLONG)(fad.nFileSizeHigh) << 32) + fad.nFileSizeLow; } +/* _File_size, msvcp140 version. Different error handling. */ +ULONGLONG __cdecl _File_size(WCHAR const* path) +{ + WIN32_FILE_ATTRIBUTE_DATA fad; + + TRACE("(%s)\n", debugstr_w(path)); + if(!GetFileAttributesExW(path, GetFileExInfoStandard, &fad)) + return ~(ULONGLONG)0; + + return ((ULONGLONG)(fad.nFileSizeHigh) << 32) + fad.nFileSizeLow; +} + /* ?_Equivalent@sys@tr2@std@@YAHPB_W0@Z */ /* ?_Equivalent@sys@tr2@std@@YAHPEB_W0@Z */ int __cdecl tr2_sys__Equivalent_wchar(WCHAR const* path1, WCHAR const* path2)
1
0
0
0
Nikolay Sivov : d2d1/tests: Fix stroke style object leak (Valgrind).
by Alexandre Julliard
11 Jul '17
11 Jul '17
Module: wine Branch: master Commit: d6e2a6f370b50df06ec5957226f637e40d049527 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=d6e2a6f370b50df06ec595722…
Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Jul 11 11:36:02 2017 +0300 d2d1/tests: Fix stroke style object leak (Valgrind). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d2d1/tests/d2d1.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/d2d1/tests/d2d1.c b/dlls/d2d1/tests/d2d1.c index e0318ce..e9e73d8 100644 --- a/dlls/d2d1/tests/d2d1.c +++ b/dlls/d2d1/tests/d2d1.c @@ -4440,6 +4440,8 @@ static void test_stroke_style(void) desc.dashStyle = D2D1_DASH_STYLE_CUSTOM; desc.dashOffset = 0.0f; + ID2D1StrokeStyle_Release(style); + hr = ID2D1Factory_CreateStrokeStyle(factory, &desc, NULL, 0, &style); ok(hr == E_INVALIDARG, "Unexpected return value, %#x.\n", hr);
1
0
0
0
Nikolay Sivov : d2d1: Added a helper to trace D2D1_RECT_F arguments.
by Alexandre Julliard
11 Jul '17
11 Jul '17
Module: wine Branch: master Commit: 9fe40c24f8cb6d7bafe3b41ad57a01b9aa14f225 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=9fe40c24f8cb6d7bafe3b41ad…
Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Mon Jul 10 19:02:18 2017 +0300 d2d1: Added a helper to trace D2D1_RECT_F arguments. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d2d1/bitmap_render_target.c | 20 ++++++++++---------- dlls/d2d1/d2d1_private.h | 6 ++++++ dlls/d2d1/dc_render_target.c | 20 ++++++++++---------- dlls/d2d1/factory.c | 2 +- dlls/d2d1/hwnd_render_target.c | 20 ++++++++++---------- dlls/d2d1/render_target.c | 20 ++++++++++---------- dlls/d2d1/wic_render_target.c | 20 ++++++++++---------- 7 files changed, 57 insertions(+), 51 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=9fe40c24f8cb6d7bafe3b…
1
0
0
0
Nikolay Sivov : po: Update Russian translation.
by Alexandre Julliard
11 Jul '17
11 Jul '17
Module: wine Branch: master Commit: 26c2745266fb8e81368b411e4f06f06869d5c53e URL:
http://source.winehq.org/git/wine.git/?a=commit;h=26c2745266fb8e81368b411e4…
Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Jul 11 13:18:51 2017 +0300 po: Update Russian translation. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- po/ru.po | 28 +++++++++++++--------------- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/po/ru.po b/po/ru.po index a5bcfae..eefee95 100644 --- a/po/ru.po +++ b/po/ru.po @@ -5,7 +5,7 @@ msgstr "" "Project-Id-Version: Wine\n" "Report-Msgid-Bugs-To:
http://bugs.winehq.org\n
" "POT-Creation-Date: N/A\n" -"PO-Revision-Date: 2017-06-30 10:35+0300\n" +"PO-Revision-Date: 2017-07-11 13:16+0300\n" "Last-Translator: Nikolay Sivov <nsivov(a)codeweavers.com>\n" "Language-Team: Russian\n" "Language: ru\n" @@ -1171,7 +1171,7 @@ msgstr "Документов в очереди: %d" #: comdlg32.rc:79 msgid "Margins [inches]" -msgstr "Границы [дюймы)" +msgstr "Границы [дюймы]" #: comdlg32.rc:80 msgid "Margins [mm]" @@ -6895,27 +6895,23 @@ msgstr "выберите каталог, содержащий %s" #: msi.rc:71 msgid "{{Fatal error: }}" -msgstr "" +msgstr "{{Критическая ошибка: }}" #: msi.rc:72 msgid "{{Error [1]. }}" -msgstr "" +msgstr "{{Ошибка [1]. }}" #: msi.rc:73 msgid "Warning [1]." -msgstr "" +msgstr "Предупреждение [1]." #: msi.rc:74 -#, fuzzy -#| msgid "Info [1]. " msgid "Info [1]." -msgstr "Инфо [1]. " +msgstr "Инфо [1]." #: msi.rc:75 -#, fuzzy -#| msgid "Disk full.\n" msgid "{{Disk full: }}" -msgstr "Диск полностью заполнен.\n" +msgstr "{{Диск полон: }}" #: msi.rc:76 msgid "Action %s: [1]. [2]" @@ -6943,6 +6939,8 @@ msgid "" "This may indicate a problem with this package. The error code is [1]. {{The " "arguments are: [2], [3], [4]}}" msgstr "" +"Произошла непредвиденная ошибка при установке пакета. Возможно проблема в " +"самом пакете. Код ошибки [1]. {{Аргументы: [2], [3], [4]}}" #: msi.rc:92 msgid "Allocating registry space" @@ -7010,11 +7008,11 @@ msgstr "Проверка установки" #: msi.rc:110 msgid "Evaluating launch conditions" -msgstr "вычисление условий запуска" +msgstr "Вычисление условий запуска" #: msi.rc:111 msgid "Migrating feature states from related applications" -msgstr "Миграция состояний компонентов " +msgstr "Миграция состояний компонентов" #: msi.rc:112 msgid "Moving files" @@ -12991,7 +12989,7 @@ msgstr "Загрузка ЦП" #: taskmgr.rc:373 msgid "Mem usage" -msgstr "использование памяти" +msgstr "Использование памяти" #: taskmgr.rc:374 msgid "Totals" @@ -13550,7 +13548,7 @@ msgstr "Выгр. пул" #: taskmgr.rc:288 msgid "NP Pool" -msgstr "Невыгр. пул." +msgstr "Невыгр. пул" #: taskmgr.rc:289 msgid "Base Pri"
1
0
0
0
← Newer
1
...
42
43
44
45
46
47
48
...
64
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
Results per page:
10
25
50
100
200