wine-commits July 2017

wine-commits@winehq.org

2 participants
632 discussions

Henri Verbeet : wined3d: Validate vertex shader input signature register indices (AFL).
by Alexandre Julliard 25 Jul '17

25 Jul '17

Module: wine Branch: master Commit: cc16e0d2de47bc6a34039f6cc8d261d94241edf3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=cc16e0d2de47bc6a34039f6cc… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Tue Jul 25 14:26:00 2017 +0200 wined3d: Validate vertex shader input signature register indices (AFL). Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/shader.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/dlls/wined3d/shader.c b/dlls/wined3d/shader.c index d9504ef..8ed2cb9 100644 --- a/dlls/wined3d/shader.c +++ b/dlls/wined3d/shader.c @@ -1684,14 +1684,22 @@ static HRESULT shader_get_registers_used(struct wined3d_shader *shader, const st { for (i = 0; i < input_signature->element_count; ++i) { - reg_maps->input_registers |= 1u << input_signature->elements[i].register_idx; - if (shader_version.type == WINED3D_SHADER_TYPE_PIXEL) + if (shader_version.type == WINED3D_SHADER_TYPE_VERTEX) + { + if (input_signature->elements[i].register_idx >= ARRAY_SIZE(shader->u.vs.attributes)) + { + WARN("Invalid input signature register index %u.\n", input_signature->elements[i].register_idx); + return WINED3DERR_INVALIDCALL; + } + } + else if (shader_version.type == WINED3D_SHADER_TYPE_PIXEL) { if (input_signature->elements[i].sysval_semantic == WINED3D_SV_POSITION) reg_maps->vpos = 1; else if (input_signature->elements[i].sysval_semantic == WINED3D_SV_IS_FRONT_FACE) reg_maps->usesfacing = 1; } + reg_maps->input_registers |= 1u << input_signature->elements[i].register_idx; } } else if (!input_signature->elements && reg_maps->input_registers)

1 0

Jacek Caban : wininet: Improved cookie debug traces.
by Alexandre Julliard 25 Jul '17

25 Jul '17

Module: wine Branch: master Commit: a24b8267d508d27243a31e582e764949c88ad9ee URL: http://source.winehq.org/git/wine.git/?a=commit;h=a24b8267d508d27243a31e582… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Jul 25 13:13:15 2017 +0200 wininet: Improved cookie debug traces. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wininet/cookie.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/dlls/wininet/cookie.c b/dlls/wininet/cookie.c index 5da9710..60b8335 100644 --- a/dlls/wininet/cookie.c +++ b/dlls/wininet/cookie.c @@ -560,18 +560,12 @@ static DWORD get_cookie(substr_t host, substr_t path, DWORD flags, cookie_set_t } for(domain = get_cookie_domain(host, FALSE); domain; domain = domain->parent) { - TRACE("Trying %s domain...\n", debugstr_w(domain->domain)); - LIST_FOR_EACH_ENTRY(container, &domain->path_list, cookie_container_t, entry) { struct list *cursor, *cursor2; - TRACE("path %s\n", debugstr_wn(container->path.str, container->path.len)); - if(!cookie_match_path(container, path)) continue; - TRACE("found domain %p\n", domain->domain); - LIST_FOR_EACH_SAFE(cursor, cursor2, &container->cookie_list) { cookie_t *cookie_iter = LIST_ENTRY(cursor, cookie_t, entry); @@ -586,7 +580,6 @@ static DWORD get_cookie(substr_t host, substr_t path, DWORD flags, cookie_set_t if((cookie_iter->flags & INTERNET_COOKIE_HTTPONLY) && !(flags & INTERNET_COOKIE_HTTPONLY)) continue; - if(!res->size) { res->cookies = heap_alloc(4*sizeof(*res->cookies)); if(!res->cookies) @@ -600,6 +593,9 @@ static DWORD get_cookie(substr_t host, substr_t path, DWORD flags, cookie_set_t res->size *= 2; } + TRACE("%s = %s domain %s path %s\n", debugstr_w(cookie_iter->name), debugstr_w(cookie_iter->data), + debugstr_w(domain->domain), debugstr_wn(container->path.str, container->path.len)); + if(res->cnt) res->string_len += 2; /* '; ' */ res->cookies[res->cnt++] = cookie_iter;

1 0

Alexandre Julliard : configure: Disable LDAP completely if the headers are not missing.
by Alexandre Julliard 25 Jul '17

25 Jul '17

Module: wine Branch: master Commit: 6fd7e75d08669a3498583edc1662bc65d06212d1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6fd7e75d08669a3498583edc1… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Jul 25 12:46:18 2017 +0200 configure: Disable LDAP completely if the headers are not missing. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- configure | 2 ++ configure.ac | 2 ++ 2 files changed, 4 insertions(+) diff --git a/configure b/configure index 0c670fe..5340523 100755 --- a/configure +++ b/configure @@ -16104,6 +16104,8 @@ fi done LIBS="$ac_wine_check_funcs_save_LIBS" + else + LDAP_LIBS="" fi CPPFLAGS=$ac_save_CPPFLAGS test -z "$LDAP_CFLAGS" || LDAP_CFLAGS=`echo " $LDAP_CFLAGS" | sed 's/ -I$[^/]$/ -I\$(top_builddir)\/\1/g'` diff --git a/configure.ac b/configure.ac index 422a7eb..580c37c 100644 --- a/configure.ac +++ b/configure.ac @@ -2172,6 +2172,8 @@ then ldap_parse_vlv_control \ ldap_parse_vlvresponse_control, [$LDAP_LIBS $PTHREAD_LIBS]) + else + LDAP_LIBS="" fi]) fi WINE_NOTICE_WITH(ldap,[test "x$LDAP_LIBS" = "x"],

1 0

Alexandre Julliard : krnl386: Use RtlCaptureContext and NtSetContextThread to implement register functions.
by Alexandre Julliard 25 Jul '17

25 Jul '17

Module: wine Branch: master Commit: 1b85b6cab7372c05fec841a578a9882ef47028f5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1b85b6cab7372c05fec841a57… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Jul 25 12:04:28 2017 +0200 krnl386: Use RtlCaptureContext and NtSetContextThread to implement register functions. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/kernel32.spec | 42 +++++++++++++++++------------------ dlls/krnl386.exe16/kernel16_private.h | 26 ++++++++++++++++------ dlls/krnl386.exe16/krnl386.exe16.spec | 42 +++++++++++++++++------------------ dlls/krnl386.exe16/thunk.c | 24 ++++++++++---------- dlls/krnl386.exe16/vxd.c | 2 +- 5 files changed, 74 insertions(+), 62 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=1b85b6cab7372c05fec84…

1 0

Alexandre Julliard : krnl386: Explicitly fetch the service argument in VxDCall.
by Alexandre Julliard 25 Jul '17

25 Jul '17

Module: wine Branch: master Commit: c5a35d898f40a1f64ffddf36b7bcaa7dbe01b0b3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c5a35d898f40a1f64ffddf36b… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Jul 25 11:51:18 2017 +0200 krnl386: Explicitly fetch the service argument in VxDCall. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/kernel32.spec | 18 +++++++++--------- dlls/krnl386.exe16/kernel16_private.h | 15 +++++++++++++++ dlls/krnl386.exe16/krnl386.exe16.spec | 18 +++++++++--------- dlls/krnl386.exe16/thunk.c | 15 --------------- dlls/krnl386.exe16/vxd.c | 7 +++---- 5 files changed, 36 insertions(+), 37 deletions(-) diff --git a/dlls/kernel32/kernel32.spec b/dlls/kernel32/kernel32.spec index f67141d..36a98bd 100644 --- a/dlls/kernel32/kernel32.spec +++ b/dlls/kernel32/kernel32.spec @@ -8,15 +8,15 @@ # - code generated by the MS Thunk Compiler # - symbols exported by the Oct 94 beta version of kernel32.dll - 1 stdcall -noname -i386 -private -register VxDCall0(long) krnl386.exe16.VxDCall0 - 2 stdcall -noname -i386 -private -register VxDCall1(long) krnl386.exe16.VxDCall1 - 3 stdcall -noname -i386 -private -register VxDCall2(long) krnl386.exe16.VxDCall2 - 4 stdcall -noname -i386 -private -register VxDCall3(long) krnl386.exe16.VxDCall3 - 5 stdcall -noname -i386 -private -register VxDCall4(long) krnl386.exe16.VxDCall4 - 6 stdcall -noname -i386 -private -register VxDCall5(long) krnl386.exe16.VxDCall5 - 7 stdcall -noname -i386 -private -register VxDCall6(long) krnl386.exe16.VxDCall6 - 8 stdcall -noname -i386 -private -register VxDCall7(long) krnl386.exe16.VxDCall7 - 9 stdcall -noname -i386 -private -register VxDCall8(long) krnl386.exe16.VxDCall8 + 1 stdcall -noname -i386 -private -register VxDCall0() krnl386.exe16.VxDCall0 + 2 stdcall -noname -i386 -private -register VxDCall1() krnl386.exe16.VxDCall1 + 3 stdcall -noname -i386 -private -register VxDCall2() krnl386.exe16.VxDCall2 + 4 stdcall -noname -i386 -private -register VxDCall3() krnl386.exe16.VxDCall3 + 5 stdcall -noname -i386 -private -register VxDCall4() krnl386.exe16.VxDCall4 + 6 stdcall -noname -i386 -private -register VxDCall5() krnl386.exe16.VxDCall5 + 7 stdcall -noname -i386 -private -register VxDCall6() krnl386.exe16.VxDCall6 + 8 stdcall -noname -i386 -private -register VxDCall7() krnl386.exe16.VxDCall7 + 9 stdcall -noname -i386 -private -register VxDCall8() krnl386.exe16.VxDCall8 10 stdcall -noname -i386 -private k32CharToOemA(str ptr) krnl386.exe16.k32CharToOemA 11 stdcall -noname -i386 -private k32CharToOemBuffA(str ptr long) krnl386.exe16.k32CharToOemBuffA 12 stdcall -noname -i386 -private k32OemToCharA(ptr ptr) krnl386.exe16.k32OemToCharA diff --git a/dlls/krnl386.exe16/kernel16_private.h b/dlls/krnl386.exe16/kernel16_private.h index 183c872..2c860df 100644 --- a/dlls/krnl386.exe16/kernel16_private.h +++ b/dlls/krnl386.exe16/kernel16_private.h @@ -283,6 +283,21 @@ static inline struct kernel_thread_data *kernel_get_thread_data(void) return (struct kernel_thread_data *)NtCurrentTeb()->SystemReserved1; } +/* Push a DWORD on the 32-bit stack */ +static inline void stack32_push( CONTEXT *context, DWORD val ) +{ + context->Esp -= sizeof(DWORD); + *(DWORD *)context->Esp = val; +} + +/* Pop a DWORD from the 32-bit stack */ +static inline DWORD stack32_pop( CONTEXT *context ) +{ + DWORD ret = *(DWORD *)context->Esp; + context->Esp += sizeof(DWORD); + return ret; +} + #define DEFINE_REGS_ENTRYPOINT( name, args ) \ __ASM_GLOBAL_FUNC( name, \ ".byte 0x68\n\t" /* pushl $__regs_func */ \ diff --git a/dlls/krnl386.exe16/krnl386.exe16.spec b/dlls/krnl386.exe16/krnl386.exe16.spec index 09e2cf6..0f2007b 100644 --- a/dlls/krnl386.exe16/krnl386.exe16.spec +++ b/dlls/krnl386.exe16/krnl386.exe16.spec @@ -549,15 +549,15 @@ ################################################################ # 32-bit version of the various 16-bit functions exported by kernel32 # -@ stdcall -arch=win32 -register VxDCall0(long) VxDCall -@ stdcall -arch=win32 -register VxDCall1(long) VxDCall -@ stdcall -arch=win32 -register VxDCall2(long) VxDCall -@ stdcall -arch=win32 -register VxDCall3(long) VxDCall -@ stdcall -arch=win32 -register VxDCall4(long) VxDCall -@ stdcall -arch=win32 -register VxDCall5(long) VxDCall -@ stdcall -arch=win32 -register VxDCall6(long) VxDCall -@ stdcall -arch=win32 -register VxDCall7(long) VxDCall -@ stdcall -arch=win32 -register VxDCall8(long) VxDCall +@ stdcall -arch=win32 -register VxDCall0() VxDCall +@ stdcall -arch=win32 -register VxDCall1() VxDCall +@ stdcall -arch=win32 -register VxDCall2() VxDCall +@ stdcall -arch=win32 -register VxDCall3() VxDCall +@ stdcall -arch=win32 -register VxDCall4() VxDCall +@ stdcall -arch=win32 -register VxDCall5() VxDCall +@ stdcall -arch=win32 -register VxDCall6() VxDCall +@ stdcall -arch=win32 -register VxDCall7() VxDCall +@ stdcall -arch=win32 -register VxDCall8() VxDCall @ stdcall -arch=win32 k32CharToOemA(str ptr) @ stdcall -arch=win32 k32CharToOemBuffA(str ptr long) @ stdcall -arch=win32 k32OemToCharA(ptr ptr) diff --git a/dlls/krnl386.exe16/thunk.c b/dlls/krnl386.exe16/thunk.c index c72da1c..64287c3 100644 --- a/dlls/krnl386.exe16/thunk.c +++ b/dlls/krnl386.exe16/thunk.c @@ -153,21 +153,6 @@ extern void FT_PrologPrime(void); extern void QT_Thunk(void); extern void QT_ThunkPrime(void); -/* Push a DWORD on the 32-bit stack */ -static inline void stack32_push( CONTEXT *context, DWORD val ) -{ - context->Esp -= sizeof(DWORD); - *(DWORD *)context->Esp = val; -} - -/* Pop a DWORD from the 32-bit stack */ -static inline DWORD stack32_pop( CONTEXT *context ) -{ - DWORD ret = *(DWORD *)context->Esp; - context->Esp += sizeof(DWORD); - return ret; -} - /*********************************************************************** * * * Win95 internal thunks * diff --git a/dlls/krnl386.exe16/vxd.c b/dlls/krnl386.exe16/vxd.c index 6cb7d70..4cd4f05 100644 --- a/dlls/krnl386.exe16/vxd.c +++ b/dlls/krnl386.exe16/vxd.c @@ -286,10 +286,11 @@ done: * VxDCall7 (KERNEL32.8) * VxDCall8 (KERNEL32.9) */ -void WINAPI DECLSPEC_HIDDEN __regs_VxDCall( DWORD service, CONTEXT *context ) +void WINAPI DECLSPEC_HIDDEN __regs_VxDCall( CONTEXT *context ) { unsigned int i; VxDCallProc proc = NULL; + DWORD service = stack32_pop( context ); RtlEnterCriticalSection( &vxd_section ); for (i = 0; i < NB_VXD_SERVICES; i++) @@ -312,9 +313,7 @@ void WINAPI DECLSPEC_HIDDEN __regs_VxDCall( DWORD service, CONTEXT *context ) context->Eax = 0xffffffff; /* FIXME */ } } -#ifdef DEFINE_REGS_ENTRYPOINT -DEFINE_REGS_ENTRYPOINT( VxDCall, 1 ) -#endif +DEFINE_REGS_ENTRYPOINT( VxDCall, 0 ) /***********************************************************************

1 0

Alexandre Julliard : krnl386: Mark function that are only called from assembly as hidden.
by Alexandre Julliard 25 Jul '17

25 Jul '17

Module: wine Branch: master Commit: 5b71091b434b3981559d18c433044d8d84d45496 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5b71091b434b3981559d18c43… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Jul 25 11:50:51 2017 +0200 krnl386: Mark function that are only called from assembly as hidden. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/krnl386.exe16/thunk.c | 2 +- dlls/krnl386.exe16/vxd.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/krnl386.exe16/thunk.c b/dlls/krnl386.exe16/thunk.c index 9126125..c72da1c 100644 --- a/dlls/krnl386.exe16/thunk.c +++ b/dlls/krnl386.exe16/thunk.c @@ -2123,7 +2123,7 @@ LPVOID WINAPI GetPK16SysVar(void) /********************************************************************** * CommonUnimpStub (KERNEL32.17) */ -int WINAPI __regs_CommonUnimpStub( const char *name, int type ) +int WINAPI DECLSPEC_HIDDEN __regs_CommonUnimpStub( const char *name, int type ) { FIXME("generic stub %s\n", debugstr_a(name)); diff --git a/dlls/krnl386.exe16/vxd.c b/dlls/krnl386.exe16/vxd.c index 64983b4..6cb7d70 100644 --- a/dlls/krnl386.exe16/vxd.c +++ b/dlls/krnl386.exe16/vxd.c @@ -286,7 +286,7 @@ done: * VxDCall7 (KERNEL32.8) * VxDCall8 (KERNEL32.9) */ -void WINAPI __regs_VxDCall( DWORD service, CONTEXT *context ) +void WINAPI DECLSPEC_HIDDEN __regs_VxDCall( DWORD service, CONTEXT *context ) { unsigned int i; VxDCallProc proc = NULL;

1 0

Alexandre Julliard : msvcrt: Mark function that are only called from assembly as hidden.
by Alexandre Julliard 25 Jul '17

25 Jul '17

Module: wine Branch: master Commit: c293acac010966193744f30dc5bf6b92aea5f497 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c293acac010966193744f30dc… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Jul 25 11:49:07 2017 +0200 msvcrt: Mark function that are only called from assembly as hidden. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcrt/except_i386.c | 6 +++--- dlls/msvcrt/misc.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/msvcrt/except_i386.c b/dlls/msvcrt/except_i386.c index f777ba6..0400ce5 100644 --- a/dlls/msvcrt/except_i386.c +++ b/dlls/msvcrt/except_i386.c @@ -135,7 +135,7 @@ typedef struct DWORD CDECL cxx_frame_handler( PEXCEPTION_RECORD rec, cxx_exception_frame* frame, PCONTEXT context, EXCEPTION_REGISTRATION_RECORD** dispatch, const cxx_function_descr *descr, - EXCEPTION_REGISTRATION_RECORD* nested_frame, int nested_trylevel ); + EXCEPTION_REGISTRATION_RECORD* nested_frame, int nested_trylevel ) DECLSPEC_HIDDEN; /* call a function with a given ebp */ static inline void *call_ebp_func( void *func, void *ebp ) @@ -1054,7 +1054,7 @@ __ASM_GLOBAL_FUNC( longjmp_set_regs, * _setjmp (MSVCRT.@) */ DEFINE_SETJMP_ENTRYPOINT(MSVCRT__setjmp) -int CDECL __regs_MSVCRT__setjmp(struct MSVCRT___JUMP_BUFFER *jmp) +int CDECL DECLSPEC_HIDDEN __regs_MSVCRT__setjmp(struct MSVCRT___JUMP_BUFFER *jmp) { jmp->Registration = (unsigned long)NtCurrentTeb()->Tib.ExceptionList; if (jmp->Registration == ~0UL) @@ -1071,7 +1071,7 @@ int CDECL __regs_MSVCRT__setjmp(struct MSVCRT___JUMP_BUFFER *jmp) * _setjmp3 (MSVCRT.@) */ DEFINE_SETJMP_ENTRYPOINT( MSVCRT__setjmp3 ) -int CDECL __regs_MSVCRT__setjmp3(struct MSVCRT___JUMP_BUFFER *jmp, int nb_args, ...) +int CDECL DECLSPEC_HIDDEN __regs_MSVCRT__setjmp3(struct MSVCRT___JUMP_BUFFER *jmp, int nb_args, ...) { jmp->Cookie = MSVCRT_JMP_MAGIC; jmp->UnwindFunc = 0; diff --git a/dlls/msvcrt/misc.c b/dlls/msvcrt/misc.c index 9e38364..b9dadac 100644 --- a/dlls/msvcrt/misc.c +++ b/dlls/msvcrt/misc.c @@ -237,7 +237,7 @@ __ASM_GLOBAL_FUNC(_chkesp, __ASM_CFI(".cfi_same_value %ebp\n\t") "ret") -void CDECL MSVCRT_chkesp_fail(void) +void CDECL DECLSPEC_HIDDEN MSVCRT_chkesp_fail(void) { ERR("Stack pointer incorrect after last function call - Bad prototype/spec entry?\n"); DebugBreak();

1 0

Alexandre Julliard : rpcrt4: Mark function that are only called from assembly as hidden.
by Alexandre Julliard 25 Jul '17

25 Jul '17

Module: wine Branch: master Commit: aea6d2371d93f2a76c5ab20801f34e9d6a5b0785 URL: http://source.winehq.org/git/wine.git/?a=commit;h=aea6d2371d93f2a76c5ab2080… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Jul 25 11:48:54 2017 +0200 rpcrt4: Mark function that are only called from assembly as hidden. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/rpcrt4/ndr_stubless.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/dlls/rpcrt4/ndr_stubless.c b/dlls/rpcrt4/ndr_stubless.c index 92a3665..f65eaf5 100644 --- a/dlls/rpcrt4/ndr_stubless.c +++ b/dlls/rpcrt4/ndr_stubless.c @@ -602,8 +602,8 @@ PFORMAT_STRING convert_old_args( PMIDL_STUB_MESSAGE pStubMsg, PFORMAT_STRING pFo return (PFORMAT_STRING)args; } -LONG_PTR CDECL ndr_client_call( PMIDL_STUB_DESC pStubDesc, PFORMAT_STRING pFormat, - void **stack_top, void **fpu_stack ) +LONG_PTR CDECL DECLSPEC_HIDDEN ndr_client_call( PMIDL_STUB_DESC pStubDesc, PFORMAT_STRING pFormat, + void **stack_top, void **fpu_stack ) { /* pointer to start of stack where arguments start */ RPC_MESSAGE rpcMsg; @@ -1532,7 +1532,8 @@ struct async_call_data ULONG_PTR NdrCorrCache[256]; }; -LONG_PTR CDECL ndr_async_client_call( PMIDL_STUB_DESC pStubDesc, PFORMAT_STRING pFormat, void **stack_top ) +LONG_PTR CDECL DECLSPEC_HIDDEN ndr_async_client_call( PMIDL_STUB_DESC pStubDesc, PFORMAT_STRING pFormat, + void **stack_top ) { /* pointer to start of stack where arguments start */ PRPC_MESSAGE pRpcMsg;

1 0

Alexandre Julliard : ntoskrnl: Mark function that are only called from assembly as hidden.
by Alexandre Julliard 25 Jul '17

25 Jul '17

Module: wine Branch: master Commit: e6ff0e6357fb6a78f868c13dc00355d1c01d94ed URL: http://source.winehq.org/git/wine.git/?a=commit;h=e6ff0e6357fb6a78f868c13dc… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Jul 25 11:48:46 2017 +0200 ntoskrnl: Mark function that are only called from assembly as hidden. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntoskrnl.exe/ntoskrnl.c | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/dlls/ntoskrnl.exe/ntoskrnl.c b/dlls/ntoskrnl.exe/ntoskrnl.c index 8d2c020..6347eb0 100644 --- a/dlls/ntoskrnl.exe/ntoskrnl.c +++ b/dlls/ntoskrnl.exe/ntoskrnl.c @@ -1314,7 +1314,7 @@ NTSTATUS WINAPI IoCallDriver( DEVICE_OBJECT *device, IRP *irp ) */ #ifdef DEFINE_FASTCALL2_ENTRYPOINT DEFINE_FASTCALL2_ENTRYPOINT( IofCallDriver ) -NTSTATUS WINAPI __regs_IofCallDriver( DEVICE_OBJECT *device, IRP *irp ) +NTSTATUS WINAPI DECLSPEC_HIDDEN __regs_IofCallDriver( DEVICE_OBJECT *device, IRP *irp ) #else NTSTATUS WINAPI IofCallDriver( DEVICE_OBJECT *device, IRP *irp ) #endif @@ -1531,7 +1531,7 @@ VOID WINAPI IoCompleteRequest( IRP *irp, UCHAR priority_boost ) */ #ifdef DEFINE_FASTCALL2_ENTRYPOINT DEFINE_FASTCALL2_ENTRYPOINT( IofCompleteRequest ) -void WINAPI __regs_IofCompleteRequest( IRP *irp, UCHAR priority_boost ) +void WINAPI DECLSPEC_HIDDEN __regs_IofCompleteRequest( IRP *irp, UCHAR priority_boost ) #else void WINAPI IofCompleteRequest( IRP *irp, UCHAR priority_boost ) #endif @@ -1546,7 +1546,7 @@ void WINAPI IofCompleteRequest( IRP *irp, UCHAR priority_boost ) */ #ifdef DEFINE_FASTCALL3_ENTRYPOINT DEFINE_FASTCALL3_ENTRYPOINT( NTOSKRNL_InterlockedCompareExchange ) -LONG WINAPI __regs_NTOSKRNL_InterlockedCompareExchange( LONG volatile *dest, LONG xchg, LONG compare ) +LONG WINAPI DECLSPEC_HIDDEN __regs_NTOSKRNL_InterlockedCompareExchange( LONG volatile *dest, LONG xchg, LONG compare ) #else LONG WINAPI NTOSKRNL_InterlockedCompareExchange( LONG volatile *dest, LONG xchg, LONG compare ) #endif @@ -1560,7 +1560,7 @@ LONG WINAPI NTOSKRNL_InterlockedCompareExchange( LONG volatile *dest, LONG xchg, */ #ifdef DEFINE_FASTCALL1_ENTRYPOINT DEFINE_FASTCALL1_ENTRYPOINT( NTOSKRNL_InterlockedDecrement ) -LONG WINAPI __regs_NTOSKRNL_InterlockedDecrement( LONG volatile *dest ) +LONG WINAPI DECLSPEC_HIDDEN __regs_NTOSKRNL_InterlockedDecrement( LONG volatile *dest ) #else LONG WINAPI NTOSKRNL_InterlockedDecrement( LONG volatile *dest ) #endif @@ -1574,7 +1574,7 @@ LONG WINAPI NTOSKRNL_InterlockedDecrement( LONG volatile *dest ) */ #ifdef DEFINE_FASTCALL2_ENTRYPOINT DEFINE_FASTCALL2_ENTRYPOINT( NTOSKRNL_InterlockedExchange ) -LONG WINAPI __regs_NTOSKRNL_InterlockedExchange( LONG volatile *dest, LONG val ) +LONG WINAPI DECLSPEC_HIDDEN __regs_NTOSKRNL_InterlockedExchange( LONG volatile *dest, LONG val ) #else LONG WINAPI NTOSKRNL_InterlockedExchange( LONG volatile *dest, LONG val ) #endif @@ -1588,7 +1588,7 @@ LONG WINAPI NTOSKRNL_InterlockedExchange( LONG volatile *dest, LONG val ) */ #ifdef DEFINE_FASTCALL2_ENTRYPOINT DEFINE_FASTCALL2_ENTRYPOINT( NTOSKRNL_InterlockedExchangeAdd ) -LONG WINAPI __regs_NTOSKRNL_InterlockedExchangeAdd( LONG volatile *dest, LONG incr ) +LONG WINAPI DECLSPEC_HIDDEN __regs_NTOSKRNL_InterlockedExchangeAdd( LONG volatile *dest, LONG incr ) #else LONG WINAPI NTOSKRNL_InterlockedExchangeAdd( LONG volatile *dest, LONG incr ) #endif @@ -1602,7 +1602,7 @@ LONG WINAPI NTOSKRNL_InterlockedExchangeAdd( LONG volatile *dest, LONG incr ) */ #ifdef DEFINE_FASTCALL1_ENTRYPOINT DEFINE_FASTCALL1_ENTRYPOINT( NTOSKRNL_InterlockedIncrement ) -LONG WINAPI __regs_NTOSKRNL_InterlockedIncrement( LONG volatile *dest ) +LONG WINAPI DECLSPEC_HIDDEN __regs_NTOSKRNL_InterlockedIncrement( LONG volatile *dest ) #else LONG WINAPI NTOSKRNL_InterlockedIncrement( LONG volatile *dest ) #endif @@ -1616,7 +1616,7 @@ LONG WINAPI NTOSKRNL_InterlockedIncrement( LONG volatile *dest ) */ #ifdef DEFINE_FASTCALL1_ENTRYPOINT DEFINE_FASTCALL1_ENTRYPOINT( NTOSKRNL_InterlockedPopEntrySList ) -PSLIST_ENTRY WINAPI __regs_NTOSKRNL_InterlockedPopEntrySList( PSLIST_HEADER list ) +PSLIST_ENTRY WINAPI DECLSPEC_HIDDEN __regs_NTOSKRNL_InterlockedPopEntrySList( PSLIST_HEADER list ) #else PSLIST_ENTRY WINAPI NTOSKRNL_InterlockedPopEntrySList( PSLIST_HEADER list ) #endif @@ -1630,7 +1630,8 @@ PSLIST_ENTRY WINAPI NTOSKRNL_InterlockedPopEntrySList( PSLIST_HEADER list ) */ #ifdef DEFINE_FASTCALL2_ENTRYPOINT DEFINE_FASTCALL2_ENTRYPOINT( NTOSKRNL_InterlockedPushEntrySList ) -PSLIST_ENTRY WINAPI __regs_NTOSKRNL_InterlockedPushEntrySList( PSLIST_HEADER list, PSLIST_ENTRY entry ) +PSLIST_ENTRY WINAPI DECLSPEC_HIDDEN __regs_NTOSKRNL_InterlockedPushEntrySList( PSLIST_HEADER list, + PSLIST_ENTRY entry ) #else PSLIST_ENTRY WINAPI NTOSKRNL_InterlockedPushEntrySList( PSLIST_HEADER list, PSLIST_ENTRY entry ) #endif @@ -2272,7 +2273,7 @@ void WINAPI ObDereferenceObject( void *obj ) */ #ifdef DEFINE_FASTCALL1_ENTRYPOINT DEFINE_FASTCALL1_ENTRYPOINT( ObfReferenceObject ) -void WINAPI __regs_ObfReferenceObject( void *obj ) +void WINAPI DECLSPEC_HIDDEN __regs_ObfReferenceObject( void *obj ) #else void WINAPI ObfReferenceObject( void *obj ) #endif @@ -2286,7 +2287,7 @@ void WINAPI ObfReferenceObject( void *obj ) */ #ifdef DEFINE_FASTCALL1_ENTRYPOINT DEFINE_FASTCALL1_ENTRYPOINT( ObfDereferenceObject ) -void WINAPI __regs_ObfDereferenceObject( void *obj ) +void WINAPI DECLSPEC_HIDDEN __regs_ObfDereferenceObject( void *obj ) #else void WINAPI ObfDereferenceObject( void *obj ) #endif @@ -2685,7 +2686,7 @@ PLIST_ENTRY WINAPI ExInterlockedRemoveHeadList(PLIST_ENTRY head, PKSPIN_LOCK loc */ #ifdef DEFINE_FASTCALL2_ENTRYPOINT DEFINE_FASTCALL2_ENTRYPOINT( ExfInterlockedRemoveHeadList ) -PLIST_ENTRY WINAPI __regs_ExfInterlockedRemoveHeadList(PLIST_ENTRY head, PKSPIN_LOCK lock) +PLIST_ENTRY WINAPI DECLSPEC_HIDDEN __regs_ExfInterlockedRemoveHeadList(PLIST_ENTRY head, PKSPIN_LOCK lock) #else PLIST_ENTRY WINAPI ExfInterlockedRemoveHeadList(PLIST_ENTRY head, PKSPIN_LOCK lock) #endif @@ -3222,7 +3223,8 @@ VOID WINAPI KeClearEvent(PRKEVENT event) */ #ifdef DEFINE_FASTCALL2_ENTRYPOINT DEFINE_FASTCALL2_ENTRYPOINT( KeAcquireInStackQueuedSpinLock ) -void WINAPI __regs_KeAcquireInStackQueuedSpinLock( KSPIN_LOCK *spinlock, KLOCK_QUEUE_HANDLE *handle ) +void WINAPI DECLSPEC_HIDDEN __regs_KeAcquireInStackQueuedSpinLock( KSPIN_LOCK *spinlock, + KLOCK_QUEUE_HANDLE *handle ) #else void WINAPI KeAcquireInStackQueuedSpinLock( KSPIN_LOCK *spinlock, KLOCK_QUEUE_HANDLE *handle ) #endif @@ -3235,7 +3237,7 @@ void WINAPI KeAcquireInStackQueuedSpinLock( KSPIN_LOCK *spinlock, KLOCK_QUEUE_HA */ #ifdef DEFINE_FASTCALL1_ENTRYPOINT DEFINE_FASTCALL1_ENTRYPOINT( KeReleaseInStackQueuedSpinLock ) -void WINAPI __regs_KeReleaseInStackQueuedSpinLock( KLOCK_QUEUE_HANDLE *handle ) +void WINAPI DECLSPEC_HIDDEN __regs_KeReleaseInStackQueuedSpinLock( KLOCK_QUEUE_HANDLE *handle ) #else void WINAPI KeReleaseInStackQueuedSpinLock( KLOCK_QUEUE_HANDLE *handle ) #endif

1 0

Alexandre Julliard : hal: Mark function that are only called from assembly as hidden.
by Alexandre Julliard 25 Jul '17

25 Jul '17

Module: wine Branch: master Commit: 6d2719d3c12c2765c1a4332b894f95f232ff652b URL: http://source.winehq.org/git/wine.git/?a=commit;h=6d2719d3c12c2765c1a4332b8… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Jul 25 11:48:40 2017 +0200 hal: Mark function that are only called from assembly as hidden. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/hal/hal.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/dlls/hal/hal.c b/dlls/hal/hal.c index 9cae67e..ddd8710 100644 --- a/dlls/hal/hal.c +++ b/dlls/hal/hal.c @@ -52,7 +52,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(ntoskrnl); #ifdef DEFINE_FASTCALL1_ENTRYPOINT DEFINE_FASTCALL1_ENTRYPOINT( ExAcquireFastMutex ) -VOID WINAPI __regs_ExAcquireFastMutex(PFAST_MUTEX FastMutex) +VOID WINAPI DECLSPEC_HIDDEN __regs_ExAcquireFastMutex(PFAST_MUTEX FastMutex) #else VOID WINAPI ExAcquireFastMutex(PFAST_MUTEX FastMutex) #endif @@ -62,7 +62,7 @@ VOID WINAPI ExAcquireFastMutex(PFAST_MUTEX FastMutex) #ifdef DEFINE_FASTCALL1_ENTRYPOINT DEFINE_FASTCALL1_ENTRYPOINT( ExReleaseFastMutex ) -VOID WINAPI __regs_ExReleaseFastMutex(PFAST_MUTEX FastMutex) +VOID WINAPI DECLSPEC_HIDDEN __regs_ExReleaseFastMutex(PFAST_MUTEX FastMutex) #else VOID WINAPI ExReleaseFastMutex(PFAST_MUTEX FastMutex) #endif @@ -72,7 +72,7 @@ VOID WINAPI ExReleaseFastMutex(PFAST_MUTEX FastMutex) #ifdef DEFINE_FASTCALL1_ENTRYPOINT DEFINE_FASTCALL1_ENTRYPOINT( ExTryToAcquireFastMutex ) -BOOLEAN WINAPI __regs_ExTryToAcquireFastMutex(PFAST_MUTEX FastMutex) +BOOLEAN WINAPI DECLSPEC_HIDDEN __regs_ExTryToAcquireFastMutex(PFAST_MUTEX FastMutex) #else BOOLEAN WINAPI ExTryToAcquireFastMutex(PFAST_MUTEX FastMutex) #endif @@ -83,7 +83,7 @@ BOOLEAN WINAPI ExTryToAcquireFastMutex(PFAST_MUTEX FastMutex) #ifdef DEFINE_FASTCALL1_ENTRYPOINT DEFINE_FASTCALL1_ENTRYPOINT( KfAcquireSpinLock ) -KIRQL WINAPI __regs_KfAcquireSpinLock(PKSPIN_LOCK SpinLock) +KIRQL WINAPI DECLSPEC_HIDDEN __regs_KfAcquireSpinLock(PKSPIN_LOCK SpinLock) #else KIRQL WINAPI KfAcquireSpinLock(PKSPIN_LOCK SpinLock) #endif @@ -96,7 +96,7 @@ KIRQL WINAPI KfAcquireSpinLock(PKSPIN_LOCK SpinLock) #ifdef DEFINE_FASTCALL1_ENTRYPOINT DEFINE_FASTCALL1_ENTRYPOINT( KfLowerIrql ) -VOID WINAPI __regs_KfLowerIrql(KIRQL NewIrql) +VOID WINAPI DECLSPEC_HIDDEN __regs_KfLowerIrql(KIRQL NewIrql) #else VOID WINAPI KfLowerIrql(KIRQL NewIrql) #endif @@ -107,7 +107,7 @@ VOID WINAPI KfLowerIrql(KIRQL NewIrql) #ifdef DEFINE_FASTCALL1_ENTRYPOINT DEFINE_FASTCALL1_ENTRYPOINT( KfRaiseIrql ) -KIRQL WINAPI __regs_KfRaiseIrql(KIRQL NewIrql) +KIRQL WINAPI DECLSPEC_HIDDEN __regs_KfRaiseIrql(KIRQL NewIrql) #else KIRQL WINAPI KfRaiseIrql(KIRQL NewIrql) #endif @@ -120,7 +120,7 @@ KIRQL WINAPI KfRaiseIrql(KIRQL NewIrql) #ifdef DEFINE_FASTCALL2_ENTRYPOINT DEFINE_FASTCALL2_ENTRYPOINT( KfReleaseSpinLock ) -VOID WINAPI __regs_KfReleaseSpinLock(PKSPIN_LOCK SpinLock, KIRQL NewIrql) +VOID WINAPI DECLSPEC_HIDDEN __regs_KfReleaseSpinLock(PKSPIN_LOCK SpinLock, KIRQL NewIrql) #else VOID WINAPI KfReleaseSpinLock(PKSPIN_LOCK SpinLock, KIRQL NewIrql) #endif

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
64
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits July 2017