winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
September 2017
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
446 discussions
Start a n
N
ew thread
Alexandre Julliard : ntdll: Remove some unnecessary parameters in helper functions.
by Alexandre Julliard
22 Sep '17
22 Sep '17
Module: wine Branch: master Commit: 872228da4c0000459ac1cc883fb2b3a2620ddb3a URL:
http://source.winehq.org/git/wine.git/?a=commit;h=872228da4c0000459ac1cc883…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Sep 22 09:52:29 2017 +0200 ntdll: Remove some unnecessary parameters in helper functions. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/virtual.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/dlls/ntdll/virtual.c b/dlls/ntdll/virtual.c index a452c58..ceb4216 100644 --- a/dlls/ntdll/virtual.c +++ b/dlls/ntdll/virtual.c @@ -804,7 +804,7 @@ static NTSTATUS get_vprot_flags( DWORD protect, unsigned int *vprot, BOOL image * * Wrapper for mprotect, adds PROT_EXEC if forced by force_exec_prot */ -static inline int mprotect_exec( void *base, size_t size, int unix_prot, unsigned int view_protect ) +static inline int mprotect_exec( void *base, size_t size, int unix_prot ) { if (force_exec_prot && (unix_prot & PROT_READ) && !(unix_prot & PROT_EXEC)) { @@ -823,7 +823,7 @@ static inline int mprotect_exec( void *base, size_t size, int unix_prot, unsigne * * Call mprotect on a page range, applying the protections from the per-page byte. */ -static void mprotect_range( struct file_view *view, void *base, size_t size, BYTE set, BYTE clear ) +static void mprotect_range( void *base, size_t size, BYTE set, BYTE clear ) { size_t i, count; char *addr = base; @@ -834,12 +834,12 @@ static void mprotect_range( struct file_view *view, void *base, size_t size, BYT { next = VIRTUAL_GetUnixProt( (get_page_vprot( addr + (count << page_shift) ) & ~clear) | set ); if (next == prot) continue; - mprotect_exec( addr, count << page_shift, prot, view->protect ); + mprotect_exec( addr, count << page_shift, prot ); addr += count << page_shift; prot = next; count = 0; } - if (count) mprotect_exec( addr, count << page_shift, prot, view->protect ); + if (count) mprotect_exec( addr, count << page_shift, prot ); } @@ -863,7 +863,7 @@ static BOOL VIRTUAL_SetProt( struct file_view *view, /* [in] Pointer to view */ { /* each page may need different protections depending on write watch flag */ set_page_vprot_bits( base, size, vprot & ~VPROT_WRITEWATCH, ~vprot & ~VPROT_WRITEWATCH ); - mprotect_range( view, base, size, 0, 0 ); + mprotect_range( base, size, 0, 0 ); return TRUE; } @@ -878,7 +878,7 @@ static BOOL VIRTUAL_SetProt( struct file_view *view, /* [in] Pointer to view */ return TRUE; } - if (mprotect_exec( base, size, unix_prot, view->protect )) /* FIXME: last error */ + if (mprotect_exec( base, size, unix_prot )) /* FIXME: last error */ return FALSE; set_page_vprot( base, size, vprot ); @@ -917,10 +917,10 @@ static NTSTATUS set_protection( struct file_view *view, void *base, SIZE_T size, * * Reset write watches in a memory range. */ -static void reset_write_watches( struct file_view *view, void *base, SIZE_T size ) +static void reset_write_watches( void *base, SIZE_T size ) { set_page_vprot_bits( base, size, VPROT_WRITEWATCH, 0 ); - mprotect_range( view, base, size, 0, 0 ); + mprotect_range( base, size, 0, 0 ); } @@ -1769,7 +1769,7 @@ NTSTATUS virtual_handle_fault( LPCVOID addr, DWORD err, BOOL on_signal_stack ) if (vprot & VPROT_WRITEWATCH) { set_page_vprot_bits( page, page_size, 0, VPROT_WRITEWATCH ); - mprotect_range( view, page, page_size, 0, 0 ); + mprotect_range( page, page_size, 0, 0 ); } /* ignore fault if page is writable now */ if (VIRTUAL_GetUnixProt( get_page_vprot( page )) & PROT_WRITE) ret = STATUS_SUCCESS; @@ -1777,7 +1777,7 @@ NTSTATUS virtual_handle_fault( LPCVOID addr, DWORD err, BOOL on_signal_stack ) if (!on_signal_stack && (vprot & VPROT_GUARD)) { set_page_vprot_bits( page, page_size, 0, VPROT_GUARD ); - mprotect_range( view, page, page_size, 0, 0 ); + mprotect_range( page, page_size, 0, 0 ); ret = STATUS_GUARD_PAGE_VIOLATION; } } @@ -1972,7 +1972,7 @@ NTSTATUS virtual_uninterrupted_write_memory( void *addr, const void *buffer, SIZ if (view->protect & VPROT_WRITEWATCH) /* enable write access by clearing write watches */ { set_page_vprot_bits( addr, size, 0, VPROT_WRITEWATCH ); - mprotect_range( view, addr, size, 0, 0 ); + mprotect_range( addr, size, 0, 0 ); } memcpy( addr, buffer, size ); ret = STATUS_SUCCESS; @@ -2003,7 +2003,7 @@ void VIRTUAL_SetForceExec( BOOL enable ) /* file mappings are always accessible */ BYTE commit = is_view_valloc( view ) ? 0 : VPROT_COMMITTED; - mprotect_range( view, view->base, view->size, commit, 0 ); + mprotect_range( view->base, view->size, commit, 0 ); } } server_leave_uninterrupted_section( &csVirtual, &sigset ); @@ -3090,7 +3090,7 @@ NTSTATUS WINAPI NtGetWriteWatch( HANDLE process, ULONG flags, PVOID base, SIZE_T if (!(get_page_vprot( addr ) & VPROT_WRITEWATCH)) addresses[pos++] = addr; addr += page_size; } - if (flags & WRITE_WATCH_FLAG_RESET) reset_write_watches( view, base, addr - (char *)base ); + if (flags & WRITE_WATCH_FLAG_RESET) reset_write_watches( base, addr - (char *)base ); *count = pos; *granularity = page_size; } @@ -3121,7 +3121,7 @@ NTSTATUS WINAPI NtResetWriteWatch( HANDLE process, PVOID base, SIZE_T size ) server_enter_uninterrupted_section( &csVirtual, &sigset ); if ((view = VIRTUAL_FindView( base, size )) && (view->protect & VPROT_WRITEWATCH)) - reset_write_watches( view, base, size ); + reset_write_watches( base, size ); else status = STATUS_INVALID_PARAMETER;
1
0
0
0
Fabian Maurer : propsys: Added PropVariantToBoolean with some tests.
by Alexandre Julliard
22 Sep '17
22 Sep '17
Module: wine Branch: master Commit: 58ea6bddaef5deced2c7f81c6df0668408e99656 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=58ea6bddaef5deced2c7f81c6…
Author: Fabian Maurer <dark.shadow4(a)web.de> Date: Fri Sep 22 10:00:46 2017 +0300 propsys: Added PropVariantToBoolean with some tests. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/propsys/propsys.spec | 2 +- dlls/propsys/propvar.c | 60 ++++++++++++ dlls/propsys/tests/propsys.c | 215 +++++++++++++++++++++++++++++++++++++++++++ include/propvarutil.h | 1 + 4 files changed, 277 insertions(+), 1 deletion(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=58ea6bddaef5deced2c7f…
1
0
0
0
Zebediah Figura : mshtml: Don' t query for an INewWindowManager if the client site is NULL.
by Alexandre Julliard
22 Sep '17
22 Sep '17
Module: wine Branch: master Commit: 02641e33a98c68435eb70a240f640bdfa2e5fd22 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=02641e33a98c68435eb70a240…
Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Thu Sep 21 09:59:43 2017 -0500 mshtml: Don't query for an INewWindowManager if the client site is NULL. Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/navigate.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/dlls/mshtml/navigate.c b/dlls/mshtml/navigate.c index 423d650..1597de9 100644 --- a/dlls/mshtml/navigate.c +++ b/dlls/mshtml/navigate.c @@ -2246,9 +2246,14 @@ HRESULT navigate_new_window(HTMLOuterWindow *window, IUri *uri, const WCHAR *nam nsChannelBSC *bsc; HRESULT hres; - hres = do_query_service((IUnknown*)window->doc_obj->client, &SID_SNewWindowManager, &IID_INewWindowManager, - (void**)&new_window_mgr); - if(SUCCEEDED(hres)) { + if (window->doc_obj->client) { + hres = do_query_service((IUnknown*)window->doc_obj->client, &SID_SNewWindowManager, + &IID_INewWindowManager, (void**)&new_window_mgr); + if (FAILED(hres)) { + FIXME("No INewWindowManager\n"); + return hres; + } + hres = IUri_GetDisplayUri(window->uri_nofrag, &context_url); if(FAILED(hres)) return hres; @@ -2270,9 +2275,6 @@ HRESULT navigate_new_window(HTMLOuterWindow *window, IUri *uri, const WCHAR *nam *ret = NULL; return S_OK; } - }else { - FIXME("No INewWindowManager\n"); - return E_NOTIMPL; }
1
0
0
0
Zebediah Figura : shlwapi: URL schemes may contain hyphen, plus, or period.
by Alexandre Julliard
22 Sep '17
22 Sep '17
Module: wine Branch: master Commit: 3559c261c142eff8d500c6ca443672b17ea162db URL:
http://source.winehq.org/git/wine.git/?a=commit;h=3559c261c142eff8d500c6ca4…
Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Thu Sep 21 14:49:46 2017 -0500 shlwapi: URL schemes may contain hyphen, plus, or period. Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/shlwapi/tests/url.c | 1 + dlls/shlwapi/url.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/dlls/shlwapi/tests/url.c b/dlls/shlwapi/tests/url.c index f1c0965..ac896b0 100644 --- a/dlls/shlwapi/tests/url.c +++ b/dlls/shlwapi/tests/url.c @@ -1483,6 +1483,7 @@ static const struct parse_url_test_t { {"
ab-://www.winehq.org/
",S_OK,3,URL_SCHEME_UNKNOWN}, {"
http://www.winehq.org/
",URL_E_INVALID_SYNTAX}, {"
HTTP://www.winehq.org/
",S_OK,4,URL_SCHEME_HTTP}, + {"
a+-.://www.winehq.org/
",S_OK,4,URL_SCHEME_UNKNOWN}, }; static void test_ParseURL(void) diff --git a/dlls/shlwapi/url.c b/dlls/shlwapi/url.c index bda4eb2..c7d717b 100644 --- a/dlls/shlwapi/url.c +++ b/dlls/shlwapi/url.c @@ -169,7 +169,7 @@ HRESULT WINAPI ParseURLA(LPCSTR x, PARSEDURLA *y) if(y->cbSize != sizeof(*y)) return E_INVALIDARG; - while(*ptr && (isalnum(*ptr) || *ptr == '-')) + while(*ptr && (isalnum(*ptr) || *ptr == '-' || *ptr == '+' || *ptr == '.')) ptr++; if (*ptr != ':' || ptr <= x+1) { @@ -203,7 +203,7 @@ HRESULT WINAPI ParseURLW(LPCWSTR x, PARSEDURLW *y) if(y->cbSize != sizeof(*y)) return E_INVALIDARG; - while(*ptr && (isalnumW(*ptr) || *ptr == '-')) + while(*ptr && (isalnumW(*ptr) || *ptr == '-' || *ptr == '+' || *ptr == '.')) ptr++; if (*ptr != ':' || ptr <= x+1) {
1
0
0
0
Zebediah Figura : include: Update BrowserNavConstants enum for Win10.
by Alexandre Julliard
22 Sep '17
22 Sep '17
Module: wine Branch: master Commit: 52e45d8f505f393e3a347426b7b0dc3ac4dcf64a URL:
http://source.winehq.org/git/wine.git/?a=commit;h=52e45d8f505f393e3a347426b…
Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Thu Sep 21 13:55:40 2017 -0500 include: Update BrowserNavConstants enum for Win10. Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/exdisp.idl | 37 +++++++++++++++++++++++++++++-------- 1 file changed, 29 insertions(+), 8 deletions(-) diff --git a/include/exdisp.idl b/include/exdisp.idl index b665ce3..90cc266 100644 --- a/include/exdisp.idl +++ b/include/exdisp.idl @@ -64,14 +64,35 @@ interface IWebBrowser : IDispatch { typedef enum BrowserNavConstants { - navOpenInNewWindow = 0x1, - navNoHistory = 0x2, - navNoReadFromCache = 0x4, - navNoWriteToCache = 0x8, - navAllowAutosearch = 0x10, - navBrowserBar = 0x20, - navHyperlink = 0x40, - navEnforceRestricted = 0x80 + navOpenInNewWindow = 0x00000001, + navNoHistory = 0x00000002, + navNoReadFromCache = 0x00000004, + navNoWriteToCache = 0x00000008, + navAllowAutosearch = 0x00000010, + navBrowserBar = 0x00000020, + navHyperlink = 0x00000040, + navEnforceRestricted = 0x00000080, + navNewWindowsManaged = 0x00000100, + navUntrustedForDownload = 0x00000200, + navTrustedForActiveX = 0x00000400, + navOpenInNewTab = 0x00000800, + navOpenInBackgroundTab = 0x00001000, + navKeepWordWheelText = 0x00002000, + navVirtualTab = 0x00004000, + navBlockRedirectsXDomain = 0x00008000, + navOpenNewForegroundTab = 0x00010000, + navTravelLogScreenshot = 0x00020000, + navDeferUnload = 0x00040000, + navSpeculative = 0x00080000, + navSuggestNewWindow = 0x00100000, + navSuggestNewTab = 0x00200000, + navReserved1 = 0x00400000, + navHomepageNavigate = 0x00800000, + navRefresh = 0x01000000, + navHostNavigation = 0x02000000, + navReserved2 = 0x04000000, + navReserved3 = 0x08000000, + navReserved4 = 0x10000000, } BrowserNavConstants; typedef enum RefreshConstants
1
0
0
0
Jacek Caban : mshtml: Added IEventTarget stub implementation.
by Alexandre Julliard
22 Sep '17
22 Sep '17
Module: wine Branch: master Commit: 455d68467116dd962caceb844a74d8ee4ef8484c URL:
http://source.winehq.org/git/wine.git/?a=commit;h=455d68467116dd962caceb844…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Sep 21 23:25:55 2017 +0200 mshtml: Added IEventTarget stub implementation. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/dispex.c | 8 ++- dlls/mshtml/htmlevent.c | 126 +++++++++++++++++++++++++++++++++++++++++++ dlls/mshtml/mshtml_private.h | 2 + dlls/mshtml/tests/dom.c | 28 ++++++++++ 4 files changed, 162 insertions(+), 2 deletions(-) diff --git a/dlls/mshtml/dispex.c b/dlls/mshtml/dispex.c index 95c17b8..de478f3 100644 --- a/dlls/mshtml/dispex.c +++ b/dlls/mshtml/dispex.c @@ -1346,6 +1346,11 @@ HRESULT remove_attribute(DispatchEx *This, DISPID id, VARIANT_BOOL *success) } } +compat_mode_t dispex_compat_mode(DispatchEx *dispex) +{ + return dispex->info->desc->vtbl->get_compat_mode(dispex); +} + static dispex_data_t *ensure_dispex_info(dispex_static_data_t *desc, compat_mode_t compat_mode) { if(!desc->info_cache[compat_mode]) { @@ -1362,8 +1367,7 @@ static BOOL ensure_real_info(DispatchEx *dispex) if(dispex->info != dispex->info->desc->delayed_init_info) return TRUE; - dispex->info = ensure_dispex_info(dispex->info->desc, - dispex->info->desc->vtbl->get_compat_mode(dispex)); + dispex->info = ensure_dispex_info(dispex->info->desc, dispex_compat_mode(dispex)); return dispex->info != NULL; } diff --git a/dlls/mshtml/htmlevent.c b/dlls/mshtml/htmlevent.c index 0061384..4372066 100644 --- a/dlls/mshtml/htmlevent.c +++ b/dlls/mshtml/htmlevent.c @@ -1638,8 +1638,120 @@ HRESULT doc_init_events(HTMLDocumentNode *doc) return S_OK; } +static inline EventTarget *impl_from_IEventTarget(IEventTarget *iface) +{ + return CONTAINING_RECORD(iface, EventTarget, IEventTarget_iface); +} + +static HRESULT WINAPI EventTarget_QueryInterface(IEventTarget *iface, REFIID riid, void **ppv) +{ + EventTarget *This = impl_from_IEventTarget(iface); + return IDispatchEx_QueryInterface(&This->dispex.IDispatchEx_iface, riid, ppv); +} + +static ULONG WINAPI EventTarget_AddRef(IEventTarget *iface) +{ + EventTarget *This = impl_from_IEventTarget(iface); + return IDispatchEx_AddRef(&This->dispex.IDispatchEx_iface); +} + +static ULONG WINAPI EventTarget_Release(IEventTarget *iface) +{ + EventTarget *This = impl_from_IEventTarget(iface); + return IDispatchEx_Release(&This->dispex.IDispatchEx_iface); +} + +static HRESULT WINAPI EventTarget_GetTypeInfoCount(IEventTarget *iface, UINT *pctinfo) +{ + EventTarget *This = impl_from_IEventTarget(iface); + return IDispatchEx_GetTypeInfoCount(&This->dispex.IDispatchEx_iface, pctinfo); +} + +static HRESULT WINAPI EventTarget_GetTypeInfo(IEventTarget *iface, UINT iTInfo, + LCID lcid, ITypeInfo **ppTInfo) +{ + EventTarget *This = impl_from_IEventTarget(iface); + return IDispatchEx_GetTypeInfo(&This->dispex.IDispatchEx_iface, iTInfo, lcid, ppTInfo); +} + +static HRESULT WINAPI EventTarget_GetIDsOfNames(IEventTarget *iface, REFIID riid, LPOLESTR *rgszNames, + UINT cNames, LCID lcid, DISPID *rgDispId) +{ + EventTarget *This = impl_from_IEventTarget(iface); + return IDispatchEx_GetIDsOfNames(&This->dispex.IDispatchEx_iface, riid, + rgszNames, cNames, lcid, rgDispId); +} + +static HRESULT WINAPI EventTarget_Invoke(IEventTarget *iface, DISPID dispIdMember, + REFIID riid, LCID lcid, WORD wFlags, DISPPARAMS *pDispParams, + VARIANT *pVarResult, EXCEPINFO *pExcepInfo, UINT *puArgErr) +{ + EventTarget *This = impl_from_IEventTarget(iface); + return IDispatchEx_Invoke(&This->dispex.IDispatchEx_iface, dispIdMember, + riid, lcid, wFlags, pDispParams, pVarResult, pExcepInfo, puArgErr); +} + +static HRESULT WINAPI EventTarget_addEventListener(IEventTarget *iface, BSTR type, + IDispatch *listener, VARIANT_BOOL capture) +{ + EventTarget *This = impl_from_IEventTarget(iface); + FIXME("(%p)->(%s %p %x)\n", This, debugstr_w(type), listener, capture); + return E_NOTIMPL; +} + +static HRESULT WINAPI EventTarget_removeEventListener(IEventTarget *iface, BSTR type, + IDispatch *listener, VARIANT_BOOL capture) +{ + EventTarget *This = impl_from_IEventTarget(iface); + FIXME("(%p)->(%s %p %x)\n", This, debugstr_w(type), listener, capture); + return E_NOTIMPL; +} + +static HRESULT WINAPI EventTarget_dispatchEvent(IEventTarget *iface, IDOMEvent *event, VARIANT_BOOL *result) +{ + EventTarget *This = impl_from_IEventTarget(iface); + FIXME("(%p)->(%p %p)\n", This, event, result); + return E_NOTIMPL; +} + +static const IEventTargetVtbl EventTargetVtbl = { + EventTarget_QueryInterface, + EventTarget_AddRef, + EventTarget_Release, + EventTarget_GetTypeInfoCount, + EventTarget_GetTypeInfo, + EventTarget_GetIDsOfNames, + EventTarget_Invoke, + EventTarget_addEventListener, + EventTarget_removeEventListener, + EventTarget_dispatchEvent +}; + +#define DELAY_INIT_VTBL ((const IEventTargetVtbl*)1) + +static BOOL use_event_quirks(EventTarget *event_target) +{ + if(event_target->IEventTarget_iface.lpVtbl == DELAY_INIT_VTBL) { + event_target->IEventTarget_iface.lpVtbl = + dispex_compat_mode(&event_target->dispex) >= COMPAT_MODE_IE9 + ? &EventTargetVtbl : NULL; + } + return !event_target->IEventTarget_iface.lpVtbl; +} + HRESULT EventTarget_QI(EventTarget *event_target, REFIID riid, void **ppv) { + if(IsEqualGUID(riid, &IID_IEventTarget)) { + if(use_event_quirks(event_target)) { + WARN("IEventTarget queried, but not supported by in document mode\n"); + *ppv = NULL; + return E_NOINTERFACE; + } + IEventTarget_AddRef(&event_target->IEventTarget_iface); + *ppv = &event_target->IEventTarget_iface; + return S_OK; + } + if(dispex_query_interface(&event_target->dispex, riid, ppv)) return *ppv ? S_OK : E_NOINTERFACE; @@ -1658,6 +1770,20 @@ void EventTarget_Init(EventTarget *event_target, IUnknown *outer, dispex_static_ { init_dispex_with_compat_mode(&event_target->dispex, outer, dispex_data, compat_mode); wine_rb_init(&event_target->handler_map, event_id_cmp); + + /* + * IEventTarget is supported by the object or not depending on compatibility mode. + * We use NULL vtbl for objects in compatibility mode not supporting the interface. + * For targets that don't know compatibility mode at creation time, we set vtbl + * to special DELAY_INIT_VTBL value so that vtbl will be set to proper value + * when it's needed. + */ + if(compat_mode == COMPAT_MODE_QUIRKS && dispex_data->vtbl && dispex_data->vtbl->get_compat_mode) + event_target->IEventTarget_iface.lpVtbl = DELAY_INIT_VTBL; + else if(compat_mode < COMPAT_MODE_IE9) + event_target->IEventTarget_iface.lpVtbl = NULL; + else + event_target->IEventTarget_iface.lpVtbl = &EventTargetVtbl; } void release_event_target(EventTarget *event_target) diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index f509b43..1727f2c 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -333,6 +333,7 @@ void release_typelib(void) DECLSPEC_HIDDEN; HRESULT get_class_typeinfo(const CLSID*,ITypeInfo**) DECLSPEC_HIDDEN; const dispex_static_data_vtbl_t *dispex_get_vtbl(DispatchEx*) DECLSPEC_HIDDEN; void dispex_info_add_interface(dispex_data_t*,tid_t,const DISPID*) DECLSPEC_HIDDEN; +compat_mode_t dispex_compat_mode(DispatchEx*) DECLSPEC_HIDDEN; static inline void init_dispex(DispatchEx *dispex, IUnknown *outer, dispex_static_data_t *desc) { @@ -379,6 +380,7 @@ typedef struct { struct EventTarget { DispatchEx dispex; + IEventTarget IEventTarget_iface; struct wine_rb_tree handler_map; }; diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index d7cfedd..0ce4872 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -10582,7 +10582,10 @@ static float expected_document_mode; static void test_document_mode(IHTMLDocument2 *doc2) { + IEventTarget *event_target; + IHTMLDocument2 *doc_node; IHTMLDocument6 *doc; + IHTMLElement *body; VARIANT v; HRESULT hres; @@ -10605,6 +10608,31 @@ static void test_document_mode(IHTMLDocument2 *doc2) ok(V_VT(&v) == VT_R4, "V_VT(documentMode) = %u\n", V_VT(&v)); ok(V_R4(&v) == expected_document_mode, "documentMode = %f\n", V_R4(&v)); IHTMLDocument6_Release(doc); + + doc_node = get_doc_node(doc2); + + hres = IHTMLDocument2_QueryInterface(doc_node, &IID_IEventTarget, (void**)&event_target); + if(expected_document_mode >= 9) { + ok(hres == S_OK, "Could not get IEventTarget interface: %08x\n", hres); + IEventTarget_Release(event_target); + }else { + ok(hres == E_NOINTERFACE, "QI(IEventTarget) returned %08x\n", hres); + } + + IHTMLDocument2_Release(doc_node); + + + body = doc_get_body(doc2); + + hres = IHTMLElement_QueryInterface(body, &IID_IEventTarget, (void**)&event_target); + if(expected_document_mode >= 9) { + ok(hres == S_OK, "Could not get IEventTarget interface: %08x\n", hres); + IEventTarget_Release(event_target); + }else { + ok(hres == E_NOINTERFACE, "QI(IEventTarget) returned %08x\n", hres); + } + + IHTMLElement_Release(body); } static void test_quirks_mode(void)
1
0
0
0
Jacek Caban : mshtml: Introduce EventTarget_QI.
by Alexandre Julliard
22 Sep '17
22 Sep '17
Module: wine Branch: master Commit: 632d897c1035d0ec98b2aaaf45f19f9cd26f1515 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=632d897c1035d0ec98b2aaaf4…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Sep 21 23:25:36 2017 +0200 mshtml: Introduce EventTarget_QI. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/htmlevent.c | 10 ++++++++++ dlls/mshtml/htmlnode.c | 6 +----- dlls/mshtml/htmlwindow.c | 4 +--- dlls/mshtml/mshtml_private.h | 1 + dlls/mshtml/xmlhttprequest.c | 6 +----- 5 files changed, 14 insertions(+), 13 deletions(-) diff --git a/dlls/mshtml/htmlevent.c b/dlls/mshtml/htmlevent.c index c47b71d..0061384 100644 --- a/dlls/mshtml/htmlevent.c +++ b/dlls/mshtml/htmlevent.c @@ -1638,6 +1638,16 @@ HRESULT doc_init_events(HTMLDocumentNode *doc) return S_OK; } +HRESULT EventTarget_QI(EventTarget *event_target, REFIID riid, void **ppv) +{ + if(dispex_query_interface(&event_target->dispex, riid, ppv)) + return *ppv ? S_OK : E_NOINTERFACE; + + WARN("(%p)->(%s %p)\n", event_target, debugstr_mshtml_guid(riid), ppv); + *ppv = NULL; + return E_NOINTERFACE; +} + static int event_id_cmp(const void *key, const struct wine_rb_entry *entry) { return (INT_PTR)key - WINE_RB_ENTRY_VALUE(entry, handler_vector_t, entry)->event_id; diff --git a/dlls/mshtml/htmlnode.c b/dlls/mshtml/htmlnode.c index 730e2a8..8f03b4a 100644 --- a/dlls/mshtml/htmlnode.c +++ b/dlls/mshtml/htmlnode.c @@ -1399,12 +1399,8 @@ HRESULT HTMLDOMNode_QI(HTMLDOMNode *This, REFIID riid, void **ppv) }else if(IsEqualGUID(&IID_nsCycleCollectionISupports, riid)) { *ppv = &This->IHTMLDOMNode_iface; return S_OK; - }else if(dispex_query_interface(&This->event_target.dispex, riid, ppv)) { - return *ppv ? S_OK : E_NOINTERFACE; }else { - *ppv = NULL; - WARN("(%p)->(%s %p)\n", This, debugstr_mshtml_guid(riid), ppv); - return E_NOINTERFACE; + return EventTarget_QI(&This->event_target, riid, ppv); } IUnknown_AddRef((IUnknown*)*ppv); diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c index f61aa91..6dd66f2 100644 --- a/dlls/mshtml/htmlwindow.c +++ b/dlls/mshtml/htmlwindow.c @@ -198,9 +198,7 @@ static HRESULT WINAPI HTMLWindow2_QueryInterface(IHTMLWindow2 *iface, REFIID rii assert(!*ppv); return E_NOINTERFACE; }else { - *ppv = NULL; - WARN("(%p)->(%s %p)\n", This, debugstr_mshtml_guid(riid), ppv); - return E_NOINTERFACE; + return EventTarget_QI(&This->inner_window->event_target, riid, ppv); } IUnknown_AddRef((IUnknown*)*ppv); diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index 5d46317..f509b43 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -1041,6 +1041,7 @@ void HTMLTextContainer_Init(HTMLTextContainer*,HTMLDocumentNode*,nsIDOMHTMLEleme void HTMLFrameBase_Init(HTMLFrameBase*,HTMLDocumentNode*,nsIDOMHTMLElement*,dispex_static_data_t*) DECLSPEC_HIDDEN; void EventTarget_Init(EventTarget*,IUnknown*,dispex_static_data_t*,compat_mode_t) DECLSPEC_HIDDEN; +HRESULT EventTarget_QI(EventTarget*,REFIID,void**) DECLSPEC_HIDDEN; HRESULT HTMLDOMNode_QI(HTMLDOMNode*,REFIID,void**) DECLSPEC_HIDDEN; void HTMLDOMNode_destructor(HTMLDOMNode*) DECLSPEC_HIDDEN; diff --git a/dlls/mshtml/xmlhttprequest.c b/dlls/mshtml/xmlhttprequest.c index e257bbc..7e2da4b 100644 --- a/dlls/mshtml/xmlhttprequest.c +++ b/dlls/mshtml/xmlhttprequest.c @@ -223,12 +223,8 @@ static HRESULT WINAPI HTMLXMLHttpRequest_QueryInterface(IHTMLXMLHttpRequest *ifa *ppv = &This->IProvideClassInfo2_iface; }else if(IsEqualGUID(&IID_IProvideClassInfo2, riid)) { *ppv = &This->IProvideClassInfo2_iface; - }else if(dispex_query_interface(&This->event_target.dispex, riid, ppv)) { - return *ppv ? S_OK : E_NOINTERFACE; }else { - *ppv = NULL; - WARN("(%p)->(%s %p)\n", This, debugstr_mshtml_guid(riid), ppv); - return E_NOINTERFACE; + return EventTarget_QI(&This->event_target, riid, ppv); } IUnknown_AddRef((IUnknown*)*ppv);
1
0
0
0
Jacek Caban : mshtml: Introduce EventTarget_Init.
by Alexandre Julliard
22 Sep '17
22 Sep '17
Module: wine Branch: master Commit: d69f1f01e59385ffc04d29febccea75a7ce6e0b1 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=d69f1f01e59385ffc04d29feb…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Sep 21 23:25:27 2017 +0200 mshtml: Introduce EventTarget_Init. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/htmlevent.c | 4 +++- dlls/mshtml/htmlevent.h | 1 - dlls/mshtml/htmlnode.c | 4 +--- dlls/mshtml/htmlwindow.c | 4 ++-- dlls/mshtml/mshtml_private.h | 2 ++ dlls/mshtml/xmlhttprequest.c | 5 ++--- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/dlls/mshtml/htmlevent.c b/dlls/mshtml/htmlevent.c index 40f26de..c47b71d 100644 --- a/dlls/mshtml/htmlevent.c +++ b/dlls/mshtml/htmlevent.c @@ -1643,8 +1643,10 @@ static int event_id_cmp(const void *key, const struct wine_rb_entry *entry) return (INT_PTR)key - WINE_RB_ENTRY_VALUE(entry, handler_vector_t, entry)->event_id; } -void init_event_target(EventTarget *event_target) +void EventTarget_Init(EventTarget *event_target, IUnknown *outer, dispex_static_data_t *dispex_data, + compat_mode_t compat_mode) { + init_dispex_with_compat_mode(&event_target->dispex, outer, dispex_data, compat_mode); wine_rb_init(&event_target->handler_map, event_id_cmp); } diff --git a/dlls/mshtml/htmlevent.h b/dlls/mshtml/htmlevent.h index b88f32f3..c47f20f 100644 --- a/dlls/mshtml/htmlevent.h +++ b/dlls/mshtml/htmlevent.h @@ -57,7 +57,6 @@ typedef enum { eventid_t str_to_eid(LPCWSTR) DECLSPEC_HIDDEN; void check_event_attr(HTMLDocumentNode*,nsIDOMHTMLElement*) DECLSPEC_HIDDEN; -void init_event_target(EventTarget*) DECLSPEC_HIDDEN; void release_event_target(EventTarget*) DECLSPEC_HIDDEN; void fire_event(HTMLDocumentNode*,eventid_t,BOOL,HTMLDOMNode*,nsIDOMEvent*,IDispatch*) DECLSPEC_HIDDEN; HRESULT set_event_handler(EventTarget*,eventid_t,VARIANT*) DECLSPEC_HIDDEN; diff --git a/dlls/mshtml/htmlnode.c b/dlls/mshtml/htmlnode.c index e90f4e3..730e2a8 100644 --- a/dlls/mshtml/htmlnode.c +++ b/dlls/mshtml/htmlnode.c @@ -1450,9 +1450,7 @@ void HTMLDOMNode_Init(HTMLDocumentNode *doc, HTMLDOMNode *node, nsIDOMNode *nsno node->IHTMLDOMNode3_iface.lpVtbl = &HTMLDOMNode3Vtbl; ccref_init(&node->ccref, 1); - init_dispex_with_compat_mode(&node->event_target.dispex, (IUnknown*)&node->IHTMLDOMNode_iface, - dispex_data, doc->document_mode); - init_event_target(&node->event_target); + EventTarget_Init(&node->event_target, (IUnknown*)&node->IHTMLDOMNode_iface, dispex_data, doc->document_mode); if(&doc->node != node) htmldoc_addref(&doc->basedoc); diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c index dc18f84..f61aa91 100644 --- a/dlls/mshtml/htmlwindow.c +++ b/dlls/mshtml/htmlwindow.c @@ -3078,8 +3078,8 @@ static HRESULT create_inner_window(HTMLOuterWindow *outer_window, IMoniker *mon, window->base.outer_window = outer_window; window->base.inner_window = window; - init_event_target(&window->event_target); - init_dispex(&window->event_target.dispex, (IUnknown*)&window->base.IHTMLWindow2_iface, &HTMLWindow_dispex); + EventTarget_Init(&window->event_target, (IUnknown*)&window->base.IHTMLWindow2_iface, + &HTMLWindow_dispex, COMPAT_MODE_NONE); window->task_magic = get_task_target_magic(); diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index 45bf98c..5d46317 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -1040,6 +1040,8 @@ void HTMLElement_Init(HTMLElement*,HTMLDocumentNode*,nsIDOMHTMLElement*,dispex_s void HTMLTextContainer_Init(HTMLTextContainer*,HTMLDocumentNode*,nsIDOMHTMLElement*,dispex_static_data_t*) DECLSPEC_HIDDEN; void HTMLFrameBase_Init(HTMLFrameBase*,HTMLDocumentNode*,nsIDOMHTMLElement*,dispex_static_data_t*) DECLSPEC_HIDDEN; +void EventTarget_Init(EventTarget*,IUnknown*,dispex_static_data_t*,compat_mode_t) DECLSPEC_HIDDEN; + HRESULT HTMLDOMNode_QI(HTMLDOMNode*,REFIID,void**) DECLSPEC_HIDDEN; void HTMLDOMNode_destructor(HTMLDOMNode*) DECLSPEC_HIDDEN; void HTMLDOMNode_init_dispex_info(dispex_data_t*,compat_mode_t) DECLSPEC_HIDDEN; diff --git a/dlls/mshtml/xmlhttprequest.c b/dlls/mshtml/xmlhttprequest.c index 35e91fc..e257bbc 100644 --- a/dlls/mshtml/xmlhttprequest.c +++ b/dlls/mshtml/xmlhttprequest.c @@ -901,9 +901,8 @@ static HRESULT WINAPI HTMLXMLHttpRequestFactory_create(IHTMLXMLHttpRequestFactor ret->IHTMLXMLHttpRequest_iface.lpVtbl = &HTMLXMLHttpRequestVtbl; ret->IProvideClassInfo2_iface.lpVtbl = &ProvideClassInfo2Vtbl; - init_event_target(&ret->event_target); - init_dispex(&ret->event_target.dispex, (IUnknown*)&ret->IHTMLXMLHttpRequest_iface, - &HTMLXMLHttpRequest_dispex); + EventTarget_Init(&ret->event_target, (IUnknown*)&ret->IHTMLXMLHttpRequest_iface, + &HTMLXMLHttpRequest_dispex, COMPAT_MODE_NONE); ret->ref = 1; *p = &ret->IHTMLXMLHttpRequest_iface;
1
0
0
0
Jacek Caban : mshtml: Initialize DispatchEx in HTMLDOMNode_Init.
by Alexandre Julliard
22 Sep '17
22 Sep '17
Module: wine Branch: master Commit: 1b09514c820228bc6414e2d8d26574c37c19c1ac URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1b09514c820228bc6414e2d8d…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Sep 21 23:25:17 2017 +0200 mshtml: Initialize DispatchEx in HTMLDOMNode_Init. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/htmlcomment.c | 2 +- dlls/mshtml/htmldoc.c | 6 ++---- dlls/mshtml/htmlelem.c | 4 +--- dlls/mshtml/htmlnode.c | 19 +++++++++++++++++-- dlls/mshtml/htmltextnode.c | 5 +---- dlls/mshtml/mshtml_private.h | 2 +- 6 files changed, 23 insertions(+), 15 deletions(-) diff --git a/dlls/mshtml/htmlcomment.c b/dlls/mshtml/htmlcomment.c index ed6a740..85eceef 100644 --- a/dlls/mshtml/htmlcomment.c +++ b/dlls/mshtml/htmlcomment.c @@ -217,7 +217,7 @@ HRESULT HTMLCommentElement_Create(HTMLDocumentNode *doc, nsIDOMNode *nsnode, HTM ret->IHTMLCommentElement_iface.lpVtbl = &HTMLCommentElementVtbl; HTMLElement_Init(&ret->element, doc, NULL, &HTMLCommentElement_dispex); - HTMLDOMNode_Init(doc, &ret->element.node, nsnode); + HTMLDOMNode_Init(doc, &ret->element.node, nsnode, &HTMLCommentElement_dispex); *elem = &ret->element; return S_OK; diff --git a/dlls/mshtml/htmldoc.c b/dlls/mshtml/htmldoc.c index 0a2d243..f4ff2f7 100644 --- a/dlls/mshtml/htmldoc.c +++ b/dlls/mshtml/htmldoc.c @@ -5025,8 +5025,6 @@ static HTMLDocumentNode *alloc_doc_node(HTMLDocumentObj *doc_obj, HTMLInnerWindo doc->basedoc.window = window->base.outer_window; doc->window = window; - init_dispex(&doc->node.event_target.dispex, (IUnknown*)&doc->node.IHTMLDOMNode_iface, - &HTMLDocumentNode_dispex); init_doc(&doc->basedoc, (IUnknown*)&doc->node.IHTMLDOMNode_iface, &doc->node.event_target.dispex.IDispatchEx_iface); HTMLDocumentNode_SecMgr_Init(doc); @@ -5049,7 +5047,7 @@ HRESULT create_doc_from_nsdoc(nsIDOMHTMLDocument *nsdoc, HTMLDocumentObj *doc_ob if(!doc_obj->basedoc.window || window->base.outer_window == doc_obj->basedoc.window) doc->basedoc.cp_container.forward_container = &doc_obj->basedoc.cp_container; - HTMLDOMNode_Init(doc, &doc->node, (nsIDOMNode*)nsdoc); + HTMLDOMNode_Init(doc, &doc->node, (nsIDOMNode*)nsdoc, &HTMLDocumentNode_dispex); nsIDOMHTMLDocument_AddRef(nsdoc); doc->nsdoc = nsdoc; @@ -5074,7 +5072,7 @@ static HRESULT create_document_fragment(nsIDOMNode *nsnode, HTMLDocumentNode *do IHTMLWindow2_AddRef(&doc_frag->window->base.IHTMLWindow2_iface); - HTMLDOMNode_Init(doc_node, &doc_frag->node, nsnode); + HTMLDOMNode_Init(doc_node, &doc_frag->node, nsnode, &HTMLDocumentNode_dispex); doc_frag->node.vtbl = &HTMLDocumentFragmentImplVtbl; doc_frag->node.cp_container = &doc_frag->basedoc.cp_container; diff --git a/dlls/mshtml/htmlelem.c b/dlls/mshtml/htmlelem.c index a87bdf0..ea65042 100644 --- a/dlls/mshtml/htmlelem.c +++ b/dlls/mshtml/htmlelem.c @@ -5396,11 +5396,9 @@ void HTMLElement_Init(HTMLElement *This, HTMLDocumentNode *doc, nsIDOMHTMLElemen if(dispex_data && !dispex_data->vtbl) dispex_data->vtbl = &HTMLElement_dispex_vtbl; - init_dispex_with_compat_mode(&This->node.event_target.dispex, (IUnknown*)&This->IHTMLElement_iface, - dispex_data ? dispex_data : &HTMLElement_dispex, doc->document_mode); if(nselem) { - HTMLDOMNode_Init(doc, &This->node, (nsIDOMNode*)nselem); + HTMLDOMNode_Init(doc, &This->node, (nsIDOMNode*)nselem, dispex_data ? dispex_data : &HTMLElement_dispex); /* No AddRef, share reference with HTMLDOMNode */ assert((nsIDOMNode*)nselem == This->node.nsnode); diff --git a/dlls/mshtml/htmlnode.c b/dlls/mshtml/htmlnode.c index 80bf31d..e90f4e3 100644 --- a/dlls/mshtml/htmlnode.c +++ b/dlls/mshtml/htmlnode.c @@ -1441,7 +1441,7 @@ static const NodeImplVtbl HTMLDOMNodeImplVtbl = { HTMLDOMNode_clone }; -void HTMLDOMNode_Init(HTMLDocumentNode *doc, HTMLDOMNode *node, nsIDOMNode *nsnode) +void HTMLDOMNode_Init(HTMLDocumentNode *doc, HTMLDOMNode *node, nsIDOMNode *nsnode, dispex_static_data_t *dispex_data) { nsresult nsres; @@ -1450,6 +1450,8 @@ void HTMLDOMNode_Init(HTMLDocumentNode *doc, HTMLDOMNode *node, nsIDOMNode *nsno node->IHTMLDOMNode3_iface.lpVtbl = &HTMLDOMNode3Vtbl; ccref_init(&node->ccref, 1); + init_dispex_with_compat_mode(&node->event_target.dispex, (IUnknown*)&node->IHTMLDOMNode_iface, + dispex_data, doc->document_mode); init_event_target(&node->event_target); if(&doc->node != node) @@ -1463,6 +1465,17 @@ void HTMLDOMNode_Init(HTMLDocumentNode *doc, HTMLDOMNode *node, nsIDOMNode *nsno assert(nsres == NS_OK); } +static const tid_t HTMLDOMNode_iface_tids[] = { + IHTMLDOMNode_tid, + 0 +}; +static dispex_static_data_t HTMLDOMNode_dispex = { + NULL, + IHTMLDOMNode_tid, + HTMLDOMNode_iface_tids, + HTMLDOMNode_init_dispex_info +}; + static HRESULT create_node(HTMLDocumentNode *doc, nsIDOMNode *nsnode, HTMLDOMNode **ret) { UINT16 node_type; @@ -1500,12 +1513,14 @@ static HRESULT create_node(HTMLDocumentNode *doc, nsIDOMNode *nsnode, HTMLDOMNod default: { HTMLDOMNode *node; + FIXME("unimplemented node type %u\n", node_type); + node = heap_alloc_zero(sizeof(HTMLDOMNode)); if(!node) return E_OUTOFMEMORY; node->vtbl = &HTMLDOMNodeImplVtbl; - HTMLDOMNode_Init(doc, node, nsnode); + HTMLDOMNode_Init(doc, node, nsnode, &HTMLDOMNode_dispex); *ret = node; } } diff --git a/dlls/mshtml/htmltextnode.c b/dlls/mshtml/htmltextnode.c index a5587c1..f9d7eec 100644 --- a/dlls/mshtml/htmltextnode.c +++ b/dlls/mshtml/htmltextnode.c @@ -378,10 +378,7 @@ HRESULT HTMLDOMTextNode_Create(HTMLDocumentNode *doc, nsIDOMNode *nsnode, HTMLDO ret->IHTMLDOMTextNode_iface.lpVtbl = &HTMLDOMTextNodeVtbl; ret->IHTMLDOMTextNode2_iface.lpVtbl = &HTMLDOMTextNode2Vtbl; - init_dispex_with_compat_mode(&ret->node.event_target.dispex, (IUnknown*)&ret->IHTMLDOMTextNode_iface, - &HTMLDOMTextNode_dispex, doc->document_mode); - - HTMLDOMNode_Init(doc, &ret->node, nsnode); + HTMLDOMNode_Init(doc, &ret->node, nsnode, &HTMLDOMTextNode_dispex); nsres = nsIDOMNode_QueryInterface(nsnode, &IID_nsIDOMText, (void**)&ret->nstext); assert(nsres == NS_OK && (nsIDOMNode*)ret->nstext == ret->node.nsnode); diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index ecd72b8..45bf98c 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -1035,7 +1035,7 @@ HRESULT HTMLTextAreaElement_Create(HTMLDocumentNode*,nsIDOMHTMLElement*,HTMLElem HRESULT HTMLTitleElement_Create(HTMLDocumentNode*,nsIDOMHTMLElement*,HTMLElement**) DECLSPEC_HIDDEN; HRESULT HTMLGenericElement_Create(HTMLDocumentNode*,nsIDOMHTMLElement*,HTMLElement**) DECLSPEC_HIDDEN; -void HTMLDOMNode_Init(HTMLDocumentNode*,HTMLDOMNode*,nsIDOMNode*) DECLSPEC_HIDDEN; +void HTMLDOMNode_Init(HTMLDocumentNode*,HTMLDOMNode*,nsIDOMNode*,dispex_static_data_t*) DECLSPEC_HIDDEN; void HTMLElement_Init(HTMLElement*,HTMLDocumentNode*,nsIDOMHTMLElement*,dispex_static_data_t*) DECLSPEC_HIDDEN; void HTMLTextContainer_Init(HTMLTextContainer*,HTMLDocumentNode*,nsIDOMHTMLElement*,dispex_static_data_t*) DECLSPEC_HIDDEN; void HTMLFrameBase_Init(HTMLFrameBase*,HTMLDocumentNode*,nsIDOMHTMLElement*,dispex_static_data_t*) DECLSPEC_HIDDEN;
1
0
0
0
Ihsan Akmal : include: Add dxgi1_6.idl.
by Alexandre Julliard
22 Sep '17
22 Sep '17
Module: wine Branch: master Commit: 54483fc7966213e44401482176095cae07c50131 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=54483fc7966213e4440148217…
Author: Ihsan Akmal <ihsanapps(a)gmail.com> Date: Thu Sep 21 22:29:38 2017 +0200 include: Add dxgi1_6.idl. Signed-off-by: Ihsan Akmal <ihsanapps(a)gmail.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/Makefile.in | 1 + include/dxgi1_6.idl | 98 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 99 insertions(+) diff --git a/include/Makefile.in b/include/Makefile.in index 04665ef..fd52a5f 100644 --- a/include/Makefile.in +++ b/include/Makefile.in @@ -72,6 +72,7 @@ IDL_SRCS = \ dxgi1_3.idl \ dxgi1_4.idl \ dxgi1_5.idl \ + dxgi1_6.idl \ dxgicommon.idl \ dxgiformat.idl \ dxgitype.idl \ diff --git a/include/dxgi1_6.idl b/include/dxgi1_6.idl new file mode 100644 index 0000000..9dcf9f2 --- /dev/null +++ b/include/dxgi1_6.idl @@ -0,0 +1,98 @@ +/* + * Copyright 2017 Ihsan Akmal + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +import "dxgi1_5.idl"; + +typedef enum DXGI_ADAPTER_FLAG3 +{ + DXGI_ADAPTER_FLAG3_NONE = 0x0, + DXGI_ADAPTER_FLAG3_REMOTE = 0x1, + DXGI_ADAPTER_FLAG3_SOFTWARE = 0x2, + DXGI_ADAPTER_FLAG3_ACG_COMPATIBLE = 0x4, + DXGI_ADAPTER_FLAG3_FORCE_DWORD = 0xffffffff, +} DXGI_ADAPTER_FLAG3; + +typedef enum DXGI_HARDWARE_COMPOSITION_SUPPORT_FLAGS +{ + DXGI_HARDWARE_COMPOSITION_SUPPORT_FLAG_FULLSCREEN = 0x1, + DXGI_HARDWARE_COMPOSITION_SUPPORT_FLAG_WINDOWED = 0x2, + DXGI_HARDWARE_COMPOSITION_SUPPORT_FLAG_CURSOR_STRETCHED = 0x4, +} DXGI_HARDWARE_COMPOSITION_SUPPORT_FLAGS; + +typedef struct DXGI_ADAPTER_DESC3 +{ + WCHAR Description[128]; + UINT VendorId; + UINT DeviceId; + UINT SubSysId; + UINT Revision; + SIZE_T DedicatedVideoMemory; + SIZE_T DedicatedSystemMemory; + SIZE_T SharedSystemMemory; + LUID AdapterLuid; + DXGI_ADAPTER_FLAG3 Flags; + DXGI_GRAPHICS_PREEMPTION_GRANULARITY GraphicsPreemptionGranularity; + DXGI_COMPUTE_PREEMPTION_GRANULARITY ComputePreemptionGranularity; +} DXGI_ADAPTER_DESC3; + +typedef struct DXGI_OUTPUT_DESC1 +{ + WCHAR DeviceName[32]; + RECT DesktopCoordinates; + BOOL AttachedToDesktop; + DXGI_MODE_ROTATION Rotation; + HMONITOR Monitor; + UINT BitsPerColor; + DXGI_COLOR_SPACE_TYPE ColorSpace; + FLOAT RedPrimary[2]; + FLOAT GreenPrimary[2]; + FLOAT BluePrimary[2]; + FLOAT WhitePoint[2]; + FLOAT MinLuminance; + FLOAT MaxLuminance; + FLOAT MaxFullFrameLuminance; +} DXGI_OUTPUT_DESC1; + +[ + object, + uuid(3c8d99d1-4fbf-4181-a82c-af66bf7bd24e), + local, + pointer_default(unique) +] +interface IDXGIAdapter4 : IDXGIAdapter3 +{ + HRESULT GetDesc3( + [out] DXGI_ADAPTER_DESC3 *desc + ); +} + +[ + object, + uuid(068346e8-aaec-4b84-add7-137f513f77a1), + local, + pointer_default(unique) +] +interface IDXGIOutput6 : IDXGIOutput5 +{ + HRESULT GetDesc1( + [out] DXGI_OUTPUT_DESC1 *desc + ); + HRESULT CheckHardwareCompositionSupport( + [out] UINT *flags + ); +}
1
0
0
0
← Newer
1
...
12
13
14
15
16
17
18
...
45
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
Results per page:
10
25
50
100
200