wine-commits November 2018

wine-commits@winehq.org

2 participants
951 discussions

Józef Kucia : tests: Add more tests for mapping resources.
by Alexandre Julliard 13 Nov '18

13 Nov '18

Module: vkd3d Branch: master Commit: bebda782c8ee47de6956e06aa89faef4d0da58c2 URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=bebda782c8ee47de6956e06… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Tue Nov 13 00:23:29 2018 +0100 tests: Add more tests for mapping resources. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- tests/d3d12.c | 36 ++++++++++++++++++++++++++++++++++-- 1 file changed, 34 insertions(+), 2 deletions(-) diff --git a/tests/d3d12.c b/tests/d3d12.c index 1ddf7c2..e98dbfa 100644 --- a/tests/d3d12.c +++ b/tests/d3d12.c @@ -5364,11 +5364,13 @@ static void test_map_resource(void) hr = ID3D12Device_CreateCommittedResource(device, &heap_properties, D3D12_HEAP_FLAG_NONE, &resource_desc, D3D12_RESOURCE_STATE_COMMON, NULL, &IID_ID3D12Resource, (void **)&resource); - ok(SUCCEEDED(hr), "Failed to create texture, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to create texture, hr %#x.\n", hr); /* Resources on a DEFAULT heap cannot be mapped. */ + data = (void *)0xdeadbeef; hr = ID3D12Resource_Map(resource, 0, NULL, &data); ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr); + ok(data == (void *)0xdeadbeef, "Pointer was modified %p.\n", data); ID3D12Resource_Release(resource); @@ -5385,8 +5387,10 @@ static void test_map_resource(void) else { /* The data pointer must be NULL for the UNKNOWN layout. */ + data = (void *)0xdeadbeef; hr = ID3D12Resource_Map(resource, 0, NULL, &data); ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr); + ok(data == (void *)0xdeadbeef, "Pointer was modified %p.\n", data); ID3D12Resource_Release(resource); } @@ -5401,11 +5405,39 @@ static void test_map_resource(void) hr = ID3D12Device_CreateCommittedResource(device, &heap_properties, D3D12_HEAP_FLAG_NONE, &resource_desc, D3D12_RESOURCE_STATE_COMMON, NULL, &IID_ID3D12Resource, (void **)&resource); - ok(SUCCEEDED(hr), "Failed to create committed resource, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to create committed resource, hr %#x.\n", hr); /* Resources on a DEFAULT heap cannot be mapped. */ + data = (void *)0xdeadbeef; + hr = ID3D12Resource_Map(resource, 0, NULL, &data); + ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr); + ok(data == (void *)0xdeadbeef, "Pointer was modified %p.\n", data); + + ID3D12Resource_Release(resource); + + heap_properties.Type = D3D12_HEAP_TYPE_UPLOAD; + hr = ID3D12Device_CreateCommittedResource(device, &heap_properties, D3D12_HEAP_FLAG_NONE, + &resource_desc, D3D12_RESOURCE_STATE_GENERIC_READ, NULL, + &IID_ID3D12Resource, (void **)&resource); + ok(hr == S_OK, "Failed to create committed resource, hr %#x.\n", hr); + + data = NULL; hr = ID3D12Resource_Map(resource, 0, NULL, &data); + ok(hr == S_OK, "Got unexpected hr %#x.\n", hr); + ok(data, "Got NULL pointer.\n"); + ID3D12Resource_Unmap(resource, 0, NULL); + + data = (void *)0xdeadbeef; + hr = ID3D12Resource_Map(resource, 1, NULL, &data); ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr); + ok(data == (void *)0xdeadbeef, "Pointer was modified %p.\n", data); + + data = NULL; + hr = ID3D12Resource_Map(resource, 0, NULL, &data); + ok(hr == S_OK, "Got unexpected hr %#x.\n", hr); + ok(data, "Got NULL pointer.\n"); + ID3D12Resource_Unmap(resource, 1, NULL); + ID3D12Resource_Unmap(resource, 0, NULL); ID3D12Resource_Release(resource);

1 0

Józef Kucia : vkd3d: Validate sub-resource index in d3d12_resource_Unmap().
by Alexandre Julliard 13 Nov '18

13 Nov '18

Module: vkd3d Branch: master Commit: 361e5f627436aad94a12faffe711d5f4df617498 URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=361e5f627436aad94a12faf… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Tue Nov 13 00:23:28 2018 +0100 vkd3d: Validate sub-resource index in d3d12_resource_Unmap(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- libs/vkd3d/resource.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/libs/vkd3d/resource.c b/libs/vkd3d/resource.c index 80e7319..f4619ef 100644 --- a/libs/vkd3d/resource.c +++ b/libs/vkd3d/resource.c @@ -885,11 +885,19 @@ static void STDMETHODCALLTYPE d3d12_resource_Unmap(ID3D12Resource *iface, UINT s const D3D12_RANGE *written_range) { struct d3d12_resource *resource = impl_from_ID3D12Resource(iface); + unsigned int sub_resource_count; struct d3d12_device *device; TRACE("iface %p, sub_resource %u, written_range %p.\n", iface, sub_resource, written_range); + sub_resource_count = d3d12_resource_desc_get_sub_resource_count(&resource->desc); + if (sub_resource >= sub_resource_count) + { + WARN("Sub-resource index %u is out of range (%u sub-resources).\n", sub_resource, sub_resource_count); + return; + } + if (!resource->map_count) { WARN("Resource %p is not mapped.\n", resource);

1 0

Józef Kucia : vkd3d: Validate sub-resource index in d3d12_resource_Map().
by Alexandre Julliard 13 Nov '18

13 Nov '18

Module: vkd3d Branch: master Commit: 91c11eed03d320e8713e0566854d02e47c1cc4f9 URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=91c11eed03d320e8713e056… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Tue Nov 13 00:23:27 2018 +0100 vkd3d: Validate sub-resource index in d3d12_resource_Map(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- libs/vkd3d/resource.c | 8 ++++++++ libs/vkd3d/vkd3d_private.h | 5 +++++ 2 files changed, 13 insertions(+) diff --git a/libs/vkd3d/resource.c b/libs/vkd3d/resource.c index be8bbed..80e7319 100644 --- a/libs/vkd3d/resource.c +++ b/libs/vkd3d/resource.c @@ -811,6 +811,7 @@ static HRESULT STDMETHODCALLTYPE d3d12_resource_Map(ID3D12Resource *iface, UINT const D3D12_RANGE *read_range, void **data) { struct d3d12_resource *resource = impl_from_ID3D12Resource(iface); + unsigned int sub_resource_count; struct d3d12_device *device; VkResult vr; HRESULT hr; @@ -826,6 +827,13 @@ static HRESULT STDMETHODCALLTYPE d3d12_resource_Map(ID3D12Resource *iface, UINT return E_INVALIDARG; } + sub_resource_count = d3d12_resource_desc_get_sub_resource_count(&resource->desc); + if (sub_resource >= sub_resource_count) + { + WARN("Sub-resource index %u is out of range (%u sub-resources).\n", sub_resource, sub_resource_count); + return E_INVALIDARG; + } + if (d3d12_resource_is_texture(resource)) { /* Textures seem to be mappable only on UMA adapters. */ diff --git a/libs/vkd3d/vkd3d_private.h b/libs/vkd3d/vkd3d_private.h index d6c821b..daa60cb 100644 --- a/libs/vkd3d/vkd3d_private.h +++ b/libs/vkd3d/vkd3d_private.h @@ -861,6 +861,11 @@ static inline unsigned int d3d12_resource_desc_get_layer_count(const D3D12_RESOU return desc->Dimension != D3D12_RESOURCE_DIMENSION_TEXTURE3D ? desc->DepthOrArraySize : 1; } +static inline unsigned int d3d12_resource_desc_get_sub_resource_count(const D3D12_RESOURCE_DESC *desc) +{ + return d3d12_resource_desc_get_layer_count(desc) * desc->MipLevels; +} + enum VkCompareOp vk_compare_op_from_d3d12(D3D12_COMPARISON_FUNC op) DECLSPEC_HIDDEN; VkSampleCountFlagBits vk_samples_from_dxgi_sample_desc(const DXGI_SAMPLE_DESC *desc) DECLSPEC_HIDDEN;

1 0

Józef Kucia : vkd3d: Assign "heap" and "heap_offset" in more appropriate places.
by Alexandre Julliard 13 Nov '18

13 Nov '18

Module: vkd3d Branch: master Commit: dc36ab41e3a3cea15694b94f26bfbe0eb192514f URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=dc36ab41e3a3cea15694b94… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Tue Nov 13 00:23:26 2018 +0100 vkd3d: Assign "heap" and "heap_offset" in more appropriate places. Initializes all fields of struct d3d12_resource in d3d12_resource_init(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- libs/vkd3d/resource.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/libs/vkd3d/resource.c b/libs/vkd3d/resource.c index 78101a5..be8bbed 100644 --- a/libs/vkd3d/resource.c +++ b/libs/vkd3d/resource.c @@ -1138,6 +1138,9 @@ static HRESULT d3d12_resource_init(struct d3d12_resource *resource, struct d3d12 resource->heap_flags = heap_flags; resource->initial_state = initial_state; + resource->heap = NULL; + resource->heap_offset = 0; + resource->device = device; ID3D12Device_AddRef(&device->ID3D12Device_iface); @@ -1201,9 +1204,6 @@ HRESULT d3d12_committed_resource_create(struct d3d12_device *device, return hr; } - object->heap = NULL; - object->heap_offset = 0; - TRACE("Created committed resource %p.\n", object); *resource = object; @@ -1243,8 +1243,15 @@ static HRESULT vkd3d_bind_heap_memory(struct d3d12_device *device, else vr = VK_CALL(vkBindImageMemory(vk_device, resource->u.vk_image, heap->vk_memory, heap_offset)); - if (vr < 0) + if (vr == VK_SUCCESS) + { + resource->heap = heap; + resource->heap_offset = heap_offset; + } + else + { WARN("Failed to bind memory, vr %d.\n", vr); + } return hresult_from_vk_result(vr); } @@ -1266,9 +1273,6 @@ HRESULT d3d12_placed_resource_create(struct d3d12_device *device, struct d3d12_h return hr; } - object->heap = heap; - object->heap_offset = heap_offset; - TRACE("Created placed resource %p.\n", object); *resource = object;

1 0

Francois Gouget : testbot: Add support for Wine's PARENTSRC.
by Alexandre Julliard 13 Nov '18

13 Nov '18

Module: tools Branch: master Commit: 27463129bb40d2a17dcbd85a73a68de703677a2c URL: https://source.winehq.org/git/tools.git/?a=commit;h=27463129bb40d2a17dcbd85… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Tue Nov 13 16:43:47 2018 +0100 testbot: Add support for Wine's PARENTSRC. This lets the TestBot take into account that modifying the source in a 'PARENTSRC' module affects the code of other modules. This impacts the time it takes to rebuild Wine and the tests to be rerun with the test=module option. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/WineTestBot/PatchUtils.pm | 29 ++++++++++++++++++++++++----- 1 file changed, 24 insertions(+), 5 deletions(-) diff --git a/testbot/lib/WineTestBot/PatchUtils.pm b/testbot/lib/WineTestBot/PatchUtils.pm index 6009264..f72cef5 100644 --- a/testbot/lib/WineTestBot/PatchUtils.pm +++ b/testbot/lib/WineTestBot/PatchUtils.pm @@ -60,13 +60,14 @@ sub UpdateWineData($) mkdir "$DataDir/latest" if (!-d "$DataDir/latest"); - my $ErrMessage = `cd '$WineDir' && git ls-tree -r --name-only HEAD 2>&1 >'$DataDir/latest/winefiles.txt'`; - return $ErrMessage if ($? != 0); + my $ErrMessage = `cd '$WineDir' && git ls-tree -r --name-only HEAD 2>&1 >'$DataDir/latest/winefiles.txt' && egrep '^PARENTSRC *=' dlls/*/Makefile.in programs/*/Makefile.in >'$DataDir/latest/wine-parentsrc.txt'`; + return $? != 0 ? $ErrMessage : undef; } my $_TimeStamp; my $_WineFiles; my $_TestList; +my $_WineParentDirs; =pod =over 12 @@ -111,6 +112,21 @@ sub _LoadWineFiles() } close($fh); } + + $_WineParentDirs = {}; + $FileName = "$DataDir/latest/wine-parentsrc.txt"; + if (open(my $fh, "<", $FileName)) + { + while (my $Line = <$fh>) + { + if ($Line =~ m~^\w+/([^/]+)/Makefile\.in:PARENTSRC *= *\.\./([^/\s]+)~) + { + my ($Child, $Parent) = ($1, $2); + $_WineParentDirs->{$Parent}->{$Child} = 1; + } + } + close($fh); + } } @@ -212,11 +228,14 @@ sub _HandleFile($$$) } elsif ($FilePath =~ m~^(dlls|programs)/([^/]+)/([^/\s]+)$~) { - my ($Root, $Dir, $File) = ($1, $2, $3); + my ($Root, $PatchedDir, $File) = ($1, $2, $3); - my $Module = _CreateTestInfo($Impacts, $Root, $Dir); + foreach my $Dir ($PatchedDir, keys %{$_WineParentDirs->{$PatchedDir} || {}}) + { + my $Module = _CreateTestInfo($Impacts, $Root, $Dir); + $Impacts->{Tests}->{$Module}->{PatchedModule} = 1; + } $Impacts->{PatchedModules} = 1; - $Impacts->{Tests}->{$Module}->{PatchedModule} = 1; if ($File eq "Makefile.in" and $Change ne "modify") {

1 0

Baruch Rutman : winmm: Attempt only once to load the default joystick driver.
by Alexandre Julliard 12 Nov '18

12 Nov '18

Module: wine Branch: master Commit: ebae298aa4d2711fef35d4ac60c6012438f36d61 URL: https://source.winehq.org/git/wine.git/?a=commit;h=ebae298aa4d2711fef35d4ac… Author: Baruch Rutman <peterooch(a)gmail.com> Date: Fri Nov 9 00:45:19 2018 +0200 winmm: Attempt only once to load the default joystick driver. Signed-off-by: Baruch Rutman <peterooch(a)gmail.com> Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winmm/joystick.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/dlls/winmm/joystick.c b/dlls/winmm/joystick.c index 8a52942..5a12b36 100644 --- a/dlls/winmm/joystick.c +++ b/dlls/winmm/joystick.c @@ -68,12 +68,21 @@ static WINE_JOYSTICK JOY_Sticks[MAXJOYSTICK]; */ static BOOL JOY_LoadDriver(DWORD dwJoyID) { - if (dwJoyID >= MAXJOYSTICK) + static BOOL winejoystick_missing = FALSE; + + if (dwJoyID >= MAXJOYSTICK || winejoystick_missing) return FALSE; if (JOY_Sticks[dwJoyID].hDriver) return TRUE; JOY_Sticks[dwJoyID].hDriver = OpenDriverA("winejoystick.drv", 0, dwJoyID); + + if (!JOY_Sticks[dwJoyID].hDriver) + { + /* The default driver is missing, don't attempt to load it again */ + winejoystick_missing = TRUE; + } + return (JOY_Sticks[dwJoyID].hDriver != 0); }

1 0

Michael Stefaniuc : atl100/tests: Use the ARRAY_SIZE() macro.
by Alexandre Julliard 12 Nov '18

12 Nov '18

Module: wine Branch: master Commit: 0c28ca8d50e02af1fedfec3a171a31b094cd9864 URL: https://source.winehq.org/git/wine.git/?a=commit;h=0c28ca8d50e02af1fedfec3a… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Mon Nov 12 20:29:05 2018 +0100 atl100/tests: Use the ARRAY_SIZE() macro. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/atl100/tests/atl.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/atl100/tests/atl.c b/dlls/atl100/tests/atl.c index eecf079..bdd3c57 100644 --- a/dlls/atl100/tests/atl.c +++ b/dlls/atl100/tests/atl.c @@ -304,8 +304,8 @@ static void test_typelib(void) FreeLibrary(inst); len = SysStringLen(path); - ok(len > sizeof(scrrun_dll_suffixW)/sizeof(WCHAR) - && lstrcmpiW(path+len-sizeof(scrrun_dll_suffixW)/sizeof(WCHAR), scrrun_dll_suffixW), + ok(len > ARRAY_SIZE(scrrun_dll_suffixW) + && lstrcmpiW(path+len-ARRAY_SIZE(scrrun_dll_suffixW), scrrun_dll_suffixW), "unexpected path %s\n", wine_dbgstr_w(path)); SysFreeString(path); ok(typelib != NULL, "typelib == NULL\n"); @@ -320,8 +320,8 @@ static void test_typelib(void) FreeLibrary(inst); len = SysStringLen(path); - ok(len > sizeof(mshtml_tlb_suffixW)/sizeof(WCHAR) - && lstrcmpiW(path+len-sizeof(mshtml_tlb_suffixW)/sizeof(WCHAR), mshtml_tlb_suffixW), + ok(len > ARRAY_SIZE(mshtml_tlb_suffixW) + && lstrcmpiW(path+len-ARRAY_SIZE(mshtml_tlb_suffixW), mshtml_tlb_suffixW), "unexpected path %s\n", wine_dbgstr_w(path)); SysFreeString(path); ok(typelib != NULL, "typelib == NULL\n");

1 0

Michael Stefaniuc : advapi32: Use the ARRAY_SIZE() macro.
by Alexandre Julliard 12 Nov '18

12 Nov '18

Module: wine Branch: master Commit: dc235ab4a7235cf15daf6f5c32d05b2a0c520097 URL: https://source.winehq.org/git/wine.git/?a=commit;h=dc235ab4a7235cf15daf6f5c… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Mon Nov 12 20:29:04 2018 +0100 advapi32: Use the ARRAY_SIZE() macro. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/advapi32/registry.c | 8 ++++---- dlls/advapi32/service.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/dlls/advapi32/registry.c b/dlls/advapi32/registry.c index 9989097..b537f69 100644 --- a/dlls/advapi32/registry.c +++ b/dlls/advapi32/registry.c @@ -108,7 +108,7 @@ static BOOL is_wow6432node( const UNICODE_STRING *name ) static const WCHAR wow6432nodeW[] = {'W','o','w','6','4','3','2','N','o','d','e'}; return (name->Length == sizeof(wow6432nodeW) && - !memicmpW( name->Buffer, wow6432nodeW, sizeof(wow6432nodeW)/sizeof(WCHAR) )); + !memicmpW( name->Buffer, wow6432nodeW, ARRAY_SIZE( wow6432nodeW ))); } /* open the Wow6432Node subkey of the specified key */ @@ -148,9 +148,9 @@ static NTSTATUS create_key( HKEY *retkey, ACCESS_MASK access, OBJECT_ATTRIBUTES UNICODE_STRING str; /* don't try to create registry root */ - if (!attr->RootDirectory && len > sizeof(registry_root)/sizeof(WCHAR) && - !memicmpW( buffer, registry_root, sizeof(registry_root)/sizeof(WCHAR))) - i += sizeof(registry_root)/sizeof(WCHAR); + if (!attr->RootDirectory && len > ARRAY_SIZE( registry_root ) && + !memicmpW( buffer, registry_root, ARRAY_SIZE( registry_root ))) + i += ARRAY_SIZE( registry_root ); while (i < len && buffer[i] != '\\') i++; if (i == len && !force_wow32) return status; diff --git a/dlls/advapi32/service.c b/dlls/advapi32/service.c index 718c964..231f026 100644 --- a/dlls/advapi32/service.c +++ b/dlls/advapi32/service.c @@ -299,7 +299,7 @@ static LPWSTR service_get_pipe_name(void) RegCloseKey(service_current_key); if (ret != ERROR_SUCCESS || type != REG_DWORD) return NULL; - len = sizeof(format)/sizeof(WCHAR) + 10 /* strlenW("4294967295") */; + len = ARRAY_SIZE(format) + 10 /* strlenW("4294967295") */; name = heap_alloc(len * sizeof(WCHAR)); if (!name) return NULL;

1 0

Daniel Lehman : msvcrt/tests: Remove unused todo field.
by Alexandre Julliard 12 Nov '18

12 Nov '18

Module: wine Branch: master Commit: ed712a96a45a912ffc5bca17ac0c8fc7106cf120 URL: https://source.winehq.org/git/wine.git/?a=commit;h=ed712a96a45a912ffc5bca17… Author: Daniel Lehman <dlehman25(a)gmail.com> Date: Sun Nov 11 16:43:14 2018 -0800 msvcrt/tests: Remove unused todo field. Signed-off-by: Daniel Lehman <dlehman25(a)gmail.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcrt/tests/string.c | 1 - 1 file changed, 1 deletion(-) diff --git a/dlls/msvcrt/tests/string.c b/dlls/msvcrt/tests/string.c index d0988bf..0568bcf 100644 --- a/dlls/msvcrt/tests/string.c +++ b/dlls/msvcrt/tests/string.c @@ -3493,7 +3493,6 @@ static void test__tcsnicoll(void) const char *str2; size_t count; int exp; - BOOL todo; }; static const struct test tests[] = { { "English", "abcd", "ABCD", 4, 0 },

1 0

Józef Kucia : ddraw: Do not use unset viewport in viewport_activate().
by Alexandre Julliard 12 Nov '18

12 Nov '18

Module: wine Branch: master Commit: ecad1995a0c13ec39673412adcc6f05e47ea51bc URL: https://source.winehq.org/git/wine.git/?a=commit;h=ecad1995a0c13ec39673412a… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Mon Nov 12 15:13:06 2018 +0100 ddraw: Do not use unset viewport in viewport_activate(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ddraw/viewport.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/dlls/ddraw/viewport.c b/dlls/ddraw/viewport.c index 8cc60f1..e6f8621 100644 --- a/dlls/ddraw/viewport.c +++ b/dlls/ddraw/viewport.c @@ -68,6 +68,12 @@ void viewport_activate(struct d3d_viewport *This, BOOL ignore_lights) } } + if (This->version == DDRAW_VIEWPORT_VERSION_NONE) + { + TRACE("Viewport data was not set.\n"); + return; + } + /* And copy the values in the structure used by the device */ if (This->version == DDRAW_VIEWPORT_VERSION_2) {

1 0

← Newer
1
...
69
70
71
72
73
74
75
...
96
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits November 2018