wine-commits April 2018

wine-commits@winehq.org

2 participants
542 discussions

Dmitry Timoshkov : mstask: Implement ITask::GetTrigger().
by Alexandre Julliard 24 Apr '18

24 Apr '18

Module: wine Branch: master Commit: 0ad429aff6fc24230decb99bd3334f65d9a15e73 URL: https://source.winehq.org/git/wine.git/?a=commit;h=0ad429aff6fc24230decb99b… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Tue Apr 24 16:13:58 2018 +0800 mstask: Implement ITask::GetTrigger(). Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mstask/task.c | 23 +++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/dlls/mstask/task.c b/dlls/mstask/task.c index 2525a1a..8c9d479 100644 --- a/dlls/mstask/task.c +++ b/dlls/mstask/task.c @@ -198,13 +198,24 @@ static HRESULT WINAPI MSTASK_ITask_GetTriggerCount(ITask *iface, WORD *count) return S_OK; } -static HRESULT WINAPI MSTASK_ITask_GetTrigger( - ITask* iface, - WORD iTrigger, - ITaskTrigger **ppTrigger) +static HRESULT WINAPI MSTASK_ITask_GetTrigger(ITask *iface, WORD idx, ITaskTrigger **trigger) { - FIXME("(%p, %d, %p): stub\n", iface, iTrigger, ppTrigger); - return E_NOTIMPL; + TaskImpl *This = impl_from_ITask(iface); + HRESULT hr; + + TRACE("(%p, %u, %p)\n", iface, idx, trigger); + + if (idx >= This->trigger_count) + return SCHED_E_TRIGGER_NOT_FOUND; + + hr = TaskTriggerConstructor((void **)trigger); + if (hr != S_OK) return hr; + + hr = ITaskTrigger_SetTrigger(*trigger, &This->trigger[idx]); + if (hr != S_OK) + ITaskTrigger_Release(*trigger); + + return hr; } static HRESULT WINAPI MSTASK_ITask_GetTriggerString(

1 0

Dmitry Timoshkov : mstask: Implement ITask::DeleteTrigger().
by Alexandre Julliard 24 Apr '18

24 Apr '18

Module: wine Branch: master Commit: 0049deca7a1146b5ba88fd3947d4c9ee03d57887 URL: https://source.winehq.org/git/wine.git/?a=commit;h=0049deca7a1146b5ba88fd39… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Tue Apr 24 16:13:51 2018 +0800 mstask: Implement ITask::DeleteTrigger(). Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mstask/task.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/dlls/mstask/task.c b/dlls/mstask/task.c index 199049d..2525a1a 100644 --- a/dlls/mstask/task.c +++ b/dlls/mstask/task.c @@ -171,12 +171,21 @@ static HRESULT WINAPI MSTASK_ITask_CreateTrigger(ITask *iface, WORD *idx, ITaskT return hr; } -static HRESULT WINAPI MSTASK_ITask_DeleteTrigger( - ITask* iface, - WORD iTrigger) +static HRESULT WINAPI MSTASK_ITask_DeleteTrigger(ITask *iface, WORD idx) { - FIXME("(%p, %d): stub\n", iface, iTrigger); - return E_NOTIMPL; + TaskImpl *This = impl_from_ITask(iface); + + TRACE("(%p, %u)\n", iface, idx); + + if (idx >= This->trigger_count) + return SCHED_E_TRIGGER_NOT_FOUND; + + This->trigger_count--; + memmove(&This->trigger[idx], &This->trigger[idx + 1], (This->trigger_count - idx) * sizeof(This->trigger[0])); + /* this shouldn't fail in practice since we're shrinking the memory block */ + This->trigger = heap_realloc(This->trigger, sizeof(This->trigger[0]) * This->trigger_count); + + return S_OK; } static HRESULT WINAPI MSTASK_ITask_GetTriggerCount(ITask *iface, WORD *count)

1 0

Dmitry Timoshkov : mstask: Implement ITask::CreateTrigger().
by Alexandre Julliard 24 Apr '18

24 Apr '18

Module: wine Branch: master Commit: bcb50e2d12f8f13f020226a312ebd288152b9f1e URL: https://source.winehq.org/git/wine.git/?a=commit;h=bcb50e2d12f8f13f020226a3… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Tue Apr 24 16:13:47 2018 +0800 mstask: Implement ITask::CreateTrigger(). Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mstask/task.c | 36 ++++++++++++++++++++++++++++++------ 1 file changed, 30 insertions(+), 6 deletions(-) diff --git a/dlls/mstask/task.c b/dlls/mstask/task.c index cf41727..199049d 100644 --- a/dlls/mstask/task.c +++ b/dlls/mstask/task.c @@ -63,6 +63,7 @@ typedef struct DWORD priority, maxRunTime; LPWSTR accountName; DWORD trigger_count; + TASK_TRIGGER *trigger; } TaskImpl; static inline TaskImpl *impl_from_ITask(ITask *iface) @@ -83,6 +84,7 @@ static void TaskDestructor(TaskImpl *This) ITaskDefinition_Release(This->task); HeapFree(GetProcessHeap(), 0, This->task_name); HeapFree(GetProcessHeap(), 0, This->accountName); + HeapFree(GetProcessHeap(), 0, This->trigger); HeapFree(GetProcessHeap(), 0, This); InterlockedDecrement(&dll_ref); } @@ -139,13 +141,34 @@ static ULONG WINAPI MSTASK_ITask_Release( return ref; } -static HRESULT WINAPI MSTASK_ITask_CreateTrigger( - ITask* iface, - WORD *piNewTrigger, - ITaskTrigger **ppTrigger) +static HRESULT WINAPI MSTASK_ITask_CreateTrigger(ITask *iface, WORD *idx, ITaskTrigger **task_trigger) { - TRACE("(%p, %p, %p)\n", iface, piNewTrigger, ppTrigger); - return TaskTriggerConstructor((LPVOID *)ppTrigger); + TaskImpl *This = impl_from_ITask(iface); + TASK_TRIGGER *new_trigger; + HRESULT hr; + + TRACE("(%p, %p, %p)\n", iface, idx, task_trigger); + + hr = TaskTriggerConstructor((void **)task_trigger); + if (hr != S_OK) return hr; + + if (This->trigger) + new_trigger = heap_realloc(This->trigger, sizeof(This->trigger[0]) * (This->trigger_count + 1)); + else + new_trigger = heap_alloc(sizeof(This->trigger[0])); + if (!new_trigger) + { + ITaskTrigger_Release(*task_trigger); + return E_OUTOFMEMORY; + } + + This->trigger = new_trigger; + + hr = ITaskTrigger_GetTrigger(*task_trigger, &This->trigger[This->trigger_count]); + if (hr == S_OK) + *idx = This->trigger_count++; + + return hr; } static HRESULT WINAPI MSTASK_ITask_DeleteTrigger( @@ -1135,6 +1158,7 @@ HRESULT TaskConstructor(ITaskService *service, const WCHAR *name, ITask **task) This->priority = NORMAL_PRIORITY_CLASS; This->accountName = NULL; This->trigger_count = 0; + This->trigger = NULL; /* Default time is 3 days = 259200000 ms */ This->maxRunTime = 259200000;

1 0

Dmitry Timoshkov : mstask: Implement ITask::GetTriggerCount().
by Alexandre Julliard 24 Apr '18

24 Apr '18

Module: wine Branch: master Commit: 90160bd65d28af5f8c355a62c1e2966481727ebc URL: https://source.winehq.org/git/wine.git/?a=commit;h=90160bd65d28af5f8c355a62… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Tue Apr 24 16:13:43 2018 +0800 mstask: Implement ITask::GetTriggerCount(). Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mstask/task.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/dlls/mstask/task.c b/dlls/mstask/task.c index f74d439..cf41727 100644 --- a/dlls/mstask/task.c +++ b/dlls/mstask/task.c @@ -62,6 +62,7 @@ typedef struct WORD idle_minutes, deadline_minutes; DWORD priority, maxRunTime; LPWSTR accountName; + DWORD trigger_count; } TaskImpl; static inline TaskImpl *impl_from_ITask(ITask *iface) @@ -155,12 +156,14 @@ static HRESULT WINAPI MSTASK_ITask_DeleteTrigger( return E_NOTIMPL; } -static HRESULT WINAPI MSTASK_ITask_GetTriggerCount( - ITask* iface, - WORD *plCount) +static HRESULT WINAPI MSTASK_ITask_GetTriggerCount(ITask *iface, WORD *count) { - FIXME("(%p, %p): stub\n", iface, plCount); - return E_NOTIMPL; + TaskImpl *This = impl_from_ITask(iface); + + TRACE("(%p, %p)\n", iface, count); + + *count = This->trigger_count; + return S_OK; } static HRESULT WINAPI MSTASK_ITask_GetTrigger( @@ -1131,6 +1134,7 @@ HRESULT TaskConstructor(ITaskService *service, const WCHAR *name, ITask **task) This->deadline_minutes = 60; This->priority = NORMAL_PRIORITY_CLASS; This->accountName = NULL; + This->trigger_count = 0; /* Default time is 3 days = 259200000 ms */ This->maxRunTime = 259200000;

1 0

Dmitry Timoshkov : mstask: Fix saving the triggers.
by Alexandre Julliard 24 Apr '18

24 Apr '18

Module: wine Branch: master Commit: bdb78491cb11dc24336d7cd0bb2fd08d0ce166bd URL: https://source.winehq.org/git/wine.git/?a=commit;h=bdb78491cb11dc24336d7cd0… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Tue Apr 24 16:13:38 2018 +0800 mstask: Fix saving the triggers. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mstask/task.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/dlls/mstask/task.c b/dlls/mstask/task.c index 58ff601..f74d439 100644 --- a/dlls/mstask/task.c +++ b/dlls/mstask/task.c @@ -980,12 +980,10 @@ static HRESULT WINAPI MSTASK_IPersistFile_Save(IPersistFile *iface, LPCOLESTR ta goto failed; } - /* Trigegrs */ - if (!write_triggers(hfile, task)) - { - hr = HRESULT_FROM_WIN32(GetLastError()); + /* Triggers */ + hr = write_triggers(task, hfile); + if (hr != S_OK) goto failed; - } /* Signature */ if (!write_signature(hfile))

1 0

Dmitry Timoshkov : mstask: Initialize task file name in the task constructor.
by Alexandre Julliard 24 Apr '18

24 Apr '18

Module: wine Branch: master Commit: f997b162303ecee8b32afd46c6ed62d1d357210f URL: https://source.winehq.org/git/wine.git/?a=commit;h=f997b162303ecee8b32afd46… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Tue Apr 24 16:13:31 2018 +0800 mstask: Initialize task file name in the task constructor. IPersistFile::Save() receives full path name. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mstask/task.c | 38 +++++++++++++++++++------------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/dlls/mstask/task.c b/dlls/mstask/task.c index e390aa6..58ff601 100644 --- a/dlls/mstask/task.c +++ b/dlls/mstask/task.c @@ -850,10 +850,8 @@ static BOOL write_unicode_string(HANDLE hfile, const WCHAR *str) return WriteFile(hfile, str, count, &size, NULL); } -static HRESULT WINAPI MSTASK_IPersistFile_Save(IPersistFile *iface, LPCOLESTR name, BOOL remember) +static HRESULT WINAPI MSTASK_IPersistFile_Save(IPersistFile *iface, LPCOLESTR task_name, BOOL remember) { - static const WCHAR tasksW[] = { '\\','T','a','s','k','s','\\',0 }; - static const WCHAR jobW[] = { '.','j','o','b',0 }; static WCHAR authorW[] = { 'W','i','n','e',0 }; static WCHAR commentW[] = { 'C','r','e','a','t','e','d',' ','b','y',' ','W','i','n','e',0 }; FIXDLEN_DATA fixed; @@ -864,25 +862,17 @@ static HRESULT WINAPI MSTASK_IPersistFile_Save(IPersistFile *iface, LPCOLESTR na ITask *task = &This->ITask_iface; LPWSTR appname = NULL, params = NULL, workdir = NULL, creator = NULL, comment = NULL; BYTE *user_data = NULL; - WCHAR task_name[MAX_PATH]; HRESULT hr; - TRACE("(%p, %s, %d)\n", iface, debugstr_w(name), remember); + TRACE("(%p, %s, %d)\n", iface, debugstr_w(task_name), remember); - disposition = name ? CREATE_NEW : OPEN_ALWAYS; + disposition = task_name ? CREATE_NEW : OPEN_ALWAYS; - if (!name) + if (!task_name) { - name = This->task_name; + task_name = This->task_name; remember = FALSE; } - else if (strchrW(name, '.')) - return E_INVALIDARG; - - GetWindowsDirectoryW(task_name, MAX_PATH); - lstrcatW(task_name, tasksW); - lstrcatW(task_name, name); - lstrcatW(task_name, jobW); ITask_GetComment(task, &comment); if (!comment) comment = commentW; @@ -1018,11 +1008,11 @@ failed: CloseHandle(hfile); if (hr != S_OK) - DeleteFileW(name); + DeleteFileW(task_name); else if (remember) { HeapFree(GetProcessHeap(), 0, This->task_name); - This->task_name = heap_strdupW(name); + This->task_name = heap_strdupW(task_name); } return hr; } @@ -1104,14 +1094,24 @@ static const IPersistFileVtbl MSTASK_IPersistFileVtbl = MSTASK_IPersistFile_GetCurFile }; -HRESULT TaskConstructor(ITaskService *service, const WCHAR *task_name, ITask **task) +HRESULT TaskConstructor(ITaskService *service, const WCHAR *name, ITask **task) { + static const WCHAR tasksW[] = { '\\','T','a','s','k','s','\\',0 }; + static const WCHAR jobW[] = { '.','j','o','b',0 }; TaskImpl *This; + WCHAR task_name[MAX_PATH]; ITaskDefinition *taskdef; IActionCollection *actions; HRESULT hr; - TRACE("(%s, %p)\n", debugstr_w(task_name), task); + TRACE("(%s, %p)\n", debugstr_w(name), task); + + if (strchrW(name, '.')) return E_INVALIDARG; + + GetWindowsDirectoryW(task_name, MAX_PATH); + lstrcatW(task_name, tasksW); + lstrcatW(task_name, name); + lstrcatW(task_name, jobW); hr = ITaskService_NewTask(service, 0, &taskdef); if (hr != S_OK) return hr;

1 0

Dmitry Timoshkov : mstask: Save a task with at least 1 trigger to follow the .job file spec.
by Alexandre Julliard 24 Apr '18

24 Apr '18

Module: wine Branch: master Commit: 66d8e7f6a96a230fd44d094cbea82c512726965e URL: https://source.winehq.org/git/wine.git/?a=commit;h=66d8e7f6a96a230fd44d094c… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Tue Apr 24 16:13:24 2018 +0800 mstask: Save a task with at least 1 trigger to follow the .job file spec. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mstask/task.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/dlls/mstask/task.c b/dlls/mstask/task.c index d64860a..e390aa6 100644 --- a/dlls/mstask/task.c +++ b/dlls/mstask/task.c @@ -793,9 +793,10 @@ static BOOL write_user_data(HANDLE hfile, BYTE *data, WORD data_size) static HRESULT write_triggers(ITask *task, HANDLE hfile) { - WORD count, i; + WORD count, i, idx = 0xffff; DWORD size; HRESULT hr; + ITaskTrigger *trigger; hr = ITask_GetTriggerCount(task, &count); if (hr != S_OK) return hr; @@ -803,9 +804,18 @@ static HRESULT write_triggers(ITask *task, HANDLE hfile) if (!WriteFile(hfile, &count, sizeof(count), &size, NULL)) return HRESULT_FROM_WIN32(GetLastError()); + /* Windows saves a .job with at least 1 trigger */ + if (!count) + { + hr = ITask_CreateTrigger(task, &idx, &trigger); + if (hr != S_OK) return hr; + ITaskTrigger_Release(trigger); + + count = 1; + } + for (i = 0; i < count; i++) { - ITaskTrigger *trigger; TASK_TRIGGER task_trigger; hr = ITask_GetTrigger(task, i, &trigger); @@ -813,13 +823,16 @@ static HRESULT write_triggers(ITask *task, HANDLE hfile) hr = ITaskTrigger_GetTrigger(trigger, &task_trigger); ITaskTrigger_Release(trigger); - if (hr != S_OK) return hr; + if (hr != S_OK) break; if (!WriteFile(hfile, &task_trigger, sizeof(task_trigger), &size, NULL)) return HRESULT_FROM_WIN32(GetLastError()); } - return S_OK; + if (idx != 0xffff) + ITask_DeleteTrigger(task, idx); + + return hr; } static BOOL write_unicode_string(HANDLE hfile, const WCHAR *str)

1 0

Dmitry Timoshkov : schedsvc: Print an error if the service couldn' t start monitoring the tasks directory.
by Alexandre Julliard 24 Apr '18

24 Apr '18

Module: wine Branch: master Commit: 0f77a4cb8207dfdae6344e07d3e3d2217274094b URL: https://source.winehq.org/git/wine.git/?a=commit;h=0f77a4cb8207dfdae6344e07… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Tue Apr 24 16:13:20 2018 +0800 schedsvc: Print an error if the service couldn't start monitoring the tasks directory. This happens for old prefixes with disabled updates. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/schedsvc/svc_main.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/dlls/schedsvc/svc_main.c b/dlls/schedsvc/svc_main.c index 1ccc345..fb7732c 100644 --- a/dlls/schedsvc/svc_main.c +++ b/dlls/schedsvc/svc_main.c @@ -50,7 +50,14 @@ static DWORD WINAPI tasks_monitor_thread(void *arg) htasks = CreateFileW(path, FILE_LIST_DIRECTORY, FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE, NULL, OPEN_EXISTING, FILE_FLAG_BACKUP_SEMANTICS | FILE_FLAG_OVERLAPPED, NULL); - if (htasks == INVALID_HANDLE_VALUE) return -1; + if (htasks == INVALID_HANDLE_VALUE) + { + ERR("Couldn't start monitoring %s for tasks, error %u\n", debugstr_w(path), GetLastError()); + /* Probably this is an old prefix with disabled updates */ + if (GetLastError() == ERROR_PATH_NOT_FOUND || GetLastError() == ERROR_FILE_NOT_FOUND) + ERR("Please create the directory manually\n"); + return -1; + } memset(&ov, 0, sizeof(ov)); ov.hEvent = CreateEventW(NULL, FALSE, FALSE, NULL);

1 0

Dmitry Timoshkov : schedsvc: Allow others to read the file.
by Alexandre Julliard 24 Apr '18

24 Apr '18

Module: wine Branch: master Commit: a49f07204047b3d742a9d2f6956506c669026fd2 URL: https://source.winehq.org/git/wine.git/?a=commit;h=a49f07204047b3d742a9d2f6… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Tue Apr 24 16:13:16 2018 +0800 schedsvc: Allow others to read the file. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/schedsvc/atsvc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/schedsvc/atsvc.c b/dlls/schedsvc/atsvc.c index e46c1e9..83e7dca 100644 --- a/dlls/schedsvc/atsvc.c +++ b/dlls/schedsvc/atsvc.c @@ -282,7 +282,7 @@ void add_job(const WCHAR *name) try = 1; for (;;) { - file = CreateFileW(name, GENERIC_READ, 0, NULL, OPEN_EXISTING, 0, 0); + file = CreateFileW(name, GENERIC_READ, FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, 0); if (file == INVALID_HANDLE_VALUE) { TRACE("Failed to open %s, error %u\n", debugstr_w(name), GetLastError());

1 0

Owen Rudge : wsdapi: Add MetadataVersion to Hello message.
by Alexandre Julliard 24 Apr '18

24 Apr '18

Module: wine Branch: master Commit: d11a18383b46651d7a31e64b6daa5e7bf3bf07f2 URL: https://source.winehq.org/git/wine.git/?a=commit;h=d11a18383b46651d7a31e64b… Author: Owen Rudge <orudge(a)codeweavers.com> Date: Mon Apr 23 21:12:31 2018 +0100 wsdapi: Add MetadataVersion to Hello message. Signed-off-by: Owen Rudge <orudge(a)codeweavers.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wsdapi/soap.c | 7 +++++++ dlls/wsdapi/tests/discovery.c | 4 ++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/dlls/wsdapi/soap.c b/dlls/wsdapi/soap.c index 9ba934e..e7cd651 100644 --- a/dlls/wsdapi/soap.c +++ b/dlls/wsdapi/soap.c @@ -80,6 +80,7 @@ static const WCHAR addressString[] = { 'A','d','d','r','e','s','s', 0 }; static const WCHAR typesString[] = { 'T','y','p','e','s', 0 }; static const WCHAR scopesString[] = { 'S','c','o','p','e','s', 0 }; static const WCHAR xAddrsString[] = { 'X','A','d','d','r','s', 0 }; +static const WCHAR metadataVersionString[] = { 'M','e','t','a','d','a','t','a','V','e','r','s','i','o','n', 0 }; struct discovered_namespace { @@ -968,6 +969,12 @@ HRESULT send_hello_message(IWSDiscoveryPublisherImpl *impl, LPCWSTR id, ULONGLON if (FAILED(ret)) goto cleanup; } + /* <wsd:MetadataVersion> */ + ret = add_child_element(impl->xmlContext, hello_element, discoveryNsUri, metadataVersionString, + ulonglong_to_string(hello_element, min(UINT_MAX, metadata_ver)), NULL); + + if (FAILED(ret)) goto cleanup; + /* Write any body elements */ if (any != NULL) { diff --git a/dlls/wsdapi/tests/discovery.c b/dlls/wsdapi/tests/discovery.c index 0576c8f..5d10d3d 100644 --- a/dlls/wsdapi/tests/discovery.c +++ b/dlls/wsdapi/tests/discovery.c @@ -699,8 +699,8 @@ static void Publish_tests(void) ok(hello_message_seen == TRUE, "Hello message not received\n"); ok(endpoint_reference_seen == TRUE, "EndpointReference not received\n"); ok(app_sequence_seen == TRUE, "AppSequence not received\n"); - todo_wine ok(metadata_version_seen == TRUE, "MetadataVersion not received\n"); - todo_wine ok(messageOK == TRUE, "Hello message metadata not received\n"); + ok(metadata_version_seen == TRUE, "MetadataVersion not received\n"); + ok(messageOK == TRUE, "Hello message metadata not received\n"); ok(any_header_seen == TRUE, "Custom header not received\n"); ok(wine_ns_seen == TRUE, "Wine namespace not received\n"); ok(body_hello_seen == TRUE, "Body and Hello elements not received\n");

1 0

← Newer
1
...
10
11
12
13
14
15
16
...
55
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits April 2018