winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
August 2018
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
618 discussions
Start a n
N
ew thread
Jacek Caban : server: Share more code between pipe client and server destructors.
by Alexandre Julliard
17 Aug '18
17 Aug '18
Module: wine Branch: master Commit: 95296651b57dee423a567896cffa8424f2f5a8e8 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=95296651b57dee423a567896…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Aug 17 17:41:30 2018 +0200 server: Share more code between pipe client and server destructors. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- server/named_pipe.c | 25 ++++++++----------------- 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/server/named_pipe.c b/server/named_pipe.c index 70134fb..ba6f507 100644 --- a/server/named_pipe.c +++ b/server/named_pipe.c @@ -133,6 +133,7 @@ static const struct object_ops named_pipe_ops = }; /* common server and client pipe end functions */ +static void pipe_end_destroy( struct object *obj ); static enum server_fd_type pipe_end_get_fd_type( struct fd *fd ); static struct fd *pipe_end_get_fd( struct object *obj ); static struct security_descriptor *pipe_end_get_sd( struct object *obj ); @@ -189,7 +190,6 @@ static const struct fd_ops pipe_server_fd_ops = /* client end functions */ static void pipe_client_dump( struct object *obj, int verbose ); -static void pipe_client_destroy( struct object *obj ); static int pipe_client_ioctl( struct fd *fd, ioctl_code_t code, struct async *async ); static const struct object_ops pipe_client_ops = @@ -211,7 +211,7 @@ static const struct object_ops pipe_client_ops = NULL, /* unlink_name */ no_open_file, /* open_file */ fd_close_handle, /* close_handle */ - pipe_client_destroy /* destroy */ + pipe_end_destroy /* destroy */ }; static const struct fd_ops pipe_client_fd_ops = @@ -382,10 +382,13 @@ static void pipe_end_disconnect( struct pipe_end *pipe_end, unsigned int status } } -static void pipe_end_destroy( struct pipe_end *pipe_end ) +static void pipe_end_destroy( struct object *obj ) { + struct pipe_end *pipe_end = (struct pipe_end *)obj; struct pipe_message *message; + pipe_end_disconnect( pipe_end, STATUS_PIPE_BROKEN ); + while (!list_empty( &pipe_end->message_queue )) { message = LIST_ENTRY( list_head(&pipe_end->message_queue), struct pipe_message, entry ); @@ -399,7 +402,7 @@ static void pipe_end_destroy( struct pipe_end *pipe_end ) if (pipe_end->pipe) release_object( pipe_end->pipe ); } -static void pipe_server_destroy( struct object *obj) +static void pipe_server_destroy( struct object *obj ) { struct pipe_server *server = (struct pipe_server *)obj; struct named_pipe *pipe = server->pipe_end.pipe; @@ -411,19 +414,7 @@ static void pipe_server_destroy( struct object *obj) list_remove( &server->entry ); free_async_queue( &server->listen_q ); - pipe_end_disconnect( &server->pipe_end, STATUS_PIPE_BROKEN ); - - pipe_end_destroy( &server->pipe_end ); -} - -static void pipe_client_destroy( struct object *obj) -{ - struct pipe_client *client = (struct pipe_client *)obj; - - assert( obj->ops == &pipe_client_ops ); - - pipe_end_disconnect( &client->pipe_end, STATUS_PIPE_BROKEN ); - pipe_end_destroy( &client->pipe_end ); + pipe_end_destroy( obj ); } static void named_pipe_device_dump( struct object *obj, int verbose )
1
0
0
0
Jacek Caban : server: Remove no longer needed pipe_state enum.
by Alexandre Julliard
17 Aug '18
17 Aug '18
Module: wine Branch: master Commit: ce5def4b58fb747bb3183220cb13c0e486048419 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=ce5def4b58fb747bb3183220…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Aug 17 17:41:17 2018 +0200 server: Remove no longer needed pipe_state enum. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- server/named_pipe.c | 42 ++---------------------------------------- 1 file changed, 2 insertions(+), 40 deletions(-) diff --git a/server/named_pipe.c b/server/named_pipe.c index c2c80b1..70134fb 100644 --- a/server/named_pipe.c +++ b/server/named_pipe.c @@ -42,15 +42,6 @@ #include "security.h" #include "process.h" -enum pipe_state -{ - ps_idle_server, - ps_wait_open, - ps_connected_server, - ps_wait_disconnect, - ps_wait_connect -}; - struct named_pipe; struct pipe_message @@ -81,7 +72,6 @@ struct pipe_server { struct pipe_end pipe_end; /* common header for pipe_client and pipe_server */ struct list entry; /* entry in named pipe servers list */ - enum pipe_state state; /* server state */ unsigned int options; /* pipe options */ struct async_queue listen_q; /* listen queue */ }; @@ -305,7 +295,8 @@ static void pipe_server_dump( struct object *obj, int verbose ) { struct pipe_server *server = (struct pipe_server *) obj; assert( obj->ops == &pipe_server_ops ); - fprintf( stderr, "Named pipe server pipe=%p state=%d\n", server->pipe_end.pipe, server->state ); + fprintf( stderr, "Named pipe server pipe=%p state=%d\n", server->pipe_end.pipe, + server->pipe_end.state ); } static void pipe_client_dump( struct object *obj, int verbose ) @@ -330,12 +321,6 @@ static struct fd *pipe_end_get_fd( struct object *obj ) return (struct fd *) grab_object( pipe_end->fd ); } -static void set_server_state( struct pipe_server *server, enum pipe_state state ) -{ - server->state = state; -} - - static struct pipe_message *queue_message( struct pipe_end *pipe_end, struct iosb *iosb ) { struct pipe_message *message; @@ -434,29 +419,10 @@ static void pipe_server_destroy( struct object *obj) static void pipe_client_destroy( struct object *obj) { struct pipe_client *client = (struct pipe_client *)obj; - struct pipe_server *server = (struct pipe_server *)client->pipe_end.connection; assert( obj->ops == &pipe_client_ops ); pipe_end_disconnect( &client->pipe_end, STATUS_PIPE_BROKEN ); - - if (server) - { - switch(server->state) - { - case ps_connected_server: - /* Don't destroy the server's fd here as we can't - do a successful flush without it. */ - set_server_state( server, ps_wait_disconnect ); - break; - case ps_idle_server: - case ps_wait_open: - case ps_wait_disconnect: - case ps_wait_connect: - assert( 0 ); - } - } - pipe_end_destroy( &client->pipe_end ); } @@ -1007,7 +973,6 @@ static int pipe_server_ioctl( struct fd *fd, ioctl_code_t code, struct async *as server->pipe_end.state = FILE_PIPE_LISTENING_STATE; queue_async( &server->listen_q, async ); - set_server_state( server, ps_wait_open ); async_wake_up( &server->pipe_end.pipe->waiters, STATUS_SUCCESS ); set_error( STATUS_PENDING ); return 1; @@ -1032,7 +997,6 @@ static int pipe_server_ioctl( struct fd *fd, ioctl_code_t code, struct async *as } pipe_end_disconnect( &server->pipe_end, STATUS_PIPE_DISCONNECTED ); - set_server_state( server, ps_wait_connect ); return 1; default: @@ -1091,7 +1055,6 @@ static struct pipe_server *create_pipe_server( struct named_pipe *pipe, unsigned allow_fd_caching( server->pipe_end.fd ); set_fd_signaled( server->pipe_end.fd, 1 ); init_async_queue( &server->listen_q ); - set_server_state( server, ps_idle_server ); return server; } @@ -1183,7 +1146,6 @@ static struct object *named_pipe_open_file( struct object *obj, unsigned int acc { async_wake_up( &server->listen_q, STATUS_SUCCESS ); server->pipe_end.state = FILE_PIPE_CONNECTED_STATE; - set_server_state( server, ps_connected_server ); server->pipe_end.connection = &client->pipe_end; client->pipe_end.connection = &server->pipe_end; server->pipe_end.client_pid = client->pipe_end.client_pid;
1
0
0
0
Jacek Caban : server: Use pipe_end state in find_available_server.
by Alexandre Julliard
17 Aug '18
17 Aug '18
Module: wine Branch: master Commit: 05319312783a3495c64898dd0e1c801420482b00 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=05319312783a3495c64898dd…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Aug 17 17:41:08 2018 +0200 server: Use pipe_end state in find_available_server. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- server/named_pipe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/named_pipe.c b/server/named_pipe.c index c17889b..c2c80b1 100644 --- a/server/named_pipe.c +++ b/server/named_pipe.c @@ -1128,14 +1128,14 @@ static struct pipe_server *find_available_server( struct named_pipe *pipe ) /* look for pipe servers that are listening */ LIST_FOR_EACH_ENTRY( server, &pipe->servers, struct pipe_server, entry ) { - if (server->state == ps_wait_open) + if (server->pipe_end.state == FILE_PIPE_LISTENING_STATE && async_queued( &server->listen_q )) return (struct pipe_server *)grab_object( server ); } /* fall back to pipe servers that are idle */ LIST_FOR_EACH_ENTRY( server, &pipe->servers, struct pipe_server, entry ) { - if (server->state == ps_idle_server) + if (server->pipe_end.state == FILE_PIPE_LISTENING_STATE ) return (struct pipe_server *)grab_object( server ); }
1
0
0
0
Jacek Caban : server: Use separated async queue for listeners.
by Alexandre Julliard
17 Aug '18
17 Aug '18
Module: wine Branch: master Commit: 03317d10a0dfd21bf7b64120432274b98d8bfcb0 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=03317d10a0dfd21bf7b64120…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Aug 17 17:41:01 2018 +0200 server: Use separated async queue for listeners. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- server/named_pipe.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/server/named_pipe.c b/server/named_pipe.c index 80a56ae..c17889b 100644 --- a/server/named_pipe.c +++ b/server/named_pipe.c @@ -83,6 +83,7 @@ struct pipe_server struct list entry; /* entry in named pipe servers list */ enum pipe_state state; /* server state */ unsigned int options; /* pipe options */ + struct async_queue listen_q; /* listen queue */ }; struct pipe_client @@ -424,6 +425,7 @@ static void pipe_server_destroy( struct object *obj) if (!--pipe->instances) unlink_named_object( &pipe->obj ); list_remove( &server->entry ); + free_async_queue( &server->listen_q ); pipe_end_disconnect( &server->pipe_end, STATUS_PIPE_BROKEN ); pipe_end_destroy( &server->pipe_end ); @@ -1003,8 +1005,8 @@ static int pipe_server_ioctl( struct fd *fd, ioctl_code_t code, struct async *as return 0; } - fd_queue_async( server->pipe_end.fd, async, ASYNC_TYPE_WAIT ); server->pipe_end.state = FILE_PIPE_LISTENING_STATE; + queue_async( &server->listen_q, async ); set_server_state( server, ps_wait_open ); async_wake_up( &server->pipe_end.pipe->waiters, STATUS_SUCCESS ); set_error( STATUS_PENDING ); @@ -1088,6 +1090,7 @@ static struct pipe_server *create_pipe_server( struct named_pipe *pipe, unsigned } allow_fd_caching( server->pipe_end.fd ); set_fd_signaled( server->pipe_end.fd, 1 ); + init_async_queue( &server->listen_q ); set_server_state( server, ps_idle_server ); return server; } @@ -1178,8 +1181,7 @@ static struct object *named_pipe_open_file( struct object *obj, unsigned int acc if ((client = create_pipe_client( options, pipe, pipe->outsize, options ))) { - if (server->state == ps_wait_open) - fd_async_wake_up( server->pipe_end.fd, ASYNC_TYPE_WAIT, STATUS_SUCCESS ); + async_wake_up( &server->listen_q, STATUS_SUCCESS ); server->pipe_end.state = FILE_PIPE_CONNECTED_STATE; set_server_state( server, ps_connected_server ); server->pipe_end.connection = &client->pipe_end;
1
0
0
0
Jacek Caban : server: Use pipe_end state in FSCTL_PIPE_DISCONNECT implementation.
by Alexandre Julliard
17 Aug '18
17 Aug '18
Module: wine Branch: master Commit: a03d0a8eae7d5694e10d767597c2f9ce4c5ee4ed URL:
https://source.winehq.org/git/wine.git/?a=commit;h=a03d0a8eae7d5694e10d7675…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Aug 17 17:40:55 2018 +0200 server: Use pipe_end state in FSCTL_PIPE_DISCONNECT implementation. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- server/named_pipe.c | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/server/named_pipe.c b/server/named_pipe.c index bb4ea3b..80a56ae 100644 --- a/server/named_pipe.c +++ b/server/named_pipe.c @@ -1011,31 +1011,26 @@ static int pipe_server_ioctl( struct fd *fd, ioctl_code_t code, struct async *as return 1; case FSCTL_PIPE_DISCONNECT: - switch(server->state) + switch(server->pipe_end.state) { - case ps_connected_server: - assert( server->pipe_end.connection ); - + case FILE_PIPE_CONNECTED_STATE: /* dump the client connection - all data is lost */ + assert( server->pipe_end.connection ); release_object( server->pipe_end.connection->pipe ); server->pipe_end.connection->pipe = NULL; - - pipe_end_disconnect( &server->pipe_end, STATUS_PIPE_DISCONNECTED ); - set_server_state( server, ps_wait_connect ); break; - case ps_wait_disconnect: - assert( !server->pipe_end.connection ); - pipe_end_disconnect( &server->pipe_end, STATUS_PIPE_DISCONNECTED ); - set_server_state( server, ps_wait_connect ); + case FILE_PIPE_CLOSING_STATE: break; - case ps_idle_server: - case ps_wait_open: + case FILE_PIPE_LISTENING_STATE: set_error( STATUS_PIPE_LISTENING ); return 0; - case ps_wait_connect: + case FILE_PIPE_DISCONNECTED_STATE: set_error( STATUS_PIPE_DISCONNECTED ); return 0; } + + pipe_end_disconnect( &server->pipe_end, STATUS_PIPE_DISCONNECTED ); + set_server_state( server, ps_wait_connect ); return 1; default:
1
0
0
0
Jacek Caban : server: Use pipe_end state in FSCTL_PIPE_LISTEN implementation.
by Alexandre Julliard
17 Aug '18
17 Aug '18
Module: wine Branch: master Commit: 290320a8fec6f78289761d5162f27873d83edbb0 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=290320a8fec6f78289761d51…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Aug 17 17:40:44 2018 +0200 server: Use pipe_end state in FSCTL_PIPE_LISTEN implementation. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/tests/pipe.c | 8 ++++++++ server/named_pipe.c | 34 ++++++++++++++++------------------ 2 files changed, 24 insertions(+), 18 deletions(-) diff --git a/dlls/ntdll/tests/pipe.c b/dlls/ntdll/tests/pipe.c index 94db1a2..d6a0d41 100644 --- a/dlls/ntdll/tests/pipe.c +++ b/dlls/ntdll/tests/pipe.c @@ -1341,6 +1341,14 @@ static void test_pipe_state(HANDLE pipe, BOOL is_server, DWORD state) ok(status == expected_status, "NtReadFile failed in %s state %u: %x\n", is_server ? "server" : "client", state, status); } + + if (is_server && (state == FILE_PIPE_CLOSING_STATE || state == FILE_PIPE_CONNECTED_STATE)) + { + memset(&io, 0xcc, sizeof(io)); + status = listen_pipe(pipe, NULL, &io, FALSE); + ok(status == (state == FILE_PIPE_CLOSING_STATE ? STATUS_PIPE_CLOSING : STATUS_PIPE_CONNECTED), + "status = %x in %u state\n", status, state); + } } static void test_pipe_with_data_state(HANDLE pipe, BOOL is_server, DWORD state) diff --git a/server/named_pipe.c b/server/named_pipe.c index 76e38a9..bb4ea3b 100644 --- a/server/named_pipe.c +++ b/server/named_pipe.c @@ -990,27 +990,25 @@ static int pipe_server_ioctl( struct fd *fd, ioctl_code_t code, struct async *as switch(code) { case FSCTL_PIPE_LISTEN: - switch(server->state) + switch(server->pipe_end.state) { - case ps_idle_server: - case ps_wait_connect: - fd_queue_async( server->pipe_end.fd, async, ASYNC_TYPE_WAIT ); - server->pipe_end.state = FILE_PIPE_LISTENING_STATE; - set_server_state( server, ps_wait_open ); - async_wake_up( &server->pipe_end.pipe->waiters, STATUS_SUCCESS ); - set_error( STATUS_PENDING ); - return 1; - case ps_connected_server: - set_error( STATUS_PIPE_CONNECTED ); - break; - case ps_wait_disconnect: - set_error( STATUS_NO_DATA_DETECTED ); - break; - case ps_wait_open: - set_error( STATUS_INVALID_HANDLE ); + case FILE_PIPE_LISTENING_STATE: + case FILE_PIPE_DISCONNECTED_STATE: break; + case FILE_PIPE_CONNECTED_STATE: + set_error( STATUS_PIPE_CONNECTED ); + return 0; + case FILE_PIPE_CLOSING_STATE: + set_error( STATUS_PIPE_CLOSING ); + return 0; } - return 0; + + fd_queue_async( server->pipe_end.fd, async, ASYNC_TYPE_WAIT ); + server->pipe_end.state = FILE_PIPE_LISTENING_STATE; + set_server_state( server, ps_wait_open ); + async_wake_up( &server->pipe_end.pipe->waiters, STATUS_SUCCESS ); + set_error( STATUS_PENDING ); + return 1; case FSCTL_PIPE_DISCONNECT: switch(server->state)
1
0
0
0
Nikolay Sivov : wmp: Improve media items handling.
by Alexandre Julliard
17 Aug '18
17 Aug '18
Module: wine Branch: master Commit: cd1c681ee71332e18081730ce7f8794fedb55f5b URL:
https://source.winehq.org/git/wine.git/?a=commit;h=cd1c681ee71332e18081730c…
Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Fri Aug 17 18:05:16 2018 +0300 wmp: Improve media items handling. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wmp/player.c | 98 +++++++++++++++++++++++++------------------------- dlls/wmp/tests/media.c | 77 +++++++++++++++++++++++++++++++++++++++ dlls/wmp/wmp_private.h | 20 +++++++++-- 3 files changed, 144 insertions(+), 51 deletions(-) Diff:
https://source.winehq.org/git/wine.git/?a=commitdiff;h=cd1c681ee71332e18081…
1
0
0
0
Nikolay Sivov : d2d1: Add ID2D1DeviceContext stub.
by Alexandre Julliard
17 Aug '18
17 Aug '18
Module: wine Branch: master Commit: 31cbe190f7caa0cd9089fba8ca77179fef9dfb66 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=31cbe190f7caa0cd9089fba8…
Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Fri Aug 17 19:42:11 2018 +0430 d2d1: Add ID2D1DeviceContext stub. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d2d1/bitmap.c | 8 +- dlls/d2d1/bitmap_render_target.c | 2 +- dlls/d2d1/brush.c | 4 +- dlls/d2d1/d2d1_private.h | 10 +- dlls/d2d1/device.c | 786 +++++++++++++++++++++++++++------------ 5 files changed, 563 insertions(+), 247 deletions(-) Diff:
https://source.winehq.org/git/wine.git/?a=commitdiff;h=31cbe190f7caa0cd9089…
1
0
0
0
Henri Verbeet : d2d1/tests: Run the tests in parallel.
by Alexandre Julliard
17 Aug '18
17 Aug '18
Module: wine Branch: master Commit: e7949902c51f3ffd5c005aa911176061fd709376 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=e7949902c51f3ffd5c005aa9…
Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Fri Aug 17 19:42:10 2018 +0430 d2d1/tests: Run the tests in parallel. Like d3d11. Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d2d1/tests/d2d1.c | 132 +++++++++++++++++++++++++++++++++++++++---------- 1 file changed, 105 insertions(+), 27 deletions(-) diff --git a/dlls/d2d1/tests/d2d1.c b/dlls/d2d1/tests/d2d1.c index 26c81e6..a8b67f1 100644 --- a/dlls/d2d1/tests/d2d1.c +++ b/dlls/d2d1/tests/d2d1.c @@ -25,6 +25,15 @@ #include "initguid.h" #include "dwrite.h" #include "wincodec.h" +#include "wine/heap.h" + +static BOOL use_mt = TRUE; + +static struct test_entry +{ + void (*test)(void); +} *mt_tests; +size_t mt_tests_size, mt_test_count; struct resource_readback { @@ -83,6 +92,63 @@ struct expected_geometry_figure const struct geometry_segment *segments; }; +static void queue_test(void (*test)(void)) +{ + if (mt_test_count >= mt_tests_size) + { + mt_tests_size = max(16, mt_tests_size * 2); + mt_tests = heap_realloc(mt_tests, mt_tests_size * sizeof(*mt_tests)); + } + mt_tests[mt_test_count++].test = test; +} + +static DWORD WINAPI thread_func(void *ctx) +{ + LONG *i = ctx, j; + + while (*i < mt_test_count) + { + j = *i; + if (InterlockedCompareExchange(i, j + 1, j) == j) + mt_tests[j].test(); + } + + return 0; +} + +static void run_queued_tests(void) +{ + unsigned int thread_count, i; + HANDLE *threads; + SYSTEM_INFO si; + LONG test_idx; + + if (!use_mt) + { + for (i = 0; i < mt_test_count; ++i) + { + mt_tests[i].test(); + } + + return; + } + + GetSystemInfo(&si); + thread_count = si.dwNumberOfProcessors; + threads = heap_calloc(thread_count, sizeof(*threads)); + for (i = 0, test_idx = 0; i < thread_count; ++i) + { + threads[i] = CreateThread(NULL, 0, thread_func, &test_idx, 0, NULL); + ok(!!threads[i], "Failed to create thread %u.\n", i); + } + WaitForMultipleObjects(thread_count, threads, TRUE, INFINITE); + for (i = 0; i < thread_count; ++i) + { + CloseHandle(threads[i]); + } + heap_free(threads); +} + static void set_point(D2D1_POINT_2F *point, float x, float y) { point->x = x; @@ -6465,31 +6531,43 @@ static void test_create_device(void) START_TEST(d2d1) { - test_clip(); - test_state_block(); - test_color_brush(); - test_bitmap_brush(); - test_linear_brush(); - test_radial_brush(); - test_path_geometry(); - test_rectangle_geometry(); - test_rounded_rectangle_geometry(); - test_bitmap_formats(); - test_alpha_mode(); - test_shared_bitmap(); - test_bitmap_updates(); - test_opacity_brush(); - test_create_target(); - test_draw_text_layout(); - test_dc_target(); - test_hwnd_target(); - test_bitmap_target(); - test_desktop_dpi(); - test_stroke_style(); - test_gradient(); - test_draw_geometry(); - test_gdi_interop(); - test_layer(); - test_bezier_intersect(); - test_create_device(); + unsigned int argc, i; + char **argv; + + argc = winetest_get_mainargs(&argv); + for (i = 2; i < argc; ++i) + { + if (!strcmp(argv[i], "--single")) + use_mt = FALSE; + } + + queue_test(test_clip); + queue_test(test_state_block); + queue_test(test_color_brush); + queue_test(test_bitmap_brush); + queue_test(test_linear_brush); + queue_test(test_radial_brush); + queue_test(test_path_geometry); + queue_test(test_rectangle_geometry); + queue_test(test_rounded_rectangle_geometry); + queue_test(test_bitmap_formats); + queue_test(test_alpha_mode); + queue_test(test_shared_bitmap); + queue_test(test_bitmap_updates); + queue_test(test_opacity_brush); + queue_test(test_create_target); + queue_test(test_draw_text_layout); + queue_test(test_dc_target); + queue_test(test_hwnd_target); + queue_test(test_bitmap_target); + queue_test(test_desktop_dpi); + queue_test(test_stroke_style); + queue_test(test_gradient); + queue_test(test_draw_geometry); + queue_test(test_gdi_interop); + queue_test(test_layer); + queue_test(test_bezier_intersect); + queue_test(test_create_device); + + run_queued_tests(); }
1
0
0
0
Henri Verbeet : wined3d: Move OpenGL initialisation code to adapter_gl.c.
by Alexandre Julliard
17 Aug '18
17 Aug '18
Module: wine Branch: master Commit: cf9536b6bfbefbf5003c7633446a91f6e399c4de URL:
https://source.winehq.org/git/wine.git/?a=commit;h=cf9536b6bfbefbf5003c7633…
Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Fri Aug 17 19:42:09 2018 +0430 wined3d: Move OpenGL initialisation code to adapter_gl.c. Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/Makefile.in | 1 + dlls/wined3d/adapter_gl.c | 4290 ++++++++++++++++++++++++++++++++++++ dlls/wined3d/directx.c | 4664 ++-------------------------------------- dlls/wined3d/wined3d_private.h | 43 + 4 files changed, 4538 insertions(+), 4460 deletions(-) Diff:
https://source.winehq.org/git/wine.git/?a=commitdiff;h=cf9536b6bfbefbf5003c…
1
0
0
0
← Newer
1
...
41
42
43
44
45
46
47
...
62
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
Results per page:
10
25
50
100
200