wine-commits October 2019

wine-commits@winehq.org

2 participants
614 discussions

Conor McCarthy : dxgi: Add support for DXGI_SCALING_NONE.
by Alexandre Julliard 21 Oct '19

21 Oct '19

Module: wine Branch: master Commit: fabd07d520d3ad40bb24d39e61867e1d39736ace URL: https://source.winehq.org/git/wine.git/?a=commit;h=fabd07d520d3ad40bb24d39e… Author: Conor McCarthy <cmccarthy(a)codeweavers.com> Date: Fri Oct 18 00:57:09 2019 +1000 dxgi: Add support for DXGI_SCALING_NONE. In fullscreen mode, Shadow of the Tomb Raider uses an unscaled swapchain that is oversized by 1x1 pixel. The pixel-wide lines on the right and bottom should be clipped to fit the display. This eliminates the two lines of uninitialized data. Signed-off-by: Conor McCarthy <cmccarthy(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dxgi/swapchain.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/dlls/dxgi/swapchain.c b/dlls/dxgi/swapchain.c index 53dabe7cde..9e620e0b1e 100644 --- a/dlls/dxgi/swapchain.c +++ b/dlls/dxgi/swapchain.c @@ -1432,8 +1432,19 @@ static VkResult d3d12_swapchain_record_swapchain_blit(struct d3d12_swapchain *sw blit.dstOffsets[0].x = 0; blit.dstOffsets[0].y = 0; blit.dstOffsets[0].z = 0; - blit.dstOffsets[1].x = swapchain->vk_swapchain_width; - blit.dstOffsets[1].y = swapchain->vk_swapchain_height; + if (swapchain->desc.Scaling == DXGI_SCALING_NONE) + { + blit.srcOffsets[1].x = min(swapchain->vk_swapchain_width, blit.srcOffsets[1].x); + blit.srcOffsets[1].y = min(swapchain->vk_swapchain_height, blit.srcOffsets[1].y); + blit.dstOffsets[1].x = blit.srcOffsets[1].x; + blit.dstOffsets[1].y = blit.srcOffsets[1].y; + } + else + { + /* FIXME: handle DXGI_SCALING_ASPECT_RATIO_STRETCH. */ + blit.dstOffsets[1].x = swapchain->vk_swapchain_width; + blit.dstOffsets[1].y = swapchain->vk_swapchain_height; + } blit.dstOffsets[1].z = 1; vk_funcs->p_vkCmdBlitImage(vk_cmd_buffer, @@ -2873,7 +2884,7 @@ static HRESULT d3d12_swapchain_init(struct d3d12_swapchain *swapchain, IWineDXGI if (swapchain_desc->BufferUsage && swapchain_desc->BufferUsage != DXGI_USAGE_RENDER_TARGET_OUTPUT) FIXME("Ignoring buffer usage %#x.\n", swapchain_desc->BufferUsage); - if (swapchain_desc->Scaling != DXGI_SCALING_STRETCH) + if (swapchain_desc->Scaling != DXGI_SCALING_STRETCH && swapchain_desc->Scaling != DXGI_SCALING_NONE) FIXME("Ignoring scaling %#x.\n", swapchain_desc->Scaling); if (swapchain_desc->AlphaMode && swapchain_desc->AlphaMode != DXGI_ALPHA_MODE_IGNORE) FIXME("Ignoring alpha mode %#x.\n", swapchain_desc->AlphaMode);

1 0

Conor McCarthy : dxgi: Do not warn about ignoring a null refresh rate.
by Alexandre Julliard 21 Oct '19

21 Oct '19

Module: wine Branch: master Commit: 66548659d0bb961da31d6183272e396aaa511dc1 URL: https://source.winehq.org/git/wine.git/?a=commit;h=66548659d0bb961da31d6183… Author: Conor McCarthy <cmccarthy(a)codeweavers.com> Date: Tue Oct 8 14:13:52 2019 +1000 dxgi: Do not warn about ignoring a null refresh rate. Both values will be zero if fullscreen_desc was NULL. Signed-off-by: Conor McCarthy <cmccarthy(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dxgi/swapchain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/dxgi/swapchain.c b/dlls/dxgi/swapchain.c index c76ad1d135..53dabe7cde 100644 --- a/dlls/dxgi/swapchain.c +++ b/dlls/dxgi/swapchain.c @@ -2880,7 +2880,8 @@ static HRESULT d3d12_swapchain_init(struct d3d12_swapchain *swapchain, IWineDXGI if (swapchain_desc->Flags) FIXME("Ignoring swapchain flags %#x.\n", swapchain_desc->Flags); - FIXME("Ignoring refresh rate.\n"); + if (fullscreen_desc->RefreshRate.Numerator || fullscreen_desc->RefreshRate.Denominator) + FIXME("Ignoring refresh rate.\n"); if (fullscreen_desc->ScanlineOrdering) FIXME("Unhandled scanline ordering %#x.\n", fullscreen_desc->ScanlineOrdering); if (fullscreen_desc->Scaling)

1 0

Conor McCarthy : dxgi/tests: Mark as todo the containing output test if a secondary monitor will cause failure.
by Alexandre Julliard 21 Oct '19

21 Oct '19

Module: wine Branch: master Commit: 890428abdca8ef027b81cf805ad740158079117d URL: https://source.winehq.org/git/wine.git/?a=commit;h=890428abdca8ef027b81cf80… Author: Conor McCarthy <cmccarthy(a)codeweavers.com> Date: Tue Oct 8 14:13:49 2019 +1000 dxgi/tests: Mark as todo the containing output test if a secondary monitor will cause failure. Prevents test failure and crash until multi-monitor support is improved. Signed-off-by: Conor McCarthy <cmccarthy(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dxgi/tests/dxgi.c | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/dlls/dxgi/tests/dxgi.c b/dlls/dxgi/tests/dxgi.c index 0f256d4ce2..7a1baa828f 100644 --- a/dlls/dxgi/tests/dxgi.c +++ b/dlls/dxgi/tests/dxgi.c @@ -1935,6 +1935,22 @@ done: DestroyWindow(creation_desc.OutputWindow); } +static HMONITOR get_primary_if_right_side_secondary(const DXGI_OUTPUT_DESC *output_desc) +{ + HMONITOR primary, secondary; + MONITORINFO mi; + POINT pt = {0, 0}; + + primary = MonitorFromPoint(pt, MONITOR_DEFAULTTONULL); + pt.x = output_desc->DesktopCoordinates.right; + secondary = MonitorFromPoint(pt, MONITOR_DEFAULTTONULL); + mi.cbSize = sizeof(mi); + if (secondary && secondary != primary + && GetMonitorInfoW(primary, &mi) && (mi.dwFlags & MONITORINFOF_PRIMARY)) + return primary; + return NULL; +} + static void test_get_containing_output(void) { unsigned int output_count, output_idx; @@ -1949,6 +1965,7 @@ static void test_get_containing_output(void) IDXGIDevice *device; unsigned int i, j; HMONITOR monitor; + HMONITOR primary; ULONG refcount; HRESULT hr; BOOL ret; @@ -2031,6 +2048,8 @@ static void test_get_containing_output(void) wine_dbgstr_rect(&output_desc.DesktopCoordinates), wine_dbgstr_rect(&monitor_info.rcMonitor)); + primary = get_primary_if_right_side_secondary(&output_desc); + output_idx = 0; while ((hr = IDXGIAdapter_EnumOutputs(adapter, output_idx, &output)) != DXGI_ERROR_NOT_FOUND) { @@ -2113,9 +2132,11 @@ static void test_get_containing_output(void) ok(ret, "Failed to get monitor info.\n"); hr = IDXGISwapChain_GetContainingOutput(swapchain, &output); + /* Hack to prevent test failures with secondary on the right until multi-monitor support is improved. */ + todo_wine_if(primary && monitor != primary) ok(hr == S_OK || broken(hr == DXGI_ERROR_UNSUPPORTED), "Failed to get containing output, hr %#x.\n", hr); - if (hr == DXGI_ERROR_UNSUPPORTED) + if (hr != S_OK) continue; ok(!!output, "Got unexpected containing output %p.\n", output); hr = IDXGIOutput_GetDesc(output, &output_desc);

1 0

Alistair Leslie-Hughes : dinput/tests: Remove unrequired pointer checks (Coverity).
by Alexandre Julliard 21 Oct '19

21 Oct '19

Module: wine Branch: master Commit: 61a85a60318f927f032fefce0cc4beeee2b1090e URL: https://source.winehq.org/git/wine.git/?a=commit;h=61a85a60318f927f032fefce… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Sun Oct 20 09:32:06 2019 +0000 dinput/tests: Remove unrequired pointer checks (Coverity). Also fixes a few test strings. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dinput/tests/device.c | 8 ++++---- dlls/dinput/tests/keyboard.c | 4 ++-- dlls/dinput/tests/mouse.c | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/dlls/dinput/tests/device.c b/dlls/dinput/tests/device.c index fa9b6f1436..a2a5a65686 100644 --- a/dlls/dinput/tests/device.c +++ b/dlls/dinput/tests/device.c @@ -190,15 +190,15 @@ static BOOL CALLBACK enum_devices(const DIDEVICEINSTANCEA *lpddi, void *pvRef) trace("Testing device %p \"%s\"\n", device, lpddi->tszInstanceName); hr = IUnknown_QueryInterface(device, &IID_IDirectInputDevice2A, (LPVOID*)&obj); - ok(SUCCEEDED(hr), "IUnknown_QueryInterface(IID_IDirectInputDevice7A) failed: %08x\n", hr); + ok(SUCCEEDED(hr), "IUnknown_QueryInterface(IID_IDirectInputDevice2A) failed: %08x\n", hr); test_object_info(obj, data->hwnd); - if (obj) IUnknown_Release(obj); + IUnknown_Release(obj); obj = NULL; hr = IUnknown_QueryInterface(device, &IID_IDirectInputDevice2W, (LPVOID*)&obj); - ok(SUCCEEDED(hr), "IUnknown_QueryInterface(IID_IDirectInputDevice7W) failed: %08x\n", hr); + ok(SUCCEEDED(hr), "IUnknown_QueryInterface(IID_IDirectInputDevice2W) failed: %08x\n", hr); test_object_info(obj, data->hwnd); - if (obj) IUnknown_Release(obj); + IUnknown_Release(obj); IUnknown_Release(device); } diff --git a/dlls/dinput/tests/keyboard.c b/dlls/dinput/tests/keyboard.c index 0e399f021c..84e6fed078 100644 --- a/dlls/dinput/tests/keyboard.c +++ b/dlls/dinput/tests/keyboard.c @@ -182,7 +182,7 @@ static void acquire_tests(IDirectInputA *pDI, HWND hwnd) hr = IDirectInputDevice_Unacquire(pKeyboard); ok(SUCCEEDED(hr), "IDirectInputDevice_Unacquire() failed: %08x\n", hr); - if (pKeyboard) IUnknown_Release(pKeyboard); + IUnknown_Release(pKeyboard); ActivateKeyboardLayout(hkl_orig, 0); UnloadKeyboardLayout(hkl); @@ -272,7 +272,7 @@ static void test_get_prop(IDirectInputA *pDI, HWND hwnd) hr = IDirectInputDevice_GetProperty(pKeyboard, DIPROP_RANGE, &diprg.diph); ok(hr == DIERR_UNSUPPORTED, "IDirectInputDevice_GetProperty() did not return DIPROP_RANGE but: %08x\n", hr); - if (pKeyboard) IUnknown_Release(pKeyboard); + IUnknown_Release(pKeyboard); } static void test_capabilities(IDirectInputA *pDI, HWND hwnd) diff --git a/dlls/dinput/tests/mouse.c b/dlls/dinput/tests/mouse.c index 11da951d10..19d1c3708b 100644 --- a/dlls/dinput/tests/mouse.c +++ b/dlls/dinput/tests/mouse.c @@ -198,7 +198,7 @@ static void test_acquire(IDirectInputA *pDI, HWND hwnd) /* Granularity of Y axis should be 1! */ ok(hr == S_OK && di_op.dwData == 1, "GetProperty(): %08x, dwData: %i but should be 1.\n", hr, di_op.dwData); - if (pMouse) IUnknown_Release(pMouse); + IUnknown_Release(pMouse); DestroyWindow( hwnd2 ); } @@ -259,7 +259,7 @@ static void test_mouse_EnumObjects(IDirectInputA *pDI) hr = IDirectInputDevice_EnumObjects(pMouse, EnumAxes, NULL, DIDFT_ALL); ok(hr==DI_OK,"IDirectInputDevice_EnumObjects() failed: %08x\n", hr); - if (pMouse) IUnknown_Release(pMouse); + IUnknown_Release(pMouse); } static void mouse_tests(void)

1 0

Sven Baars : webservices: Fix some leaks on error paths (Coverity).
by Alexandre Julliard 21 Oct '19

21 Oct '19

Module: wine Branch: master Commit: 4f07e4f014587d016ea159c16052d30f0ea72a43 URL: https://source.winehq.org/git/wine.git/?a=commit;h=4f07e4f014587d016ea159c1… Author: Sven Baars <sven.wine(a)gmail.com> Date: Mon Oct 21 11:22:06 2019 +0200 webservices: Fix some leaks on error paths (Coverity). Signed-off-by: Sven Baars <sven.wine(a)gmail.com> Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/webservices/msg.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/dlls/webservices/msg.c b/dlls/webservices/msg.c index a006841be6..6922224a05 100644 --- a/dlls/webservices/msg.c +++ b/dlls/webservices/msg.c @@ -1552,12 +1552,12 @@ HRESULT WINAPI WsRemoveMappedHeader( WS_MESSAGE *handle, const WS_XML_STRING *na return hr; } -static HRESULT xmlstring_to_wsz( const WS_XML_STRING *str, WS_HEAP *heap, WCHAR **ret ) +static HRESULT xmlstring_to_wsz( const WS_XML_STRING *str, WS_HEAP *heap, WCHAR **ret, int *len ) { - int len = MultiByteToWideChar( CP_UTF8, 0, (char *)str->bytes, str->length, NULL, 0 ); - if (!(*ret = ws_alloc( heap, (len + 1) * sizeof(WCHAR) ))) return WS_E_QUOTA_EXCEEDED; - MultiByteToWideChar( CP_UTF8, 0, (char *)str->bytes, str->length, *ret, len ); - (*ret)[len] = 0; + *len = MultiByteToWideChar( CP_UTF8, 0, (char *)str->bytes, str->length, NULL, 0 ); + if (!(*ret = ws_alloc( heap, (*len + 1) * sizeof(WCHAR) ))) return WS_E_QUOTA_EXCEEDED; + MultiByteToWideChar( CP_UTF8, 0, (char *)str->bytes, str->length, *ret, *len ); + (*ret)[*len] = 0; return S_OK; } @@ -1565,9 +1565,10 @@ static HRESULT get_header_value_wsz( struct header *header, WS_READ_OPTION optio ULONG size ) { WCHAR *str = NULL; + int len = 0; HRESULT hr; - if (header && (hr = xmlstring_to_wsz( header->u.text, heap, &str )) != S_OK) return hr; + if (header && (hr = xmlstring_to_wsz( header->u.text, heap, &str, &len )) != S_OK) return hr; switch (option) { @@ -1577,12 +1578,17 @@ static HRESULT get_header_value_wsz( struct header *header, WS_READ_OPTION optio case WS_READ_OPTIONAL_POINTER: case WS_READ_NILLABLE_POINTER: - if (size != sizeof(str)) return E_INVALIDARG; + if (size != sizeof(str)) + { + ws_free( heap, str, (len + 1) * sizeof(WCHAR) ); + return E_INVALIDARG; + } *ret = str; break; default: FIXME( "read option %u not supported\n", option ); + ws_free( heap, str, (len + 1) * sizeof(WCHAR) ); return E_NOTIMPL; }

1 0

Sven Baars : scrobj: Add a missing return value check (Coverity).
by Alexandre Julliard 21 Oct '19

21 Oct '19

Module: wine Branch: master Commit: 43eb22c57f3a6227f23178205139c775199db2c8 URL: https://source.winehq.org/git/wine.git/?a=commit;h=43eb22c57f3a6227f2317820… Author: Sven Baars <sven.wine(a)gmail.com> Date: Sat Oct 19 21:20:54 2019 +0200 scrobj: Add a missing return value check (Coverity). Signed-off-by: Sven Baars <sven.wine(a)gmail.com> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/scrobj/scrobj.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/scrobj/scrobj.c b/dlls/scrobj/scrobj.c index 1d37864039..427e4e5439 100644 --- a/dlls/scrobj/scrobj.c +++ b/dlls/scrobj/scrobj.c @@ -1695,6 +1695,8 @@ static HRESULT parse_scriptlet_file(struct scriptlet_factory *factory, const WCH hres = next_xml_node(factory, &node_type); if (hres == S_OK && node_type == XmlNodeType_XmlDeclaration) hres = next_xml_node(factory, &node_type); + if (FAILED(hres)) + return hres; if (node_type != XmlNodeType_Element || !is_xml_name(factory, L"component")) {

1 0

Sven Baars : scrobj/tests: Don't set site to NULL before it has been freed (Valgrind).
by Alexandre Julliard 21 Oct '19

21 Oct '19

Module: wine Branch: master Commit: dd9d2bdbbd760e3d9e7a59e63cbb0a175087adad URL: https://source.winehq.org/git/wine.git/?a=commit;h=dd9d2bdbbd760e3d9e7a59e6… Author: Sven Baars <sven.wine(a)gmail.com> Date: Mon Oct 21 14:18:26 2019 +0200 scrobj/tests: Don't set site to NULL before it has been freed (Valgrind). Signed-off-by: Sven Baars <sven.wine(a)gmail.com> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/scrobj/tests/scrobj.c | 1 - 1 file changed, 1 deletion(-) diff --git a/dlls/scrobj/tests/scrobj.c b/dlls/scrobj/tests/scrobj.c index 023aa30f92..93779883fe 100644 --- a/dlls/scrobj/tests/scrobj.c +++ b/dlls/scrobj/tests/scrobj.c @@ -634,7 +634,6 @@ static HRESULT WINAPI ClassFactory_CreateInstance(IClassFactory *iface, IUnknown ok(!outer, "outer = %p\n", outer); ok(IsEqualGUID(&IID_IUnknown, riid), "unexpected riid %s\n", wine_dbgstr_guid(riid)); *ppv = &ActiveScript; - site = NULL; return S_OK; }

1 0

Sven Baars : scrobj: Fix some leaks on error paths (Coverity).
by Alexandre Julliard 21 Oct '19

21 Oct '19

Module: wine Branch: master Commit: fae51bd740339c3a15a1dd4751ec0eb994ee1551 URL: https://source.winehq.org/git/wine.git/?a=commit;h=fae51bd740339c3a15a1dd47… Author: Sven Baars <sven.wine(a)gmail.com> Date: Mon Oct 21 14:18:25 2019 +0200 scrobj: Fix some leaks on error paths (Coverity). Signed-off-by: Sven Baars <sven.wine(a)gmail.com> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/scrobj/scrobj.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/dlls/scrobj/scrobj.c b/dlls/scrobj/scrobj.c index ce5a3dedd1..1d37864039 100644 --- a/dlls/scrobj/scrobj.c +++ b/dlls/scrobj/scrobj.c @@ -1491,6 +1491,7 @@ static HRESULT parse_scriptlet_public(struct scriptlet_factory *factory) if (!wcsicmp(member_iter->name, member->name)) { FIXME("Duplicated member %s\n", debugstr_w(member->name)); + heap_free(member); return E_FAIL; } } @@ -1529,11 +1530,11 @@ static HRESULT parse_scriptlet_public(struct scriptlet_factory *factory) return E_FAIL; } - if (!(parameter = heap_alloc(sizeof(*parameter)))) return E_OUTOFMEMORY; + if (!(parameter = heap_alloc_zero(sizeof(*parameter)))) return E_OUTOFMEMORY; + list_add_tail(&member->u.parameters, &parameter->entry); hres = read_xml_value(factory, &parameter->name); if (FAILED(hres)) return hres; - list_add_tail(&member->u.parameters, &parameter->entry); if (!empty && FAILED(hres = expect_end_element(factory))) return hres; } break;

1 0

Francois Gouget : msi: Fix the spelling of a comment.
by Alexandre Julliard 21 Oct '19

21 Oct '19

Module: wine Branch: master Commit: a0c6c8c2ecdad0bf8992b6c89276ee7bf2402883 URL: https://source.winehq.org/git/wine.git/?a=commit;h=a0c6c8c2ecdad0bf8992b6c8… Author: Francois Gouget <fgouget(a)free.fr> Date: Mon Oct 21 06:21:39 2019 +0200 msi: Fix the spelling of a comment. Signed-off-by: Francois Gouget <fgouget(a)free.fr> Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msi/action.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/msi/action.c b/dlls/msi/action.c index f6f7ffbcf4..048d5983a9 100644 --- a/dlls/msi/action.c +++ b/dlls/msi/action.c @@ -5878,7 +5878,7 @@ end: } /* - * At present I am ignorning the advertised components part of this and only + * At present I am ignoring the advertised components part of this and only * focusing on the qualified component sets */ static UINT ACTION_PublishComponents(MSIPACKAGE *package)

1 0

Francois Gouget : msi/tests: Fix the case of an ok() message.
by Alexandre Julliard 21 Oct '19

21 Oct '19

Module: wine Branch: master Commit: 3f2cae1378cc14e98747af6c0de02cb1e6a69928 URL: https://source.winehq.org/git/wine.git/?a=commit;h=3f2cae1378cc14e98747af6c… Author: Francois Gouget <fgouget(a)free.fr> Date: Mon Oct 21 06:21:28 2019 +0200 msi/tests: Fix the case of an ok() message. Signed-off-by: Francois Gouget <fgouget(a)free.fr> Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msi/tests/format.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/msi/tests/format.c b/dlls/msi/tests/format.c index 6cb52cf04d..88d8180a50 100644 --- a/dlls/msi/tests/format.c +++ b/dlls/msi/tests/format.c @@ -1771,7 +1771,7 @@ static void test_formatrecord_package(void) ok( 0 == strcmp(buffer,"1: 2: 3: 4: 5: 6: 7: 8: 9: 10: 11: 12: "), "wrong output(%s)\n",buffer); r = MsiSetPropertyA(package, "prop", "val"); - ok( r == ERROR_SUCCESS, "failed to set propertY: %d\n", r); + ok( r == ERROR_SUCCESS, "failed to set property: %d\n", r); r = MsiRecordSetStringA(hrec, 0, NULL); ok( r == ERROR_SUCCESS, "set string failed\n");

1 0

← Newer
1
...
25
26
27
28
29
30
31
...
62
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits October 2019