winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
November 2019
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
1 participants
895 discussions
Start a n
N
ew thread
Alexandre Julliard : ntdll: Move locale functions to a new locale.c file.
by Alexandre Julliard
19 Nov '19
19 Nov '19
Module: wine Branch: master Commit: 4538a137e089240f1981f0d6f82fb8d63a65f4f6 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=4538a137e089240f1981f0d6…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Nov 13 20:55:03 2019 +0100 ntdll: Move locale functions to a new locale.c file. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/Makefile.in | 1 + dlls/ntdll/directory.c | 134 --------------------------- dlls/ntdll/loader.c | 1 + dlls/ntdll/locale.c | 236 ++++++++++++++++++++++++++++++++++++++++++++++++ dlls/ntdll/ntdll_misc.h | 4 +- dlls/ntdll/resource.c | 59 +----------- 6 files changed, 242 insertions(+), 193 deletions(-) Diff:
https://source.winehq.org/git/wine.git/?a=commitdiff;h=4538a137e089240f1981…
1
0
0
0
Alexandre Julliard : kernel32: Add more special cases in ConvertDefaultLocale().
by Alexandre Julliard
19 Nov '19
19 Nov '19
Module: wine Branch: master Commit: 4b1a8d63615d0e553fd4021a7b135192467220cb URL:
https://source.winehq.org/git/wine.git/?a=commit;h=4b1a8d63615d0e553fd4021a…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Nov 19 09:58:20 2019 +0100 kernel32: Add more special cases in ConvertDefaultLocale(). --- dlls/kernel32/locale.c | 41 ++++++++++++++++--------- dlls/kernel32/tests/locale.c | 73 ++++++++++++++++++++++++++++++++------------ 2 files changed, 81 insertions(+), 33 deletions(-) Diff:
https://source.winehq.org/git/wine.git/?a=commitdiff;h=4b1a8d63615d0e553fd4…
1
0
0
0
Alexandre Julliard : kernel32: Move system information functions to kernelbase.
by Alexandre Julliard
19 Nov '19
19 Nov '19
Module: wine Branch: master Commit: 71aba33fc68e97d1b49a9207c8fc2ef733b604a7 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=71aba33fc68e97d1b49a9207…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Nov 18 18:57:26 2019 +0100 kernel32: Move system information functions to kernelbase. --- dlls/kernel32/cpu.c | 151 ---------------------------------------- dlls/kernel32/kernel32.spec | 10 +-- dlls/kernelbase/kernelbase.spec | 10 +-- dlls/kernelbase/memory.c | 147 ++++++++++++++++++++++++++++++++++++++ 4 files changed, 157 insertions(+), 161 deletions(-) Diff:
https://source.winehq.org/git/wine.git/?a=commitdiff;h=71aba33fc68e97d1b49a…
1
0
0
0
Alexandre Julliard : kernel32: Move physical memory status functions to kernelbase.
by Alexandre Julliard
19 Nov '19
19 Nov '19
Module: wine Branch: master Commit: b73cfa72edaed76744cfa9a19670bff3684c66ce URL:
https://source.winehq.org/git/wine.git/?a=commit;h=b73cfa72edaed76744cfa9a1…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Nov 18 15:05:04 2019 +0100 kernel32: Move physical memory status functions to kernelbase. --- dlls/kernel32/heap.c | 274 +--------------------------------------- dlls/kernel32/kernel32.spec | 4 +- dlls/kernelbase/kernelbase.spec | 4 +- dlls/kernelbase/memory.c | 77 +++++++++++ 4 files changed, 83 insertions(+), 276 deletions(-) Diff:
https://source.winehq.org/git/wine.git/?a=commitdiff;h=b73cfa72edaed76744cf…
1
0
0
0
Alexandre Julliard : ntdll: Support SystemPerformanceInformation on non-Linux platforms.
by Alexandre Julliard
19 Nov '19
19 Nov '19
Module: wine Branch: master Commit: dad14ab8331922171393d6ef75861303c8bc8d50 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=dad14ab8331922171393d6ef…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Nov 18 14:55:00 2019 +0100 ntdll: Support SystemPerformanceInformation on non-Linux platforms. Based on the GlobalMemoryStatusEx implementation. --- dlls/ntdll/nt.c | 197 ++++++++++++++++++++++++++++++++++++++++++-------------- 1 file changed, 147 insertions(+), 50 deletions(-) diff --git a/dlls/ntdll/nt.c b/dlls/ntdll/nt.c index b6daa226b3..c9b278d3fc 100644 --- a/dlls/ntdll/nt.c +++ b/dlls/ntdll/nt.c @@ -50,6 +50,19 @@ #endif #include <time.h> +#ifdef sun +/* FIXME: Unfortunately swapctl can't be used with largefile.... */ +# undef _FILE_OFFSET_BITS +# define _FILE_OFFSET_BITS 32 +# ifdef HAVE_SYS_RESOURCE_H +# include <sys/resource.h> +# endif +# ifdef HAVE_SYS_STAT_H +# include <sys/stat.h> +# endif +# include <sys/swap.h> +#endif + #define NONAMELESSUNION #include "ntstatus.h" #define WIN32_NO_STATUS @@ -2347,6 +2360,139 @@ static NTSTATUS get_firmware_info(SYSTEM_FIRMWARE_TABLE_INFORMATION *sfti, ULONG #endif +static void get_performance_info( SYSTEM_PERFORMANCE_INFORMATION *info ) +{ + unsigned long long totalram = 0, freeram = 0, totalswap = 0, freeswap = 0; + FILE *fp; + + memset( info, 0, sizeof(*info) ); + + if ((fp = fopen("/proc/uptime", "r"))) + { + double uptime, idle_time; + + fscanf(fp, "%lf %lf", &uptime, &idle_time); + fclose(fp); + info->IdleTime.QuadPart = 10000000 * idle_time; + } + else + { + static ULONGLONG idle; + /* many programs expect IdleTime to change so fake change */ + info->IdleTime.QuadPart = ++idle; + } + +#ifdef linux + if ((fp = fopen("/proc/meminfo", "r"))) + { + unsigned long long value; + char line[64]; + + while (fgets(line, sizeof(line), fp)) + { + if(sscanf(line, "MemTotal: %llu kB", &value) == 1) + totalram += value * 1024; + else if(sscanf(line, "MemFree: %llu kB", &value) == 1) + freeram += value * 1024; + else if(sscanf(line, "SwapTotal: %llu kB", &value) == 1) + totalswap += value * 1024; + else if(sscanf(line, "SwapFree: %llu kB", &value) == 1) + freeswap += value * 1024; + else if (sscanf(line, "Buffers: %llu", &value)) + freeram += value * 1024; + else if (sscanf(line, "Cached: %llu", &value)) + freeram += value * 1024; + } + fclose(fp); + } +#elif defined(__FreeBSD__) || defined(__FreeBSD_kernel__) || defined(__NetBSD__) || \ + defined(__OpenBSD__) || defined(__DragonFly__) || defined(__APPLE__) + { +#ifdef __APPLE__ + unsigned int val; +#else + unsigned long val; +#endif + int mib[2]; + size_t size_sys; + + mib[0] = CTL_HW; +#ifdef HW_MEMSIZE + { + uint64_t val64; + mib[1] = HW_MEMSIZE; + size_sys = sizeof(val64); + if (!sysctl(mib, 2, &val64, &size_sys, NULL, 0) && size_sys == sizeof(val64)) totalram = val64; + } +#endif + +#ifdef HAVE_MACH_MACH_H + { + host_name_port_t host = mach_host_self(); + mach_msg_type_number_t count; +#ifdef HOST_VM_INFO64_COUNT + vm_statistics64_data_t vm_stat; + + count = HOST_VM_INFO64_COUNT; + if (host_statistics64(host, HOST_VM_INFO64, (host_info64_t)&vm_stat, &count) == KERN_SUCCESS) + freeram = (vm_stat.free_count + vm_stat.inactive_count) * (ULONGLONG)page_size; +#endif + if (!totalram) + { + host_basic_info_data_t info; + count = HOST_BASIC_INFO_COUNT; + if (host_info(host, HOST_BASIC_INFO, (host_info_t)&info, &count) == KERN_SUCCESS) + totalram = info.max_mem; + } + mach_port_deallocate(mach_task_self(), host); + } +#endif + + if (!totalram) + { + mib[1] = HW_PHYSMEM; + size_sys = sizeof(val); + if (!sysctl(mib, 2, &val, &size_sys, NULL, 0) && size_sys == sizeof(val)) totalram = val; + } + if (!freeram) + { + mib[1] = HW_USERMEM; + size_sys = sizeof(val); + if (!sysctl(mib, 2, &val, &size_sys, NULL, 0) && size_sys == sizeof(val)) freeram = val; + } +#ifdef VM_SWAPUSAGE + { + struct xsw_usage swap; + mib[0] = CTL_VM; + mib[1] = VM_SWAPUSAGE; + size_sys = sizeof(swap); + if (!sysctl(mib, 2, &swap, &size_sys, NULL, 0) && size_sys == sizeof(swap)) + { + totalswap = swap.xsu_total; + freeswap = swap.xsu_avail; + } + } +#endif + } +#elif defined( sun ) + { + struct anoninfo swapinf; + int rval; + totalram = sysconf(_SC_PHYS_PAGES) * (ULONGLONG)page_size; + freeram = sysconf(_SC_AVPHYS_PAGES) * (ULONGLONG)page_size; + rval = swapctl(SC_AINFO, &swapinf); + if (rval > -1) + { + totalswap = swapinf.ani_max * (ULONGLONG)page_size; + freeswap = swapinf.ani_free * (ULONGLONG)page_size; + } + } +#endif + info->AvailablePages = freeram / page_size; + info->TotalCommittedPages = (totalram + totalswap - freeram - freeswap) / page_size; + info->TotalCommitLimit = (totalram + totalswap) / page_size; +} + /*********************************************************************** * RtlIsProcessorFeaturePresent [NTDLL.@] */ @@ -2415,59 +2561,10 @@ NTSTATUS WINAPI NtQuerySystemInformation( { SYSTEM_PERFORMANCE_INFORMATION spi; static BOOL fixme_written = FALSE; - FILE *fp; - memset(&spi, 0 , sizeof(spi)); + get_performance_info( &spi ); len = sizeof(spi); - spi.Reserved3 = 0x7fffffff; /* Available paged pool memory? */ - - if ((fp = fopen("/proc/uptime", "r"))) - { - double uptime, idle_time; - - fscanf(fp, "%lf %lf", &uptime, &idle_time); - fclose(fp); - spi.IdleTime.QuadPart = 10000000 * idle_time; - } - else - { - static ULONGLONG idle; - /* many programs expect IdleTime to change so fake change */ - spi.IdleTime.QuadPart = ++idle; - } - - if ((fp = fopen("/proc/meminfo", "r"))) - { - unsigned long long totalram = 0, freeram = 0, totalswap = 0, freeswap = 0; - char line[64]; - while (fgets(line, sizeof(line), fp)) - { - if(sscanf(line, "MemTotal: %llu kB", &totalram) == 1) - { - totalram *= 1024; - } - else if(sscanf(line, "MemFree: %llu kB", &freeram) == 1) - { - freeram *= 1024; - } - else if(sscanf(line, "SwapTotal: %llu kB", &totalswap) == 1) - { - totalswap *= 1024; - } - else if(sscanf(line, "SwapFree: %llu kB", &freeswap) == 1) - { - freeswap *= 1024; - break; - } - } - fclose(fp); - - spi.AvailablePages = freeram / page_size; - spi.TotalCommittedPages = (totalram + totalswap - freeram - freeswap) / page_size; - spi.TotalCommitLimit = (totalram + totalswap) / page_size; - } - if (Length >= len) { if (!SystemInformation) ret = STATUS_ACCESS_VIOLATION;
1
0
0
0
Zebediah Figura : strmbase: Avoid unnecessary use of IPin::ConnectedTo().
by Alexandre Julliard
19 Nov '19
19 Nov '19
Module: wine Branch: master Commit: cc78d104054378570b0d4a244efb5a3e95b92cb0 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=cc78d104054378570b0d4a24…
Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Mon Nov 18 18:51:24 2019 -0600 strmbase: Avoid unnecessary use of IPin::ConnectedTo(). Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/strmbase/outputqueue.c | 24 +++++++----------------- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/dlls/strmbase/outputqueue.c b/dlls/strmbase/outputqueue.c index ee05653d7a..dbcc4b6d0d 100644 --- a/dlls/strmbase/outputqueue.c +++ b/dlls/strmbase/outputqueue.c @@ -177,6 +177,8 @@ VOID WINAPI OutputQueue_SendAnyway(OutputQueue *pOutputQueue) VOID WINAPI OutputQueue_EOS(OutputQueue *pOutputQueue) { + IPin *peer; + EnterCriticalSection(&pOutputQueue->csQueue); if (pOutputQueue->hThread) { @@ -191,16 +193,8 @@ VOID WINAPI OutputQueue_EOS(OutputQueue *pOutputQueue) qev->pSample = NULL; list_add_tail(&pOutputQueue->SampleList, &qev->entry); } - else - { - IPin* ppin = NULL; - IPin_ConnectedTo(&pOutputQueue->pInputPin->pin.IPin_iface, &ppin); - if (ppin) - { - IPin_EndOfStream(ppin); - IPin_Release(ppin); - } - } + else if ((peer = pOutputQueue->pInputPin->pin.peer)) + IPin_EndOfStream(peer); LeaveCriticalSection(&pOutputQueue->csQueue); /* Covers sending the Event to the worker Thread */ OutputQueue_SendAnyway(pOutputQueue); @@ -259,13 +253,9 @@ DWORD WINAPI OutputQueueImpl_ThreadProc(OutputQueue *pOutputQueue) QueuedEvent *qev = LIST_ENTRY(cursor, QueuedEvent, entry); if (qev->type == EOS_PACKET) { - IPin* ppin = NULL; - IPin_ConnectedTo(&pOutputQueue->pInputPin->pin.IPin_iface, &ppin); - if (ppin) - { - IPin_EndOfStream(ppin); - IPin_Release(ppin); - } + IPin *peer; + if ((peer = pOutputQueue->pInputPin->pin.peer)) + IPin_EndOfStream(peer); } else if (qev->type == SAMPLE_PACKET) break;
1
0
0
0
Zebediah Figura : quartz/videorenderer: Avoid calling IPin::ConnectionMediaType() on our own pin.
by Alexandre Julliard
19 Nov '19
19 Nov '19
Module: wine Branch: master Commit: bcb05ad29b7cf1bcda29f5b019cf2636b3491f4a URL:
https://source.winehq.org/git/wine.git/?a=commit;h=bcb05ad29b7cf1bcda29f5b0…
Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Mon Nov 18 18:51:23 2019 -0600 quartz/videorenderer: Avoid calling IPin::ConnectionMediaType() on our own pin. Avoids leaking the format block. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/quartz/videorenderer.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/dlls/quartz/videorenderer.c b/dlls/quartz/videorenderer.c index 18e5f618b0..b71d15a5d2 100644 --- a/dlls/quartz/videorenderer.c +++ b/dlls/quartz/videorenderer.c @@ -136,30 +136,23 @@ static void VideoRenderer_AutoShowWindow(VideoRendererImpl *This) static DWORD VideoRenderer_SendSampleData(VideoRendererImpl* This, LPBYTE data, DWORD size) { - AM_MEDIA_TYPE amt; - HRESULT hr = S_OK; + const AM_MEDIA_TYPE *amt = &This->renderer.sink.pin.mt; BITMAPINFOHEADER *bmiHeader; HDC dc; TRACE("(%p)->(%p, %d)\n", This, data, size); - hr = IPin_ConnectionMediaType(&This->renderer.sink.pin.IPin_iface, &amt); - if (FAILED(hr)) { - ERR("Unable to retrieve media type\n"); - return hr; - } - - if (IsEqualIID(&amt.formattype, &FORMAT_VideoInfo)) + if (IsEqualGUID(&amt->formattype, &FORMAT_VideoInfo)) { - bmiHeader = &((VIDEOINFOHEADER *)amt.pbFormat)->bmiHeader; + bmiHeader = &((VIDEOINFOHEADER *)amt->pbFormat)->bmiHeader; } - else if (IsEqualIID(&amt.formattype, &FORMAT_VideoInfo2)) + else if (IsEqualGUID(&amt->formattype, &FORMAT_VideoInfo2)) { - bmiHeader = &((VIDEOINFOHEADER2 *)amt.pbFormat)->bmiHeader; + bmiHeader = &((VIDEOINFOHEADER2 *)amt->pbFormat)->bmiHeader; } else { - FIXME("Unknown type %s\n", debugstr_guid(&amt.subtype)); + FIXME("Unknown subtype %s.\n", debugstr_guid(&amt->subtype)); return VFW_E_RUNTIME_ERROR; }
1
0
0
0
Zebediah Figura : wineqtdecoder: Simplify disconnecting the sink's peer in qt_splitter_destroy().
by Alexandre Julliard
19 Nov '19
19 Nov '19
Module: wine Branch: master Commit: 31bd0a6abbf2816c428c4044227d190b6ccda8d5 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=31bd0a6abbf2816c428c4044…
Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Mon Nov 18 18:51:22 2019 -0600 wineqtdecoder: Simplify disconnecting the sink's peer in qt_splitter_destroy(). Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wineqtdecoder/qtsplitter.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/dlls/wineqtdecoder/qtsplitter.c b/dlls/wineqtdecoder/qtsplitter.c index a7da3b37d6..2da0f691dc 100644 --- a/dlls/wineqtdecoder/qtsplitter.c +++ b/dlls/wineqtdecoder/qtsplitter.c @@ -234,12 +234,9 @@ static void qt_splitter_destroy(struct strmbase_filter *iface) EnterCriticalSection(&filter->csReceive); /* Don't need to clean up output pins, disconnecting input pin will do that */ - IPin_ConnectedTo(&filter->pInputPin.pin.IPin_iface, &peer); - if (peer) - { - IPin_Disconnect(peer); - IPin_Release(peer); - } + + if (filter->pInputPin.pin.peer) + IPin_Disconnect(filter->pInputPin.pin.peer); FreeMediaType(&filter->pInputPin.pin.mt); if (filter->pInputPin.pAlloc)
1
0
0
0
Zebediah Figura : strmbase: Forbid (dis)connecting pins if the filter is not stopped.
by Alexandre Julliard
19 Nov '19
19 Nov '19
Module: wine Branch: master Commit: 2a6037e263ff3fae8ca82d90b0b141bea1cd473d URL:
https://source.winehq.org/git/wine.git/?a=commit;h=2a6037e263ff3fae8ca82d90…
Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Mon Nov 18 18:51:21 2019 -0600 strmbase: Forbid (dis)connecting pins if the filter is not stopped. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/strmbase/pin.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/dlls/strmbase/pin.c b/dlls/strmbase/pin.c index c7f1ed2af4..8c337ca471 100644 --- a/dlls/strmbase/pin.c +++ b/dlls/strmbase/pin.c @@ -366,6 +366,13 @@ HRESULT WINAPI BaseOutputPinImpl_Connect(IPin * iface, IPin * pReceivePin, const EnterCriticalSection(&This->pin.filter->csFilter); { + if (This->pin.filter->state != State_Stopped) + { + LeaveCriticalSection(&This->pin.filter->csFilter); + WARN("Filter is not stopped; returning VFW_E_NOT_STOPPED.\n"); + return VFW_E_NOT_STOPPED; + } + /* if we have been a specific type to connect with, then we can either connect * with that or fail. We cannot choose different AM_MEDIA_TYPE */ if (pmt && !IsEqualGUID(&pmt->majortype, &GUID_NULL) && !IsEqualGUID(&pmt->subtype, &GUID_NULL)) @@ -447,6 +454,13 @@ HRESULT WINAPI BaseOutputPinImpl_Disconnect(IPin * iface) EnterCriticalSection(&This->pin.filter->csFilter); { + if (This->pin.filter->state != State_Stopped) + { + LeaveCriticalSection(&This->pin.filter->csFilter); + WARN("Filter is not stopped; returning VFW_E_NOT_STOPPED.\n"); + return VFW_E_NOT_STOPPED; + } + if (This->pMemInputPin) { IMemInputPin_Release(This->pMemInputPin); @@ -730,6 +744,13 @@ HRESULT WINAPI BaseInputPinImpl_ReceiveConnection(IPin * iface, IPin * pReceiveP EnterCriticalSection(&This->pin.filter->csFilter); { + if (This->pin.filter->state != State_Stopped) + { + LeaveCriticalSection(&This->pin.filter->csFilter); + WARN("Filter is not stopped; returning VFW_E_NOT_STOPPED.\n"); + return VFW_E_NOT_STOPPED; + } + if (This->pin.peer) hr = VFW_E_ALREADY_CONNECTED;
1
0
0
0
Zebediah Figura : strmbase: Rename the "mtCurrent" field of struct strmbase_pin to "mt".
by Alexandre Julliard
19 Nov '19
19 Nov '19
Module: wine Branch: master Commit: 03f0479c34ec1d9cf732728f740113fedd48a10c URL:
https://source.winehq.org/git/wine.git/?a=commit;h=03f0479c34ec1d9cf732728f…
Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Mon Nov 18 18:51:20 2019 -0600 strmbase: Rename the "mtCurrent" field of struct strmbase_pin to "mt". Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/qcap/avico.c | 4 ++-- dlls/qcap/avimux.c | 2 +- dlls/qcap/smartteefilter.c | 4 ++-- dlls/quartz/dsoundrender.c | 14 +++++++------- dlls/quartz/filesource.c | 4 ++-- dlls/quartz/tests/videorenderer.c | 4 ++-- dlls/quartz/tests/vmr7.c | 4 ++-- dlls/quartz/tests/vmr9.c | 4 ++-- dlls/quartz/videorenderer.c | 4 ++-- dlls/quartz/vmr9.c | 6 +++--- dlls/strmbase/pin.c | 20 ++++++++++---------- dlls/winegstreamer/gstdemux.c | 4 ++-- dlls/wineqtdecoder/qtsplitter.c | 4 ++-- include/wine/strmbase.h | 2 +- 14 files changed, 40 insertions(+), 40 deletions(-) Diff:
https://source.winehq.org/git/wine.git/?a=commitdiff;h=03f0479c34ec1d9cf732…
1
0
0
0
← Newer
1
...
42
43
44
45
46
47
48
...
90
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
Results per page:
10
25
50
100
200