wine-commits December 2019

wine-commits@winehq.org

1 participants
635 discussions

Conor McCarthy : vkd3d/tests: Add tests for ID3D12GraphicsCommandList2::WriteBufferImmediate().
by Alexandre Julliard 06 Dec '19

06 Dec '19

Module: vkd3d Branch: master Commit: 0d43c776c50c36743f765eb9f2ce18e985a5b1cc URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=0d43c776c50c36743f765eb… Author: Conor McCarthy <cmccarthy(a)codeweavers.com> Date: Fri Dec 6 22:51:16 2019 +0330 vkd3d/tests: Add tests for ID3D12GraphicsCommandList2::WriteBufferImmediate(). Signed-off-by: Conor McCarthy <cmccarthy(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/vkd3d_d3d12.idl | 26 +++++++++++++++ tests/d3d12.c | 84 +++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 110 insertions(+) diff --git a/include/vkd3d_d3d12.idl b/include/vkd3d_d3d12.idl index b887480..3bfe47b 100644 --- a/include/vkd3d_d3d12.idl +++ b/include/vkd3d_d3d12.idl @@ -177,6 +177,13 @@ typedef enum D3D12_FORMAT_SUPPORT2 D3D12_FORMAT_SUPPORT2_MULTIPLANE_OVERLAY = 0x00004000, } D3D12_FORMAT_SUPPORT2; +typedef enum D3D12_WRITEBUFFERIMMEDIATE_MODE +{ + D3D12_WRITEBUFFERIMMEDIATE_MODE_DEFAULT = 0x0, + D3D12_WRITEBUFFERIMMEDIATE_MODE_MARKER_IN = 0x1, + D3D12_WRITEBUFFERIMMEDIATE_MODE_MARKER_OUT = 0x2, +} D3D12_WRITEBUFFERIMMEDIATE_MODE; + interface ID3D12Fence; interface ID3D12RootSignature; interface ID3D12Heap; @@ -1657,6 +1664,12 @@ typedef enum D3D12_RESIDENCY_PRIORITY D3D12_RESIDENCY_PRIORITY_MAXIMUM = 0xc8000000, } D3D12_RESIDENCY_PRIORITY; +typedef struct D3D12_WRITEBUFFERIMMEDIATE_PARAMETER +{ + D3D12_GPU_VIRTUAL_ADDRESS Dest; + UINT32 Value; +} D3D12_WRITEBUFFERIMMEDIATE_PARAMETER; + [ uuid(c4fec28f-7966-4e95-9f94-f431cb56c3b8), object, @@ -2004,6 +2017,19 @@ interface ID3D12GraphicsCommandList1 : ID3D12GraphicsCommandList void SetViewInstanceMask(UINT mask); } +[ + uuid(38c3e585-ff17-412c-9150-4fc6f9d72a28), + object, + local, + pointer_default(unique) +] +interface ID3D12GraphicsCommandList2 : ID3D12GraphicsCommandList1 +{ + void WriteBufferImmediate(UINT count, + const D3D12_WRITEBUFFERIMMEDIATE_PARAMETER *parameters, + const D3D12_WRITEBUFFERIMMEDIATE_MODE *modes); +} + typedef enum D3D12_TILE_RANGE_FLAGS { D3D12_TILE_RANGE_FLAG_NONE = 0x0, diff --git a/tests/d3d12.c b/tests/d3d12.c index 578ae56..b08f115 100644 --- a/tests/d3d12.c +++ b/tests/d3d12.c @@ -32728,6 +32728,89 @@ static void test_bufinfo_instruction(void) destroy_test_context(&context); } +static void test_write_buffer_immediate(void) +{ + D3D12_WRITEBUFFERIMMEDIATE_PARAMETER parameters[2]; + ID3D12GraphicsCommandList2 *command_list2; + D3D12_WRITEBUFFERIMMEDIATE_MODE modes[2]; + ID3D12GraphicsCommandList *command_list; + struct resource_readback rb; + struct test_context context; + ID3D12CommandQueue *queue; + ID3D12Resource *buffer; + ID3D12Device *device; + unsigned int value; + HRESULT hr; + + static const unsigned int data_values[] = {0xdeadbeef, 0xf00baa}; + + if (!init_test_context(&context, NULL)) + return; + device = context.device; + command_list = context.list; + queue = context.queue; + + if (FAILED(hr = ID3D12GraphicsCommandList_QueryInterface(command_list, + &IID_ID3D12GraphicsCommandList2, (void **)&command_list2))) + { + skip("ID3D12GraphicsCommandList2 not implemented.\n"); + destroy_test_context(&context); + return; + } + + buffer = create_default_buffer(device, sizeof(data_values), + D3D12_RESOURCE_FLAG_NONE, D3D12_RESOURCE_STATE_COPY_DEST); + upload_buffer_data(buffer, 0, sizeof(data_values), data_values, queue, command_list); + reset_command_list(command_list, context.allocator); + + parameters[0].Dest = ID3D12Resource_GetGPUVirtualAddress(buffer); + parameters[0].Value = 0x1020304; + parameters[1].Dest = parameters[0].Dest + sizeof(data_values[0]); + parameters[1].Value = 0xc0d0e0f; + ID3D12GraphicsCommandList2_WriteBufferImmediate(command_list2, ARRAY_SIZE(parameters), parameters, NULL); + hr = ID3D12GraphicsCommandList_Close(command_list); + ok(hr == S_OK, "Got unexpected hr %#x.\n", hr); + exec_command_list(queue, command_list); + wait_queue_idle(device, queue); + reset_command_list(command_list, context.allocator); + + get_buffer_readback_with_command_list(buffer, DXGI_FORMAT_R32_UINT, &rb, queue, command_list); + value = get_readback_uint(&rb, 0, 0, 0); + ok(value == parameters[0].Value, "Got unexpected value %#x, expected %#x.\n", value, parameters[0].Value); + value = get_readback_uint(&rb, 1, 0, 0); + ok(value == parameters[1].Value, "Got unexpected value %#x, expected %#x.\n", value, parameters[1].Value); + release_resource_readback(&rb); + reset_command_list(command_list, context.allocator); + + parameters[0].Value = 0x2030405; + parameters[1].Value = 0xb0c0d0e; + modes[0] = D3D12_WRITEBUFFERIMMEDIATE_MODE_MARKER_IN; + modes[1] = D3D12_WRITEBUFFERIMMEDIATE_MODE_MARKER_OUT; + ID3D12GraphicsCommandList2_WriteBufferImmediate(command_list2, ARRAY_SIZE(parameters), parameters, modes); + hr = ID3D12GraphicsCommandList_Close(command_list); + ok(hr == S_OK, "Got unexpected hr %#x.\n", hr); + exec_command_list(queue, command_list); + wait_queue_idle(device, queue); + reset_command_list(command_list, context.allocator); + + get_buffer_readback_with_command_list(buffer, DXGI_FORMAT_R32_UINT, &rb, queue, command_list); + value = get_readback_uint(&rb, 0, 0, 0); + ok(value == parameters[0].Value, "Got unexpected value %#x, expected %#x.\n", value, parameters[0].Value); + value = get_readback_uint(&rb, 1, 0, 0); + ok(value == parameters[1].Value, "Got unexpected value %#x, expected %#x.\n", value, parameters[1].Value); + release_resource_readback(&rb); + reset_command_list(command_list, context.allocator); + + modes[0] = 0x7fffffff; + ID3D12GraphicsCommandList2_WriteBufferImmediate(command_list2, ARRAY_SIZE(parameters), parameters, modes); + hr = ID3D12GraphicsCommandList_Close(command_list); + ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr); + + ID3D12Resource_Release(buffer); + ID3D12GraphicsCommandList2_Release(command_list2); + destroy_test_context(&context); +} + START_TEST(d3d12) { parse_args(argc, argv); @@ -32891,4 +32974,5 @@ START_TEST(d3d12) run_test(test_early_depth_stencil_tests); run_test(test_conditional_rendering); run_test(test_bufinfo_instruction); + run_test(test_write_buffer_immediate); }

1 0

Conor McCarthy : vkd3d: Add SetViewInstanceMask() to the ID3D12GraphicsCommandList1 interface.
by Alexandre Julliard 06 Dec '19

06 Dec '19

Module: vkd3d Branch: master Commit: 9c64642468fbf17dcec07220a2ec5bf1aed9ce3b URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=9c64642468fbf17dcec0722… Author: Conor McCarthy <cmccarthy(a)codeweavers.com> Date: Fri Dec 6 22:51:15 2019 +0330 vkd3d: Add SetViewInstanceMask() to the ID3D12GraphicsCommandList1 interface. This method was missing in version 10.0.15063.0 of the SDK, but is present in version 10.0.18362.0, without a UUID change. Presumably that means this was simply an omission in the older header, rather than an API change in the newer header. Signed-off-by: Conor McCarthy <cmccarthy(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/vkd3d_d3d12.idl | 2 ++ libs/vkd3d/command.c | 6 ++++++ 2 files changed, 8 insertions(+) diff --git a/include/vkd3d_d3d12.idl b/include/vkd3d_d3d12.idl index ec8b83d..b887480 100644 --- a/include/vkd3d_d3d12.idl +++ b/include/vkd3d_d3d12.idl @@ -2000,6 +2000,8 @@ interface ID3D12GraphicsCommandList1 : ID3D12GraphicsCommandList UINT dst_sub_resource_idx, UINT dst_x, UINT dst_y, ID3D12Resource *src_resource, UINT src_sub_resource_idx, D3D12_RECT *src_rect, DXGI_FORMAT format, D3D12_RESOLVE_MODE mode); + + void SetViewInstanceMask(UINT mask); } typedef enum D3D12_TILE_RANGE_FLAGS diff --git a/libs/vkd3d/command.c b/libs/vkd3d/command.c index 75af27d..d6feecf 100644 --- a/libs/vkd3d/command.c +++ b/libs/vkd3d/command.c @@ -5483,6 +5483,11 @@ static void STDMETHODCALLTYPE d3d12_command_list_ResolveSubresourceRegion(ID3D12 src_resource, src_sub_resource_idx, src_rect, format, mode); } +static void STDMETHODCALLTYPE d3d12_command_list_SetViewInstanceMask(ID3D12GraphicsCommandList1 *iface, UINT mask) +{ + FIXME("iface %p, mask %#x stub!\n", iface, mask); +} + static const struct ID3D12GraphicsCommandList1Vtbl d3d12_command_list_vtbl = { /* IUnknown methods */ @@ -5556,6 +5561,7 @@ static const struct ID3D12GraphicsCommandList1Vtbl d3d12_command_list_vtbl = d3d12_command_list_OMSetDepthBounds, d3d12_command_list_SetSamplePositions, d3d12_command_list_ResolveSubresourceRegion, + d3d12_command_list_SetViewInstanceMask, }; static struct d3d12_command_list *unsafe_impl_from_ID3D12CommandList(ID3D12CommandList *iface)

1 0

Julian Rüger : German translation for release 4.21.
by Alexandre Julliard 06 Dec '19

06 Dec '19

Module: website Branch: master Commit: 90d0854a716337b1a8e9c1e970a60a20e046ce83 URL: https://source.winehq.org/git/website.git/?a=commit;h=90d0854a716337b1a8e9c… Author: Julian Rüger <jr98(a)gmx.net> Date: Fri Dec 6 11:24:42 2019 +0100 German translation for release 4.21. Signed-off-by: Julian Rüger <jr98(a)gmx.net> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- news/de/2019112901.xml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/news/de/2019112901.xml b/news/de/2019112901.xml new file mode 100644 index 00000000..3f5f1778 --- /dev/null +++ b/news/de/2019112901.xml @@ -0,0 +1,15 @@ +<news> +<date>29. November 2019</date> +<title>Wine 4.21 freigegeben</title> +<body> + Die Entwicklungsversion 4.21 von Wine ist jetzt verfügbar. + <a href="{$root}/announce/4.21">Neuerungen (en)</a> in dieser Version: +<ul> + <li>HTTP-Proxykonfiguration per DHCP.</li> + <li>Parameterblock-Unterstützung in D3DX9.</li> + <li>Konvertierung einiger weiterer DLLs zu PE.</li> + <li>Diverse Fehlerkorrekturen.</li> +</ul> +Der Quelltext ist ab sofort <a href="//dl.winehq.org/wine/source/4.x/wine-4.21.tar.xz">verfügbar</a>. +Binärpakete werden gerade erstellt und stehen bald auf den jeweiligen <a href="{$root}/download">Downloadseiten</a> zur Verfügung. +</body></news>

1 0

Julian Rüger : German translation for release 4.0.3.
by Alexandre Julliard 06 Dec '19

06 Dec '19

Module: website Branch: master Commit: 40fa8a0639dc311a467fb657de3c8de8d6900470 URL: https://source.winehq.org/git/website.git/?a=commit;h=40fa8a0639dc311a467fb… Author: Julian Rüger <jr98(a)gmx.net> Date: Fri Dec 6 11:21:23 2019 +0100 German translation for release 4.0.3. Signed-off-by: Julian Rüger <jr98(a)gmx.net> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- news/de/2019112501.xml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/news/de/2019112501.xml b/news/de/2019112501.xml new file mode 100644 index 00000000..19ff6745 --- /dev/null +++ b/news/de/2019112501.xml @@ -0,0 +1,13 @@ +<news> +<date>25. November 2019</date> +<title>Wine 4.0.3 freigegeben</title> +<body> + Die Wartungsversion 4.0.3 von Wine ist jetzt verfügbar. + <a href="{$root}/announce/4.0.3">Neuerungen (en)</a> in dieser Version: +<ul> + <li>Diverse Fehlerkorrekturen</li> + <li>Aktualisierung der nationalen Sprachunterstützungsdateien (NLS)</li> +</ul> +Der Quelltext ist ab sofort <a href="//dl.winehq.org/wine/source/4.0/wine-4.0.3.tar.xz">verfügbar</a>. +Binärpakete werden gerade erstellt und stehen bald auf den jeweiligen <a href="{$root}/download">Downloadseiten</a> zur Verfügung. +</body></news>

1 0

Julian Rüger : German translation for release 4.20.
by Alexandre Julliard 06 Dec '19

06 Dec '19

Module: website Branch: master Commit: aed1476412a4ad82f7e16431d59ac73d9cfd8984 URL: https://source.winehq.org/git/website.git/?a=commit;h=aed1476412a4ad82f7e16… Author: Julian Rüger <jr98(a)gmx.net> Date: Fri Dec 6 11:19:33 2019 +0100 German translation for release 4.20. Signed-off-by: Julian Rüger <jr98(a)gmx.net> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- news/de/2019111501.xml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/news/de/2019111501.xml b/news/de/2019111501.xml new file mode 100644 index 00000000..95a0964c --- /dev/null +++ b/news/de/2019111501.xml @@ -0,0 +1,16 @@ +<news> +<date>15. November 2019</date> +<title>Wine 4.20 freigegeben</title> +<body> + Die Entwicklungsversion 4.20 von Wine ist jetzt verfügbar. + <a href="{$root}/announce/4.20">Neuerungen (en)</a> in dieser Version: +<ul> + <li>Neue Version der Mono-Engine mit einem FNA-Update.</li> + <li>Code-Persistenz in VBScript und JScript.</li> + <li>Aktualisierung der Vulkan-Spezifikation.</li> + <li>Verbesserte Unterstützung von LLVM-MinGW.</li> + <li>Diverse Fehlerkorrekturen.</li> +</ul> +Der Quelltext ist ab sofort <a href="//dl.winehq.org/wine/source/4.x/wine-4.20.tar.xz">verfügbar</a>. +Binärpakete werden gerade erstellt und stehen bald auf den jeweiligen <a href="{$root}/download">Downloadseiten</a> zur Verfügung. +</body></news>

1 0

Piotr Caban : kernel32: Set all %eax bits on Wow64EnableWow64FsRedirection return.
by Alexandre Julliard 05 Dec '19

05 Dec '19

Module: wine Branch: master Commit: 7ca1c4900e42d608150822ef87a7ce2847a59b6f URL: https://source.winehq.org/git/wine.git/?a=commit;h=7ca1c4900e42d608150822ef… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Thu Dec 5 20:09:04 2019 +0100 kernel32: Set all %eax bits on Wow64EnableWow64FsRedirection return. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47565 Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/kernel32.spec | 2 +- dlls/kernel32/path.c | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/dlls/kernel32/kernel32.spec b/dlls/kernel32/kernel32.spec index 172be2a6e2..04fa5f2e7a 100644 --- a/dlls/kernel32/kernel32.spec +++ b/dlls/kernel32/kernel32.spec @@ -1603,7 +1603,7 @@ # @ stub WerpStringLookup @ stdcall WideCharToMultiByte(long long wstr long ptr long ptr ptr) @ stdcall WinExec(str long) -@ stdcall Wow64EnableWow64FsRedirection(long) +@ stdcall Wow64EnableWow64FsRedirection(long) KERNEL32_Wow64EnableWow64FsRedirection @ stdcall -import Wow64DisableWow64FsRedirection(ptr) @ stdcall Wow64GetThreadContext(long ptr) # @ stub Wow64GetThreadSelectorEntry diff --git a/dlls/kernel32/path.c b/dlls/kernel32/path.c index 4f05118739..c50b631d7c 100644 --- a/dlls/kernel32/path.c +++ b/dlls/kernel32/path.c @@ -851,8 +851,10 @@ UINT WINAPI GetSystemDirectoryA( LPSTR path, UINT count ) /*********************************************************************** * Wow64EnableWow64FsRedirection (KERNEL32.@) + * + * Microsoft C++ Redistributable installers are depending on all %eax bits being set. */ -BOOLEAN WINAPI Wow64EnableWow64FsRedirection( BOOLEAN enable ) +DWORD /*BOOLEAN*/ WINAPI KERNEL32_Wow64EnableWow64FsRedirection( BOOLEAN enable ) { return set_ntstatus( RtlWow64EnableFsRedirection( enable )); }

1 0

Alex Henrie : shell32: Symlink the Downloads and Templates folders too.
by Alexandre Julliard 05 Dec '19

05 Dec '19

Module: wine Branch: master Commit: 477ff7e034e882cf0dc24aa0b459ec957608a1c3 URL: https://source.winehq.org/git/wine.git/?a=commit;h=477ff7e034e882cf0dc24aa0… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Mon Dec 2 19:17:56 2019 -0700 shell32: Symlink the Downloads and Templates folders too. Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/shell32/shellpath.c | 52 +++++++++++++++++++++++++++++++----------------- 1 file changed, 34 insertions(+), 18 deletions(-) diff --git a/dlls/shell32/shellpath.c b/dlls/shell32/shellpath.c index d9d65cbaed..06be794812 100644 --- a/dlls/shell32/shellpath.c +++ b/dlls/shell32/shellpath.c @@ -4366,6 +4366,12 @@ static inline BOOL _SHAppendToUnixPath(char *szBasePath, LPCWSTR pwszSubPath) { case IDS_MYVIDEOS: lstrcpyW(wszSubPath, My_VideosW); break; + case IDS_DOWNLOADS: + lstrcpyW(wszSubPath, DownloadsW); + break; + case IDS_TEMPLATES: + lstrcpyW(wszSubPath, TemplatesW); + break; default: ERR("LoadString(%d) failed!\n", LOWORD(pwszSubPath)); return FALSE; @@ -4392,21 +4398,21 @@ static inline BOOL _SHAppendToUnixPath(char *szBasePath, LPCWSTR pwszSubPath) { /****************************************************************************** * _SHCreateSymbolicLinks [Internal] * - * Sets up symbol links for various shell folders to point into the users home + * Sets up symbol links for various shell folders to point into the user's home * directory. We do an educated guess about what the user would probably want: * - If there is a 'My Documents' directory in $HOME, the user probably wants - * wine's 'My Documents' to point there. Furthermore, we imply that the user - * is a Windows lover and has no problem with wine creating 'My Pictures', - * 'My Music' and 'My Videos' subfolders under '$HOME/My Documents', if those - * do not already exits. We put appropriate symbolic links in place for those, - * too. + * wine's 'My Documents' to point there. Furthermore, we infer that the user + * is a Windows lover and has no problem with wine creating subfolders for + * 'My Pictures', 'My Music', 'My Videos' etc. under '$HOME/My Documents', if + * those do not already exist. We put appropriate symbolic links in place for + * those, too. * - If there is no 'My Documents' directory in $HOME, we let 'My Documents' * point directly to $HOME. We assume the user to be a unix hacker who does not * want wine to create anything anywhere besides the .wine directory. So, if * there already is a 'My Music' directory in $HOME, we symlink the 'My Music' * shell folder to it. But if not, then we check XDG_MUSIC_DIR - "well known" * directory, and try to link to that. If that fails, then we symlink to - * $HOME directly. The same holds fo 'My Pictures' and 'My Videos'. + * $HOME directly. The same holds for 'My Pictures', 'My Videos' etc. * - The Desktop shell folder is symlinked to XDG_DESKTOP_DIR. If that does not * exist, then we try '$HOME/Desktop'. If that does not exist, then we leave * it alone. @@ -4414,10 +4420,18 @@ static inline BOOL _SHAppendToUnixPath(char *szBasePath, LPCWSTR pwszSubPath) { */ static void _SHCreateSymbolicLinks(void) { - UINT aidsMyStuff[] = { IDS_MYPICTURES, IDS_MYVIDEOS, IDS_MYMUSIC }, i; - const WCHAR* MyOSXStuffW[] = { PicturesW, MoviesW, MusicW }; - int acsidlMyStuff[] = { CSIDL_MYPICTURES, CSIDL_MYVIDEO, CSIDL_MYMUSIC }; - static const char * const xdg_dirs[] = { "PICTURES", "VIDEOS", "MUSIC", "DOCUMENTS", "DESKTOP" }; + static const UINT aidsMyStuff[] = { + IDS_MYPICTURES, IDS_MYVIDEOS, IDS_MYMUSIC, IDS_DOWNLOADS, IDS_TEMPLATES + }; + static const WCHAR * const MyOSXStuffW[] = { + PicturesW, MoviesW, MusicW, DownloadsW, TemplatesW + }; + static const int acsidlMyStuff[] = { + CSIDL_MYPICTURES, CSIDL_MYVIDEO, CSIDL_MYMUSIC, CSIDL_DOWNLOADS, CSIDL_TEMPLATES + }; + static const char * const xdg_dirs[] = { + "PICTURES", "VIDEOS", "MUSIC", "DOWNLOAD", "TEMPLATES", "DOCUMENTS", "DESKTOP" + }; static const unsigned int num = ARRAY_SIZE(xdg_dirs); WCHAR wszTempPath[MAX_PATH]; char szPersonalTarget[FILENAME_MAX], *pszPersonal; @@ -4428,6 +4442,7 @@ static void _SHCreateSymbolicLinks(void) HRESULT hr; char ** xdg_results; char * xdg_desktop_dir; + UINT i; /* Create all necessary profile sub-dirs up to 'My Documents' and get the unix path. */ hr = SHGetFolderPathW(NULL, CSIDL_PERSONAL|CSIDL_FLAG_CREATE, NULL, @@ -4449,9 +4464,9 @@ static void _SHCreateSymbolicLinks(void) if (_SHAppendToUnixPath(szPersonalTarget, MAKEINTRESOURCEW(IDS_PERSONAL)) && !stat(szPersonalTarget, &statFolder) && S_ISDIR(statFolder.st_mode)) { - /* '$HOME/My Documents' exists. Create 'My Pictures', - * 'My Videos' and 'My Music' subfolders or fail silently if - * they already exist. + /* '$HOME/My Documents' exists. Create subfolders for + * 'My Pictures', 'My Videos', 'My Music' etc. or fail silently + * if they already exist. */ for (i = 0; i < ARRAY_SIZE(aidsMyStuff); i++) { @@ -4489,8 +4504,9 @@ static void _SHCreateSymbolicLinks(void) } else { - /* '$HOME' doesn't exist. Create 'My Pictures', 'My Videos' and 'My Music' subdirs - * in '%USERPROFILE%\\My Documents' or fail silently if they already exist. */ + /* '$HOME' doesn't exist. Create subdirs for 'My Pictures', 'My Videos', + * 'My Music' etc. in '%USERPROFILE%\My Documents' or fail silently if + * they already exist. */ pszHome = NULL; strcpy(szPersonalTarget, pszPersonal); for (i = 0; i < ARRAY_SIZE(aidsMyStuff); i++) { @@ -4500,7 +4516,7 @@ static void _SHCreateSymbolicLinks(void) } } - /* Create symbolic links for 'My Pictures', 'My Videos' and 'My Music'. */ + /* Create symbolic links for 'My Pictures', 'My Videos', 'My Music' etc. */ for (i=0; i < ARRAY_SIZE(aidsMyStuff); i++) { /* Create the current 'My Whatever' folder and get its unix path. */ @@ -6136,7 +6152,7 @@ HRESULT SHELL_RegisterShellFolders(void) HRESULT hr; /* Set up '$HOME' targeted symlinks for 'My Documents', 'My Pictures', - * 'My Videos', 'My Music' and 'Desktop' in advance, so that the + * 'My Videos', 'My Music', 'Desktop' etc. in advance, so that the * _SHRegister*ShellFolders() functions will find everything nice and clean * and thus will not attempt to create them in the profile directory. */ _SHCreateSymbolicLinks();

1 0

Alexandre Julliard : server: No longer depend on libwine.
by Alexandre Julliard 05 Dec '19

05 Dec '19

Module: wine Branch: master Commit: fc17535eb98a4b200d6a418337a7e280568c7cfd URL: https://source.winehq.org/git/wine.git/?a=commit;h=fc17535eb98a4b200d6a4183… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Dec 5 22:17:44 2019 +0100 server: No longer depend on libwine. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- server/Makefile.in | 2 +- server/mach.c | 1 - server/main.c | 3 +-- server/registry.c | 1 - server/request.c | 1 - 5 files changed, 2 insertions(+), 6 deletions(-) diff --git a/server/Makefile.in b/server/Makefile.in index b39bd30305..3f3761faab 100644 --- a/server/Makefile.in +++ b/server/Makefile.in @@ -50,4 +50,4 @@ MANPAGES = \ wineserver.fr.UTF-8.man.in \ wineserver.man.in -EXTRALIBS = $(LDEXECFLAGS) -lwine $(POLL_LIBS) $(RT_LIBS) $(INOTIFY_LIBS) +EXTRALIBS = $(LDEXECFLAGS) $(POLL_LIBS) $(RT_LIBS) $(INOTIFY_LIBS) diff --git a/server/mach.c b/server/mach.c index e5a532dc6c..3690b29004 100644 --- a/server/mach.c +++ b/server/mach.c @@ -41,7 +41,6 @@ #include "process.h" #include "thread.h" #include "request.h" -#include "wine/library.h" #ifdef USE_MACH diff --git a/server/main.c b/server/main.c index 7aed338e96..26986d34b3 100644 --- a/server/main.c +++ b/server/main.c @@ -36,7 +36,6 @@ #include "file.h" #include "thread.h" #include "request.h" -#include "wine/library.h" /* command-line options */ int debug_level = 0; @@ -108,7 +107,7 @@ static void parse_args( int argc, char *argv[] ) master_socket_timeout = TIMEOUT_INFINITE; break; case 'v': - fprintf( stderr, "%s\n", wine_get_build_id()); + fprintf( stderr, "%s\n", PACKAGE_STRING ); exit(0); case 'w': wait_for_lock(); diff --git a/server/registry.c b/server/registry.c index 48a0f28c97..964e2ebd58 100644 --- a/server/registry.c +++ b/server/registry.c @@ -48,7 +48,6 @@ #include "security.h" #include "winternl.h" -#include "wine/library.h" struct notify { diff --git a/server/request.c b/server/request.c index 4d3263917c..200c2697db 100644 --- a/server/request.c +++ b/server/request.c @@ -61,7 +61,6 @@ #include "winbase.h" #include "wincon.h" #include "winternl.h" -#include "wine/library.h" #include "file.h" #include "process.h"

1 0

Alexandre Julliard : server: Determine the prefix directory in the server itself.
by Alexandre Julliard 05 Dec '19

05 Dec '19

Module: wine Branch: master Commit: 763d16027573eb83954236d15ce2606d2a89fcac URL: https://source.winehq.org/git/wine.git/?a=commit;h=763d16027573eb83954236d1… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Dec 5 21:58:08 2019 +0100 server: Determine the prefix directory in the server itself. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- server/request.c | 35 +++++++++++++++++++++++++++++++++-- 1 file changed, 33 insertions(+), 2 deletions(-) diff --git a/server/request.c b/server/request.c index 4aad126eec..4d3263917c 100644 --- a/server/request.c +++ b/server/request.c @@ -618,11 +618,37 @@ static void create_dir( const char *name, struct stat *st ) /* create the server directory and chdir to it */ static char *create_server_dir( int force ) { - const char *config_dir = wine_get_config_dir(); - char *p; + const char *prefix = getenv( "WINEPREFIX" ); + char *p, *config_dir; struct stat st, st2; size_t len = sizeof("/server-") + 2 * sizeof(st.st_dev) + 2 * sizeof(st.st_ino) + 2; + /* open the configuration directory */ + + if (prefix) + { + if (!(config_dir = strdup( prefix ))) fatal_error( "out of memory\n" ); + for (p = config_dir + strlen(config_dir); p > config_dir; p--) if (p[-1] != '/') break; + if (p > config_dir) *p = 0; + if (config_dir[0] != '/') + fatal_error( "invalid directory %s in WINEPREFIX: not an absolute path\n", prefix ); + } + else + { + const char *home = getenv( "HOME" ); + if (!home) + { + struct passwd *pwd = getpwuid( getuid() ); + if (pwd) home = pwd->pw_dir; + } + if (!home) fatal_error( "could not determine your home directory\n" ); + if (home[0] != '/') fatal_error( "your home directory %s is not an absolute path\n", home ); + if (!(config_dir = malloc( strlen(home) + sizeof("/.wine") ))) fatal_error( "out of memory\n" ); + strcpy( config_dir, home ); + for (p = config_dir + strlen(config_dir); p > config_dir; p--) if (p[-1] != '/') break; + strcpy( p, "/.wine" ); + } + if (chdir( config_dir ) == -1) { if (errno != ENOENT || force) fatal_error( "chdir to %s: %s\n", config_dir, strerror( errno )); @@ -630,6 +656,10 @@ static char *create_server_dir( int force ) } if ((config_dir_fd = open( ".", O_RDONLY )) == -1) fatal_error( "open %s: %s\n", config_dir, strerror( errno )); + if (fstat( config_dir_fd, &st ) == -1) + fatal_error( "stat %s: %s\n", config_dir, strerror( errno )); + if (st.st_uid != getuid()) + fatal_error( "%s is not owned by you\n", config_dir ); /* create the base directory if needed */ @@ -673,6 +703,7 @@ static char *create_server_dir( int force ) if (st.st_dev != st2.st_dev || st.st_ino != st2.st_ino) fatal_error( "chdir did not end up in %s\n", server_dir ); + free( config_dir ); return server_dir; }

1 0

Alexandre Julliard : server: Determine the server directory in the server itself.
by Alexandre Julliard 05 Dec '19

05 Dec '19

Module: wine Branch: master Commit: fe13f7a3b0d0ad709676aa046cb4c9da260900cf URL: https://source.winehq.org/git/wine.git/?a=commit;h=fe13f7a3b0d0ad709676aa04… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Dec 5 21:57:52 2019 +0100 server: Determine the server directory in the server itself. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- server/mach.c | 2 +- server/request.c | 80 +++++++++++++++++++++++++++++++++++--------------------- server/request.h | 1 + 3 files changed, 52 insertions(+), 31 deletions(-) diff --git a/server/mach.c b/server/mach.c index 9d8d911cb7..e5a532dc6c 100644 --- a/server/mach.c +++ b/server/mach.c @@ -90,7 +90,7 @@ void init_tracing_mechanism(void) server_mach_port, MACH_MSG_TYPE_MAKE_SEND ) != KERN_SUCCESS) fatal_error("Error inserting rights\n"); - if (bootstrap_register(bp, (char*)wine_get_server_dir(), server_mach_port) != KERN_SUCCESS) + if (bootstrap_register(bp, server_dir, server_mach_port) != KERN_SUCCESS) fatal_error("Can't check in server_mach_port\n"); mach_port_deallocate(mach_task_self(), bp); } diff --git a/server/request.c b/server/request.c index 5610d392cf..4aad126eec 100644 --- a/server/request.c +++ b/server/request.c @@ -127,6 +127,7 @@ static const struct fd_ops master_socket_fd_ops = struct thread *current = NULL; /* thread handling the current request */ unsigned int global_error = 0; /* global error code for when no thread is current */ timeout_t server_start_time = 0; /* server startup time */ +char *server_dir = NULL; /* server directory */ int server_dir_fd = -1; /* file descriptor for the server dir */ int config_dir_fd = -1; /* file descriptor for the config dir */ @@ -603,7 +604,7 @@ static void create_dir( const char *name, struct stat *st ) if (lstat( name, st ) == -1) { if (errno != ENOENT) - fatal_error( "lstat %s: %s", name, strerror( errno )); + fatal_error( "lstat %s: %s\n", name, strerror( errno )); if (mkdir( name, 0700 ) == -1 && errno != EEXIST) fatal_error( "mkdir %s: %s\n", name, strerror( errno )); if (lstat( name, st ) == -1) @@ -615,22 +616,52 @@ static void create_dir( const char *name, struct stat *st ) } /* create the server directory and chdir to it */ -static void create_server_dir( const char *dir ) +static char *create_server_dir( int force ) { - char *p, *server_dir; + const char *config_dir = wine_get_config_dir(); + char *p; struct stat st, st2; + size_t len = sizeof("/server-") + 2 * sizeof(st.st_dev) + 2 * sizeof(st.st_ino) + 2; - if (!(server_dir = strdup( dir ))) fatal_error( "out of memory\n" ); - - /* first create the base directory if needed */ + if (chdir( config_dir ) == -1) + { + if (errno != ENOENT || force) fatal_error( "chdir to %s: %s\n", config_dir, strerror( errno )); + return NULL; + } + if ((config_dir_fd = open( ".", O_RDONLY )) == -1) + fatal_error( "open %s: %s\n", config_dir, strerror( errno )); - p = strrchr( server_dir, '/' ); - *p = 0; - create_dir( server_dir, &st ); + /* create the base directory if needed */ + +#ifdef __ANDROID__ /* there's no /tmp dir on Android */ + len += strlen( config_dir ) + sizeof("/.wineserver"); + if (!(server_dir = malloc( len ))) fatal_error( "out of memory\n" ); + strcpy( server_dir, config_dir ); + strcat( server_dir, "/.wineserver" ); +#else + len += sizeof("/tmp/.wine-") + 12; + if (!(server_dir = malloc( len ))) fatal_error( "out of memory\n" ); + sprintf( server_dir, "/tmp/.wine-%u", getuid() ); +#endif + create_dir( server_dir, &st2 ); /* now create the server directory */ - *p = '/'; + strcat( server_dir, "/server-" ); + p = server_dir + strlen(server_dir); + + if (st.st_dev != (unsigned long)st.st_dev) + p += sprintf( p, "%lx%08lx-", (unsigned long)((unsigned long long)st.st_dev >> 32), + (unsigned long)st.st_dev ); + else + p += sprintf( p, "%lx-", (unsigned long)st.st_dev ); + + if (st.st_ino != (unsigned long)st.st_ino) + sprintf( p, "%lx%08lx", (unsigned long)((unsigned long long)st.st_ino >> 32), + (unsigned long)st.st_ino ); + else + sprintf( p, "%lx", (unsigned long)st.st_ino ); + create_dir( server_dir, &st ); if (chdir( server_dir ) == -1) @@ -642,7 +673,7 @@ static void create_server_dir( const char *dir ) if (st.st_dev != st2.st_dev || st.st_ino != st2.st_ino) fatal_error( "chdir did not end up in %s\n", server_dir ); - free( server_dir ); + return server_dir; } /* create the lock file and return its file descriptor */ @@ -654,29 +685,28 @@ static int create_server_lock(void) if (lstat( server_lock_name, &st ) == -1) { if (errno != ENOENT) - fatal_error( "lstat %s/%s: %s", wine_get_server_dir(), server_lock_name, strerror( errno )); + fatal_error( "lstat %s/%s: %s\n", server_dir, server_lock_name, strerror( errno )); } else { if (!S_ISREG(st.st_mode)) - fatal_error( "%s/%s is not a regular file\n", wine_get_server_dir(), server_lock_name ); + fatal_error( "%s/%s is not a regular file\n", server_dir, server_lock_name ); } if ((fd = open( server_lock_name, O_CREAT|O_TRUNC|O_WRONLY, 0600 )) == -1) - fatal_error( "error creating %s/%s: %s", wine_get_server_dir(), server_lock_name, strerror( errno )); + fatal_error( "error creating %s/%s: %s\n", server_dir, server_lock_name, strerror( errno )); return fd; } /* wait for the server lock */ int wait_for_lock(void) { - const char *server_dir = wine_get_server_dir(); int fd, r; struct flock fl; + server_dir = create_server_dir( 0 ); if (!server_dir) return 0; /* no server dir, so no lock to wait on */ - create_server_dir( server_dir ); fd = create_server_lock(); fl.l_type = F_WRLCK; @@ -692,14 +722,13 @@ int wait_for_lock(void) /* kill the wine server holding the lock */ int kill_lock_owner( int sig ) { - const char *server_dir = wine_get_server_dir(); int fd, i, ret = 0; pid_t pid = 0; struct flock fl; + server_dir = create_server_dir( 0 ); if (!server_dir) return 0; /* no server dir, nothing to do */ - create_server_dir( server_dir ); fd = create_server_lock(); for (i = 1; i <= 20; i++) @@ -760,7 +789,7 @@ static void acquire_lock(void) "Warning: a previous instance of the wine server seems to have crashed.\n" "Please run 'gdb %s %s/core',\n" "type 'backtrace' at the gdb prompt and report the results. Thanks.\n\n", - server_argv0, wine_get_server_dir() ); + server_argv0, server_dir ); } unlink( server_socket_name ); /* we got the lock, we can safely remove the socket */ got_lock = 1; @@ -780,7 +809,7 @@ static void acquire_lock(void) case EAGAIN: exit(2); /* we didn't get the lock, exit with special status */ default: - fatal_error( "fcntl %s/%s: %s", wine_get_server_dir(), server_lock_name, strerror( errno )); + fatal_error( "fcntl %s/%s: %s\n", server_dir, server_lock_name, strerror( errno )); } /* it seems we can't use locks on this fs, so we will use the socket existence as lock */ close( fd ); @@ -817,8 +846,6 @@ static void acquire_lock(void) /* open the master server socket and start waiting for new clients */ void open_master_socket(void) { - const char *server_dir = wine_get_server_dir(); - const char *config_dir = wine_get_config_dir(); int fd, pid, status, sync_pipe[2]; char dummy; @@ -830,14 +857,7 @@ void open_master_socket(void) fd = open( "/dev/null", O_RDWR ); while (fd >= 0 && fd <= 2) fd = dup( fd ); - if (!server_dir) - fatal_error( "directory %s cannot be accessed\n", config_dir ); - if (chdir( config_dir ) == -1) - fatal_error( "chdir to %s: %s\n", config_dir, strerror( errno )); - if ((config_dir_fd = open( ".", O_RDONLY )) == -1) - fatal_error( "open %s: %s\n", config_dir, strerror( errno )); - - create_server_dir( server_dir ); + server_dir = create_server_dir( 1 ); if (!foreground) { diff --git a/server/request.h b/server/request.h index 2930b31d72..90a3180a6c 100644 --- a/server/request.h +++ b/server/request.h @@ -60,6 +60,7 @@ extern void close_master_socket( timeout_t timeout ); extern void shutdown_master_socket(void); extern int wait_for_lock(void); extern int kill_lock_owner( int sig ); +extern char *server_dir; extern int server_dir_fd, config_dir_fd; extern void trace_request(void);

1 0

← Newer
1
...
46
47
48
49
50
51
52
...
64
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits December 2019