winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
March 2019
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
1097 discussions
Start a n
N
ew thread
Jacek Caban : mshtml: Pass style as CSSStyle to current style property getters.
by Alexandre Julliard
26 Mar '19
26 Mar '19
Module: wine Branch: master Commit: edb4eca7882b11d5b589ebe0bdf1901fea4eb0be URL:
https://source.winehq.org/git/wine.git/?a=commit;h=edb4eca7882b11d5b589ebe0…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Mar 26 17:27:00 2019 +0100 mshtml: Pass style as CSSStyle to current style property getters. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/htmlcurstyle.c | 4 ++-- dlls/mshtml/htmlstyle.c | 8 ++++---- dlls/mshtml/htmlstyle.h | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/dlls/mshtml/htmlcurstyle.c b/dlls/mshtml/htmlcurstyle.c index 668cc2b..63e8a25 100644 --- a/dlls/mshtml/htmlcurstyle.c +++ b/dlls/mshtml/htmlcurstyle.c @@ -45,12 +45,12 @@ struct HTMLCurrentStyle { static inline HRESULT get_current_style_property(HTMLCurrentStyle *current_style, styleid_t sid, BSTR *p) { - return get_nsstyle_property(current_style->css_style.nsstyle, sid, COMPAT_MODE_QUIRKS, p); + return get_style_property(¤t_style->css_style, sid, p); } static inline HRESULT get_current_style_property_var(HTMLCurrentStyle *This, styleid_t sid, VARIANT *v) { - return get_nsstyle_property_var(This->css_style.nsstyle, sid, COMPAT_MODE_QUIRKS, v); + return get_style_property_var(&This->css_style, sid, v); } static inline HTMLCurrentStyle *impl_from_IHTMLCurrentStyle(IHTMLCurrentStyle *iface) diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c index e35c93b..425a53c 100644 --- a/dlls/mshtml/htmlstyle.c +++ b/dlls/mshtml/htmlstyle.c @@ -1077,7 +1077,7 @@ static HRESULT nsstyle_to_bstr(const WCHAR *val, DWORD flags, BSTR *p) return S_OK; } -HRESULT get_nsstyle_property(nsIDOMCSSStyleDeclaration *nsstyle, styleid_t sid, compat_mode_t compat_mode, BSTR *p) +static HRESULT get_nsstyle_property(nsIDOMCSSStyleDeclaration *nsstyle, styleid_t sid, compat_mode_t compat_mode, BSTR *p) { nsAString str_value; const PRUnichar *value; @@ -1095,7 +1095,7 @@ HRESULT get_nsstyle_property(nsIDOMCSSStyleDeclaration *nsstyle, styleid_t sid, return hres; } -HRESULT get_nsstyle_property_var(nsIDOMCSSStyleDeclaration *nsstyle, styleid_t sid, compat_mode_t compat_mode, VARIANT *p) +static HRESULT get_nsstyle_property_var(nsIDOMCSSStyleDeclaration *nsstyle, styleid_t sid, compat_mode_t compat_mode, VARIANT *p) { unsigned flags = style_tbl[sid].flags; nsAString str_value; @@ -1145,12 +1145,12 @@ HRESULT get_nsstyle_property_var(nsIDOMCSSStyleDeclaration *nsstyle, styleid_t s return S_OK; } -static inline HRESULT get_style_property(CSSStyle *style, styleid_t sid, BSTR *p) +HRESULT get_style_property(CSSStyle *style, styleid_t sid, BSTR *p) { return get_nsstyle_property(style->nsstyle, sid, dispex_compat_mode(&style->dispex), p); } -static inline HRESULT get_style_property_var(CSSStyle *style, styleid_t sid, VARIANT *v) +HRESULT get_style_property_var(CSSStyle *style, styleid_t sid, VARIANT *v) { return get_nsstyle_property_var(style->nsstyle, sid, dispex_compat_mode(&style->dispex), v); } diff --git a/dlls/mshtml/htmlstyle.h b/dlls/mshtml/htmlstyle.h index 2a67ded..bb92a00 100644 --- a/dlls/mshtml/htmlstyle.h +++ b/dlls/mshtml/htmlstyle.h @@ -140,8 +140,8 @@ HRESULT HTMLStyle_Create(HTMLElement*,HTMLStyle**) DECLSPEC_HIDDEN; void init_css_style(CSSStyle*,nsIDOMCSSStyleDeclaration*,style_qi_t, dispex_static_data_t*,compat_mode_t) DECLSPEC_HIDDEN; -HRESULT get_nsstyle_property(nsIDOMCSSStyleDeclaration*,styleid_t,compat_mode_t,BSTR*) DECLSPEC_HIDDEN; -HRESULT get_nsstyle_property_var(nsIDOMCSSStyleDeclaration*,styleid_t,compat_mode_t,VARIANT*) DECLSPEC_HIDDEN; +HRESULT get_style_property(CSSStyle*,styleid_t,BSTR*) DECLSPEC_HIDDEN; +HRESULT get_style_property_var(CSSStyle*,styleid_t,VARIANT*) DECLSPEC_HIDDEN; HRESULT get_elem_style(HTMLElement*,styleid_t,BSTR*) DECLSPEC_HIDDEN; HRESULT set_elem_style(HTMLElement*,styleid_t,const WCHAR*) DECLSPEC_HIDDEN;
1
0
0
0
Jacek Caban : mshtml: Use CSSStyle for HTMLCurrentStyle implementation.
by Alexandre Julliard
26 Mar '19
26 Mar '19
Module: wine Branch: master Commit: 68d0052b6306d06472f0809be748a73861f57edd URL:
https://source.winehq.org/git/wine.git/?a=commit;h=68d0052b6306d06472f0809b…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Mar 26 17:26:53 2019 +0100 mshtml: Use CSSStyle for HTMLCurrentStyle implementation. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/htmlcurstyle.c | 106 ++++++++++++++++++--------------------------- dlls/mshtml/htmlstyle.c | 4 +- dlls/mshtml/htmlstyle.h | 2 + 3 files changed, 45 insertions(+), 67 deletions(-) Diff:
https://source.winehq.org/git/wine.git/?a=commitdiff;h=68d0052b6306d06472f0…
1
0
0
0
Jacek Caban : mshtml: Add IHTMLCSSStyleDeclaration:: getPropertyValue implementation.
by Alexandre Julliard
26 Mar '19
26 Mar '19
Module: wine Branch: master Commit: 069d5de90af595f75272f2e446c3f16ccf25ff4e URL:
https://source.winehq.org/git/wine.git/?a=commit;h=069d5de90af595f75272f2e4…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Mar 26 17:26:36 2019 +0100 mshtml: Add IHTMLCSSStyleDeclaration::getPropertyValue implementation. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/htmlstyle.c | 16 +++++++++++++--- dlls/mshtml/tests/elements.js | 8 ++++++++ 2 files changed, 21 insertions(+), 3 deletions(-) diff --git a/dlls/mshtml/htmlstyle.c b/dlls/mshtml/htmlstyle.c index 5e2d68a..88dd4a3 100644 --- a/dlls/mshtml/htmlstyle.c +++ b/dlls/mshtml/htmlstyle.c @@ -4989,11 +4989,21 @@ static HRESULT WINAPI HTMLCSSStyleDeclaration_get_parentRule(IHTMLCSSStyleDeclar return E_NOTIMPL; } -static HRESULT WINAPI HTMLCSSStyleDeclaration_getPropertyValue(IHTMLCSSStyleDeclaration *iface, BSTR bstrPropertyName, BSTR *pbstrPropertyValue) +static HRESULT WINAPI HTMLCSSStyleDeclaration_getPropertyValue(IHTMLCSSStyleDeclaration *iface, BSTR name, BSTR *value) { CSSStyle *This = impl_from_IHTMLCSSStyleDeclaration(iface); - FIXME("(%p)->(%s %p)\n", This, debugstr_w(bstrPropertyName), pbstrPropertyValue); - return E_NOTIMPL; + const style_tbl_entry_t *style_entry; + nsAString name_str, value_str; + nsresult nsres; + + TRACE("(%p)->(%s %p)\n", This, debugstr_w(name), value); + + style_entry = lookup_style_tbl(name); + nsAString_InitDepend(&name_str, style_entry ? style_entry->name : name); + nsAString_InitDepend(&value_str, NULL); + nsres = nsIDOMCSSStyleDeclaration_GetPropertyValue(This->nsstyle, &name_str, &value_str); + nsAString_Finish(&name_str); + return return_nsstr(nsres, &value_str, value); } static HRESULT WINAPI HTMLCSSStyleDeclaration_getPropertyPriority(IHTMLCSSStyleDeclaration *iface, BSTR bstrPropertyName, BSTR *pbstrPropertyPriority) diff --git a/dlls/mshtml/tests/elements.js b/dlls/mshtml/tests/elements.js index b23f5c1..188a277 100644 --- a/dlls/mshtml/tests/elements.js +++ b/dlls/mshtml/tests/elements.js @@ -238,6 +238,10 @@ function test_style_properties() { style.cssFloat = "left"; ok(style.cssFloat === "left", "cssFloat = " + style.cssFloat); + ok(style.getPropertyValue("float") === "left", + 'style.getPropertyValue("float") = ' + style.getPropertyValue("float")); + ok(style.getPropertyValue("cssFloat") === "", + 'style.getPropertyValue("cssFloat") = ' + style.getPropertyValue("cssFloat")); val = style.removeProperty("float"); ok(val === "left", "removeProperty() returned " + val); @@ -262,6 +266,10 @@ function test_style_properties() { style["z-index"] = 1; ok(style.zIndex === 1, "zIndex = " + style.zIndex); ok(style["z-index"] === 1, "z-index = " + style["z-index"]); + ok(style.getPropertyValue("z-index") === "1", + 'style.getPropertyValue("x-index") = ' + style.getPropertyValue("z-index")); + ok(style.getPropertyValue("zIndex") === "", + 'style.getPropertyValue("xIndex") = ' + style.getPropertyValue("zIndex")); style.setProperty("border-width", "5px"); ok(style.borderWidth === "5px", "style.borderWidth = " + style.borderWidth);
1
0
0
0
Gijs Vermeulen : hnetcfg: Initialize INetFwRules:: get__NewEnum out parameter.
by Alexandre Julliard
26 Mar '19
26 Mar '19
Module: wine Branch: master Commit: 16803516ef0967b1290bcdac269f4e157af163f1 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=16803516ef0967b1290bcdac…
Author: Gijs Vermeulen <gijsvrm(a)gmail.com> Date: Tue Mar 26 17:04:44 2019 +0100 hnetcfg: Initialize INetFwRules::get__NewEnum out parameter. Wine-Bug:
https://bugs.winehq.org/show_bug.cgi?id=46906
Signed-off-by: Gijs Vermeulen <gijsvrm(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/hnetcfg/policy.c | 4 ++++ dlls/hnetcfg/tests/policy.c | 3 +++ 2 files changed, 7 insertions(+) diff --git a/dlls/hnetcfg/policy.c b/dlls/hnetcfg/policy.c index 53f39ae..26b7cc1 100644 --- a/dlls/hnetcfg/policy.c +++ b/dlls/hnetcfg/policy.c @@ -238,6 +238,10 @@ static HRESULT WINAPI netfw_rules_get__NewEnum( fw_rules *This = impl_from_INetFwRules( iface ); FIXME("%p, %p\n", This, newEnum); + + if (!newEnum) return E_POINTER; + *newEnum = NULL; + return E_NOTIMPL; } diff --git a/dlls/hnetcfg/tests/policy.c b/dlls/hnetcfg/tests/policy.c index 3fa8348..8701455 100644 --- a/dlls/hnetcfg/tests/policy.c +++ b/dlls/hnetcfg/tests/policy.c @@ -60,6 +60,9 @@ static void test_policy2_rules(INetFwPolicy2 *policy2) INetFwServiceRestriction_Release(restriction); } + hr = INetFwRules_get__NewEnum(rules, NULL); + ok(hr == E_POINTER, "got %08x\n", hr); + INetFwRules_Release(rules); INetFwRules_Release(rules2); }
1
0
0
0
Alistair Leslie-Hughes : urlmon: Pass unescaped URLs to InternetOpenUrl in ftp protocol handler.
by Alexandre Julliard
26 Mar '19
26 Mar '19
Module: wine Branch: master Commit: d99605d714fcc947b4ba597a9975cf143f61f2dd URL:
https://source.winehq.org/git/wine.git/?a=commit;h=d99605d714fcc947b4ba597a…
Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Tue Mar 26 15:21:32 2019 +0100 urlmon: Pass unescaped URLs to InternetOpenUrl in ftp protocol handler. Based on a patch by André Hentschel. Wine-Bug:
https://bugs.winehq.org/show_bug.cgi?id=26445
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/urlmon/ftp.c | 21 ++++++++++++--------- dlls/urlmon/tests/Makefile.in | 2 +- dlls/urlmon/tests/url.c | 10 +++++++++- 3 files changed, 22 insertions(+), 11 deletions(-) diff --git a/dlls/urlmon/ftp.c b/dlls/urlmon/ftp.c index aef4a6c..75704ce 100644 --- a/dlls/urlmon/ftp.c +++ b/dlls/urlmon/ftp.c @@ -66,6 +66,7 @@ static HRESULT FtpProtocol_open_request(Protocol *prot, IUri *uri, DWORD request HINTERNET internet_session, IInternetBindInfo *bind_info) { FtpProtocol *This = impl_from_Protocol(prot); + DWORD path_size = 0; BSTR url; HRESULT hres; @@ -73,16 +74,18 @@ static HRESULT FtpProtocol_open_request(Protocol *prot, IUri *uri, DWORD request if(FAILED(hres)) return hres; - This->base.request = InternetOpenUrlW(internet_session, url, NULL, 0, - request_flags|INTERNET_FLAG_EXISTING_CONNECT|INTERNET_FLAG_PASSIVE, - (DWORD_PTR)&This->base); - SysFreeString(url); - if (!This->base.request && GetLastError() != ERROR_IO_PENDING) { - WARN("InternetOpenUrl failed: %d\n", GetLastError()); - return INET_E_RESOURCE_NOT_FOUND; + hres = UrlUnescapeW(url, NULL, &path_size, URL_UNESCAPE_INPLACE); + if(SUCCEEDED(hres)) { + This->base.request = InternetOpenUrlW(internet_session, url, NULL, 0, + request_flags|INTERNET_FLAG_EXISTING_CONNECT|INTERNET_FLAG_PASSIVE, + (DWORD_PTR)&This->base); + if (!This->base.request && GetLastError() != ERROR_IO_PENDING) { + WARN("InternetOpenUrl failed: %d\n", GetLastError()); + hres = INET_E_RESOURCE_NOT_FOUND; + } } - - return S_OK; + SysFreeString(url); + return hres; } static HRESULT FtpProtocol_end_request(Protocol *prot) diff --git a/dlls/urlmon/tests/Makefile.in b/dlls/urlmon/tests/Makefile.in index 2eef129..7217f53 100644 --- a/dlls/urlmon/tests/Makefile.in +++ b/dlls/urlmon/tests/Makefile.in @@ -1,5 +1,5 @@ TESTDLL = urlmon.dll -IMPORTS = urlmon wininet ole32 oleaut32 user32 advapi32 +IMPORTS = urlmon wininet ole32 oleaut32 shlwapi user32 advapi32 C_SRCS = \ generated.c \ diff --git a/dlls/urlmon/tests/url.c b/dlls/urlmon/tests/url.c index ada78c9..0f2b14e 100644 --- a/dlls/urlmon/tests/url.c +++ b/dlls/urlmon/tests/url.c @@ -32,6 +32,7 @@ #include "urlmon.h" #include "wininet.h" #include "mshtml.h" +#include "shlwapi.h" #include "wine/test.h" @@ -2905,7 +2906,7 @@ static void init_bind_test(int protocol, DWORD flags, DWORD t) url_a = (flags & BINDTEST_INVALID_CN) ? "
https://4.15.184.77/favicon.ico
" : "
https://test.winehq.org/tests/hello.html
"; break; case FTP_TEST: - url_a = "
ftp://ftp.winehq.org/welcome.msg
"; + url_a = "
ftp://ftp.winehq.org/welcome%2emsg
"; break; default: url_a = "winetest:test"; @@ -2969,6 +2970,13 @@ static void test_BindToStorage(int protocol, DWORD flags, DWORD t) if(FAILED(hres)) return; + if(protocol == FTP_TEST) + { + /* FTP url dont have any escape characters, so convert the url to what is expected */ + DWORD size = 0; + UrlUnescapeW(current_url, NULL, &size, URL_UNESCAPE_INPLACE); + } + hres = IMoniker_QueryInterface(mon, &IID_IBinding, (void**)&bind); ok(hres == E_NOINTERFACE, "IMoniker should not have IBinding interface\n"); if(SUCCEEDED(hres))
1
0
0
0
Andrew Eikum : wineandroid.drv: Remove useless cast to self.
by Alexandre Julliard
26 Mar '19
26 Mar '19
Module: wine Branch: master Commit: b51064a3d5186277e2e377f4faf0f17e816689df URL:
https://source.winehq.org/git/wine.git/?a=commit;h=b51064a3d5186277e2e377f4…
Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Tue Mar 26 08:36:16 2019 -0500 wineandroid.drv: Remove useless cast to self. Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wineandroid.drv/mmdevdrv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dlls/wineandroid.drv/mmdevdrv.c b/dlls/wineandroid.drv/mmdevdrv.c index 3968536..1dafe02 100644 --- a/dlls/wineandroid.drv/mmdevdrv.c +++ b/dlls/wineandroid.drv/mmdevdrv.c @@ -379,8 +379,7 @@ HRESULT WINAPI AUDDRV_GetAudioEndpoint(GUID *guid, IMMDevice *dev, if(!This) return E_OUTOFMEMORY; - hr = CoCreateFreeThreadedMarshaler((IUnknown *)&This->IAudioClient_iface, - (IUnknown **)&This->pUnkFTMarshal); + hr = CoCreateFreeThreadedMarshaler((IUnknown *)&This->IAudioClient_iface, &This->pUnkFTMarshal); if (FAILED(hr)) { HeapFree(GetProcessHeap(), 0, This); return hr;
1
0
0
0
Andrew Eikum : winecoreaudio.drv: Remove useless cast to self.
by Alexandre Julliard
26 Mar '19
26 Mar '19
Module: wine Branch: master Commit: be0c18b2b10a3a524674ae1481d83d294a761668 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=be0c18b2b10a3a524674ae14…
Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Tue Mar 26 08:34:55 2019 -0500 winecoreaudio.drv: Remove useless cast to self. Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winecoreaudio.drv/mmdevdrv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dlls/winecoreaudio.drv/mmdevdrv.c b/dlls/winecoreaudio.drv/mmdevdrv.c index c362a51..28ada43 100644 --- a/dlls/winecoreaudio.drv/mmdevdrv.c +++ b/dlls/winecoreaudio.drv/mmdevdrv.c @@ -695,8 +695,7 @@ HRESULT WINAPI AUDDRV_GetAudioEndpoint(GUID *guid, IMMDevice *dev, IAudioClient This->lock = 0; - hr = CoCreateFreeThreadedMarshaler((IUnknown *)&This->IAudioClient_iface, - (IUnknown **)&This->pUnkFTMarshal); + hr = CoCreateFreeThreadedMarshaler((IUnknown *)&This->IAudioClient_iface, &This->pUnkFTMarshal); if (FAILED(hr)) { HeapFree(GetProcessHeap(), 0, This); return hr;
1
0
0
0
Michael Stefaniuc : winealsa.drv: Remove useless cast to self.
by Alexandre Julliard
26 Mar '19
26 Mar '19
Module: wine Branch: master Commit: edf2df3679dada489ed345570020ef7338e52351 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=edf2df3679dada489ed34557…
Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Sun Mar 24 14:26:46 2019 +0100 winealsa.drv: Remove useless cast to self. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winealsa.drv/mmdevdrv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dlls/winealsa.drv/mmdevdrv.c b/dlls/winealsa.drv/mmdevdrv.c index de89fd0..2bf4d73 100644 --- a/dlls/winealsa.drv/mmdevdrv.c +++ b/dlls/winealsa.drv/mmdevdrv.c @@ -803,8 +803,7 @@ HRESULT WINAPI AUDDRV_GetAudioEndpoint(GUID *guid, IMMDevice *dev, IAudioClient return E_UNEXPECTED; } - hr = CoCreateFreeThreadedMarshaler((IUnknown *)&This->IAudioClient_iface, - (IUnknown **)&This->pUnkFTMarshal); + hr = CoCreateFreeThreadedMarshaler((IUnknown *)&This->IAudioClient_iface, &This->pUnkFTMarshal); if (FAILED(hr)) { HeapFree(GetProcessHeap(), 0, This); return hr;
1
0
0
0
Michael Stefaniuc : wineoss.drv: Remove useless cast to self.
by Alexandre Julliard
26 Mar '19
26 Mar '19
Module: wine Branch: master Commit: 78aaffb55d52dcbdcfd14380bd4dead79522bdb0 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=78aaffb55d52dcbdcfd14380…
Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Sun Mar 24 14:26:45 2019 +0100 wineoss.drv: Remove useless cast to self. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wineoss.drv/mmdevdrv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dlls/wineoss.drv/mmdevdrv.c b/dlls/wineoss.drv/mmdevdrv.c index fa3f885..afa018a 100644 --- a/dlls/wineoss.drv/mmdevdrv.c +++ b/dlls/wineoss.drv/mmdevdrv.c @@ -605,8 +605,7 @@ HRESULT WINAPI AUDDRV_GetAudioEndpoint(GUID *guid, IMMDevice *dev, if(!This) return E_OUTOFMEMORY; - hr = CoCreateFreeThreadedMarshaler((IUnknown *)&This->IAudioClient_iface, - (IUnknown **)&This->pUnkFTMarshal); + hr = CoCreateFreeThreadedMarshaler((IUnknown *)&This->IAudioClient_iface, &This->pUnkFTMarshal); if (FAILED(hr)) { HeapFree(GetProcessHeap(), 0, This); return hr;
1
0
0
0
Alexandre Julliard : msvcrt: Export the __acrt_iob_func function from the import library.
by Alexandre Julliard
26 Mar '19
26 Mar '19
Module: wine Branch: master Commit: ca50117418d6b8a6146dcecd5e78819b28da2e40 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=ca50117418d6b8a6146dcecd…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Mar 26 20:22:43 2019 +0100 msvcrt: Export the __acrt_iob_func function from the import library. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcr100/Makefile.in | 1 + dlls/msvcr100/msvcr100.spec | 4 ++-- dlls/msvcr110/Makefile.in | 1 + dlls/msvcr110/msvcr110.spec | 4 ++-- dlls/msvcr120/Makefile.in | 1 + dlls/msvcr120/msvcr120.spec | 4 ++-- dlls/msvcr70/Makefile.in | 1 + dlls/msvcr70/msvcr70.spec | 4 ++-- dlls/msvcr71/Makefile.in | 1 + dlls/msvcr71/msvcr71.spec | 4 ++-- dlls/msvcr80/Makefile.in | 1 + dlls/msvcr80/msvcr80.spec | 4 ++-- dlls/msvcr90/Makefile.in | 1 + dlls/msvcr90/msvcr90.spec | 4 ++-- dlls/msvcrt/Makefile.in | 1 + dlls/msvcrt/file.c | 12 ++---------- dlls/msvcrt/iob.c | 36 ++++++++++++++++++++++++++++++++++++ dlls/msvcrt/msvcrt.spec | 5 ++--- dlls/ucrtbase/Makefile.in | 1 + dlls/ucrtbase/ucrtbase.spec | 4 ++-- 20 files changed, 65 insertions(+), 29 deletions(-) Diff:
https://source.winehq.org/git/wine.git/?a=commitdiff;h=ca50117418d6b8a6146d…
1
0
0
0
← Newer
1
...
10
11
12
13
14
15
16
...
110
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
Results per page:
10
25
50
100
200