wine-commits March 2019

wine-commits@winehq.org

2 participants
1097 discussions

Sebastian Lackner : wintrust/tests: Add some additional tests.
by Alexandre Julliard 27 Mar '19

27 Mar '19

Module: wine Branch: master Commit: 0e8401076679f337655e72fa1726f05fcd89e069 URL: https://source.winehq.org/git/wine.git/?a=commit;h=0e8401076679f337655e72fa… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Fri Mar 22 10:27:17 2019 +0100 wintrust/tests: Add some additional tests. Signed-off-by: Vijay Kiran Kamuju <infyquest(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wintrust/tests/softpub.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/dlls/wintrust/tests/softpub.c b/dlls/wintrust/tests/softpub.c index c1cb959..5d6d62c 100644 --- a/dlls/wintrust/tests/softpub.c +++ b/dlls/wintrust/tests/softpub.c @@ -1150,6 +1150,16 @@ static void test_wintrust_digest(void) { CERT_E_CHAINING, TRUE }, { S_OK, FALSE } }, { + {{ SelfSignedFile32, sizeof(SelfSignedFile32) }, + { Dummy, sizeof(Dummy) }}, + { TRUST_E_NOSIGNATURE, TRUE }, { TRUST_E_NOSIGNATURE, TRUE } + }, + { + {{ Dummy, sizeof(Dummy) }, + { SelfSignedFile32 + sizeof(Dummy), sizeof(SelfSignedFile32) - sizeof(Dummy) }}, + { TRUST_E_SUBJECT_FORM_UNKNOWN, FALSE }, { TRUST_E_NOSIGNATURE, TRUE } + }, + { {{ SelfSignedFile32, 19 }, { Dummy, sizeof(Dummy) }, { SelfSignedFile32 + 19 + sizeof(Dummy), sizeof(SelfSignedFile32) - 19 - sizeof(Dummy) }}, @@ -1170,6 +1180,16 @@ static void test_wintrust_digest(void) { CERT_E_CHAINING, TRUE }, { S_OK, FALSE } }, { + {{ SelfSignedFile64, sizeof(SelfSignedFile64) }, + { Dummy, sizeof(Dummy) }}, + { TRUST_E_NOSIGNATURE, TRUE }, { TRUST_E_NOSIGNATURE, TRUE } + }, + { + {{ Dummy, sizeof(Dummy) }, + { SelfSignedFile64 + sizeof(Dummy), sizeof(SelfSignedFile64) - sizeof(Dummy) }}, + { TRUST_E_SUBJECT_FORM_UNKNOWN, FALSE }, { TRUST_E_NOSIGNATURE, TRUE } + }, + { {{ SelfSignedFile64, 19 }, { Dummy, sizeof(Dummy) }, { SelfSignedFile64 + 19 + sizeof(Dummy), sizeof(SelfSignedFile64) - 19 - sizeof(Dummy) }},

1 0

Mark Jansen : wintrust/tests: Add tests for WinVerifyTrust.
by Alexandre Julliard 27 Mar '19

27 Mar '19

Module: wine Branch: master Commit: eaf68e99ba70c5bd144e66118e2751dca4433a75 URL: https://source.winehq.org/git/wine.git/?a=commit;h=eaf68e99ba70c5bd144e6611… Author: Mark Jansen <learn0more+wine(a)gmail.com> Date: Fri Mar 22 10:27:16 2019 +0100 wintrust/tests: Add tests for WinVerifyTrust. Includes various improvements by Sebastian Lackner <sebastian(a)fds-team.de>. Signed-off-by: Vijay Kiran Kamuju <infyquest(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wintrust/tests/softpub.c | 352 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 352 insertions(+) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=eaf68e99ba70c5bd144e…

1 0

Isira Seneviratne : kernel32/nls: Change Sinhala sublang identifier to SUBLANG_SINHALESE_SRI_LANKA.
by Alexandre Julliard 27 Mar '19

27 Mar '19

Module: wine Branch: master Commit: eb3988f080b85dce5dae66c5e667724683945c6e URL: https://source.winehq.org/git/wine.git/?a=commit;h=eb3988f080b85dce5dae66c5… Author: Isira Seneviratne <isirasen96(a)gmail.com> Date: Tue Mar 26 19:56:27 2019 +0530 kernel32/nls: Change Sinhala sublang identifier to SUBLANG_SINHALESE_SRI_LANKA. Signed-off-by: Isira Seneviratne <isirasen96(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/nls/sin.nls | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/kernel32/nls/sin.nls b/dlls/kernel32/nls/sin.nls index 36dd281..033dbc0 100644 --- a/dlls/kernel32/nls/sin.nls +++ b/dlls/kernel32/nls/sin.nls @@ -20,7 +20,7 @@ #pragma code_page(65001) /* UTF-8 */ -STRINGTABLE LANGUAGE LANG_SINHALESE, SUBLANG_DEFAULT +STRINGTABLE LANGUAGE LANG_SINHALESE, SUBLANG_SINHALESE_SRI_LANKA { LOCALE_FONTSIGNATURE L"\x002f\x8010\x3808\x0000\x0000\x0000\x0000\x0000\x0001\x0000\x0000\x4000\x0003\x0000\x0000\xc5d4" LOCALE_ICALENDARTYPE "1"

1 0

Vijay Kiran Kamuju : imagehlp/tests: Add initial tests for CheckSumMappedFile.
by Alexandre Julliard 27 Mar '19

27 Mar '19

Module: wine Branch: master Commit: 602ff38cdd41f42b0d1f4a2cecf2043b2a30f037 URL: https://source.winehq.org/git/wine.git/?a=commit;h=602ff38cdd41f42b0d1f4a2c… Author: Vijay Kiran Kamuju <infyquest(a)gmail.com> Date: Sun Mar 24 12:25:47 2019 +0100 imagehlp/tests: Add initial tests for CheckSumMappedFile. Based on a patch by Michael Müller. Signed-off-by: Vijay Kiran Kamuju <infyquest(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/imagehlp/modify.c | 36 ++------- dlls/imagehlp/tests/integrity.c | 164 +++++++++++++++++++++++++++++++++++++++- 2 files changed, 170 insertions(+), 30 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=602ff38cdd41f42b0d1f…

1 0

Aurimas Fišeras : po: Update Lithuanian translation.
by Alexandre Julliard 27 Mar '19

27 Mar '19

Module: wine Branch: master Commit: 8236c7a8c50b6160ce0863a98f27fb78e0580e6a URL: https://source.winehq.org/git/wine.git/?a=commit;h=8236c7a8c50b6160ce0863a9… Author: Aurimas Fišeras <aurimas(a)members.fsf.org> Date: Wed Mar 27 10:41:38 2019 +0200 po: Update Lithuanian translation. Signed-off-by: Aurimas Fišeras <aurimas(a)members.fsf.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- po/lt.po | 56 +------------------------------------------------------- 1 file changed, 1 insertion(+), 55 deletions(-) diff --git a/po/lt.po b/po/lt.po index 2485a8f..dedbf52 100644 --- a/po/lt.po +++ b/po/lt.po @@ -5,7 +5,7 @@ msgstr "" "Project-Id-Version: Wine\n" "Report-Msgid-Bugs-To: https://bugs.winehq.org\n" "POT-Creation-Date: N/A\n" -"PO-Revision-Date: 2019-03-19 21:12+0300\n" +"PO-Revision-Date: 2019-03-27 10:40+0300\n" "Last-Translator: Aurimas Fišeras <aurimas(a)members.fsf.org>\n" "Language-Team: Lithuanian <komp_lt(a)konf.lt>\n" "Language: lt\n" @@ -10897,10 +10897,6 @@ msgstr "" "kartu." #: winmm.rc:128 -#, fuzzy -#| msgid "" -#| "The specified MIDI port is already in use. Wait until it is free; then " -#| "try again." msgid "" "The specified MIDI port is already in use. Wait until it is free, and then " "try again." @@ -10921,10 +10917,6 @@ msgid "An error occurred with the specified port." msgstr "Įvyko klaida su nurodytu prievadu." #: winmm.rc:133 -#, fuzzy -#| msgid "" -#| "All multimedia timers are being used by other applications. Quit one of " -#| "these applications; then, try again." msgid "" "All multimedia timers are being used by other applications. Quit one of " "these applications, and then try again." @@ -15245,10 +15237,6 @@ msgid "Drive configuration" msgstr "Diskų konfigūravimas" #: winecfg.rc:233 -#, fuzzy -#| msgid "" -#| "Failed to connect to the mount manager, the drive configuration cannot be " -#| "edited." msgid "" "Failed to connect to the mount manager; the drive configuration cannot be " "edited." @@ -15540,12 +15528,6 @@ msgid "System drive" msgstr "Sisteminis diskas" #: winecfg.rc:76 -#, fuzzy -#| msgid "" -#| "Are you sure you want to delete drive C?\n" -#| "\n" -#| "Most Windows applications expect drive C to exist, and will die messily " -#| "if it doesn't. If you proceed remember to recreate it!" msgid "" "Are you sure you want to delete drive C?\n" "\n" @@ -16832,42 +16814,6 @@ msgid "D" msgstr "K" #: xcopy.rc:81 -#, fuzzy -#| msgid "" -#| "XCOPY - Copies source files or directory trees to a destination.\n" -#| "\n" -#| "Syntax:\n" -#| "XCOPY source [destination] [/I] [/S] [/Q] [/F] [/L] [/W] [/T] [/N] [/U]\n" -#| "\t [/R] [/H] [/C] [/P] [/A] [/M] [/E] [/D] [/Y] [/-Y]\n" -#| "\n" -#| "Where:\n" -#| "\n" -#| "[/I] Assume directory if destination does not exist and copying two or\n" -#| "\tmore files.\n" -#| "[/S] Copy directories and subdirectories.\n" -#| "[/E] Copy directories and subdirectories, including any empty ones.\n" -#| "[/Q] Do not list names during copy, that is be quiet.\n" -#| "[/F] Show full source and destination names during copy.\n" -#| "[/L] Simulate operation, showing names which would be copied.\n" -#| "[/W] Prompts before beginning the copy operation.\n" -#| "[/T] Creates empty directory structure but does not copy files.\n" -#| "[/Y] Suppress prompting when overwriting files.\n" -#| "[/-Y] Enable prompting when overwriting files.\n" -#| "[/P] Prompts on each source file before copying.\n" -#| "[/N] Copy using short names.\n" -#| "[/U] Copy only files which already exist in destination.\n" -#| "[/R] Overwrite any read only files.\n" -#| "[/H] Include hidden and system files in the copy.\n" -#| "[/C] Continue even if an error occurs during the copy.\n" -#| "[/A] Only copy files with archive attribute set.\n" -#| "[/M] Only copy files with archive attribute set, removes the\n" -#| "\tarchive attribute.\n" -#| "[/K] Copy file attributes, without this attributes are not preserved.\n" -#| "[/D | /D:m-d-y] Copy new files or those modified after the supplied " -#| "date.\n" -#| "\t\tIf no date is supplied, only copy if destination is older\n" -#| "\t\tthan source.\n" -#| "\n" msgid "" "XCOPY - Copies source files or directory trees to a destination.\n" "\n"

1 0

Isira Seneviratne : taskmgr: Replace repeated code with for loops.
by Alexandre Julliard 27 Mar '19

27 Mar '19

Module: wine Branch: master Commit: e0625660c8c076289e21d2fa80f3c2e4a5f33a05 URL: https://source.winehq.org/git/wine.git/?a=commit;h=e0625660c8c076289e21d2fa… Author: Isira Seneviratne <isirasen96(a)gmail.com> Date: Tue Mar 26 20:36:41 2019 +0530 taskmgr: Replace repeated code with for loops. Signed-off-by: Isira Seneviratne <isirasen96(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/taskmgr/affinity.c | 203 +++----------------------------------------- programs/taskmgr/resource.h | 2 +- 2 files changed, 12 insertions(+), 193 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=e0625660c8c076289e21…

1 0

Henri Verbeet : wined3d: Also update the "src_texture_gl" pointer when using a staging texture in the blitter.
by Alexandre Julliard 27 Mar '19

27 Mar '19

Module: wine Branch: master Commit: a5279a5fba452d779cafc2cbd3098e9ed81598d9 URL: https://source.winehq.org/git/wine.git/?a=commit;h=a5279a5fba452d779cafc2cb… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Mar 27 15:46:32 2019 +0430 wined3d: Also update the "src_texture_gl" pointer when using a staging texture in the blitter. Astutely spotted by Józef Kucia. This fixes a regression introduced by commit 961a94ac046644004718c56bfeeb81740cb73793. Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/arb_program_shader.c | 1 + dlls/wined3d/glsl_shader.c | 1 + dlls/wined3d/surface.c | 1 + 3 files changed, 3 insertions(+) diff --git a/dlls/wined3d/arb_program_shader.c b/dlls/wined3d/arb_program_shader.c index 05bd55a..92c6e47 100644 --- a/dlls/wined3d/arb_program_shader.c +++ b/dlls/wined3d/arb_program_shader.c @@ -7841,6 +7841,7 @@ static DWORD arbfp_blitter_blit(struct wined3d_blitter *blitter, enum wined3d_bl src_texture, src_sub_resource_idx, &upload_box); src_texture = staging_texture; + src_texture_gl = wined3d_texture_gl(src_texture); src_sub_resource_idx = 0; } else if (wined3d_settings.offscreen_rendering_mode != ORM_FBO diff --git a/dlls/wined3d/glsl_shader.c b/dlls/wined3d/glsl_shader.c index 55d99ab..5844b0c 100644 --- a/dlls/wined3d/glsl_shader.c +++ b/dlls/wined3d/glsl_shader.c @@ -13258,6 +13258,7 @@ static DWORD glsl_blitter_blit(struct wined3d_blitter *blitter, enum wined3d_bli src_texture, src_sub_resource_idx, &upload_box); src_texture = staging_texture; + src_texture_gl = wined3d_texture_gl(src_texture); src_sub_resource_idx = 0; } else if (wined3d_settings.offscreen_rendering_mode != ORM_FBO diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c index 11d0255..48ca35b 100644 --- a/dlls/wined3d/surface.c +++ b/dlls/wined3d/surface.c @@ -2213,6 +2213,7 @@ static DWORD ffp_blitter_blit(struct wined3d_blitter *blitter, enum wined3d_blit src_texture, src_sub_resource_idx, &upload_box); src_texture = staging_texture; + src_texture_gl = wined3d_texture_gl(src_texture); src_sub_resource_idx = 0; } else

1 0

Henri Verbeet : wined3d: Do not take "draw_rect" into account when comparing attachment sizes in ffp_blitter_clear().
by Alexandre Julliard 27 Mar '19

27 Mar '19

Module: wine Branch: master Commit: 7551f01bd0ed1ac6a82663305bc2dfe9bc07d034 URL: https://source.winehq.org/git/wine.git/?a=commit;h=7551f01bd0ed1ac6a8266330… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Mar 27 15:46:31 2019 +0430 wined3d: Do not take "draw_rect" into account when comparing attachment sizes in ffp_blitter_clear(). The scissor rectangle and viewport shouldn't affect whether attachment sizes are equal. The Intel i965 driver will do a fast clear when the scissor rectangle overlaps the intersection of the attachments, and that behaviour is allowed by the OpenGL spec. This commit fixes failures in the d3d8 and d3d9 depth_buffer_test() tests on the Intel i965 driver. See also commit 0530f33cc1644cd782ee2028966721bddf28c5d4. Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/surface.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c index 4d5b777..11d0255 100644 --- a/dlls/wined3d/surface.c +++ b/dlls/wined3d/surface.c @@ -2052,12 +2052,11 @@ static void ffp_blitter_clear(struct wined3d_blitter *blitter, struct wined3d_de unsigned int rt_count, const struct wined3d_fb_state *fb, unsigned int rect_count, const RECT *clear_rects, const RECT *draw_rect, DWORD flags, const struct wined3d_color *colour, float depth, DWORD stencil) { - BOOL have_previous_rect = FALSE, have_identical_size = TRUE; - struct wined3d_rendertarget_view *view; + struct wined3d_rendertarget_view *view, *previous = NULL; + BOOL have_identical_size = TRUE; struct wined3d_fb_state tmp_fb; unsigned int next_rt_count = 0; struct wined3d_blitter *next; - RECT previous_rect, rect; DWORD next_flags = 0; unsigned int i; @@ -2101,23 +2100,17 @@ static void ffp_blitter_clear(struct wined3d_blitter *blitter, struct wined3d_de if (!(view = fb->render_targets[i])) continue; - SetRect(&rect, 0, 0, view->width, view->height); - IntersectRect(&rect, draw_rect, &rect); - if (have_previous_rect && !EqualRect(&previous_rect, &rect)) + if (previous && (previous->width != view->width || previous->height != view->height)) have_identical_size = FALSE; - previous_rect = rect; - have_previous_rect = TRUE; + previous = view; } if (flags & (WINED3DCLEAR_ZBUFFER | WINED3DCLEAR_STENCIL)) { view = fb->depth_stencil; - SetRect(&rect, 0, 0, view->width, view->height); - IntersectRect(&rect, draw_rect, &rect); - if (have_previous_rect && !EqualRect(&previous_rect, &rect)) + if (previous && (previous->width != view->width || previous->height != view->height)) have_identical_size = FALSE; - previous_rect = rect; - have_previous_rect = TRUE; + previous = view; } if (have_identical_size)

1 0

Detlef Riekenberg : wer: Fix WER_REPORT_TYPE failures on recent win10.
by Alexandre Julliard 27 Mar '19

27 Mar '19

Module: wine Branch: master Commit: 6202cf456016a25829a05d1e627175bb739462e4 URL: https://source.winehq.org/git/wine.git/?a=commit;h=6202cf456016a25829a05d1e… Author: Detlef Riekenberg <wine.dev(a)web.de> Date: Tue Mar 26 19:21:55 2019 +0100 wer: Fix WER_REPORT_TYPE failures on recent win10. Signed-off-by: Detlef Riekenberg <wine.dev(a)web.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wer/main.c | 2 +- dlls/wer/tests/main.c | 26 ++++++++++++++++++++++---- 2 files changed, 23 insertions(+), 5 deletions(-) diff --git a/dlls/wer/main.c b/dlls/wer/main.c index 75a22a5..e4bda46 100644 --- a/dlls/wer/main.c +++ b/dlls/wer/main.c @@ -278,7 +278,7 @@ HRESULT WINAPI WerReportCreate(PCWSTR eventtype, WER_REPORT_TYPE reporttype, PWE } if (phandle) *phandle = NULL; - if (!eventtype || !eventtype[0] || !phandle) { + if (!eventtype || !eventtype[0] || !phandle || (reporttype >= WerReportInvalid)) { return E_INVALIDARG; } diff --git a/dlls/wer/tests/main.c b/dlls/wer/tests/main.c index 11a02fb..7fa9a8c 100644 --- a/dlls/wer/tests/main.c +++ b/dlls/wer/tests/main.c @@ -1,7 +1,7 @@ /* * Unit test suite for windows error reporting in Vista and above * - * Copyright 2010 Detlef Riekenberg + * Copyright 2010,2019 Detlef Riekenberg * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -207,8 +207,8 @@ static void test_WerReportCreate(void) hr = WerReportCreate(empty, WerReportCritical, NULL, &report); ok(hr == E_INVALIDARG, "got 0x%x and %p(expected E_INVALIDARG)\n", hr, report); - /* WER_REPORT_TYPE is not checked during WerReportCreate */ - for (i = 0; i <= WerReportInvalid + 1; i++) { + /* a valid WER_REPORT_TYPE works */ + for (i = 0; i < WerReportInvalid; i++) { report = (void *) 0xdeadbeef; hr = WerReportCreate(appcrash, i, NULL, &report); ok(hr == S_OK, "%d: got 0x%x and %p (expected S_OK)\n", i, hr, report); @@ -217,9 +217,27 @@ static void test_WerReportCreate(void) ok(hr == S_OK, "%d: got 0x%x for %p (expected S_OK)\n", i, hr, report); } + + /* values for WER_REPORT_TYPE are checked and invalid values are rejected since recent win10, + but older windows versions did not check the report type and WerReportCreate always succeeded */ + + report = (void *) 0xdeadbeef; + hr = WerReportCreate(appcrash, WerReportInvalid, NULL, &report); + ok((hr == E_INVALIDARG) | broken(hr == S_OK), + "%d: got 0x%x and %p (expected E_INVALIDARG or a broken S_OK)\n", i, hr, report); + if (hr == S_OK) { + hr = WerReportCloseHandle(report); + ok(hr == S_OK, "%d: got 0x%x for %p (expected S_OK)\n", i, hr, report); + } + report = (void *) 0xdeadbeef; hr = WerReportCreate(appcrash, 42, NULL, &report); - ok(hr == S_OK, "42: got 0x%x and %p (expected S_OK)\n", hr, report); + ok((hr == E_INVALIDARG) | broken(hr == S_OK), + "%d: got 0x%x and %p (expected E_INVALIDARG or a broken S_OK)\n", i, hr, report); + if (hr == S_OK) { + hr = WerReportCloseHandle(report); + ok(hr == S_OK, "%d: got 0x%x for %p (expected S_OK)\n", i, hr, report); + } /* multiple active reports are possible */ memset(table, 0, sizeof(table));

1 0

Jacek Caban : mshtml: Alloc proper BSTR size in return_nscstr.
by Alexandre Julliard 27 Mar '19

27 Mar '19

Module: wine Branch: master Commit: 9f4d05b11c32a5417ef31da8aa1041166d8cfe27 URL: https://source.winehq.org/git/wine.git/?a=commit;h=9f4d05b11c32a5417ef31da8… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Mar 27 18:53:01 2019 +0100 mshtml: Alloc proper BSTR size in return_nscstr. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/tests/xhr.js | 1 + dlls/mshtml/xmlhttprequest.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/mshtml/tests/xhr.js b/dlls/mshtml/tests/xhr.js index 8c42816..cb7e461 100644 --- a/dlls/mshtml/tests/xhr.js +++ b/dlls/mshtml/tests/xhr.js @@ -29,6 +29,7 @@ function test_xhr() { next_test(); } var onload_func = xhr.onload = function() { + ok(xhr.statusText === "OK", "statusText = " + xhr.statusText); if(complete_cnt++) next_test(); }; diff --git a/dlls/mshtml/xmlhttprequest.c b/dlls/mshtml/xmlhttprequest.c index e235bf9..5f844d5 100644 --- a/dlls/mshtml/xmlhttprequest.c +++ b/dlls/mshtml/xmlhttprequest.c @@ -80,7 +80,7 @@ static HRESULT return_nscstr(nsresult nsres, nsACString *nscstr, BSTR *p) if(*str) { len = MultiByteToWideChar(CP_UTF8, 0, str, -1, NULL, 0); - *p = SysAllocStringLen(NULL, len); + *p = SysAllocStringLen(NULL, len - 1); if(!*p) { nsACString_Finish(nscstr); return E_OUTOFMEMORY;

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
110
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits March 2019