wine-commits August 2019

wine-commits@winehq.org

2 participants
703 discussions

Huw Davies : shell32: On macOS don't link against CoreServices.
by Alexandre Julliard 02 Aug '19

02 Aug '19

Module: wine Branch: master Commit: 4da35deaa28c7dfea2c783a98bb94b307e7b0990 URL: https://source.winehq.org/git/wine.git/?a=commit;h=4da35deaa28c7dfea2c783a9… Author: Huw Davies <huw(a)codeweavers.com> Date: Mon Jul 15 15:04:16 2019 +0100 shell32: On macOS don't link against CoreServices. This has not been required since commit efac5d0672728f1b6d85d28aafced14223aecf16. Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/shell32/Makefile.in | 1 - 1 file changed, 1 deletion(-) diff --git a/dlls/shell32/Makefile.in b/dlls/shell32/Makefile.in index 20365b9..fe49bf0 100644 --- a/dlls/shell32/Makefile.in +++ b/dlls/shell32/Makefile.in @@ -3,7 +3,6 @@ MODULE = shell32.dll IMPORTLIB = shell32 IMPORTS = uuid shlwapi user32 gdi32 advapi32 DELAYIMPORTS = ole32 oleaut32 shdocvw version comctl32 gdiplus -EXTRALIBS = $(CORESERVICES_LIBS) # AUTHORS file is in the top-level directory EXTRAINCL = -I$(top_srcdir)

1 0

André Hentschel : kernel32/tests: Don' t test functions directly when reporting GetLastError().
by Alexandre Julliard 02 Aug '19

02 Aug '19

Module: wine Branch: master Commit: 19d96f99c641731a7e6b576b53f91c8937d012dc URL: https://source.winehq.org/git/wine.git/?a=commit;h=19d96f99c641731a7e6b576b… Author: André Hentschel <nerv(a)dawncrow.de> Date: Thu Aug 1 21:12:30 2019 +0200 kernel32/tests: Don't test functions directly when reporting GetLastError(). Signed-off-by: André Hentschel <nerv(a)dawncrow.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/tests/actctx.c | 40 ++++++++++++++++++++++++++++++++-------- 1 file changed, 32 insertions(+), 8 deletions(-) diff --git a/dlls/kernel32/tests/actctx.c b/dlls/kernel32/tests/actctx.c index 4dede37..2b8c3d7 100644 --- a/dlls/kernel32/tests/actctx.c +++ b/dlls/kernel32/tests/actctx.c @@ -3271,13 +3271,25 @@ static void clean_sxs_info(sxs_info *info) if (info->handle_context) ReleaseActCtx(info->handle_context); if (*info->path_dll) - ok(DeleteFileA(info->path_dll), "DeleteFileA failed for %s: %d\n", info->path_dll, GetLastError()); + { + BOOL ret = DeleteFileA(info->path_dll); + ok(ret, "DeleteFileA failed for %s: %d\n", info->path_dll, GetLastError()); + } if (*info->path_manifest_exe) - ok(DeleteFileA(info->path_manifest_exe), "DeleteFileA failed for %s: %d\n", info->path_manifest_exe, GetLastError()); + { + BOOL ret = DeleteFileA(info->path_manifest_exe); + ok(ret, "DeleteFileA failed for %s: %d\n", info->path_manifest_exe, GetLastError()); + } if (*info->path_manifest_dll) - ok(DeleteFileA(info->path_manifest_dll), "DeleteFileA failed for %s: %d\n", info->path_manifest_dll, GetLastError()); + { + BOOL ret = DeleteFileA(info->path_manifest_dll); + ok(ret, "DeleteFileA failed for %s: %d\n", info->path_manifest_dll, GetLastError()); + } if (*info->path_tmp) - ok(RemoveDirectoryA(info->path_tmp), "RemoveDirectoryA failed for %s: %d\n", info->path_tmp, GetLastError()); + { + BOOL ret = RemoveDirectoryA(info->path_tmp); + ok(ret, "RemoveDirectoryA failed for %s: %d\n", info->path_tmp, GetLastError()); + } } static void get_application_directory(char *buffer, int buffer_size) @@ -3348,7 +3360,10 @@ cleanup: if (dll.module) FreeLibrary(dll.module); if (*path_dll_local) - ok(DeleteFileA(path_dll_local), "DeleteFileA failed for %s: %d\n", path_dll_local, GetLastError()); + { + BOOL success = DeleteFileA(path_dll_local); + ok(success, "DeleteFileA failed for %s: %d\n", path_dll_local, GetLastError()); + } clean_sxs_info(&dll); } @@ -3385,7 +3400,10 @@ cleanup: if (dll.module) FreeLibrary(dll.module); if (*path_dll_local) - ok(DeleteFileA(path_dll_local), "DeleteFileA failed for %s: %d\n", path_dll_local, GetLastError()); + { + BOOL success = DeleteFileA(path_dll_local); + ok(success, "DeleteFileA failed for %s: %d\n", path_dll_local, GetLastError()); + } clean_sxs_info(&dll); } @@ -3423,7 +3441,10 @@ cleanup: if (dll.module) FreeLibrary(dll.module); if (*path_dll_local) - ok(DeleteFileA(path_dll_local), "DeleteFileA failed for %s: %d\n", path_dll_local, GetLastError()); + { + success = DeleteFileA(path_dll_local); + ok(success, "DeleteFileA failed for %s: %d\n", path_dll_local, GetLastError()); + } clean_sxs_info(&dll); } @@ -3486,7 +3507,10 @@ cleanup: if (module_msvcr) FreeLibrary(module_msvcr); if (*path_manifest) - ok(DeleteFileA(path_manifest), "DeleteFileA failed for %s: %d\n", path_manifest, GetLastError()); + { + success = DeleteFileA(path_manifest); + ok(success, "DeleteFileA failed for %s: %d\n", path_manifest, GetLastError()); + } } static void run_sxs_test(int run)

1 0

Qian Hong : advapi32: Initialize the LsaLookupSids() LSA_TRANSLATED_NAME.Name string properly.
by Alexandre Julliard 02 Aug '19

02 Aug '19

Module: wine Branch: master Commit: 2e53f8bccb65d112e5e341586c730094950fe6c3 URL: https://source.winehq.org/git/wine.git/?a=commit;h=2e53f8bccb65d112e5e34158… Author: Qian Hong <qhong(a)codeweavers.com> Date: Fri Aug 2 06:29:16 2019 +0200 advapi32: Initialize the LsaLookupSids() LSA_TRANSLATED_NAME.Name string properly. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=39129 Signed-off-by: Damjan Jovanovic <damjan.jov(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/advapi32/lsa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/advapi32/lsa.c b/dlls/advapi32/lsa.c index 592876a..793d791 100644 --- a/dlls/advapi32/lsa.c +++ b/dlls/advapi32/lsa.c @@ -508,7 +508,7 @@ NTSTATUS WINAPI LsaLookupSids( { (*Names)[i].Use = SidTypeUnknown; (*Names)[i].DomainIndex = -1; - (*Names)[i].Name.Buffer = NULL; + RtlInitUnicodeStringEx(&(*Names)[i].Name, NULL); memset(&(*ReferencedDomains)->Domains[i], 0, sizeof(LSA_TRUST_INFORMATION));

1 0

Alistair Leslie-Hughes : gdi32: Add D3DKMTQueryStatistics stub.
by Alexandre Julliard 02 Aug '19

02 Aug '19

Module: wine Branch: master Commit: 5373f7264c13ea729a81867c4d90e2ce5a42cf50 URL: https://source.winehq.org/git/wine.git/?a=commit;h=5373f7264c13ea729a81867c… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Fri Aug 2 03:34:31 2019 +0000 gdi32: Add D3DKMTQueryStatistics stub. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47074 Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- .../api-ms-win-dx-d3dkmt-l1-1-0/api-ms-win-dx-d3dkmt-l1-1-0.spec | 2 +- dlls/gdi32/driver.c | 9 +++++++++ dlls/gdi32/gdi32.spec | 1 + include/ddk/d3dkmthk.h | 1 + 4 files changed, 12 insertions(+), 1 deletion(-) diff --git a/dlls/api-ms-win-dx-d3dkmt-l1-1-0/api-ms-win-dx-d3dkmt-l1-1-0.spec b/dlls/api-ms-win-dx-d3dkmt-l1-1-0/api-ms-win-dx-d3dkmt-l1-1-0.spec index 43452cd..a28fc5c 100644 --- a/dlls/api-ms-win-dx-d3dkmt-l1-1-0/api-ms-win-dx-d3dkmt-l1-1-0.spec +++ b/dlls/api-ms-win-dx-d3dkmt-l1-1-0/api-ms-win-dx-d3dkmt-l1-1-0.spec @@ -68,7 +68,7 @@ @ stub D3DKMTQueryRemoteVidPnSourceFromGdiDisplayName @ stub D3DKMTQueryResourceInfo @ stub D3DKMTQueryResourceInfoFromNtHandle -@ stub D3DKMTQueryStatistics +@ stdcall D3DKMTQueryStatistics(ptr) gdi32.D3DKMTQueryStatistics @ stub D3DKMTReclaimAllocations @ stub D3DKMTReleaseKeyedMutex @ stub D3DKMTReleaseKeyedMutex2 diff --git a/dlls/gdi32/driver.c b/dlls/gdi32/driver.c index 90f9656..fc0839f 100644 --- a/dlls/gdi32/driver.c +++ b/dlls/gdi32/driver.c @@ -1447,3 +1447,12 @@ NTSTATUS WINAPI D3DKMTDestroyDevice( const D3DKMT_DESTROYDEVICE *desc ) return status; } + +/****************************************************************************** + * D3DKMTQueryStatistics [GDI32.@] + */ +NTSTATUS WINAPI D3DKMTQueryStatistics(D3DKMT_QUERYSTATISTICS *stats) +{ + FIXME("(%p): stub\n", stats); + return STATUS_SUCCESS; +} diff --git a/dlls/gdi32/gdi32.spec b/dlls/gdi32/gdi32.spec index 9abd821..cc5d2c2 100644 --- a/dlls/gdi32/gdi32.spec +++ b/dlls/gdi32/gdi32.spec @@ -88,6 +88,7 @@ @ stdcall D3DKMTEscape(ptr) @ stdcall D3DKMTOpenAdapterFromGdiDisplayName(ptr) @ stdcall D3DKMTOpenAdapterFromHdc(ptr) +@ stdcall D3DKMTQueryStatistics(ptr) @ stdcall DPtoLP(long ptr long) @ stdcall DeleteColorSpace(long) @ stdcall DeleteDC(long) diff --git a/include/ddk/d3dkmthk.h b/include/ddk/d3dkmthk.h index 8e28c94..ea4df3a 100644 --- a/include/ddk/d3dkmthk.h +++ b/include/ddk/d3dkmthk.h @@ -608,6 +608,7 @@ NTSTATUS WINAPI D3DKMTCreateDCFromMemory(D3DKMT_CREATEDCFROMMEMORY *desc); NTSTATUS WINAPI D3DKMTDestroyDCFromMemory(const D3DKMT_DESTROYDCFROMMEMORY *desc); NTSTATUS WINAPI D3DKMTDestroyDevice(const D3DKMT_DESTROYDEVICE *desc); NTSTATUS WINAPI D3DKMTOpenAdapterFromGdiDisplayName(D3DKMT_OPENADAPTERFROMGDIDISPLAYNAME *desc); +NTSTATUS WINAPI D3DKMTQueryStatistics(D3DKMT_QUERYSTATISTICS *stats); #ifdef __cplusplus }

1 0

Alistair Leslie-Hughes : include: Add missing D3DKMT typedefs.
by Alexandre Julliard 02 Aug '19

02 Aug '19

Module: wine Branch: master Commit: c078e913384fa29f2b1e2db20ae0c2a6d940f645 URL: https://source.winehq.org/git/wine.git/?a=commit;h=c078e913384fa29f2b1e2db2… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Fri Aug 2 03:34:30 2019 +0000 include: Add missing D3DKMT typedefs. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/ddk/d3dkmthk.h | 437 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 437 insertions(+) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=c078e913384fa29f2b1e…

1 0

Alistair Leslie-Hughes : include: Added LVITEMINDEX.
by Alexandre Julliard 02 Aug '19

02 Aug '19

Module: wine Branch: master Commit: eed7a2dca9e8f10b2226d3fed7f2b5b1561b89a7 URL: https://source.winehq.org/git/wine.git/?a=commit;h=eed7a2dca9e8f10b2226d3fe… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Fri Aug 2 02:20:34 2019 +0000 include: Added LVITEMINDEX. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/commctrl.h | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/include/commctrl.h b/include/commctrl.h index 0ad5614..906f2c3 100644 --- a/include/commctrl.h +++ b/include/commctrl.h @@ -3886,6 +3886,17 @@ typedef struct NMLVSCROLL int dy; } NMLVSCROLL, *LPNMLVSCROLL; +typedef struct tagLVITEMINDEX +{ + int iItem; + int iGroup; +} LVITEMINDEX, *PLVITEMINDEX; + +#define LVGGR_GROUP 0 +#define LVGGR_HEADER 1 +#define LVGGR_LABEL 2 +#define LVGGR_SUBSETLINK 3 + #define ListView_SetItemCount(hwnd,count) \ (BOOL)SNDMSG((hwnd),LVM_SETITEMCOUNT,(WPARAM)(INT)(count),0) #define ListView_SetTextBkColor(hwnd,clrBk) \

1 0

Alistair Leslie-Hughes : include: Define ADDRINFOT.
by Alexandre Julliard 02 Aug '19

02 Aug '19

Module: wine Branch: master Commit: c71db79c4b402e80e4f1e5a9642d2fe698943336 URL: https://source.winehq.org/git/wine.git/?a=commit;h=c71db79c4b402e80e4f1e5a9… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Fri Aug 2 02:20:33 2019 +0000 include: Define ADDRINFOT. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/ws2tcpip.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/ws2tcpip.h b/include/ws2tcpip.h index ea19ee3..b26ab2f 100644 --- a/include/ws2tcpip.h +++ b/include/ws2tcpip.h @@ -54,6 +54,9 @@ typedef struct WS(addrinfoW) struct WS(addrinfoW)* ai_next; } ADDRINFOW, *PADDRINFOW; +DECL_WINELIB_TYPE_AW(ADDRINFOT) +DECL_WINELIB_TYPE_AW(PADDRINFOT) + #ifdef USE_WS_PREFIX typedef int WS_socklen_t; #else

1 0

Alistair Leslie-Hughes : include: Add tchar defines.
by Alexandre Julliard 02 Aug '19

02 Aug '19

Module: wine Branch: master Commit: 75133c6158726d96689595c933404fed73ef1b15 URL: https://source.winehq.org/git/wine.git/?a=commit;h=75133c6158726d96689595c9… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Fri Aug 2 02:20:32 2019 +0000 include: Add tchar defines. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/tchar.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/include/tchar.h b/include/tchar.h index 9e7a846..5234a70 100644 --- a/include/tchar.h +++ b/include/tchar.h @@ -91,7 +91,9 @@ extern "C" { #define _istupper WINE_tchar_routine(isupper, _ismbcupper, iswupper) #define _istxdigit WINE_tchar_routine(isxdigit, isxdigit, iswxdigit) #define _itot WINE_tchar_routine(_itoa, _itoa, _itow) +#define _itot_s WINE_tchar_routine(_itoa_s, _itoa_s, _itow_s) #define _ltot WINE_tchar_routine(_ltoa, _ltoa, _ltow) +#define _ltot_s WINE_tchar_routine(_ltoa_s, _ltoa_s, _ltow_s) #define _puttc WINE_tchar_routine(putc, putc, putwc) #define _puttchar WINE_tchar_routine(putchar, putchar, putwchar) #define _putts WINE_tchar_routine(puts, puts, putws) @@ -106,11 +108,13 @@ extern "C" { #define _tchmod WINE_tchar_routine(chmod, _chmod, _wchmod) #define _tcreat WINE_tchar_routine(creat, _creat, _wcreat) #define _tcscat WINE_tchar_routine(strcat, _mbscat, wcscat) +#define _tcscat_s WINE_tchar_routine(strncat_s, _mbsncat_s, wcsncat_s) #define _tcschr WINE_tchar_routine(strchr, _mbschr, wcschr) #define _tcsclen WINE_tchar_routine(strlen, _mbslen, wcslen) #define _tcscmp WINE_tchar_routine(strcmp, _mbscmp, wcscmp) #define _tcscoll WINE_tchar_routine(strcoll, _mbscoll, wcscoll) #define _tcscpy WINE_tchar_routine(strcpy, _mbscpy, wcscpy) +#define _tcscpy_s WINE_tchar_routine(strcpy_s, _mbscpy_s, wcscpy_s) #define _tcscspn WINE_tchar_routine(strcspn, _mbscspn, wcscspn) #define _tcsdec WINE_tchar_routine(_strdec, _mbsdec, _wcsdec) #define _tcsdup WINE_tchar_routine(strdup, _mbsdup, _wcsdup) @@ -120,21 +124,27 @@ extern "C" { #define _tcsinc WINE_tchar_routine(_strinc, _mbsinc, _wcsinc) #define _tcslen WINE_tchar_routine(strlen, strlen, wcslen) #define _tcslwr WINE_tchar_routine(_strlwr, _mbslwr, _wcslwr) +#define _tcslwr_s WINE_tchar_routine(_strlwr_s, _mbslwr_s, _wcslwr_s) #define _tcsnbcnt WINE_tchar_routine(_strncnt, _mbsnbcnt, _wcnscnt) #define _tcsncat WINE_tchar_routine(strncat, _mbsnbcat, wcsncat) +#define _tcscat_s WINE_tchar_routine(strcat_s, _mbsnbcat_s, wcscat_s) #define _tcsnccat WINE_tchar_routine(strncat, _mbsncat, wcsncat) #define _tcsncmp WINE_tchar_routine(strncmp, _mbsnbcmp, wcsncmp) +#define _tcsncpy WINE_tchar_routine(strncpy, _mbsncpy, wcsncpy) +#define _tcsncpy_s WINE_tchar_routine(strncpy_s, _mbsncpy_s, wcsncpy_s) #define _tcsnccmp WINE_tchar_routine(strncmp, _mbsncmp, wcsncmp) #define _tcsnccnt WINE_tchar_routine(_strncnt, _mbsnccnt, _wcsncnt) #define _tcsnccpy WINE_tchar_routine(strncpy, _mbsncpy, wcsncpy) #define _tcsncicmp WINE_tchar_routine(_strnicmp, _mbsnicmp, _wcsnicmp) #define _tcsncpy WINE_tchar_routine(strncpy, _mbsnbcpy, wcsncpy) +#define _tcsncpy WINE_tchar_routine(strncpy_s, _mbsnbcpy_s, wcsncpy_s) #define _tcsncset WINE_tchar_routine(_strnset, _mbsnset, _wcsnset) #define _tcsnextc WINE_tchar_routine(_strnextc, _mbsnextc, _wcsnextc) #define _tcsnicmp WINE_tchar_routine(_strnicmp, _mbsnicmp, _wcsnicmp) #define _tcsnicoll WINE_tchar_routine(_strnicoll, _strnicoll _wcsnicoll) #define _tcsninc WINE_tchar_routine(_strninc, _mbsninc, _wcsninc) #define _tcsnccnt WINE_tchar_routine(_strncnt, _mbsnccnt, _wcsncnt) +#define _tcsnlen WINE_tchar_routine(strnlen, _mbsnblen, wcsnlen) #define _tcsnset WINE_tchar_routine(_strnset, _mbsnbset, _wcsnset) #define _tcspbrk WINE_tchar_routine(strpbrk, _mbspbrk, wcspbrk) #define _tcsspnp WINE_tchar_routine(_strspnp, _mbsspnp, _wcsspnp) @@ -148,6 +158,7 @@ extern "C" { #define _tcstol WINE_tchar_routine(strtol, strtol, wcstol) #define _tcstoul WINE_tchar_routine(strtoul, strtoul, wcstoul) #define _tcsupr WINE_tchar_routine(_strupr, _mbsupr, _wcsupr) +#define _tcsupr_s WINE_tchar_routine(_strupr_s, _mbsupr_s, _wcsupr_s) #define _tcsxfrm WINE_tchar_routine(strxfrm, strxfrm, wcsxfrm) #define _tctime WINE_tchar_routine(ctime, ctime, _wctime) #define _tenviron WINE_tchar_routine(_environ, _environ, _wenviron) @@ -172,6 +183,7 @@ extern "C" { #define _tgetenv WINE_tchar_routine(getenv, getenv, _wgetenv) #define _tmain WINE_tchar_routine(main, main, wmain) #define _tmakepath WINE_tchar_routine(_makepath, _makepath, _wmakepath) +#define _tmakepath_s WINE_tchar_routine(_makepath_s, _makepath_s, _wmakepath_s) #define _tmkdir WINE_tchar_routine(mkdir, _mkdir, _wmkdir) #define _tmktemp WINE_tchar_routine(mktemp, _mktemp, _wmktemp) #define _tperror WINE_tchar_routine(perror, perror, _wperror) @@ -196,6 +208,7 @@ extern "C" { #define _tspawnvp WINE_tchar_routine(_spawnvp, _spawnvp, _tspawnvp) #define _tspawnvpe WINE_tchar_routine(_spawnvpe, _spawnvpe, _tspawnvpe) #define _tsplitpath WINE_tchar_routine(_splitpath, _splitpath, _wsplitpath) +#define _tsplitpath_s WINE_tchar_routine(_splitpath_s, _splitpath_s,_wsplitpath_s) #define _tstat WINE_tchar_routine(_stat, _stat, _wstat) #define _tstati64 WINE_tchar_routine(_stati64, _stati64, _wstati64) #define _tstrdate WINE_tchar_routine(_strdate, _strdate, _wstrdate) @@ -208,6 +221,7 @@ extern "C" { #define _tutime WINE_tchar_routine(utime, _utime, _wutime) #define _tWinMain WINE_tchar_routine(WinMain, WinMain, wWinMain) #define _ultot WINE_tchar_routine(_ultoa, _ultoa, _ultow) +#define _ultot_s WINE_tchar_routine(_ultoa_s, _ultoa_s, _ultow_s) #define _ungettc WINE_tchar_routine(ungetc, ungetc, ungetwc) #define _vftprintf WINE_tchar_routine(vfprintf, vfprintf, vfwprintf) #define _vsntprintf WINE_tchar_routine(vsnprintf, _vsnprintf, _vsnwprintf)

1 0

Alistair Leslie-Hughes : include: Add some missing declarations.
by Alexandre Julliard 02 Aug '19

02 Aug '19

Module: wine Branch: master Commit: 0333278f7ba6277c29fe7bd0adaca08fae3c5f04 URL: https://source.winehq.org/git/wine.git/?a=commit;h=0333278f7ba6277c29fe7bd0… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Fri Aug 2 02:20:30 2019 +0000 include: Add some missing declarations. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/msvcrt/mbstring.h | 2 ++ include/msvcrt/stdlib.h | 8 ++++++++ include/msvcrt/string.h | 4 ++++ include/msvcrt/wchar.h | 11 +++++++++++ 4 files changed, 25 insertions(+) diff --git a/include/msvcrt/mbstring.h b/include/msvcrt/mbstring.h index 7a40f7b..f9b106b 100644 --- a/include/msvcrt/mbstring.h +++ b/include/msvcrt/mbstring.h @@ -75,6 +75,7 @@ int __cdecl _mbsicoll(const unsigned char*,const unsigned char*); unsigned char* __cdecl _mbsinc(const unsigned char*); size_t __cdecl _mbslen(const unsigned char*); unsigned char* __cdecl _mbslwr(unsigned char*); +errno_t __cdecl _mbslwr_s(unsigned char*, size_t); unsigned char* __cdecl _mbsnbcat(unsigned char*,const unsigned char*,size_t); errno_t __cdecl _mbsnbcat_s(unsigned char*,size_t,const unsigned char*,size_t); int __cdecl _mbsnbcmp(const unsigned char*,const unsigned char*,size_t); @@ -104,6 +105,7 @@ unsigned char* __cdecl _mbsstr(const unsigned char*,const unsigned char*); unsigned char* __cdecl _mbstok(unsigned char*,const unsigned char*); unsigned char* __cdecl _mbstok_l(unsigned char*,const unsigned char*,_locale_t); unsigned char* __cdecl _mbsupr(unsigned char*); +errno_t __cdecl _mbsupr_s(unsigned char*, size_t); #ifndef _MBLEADTRAIL_DEFINED #define _MBLEADTRAIL_DEFINED diff --git a/include/msvcrt/stdlib.h b/include/msvcrt/stdlib.h index 3454b17..47a50bc 100644 --- a/include/msvcrt/stdlib.h +++ b/include/msvcrt/stdlib.h @@ -159,10 +159,13 @@ char* __cdecl _ecvt(double,int,int*,int*); char* __cdecl _fcvt(double,int,int*,int*); char* __cdecl _fullpath(char*,const char*,size_t); char* __cdecl _gcvt(double,int,char*); +errno_t __cdecl _gcvt_s(char*, size_t, double, int); char* __cdecl _i64toa(__int64,char*,int); +errno_t __cdecl _i64toa_s(__int64, char*, size_t, int); char* __cdecl _itoa(int,char*,int); errno_t __cdecl _itoa_s(int,char*,size_t,int); char* __cdecl _ltoa(__msvcrt_long,char*,int); +errno_t __cdecl _ltoa_s(__msvcrt_long, char*, size_t, int); __msvcrt_ulong __cdecl _lrotl(__msvcrt_ulong,int); __msvcrt_ulong __cdecl _lrotr(__msvcrt_ulong,int); void __cdecl _makepath(char*,const char*,const char*,const char*,const char*); @@ -232,10 +235,15 @@ void __cdecl qsort(void*,size_t,size_t,int (__cdecl *)(const void*,cons #ifndef _WSTDLIB_DEFINED #define _WSTDLIB_DEFINED wchar_t* __cdecl _itow(int,wchar_t*,int); +errno_t __cdecl _itow_s(int,wchar_t*,int, int); wchar_t* __cdecl _i64tow(__int64,wchar_t*,int); +errno_t __cdecl _i64tow_s(__int64, wchar_t*, size_t, int); wchar_t* __cdecl _ltow(__msvcrt_long,wchar_t*,int); +errno_t __cdecl _ltow_s(__msvcrt_long,wchar_t*,int,int); wchar_t* __cdecl _ui64tow(unsigned __int64,wchar_t*,int); +errno_t __cdecl _ui64tow_s(unsigned __int64, wchar_t*, size_t, int); wchar_t* __cdecl _ultow(__msvcrt_ulong,wchar_t*,int); +errno_t __cdecl _ultow_s(__msvcrt_ulong, wchar_t*, size_t, int); wchar_t* __cdecl _wfullpath(wchar_t*,const wchar_t*,size_t); wchar_t* __cdecl _wgetenv(const wchar_t*); void __cdecl _wmakepath(wchar_t*,const wchar_t*,const wchar_t*,const wchar_t*,const wchar_t*); diff --git a/include/msvcrt/string.h b/include/msvcrt/string.h index 39a0296..85ba38a 100644 --- a/include/msvcrt/string.h +++ b/include/msvcrt/string.h @@ -95,16 +95,19 @@ int __cdecl _wcsicmp(const wchar_t*,const wchar_t*); int __cdecl _wcsicoll(const wchar_t*,const wchar_t*); int __cdecl _wcsicoll_l(const wchar_t*, const wchar_t*, _locale_t); wchar_t* __cdecl _wcslwr(wchar_t*); +errno_t __cdecl _wcslwr_s(wchar_t*, size_t); int __cdecl _wcscoll_l(const wchar_t*, const wchar_t*, _locale_t); int __cdecl _wcsncoll(const wchar_t*, const wchar_t*, size_t); int __cdecl _wcsncoll_l(const wchar_t*, const wchar_t*, size_t, _locale_t); int __cdecl _wcsnicmp(const wchar_t*,const wchar_t*,size_t); int __cdecl _wcsnicoll(const wchar_t*,const wchar_t*,size_t); int __cdecl _wcsnicoll_l(const wchar_t*, const wchar_t*, size_t, _locale_t); +size_t __cdecl _wcsnlen(const wchar_t*,size_t); wchar_t* __cdecl _wcsnset(wchar_t*,wchar_t,size_t); wchar_t* __cdecl _wcsrev(wchar_t*); wchar_t* __cdecl _wcsset(wchar_t*,wchar_t); wchar_t* __cdecl _wcsupr(wchar_t*); +errno_t __cdecl _wcsupr_s(wchar_t*, size_t); wchar_t* __cdecl wcscat(wchar_t*,const wchar_t*); errno_t __cdecl wcscat_s(wchar_t*,size_t,const wchar_t*); @@ -119,6 +122,7 @@ wchar_t* __cdecl wcsncat(wchar_t*,const wchar_t*,size_t); int __cdecl wcsncmp(const wchar_t*,const wchar_t*,size_t); wchar_t* __cdecl wcsncpy(wchar_t*,const wchar_t*,size_t); errno_t __cdecl wcsncpy_s(wchar_t*,size_t,const wchar_t*,size_t); +size_t __cdecl wcsnlen(const wchar_t*,size_t); wchar_t* __cdecl wcspbrk(const wchar_t*,const wchar_t*); wchar_t* __cdecl wcsrchr(const wchar_t*,wchar_t wcFor); size_t __cdecl wcsspn(const wchar_t*,const wchar_t*); diff --git a/include/msvcrt/wchar.h b/include/msvcrt/wchar.h index 78df974..baa93a6 100644 --- a/include/msvcrt/wchar.h +++ b/include/msvcrt/wchar.h @@ -392,13 +392,19 @@ static inline int WINAPIV swprintf(wchar_t *buffer, size_t size, const wchar_t * #ifndef _WSTDLIB_DEFINED #define _WSTDLIB_DEFINED wchar_t* __cdecl _itow(int,wchar_t*,int); +errno_t __cdecl _itow_s(int,wchar_t*,int, int); wchar_t* __cdecl _i64tow(__int64,wchar_t*,int); +errno_t __cdecl _i64tow_s(__int64, wchar_t*, size_t, int); wchar_t* __cdecl _ltow(__msvcrt_long,wchar_t*,int); +errno_t __cdecl _ltow_s(__msvcrt_long,wchar_t*,int,int); wchar_t* __cdecl _ui64tow(unsigned __int64,wchar_t*,int); +errno_t __cdecl _ui64tow_s(unsigned __int64, wchar_t*, size_t, int); wchar_t* __cdecl _ultow(__msvcrt_ulong,wchar_t*,int); +errno_t __cdecl _ultow_s(__msvcrt_ulong, wchar_t*, size_t, int); wchar_t* __cdecl _wfullpath(wchar_t*,const wchar_t*,size_t); wchar_t* __cdecl _wgetenv(const wchar_t*); void __cdecl _wmakepath(wchar_t*,const wchar_t*,const wchar_t*,const wchar_t*,const wchar_t*); +int __cdecl _wmakepath_s(wchar_t*,size_t,const wchar_t*,const wchar_t*,const wchar_t*,const wchar_t*); void __cdecl _wperror(const wchar_t*); int __cdecl _wputenv(const wchar_t*); void __cdecl _wsearchenv(const wchar_t*,const wchar_t*,wchar_t*); @@ -431,6 +437,7 @@ int __cdecl _wcsicmp(const wchar_t*,const wchar_t*); int __cdecl _wcsicoll(const wchar_t*,const wchar_t*); int __cdecl _wcsicoll_l(const wchar_t*,const wchar_t*,_locale_t); wchar_t* __cdecl _wcslwr(wchar_t*); +errno_t __cdecl _wcslwr_s(wchar_t*, size_t); int __cdecl _wcsncoll(const wchar_t*,const wchar_t*,size_t); int __cdecl _wcsncoll_l(const wchar_t*,const wchar_t*,size_t,_locale_t); int __cdecl _wcsnicmp(const wchar_t*,const wchar_t*,size_t); @@ -440,6 +447,7 @@ wchar_t* __cdecl _wcsnset(wchar_t*,wchar_t,size_t); wchar_t* __cdecl _wcsrev(wchar_t*); wchar_t* __cdecl _wcsset(wchar_t*,wchar_t); wchar_t* __cdecl _wcsupr(wchar_t*); +errno_t __cdecl _wcsupr_s(wchar_t*, size_t); wchar_t* __cdecl wcscat(wchar_t*,const wchar_t*); errno_t __cdecl wcscat_s(wchar_t*,size_t,const wchar_t*); @@ -451,9 +459,11 @@ errno_t __cdecl wcscpy_s(wchar_t*,size_t,const wchar_t*); size_t __cdecl wcscspn(const wchar_t*,const wchar_t*); size_t __cdecl wcslen(const wchar_t*); wchar_t* __cdecl wcsncat(wchar_t*,const wchar_t*,size_t); +errno_t __cdecl wcsncat_s(wchar_t *, size_t, const wchar_t *, size_t); int __cdecl wcsncmp(const wchar_t*,const wchar_t*,size_t); wchar_t* __cdecl wcsncpy(wchar_t*,const wchar_t*,size_t); errno_t __cdecl wcsncpy_s(wchar_t*,size_t,const wchar_t*,size_t); +size_t __cdecl wcsnlen(const size_t*,size_t); wchar_t* __cdecl wcspbrk(const wchar_t*,const wchar_t*); wchar_t* __cdecl wcsrchr(const wchar_t*,wchar_t wcFor); size_t __cdecl wcsspn(const wchar_t*,const wchar_t*); @@ -491,6 +501,7 @@ size_t __cdecl mbsrtowcs(wchar_t*,const char**,size_t,mbstate_t*); size_t __cdecl wcrtomb(char*,wchar_t,mbstate_t*); size_t __cdecl wcsrtombs(char*,const wchar_t**,size_t,mbstate_t*); int __cdecl wctob(wint_t); +errno_t __cdecl wmemcpy_s(wchar_t *, size_t, const wchar_t *, size_t); static inline wchar_t *wmemchr(const wchar_t *s, wchar_t c, size_t n) {

1 0

Zebediah Figura : mspatcha: Use the standard max() and min() macros.
by Alexandre Julliard 02 Aug '19

02 Aug '19

Module: wine Branch: master Commit: 31cbdfa49e5a13b4695c6c7e691d6e1400518e34 URL: https://source.winehq.org/git/wine.git/?a=commit;h=31cbdfa49e5a13b4695c6c7e… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Thu Aug 1 18:54:00 2019 -0500 mspatcha: Use the standard max() and min() macros. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mspatcha/lzxd_dec.c | 16 +++++++--------- dlls/mspatcha/pa19.c | 21 +++++++++------------ 2 files changed, 16 insertions(+), 21 deletions(-) diff --git a/dlls/mspatcha/lzxd_dec.c b/dlls/mspatcha/lzxd_dec.c index f21e1ed..fe04723 100644 --- a/dlls/mspatcha/lzxd_dec.c +++ b/dlls/mspatcha/lzxd_dec.c @@ -54,8 +54,6 @@ WINE_DEFAULT_DEBUG_CHANNEL(mspatcha); #define E8_TRANSFORM_LIMIT_BITS 30 #define E8_TRANSFORM_DEAD_ZONE 10 -#define my_min(a, b) ((a) < (b) ? (a) : (b)) - struct LZXD_dec { /* use byte pointers instead of uint16 for simplicity on uncompressed * chunks, and the stream is not 16-bit aligned anyway */ @@ -120,7 +118,7 @@ static int init_chunk(struct LZXD_dec *dec, size_t index, size_t buf_limit) dec->bit_pos = 0; dec->tail_bits = 0; - dec->uncomp_chunk_end = my_min(buf_limit, index + MAX_CHUNK_UNCOMPRESSED_SIZE); + dec->uncomp_chunk_end = min(buf_limit, index + MAX_CHUNK_UNCOMPRESSED_SIZE); return 0; } @@ -407,8 +405,8 @@ static int copy_uncompressed(struct LZXD_dec *dec, BYTE *base, size_t *index_ptr while (dec->src < dec->stream_end) { /* now treat the input as an unaligned byte stream */ - size_t to_copy = my_min(end - index, dec->uncomp_chunk_end - index); - to_copy = my_min(to_copy, (size_t)(dec->stream_end - dec->src)); + size_t to_copy = min(end - index, dec->uncomp_chunk_end - index); + to_copy = min(to_copy, (size_t)(dec->stream_end - dec->src)); memcpy(base + index, dec->src, to_copy); index += to_copy; @@ -522,7 +520,7 @@ static int decode_lzxd_block(struct LZXD_dec *dec, BYTE *base, size_t predef_siz ret_if_failed(make_huffman_codes(codes, dec->len_lengths, LEN_CODE_COUNT)); make_decode_table(dec->len_table, codes, dec->len_lengths, MAX_CODE_LEN, LEN_CODE_COUNT); - block_limit = my_min(buf_limit, index + block_size); + block_limit = min(buf_limit, index + block_size); while (index < block_limit) { @@ -606,7 +604,7 @@ static int decode_lzxd_block(struct LZXD_dec *dec, BYTE *base, size_t predef_siz --length; } - end = my_min(index + length, block_limit); + end = min(index + length, block_limit); while (index < end) { base[index] = base[index - dist]; @@ -624,12 +622,12 @@ static int decode_lzxd_block(struct LZXD_dec *dec, BYTE *base, size_t predef_siz static void reverse_e8_transform(BYTE *decode_buf, ptrdiff_t len, ptrdiff_t e8_file_size) { - ptrdiff_t limit = my_min((ptrdiff_t)1 << E8_TRANSFORM_LIMIT_BITS, len); + ptrdiff_t limit = min((ptrdiff_t)1 << E8_TRANSFORM_LIMIT_BITS, len); ptrdiff_t i; for (i = 0; i < limit; ) { - ptrdiff_t end = my_min(i + MAX_CHUNK_UNCOMPRESSED_SIZE - E8_TRANSFORM_DEAD_ZONE, + ptrdiff_t end = min(i + MAX_CHUNK_UNCOMPRESSED_SIZE - E8_TRANSFORM_DEAD_ZONE, limit - E8_TRANSFORM_DEAD_ZONE); ptrdiff_t next = i + MAX_CHUNK_UNCOMPRESSED_SIZE; diff --git a/dlls/mspatcha/pa19.c b/dlls/mspatcha/pa19.c index 0cb715c..0ed60f4 100644 --- a/dlls/mspatcha/pa19.c +++ b/dlls/mspatcha/pa19.c @@ -50,9 +50,6 @@ WINE_DEFAULT_DEBUG_CHANNEL(mspatcha); #define PA19_FILE_MAGIC 0x39314150 #define PATCH_OPTION_EXTRA_FLAGS 0x80000000 -#define my_max(a, b) ((a) > (b) ? (a) : (b)) -#define my_min(a, b) ((a) < (b) ? (a) : (b)) - static UINT32 compute_zero_crc32(UINT32 crc, INT_PTR len) { static const BYTE zero_buffer[1024]; @@ -173,7 +170,7 @@ static UINT64 read_uvli(struct patch_file_header *ph) const BYTE *vli = ph->src; UINT64 n; ptrdiff_t i; - ptrdiff_t limit = my_min(ph->end - vli, 9); + ptrdiff_t limit = min(ph->end - vli, 9); if (ph->src >= ph->end) { @@ -204,7 +201,7 @@ static INT64 read_svli(struct patch_file_header *ph) const BYTE *vli = ph->src; INT64 n; ptrdiff_t i; - ptrdiff_t limit = my_min(ph->end - vli, 9); + ptrdiff_t limit = min(ph->end - vli, 9); if (ph->src >= ph->end) { @@ -423,7 +420,7 @@ static int read_header(struct patch_file_header *ph, const BYTE *buf, size_t siz } /* skip the crc adjustment field */ - ph->src = my_min(ph->src + 4, ph->end); + ph->src = min(ph->src + 4, ph->end); { UINT32 crc = RtlComputeCrc32(0, buf, ph->src - buf) ^ 0xFFFFFFFF; @@ -464,8 +461,8 @@ static ULONG next_ignored_range(const struct input_file_info *fi, size_t index, if (fi->next_i < fi->ignore_range_count && fi->stream_size != 0) { start = fi->ignore_table[fi->next_i].OffsetInOldFile; - *end = my_max(start + fi->ignore_table[fi->next_i].LengthInBytes, index); - start = my_max(start, index); + *end = max(start + fi->ignore_table[fi->next_i].LengthInBytes, index); + start = max(start, index); } return start; } @@ -479,8 +476,8 @@ static ULONG next_retained_range_old(const struct input_file_info *fi, size_t in if (fi->next_r < fi->retain_range_count) { start = fi->retain_table[fi->next_r].OffsetInOldFile; - *end = my_max(start + fi->retain_table[fi->next_r].LengthInBytes, index); - start = my_max(start, index); + *end = max(start + fi->retain_table[fi->next_r].LengthInBytes, index); + start = max(start, index); } return start; } @@ -494,8 +491,8 @@ static ULONG next_retained_range_new(const struct input_file_info *fi, size_t in if (fi->next_r < fi->retain_range_count) { start = fi->retain_table[fi->next_r].OffsetInNewFile; - *end = my_max(start + fi->retain_table[fi->next_r].LengthInBytes, index); - start = my_max(start, index); + *end = max(start + fi->retain_table[fi->next_r].LengthInBytes, index); + start = max(start, index); } return start; }

1 0

← Newer
1
...
62
63
64
65
66
67
68
...
71
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits August 2019