wine-commits September 2019

wine-commits@winehq.org

2 participants
629 discussions

Zebediah Figura : winegstreamer: Set lSampleSize in amt_from_gst_caps_audio().
by Alexandre Julliard 17 Sep '19

17 Sep '19

Module: wine Branch: master Commit: ad791894021282c7fb3cb3e87d89745991ce604f URL: https://source.winehq.org/git/wine.git/?a=commit;h=ad791894021282c7fb3cb3e8… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Mon Sep 16 19:29:43 2019 -0500 winegstreamer: Set lSampleSize in amt_from_gst_caps_audio(). Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winegstreamer/gstdemux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dlls/winegstreamer/gstdemux.c b/dlls/winegstreamer/gstdemux.c index 397af6ef55..9160d12a5a 100644 --- a/dlls/winegstreamer/gstdemux.c +++ b/dlls/winegstreamer/gstdemux.c @@ -140,7 +140,6 @@ static gboolean amt_from_gst_caps_audio(const GstCaps *caps, AM_MEDIA_TYPE *amt) amt->cbFormat = sizeof(*wfe); amt->bFixedSizeSamples = 0; amt->bTemporalCompression = 1; - amt->lSampleSize = 0; amt->pUnk = NULL; wfx->wFormatTag = WAVE_FORMAT_EXTENSIBLE; @@ -177,7 +176,7 @@ static gboolean amt_from_gst_caps_audio(const GstCaps *caps, AM_MEDIA_TYPE *amt) wfx->cbSize = 0; } } - wfx->nBlockAlign = wfx->nChannels * wfx->wBitsPerSample/8; + amt->lSampleSize = wfx->nBlockAlign = wfx->nChannels * wfx->wBitsPerSample/8; wfx->nAvgBytesPerSec = wfx->nSamplesPerSec * wfx->nBlockAlign; return TRUE; }

1 0

Dmitry Timoshkov : rpcrt4: Implement wait_for_incoming_data() for named pipes transport.
by Alexandre Julliard 17 Sep '19

17 Sep '19

Module: wine Branch: master Commit: bb7c119190a14600d3ac0b47f268f8ea9c419f32 URL: https://source.winehq.org/git/wine.git/?a=commit;h=bb7c119190a14600d3ac0b47… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Tue Sep 17 18:04:54 2019 +0800 rpcrt4: Implement wait_for_incoming_data() for named pipes transport. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/rpcrt4/rpc_transport.c | 29 ++++++++++++++++++++++++++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/dlls/rpcrt4/rpc_transport.c b/dlls/rpcrt4/rpc_transport.c index 02fd56ce96..12d15f8654 100644 --- a/dlls/rpcrt4/rpc_transport.c +++ b/dlls/rpcrt4/rpc_transport.c @@ -463,10 +463,33 @@ static void rpcrt4_conn_np_cancel_call(RpcConnection *conn) CancelIoEx(connection->pipe, NULL); } -static int rpcrt4_conn_np_wait_for_incoming_data(RpcConnection *Connection) +static int rpcrt4_conn_np_wait_for_incoming_data(RpcConnection *conn) { - /* FIXME: implement when named pipe writes use overlapped I/O */ - return -1; + RpcConnection_np *connection = (RpcConnection_np *)conn; + FILE_PIPE_PEEK_BUFFER buf; + HANDLE event; + NTSTATUS status; + int ret; + + event = get_np_event(connection); + if (!event) return -1; + + status = NtFsControlFile(connection->pipe, event, NULL, NULL, &connection->io_status, FSCTL_PIPE_PEEK, NULL, 0, &buf, sizeof(buf)); + if (status == STATUS_SUCCESS) + ret = 0; + else if (status == STATUS_PENDING) + { + WaitForSingleObject(event, INFINITE); + ret = 0; + } + else + { + WARN("NtFsControlFile error %08x\n", status); + ret = -1; + } + + release_np_event(connection, event); + return ret; } static size_t rpcrt4_ncacn_np_get_top_of_tower(unsigned char *tower_data,

1 0

Zebediah Figura : winegstreamer: Clear bTemporalCompression in amt_from_gst_caps_audio().
by Alexandre Julliard 17 Sep '19

17 Sep '19

Module: wine Branch: master Commit: 19c6b2f26edc0eb9810edb5529dd4c643c2f3016 URL: https://source.winehq.org/git/wine.git/?a=commit;h=19c6b2f26edc0eb9810edb55… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Mon Sep 16 19:29:45 2019 -0500 winegstreamer: Clear bTemporalCompression in amt_from_gst_caps_audio(). Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winegstreamer/gstdemux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/winegstreamer/gstdemux.c b/dlls/winegstreamer/gstdemux.c index 9abb7bd289..60136abaac 100644 --- a/dlls/winegstreamer/gstdemux.c +++ b/dlls/winegstreamer/gstdemux.c @@ -139,7 +139,7 @@ static gboolean amt_from_gst_caps_audio(const GstCaps *caps, AM_MEDIA_TYPE *amt) amt->pbFormat = (BYTE*)wfe; amt->cbFormat = sizeof(*wfe); amt->bFixedSizeSamples = TRUE; - amt->bTemporalCompression = 1; + amt->bTemporalCompression = FALSE; amt->pUnk = NULL; wfx->wFormatTag = WAVE_FORMAT_EXTENSIBLE;

1 0

Zebediah Figura : winegstreamer: Set bFixedSizeSamples in amt_from_gst_caps_audio().
by Alexandre Julliard 17 Sep '19

17 Sep '19

Module: wine Branch: master Commit: 13da4669bd3520ca0ac152d8dcca155abe2a70df URL: https://source.winehq.org/git/wine.git/?a=commit;h=13da4669bd3520ca0ac152d8… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Mon Sep 16 19:29:44 2019 -0500 winegstreamer: Set bFixedSizeSamples in amt_from_gst_caps_audio(). Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winegstreamer/gstdemux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/winegstreamer/gstdemux.c b/dlls/winegstreamer/gstdemux.c index 9160d12a5a..9abb7bd289 100644 --- a/dlls/winegstreamer/gstdemux.c +++ b/dlls/winegstreamer/gstdemux.c @@ -138,7 +138,7 @@ static gboolean amt_from_gst_caps_audio(const GstCaps *caps, AM_MEDIA_TYPE *amt) amt->formattype = FORMAT_WaveFormatEx; amt->pbFormat = (BYTE*)wfe; amt->cbFormat = sizeof(*wfe); - amt->bFixedSizeSamples = 0; + amt->bFixedSizeSamples = TRUE; amt->bTemporalCompression = 1; amt->pUnk = NULL;

1 0

Zebediah Figura : winegstreamer: Also set cbFormat when using WAVE_FORMAT_PCM.
by Alexandre Julliard 17 Sep '19

17 Sep '19

Module: wine Branch: master Commit: 68a9cbcc8014175a7247ffe0aacc60e1f51cb8e7 URL: https://source.winehq.org/git/wine.git/?a=commit;h=68a9cbcc8014175a7247ffe0… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Mon Sep 16 19:29:46 2019 -0500 winegstreamer: Also set cbFormat when using WAVE_FORMAT_PCM. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winegstreamer/gstdemux.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/winegstreamer/gstdemux.c b/dlls/winegstreamer/gstdemux.c index 60136abaac..2ad4b08a13 100644 --- a/dlls/winegstreamer/gstdemux.c +++ b/dlls/winegstreamer/gstdemux.c @@ -174,6 +174,7 @@ static gboolean amt_from_gst_caps_audio(const GstCaps *caps, AM_MEDIA_TYPE *amt) if (wfx->nChannels <= 2 && bpp <= 16 && depth == bpp) { wfx->wFormatTag = WAVE_FORMAT_PCM; wfx->cbSize = 0; + amt->cbFormat = sizeof(WAVEFORMATEX); } } amt->lSampleSize = wfx->nBlockAlign = wfx->nChannels * wfx->wBitsPerSample/8;

1 0

Francois Gouget : testbot/WineRunTask: Make the GetAgent() parameter more explicit.
by Alexandre Julliard 17 Sep '19

17 Sep '19

Module: tools Branch: master Commit: e1b54bf69625998852857dc1a59b322e6262b987 URL: https://source.winehq.org/git/tools.git/?a=commit;h=e1b54bf69625998852857dc… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Tue Sep 17 12:36:05 2019 +0200 testbot/WineRunTask: Make the GetAgent() parameter more explicit. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/bin/WineRunTask.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testbot/bin/WineRunTask.pl b/testbot/bin/WineRunTask.pl index 432bf51..d987df7 100755 --- a/testbot/bin/WineRunTask.pl +++ b/testbot/bin/WineRunTask.pl @@ -411,7 +411,7 @@ if (!$TA->SetTime()) { # Not a fatal error. Try the next port in case the VM runs a privileged # TestAgentd daemon there. - my $PrivilegedTA = $VM->GetAgent(1); + my $PrivilegedTA = $VM->GetAgent("privileged"); if (!$PrivilegedTA->SetTime()) { LogTaskError("Unable to set the VM system time: ". $PrivilegedTA->GetLastError() .". Maybe the TestAgentd process is missing the required privileges.\n");

1 0

Francois Gouget : testbot/WineRunReconfig: Simplify retrieving the latest reference files.
by Alexandre Julliard 17 Sep '19

17 Sep '19

Module: tools Branch: master Commit: 59dadc0f2c5c90fba9439e68205353b71a4b576f URL: https://source.winehq.org/git/tools.git/?a=commit;h=59dadc0f2c5c90fba9439e6… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Tue Sep 17 12:35:41 2019 +0200 testbot/WineRunReconfig: Simplify retrieving the latest reference files. Both the build and wine VMs produce the native TestLauncher binaries now. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/bin/WineRunReconfig.pl | 31 ++++++++++--------------------- 1 file changed, 10 insertions(+), 21 deletions(-) diff --git a/testbot/bin/WineRunReconfig.pl b/testbot/bin/WineRunReconfig.pl index ed3dd90..d0baccc 100755 --- a/testbot/bin/WineRunReconfig.pl +++ b/testbot/bin/WineRunReconfig.pl @@ -40,6 +40,7 @@ sub BEGIN my $Name0 = $0; $Name0 =~ s+^.*/++; +use File::Basename; use WineTestBot::Config; use WineTestBot::Jobs; @@ -428,32 +429,20 @@ FatalTAError(undef, $TAError) if (defined $TAError); if ($NewStatus eq "completed") { use File::Copy; - if ($VM->Type eq "build") + foreach my $FileName ("../src/TestLauncher/TestLauncher32.exe", + "../src/TestLauncher/TestLauncher64.exe", + "latest/winefiles.txt", + "latest/wine-parentsrc.txt") { - for my $Bitness ("32", "64") + my $BaseName = basename($FileName); + Debug(Elapsed($Start), " Retrieving '$TaskDir/$BaseName'\n"); + if ($TA->GetFile($FileName, "$TaskDir/$BaseName")) { - Debug(Elapsed($Start), " Retrieving the $Bitness bit TestLauncher to '$TaskDir/TestLauncher$Bitness.exe'\n"); - if ($TA->GetFile("../src/TestLauncher/TestLauncher$Bitness.exe", "$TaskDir/TestLauncher$Bitness.exe")) - { - copy "$TaskDir/TestLauncher$Bitness.exe", "$DataDir/latest/TestLauncher$Bitness.exe"; - } - elsif (!defined $TAError) - { - FatalTAError($TA, "An error occurred while retrieving the $Bitness bit TestLauncher"); - } - } - } - - foreach my $FileName ("winefiles.txt", "wine-parentsrc.txt") - { - Debug(Elapsed($Start), " Retrieving '$TaskDir/$FileName'\n"); - if ($TA->GetFile("latest/$FileName", "$TaskDir/$FileName")) - { - copy "$TaskDir/$FileName", "$DataDir/latest/$FileName"; + copy "$TaskDir/$BaseName", "$DataDir/latest/$BaseName"; } elsif (!defined $TAError) { - FatalTAError($TA, "An error occurred while retrieving '$TaskDir/$FileName'"); + FatalTAError($TA, "An error occurred while retrieving '$TaskDir/$BaseName'"); } } }

1 0

Francois Gouget : testbot/Engine: Ignore ChildPid & ChildDeadline for maintenance VMs.
by Alexandre Julliard 17 Sep '19

17 Sep '19

Module: tools Branch: master Commit: 30c30200c7caff683b0c93455212d4390dd0137e URL: https://source.winehq.org/git/tools.git/?a=commit;h=30c30200c7caff683b0c934… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Tue Sep 17 12:35:15 2019 +0200 testbot/Engine: Ignore ChildPid & ChildDeadline for maintenance VMs. For debugging it is useful to set a VM in maintenance mode and then manually run scripts operating on that VM. When doing so ChildPid is undefined since it is normally set by the Engine when starting the script. But the scripts may modify other VM fields, including ChildDeadline. But when the Scheduler sees such a 'left-over' ChildDeadline field it normally marks the VM as dirty and powers it off, thus interfering with the script being tested. So modify the Scheduler to ignore ChildDeadline for maintenance VMs whether for cleanup or to compute when to reschedule next. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/WineTestBot/Engine/Scheduler.pm | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/testbot/lib/WineTestBot/Engine/Scheduler.pm b/testbot/lib/WineTestBot/Engine/Scheduler.pm index 3ec51d2..569dff7 100644 --- a/testbot/lib/WineTestBot/Engine/Scheduler.pm +++ b/testbot/lib/WineTestBot/Engine/Scheduler.pm @@ -350,8 +350,13 @@ sub _CheckAndClassifyVMs() } else { - if (defined $VM->ChildPid or defined $VM->ChildDeadline or - $VM->Status =~ /^(?:running|reverting|sleeping)$/) + if ($VM->Status eq "maintenance") + { + # Don't touch the VM while the administrator is working on it + $Sched->{busyvms}->{$VMKey} = 1; + } + elsif (defined $VM->ChildPid or defined $VM->ChildDeadline or + $VM->Status =~ /^(?:running|reverting|sleeping)$/) { # The VM is missing its child process or it died unexpectedly. Mark # the VM dirty so a revert or shutdown brings it back to a known state. @@ -381,11 +386,6 @@ sub _CheckAndClassifyVMs() # Ignore the VM for this round since we cannot use it $Sched->{busyvms}->{$VMKey} = 1; } - elsif ($VM->Status eq "maintenance") - { - # Don't touch the VM while the administrator is working on it - $Sched->{busyvms}->{$VMKey} = 1; - } elsif ($VM->Status ne "off") { LogMsg "Unexpected $VMKey status ". $VM->Status ."\n"; @@ -1025,7 +1025,7 @@ sub ScheduleJobs() $VMs->FilterEnabledRole(); foreach my $VM (@{$VMs->GetItems()}) { - if (defined $VM->ChildDeadline and + if ($VM->Status ne "maintenance" and defined $VM->ChildDeadline and (!defined $FirstDeadline or $VM->ChildDeadline < $FirstDeadline)) { $FirstDeadline = $VM->ChildDeadline;

1 0

Francois Gouget : testbot/TestAgent: Fix handling of connection timeouts.
by Alexandre Julliard 17 Sep '19

17 Sep '19

Module: tools Branch: master Commit: a47a8ac5a1bdafee182e1e6814d5d30f9de4146e URL: https://source.winehq.org/git/tools.git/?a=commit;h=a47a8ac5a1bdafee182e1e6… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Tue Sep 17 12:34:47 2019 +0200 testbot/TestAgent: Fix handling of connection timeouts. $@ does not just contain the die string we provided but also where die was called. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/WineTestBot/TestAgent.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testbot/lib/WineTestBot/TestAgent.pm b/testbot/lib/WineTestBot/TestAgent.pm index a4a2f49..d3d7137 100644 --- a/testbot/lib/WineTestBot/TestAgent.pm +++ b/testbot/lib/WineTestBot/TestAgent.pm @@ -938,7 +938,7 @@ sub _Connect($) if ($@) { - if ($@ eq "timeout") + if ($@ =~ /^timeout /) { $self->_SetError($FATAL, "Timed out in $Step while connecting to $self->{connection}"); }

1 0

Francois Gouget : testbot: Modify ParseTaskLog() so it can return more information.
by Alexandre Julliard 17 Sep '19

17 Sep '19

Module: tools Branch: master Commit: ef3bcca59c61b4cfc3d56235e783ed808fb4eefc URL: https://source.winehq.org/git/tools.git/?a=commit;h=ef3bcca59c61b4cfc3d5623… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Tue Sep 17 12:34:38 2019 +0200 testbot: Modify ParseTaskLog() so it can return more information. This also makes the 'NoLog' error case a bit cleaner. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/bin/WineRunBuild.pl | 10 +++++----- testbot/bin/WineRunReconfig.pl | 8 ++++---- testbot/bin/WineRunWineTest.pl | 12 ++++++------ testbot/lib/WineTestBot/LogUtils.pm | 28 +++++++++++++++++++--------- 4 files changed, 34 insertions(+), 24 deletions(-) diff --git a/testbot/bin/WineRunBuild.pl b/testbot/bin/WineRunBuild.pl index 1d57c44..a8b7803 100755 --- a/testbot/bin/WineRunBuild.pl +++ b/testbot/bin/WineRunBuild.pl @@ -391,23 +391,23 @@ if (!defined $TA->Wait($Pid, $Task->Timeout, 60)) Debug(Elapsed($Start), " Retrieving 'Build.log'\n"); if ($TA->GetFile("Build.log", "$TaskDir/log")) { - my ($Result, $_Type) = ParseTaskLog("$TaskDir/log"); - if ($Result eq "ok") + my $Summary = ParseTaskLog("$TaskDir/log"); + if ($Summary->{Task} eq "ok") { # We must have gotten the full log and the build did succeed. # So forget any prior error. $NewStatus = "completed"; $TAError = $ErrMessage = undef; } - elsif ($Result eq "badpatch") + elsif ($Summary->{Task} eq "badpatch") { # This too is conclusive enough to ignore other errors. $NewStatus = "badpatch"; $TAError = $ErrMessage = undef; } - elsif ($Result =~ s/^nolog://) + elsif ($Summary->{NoLog}) { - FatalError("$Result\n", "retry"); + FatalError("$Summary->{NoLog}\n", "retry"); } else { diff --git a/testbot/bin/WineRunReconfig.pl b/testbot/bin/WineRunReconfig.pl index bad5f76..ed3dd90 100755 --- a/testbot/bin/WineRunReconfig.pl +++ b/testbot/bin/WineRunReconfig.pl @@ -391,17 +391,17 @@ if (!defined $TA->Wait($Pid, $Task->Timeout, 60)) Debug(Elapsed($Start), " Retrieving 'Reconfig.log'\n"); if ($TA->GetFile("Reconfig.log", "$TaskDir/log")) { - my ($Result, $_Type) = ParseTaskLog("$TaskDir/log"); - if ($Result eq "ok") + my $Summary = ParseTaskLog("$TaskDir/log"); + if ($Summary->{Task} eq "ok") { # We must have gotten the full log and the build did succeed. # So forget any prior error. $NewStatus = "completed"; $TAError = $ErrMessage = undef; } - elsif ($Result =~ s/^nolog://) + elsif ($Summary->{NoLog}) { - FatalError("$Result\n", "retry"); + FatalError("$Summary->{NoLog}\n", "retry"); } else { diff --git a/testbot/bin/WineRunWineTest.pl b/testbot/bin/WineRunWineTest.pl index 508605b..514c57c 100755 --- a/testbot/bin/WineRunWineTest.pl +++ b/testbot/bin/WineRunWineTest.pl @@ -512,8 +512,8 @@ if (!defined $TA->Wait($Pid, $Task->Timeout, 60)) Debug(Elapsed($Start), " Retrieving 'Task.log'\n"); if ($TA->GetFile("Task.log", "$TaskDir/log")) { - my ($Result, $Type) = ParseTaskLog("$TaskDir/log"); - if ($Result eq "ok") + my $Summary = ParseTaskLog("$TaskDir/log"); + if ($Summary->{Task} eq "ok") { # We must have gotten the full log and the task completed successfully # (with or without test failures). So clear any previous errors, including @@ -521,17 +521,17 @@ if ($TA->GetFile("Task.log", "$TaskDir/log")) $NewStatus = "completed"; $TaskFailures = $TAError = $ErrMessage = $PossibleCrash = undef; } - elsif ($Result eq "badpatch") + elsif ($Summary->{Task} eq "badpatch") { # This too is conclusive enough to ignore other errors. $NewStatus = "badpatch"; $TaskFailures = $TAError = $ErrMessage = $PossibleCrash = undef; } - elsif ($Result =~ s/^nolog://) + elsif ($Summary->{NoLog}) { - FatalError("$Result\n", "retry"); + FatalError("$Summary->{NoLog}\n", "retry"); } - elsif ($Type eq "build") + elsif ($Summary->{Type} eq "build") { # The error happened before the tests started so blame the build. $NewStatus = "badbuild"; diff --git a/testbot/lib/WineTestBot/LogUtils.pm b/testbot/lib/WineTestBot/LogUtils.pm index 21f7dd0..a18c463 100644 --- a/testbot/lib/WineTestBot/LogUtils.pm +++ b/testbot/lib/WineTestBot/LogUtils.pm @@ -69,7 +69,17 @@ sub _IsPerlError($) =item C<ParseTaskLog()> -Returns ok if the task was successful and an error code otherwise. +Returns a hashtable containing a summary of the task log: +=over + +=item Type +'tests' if the task ran Wine tests and 'build' otherwise. + +=item Task +Either 'ok' if the task was successful or a code indicating why it failed. + +=item NoLog +Contains an error message if the task log could not be read. =back =cut @@ -80,33 +90,33 @@ sub ParseTaskLog($) if (open(my $LogFile, "<", $FileName)) { - my $Result; - my $Type = "build"; + my $Summary = {Type => "build"}; foreach my $Line (<$LogFile>) { chomp $Line; if ($Line eq "Task: tests") { - $Type = "tests"; + $Summary->{Type} = "tests"; } elsif ($Line eq "Task: ok") { - $Result ||= "ok"; + $Summary->{Task} ||= "ok"; } elsif ($Line eq "Task: Patch failed to apply") { - $Result = "badpatch"; + $Summary->{Task} = "badpatch"; last; # Should be the last and most specific message } elsif ($Line =~ /^Task: / or _IsPerlError($Line)) { - $Result = "failed"; + $Summary->{Task} = "failed"; } } close($LogFile); - return ($Result || "missing", $Type); + $Summary->{Task} ||= "missing"; + return $Summary; } - return ("nolog:Unable to open the task log for reading: $!", undef); + return {NoLog => "Unable to open the task log for reading: $!"}; }

1 0

← Newer
1
...
33
34
35
36
37
38
39
...
63
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits September 2019