winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
November 2020
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
1 participants
851 discussions
Start a n
N
ew thread
Alexandre Julliard : msvcrt: Fix floating-point status register size on ARM64.
by Alexandre Julliard
26 Nov '20
26 Nov '20
Module: wine Branch: master Commit: 3bf2e5230afc36d071614a76641832ea8dd94146 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=3bf2e5230afc36d071614a76…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Nov 26 17:11:47 2020 +0100 msvcrt: Fix floating-point status register size on ARM64. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcrt/math.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/msvcrt/math.c b/dlls/msvcrt/math.c index b975fd8d192..dd00cc212c6 100644 --- a/dlls/msvcrt/math.c +++ b/dlls/msvcrt/math.c @@ -1681,7 +1681,7 @@ unsigned int CDECL _statusfp(void) /* FIXME: there's no definition for ambiguous status, just return all status bits for now */ flags = x86_sw | sse2_sw; #elif defined(__aarch64__) - unsigned long fpsr; + ULONG_PTR fpsr; __asm__ __volatile__( "mrs %0, fpsr" : "=r" (fpsr) ); if (fpsr & 0x1) flags |= MSVCRT__SW_INVALID; @@ -1726,7 +1726,7 @@ unsigned int CDECL _clearfp(void) __asm__ __volatile__( "ldmxcsr %0" : : "m" (fpword) ); } #elif defined(__aarch64__) - unsigned long fpsr; + ULONG_PTR fpsr; __asm__ __volatile__( "mrs %0, fpsr" : "=r" (fpsr) ); if (fpsr & 0x1) flags |= MSVCRT__SW_INVALID; @@ -1991,7 +1991,7 @@ unsigned int CDECL _control87(unsigned int newval, unsigned int mask) __asm__ __volatile__( "ldmxcsr %0" :: "m" (fpword) ); } #elif defined(__aarch64__) - unsigned long fpcr; + ULONG_PTR fpcr; __asm__ __volatile__( "mrs %0, fpcr" : "=r" (fpcr) ); if (!(fpcr & 0x100)) flags |= MSVCRT__EM_INVALID;
1
0
0
0
Alexandre Julliard : configure: Also disable format warnings for ARM64.
by Alexandre Julliard
26 Nov '20
26 Nov '20
Module: wine Branch: master Commit: ecf00292db7844eb4191222ed01a5106e2462971 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=ecf00292db7844eb4191222e…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Nov 26 17:03:49 2020 +0100 configure: Also disable format warnings for ARM64. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- configure | 31 +++++++++++++++++++++++++++++++ configure.ac | 1 + 2 files changed, 32 insertions(+) diff --git a/configure b/configure index 94d93313949..e6596361ff1 100755 --- a/configure +++ b/configure @@ -10460,6 +10460,37 @@ fi $as_echo "$ac_cv_crosscflags__mcx16" >&6; } if test "x$ac_cv_crosscflags__mcx16" = xyes; then : EXTRACROSSCFLAGS="$EXTRACROSSCFLAGS -mcx16" +fi ;; + aarch64) { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether the cross-compiler supports -Wno-format" >&5 +$as_echo_n "checking whether the cross-compiler supports -Wno-format... " >&6; } +if ${ac_cv_crosscflags__Wno_format+:} false; then : + $as_echo_n "(cached) " >&6 +else + ac_wine_try_cflags_saved=$CFLAGS +ac_wine_try_cflags_saved_cc=$CC +ac_wine_try_cflags_saved_exeext=$ac_exeext +CFLAGS="$CFLAGS $EXTRACROSSCFLAGS -nostartfiles -nodefaultlibs -Wno-format" +CC="$CROSSCC" +ac_exeext=".exe" +cat confdefs.h - <<_ACEOF >conftest.$ac_ext +/* end confdefs.h. */ +int __cdecl mainCRTStartup(void) { return 0; } +_ACEOF +if ac_fn_c_try_link "$LINENO"; then : + ac_cv_crosscflags__Wno_format=yes +else + ac_cv_crosscflags__Wno_format=no +fi +rm -f core conftest.err conftest.$ac_objext \ + conftest$ac_exeext conftest.$ac_ext +CFLAGS=$ac_wine_try_cflags_saved +CC=$ac_wine_try_cflags_saved_cc +ac_exeext=$ac_wine_try_cflags_saved_exeext +fi +{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_cv_crosscflags__Wno_format" >&5 +$as_echo "$ac_cv_crosscflags__Wno_format" >&6; } +if test "x$ac_cv_crosscflags__Wno_format" = xyes; then : + EXTRACROSSCFLAGS="$EXTRACROSSCFLAGS -Wno-format" fi ;; esac diff --git a/configure.ac b/configure.ac index c7eab5c086f..705ab04295d 100644 --- a/configure.ac +++ b/configure.ac @@ -1072,6 +1072,7 @@ then WINE_TRY_CROSSCFLAGS([-Wformat-overflow]) WINE_TRY_CROSSCFLAGS([-Wnonnull]) WINE_TRY_CROSSCFLAGS([-mcx16]) ;; + aarch64) WINE_TRY_CROSSCFLAGS([-Wno-format]) ;; esac dnl Determine debug info format
1
0
0
0
Piotr Caban : msvcrt: Implement opening Unicode files with no BOM in _wsopen_dispatch.
by Alexandre Julliard
26 Nov '20
26 Nov '20
Module: wine Branch: master Commit: b0ab1b76029eaface724a28483fe8b0ea36029dc URL:
https://source.winehq.org/git/wine.git/?a=commit;h=b0ab1b76029eaface724a284…
Author: Piotr Caban <piotr(a)codeweavers.com> Date: Thu Nov 26 15:26:35 2020 +0100 msvcrt: Implement opening Unicode files with no BOM in _wsopen_dispatch. Spotted by Alistair Leslie-Hughes. Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcrt/file.c | 8 ++------ dlls/msvcrt/tests/file.c | 49 ++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 51 insertions(+), 6 deletions(-) diff --git a/dlls/msvcrt/file.c b/dlls/msvcrt/file.c index 3b1c7d549d9..2176e8a0476 100644 --- a/dlls/msvcrt/file.c +++ b/dlls/msvcrt/file.c @@ -2174,17 +2174,15 @@ static int check_bom(HANDLE h, int oflags, BOOL seek) char bom[sizeof(utf8_bom)]; DWORD r; - oflags &= ~(MSVCRT__O_WTEXT|MSVCRT__O_U16TEXT|MSVCRT__O_U8TEXT); - if (!ReadFile(h, bom, sizeof(utf8_bom), &r, NULL)) return oflags; if (r==sizeof(utf8_bom) && !memcmp(bom, utf8_bom, sizeof(utf8_bom))) { - oflags |= MSVCRT__O_U8TEXT; + oflags = (oflags & ~(MSVCRT__O_WTEXT | MSVCRT__O_U16TEXT)) | MSVCRT__O_U8TEXT; }else if (r>=sizeof(utf16_bom) && !memcmp(bom, utf16_bom, sizeof(utf16_bom))) { if (seek && r>2) SetFilePointer(h, 2, NULL, FILE_BEGIN); - oflags |= MSVCRT__O_U16TEXT; + oflags = (oflags & ~(MSVCRT__O_WTEXT | MSVCRT__O_U8TEXT)) | MSVCRT__O_U16TEXT; }else if (seek) { SetFilePointer(h, 0, NULL, FILE_BEGIN); } @@ -2284,8 +2282,6 @@ int CDECL MSVCRT__wsopen_dispatch( const MSVCRT_wchar_t* path, int oflags, int s oflags = check_bom(hand, oflags, FALSE); CloseHandle(hand); } - else - oflags &= ~(MSVCRT__O_WTEXT|MSVCRT__O_U16TEXT|MSVCRT__O_U8TEXT); } hand = CreateFileW(path, access, sharing, &sa, creation, attrib, 0); diff --git a/dlls/msvcrt/tests/file.c b/dlls/msvcrt/tests/file.c index fc6dacd71ff..a413d674164 100644 --- a/dlls/msvcrt/tests/file.c +++ b/dlls/msvcrt/tests/file.c @@ -971,6 +971,38 @@ static void test_fgetwc_unicode(void) ok(ch == WEOF, "got %04hx, expected WEOF (unicode)\n", ch); fclose(tempfh); + tempfh = fopen(tempfile, "r,ccs=utf-8"); + ok(tempfh != NULL, "can't open tempfile\n"); + for (i = 1; i < ARRAY_SIZE(wchar_text); i++) + { + ch = fgetwc(tempfh); + ok(ch == wchar_text[i], + "got %04hx, expected %04x (unicode[%d])\n", ch, wchar_text[i], i-1); + } + ch = fgetwc(tempfh); + ok(ch == WEOF, "got %04hx, expected WEOF (unicode)\n", ch); + fclose(tempfh); + + tempfh = fopen(tempfile, "a,ccs=utf-16le"); + ok(tempfh != NULL, "can't open tempfile\n"); + ch = fputwc('a', tempfh); + ok(ch == 'a', "fputwc returned %x\n", ch); + fclose(tempfh); + + tempfh = fopen(tempfile, "a+,ccs=utf-8"); + ok(tempfh != NULL, "can't open tempfile\n"); + for (i = 1; i < ARRAY_SIZE(wchar_text); i++) + { + ch = fgetwc(tempfh); + ok(ch == wchar_text[i], + "got %04hx, expected %04x (unicode[%d])\n", ch, wchar_text[i], i-1); + } + ch = fgetwc(tempfh); + ok(ch == 'a', "got %04x, expected 'a'\n", ch); + ch = fgetwc(tempfh); + ok(ch == WEOF, "got %04hx, expected WEOF (unicode)\n", ch); + fclose(tempfh); + tempfh = fopen(tempfile, "wb"); ok(tempfh != NULL, "can't open tempfile\n"); ret = WideCharToMultiByte(CP_UTF8, 0, wchar_text, ARRAY_SIZE(wchar_text), @@ -990,6 +1022,23 @@ static void test_fgetwc_unicode(void) ch = fgetwc(tempfh); ok(ch == WEOF, "got %04hx, expected WEOF (utf8)\n", ch); fclose(tempfh); + + tempfh = fopen(tempfile, "wb"); + ok(tempfh != NULL, "can't open tempfile\n"); + fwrite(wchar_text+1, 1, sizeof(wchar_text)-1, tempfh); + fclose(tempfh); + + tempfh = fopen(tempfile, "rt,ccs=utf-16le"); + ok(tempfh != NULL, "can't open tempfile\n"); + for (i = 1; i < ARRAY_SIZE(wchar_text); i++) + { + ch = fgetwc(tempfh); + ok(ch == wchar_text[i], + "got %04hx, expected %04x (unicode[%d])\n", ch, wchar_text[i], i-1); + } + ch = fgetwc(tempfh); + ok(ch == WEOF, "got %04hx, expected WEOF (unicode)\n", ch); + fclose(tempfh); unlink(temppath); }
1
0
0
0
Piotr Caban : msvcrt: Don't write Unicode BOM if file is not empty in _wsopen_dispatch.
by Alexandre Julliard
26 Nov '20
26 Nov '20
Module: wine Branch: master Commit: 00a024725e86f3dd3f8bb52849fd2597bbf58d40 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=00a024725e86f3dd3f8bb528…
Author: Piotr Caban <piotr(a)codeweavers.com> Date: Thu Nov 26 15:26:27 2020 +0100 msvcrt: Don't write Unicode BOM if file is not empty in _wsopen_dispatch. Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcrt/file.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/dlls/msvcrt/file.c b/dlls/msvcrt/file.c index 1cf778cca07..3b1c7d549d9 100644 --- a/dlls/msvcrt/file.c +++ b/dlls/msvcrt/file.c @@ -2297,9 +2297,14 @@ int CDECL MSVCRT__wsopen_dispatch( const MSVCRT_wchar_t* path, int oflags, int s if (oflags & (MSVCRT__O_WTEXT|MSVCRT__O_U16TEXT|MSVCRT__O_U8TEXT)) { + LARGE_INTEGER size = {{0}}; + + if ((access & GENERIC_WRITE) && (creation==OPEN_EXISTING || creation==OPEN_ALWAYS)) + GetFileSizeEx(hand, &size); + if ((access & GENERIC_WRITE) && (creation==CREATE_NEW || creation==CREATE_ALWAYS || creation==TRUNCATE_EXISTING - || (creation==OPEN_ALWAYS && GetLastError()==ERROR_ALREADY_EXISTS))) + || ((creation==OPEN_EXISTING || creation==OPEN_ALWAYS) && !size.QuadPart))) { if (oflags & MSVCRT__O_U8TEXT) {
1
0
0
0
Jacek Caban : jscript: Set error location when handling errors directly in parser.
by Alexandre Julliard
26 Nov '20
26 Nov '20
Module: wine Branch: master Commit: b485d58293bd7403a79d29c75a5b31b18b3cf52a URL:
https://source.winehq.org/git/wine.git/?a=commit;h=b485d58293bd7403a79d29c7…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Nov 26 15:27:50 2020 +0100 jscript: Set error location when handling errors directly in parser. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/jscript/parser.y | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/jscript/parser.y b/dlls/jscript/parser.y index 507369ca202..6016be6cfd8 100644 --- a/dlls/jscript/parser.y +++ b/dlls/jscript/parser.y @@ -780,7 +780,7 @@ ObjectLiteral { if(ctx->script->version < 2) { WARN("Trailing comma in object literal is illegal in legacy mode.\n"); - ctx->hres = JS_E_SYNTAX; + set_error(ctx, @3, JS_E_SYNTAX); YYABORT; } $$ = new_prop_and_value_expression(ctx, $2); @@ -824,7 +824,7 @@ IdentifierName if(ctx->script->version < SCRIPTLANGUAGEVERSION_ES5) { WARN("%s keyword used as an identifier in legacy mode.\n", debugstr_w($1)); - ctx->hres = JS_E_SYNTAX; + set_error(ctx, @$, JS_E_SYNTAX); YYABORT; } $$ = $1;
1
0
0
0
Jacek Caban : mshtml: Normalize bool values before passing them to Gecko.
by Alexandre Julliard
26 Nov '20
26 Nov '20
Module: wine Branch: master Commit: 1e94d99f3126af09219bcf76b2d2732ca011ad4e URL:
https://source.winehq.org/git/wine.git/?a=commit;h=1e94d99f3126af09219bcf76…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Nov 26 14:57:25 2020 +0100 mshtml: Normalize bool values before passing them to Gecko. Fixes events.js tests with llvm-mingw Gecko build. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/htmlevent.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/mshtml/htmlevent.c b/dlls/mshtml/htmlevent.c index 0bf3de54a96..1befd94c742 100644 --- a/dlls/mshtml/htmlevent.c +++ b/dlls/mshtml/htmlevent.c @@ -1225,7 +1225,7 @@ static HRESULT WINAPI DOMUIEvent_initUIEvent(IDOMUIEvent *iface, BSTR type, VARI return hres; nsAString_InitDepend(&type_str, type); - nsres = nsIDOMUIEvent_InitUIEvent(This->ui_event, &type_str, can_bubble, cancelable, + nsres = nsIDOMUIEvent_InitUIEvent(This->ui_event, &type_str, !!can_bubble, !!cancelable, NULL /* FIXME */, detail); nsAString_Finish(&type_str); if(NS_FAILED(nsres)) { @@ -1517,8 +1517,8 @@ static HRESULT WINAPI DOMMouseEvent_initMouseEvent(IDOMMouseEvent *iface, BSTR t nsAString_InitDepend(&type_str, type); nsres = nsIDOMMouseEvent_InitMouseEvent(This->mouse_event, &type_str, can_bubble, cancelable, NULL /* FIXME */, detail, screen_x, screen_y, - client_x, client_y, ctrl_key, alt_key, shift_key, - meta_key, button, nstarget); + client_x, client_y, !!ctrl_key, !!alt_key, !!shift_key, + !!meta_key, button, nstarget); nsAString_Finish(&type_str); if(NS_FAILED(nsres)) { FIXME("InitMouseEvent failed: %08x\n", nsres);
1
0
0
0
Nikolay Sivov : mf/session: Propagate allocator initialization failure code (Coverity).
by Alexandre Julliard
26 Nov '20
26 Nov '20
Module: wine Branch: master Commit: 9177e80de85fe76a1edc5644bcb635be12191bb8 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=9177e80de85fe76a1edc5644…
Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Nov 26 15:12:19 2020 +0300 mf/session: Propagate allocator initialization failure code (Coverity). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mf/session.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/dlls/mf/session.c b/dlls/mf/session.c index 6d4b58289d8..1a7439a13c3 100644 --- a/dlls/mf/session.c +++ b/dlls/mf/session.c @@ -794,6 +794,7 @@ static void session_shutdown_current_topology(struct media_session *session) IMFMediaSink *sink; IUnknown *object; WORD idx = 0; + HRESULT hr; topology = session->presentation.current_topology; force_shutdown = session->state == SESSION_STATE_SHUT_DOWN; @@ -813,7 +814,8 @@ static void session_shutdown_current_topology(struct media_session *session) if (SUCCEEDED(IMFTopologyNode_GetUnknown(node, &_MF_TOPONODE_IMFActivate, &IID_IMFActivate, (void **)&activate))) { - IMFActivate_ShutdownObject(activate); + if (FAILED(hr = IMFActivate_ShutdownObject(activate))) + WARN("Failed to shut down activation object for the sink, hr %#x.\n", hr); IMFActivate_Release(activate); } else if (SUCCEEDED(IMFTopologyNode_GetObject(node, &object))) @@ -1392,7 +1394,11 @@ static HRESULT session_append_node(struct media_session *session, IMFTopologyNod if (SUCCEEDED(MFGetService(topo_node->object.object, &MR_VIDEO_ACCELERATION_SERVICE, &IID_IMFVideoSampleAllocator, (void **)&topo_node->u.sink.allocator))) { - IMFVideoSampleAllocator_InitializeSampleAllocator(topo_node->u.sink.allocator, 2, media_type); + if (FAILED(hr = IMFVideoSampleAllocator_InitializeSampleAllocator(topo_node->u.sink.allocator, + 2, media_type))) + { + WARN("Failed to initialize sample allocator for the stream, hr %#x.\n", hr); + } IMFVideoSampleAllocator_QueryInterface(topo_node->u.sink.allocator, &IID_IMFVideoSampleAllocatorCallback, (void **)&topo_node->u.sink.allocator_cb); IMFVideoSampleAllocatorCallback_SetCallback(topo_node->u.sink.allocator_cb,
1
0
0
0
Nikolay Sivov : winegstreamer: Fix possible leak on error path (Coverity).
by Alexandre Julliard
26 Nov '20
26 Nov '20
Module: wine Branch: master Commit: 8315486d641dac9ee4268450f68e5093bbc91235 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=8315486d641dac9ee4268450…
Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Nov 26 15:07:33 2020 +0300 winegstreamer: Fix possible leak on error path (Coverity). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winegstreamer/media_source.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/winegstreamer/media_source.c b/dlls/winegstreamer/media_source.c index 83424719d54..5c502cf3ed5 100644 --- a/dlls/winegstreamer/media_source.c +++ b/dlls/winegstreamer/media_source.c @@ -1235,17 +1235,14 @@ static HRESULT media_source_constructor(IMFByteStream *bytestream, struct media_ GstStaticPadTemplate src_template = GST_STATIC_PAD_TEMPLATE("mf_src", GST_PAD_SRC, GST_PAD_ALWAYS, GST_STATIC_CAPS_ANY); - struct media_source *object = heap_alloc_zero(sizeof(*object)); IMFStreamDescriptor **descriptors = NULL; + struct media_source *object; gint64 total_pres_time = 0; DWORD bytestream_caps; unsigned int i; HRESULT hr; int ret; - if (!object) - return E_OUTOFMEMORY; - if (FAILED(hr = IMFByteStream_GetCapabilities(bytestream, &bytestream_caps))) return hr; @@ -1255,6 +1252,9 @@ static HRESULT media_source_constructor(IMFByteStream *bytestream, struct media_ return MF_E_BYTESTREAM_NOT_SEEKABLE; } + if (!(object = heap_alloc_zero(sizeof(*object)))) + return E_OUTOFMEMORY; + object->IMFMediaSource_iface.lpVtbl = &IMFMediaSource_vtbl; object->async_commands_callback.lpVtbl = &source_async_commands_callback_vtbl; object->ref = 1;
1
0
0
0
Biswapriyo Nath : include: Add D3D11_FORMAT_SUPPORT2 enumeration in d3d11.idl.
by Alexandre Julliard
26 Nov '20
26 Nov '20
Module: wine Branch: master Commit: 0d16b018c279cd911ab829c7553978b9cce8b9dd URL:
https://source.winehq.org/git/wine.git/?a=commit;h=0d16b018c279cd911ab829c7…
Author: Biswapriyo Nath <nathbappai(a)gmail.com> Date: Thu Nov 26 01:06:31 2020 +0530 include: Add D3D11_FORMAT_SUPPORT2 enumeration in d3d11.idl. Signed-off-by: Biswapriyo Nath <nathbappai(a)gmail.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/d3d11.idl | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/include/d3d11.idl b/include/d3d11.idl index 73ef42223eb..982f4abb8ae 100644 --- a/include/d3d11.idl +++ b/include/d3d11.idl @@ -1445,6 +1445,22 @@ typedef enum D3D11_FORMAT_SUPPORT D3D11_FORMAT_SUPPORT_VIDEO_ENCODER = 0x40000000, } D3D11_FORMAT_SUPPORT; +typedef enum D3D11_FORMAT_SUPPORT2 +{ + D3D11_FORMAT_SUPPORT2_UAV_ATOMIC_ADD = 0x00000001, + D3D11_FORMAT_SUPPORT2_UAV_ATOMIC_BITWISE_OPS = 0x00000002, + D3D11_FORMAT_SUPPORT2_UAV_ATOMIC_COMPARE_STORE_OR_COMPARE_EXCHANGE = 0x00000004, + D3D11_FORMAT_SUPPORT2_UAV_ATOMIC_EXCHANGE = 0x00000008, + D3D11_FORMAT_SUPPORT2_UAV_ATOMIC_SIGNED_MIN_OR_MAX = 0x00000010, + D3D11_FORMAT_SUPPORT2_UAV_ATOMIC_UNSIGNED_MIN_OR_MAX = 0x00000020, + D3D11_FORMAT_SUPPORT2_UAV_TYPED_LOAD = 0x00000040, + D3D11_FORMAT_SUPPORT2_UAV_TYPED_STORE = 0x00000080, + D3D11_FORMAT_SUPPORT2_OUTPUT_MERGER_LOGIC_OP = 0x00000100, + D3D11_FORMAT_SUPPORT2_TILED = 0x00000200, + D3D11_FORMAT_SUPPORT2_SHAREABLE = 0x00000400, + D3D11_FORMAT_SUPPORT2_MULTIPLANE_OVERLAY = 0x00004000, +} D3D11_FORMAT_SUPPORT2; + typedef enum D3D11_CLEAR_FLAG { D3D11_CLEAR_DEPTH = 0x0001L,
1
0
0
0
Biswapriyo Nath : include: Add D3D11_RAISE_FLAG enumeration in d3d11.idl.
by Alexandre Julliard
26 Nov '20
26 Nov '20
Module: wine Branch: master Commit: 2a1d021cf54ecb9c2ae00e95df76e4c133864275 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=2a1d021cf54ecb9c2ae00e95…
Author: Biswapriyo Nath <nathbappai(a)gmail.com> Date: Thu Nov 26 01:05:54 2020 +0530 include: Add D3D11_RAISE_FLAG enumeration in d3d11.idl. Signed-off-by: Biswapriyo Nath <nathbappai(a)gmail.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/d3d11.idl | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/d3d11.idl b/include/d3d11.idl index 3613238d722..73ef42223eb 100644 --- a/include/d3d11.idl +++ b/include/d3d11.idl @@ -961,6 +961,11 @@ typedef enum D3D11_MAP_FLAG D3D11_MAP_FLAG_DO_NOT_WAIT = 0x00100000 } D3D11_MAP_FLAG; +typedef enum D3D11_RAISE_FLAG +{ + D3D11_RAISE_FLAG_DRIVER_INTERNAL_ERROR = 0x1, +} D3D11_RAISE_FLAG; + typedef struct D3D11_QUERY_DATA_SO_STATISTICS { UINT64 NumPrimitivesWritten;
1
0
0
0
← Newer
1
...
11
12
13
14
15
16
17
...
86
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
Results per page:
10
25
50
100
200