winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
November 2020
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
1 participants
851 discussions
Start a n
N
ew thread
Gijs Vermeulen : avrt: Add AvSetMmMaxThreadCharacteristicsA/W stub.
by Alexandre Julliard
24 Nov '20
24 Nov '20
Module: wine Branch: master Commit: fed67d6edd2e6451a3e773d37a916add310e6ae6 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=fed67d6edd2e6451a3e773d3…
Author: Gijs Vermeulen <gijsvrm(a)gmail.com> Date: Sun Nov 22 15:45:14 2020 +0100 avrt: Add AvSetMmMaxThreadCharacteristicsA/W stub. Wine-Bug:
https://bugs.winehq.org/show_bug.cgi?id=50160
Signed-off-by: Gijs Vermeulen <gijsvrm(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/avrt/avrt.spec | 4 +-- dlls/avrt/main.c | 86 ++++++++++++++++++++++++++++++++++++++++++----------- include/avrt.h | 2 +- 3 files changed, 72 insertions(+), 20 deletions(-) diff --git a/dlls/avrt/avrt.spec b/dlls/avrt/avrt.spec index a7dfc42879c..0a05abcdbca 100644 --- a/dlls/avrt/avrt.spec +++ b/dlls/avrt/avrt.spec @@ -7,8 +7,8 @@ @ stub AvRtJoinThreadOrderingGroup @ stub AvRtLeaveThreadOrderingGroup @ stub AvRtWaitOnThreadOrderingGroup -@ stub AvSetMmMaxThreadCharacteristicsA -@ stub AvSetMmMaxThreadCharacteristicsW +@ stdcall AvSetMmMaxThreadCharacteristicsA(str str ptr) +@ stdcall AvSetMmMaxThreadCharacteristicsW(wstr wstr ptr) @ stdcall AvSetMmThreadCharacteristicsA(str ptr) @ stdcall AvSetMmThreadCharacteristicsW(wstr ptr) @ stdcall AvSetMmThreadPriority(ptr long) diff --git a/dlls/avrt/main.c b/dlls/avrt/main.c index eb5704cc508..258c525e198 100644 --- a/dlls/avrt/main.c +++ b/dlls/avrt/main.c @@ -23,10 +23,21 @@ #include "winbase.h" #include "winnls.h" #include "wine/debug.h" +#include "wine/heap.h" #include "avrt.h" WINE_DEFAULT_DEBUG_CHANNEL(avrt); +static inline WCHAR *heap_strdupAW(const char *src) +{ + int len; + WCHAR *dst; + if (!src) return NULL; + len = MultiByteToWideChar(CP_ACP, 0, src, -1, NULL, 0); + if ((dst = heap_alloc(len * sizeof(*dst)))) MultiByteToWideChar(CP_ACP, 0, src, -1, dst, len); + return dst; +} + BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) { TRACE("(0x%p, %d, %p)\n", hinstDLL, fdwReason, lpvReserved); @@ -43,41 +54,39 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) return TRUE; } -HANDLE WINAPI AvSetMmThreadCharacteristicsA(LPCSTR TaskName, LPDWORD TaskIndex) +HANDLE WINAPI AvSetMmThreadCharacteristicsA(const char *name, DWORD *index) { + WCHAR *nameW = NULL; HANDLE ret; - LPWSTR str = NULL; - if (TaskName) + if (name && !(nameW = heap_strdupAW(name))) { - DWORD len = (lstrlenA(TaskName)+1); - str = HeapAlloc(GetProcessHeap(), 0, len*sizeof(WCHAR)); - if (!str) - { - SetLastError(ERROR_OUTOFMEMORY); - return NULL; - } - MultiByteToWideChar(CP_ACP, 0, TaskName, len, str, len); + SetLastError(ERROR_OUTOFMEMORY); + return NULL; } - ret = AvSetMmThreadCharacteristicsW(str, TaskIndex); - HeapFree(GetProcessHeap(), 0, str); + + ret = AvSetMmThreadCharacteristicsW(nameW, index); + + heap_free(nameW); return ret; } -HANDLE WINAPI AvSetMmThreadCharacteristicsW(LPCWSTR TaskName, LPDWORD TaskIndex) +HANDLE WINAPI AvSetMmThreadCharacteristicsW(const WCHAR *name, DWORD *index) { - FIXME("(%s,%p): stub\n", debugstr_w(TaskName), TaskIndex); + FIXME("(%s,%p): stub\n", debugstr_w(name), index); - if (!TaskName) + if (!name) { SetLastError(ERROR_INVALID_TASK_NAME); return NULL; } - if (!TaskIndex) + + if (!index) { SetLastError(ERROR_INVALID_HANDLE); return NULL; } + return (HANDLE)0x12345678; } @@ -98,3 +107,46 @@ BOOL WINAPI AvSetMmThreadPriority(HANDLE AvrtHandle, AVRT_PRIORITY prio) FIXME("(%p)->(%u) stub\n", AvrtHandle, prio); return TRUE; } + +HANDLE WINAPI AvSetMmMaxThreadCharacteristicsA(const char *task1, const char *task2, DWORD *index) +{ + WCHAR *task1W = NULL, *task2W = NULL; + HANDLE ret; + + if (task1 && !(task1W = heap_strdupAW(task1))) + { + SetLastError(ERROR_OUTOFMEMORY); + return NULL; + } + + if (task2 && !(task2W = heap_strdupAW(task2))) + { + SetLastError(ERROR_OUTOFMEMORY); + return NULL; + } + + ret = AvSetMmMaxThreadCharacteristicsW(task1W, task2W, index); + + heap_free(task2W); + heap_free(task1W); + return ret; +} + +HANDLE WINAPI AvSetMmMaxThreadCharacteristicsW(const WCHAR *task1, const WCHAR *task2, DWORD *index) +{ + FIXME("(%s,%s,%p): stub\n", debugstr_w(task1), debugstr_w(task2), index); + + if (!task1 || task2) + { + SetLastError(ERROR_INVALID_TASK_NAME); + return NULL; + } + + if (!index) + { + SetLastError(ERROR_INVALID_HANDLE); + return NULL; + } + + return (HANDLE)0x12345678; +} diff --git a/include/avrt.h b/include/avrt.h index 9d12c1b5b1b..88beebb0bf8 100644 --- a/include/avrt.h +++ b/include/avrt.h @@ -43,7 +43,7 @@ HANDLE WINAPI AvSetMmThreadCharacteristicsW(LPCWSTR TaskName, LPDWORD TaskIndex) #define AvSetMmThreadCharacteristics WINELIB_NAME_AW(AvSetMmThreadCharacteristics) HANDLE WINAPI AvSetMmMaxThreadCharacteristicsA(LPCSTR FirstTask, LPCSTR SecondTask, LPDWORD TaskIndex); -HANDLE WINAPI AvSetMmMaxThreadCharacteristicsW(LPCSTR FirstTask, LPCSTR SecondTask, LPDWORD TaskIndex); +HANDLE WINAPI AvSetMmMaxThreadCharacteristicsW(LPCWSTR FirstTask, LPCWSTR SecondTask, LPDWORD TaskIndex); #define AvSetMmMaxThreadCharacteristics WINELIB_NAME_AW(AvSetMmMaxThreadCharacteristics) BOOL WINAPI AvRevertMmThreadCharacteristics(HANDLE AvrtHandle);
1
0
0
0
Erich E. Hoover : ntdll: Fix converting large 32-bit time_t when time_t is signed.
by Alexandre Julliard
24 Nov '20
24 Nov '20
Module: wine Branch: master Commit: 773b97bb2b0f4421d213b466337dd6d66b2b0856 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=773b97bb2b0f4421d213b466…
Author: Erich E. Hoover <erich.e.hoover(a)gmail.com> Date: Sat Nov 21 22:33:20 2020 -0700 ntdll: Fix converting large 32-bit time_t when time_t is signed. Signed-off-by: Erich E. Hoover <erich.e.hoover(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/tests/file.c | 12 ++++++++++++ dlls/ntdll/unix/file.c | 10 +++++----- dlls/ntdll/unix/sync.c | 12 +++++------- dlls/ntdll/unix/unix_private.h | 9 ++++++++- 4 files changed, 30 insertions(+), 13 deletions(-) diff --git a/dlls/ntdll/tests/file.c b/dlls/ntdll/tests/file.c index 8b9ec4f624d..2507437c8c3 100644 --- a/dlls/ntdll/tests/file.c +++ b/dlls/ntdll/tests/file.c @@ -1361,6 +1361,18 @@ static void test_file_basic_information(void) ok ( res == STATUS_SUCCESS, "can't set system attribute, NtSetInformationFile returned %x\n", res ); ok ( U(io).Status == STATUS_SUCCESS, "can't set system attribute, io.Status is %x\n", U(io).Status ); + memset(&fbi2, 0, sizeof(fbi2)); + fbi2.LastAccessTime.QuadPart = 0x200deadcafebeef; + U(io).Status = 0xdeadbeef; + res = pNtSetInformationFile(h, &io, &fbi2, sizeof(fbi2), FileBasicInformation); + ok ( res == STATUS_SUCCESS, "can't set system attribute, NtSetInformationFile returned %x\n", res ); + ok ( U(io).Status == STATUS_SUCCESS, "can't set system attribute, io.Status is %x\n", U(io).Status ); + res = pNtQueryInformationFile(h, &io, &fbi, sizeof(fbi), FileBasicInformation); + ok ( res == STATUS_SUCCESS, "can't get system attribute, NtQueryInformationFile returned %x\n", res ); + ok ( U(io).Status == STATUS_SUCCESS, "can't get system attribute, io.Status is %x\n", U(io).Status ); + ok ( fbi2.LastAccessTime.QuadPart == fbi.LastAccessTime.QuadPart, + "large access time set/get does not match.\n" ); + memset(&fbi2, 0, sizeof(fbi2)); res = pNtQueryInformationFile(h, &io, &fbi2, sizeof fbi2, FileBasicInformation); ok ( res == STATUS_SUCCESS, "can't get attributes, res %x\n", res); diff --git a/dlls/ntdll/unix/file.c b/dlls/ntdll/unix/file.c index cf413f46e5c..6d6edfe8926 100644 --- a/dlls/ntdll/unix/file.c +++ b/dlls/ntdll/unix/file.c @@ -1631,9 +1631,9 @@ static NTSTATUS set_file_times( int fd, const LARGE_INTEGER *mtime, const LARGE_ static inline void get_file_times( const struct stat *st, LARGE_INTEGER *mtime, LARGE_INTEGER *ctime, LARGE_INTEGER *atime, LARGE_INTEGER *creation ) { - mtime->QuadPart = st->st_mtime * (ULONGLONG)TICKSPERSEC + TICKS_1601_TO_1970; - ctime->QuadPart = st->st_ctime * (ULONGLONG)TICKSPERSEC + TICKS_1601_TO_1970; - atime->QuadPart = st->st_atime * (ULONGLONG)TICKSPERSEC + TICKS_1601_TO_1970; + mtime->QuadPart = ticks_from_time_t( st->st_mtime ); + ctime->QuadPart = ticks_from_time_t( st->st_ctime ); + atime->QuadPart = ticks_from_time_t( st->st_atime ); #ifdef HAVE_STRUCT_STAT_ST_MTIM mtime->QuadPart += st->st_mtim.tv_nsec / 100; #elif defined(HAVE_STRUCT_STAT_ST_MTIMESPEC) @@ -1650,14 +1650,14 @@ static inline void get_file_times( const struct stat *st, LARGE_INTEGER *mtime, atime->QuadPart += st->st_atimespec.tv_nsec / 100; #endif #ifdef HAVE_STRUCT_STAT_ST_BIRTHTIME - creation->QuadPart = st->st_birthtime * (ULONGLONG)TICKSPERSEC + TICKS_1601_TO_1970; + creation->QuadPart = ticks_from_time_t( st->st_birthtime ); #ifdef HAVE_STRUCT_STAT_ST_BIRTHTIM creation->QuadPart += st->st_birthtim.tv_nsec / 100; #elif defined(HAVE_STRUCT_STAT_ST_BIRTHTIMESPEC) creation->QuadPart += st->st_birthtimespec.tv_nsec / 100; #endif #elif defined(HAVE_STRUCT_STAT___ST_BIRTHTIME) - creation->QuadPart = st->__st_birthtime * (ULONGLONG)TICKSPERSEC + TICKS_1601_TO_1970; + creation->QuadPart = ticks_from_time_t( st->__st_birthtime ); #ifdef HAVE_STRUCT_STAT___ST_BIRTHTIM creation->QuadPart += st->__st_birthtim.tv_nsec / 100; #endif diff --git a/dlls/ntdll/unix/sync.c b/dlls/ntdll/unix/sync.c index bba7af7e34f..dcc8c5447ef 100644 --- a/dlls/ntdll/unix/sync.c +++ b/dlls/ntdll/unix/sync.c @@ -104,7 +104,7 @@ static inline ULONGLONG monotonic_counter(void) return ts.tv_sec * (ULONGLONG)TICKSPERSEC + ts.tv_nsec / 100; #endif gettimeofday( &now, 0 ); - return now.tv_sec * (ULONGLONG)TICKSPERSEC + now.tv_usec * 10 + TICKS_1601_TO_1970 - server_start_time; + return ticks_from_time_t( now.tv_sec ) + now.tv_usec * 10 - server_start_time; } @@ -1392,8 +1392,7 @@ NTSTATUS WINAPI NtQuerySystemTime( LARGE_INTEGER *time ) if (!clock_gettime( clock_id, &ts )) { - time->QuadPart = ts.tv_sec * (ULONGLONG)TICKSPERSEC + TICKS_1601_TO_1970; - time->QuadPart += (ts.tv_nsec + 50) / 100; + time->QuadPart = ticks_from_time_t( ts.tv_sec ) + (ts.tv_nsec + 50) / 100; } else #endif /* HAVE_CLOCK_GETTIME */ @@ -1401,8 +1400,7 @@ NTSTATUS WINAPI NtQuerySystemTime( LARGE_INTEGER *time ) struct timeval now; gettimeofday( &now, 0 ); - time->QuadPart = now.tv_sec * (ULONGLONG)TICKSPERSEC + TICKS_1601_TO_1970; - time->QuadPart += now.tv_usec * 10; + time->QuadPart = ticks_from_time_t( now.tv_sec ) + now.tv_usec * 10; } return STATUS_SUCCESS; } @@ -1475,10 +1473,10 @@ LONGLONG WINAPI RtlGetSystemTimePrecise(void) struct timespec ts; if (!clock_gettime( CLOCK_REALTIME, &ts )) - return ts.tv_sec * (ULONGLONG)TICKSPERSEC + TICKS_1601_TO_1970 + (ts.tv_nsec + 50) / 100; + return ticks_from_time_t( ts.tv_sec ) + (ts.tv_nsec + 50) / 100; #endif gettimeofday( &now, 0 ); - return now.tv_sec * (ULONGLONG)TICKSPERSEC + TICKS_1601_TO_1970 + now.tv_usec * 10; + return ticks_from_time_t( now.tv_sec ) + now.tv_usec * 10; } diff --git a/dlls/ntdll/unix/unix_private.h b/dlls/ntdll/unix/unix_private.h index c3ad0a41098..23731f0fdc6 100644 --- a/dlls/ntdll/unix/unix_private.h +++ b/dlls/ntdll/unix/unix_private.h @@ -249,7 +249,14 @@ extern void WINAPI DECLSPEC_NORETURN call_raise_user_exception_dispatcher( NTSTA #define TICKSPERSEC 10000000 #define SECS_1601_TO_1970 ((369 * 365 + 89) * (ULONGLONG)86400) -#define TICKS_1601_TO_1970 (SECS_1601_TO_1970 * TICKSPERSEC) + +static inline ULONGLONG ticks_from_time_t( time_t time ) +{ + if (sizeof(time_t) == sizeof(int)) /* time_t may be signed */ + return ((ULONGLONG)(ULONG)time + SECS_1601_TO_1970) * TICKSPERSEC; + else + return ((ULONGLONG)time + SECS_1601_TO_1970) * TICKSPERSEC; +} static inline const char *debugstr_us( const UNICODE_STRING *us ) {
1
0
0
0
Jacek Caban : conhost: Signal console in process_console_input if needed.
by Alexandre Julliard
24 Nov '20
24 Nov '20
Module: wine Branch: master Commit: dfe1bb7b8d90fd1e6f660232eb8ccccf8a30f05c URL:
https://source.winehq.org/git/wine.git/?a=commit;h=dfe1bb7b8d90fd1e6f660232…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Nov 24 17:18:01 2020 +0100 conhost: Signal console in process_console_input if needed. Wine-Bug:
https://bugs.winehq.org/show_bug.cgi?id=50037
Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/conhost/conhost.c | 7 ++++++- programs/conhost/conhost.h | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/programs/conhost/conhost.c b/programs/conhost/conhost.c index 2a4de030cbb..e3a9a25eac3 100644 --- a/programs/conhost/conhost.c +++ b/programs/conhost/conhost.c @@ -428,6 +428,7 @@ static NTSTATUS read_complete( struct console *console, NTSTATUS status, const v } SERVER_END_REQ; if (status && (console->read_ioctl || status != STATUS_INVALID_HANDLE)) ERR( "failed: %#x\n", status ); + console->signaled = signal; console->read_ioctl = 0; console->pending_read = 0; return status; @@ -1218,6 +1219,9 @@ static NTSTATUS process_console_input( struct console *console ) case IOCTL_CONDRV_READ_FILE: break; default: + assert( !console->read_ioctl ); + if (console->record_count && !console->signaled) + read_complete( console, STATUS_PENDING, NULL, 0, TRUE ); /* signal server */ return STATUS_SUCCESS; } @@ -2534,11 +2538,12 @@ static NTSTATUS process_console_ioctls( struct console *console ) { if (status) out_size = 0; + console->signaled = console->record_count != 0; SERVER_START_REQ( get_next_console_request ) { req->handle = wine_server_obj_handle( console->server ); req->status = status; - req->signal = console->record_count != 0; + req->signal = console->signaled; wine_server_add_data( req, ioctl_buffer, out_size ); wine_server_set_reply( req, ioctl_buffer, ioctl_buffer_size ); status = wine_server_call( req ); diff --git a/programs/conhost/conhost.h b/programs/conhost/conhost.h index 7bc102b0df0..3094fd6e5f0 100644 --- a/programs/conhost/conhost.h +++ b/programs/conhost/conhost.h @@ -80,6 +80,7 @@ struct console INPUT_RECORD *records; /* input records */ unsigned int record_count; /* number of input records */ unsigned int record_size; /* size of input records buffer */ + int signaled; /* is server in signaled state */ WCHAR *read_buffer; /* buffer of data available for read */ size_t read_buffer_count; /* size of available data */ size_t read_buffer_size; /* size of buffer */
1
0
0
0
Nikolay Sivov : mfreadwrite/reader: Implement GetServiceForStream() for stream objects.
by Alexandre Julliard
24 Nov '20
24 Nov '20
Module: wine Branch: master Commit: 8999dd2ba093c8f249f2182299ee7c9d069f0083 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=8999dd2ba093c8f249f21822…
Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Nov 24 18:14:24 2020 +0300 mfreadwrite/reader: Implement GetServiceForStream() for stream objects. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mfreadwrite/reader.c | 52 ++++++++++++++++++++++++++++++++++------------- 1 file changed, 38 insertions(+), 14 deletions(-) diff --git a/dlls/mfreadwrite/reader.c b/dlls/mfreadwrite/reader.c index 7aa8f65df7a..85aec9aaedc 100644 --- a/dlls/mfreadwrite/reader.c +++ b/dlls/mfreadwrite/reader.c @@ -1906,36 +1906,60 @@ static HRESULT WINAPI src_reader_GetServiceForStream(IMFSourceReader *iface, DWO { struct source_reader *reader = impl_from_IMFSourceReader(iface); IUnknown *obj = NULL; - HRESULT hr; + HRESULT hr = S_OK; TRACE("%p, %#x, %s, %s, %p\n", iface, index, debugstr_guid(service), debugstr_guid(riid), object); + EnterCriticalSection(&reader->cs); + switch (index) { case MF_SOURCE_READER_MEDIASOURCE: obj = (IUnknown *)reader->source; break; default: - FIXME("Unsupported index %#x.\n", index); - return E_NOTIMPL; - } + if (index == MF_SOURCE_READER_FIRST_VIDEO_STREAM) + index = reader->first_video_stream_index; + else if (index == MF_SOURCE_READER_FIRST_AUDIO_STREAM) + index = reader->first_audio_stream_index; - if (IsEqualGUID(service, &GUID_NULL)) - { - hr = IUnknown_QueryInterface(obj, riid, object); + if (index >= reader->stream_count) + hr = MF_E_INVALIDSTREAMNUMBER; + else + { + obj = (IUnknown *)reader->streams[index].decoder; + if (!obj) hr = E_NOINTERFACE; + } + break; } - else - { - IMFGetService *gs; - hr = IUnknown_QueryInterface(obj, &IID_IMFGetService, (void **)&gs); - if (SUCCEEDED(hr)) + if (obj) + IUnknown_AddRef(obj); + + LeaveCriticalSection(&reader->cs); + + if (obj) + { + if (IsEqualGUID(service, &GUID_NULL)) { - hr = IMFGetService_GetService(gs, service, riid, object); - IMFGetService_Release(gs); + hr = IUnknown_QueryInterface(obj, riid, object); + } + else + { + IMFGetService *gs; + + hr = IUnknown_QueryInterface(obj, &IID_IMFGetService, (void **)&gs); + if (SUCCEEDED(hr)) + { + hr = IMFGetService_GetService(gs, service, riid, object); + IMFGetService_Release(gs); + } } } + if (obj) + IUnknown_Release(obj); + return hr; }
1
0
0
0
Nikolay Sivov : evr/presenter: Add aspect ratio preserving scaling.
by Alexandre Julliard
24 Nov '20
24 Nov '20
Module: wine Branch: master Commit: c06e7ba7299827d1a876a58676b51597a2560a41 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=c06e7ba7299827d1a876a586…
Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Nov 24 18:12:46 2020 +0300 evr/presenter: Add aspect ratio preserving scaling. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/evr/presenter.c | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 50 insertions(+), 1 deletion(-) diff --git a/dlls/evr/presenter.c b/dlls/evr/presenter.c index 5701eb17bd3..9b7fb5f6f67 100644 --- a/dlls/evr/presenter.c +++ b/dlls/evr/presenter.c @@ -426,10 +426,27 @@ static HRESULT video_presenter_get_sample_surface(IMFSample *sample, IDirect3DSu return hr; } +static void scale_rect(RECT *rect, unsigned int width, unsigned int height, const MFVideoNormalizedRect *scale) +{ + if (rect->left == 0.0f && rect->top == 0.0f && rect->right == 1.0f && rect->bottom == 1.0f) + { + SetRect(rect, 0, 0, width, height); + } + else + { + rect->left = width * scale->left; + rect->right = width * scale->right; + rect->top = height * scale->top; + rect->bottom = height * scale->bottom; + } +} + static void video_presenter_sample_present(struct video_presenter *presenter, IMFSample *sample) { IDirect3DSurface9 *surface, *backbuffer; IDirect3DDevice9 *device; + D3DSURFACE_DESC desc; + RECT dst, src; HRESULT hr; if (!presenter->swapchain) @@ -450,7 +467,39 @@ static void video_presenter_sample_present(struct video_presenter *presenter, IM IDirect3DSwapChain9_GetDevice(presenter->swapchain, &device); IDirect3DDevice9_StretchRect(device, surface, NULL, backbuffer, NULL, D3DTEXF_POINT); - IDirect3DSwapChain9_Present(presenter->swapchain, NULL, NULL, NULL, NULL, 0); + + IDirect3DSurface9_GetDesc(surface, &desc); + scale_rect(&src, desc.Width, desc.Height, &presenter->src_rect); + + IDirect3DSurface9_GetDesc(backbuffer, &desc); + SetRect(&dst, 0, 0, desc.Width, desc.Height); + + if (presenter->ar_mode & MFVideoARMode_PreservePicture) + { + unsigned int src_width = src.right - src.left, src_height = src.bottom - src.top; + unsigned int dst_width = dst.right - dst.left, dst_height = dst.bottom - dst.top; + + if (src_width * dst_height > dst_width * src_height) + { + /* src is "wider" than dst. */ + unsigned int dst_center = (dst.top + dst.bottom) / 2; + unsigned int scaled_height = src_height * dst_width / src_width; + + dst.top = dst_center - scaled_height / 2; + dst.bottom = dst.top + scaled_height; + } + else if (src_width * dst_height < dst_width * src_height) + { + /* src is "taller" than dst. */ + unsigned int dst_center = (dst.left + dst.right) / 2; + unsigned int scaled_width = src_width * dst_height / src_height; + + dst.left = dst_center - scaled_width / 2; + dst.right = dst.left + scaled_width; + } + } + + IDirect3DSwapChain9_Present(presenter->swapchain, &src, &dst, NULL, NULL, 0); IDirect3DDevice9_Release(device); IDirect3DSurface9_Release(backbuffer);
1
0
0
0
Nikolay Sivov : evr/presenter: Set frame size and aperture attributes for mixer output type.
by Alexandre Julliard
24 Nov '20
24 Nov '20
Module: wine Branch: master Commit: 1f1842e02719905f08fdd858fe455cde1ab2b9ad URL:
https://source.winehq.org/git/wine.git/?a=commit;h=1f1842e02719905f08fdd858…
Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Nov 24 18:12:45 2020 +0300 evr/presenter: Set frame size and aperture attributes for mixer output type. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/evr/presenter.c | 36 ++++++++++++-- dlls/evr/tests/evr.c | 132 +++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 163 insertions(+), 5 deletions(-) diff --git a/dlls/evr/presenter.c b/dlls/evr/presenter.c index f0733f6f060..5701eb17bd3 100644 --- a/dlls/evr/presenter.c +++ b/dlls/evr/presenter.c @@ -306,17 +306,43 @@ static HRESULT video_presenter_set_media_type(struct video_presenter *presenter, static HRESULT video_presenter_invalidate_media_type(struct video_presenter *presenter) { - IMFMediaType *media_type; + IMFMediaType *media_type, *candidate_type; unsigned int idx = 0; + UINT64 frame_size; + MFVideoArea aperture; + RECT rect; HRESULT hr; + if (FAILED(hr = MFCreateMediaType(&media_type))) + return hr; + video_presenter_get_native_video_size(presenter); - while (SUCCEEDED(hr = IMFTransform_GetOutputAvailableType(presenter->mixer, 0, idx++, &media_type))) + rect = presenter->dst_rect; + if (rect.left == 0 && rect.right == 0 && rect.bottom == 0 && rect.top == 0) + { + rect.right = presenter->native_size.cx; + rect.bottom = presenter->native_size.cy; + } + + aperture.Area.cx = rect.right - rect.left; + aperture.Area.cy = rect.bottom - rect.top; + aperture.OffsetX.value = 0; + aperture.OffsetX.fract = 0; + aperture.OffsetY.value = 0; + aperture.OffsetY.fract = 0; + frame_size = (UINT64)aperture.Area.cx << 32 | aperture.Area.cy; + + while (SUCCEEDED(hr = IMFTransform_GetOutputAvailableType(presenter->mixer, 0, idx++, &candidate_type))) { /* FIXME: check that d3d device supports this format */ - /* FIXME: potentially adjust frame size */ + if (FAILED(hr = IMFMediaType_CopyAllItems(candidate_type, (IMFAttributes *)media_type))) + WARN("Failed to clone a media type, hr %#x.\n", hr); + IMFMediaType_Release(candidate_type); + + IMFMediaType_SetUINT64(media_type, &MF_MT_FRAME_SIZE, frame_size); + IMFMediaType_SetBlob(media_type, &MF_MT_GEOMETRIC_APERTURE, (UINT8 *)&aperture, sizeof(aperture)); hr = IMFTransform_SetOutputType(presenter->mixer, 0, media_type, MFT_SET_TYPE_TEST_ONLY); @@ -326,12 +352,12 @@ static HRESULT video_presenter_invalidate_media_type(struct video_presenter *pre if (SUCCEEDED(hr)) hr = IMFTransform_SetOutputType(presenter->mixer, 0, media_type, 0); - IMFMediaType_Release(media_type); - if (SUCCEEDED(hr)) break; } + IMFMediaType_Release(media_type); + return hr; } diff --git a/dlls/evr/tests/evr.c b/dlls/evr/tests/evr.c index 2740f2263f0..31434bde43a 100644 --- a/dlls/evr/tests/evr.c +++ b/dlls/evr/tests/evr.c @@ -2072,6 +2072,137 @@ todo_wine { IMFVideoPresenter_Release(presenter); } +static void get_output_aperture(IMFTransform *mixer, SIZE *frame_size, MFVideoArea *aperture) +{ + IMFMediaType *media_type; + UINT64 size; + HRESULT hr; + + memset(frame_size, 0xcc, sizeof(*frame_size)); + memset(aperture, 0xcc, sizeof(*aperture)); + + hr = IMFTransform_GetOutputCurrentType(mixer, 0, &media_type); + ok(hr == S_OK, "Unexpected hr %#x.\n", hr); + + hr = IMFMediaType_GetUINT64(media_type, &MF_MT_FRAME_SIZE, &size); + ok(hr == S_OK, "Unexpected hr %#x.\n", hr); + + frame_size->cx = size >> 32; + frame_size->cy = size; + + hr = IMFMediaType_GetBlob(media_type, &MF_MT_GEOMETRIC_APERTURE, (UINT8 *)aperture, sizeof(*aperture), NULL); + ok(hr == S_OK, "Unexpected hr %#x.\n", hr); + + IMFMediaType_Release(media_type); +} + +static void test_presenter_media_type(void) +{ + IMFTopologyServiceLookupClient *lookup_client; + IMFVideoPresenter *presenter; + struct test_host host; + IMFMediaType *input_type; + IDirect3DDeviceManager9 *manager; + HRESULT hr; + IMFTransform *mixer; + IDirect3D9 *d3d; + IDirect3DDevice9 *device; + unsigned int token; + SIZE frame_size; + HWND window; + MFVideoArea aperture; + IMFVideoDisplayControl *display_control; + RECT dst; + + window = create_window(); + d3d = Direct3DCreate9(D3D_SDK_VERSION); + ok(!!d3d, "Failed to create a D3D object.\n"); + if (!(device = create_device(d3d, window))) + { + skip("Failed to create a D3D device, skipping tests.\n"); + goto done; + } + + hr = DXVA2CreateDirect3DDeviceManager9(&token, &manager); + ok(hr == S_OK, "Unexpected hr %#x.\n", hr); + + hr = IDirect3DDeviceManager9_ResetDevice(manager, device, token); + ok(hr == S_OK, "Unexpected hr %#x.\n", hr); + + hr = MFCreateVideoPresenter(NULL, &IID_IDirect3DDevice9, &IID_IMFVideoPresenter, (void **)&presenter); + ok(hr == S_OK, "Failed to create default presenter, hr %#x.\n", hr); + + hr = IMFVideoPresenter_QueryInterface(presenter, &IID_IMFVideoDisplayControl, (void **)&display_control); + ok(hr == S_OK, "Unexpected hr %#x.\n", hr); + + hr = MFCreateVideoMixer(NULL, &IID_IDirect3DDevice9, &IID_IMFTransform, (void **)&mixer); + ok(hr == S_OK, "Failed to create a mixer, hr %#x.\n", hr); + + input_type = create_video_type(&MFVideoFormat_RGB32); + + hr = IMFMediaType_SetUINT64(input_type, &MF_MT_FRAME_SIZE, (UINT64)100 << 32 | 50); + ok(hr == S_OK, "Unexpected hr %#x.\n", hr); + hr = IMFMediaType_SetUINT32(input_type, &MF_MT_ALL_SAMPLES_INDEPENDENT, TRUE); + ok(hr == S_OK, "Unexpected hr %#x.\n", hr); + + hr = IMFTransform_ProcessMessage(mixer, MFT_MESSAGE_SET_D3D_MANAGER, (ULONG_PTR)manager); + ok(hr == S_OK, "Unexpected hr %#x.\n", hr); + + hr = IMFTransform_SetInputType(mixer, 0, input_type, 0); + ok(hr == S_OK, "Unexpected hr %#x.\n", hr); + + hr = IMFVideoPresenter_QueryInterface(presenter, &IID_IMFTopologyServiceLookupClient, (void **)&lookup_client); + ok(hr == S_OK, "Unexpected hr %#x.\n", hr); + + init_test_host(&host, mixer, presenter); + + hr = IMFTopologyServiceLookupClient_InitServicePointers(lookup_client, &host.IMFTopologyServiceLookup_iface); + ok(hr == S_OK, "Unexpected hr %#x.\n", hr); + + hr = IMFVideoDisplayControl_SetVideoWindow(display_control, window); + ok(hr == S_OK, "Unexpected hr %#x.\n", hr); + + hr = IMFVideoPresenter_ProcessMessage(presenter, MFVP_MESSAGE_INVALIDATEMEDIATYPE, 0); + ok(hr == S_OK, "Unexpected hr %#x.\n", hr); + + get_output_aperture(mixer, &frame_size, &aperture); + ok(frame_size.cx == 100 && frame_size.cy == 50, "Unexpected frame size %u x %u.\n", frame_size.cx, frame_size.cy); + ok(aperture.Area.cx == 100 && aperture.Area.cy == 50, "Unexpected size %u x %u.\n", aperture.Area.cx, aperture.Area.cy); + ok(!aperture.OffsetX.value && !aperture.OffsetX.fract && !aperture.OffsetY.value && !aperture.OffsetY.fract, + "Unexpected offset %u x %u.\n", aperture.OffsetX.value, aperture.OffsetY.value); + + SetRect(&dst, 1, 2, 200, 300); + hr = IMFVideoDisplayControl_SetVideoPosition(display_control, NULL, &dst); + ok(hr == S_OK, "Unexpected hr %#x.\n", hr); + + get_output_aperture(mixer, &frame_size, &aperture); +todo_wine { + ok(frame_size.cx == 199 && frame_size.cy == 298, "Unexpected frame size %u x %u.\n", frame_size.cx, frame_size.cy); + ok(aperture.Area.cx == 199 && aperture.Area.cy == 298, "Unexpected size %u x %u.\n", aperture.Area.cx, aperture.Area.cy); +} + ok(!aperture.OffsetX.value && !aperture.OffsetX.fract && !aperture.OffsetY.value && !aperture.OffsetY.fract, + "Unexpected offset %u x %u.\n", aperture.OffsetX.value, aperture.OffsetY.value); + + hr = IMFVideoDisplayControl_SetAspectRatioMode(display_control, MFVideoARMode_None); + ok(hr == S_OK, "Unexpected hr %#x.\n", hr); + + get_output_aperture(mixer, &frame_size, &aperture); +todo_wine { + ok(frame_size.cx == 199 && frame_size.cy == 298, "Unexpected frame size %u x %u.\n", frame_size.cx, frame_size.cy); + ok(aperture.Area.cx == 199 && aperture.Area.cy == 298, "Unexpected size %u x %u.\n", aperture.Area.cx, aperture.Area.cy); +} + ok(!aperture.OffsetX.value && !aperture.OffsetX.fract && !aperture.OffsetY.value && !aperture.OffsetY.fract, + "Unexpected offset %u x %u.\n", aperture.OffsetX.value, aperture.OffsetY.value); + + IMFVideoDisplayControl_Release(display_control); + IMFVideoPresenter_Release(presenter); + IMFTransform_Release(mixer); + +done: + IDirect3D9_Release(d3d); + DestroyWindow(window); +} + static void test_mixer_output_rectangle(void) { IMFVideoMixerControl *mixer_control; @@ -2574,6 +2705,7 @@ START_TEST(evr) test_presenter_ar_mode(); test_presenter_video_window(); test_presenter_quality_control(); + test_presenter_media_type(); test_mixer_output_rectangle(); test_mixer_zorder(); test_mixer_samples();
1
0
0
0
Hans Leidekker : winebus.sys: Support setting SDL controller mapping through environment variable.
by Alexandre Julliard
24 Nov '20
24 Nov '20
Module: wine Branch: master Commit: 3a007a95e86b6a9795a6ab92a53a08acf58e4b2e URL:
https://source.winehq.org/git/wine.git/?a=commit;h=3a007a95e86b6a9795a6ab92…
Author: Hans Leidekker <hans(a)codeweavers.com> Date: Tue Nov 24 12:22:01 2020 +0100 winebus.sys: Support setting SDL controller mapping through environment variable. Wine-Bug:
https://bugs.winehq.org/show_bug.cgi?id=50154
Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winebus.sys/bus_sdl.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/dlls/winebus.sys/bus_sdl.c b/dlls/winebus.sys/bus_sdl.c index feac5acf950..19c6f23e071 100644 --- a/dlls/winebus.sys/bus_sdl.c +++ b/dlls/winebus.sys/bus_sdl.c @@ -1024,8 +1024,15 @@ static DWORD CALLBACK deviceloop_thread(void *args) { HKEY key; static const WCHAR szPath[] = {'m','a','p',0}; + const char *mapping; - if (!RegOpenKeyExW(driver_key, szPath, 0, KEY_QUERY_VALUE, &key)) + if ((mapping = getenv("SDL_GAMECONTROLLERCONFIG"))) + { + TRACE("Setting environment mapping %s\n", debugstr_a(mapping)); + if (pSDL_GameControllerAddMapping(mapping) < 0) + WARN("Failed to add environment mapping %s\n", pSDL_GetError()); + } + else if (!RegOpenKeyExW(driver_key, szPath, 0, KEY_QUERY_VALUE, &key)) { DWORD index = 0; CHAR *buffer = NULL; @@ -1054,8 +1061,9 @@ static DWORD CALLBACK deviceloop_thread(void *args) if (rc == STATUS_SUCCESS) { - TRACE("Setting mapping %s...\n",debugstr_an(buffer,29)); - pSDL_GameControllerAddMapping(buffer); + TRACE("Setting registry mapping %s\n", debugstr_a(buffer)); + if (pSDL_GameControllerAddMapping(buffer) < 0) + WARN("Failed to add registry mapping %s\n", pSDL_GetError()); index ++; } } while (rc == STATUS_SUCCESS);
1
0
0
0
Hans Leidekker : winebus.sys: Fix registry access rights for SDL controller mapping.
by Alexandre Julliard
24 Nov '20
24 Nov '20
Module: wine Branch: master Commit: 6ce03d93135247fce4e9b2319319c8e989fd3767 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=6ce03d93135247fce4e9b231…
Author: Hans Leidekker <hans(a)codeweavers.com> Date: Tue Nov 24 12:22:00 2020 +0100 winebus.sys: Fix registry access rights for SDL controller mapping. Wine-Bug:
https://bugs.winehq.org/show_bug.cgi?id=48545
Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winebus.sys/bus_sdl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/winebus.sys/bus_sdl.c b/dlls/winebus.sys/bus_sdl.c index 95d5b9f9d0d..feac5acf950 100644 --- a/dlls/winebus.sys/bus_sdl.c +++ b/dlls/winebus.sys/bus_sdl.c @@ -1025,7 +1025,7 @@ static DWORD CALLBACK deviceloop_thread(void *args) HKEY key; static const WCHAR szPath[] = {'m','a','p',0}; - if (!RegOpenKeyExW(driver_key, szPath, 0, KEY_ENUMERATE_SUB_KEYS, &key)) + if (!RegOpenKeyExW(driver_key, szPath, 0, KEY_QUERY_VALUE, &key)) { DWORD index = 0; CHAR *buffer = NULL;
1
0
0
0
Alexandre Julliard : include: Use proper dllimports for msvcrt functions.
by Alexandre Julliard
24 Nov '20
24 Nov '20
Module: wine Branch: master Commit: 579fc688af0c54fe6a49e3b56204c34c77dc6e9e URL:
https://source.winehq.org/git/wine.git/?a=commit;h=579fc688af0c54fe6a49e3b5…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Nov 24 18:50:06 2020 +0100 include: Use proper dllimports for msvcrt functions. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcp90/msvcp90.h | 2 - dlls/msvcrt/mathf.c | 13 +++ include/msvcrt/assert.h | 2 +- include/msvcrt/conio.h | 34 +++--- include/msvcrt/corecrt_wctype.h | 44 ++++---- include/msvcrt/corecrt_wdirect.h | 10 +- include/msvcrt/corecrt_wio.h | 32 +++--- include/msvcrt/corecrt_wprocess.h | 34 +++--- include/msvcrt/corecrt_wstdio.h | 70 ++++++------ include/msvcrt/corecrt_wstdlib.h | 78 +++++++------- include/msvcrt/corecrt_wtime.h | 16 +-- include/msvcrt/crtdbg.h | 16 +-- include/msvcrt/ctype.h | 48 ++++----- include/msvcrt/direct.h | 16 +-- include/msvcrt/dos.h | 2 +- include/msvcrt/eh.h | 6 +- include/msvcrt/errno.h | 2 +- include/msvcrt/float.h | 30 +++--- include/msvcrt/fpieee.h | 2 +- include/msvcrt/io.h | 86 +++++++-------- include/msvcrt/locale.h | 16 +-- include/msvcrt/malloc.h | 40 +++---- include/msvcrt/math.h | 208 ++++++++++++++++++------------------ include/msvcrt/mbctype.h | 32 +++--- include/msvcrt/mbstring.h | 160 ++++++++++++++-------------- include/msvcrt/memory.h | 16 +-- include/msvcrt/process.h | 62 +++++------ include/msvcrt/search.h | 8 +- include/msvcrt/setjmp.h | 8 +- include/msvcrt/signal.h | 6 +- include/msvcrt/stddef.h | 4 +- include/msvcrt/stdio.h | 156 +++++++++++++-------------- include/msvcrt/stdlib.h | 218 +++++++++++++++++++------------------- include/msvcrt/sys/stat.h | 26 ++--- include/msvcrt/sys/timeb.h | 4 +- include/msvcrt/sys/utime.h | 12 +-- include/msvcrt/time.h | 56 +++++----- include/msvcrt/wchar.h | 5 +- include/msvcrt/wctype.h | 34 +++--- 39 files changed, 812 insertions(+), 802 deletions(-) Diff:
https://source.winehq.org/git/wine.git/?a=commitdiff;h=579fc688af0c54fe6a49…
1
0
0
0
Alexandre Julliard : include: Use proper dllimports for kernel32 functions.
by Alexandre Julliard
24 Nov '20
24 Nov '20
Module: wine Branch: master Commit: 9dc2892785649b22272f68de42bbd55e72a64bf1 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=9dc2892785649b22272f68de…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Nov 24 18:41:13 2020 +0100 include: Use proper dllimports for kernel32 functions. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernelbase/Makefile.in | 1 + dlls/kernelbase/debug.c | 1 + dlls/kernelbase/locale.c | 1 + dlls/ntdll/Makefile.in | 2 +- dlls/ntdll/exception.c | 3 ++- dlls/winecrt0/delay_load.c | 11 ++++++----- include/winbase.h | 6 +++--- include/wine/winbase16.h | 2 ++ include/winnls.h | 4 +++- 9 files changed, 20 insertions(+), 11 deletions(-) diff --git a/dlls/kernelbase/Makefile.in b/dlls/kernelbase/Makefile.in index 14953246f24..971022139c5 100644 --- a/dlls/kernelbase/Makefile.in +++ b/dlls/kernelbase/Makefile.in @@ -1,3 +1,4 @@ +EXTRADEFS = -DWINBASEAPI= MODULE = kernelbase.dll IMPORTLIB = kernelbase IMPORTS = uuid ntdll winecrt0 diff --git a/dlls/kernelbase/debug.c b/dlls/kernelbase/debug.c index 0382ea9f95a..52d0f705267 100644 --- a/dlls/kernelbase/debug.c +++ b/dlls/kernelbase/debug.c @@ -314,6 +314,7 @@ void WINAPI DECLSPEC_HOTPATCH RaiseException( DWORD code, DWORD flags, DWORD cou RtlRaiseException( &record ); } +__ASM_STDCALL_IMPORT(RaiseException,16) /*********************************************************************** diff --git a/dlls/kernelbase/locale.c b/dlls/kernelbase/locale.c index 9cfb9f129ee..7218a159844 100644 --- a/dlls/kernelbase/locale.c +++ b/dlls/kernelbase/locale.c @@ -28,6 +28,7 @@ #include "ntstatus.h" #define WIN32_NO_STATUS +#define WINNORMALIZEAPI #include "windef.h" #include "winbase.h" #include "winreg.h" diff --git a/dlls/ntdll/Makefile.in b/dlls/ntdll/Makefile.in index 02eb5f1d871..b2f63d9f63a 100644 --- a/dlls/ntdll/Makefile.in +++ b/dlls/ntdll/Makefile.in @@ -1,4 +1,4 @@ -EXTRADEFS = -D_NTSYSTEM_ -D_ACRTIMP= +EXTRADEFS = -D_NTSYSTEM_ -D_ACRTIMP= -DWINBASEAPI= MODULE = ntdll.dll IMPORTLIB = ntdll IMPORTS = winecrt0 diff --git a/dlls/ntdll/exception.c b/dlls/ntdll/exception.c index a6b4b6a7baa..6b51be39be0 100644 --- a/dlls/ntdll/exception.c +++ b/dlls/ntdll/exception.c @@ -634,7 +634,7 @@ BOOL WINAPI IsBadStringPtrA( LPCSTR str, UINT_PTR max ) __ENDTRY return FALSE; } - +__ASM_STDCALL_IMPORT(IsBadStringPtrA,8) /************************************************************* * IsBadStringPtrW @@ -656,6 +656,7 @@ BOOL WINAPI IsBadStringPtrW( LPCWSTR str, UINT_PTR max ) __ENDTRY return FALSE; } +__ASM_STDCALL_IMPORT(IsBadStringPtrW,8) /********************************************************************** diff --git a/dlls/winecrt0/delay_load.c b/dlls/winecrt0/delay_load.c index 8c8a9cc836a..1778856aa56 100644 --- a/dlls/winecrt0/delay_load.c +++ b/dlls/winecrt0/delay_load.c @@ -23,16 +23,17 @@ #include "winbase.h" #include "delayloadhandler.h" -void *WINAPI ResolveDelayLoadedAPI( void* base, const IMAGE_DELAYLOAD_DESCRIPTOR* desc, - PDELAYLOAD_FAILURE_DLL_CALLBACK dllhook, - PDELAYLOAD_FAILURE_SYSTEM_ROUTINE syshook, - IMAGE_THUNK_DATA* addr, ULONG flags ); -void *WINAPI DelayLoadFailureHook( LPCSTR name, LPCSTR function ); +WINBASEAPI void *WINAPI DelayLoadFailureHook( LPCSTR name, LPCSTR function ); #ifdef _WIN32 extern IMAGE_DOS_HEADER __ImageBase; +WINBASEAPI void *WINAPI ResolveDelayLoadedAPI( void* base, const IMAGE_DELAYLOAD_DESCRIPTOR* desc, + PDELAYLOAD_FAILURE_DLL_CALLBACK dllhook, + PDELAYLOAD_FAILURE_SYSTEM_ROUTINE syshook, + IMAGE_THUNK_DATA* addr, ULONG flags ); + FARPROC WINAPI __delayLoadHelper2( const IMAGE_DELAYLOAD_DESCRIPTOR *descr, IMAGE_THUNK_DATA *addr ) { return ResolveDelayLoadedAPI( &__ImageBase, descr, NULL, DelayLoadFailureHook, addr, 0 ); diff --git a/include/winbase.h b/include/winbase.h index 82797efc2b0..dc8aa081be4 100644 --- a/include/winbase.h +++ b/include/winbase.h @@ -25,10 +25,12 @@ extern "C" { #endif +#ifndef WINBASEAPI #ifdef _KERNEL32_ #define WINBASEAPI #else -#define WINBASEAPI DECLSPEC_HIDDEN +#define WINBASEAPI DECLSPEC_IMPORT +#endif #endif #ifdef _ADVAPI32_ @@ -2473,8 +2475,6 @@ WINBASEAPI void WINAPI MakeCriticalSectionGlobal(CRITICAL_SECTION *lpCrit #define MakeProcInstance(proc,inst) (proc) WINADVAPI BOOL WINAPI MakeSelfRelativeSD(PSECURITY_DESCRIPTOR,PSECURITY_DESCRIPTOR,LPDWORD); WINADVAPI VOID WINAPI MapGenericMask(PDWORD,PGENERIC_MAPPING); -WINBASEAPI HMODULE WINAPI MapHModuleSL(WORD); -WINBASEAPI WORD WINAPI MapHModuleLS(HMODULE); WINBASEAPI BOOL WINAPI MapUserPhysicalPages(PVOID,ULONG_PTR,PULONG_PTR); WINBASEAPI LPVOID WINAPI MapViewOfFile(HANDLE,DWORD,DWORD,DWORD,SIZE_T); WINBASEAPI LPVOID WINAPI MapViewOfFileEx(HANDLE,DWORD,DWORD,DWORD,SIZE_T,LPVOID); diff --git a/include/wine/winbase16.h b/include/wine/winbase16.h index d4a5096ee11..5938ef19966 100644 --- a/include/wine/winbase16.h +++ b/include/wine/winbase16.h @@ -515,6 +515,8 @@ BOOL16 WINAPI LocalUnlock16(HLOCAL16); LPVOID WINAPI LockResource16(HGLOBAL16); HGLOBAL16 WINAPI LockSegment16(HGLOBAL16); FARPROC16 WINAPI MakeProcInstance16(FARPROC16,HANDLE16); +HMODULE WINAPI MapHModuleSL(WORD); +WORD WINAPI MapHModuleLS(HMODULE); HFILE16 WINAPI OpenFile16(LPCSTR,OFSTRUCT*,UINT16); DWORD WINAPI RegCloseKey16(HKEY); DWORD WINAPI RegCreateKey16(HKEY,LPCSTR,PHKEY); diff --git a/include/winnls.h b/include/winnls.h index 2964ae56853..e90b6f5a22f 100644 --- a/include/winnls.h +++ b/include/winnls.h @@ -24,11 +24,13 @@ extern "C" { #endif +#ifndef WINNORMALIZEAPI #ifndef _NORMALIZE_ -# define WINNORMALIZEAPI DECLSPEC_HIDDEN +# define WINNORMALIZEAPI DECLSPEC_IMPORT #else # define WINNORMALIZEAPI #endif +#endif /* Country codes */ #define CTRY_DEFAULT (0)
1
0
0
0
← Newer
1
...
18
19
20
21
22
23
24
...
86
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
Results per page:
10
25
50
100
200