wine-commits March 2020

wine-commits@winehq.org

1 participants
996 discussions

Alistair Leslie-Hughes : dmime: IDirectMusicGraph GetTool isn't a stub.
by Alexandre Julliard 17 Mar '20

17 Mar '20

Module: wine Branch: master Commit: 04fe670aa6d58d44dbb760f6aafd86b9aa02117a URL: https://source.winehq.org/git/wine.git/?a=commit;h=04fe670aa6d58d44dbb760f6… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Mon Mar 16 05:33:43 2020 +0000 dmime: IDirectMusicGraph GetTool isn't a stub. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dmime/graph.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/dmime/graph.c b/dlls/dmime/graph.c index eebebef4d1..85eef9c091 100644 --- a/dlls/dmime/graph.c +++ b/dlls/dmime/graph.c @@ -149,8 +149,8 @@ static HRESULT WINAPI DirectMusicGraph_GetTool(IDirectMusicGraph *iface, DWORD d IDirectMusicGraphImpl *This = impl_from_IDirectMusicGraph(iface); struct list* pEntry = NULL; LPDMUS_PRIVATE_GRAPH_TOOL pIt = NULL; - - FIXME("(%p, %d, %p): stub\n", This, dwIndex, ppTool); + + TRACE("(%p, %d, %p)\n", This, dwIndex, ppTool); LIST_FOR_EACH (pEntry, &This->Tools) {

1 0

Francois Gouget : testbot/LogUtils: Handle child process crashes.
by Alexandre Julliard 17 Mar '20

17 Mar '20

Module: tools Branch: master Commit: c0be1870cb2a80620939ae364049686fba924854 URL: https://source.winehq.org/git/tools.git/?a=commit;h=c0be1870cb2a80620939ae3… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Tue Mar 17 00:02:47 2020 +0100 testbot/LogUtils: Handle child process crashes. Make sure they are included in the failure count, highlighted as failures and sanitized before comparison for the new failures detection. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48651 Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/WineTestBot/LogUtils.pm | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/testbot/lib/WineTestBot/LogUtils.pm b/testbot/lib/WineTestBot/LogUtils.pm index 57229bc..99c30e0 100644 --- a/testbot/lib/WineTestBot/LogUtils.pm +++ b/testbot/lib/WineTestBot/LogUtils.pm @@ -327,7 +327,7 @@ sub GetReportLineCategory($) if ($Line =~ /: Test (?:failed|succeeded inside todo block): / or $Line =~ /Fatal: test .* does not exist/ or $Line =~ / done $258$/ or - $Line =~ /: unhandled exception [0-9a-fA-F]{8} at / or + $Line =~ /: unhandled exception [0-9a-fA-F]{8} (?:at|in) / or $Line =~ /^Unhandled exception: /) { return "error"; @@ -627,6 +627,13 @@ sub ParseWineTestReport($$$) _CheckUnit($LogInfo, $Cur, $Unit, "unhandled exception"); $Cur->{LineFailures}++; } + elsif (($Cur->{Unit} ne "" and + $Line =~ /($Cur->{UnitsRE}):\d+: unhandled exception [0-9a-fA-F]{8} in child process /) or + $Line =~ /^([_.a-z0-9]+):\d+: unhandled exception [0-9a-fA-F]{8} in child process /) + { + _CheckUnit($LogInfo, $Cur, $1, "child exception"); + $Cur->{LineFailures}++; + } elsif (($Cur->{Unit} ne "" and $Line =~ /([0-9a-f]+):($Cur->{Unit}): \d+ tests? executed $(\d+) marked as todo, (\d+) failures?$, (\d+) skipped\./) or $Line =~ /^([0-9a-f]+):([_a-z0-9]+): \d+ tests? executed $(\d+) marked as todo, (\d+) failures?$, (\d+) skipped\./) @@ -1054,6 +1061,8 @@ sub _GetLineKey($) or $Line =~ s/^(Unhandled exception: .* code) $0x[0-9a-fA-F]{8,16}$\.$/$1/ # or the process id in Wine's exc_filter() lines or $Line =~ s/^[0-9a-f]+:([_a-z0-9]+: unhandled exception [0-9a-fA-F]{8} at )[0-9a-fA-F]{8,16}$/$1/ + # or child process id + or $Line =~ s/^([_.a-z0-9]+:)\d+:( unhandled exception [0-9a-fA-F]{8} in child process )[0-9a-fA-F]{4}$/$1$2/ # The exact amount of data printed does not change the error or $Line =~ s/^([_.a-z0-9-]+:[_a-z0-9]* prints too much data )$\d+ bytes$$/$1/;

1 0

Francois Gouget : testbot/web: Remove the old job submit page.
by Alexandre Julliard 17 Mar '20

17 Mar '20

Module: tools Branch: master Commit: 7d763278df8dad54c1acd4e966e32ed4affefdac URL: https://source.winehq.org/git/tools.git/?a=commit;h=7d763278df8dad54c1acd4e… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Mar 16 23:57:00 2020 +0100 testbot/web: Remove the old job submit page. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/WineTestBot/CGI/PageBase.pm | 3 +- testbot/web/OldSubmit.pl | 1043 ------------------------------- 2 files changed, 1 insertion(+), 1045 deletions(-) Diff: https://source.winehq.org/git/tools.git/?a=commitdiff;h=7d763278df8dad54c1a…

1 0

Francois Gouget : testbot/PatchUtils: Detect when make_fir needs to be run.
by Alexandre Julliard 17 Mar '20

17 Mar '20

Module: tools Branch: master Commit: 53ac3623936a0f48554c162c8e1a2d4e81dca608 URL: https://source.winehq.org/git/tools.git/?a=commit;h=53ac3623936a0f48554c162… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Mar 16 23:55:21 2020 +0100 testbot/PatchUtils: Detect when make_fir needs to be run. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/Build/Utils.pm | 10 ++++++++++ testbot/lib/WineTestBot/PatchUtils.pm | 5 +++++ 2 files changed, 15 insertions(+) diff --git a/testbot/lib/Build/Utils.pm b/testbot/lib/Build/Utils.pm index 85df900..8a6982c 100644 --- a/testbot/lib/Build/Utils.pm +++ b/testbot/lib/Build/Utils.pm @@ -148,6 +148,16 @@ sub ApplyPatch($$) return undef; } } + if ($Impacts->{MakeFir}) + { + InfoMsg "\nRunning make_fir\n"; + system("cd '$DataDir/$Dir/dlls/dsound/' && set -x && ./make_fir"); + if ($? != 0) + { + LogMsg "make_fir failed\n"; + return undef; + } + } if ($Impacts->{MakeOpenGL}) { InfoMsg "\nRunning make_opengl\n"; diff --git a/testbot/lib/WineTestBot/PatchUtils.pm b/testbot/lib/WineTestBot/PatchUtils.pm index eaa9868..44b3f97 100644 --- a/testbot/lib/WineTestBot/PatchUtils.pm +++ b/testbot/lib/WineTestBot/PatchUtils.pm @@ -326,6 +326,11 @@ sub GetPatchImpacts($) $Impacts->{PatchedRoot} = $Impacts->{MakeRequests} = 1; $Impacts->{IsWinePatch} = 1; } + elsif ($Line =~ m=^--- \w+/dlls/dsound/make_fir$=) + { + $Impacts->{MakeFir} = 1; + $Impacts->{IsWinePatch} = 1; + } elsif ($Line =~ m=^--- \w+/(?:dlls/ntdll/make_errors|dlls/ntdll/error\.c|include/ntstatus\.h|include/winerror\.h)$=) { $Impacts->{MakeErrors} = 1;

1 0

Francois Gouget : testbot/build: Simplify the --no-rm handling.
by Alexandre Julliard 17 Mar '20

17 Mar '20

Module: tools Branch: master Commit: 443e63563411f8edd6caedf20ae7aab9213e2772 URL: https://source.winehq.org/git/tools.git/?a=commit;h=443e63563411f8edd6caedf… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Mar 16 23:55:03 2020 +0100 testbot/build: Simplify the --no-rm handling. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/bin/build/Reconfig.pl | 6 ++++-- testbot/bin/build/WineReconfig.pl | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/testbot/bin/build/Reconfig.pl b/testbot/bin/build/Reconfig.pl index f0ed128..62644e1 100755 --- a/testbot/bin/build/Reconfig.pl +++ b/testbot/bin/build/Reconfig.pl @@ -40,6 +40,8 @@ sub BEGIN $::BuildEnv = 1; } +use File::Path; + use Build::Utils; use WineTestBot::Config; use WineTestBot::Missions; @@ -53,13 +55,13 @@ sub BuildNative($) { my ($NoRm) = @_; + rmtree "$DataDir/wine-native" if (!$NoRm); mkdir "$DataDir/wine-native" if (!-d "$DataDir/wine-native"); # Rebuild from scratch to make sure cruft will not accumulate InfoMsg "\nRebuilding native tools\n"; my $CPUCount = GetCPUCount(); system("cd '$DataDir/wine-native' && set -x && ". - ($NoRm ? "" : "rm -rf * && ") . "time ../wine/configure --enable-win64 --without-x --without-freetype --disable-winetest && ". "time make -j$CPUCount __tooldeps__"); @@ -77,6 +79,7 @@ sub BuildCross($$$) my ($TaskMissions, $NoRm, $Build) = @_; return 1 if (!$TaskMissions->{Builds}->{$Build}); + rmtree "$DataDir/wine-$Build" if (!$NoRm); mkdir "$DataDir/wine-$Build" if (!-d "$DataDir/wine-$Build"); # Rebuild from scratch to make sure cruft will not accumulate @@ -84,7 +87,6 @@ sub BuildCross($$$) my $CPUCount = GetCPUCount(); my $Host = ($Build eq "exe64" ? "x86_64-w64-mingw32" : "i686-w64-mingw32"); system("cd '$DataDir/wine-$Build' && set -x && ". - ($NoRm ? "" : "rm -rf * && ") . "time ../wine/configure --host=$Host --with-wine-tools=../wine-native --without-x --without-freetype --disable-winetest && ". "time make -j$CPUCount buildtests"); if ($? != 0) diff --git a/testbot/bin/build/WineReconfig.pl b/testbot/bin/build/WineReconfig.pl index 835be46..ad0d429 100755 --- a/testbot/bin/build/WineReconfig.pl +++ b/testbot/bin/build/WineReconfig.pl @@ -54,6 +54,7 @@ sub BuildWine($$$$;$) my ($TaskMissions, $NoRm, $Build, $Extras, $WithWine) = @_; return 1 if (!$TaskMissions->{Builds}->{$Build}); + rmtree "$DataDir/wine-$Build" if (!$NoRm); mkdir "$DataDir/wine-$Build" if (!-d "$DataDir/wine-$Build"); # If $NoRm is not set, rebuild from scratch to make sure cruft will not @@ -62,7 +63,6 @@ sub BuildWine($$$$;$) my $CPUCount = GetCPUCount(); $Extras .= " --with-wine64='$WithWine'" if (defined $WithWine); system("cd '$DataDir/wine-$Build' && set -x && ". - ($NoRm ? "" : "rm -rf * && ") . "time ../wine/configure $Extras && ". "time make -j$CPUCount"); if ($? != 0)

1 0

Francois Gouget : testbot/WinePatchesMLSubmit: Add a semi-colon.
by Alexandre Julliard 17 Mar '20

17 Mar '20

Module: tools Branch: master Commit: 93e5c34f072c1061c413b1df6f4beb13149997e7 URL: https://source.winehq.org/git/tools.git/?a=commit;h=93e5c34f072c1061c413b1d… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Mar 16 23:54:20 2020 +0100 testbot/WinePatchesMLSubmit: Add a semi-colon. It's at the end of a block and thus optional but all other blocks have one. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/bin/WinePatchesMLSubmit.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testbot/bin/WinePatchesMLSubmit.pl b/testbot/bin/WinePatchesMLSubmit.pl index 4797e98..92c769f 100755 --- a/testbot/bin/WinePatchesMLSubmit.pl +++ b/testbot/bin/WinePatchesMLSubmit.pl @@ -65,7 +65,7 @@ if (defined $ErrMessage) { # The Engine will pick up the email later so return success anyway. # But still log the issue so it can be checked out. - LogMsg "$ErrMessage\n" + LogMsg "$ErrMessage\n"; } exit 0;

1 0

Jacek Caban : ucrtbase/tests: Use more functions directly.
by Alexandre Julliard 16 Mar '20

16 Mar '20

Module: wine Branch: master Commit: c2ee20c95bea55069d32cfa69a95ae3e4486a02b URL: https://source.winehq.org/git/wine.git/?a=commit;h=c2ee20c95bea55069d32cfa6… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Mar 16 21:12:57 2020 +0100 ucrtbase/tests: Use more functions directly. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ucrtbase/tests/misc.c | 122 ++++++++++++++++----------------------------- 1 file changed, 44 insertions(+), 78 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=c2ee20c95bea55069d32…

1 0

Jacek Caban : ucrtbase/tests: Build with -fno-builtin.
by Alexandre Julliard 16 Mar '20

16 Mar '20

Module: wine Branch: master Commit: f202beb7454e3c39de7a8271c4a2f05f21d3c8bd URL: https://source.winehq.org/git/wine.git/?a=commit;h=f202beb7454e3c39de7a8271… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Mar 16 21:12:32 2020 +0100 ucrtbase/tests: Build with -fno-builtin. Some of tested functions are handled as builtin compiler functions. We always want to test our actual implementation. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ucrtbase/tests/Makefile.in | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/ucrtbase/tests/Makefile.in b/dlls/ucrtbase/tests/Makefile.in index 126cafd66d..259880a7d9 100644 --- a/dlls/ucrtbase/tests/Makefile.in +++ b/dlls/ucrtbase/tests/Makefile.in @@ -1,5 +1,6 @@ TESTDLL = ucrtbase.dll IMPORTS = ucrtbase +EXTRADEFS = -fno-builtin C_SRCS = \ cpp.c \

1 0

Zebediah Figura : winegstreamer: Use the image size provided by GStreamer.
by Alexandre Julliard 16 Mar '20

16 Mar '20

Module: wine Branch: master Commit: 8575484f2192d5394903f3362601f4131bd7f25c URL: https://source.winehq.org/git/wine.git/?a=commit;h=8575484f2192d5394903f336… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Mon Mar 16 14:40:16 2020 -0500 winegstreamer: Use the image size provided by GStreamer. If the stride is not equal to the width, this calculation will be invalid. Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winegstreamer/gstdemux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/winegstreamer/gstdemux.c b/dlls/winegstreamer/gstdemux.c index a8b1098752..9d7f85b82d 100644 --- a/dlls/winegstreamer/gstdemux.c +++ b/dlls/winegstreamer/gstdemux.c @@ -243,7 +243,7 @@ static gboolean amt_from_gst_video_info(const GstVideoInfo *info, AM_MEDIA_TYPE } bih->biCompression = amt->subtype.Data1; } - bih->biSizeImage = width * height * bih->biBitCount / 8; + bih->biSizeImage = GST_VIDEO_INFO_SIZE(info); if ((vih->AvgTimePerFrame = (REFERENCE_TIME)MulDiv(10000000, GST_VIDEO_INFO_FPS_D(info), GST_VIDEO_INFO_FPS_N(info))) == -1) vih->AvgTimePerFrame = 0; /* zero division or integer overflow */

1 0

Zebediah Figura : winegstreamer: Use amt_from_gst_video_info() in gstdecoder_source_get_media_type().
by Alexandre Julliard 16 Mar '20

16 Mar '20

Module: wine Branch: master Commit: 1bb868e9c1ca5ffbe1d6070ec5275123f3dcd69e URL: https://source.winehq.org/git/wine.git/?a=commit;h=1bb868e9c1ca5ffbe1d6070e… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Mon Mar 16 14:40:15 2020 -0500 winegstreamer: Use amt_from_gst_video_info() in gstdecoder_source_get_media_type(). Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winegstreamer/gstdemux.c | 74 +++++++++++++++++++------------------------ 1 file changed, 33 insertions(+), 41 deletions(-) diff --git a/dlls/winegstreamer/gstdemux.c b/dlls/winegstreamer/gstdemux.c index 40301c0d63..a8b1098752 100644 --- a/dlls/winegstreamer/gstdemux.c +++ b/dlls/winegstreamer/gstdemux.c @@ -172,17 +172,14 @@ static gboolean amt_from_gst_caps_audio_raw(const GstCaps *caps, AM_MEDIA_TYPE * return TRUE; } -static gboolean amt_from_gst_caps_video_raw(const GstCaps *caps, AM_MEDIA_TYPE *amt) +static gboolean amt_from_gst_video_info(const GstVideoInfo *info, AM_MEDIA_TYPE *amt) { VIDEOINFOHEADER *vih; BITMAPINFOHEADER *bih; gint32 width, height; - GstVideoInfo vinfo; - if (!gst_video_info_from_caps (&vinfo, caps)) - return FALSE; - width = GST_VIDEO_INFO_WIDTH(&vinfo); - height = GST_VIDEO_INFO_HEIGHT(&vinfo); + width = GST_VIDEO_INFO_WIDTH(info); + height = GST_VIDEO_INFO_HEIGHT(info); vih = CoTaskMemAlloc(sizeof(*vih)); bih = &vih->bmiHeader; @@ -197,9 +194,9 @@ static gboolean amt_from_gst_caps_video_raw(const GstCaps *caps, AM_MEDIA_TYPE * ZeroMemory(vih, sizeof(*vih)); amt->majortype = MEDIATYPE_Video; - if (GST_VIDEO_INFO_IS_RGB(&vinfo)) + if (GST_VIDEO_INFO_IS_RGB(info)) { - switch (GST_VIDEO_INFO_FORMAT(&vinfo)) + switch (GST_VIDEO_INFO_FORMAT(info)) { case GST_VIDEO_FORMAT_BGRA: amt->subtype = MEDIASUBTYPE_ARGB32; @@ -222,14 +219,14 @@ static gboolean amt_from_gst_caps_video_raw(const GstCaps *caps, AM_MEDIA_TYPE * bih->biBitCount = 16; break; default: - FIXME("Unhandled type %s.\n", GST_VIDEO_INFO_NAME(&vinfo)); + FIXME("Unhandled type %s.\n", GST_VIDEO_INFO_NAME(info)); CoTaskMemFree(vih); return FALSE; } bih->biCompression = BI_RGB; } else { amt->subtype = MEDIATYPE_Video; - if (!(amt->subtype.Data1 = gst_video_format_to_fourcc(GST_VIDEO_INFO_FORMAT(&vinfo)))) + if (!(amt->subtype.Data1 = gst_video_format_to_fourcc(GST_VIDEO_INFO_FORMAT(info)))) { CoTaskMemFree(vih); return FALSE; @@ -248,7 +245,7 @@ static gboolean amt_from_gst_caps_video_raw(const GstCaps *caps, AM_MEDIA_TYPE * } bih->biSizeImage = width * height * bih->biBitCount / 8; if ((vih->AvgTimePerFrame = (REFERENCE_TIME)MulDiv(10000000, - GST_VIDEO_INFO_FPS_D(&vinfo), GST_VIDEO_INFO_FPS_N(&vinfo))) == -1) + GST_VIDEO_INFO_FPS_D(info), GST_VIDEO_INFO_FPS_N(info))) == -1) vih->AvgTimePerFrame = 0; /* zero division or integer overflow */ bih->biSize = sizeof(*bih); bih->biWidth = width; @@ -331,7 +328,13 @@ static gboolean amt_from_gst_caps(const GstCaps *caps, AM_MEDIA_TYPE *mt) if (!strcmp(type, "audio/x-raw")) return amt_from_gst_caps_audio_raw(caps, mt); else if (!strcmp(type, "video/x-raw")) - return amt_from_gst_caps_video_raw(caps, mt); + { + GstVideoInfo info; + + if (!gst_video_info_from_caps(&info, caps)) + return FALSE; + return amt_from_gst_video_info(&info, mt); + } else if (!strcmp(type, "audio/mpeg")) return amt_from_gst_caps_audio_mpeg(caps, mt); else if (!strcmp(type, "video/x-cinepak")) @@ -1649,26 +1652,19 @@ static HRESULT gstdecoder_source_query_accept(struct gstdemux_source *pin, const static HRESULT gstdecoder_source_get_media_type(struct gstdemux_source *pin, unsigned int index, AM_MEDIA_TYPE *mt) { - static const struct - { - const GUID *subtype; - WORD bpp; - DWORD compression; - } - video_types[] = + static const GstVideoFormat video_formats[] = { /* Roughly ordered by preference from videoflip. */ - {&MEDIASUBTYPE_AYUV, 32, mmioFOURCC('A','Y','U','V')}, - {&MEDIASUBTYPE_ARGB32, 32, BI_RGB}, - {&MEDIASUBTYPE_RGB32, 32, BI_RGB}, - {&MEDIASUBTYPE_RGB24, 24, BI_RGB}, - {&MEDIASUBTYPE_I420, 12, mmioFOURCC('I','4','2','0')}, - {&MEDIASUBTYPE_YV12, 12, mmioFOURCC('Y','V','1','2')}, - {&MEDIASUBTYPE_IYUV, 12, mmioFOURCC('I','Y','U','V')}, - {&MEDIASUBTYPE_YUY2, 16, mmioFOURCC('Y','U','Y','2')}, - {&MEDIASUBTYPE_UYVY, 16, mmioFOURCC('U','Y','V','Y')}, - {&MEDIASUBTYPE_YVYU, 16, mmioFOURCC('Y','V','Y','U')}, - {&MEDIASUBTYPE_NV12, 12, mmioFOURCC('N','V','1','2')}, + GST_VIDEO_FORMAT_AYUV, + GST_VIDEO_FORMAT_BGRA, + GST_VIDEO_FORMAT_BGRx, + GST_VIDEO_FORMAT_BGR, + GST_VIDEO_FORMAT_I420, + GST_VIDEO_FORMAT_YV12, + GST_VIDEO_FORMAT_YUY2, + GST_VIDEO_FORMAT_UYVY, + GST_VIDEO_FORMAT_YVYU, + GST_VIDEO_FORMAT_NV12, }; if (!index) @@ -1677,19 +1673,15 @@ static HRESULT gstdecoder_source_get_media_type(struct gstdemux_source *pin, return S_OK; } else if (IsEqualGUID(&pin->mt.majortype, &MEDIATYPE_Video) - && index - 1 < ARRAY_SIZE(video_types)) + && index - 1 < ARRAY_SIZE(video_formats)) { - VIDEOINFOHEADER *vih; + const VIDEOINFOHEADER *vih = (VIDEOINFOHEADER *)pin->mt.pbFormat; + GstVideoInfo info; - *mt = pin->mt; - mt->subtype = *video_types[index - 1].subtype; - mt->pbFormat = CoTaskMemAlloc(pin->mt.cbFormat); - memcpy(mt->pbFormat, pin->mt.pbFormat, pin->mt.cbFormat); - vih = (VIDEOINFOHEADER *)mt->pbFormat; - vih->bmiHeader.biBitCount = video_types[index - 1].bpp; - vih->bmiHeader.biCompression = video_types[index - 1].compression; - vih->bmiHeader.biSizeImage = vih->bmiHeader.biWidth - * vih->bmiHeader.biHeight * vih->bmiHeader.biBitCount / 8; + gst_video_info_set_format(&info, video_formats[index - 1], + vih->bmiHeader.biWidth, vih->bmiHeader.biHeight); + if (!amt_from_gst_video_info(&info, mt)) + return E_OUTOFMEMORY; return S_OK; } else if (IsEqualGUID(&pin->mt.majortype, &MEDIATYPE_Audio) && index == 1)

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits March 2020