winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
July 2020
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
1 participants
826 discussions
Start a n
N
ew thread
Matteo Bruni : include: Flesh out d3dx10math.h a bit more.
by Alexandre Julliard
24 Jul '20
24 Jul '20
Module: wine Branch: master Commit: e48fccf76c4f821958494c1601f1c090f2fdba4c URL:
https://source.winehq.org/git/wine.git/?a=commit;h=e48fccf76c4f821958494c16…
Author: Matteo Bruni <mbruni(a)codeweavers.com> Date: Fri Jul 24 11:14:07 2020 +0200 include: Flesh out d3dx10math.h a bit more. Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/d3dx10math.h | 55 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+) diff --git a/include/d3dx10math.h b/include/d3dx10math.h index a96784b108..c8bcfd2ce4 100644 --- a/include/d3dx10math.h +++ b/include/d3dx10math.h @@ -32,10 +32,65 @@ typedef enum _D3DX_CPU_OPTIMIZATION D3DX_SSE_OPTIMIZED } D3DX_CPU_OPTIMIZATION; +typedef struct D3DXFLOAT16 +{ +#ifdef __cplusplus + D3DXFLOAT16(); + D3DXFLOAT16(float f); + D3DXFLOAT16(const D3DXFLOAT16 &f); + + operator float(); + + BOOL operator==(const D3DXFLOAT16 &f) const; + BOOL operator!=(const D3DXFLOAT16 &f) const; +#endif + WORD value; +} D3DXFLOAT16, *LPD3DXFLOAT16; + +typedef struct D3DXCOLOR +{ +#ifdef __cplusplus +public: + D3DXCOLOR(){}; + D3DXCOLOR(UINT color); + D3DXCOLOR(const float *color); + D3DXCOLOR(const D3DXFLOAT16 *color); + D3DXCOLOR(float r, float g, float b, float a); + + operator UINT() const; + operator float *(); + operator const float *() const; + + D3DXCOLOR & operator+=(const D3DXCOLOR &color); + D3DXCOLOR & operator-=(const D3DXCOLOR &color); + D3DXCOLOR & operator*=(float n); + D3DXCOLOR & operator/=(float n); + + D3DXCOLOR operator+() const; + D3DXCOLOR operator-() const; + + D3DXCOLOR operator+(const D3DXCOLOR &color) const; + D3DXCOLOR operator-(const D3DXCOLOR &color) const; + D3DXCOLOR operator*(float n) const; + D3DXCOLOR operator/(float n) const; + + friend D3DXCOLOR operator*(float n, const D3DXCOLOR &color); + + BOOL operator==(const D3DXCOLOR &color) const; + BOOL operator!=(const D3DXCOLOR &color) const; +#endif + float r, g, b, a; +} D3DXCOLOR, *LPD3DXCOLOR; + #ifdef __cplusplus extern "C" { #endif +D3DXCOLOR *D3DXColorAdd(D3DXCOLOR *out, D3DXCOLOR c1, D3DXCOLOR c2); +D3DXCOLOR *D3DXColorLerp(D3DXCOLOR *out, D3DXCOLOR c1, D3DXCOLOR c2, float s); +D3DXCOLOR *D3DXColorModulate(D3DXCOLOR *out, D3DXCOLOR c1, D3DXCOLOR c2); +D3DXCOLOR *D3DXColorScale(D3DXCOLOR *out, D3DXCOLOR c, float s); +D3DXCOLOR *D3DXColorSubtract(D3DXCOLOR *out, D3DXCOLOR c1, D3DXCOLOR c2); D3DX_CPU_OPTIMIZATION WINAPI D3DXCpuOptimizations(BOOL enable); #ifdef __cplusplus
1
0
0
0
Matteo Bruni : include: Add ID3D10Device1 forward declaration.
by Alexandre Julliard
24 Jul '20
24 Jul '20
Module: wine Branch: master Commit: 7af62f176d077045993c48a82ad2ce511da762dd URL:
https://source.winehq.org/git/wine.git/?a=commit;h=7af62f176d077045993c48a8…
Author: Matteo Bruni <mbruni(a)codeweavers.com> Date: Fri Jul 24 11:14:06 2020 +0200 include: Add ID3D10Device1 forward declaration. Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/d3dx10core.idl | 1 + 1 file changed, 1 insertion(+) diff --git a/include/d3dx10core.idl b/include/d3dx10core.idl index c99ab82eb7..88f13d0765 100644 --- a/include/d3dx10core.idl +++ b/include/d3dx10core.idl @@ -71,4 +71,5 @@ cpp_quote(" HMODULE swrast, unsigned int flags, ID3D10Device **device);") cpp_quote("HRESULT WINAPI D3DX10CreateDeviceAndSwapChain(IDXGIAdapter *adapter, D3D10_DRIVER_TYPE driver_type,") cpp_quote(" HMODULE swrast, unsigned int flags, DXGI_SWAP_CHAIN_DESC *desc, IDXGISwapChain **swapchain,") cpp_quote(" ID3D10Device **device);") +interface ID3D10Device1; cpp_quote("HRESULT WINAPI D3DX10GetFeatureLevel1(ID3D10Device *device, ID3D10Device1 **device1);")
1
0
0
0
Matteo Bruni : ntdll: Don't read current CPU frequency on Linux.
by Alexandre Julliard
24 Jul '20
24 Jul '20
Module: wine Branch: master Commit: b37371bf20be58ee7bd0b63dbac15b474873bc86 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=b37371bf20be58ee7bd0b63d…
Author: Matteo Bruni <mbruni(a)codeweavers.com> Date: Fri Jul 24 11:14:05 2020 +0200 ntdll: Don't read current CPU frequency on Linux. On the Linux boxes I tested, reading scaling_cur_freq usually takes about 12 ms per core. Wine-Bug:
https://bugs.winehq.org/show_bug.cgi?id=47128
Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/unix/system.c | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/dlls/ntdll/unix/system.c b/dlls/ntdll/unix/system.c index 681d56a869..3756bd7cee 100644 --- a/dlls/ntdll/unix/system.c +++ b/dlls/ntdll/unix/system.c @@ -2907,11 +2907,12 @@ NTSTATUS WINAPI NtPowerInformation( POWER_INFORMATION_LEVEL level, void *input, FILE* f; for(i = 0; i < out_cpus; i++) { - sprintf(filename, "/sys/devices/system/cpu/cpu%d/cpufreq/scaling_cur_freq", i); + sprintf(filename, "/sys/devices/system/cpu/cpu%d/cpufreq/cpuinfo_max_freq", i); f = fopen(filename, "r"); - if (f && (fscanf(f, "%d", &cpu_power[i].CurrentMhz) == 1)) { - cpu_power[i].CurrentMhz /= 1000; + if (f && (fscanf(f, "%d", &cpu_power[i].MaxMhz) == 1)) { + cpu_power[i].MaxMhz /= 1000; fclose(f); + cpu_power[i].CurrentMhz = cpu_power[i].MaxMhz; } else { if(i == 0) { @@ -2921,16 +2922,6 @@ NTSTATUS WINAPI NtPowerInformation( POWER_INFORMATION_LEVEL level, void *input, } else cpu_power[i].CurrentMhz = cpu_power[0].CurrentMhz; - if(f) fclose(f); - } - - sprintf(filename, "/sys/devices/system/cpu/cpu%d/cpufreq/cpuinfo_max_freq", i); - f = fopen(filename, "r"); - if (f && (fscanf(f, "%d", &cpu_power[i].MaxMhz) == 1)) { - cpu_power[i].MaxMhz /= 1000; - fclose(f); - } - else { cpu_power[i].MaxMhz = cpu_power[i].CurrentMhz; if(f) fclose(f); }
1
0
0
0
Alexandre Julliard : ntdll: Store the filesystem redirection flag in the 64-bit TEB.
by Alexandre Julliard
24 Jul '20
24 Jul '20
Module: wine Branch: master Commit: d18b5669952bf1639be78fd699310231d4de0259 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=d18b5669952bf1639be78fd6…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Jul 24 13:29:31 2020 +0200 ntdll: Store the filesystem redirection flag in the 64-bit TEB. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/directory.c | 18 +++++++++++++----- dlls/ntdll/ntdll_misc.h | 19 ------------------- dlls/ntdll/signal_i386.c | 5 ++--- dlls/ntdll/tests/directory.c | 20 ++++++++++++++++++++ dlls/ntdll/unix/file.c | 9 +++++---- dlls/ntdll/unix/process.c | 4 +++- dlls/ntdll/unix/server.c | 2 -- dlls/ntdll/unix/unix_private.h | 5 ++++- include/winternl.h | 3 +++ 9 files changed, 50 insertions(+), 35 deletions(-) Diff:
https://source.winehq.org/git/wine.git/?a=commitdiff;h=d18b5669952bf1639be7…
1
0
0
0
Alexandre Julliard : ntdll: Allocate 64-bit TEB and PEB in WoW64 mode.
by Alexandre Julliard
24 Jul '20
24 Jul '20
Module: wine Branch: master Commit: a865a4f61d413d85d6ae4e57d3c14c0657d3a598 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=a865a4f61d413d85d6ae4e57…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Jul 24 11:24:31 2020 +0200 ntdll: Allocate 64-bit TEB and PEB in WoW64 mode. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/loader.c | 19 +++++++++-- dlls/ntdll/ntdll_misc.h | 4 +++ dlls/ntdll/tests/info.c | 42 +++++++++++++++++++++++ dlls/ntdll/unix/server.c | 14 +++++++- dlls/ntdll/unix/signal_i386.c | 6 ++-- dlls/ntdll/unix/unix_private.h | 17 +++++++--- dlls/ntdll/unix/virtual.c | 75 +++++++++++++++++++++++------------------- 7 files changed, 131 insertions(+), 46 deletions(-) Diff:
https://source.winehq.org/git/wine.git/?a=commitdiff;h=a865a4f61d413d85d6ae…
1
0
0
0
Alexandre Julliard : ntdll: Store the thread startup info in the ntdll_thread_data structure.
by Alexandre Julliard
24 Jul '20
24 Jul '20
Module: wine Branch: master Commit: e3b059b5bad4b7ff23459a6384c866e3da1bdee1 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=e3b059b5bad4b7ff23459a63…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Jul 24 11:15:42 2020 +0200 ntdll: Store the thread startup info in the ntdll_thread_data structure. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/unix/thread.c | 19 ++++--------------- dlls/ntdll/unix/unix_private.h | 2 ++ 2 files changed, 6 insertions(+), 15 deletions(-) diff --git a/dlls/ntdll/unix/thread.c b/dlls/ntdll/unix/thread.c index 8ade2d9c78..b2b97e1c57 100644 --- a/dlls/ntdll/unix/thread.c +++ b/dlls/ntdll/unix/thread.c @@ -83,13 +83,6 @@ static void pthread_exit_wrapper( int status ) } -/* info passed to a starting thread */ -struct startup_info -{ - PRTL_THREAD_START_ROUTINE entry; - void *arg; -}; - /*********************************************************************** * start_thread * @@ -97,7 +90,6 @@ struct startup_info */ static void start_thread( TEB *teb ) { - struct startup_info *info = (struct startup_info *)(teb + 1); struct ntdll_thread_data *thread_data = (struct ntdll_thread_data *)&teb->GdiTebBatch; struct debug_info debug_info; BOOL suspend; @@ -106,8 +98,8 @@ static void start_thread( TEB *teb ) thread_data->debug_info = &debug_info; thread_data->pthread_id = pthread_self(); signal_init_thread( teb ); - server_init_thread( info->entry, &suspend ); - signal_start_thread( info->entry, info->arg, suspend, pRtlUserThreadStart, teb ); + server_init_thread( thread_data->start, &suspend ); + signal_start_thread( thread_data->start, thread_data->param, suspend, pRtlUserThreadStart, teb ); } @@ -152,7 +144,6 @@ NTSTATUS WINAPI NtCreateThreadEx( HANDLE *handle, ACCESS_MASK access, OBJECT_ATT data_size_t len; struct object_attributes *objattr; struct ntdll_thread_data *thread_data; - struct startup_info *info; DWORD tid = 0; int request_pipe[2]; SIZE_T extra_stack = PTHREAD_STACK_MIN; @@ -236,10 +227,6 @@ NTSTATUS WINAPI NtCreateThreadEx( HANDLE *handle, ACCESS_MASK access, OBJECT_ATT client_id.UniqueThread = ULongToHandle( tid ); teb->ClientId = client_id; - info = (struct startup_info *)(teb + 1); - info->entry = start; - info->arg = param; - teb->Tib.StackBase = stack.StackBase; teb->Tib.StackLimit = stack.StackLimit; teb->DeallocationStack = stack.DeallocationStack; @@ -247,6 +234,8 @@ NTSTATUS WINAPI NtCreateThreadEx( HANDLE *handle, ACCESS_MASK access, OBJECT_ATT thread_data = (struct ntdll_thread_data *)&teb->GdiTebBatch; thread_data->request_fd = request_pipe[1]; thread_data->start_stack = (char *)teb->Tib.StackBase; + thread_data->start = start; + thread_data->param = param; pthread_attr_init( &pthread_attr ); pthread_attr_setstack( &pthread_attr, teb->DeallocationStack, diff --git a/dlls/ntdll/unix/unix_private.h b/dlls/ntdll/unix/unix_private.h index 0ecc2456ba..af2ad40144 100644 --- a/dlls/ntdll/unix/unix_private.h +++ b/dlls/ntdll/unix/unix_private.h @@ -60,6 +60,8 @@ struct ntdll_thread_data BOOL wow64_redir; /* Wow64 filesystem redirection flag */ pthread_t pthread_id; /* pthread thread id */ struct list entry; /* entry in TEB list */ + PRTL_THREAD_START_ROUTINE start; /* thread entry point */ + void *param; /* thread entry point parameter */ }; C_ASSERT( sizeof(struct ntdll_thread_data) <= sizeof(((TEB *)0)->GdiTebBatch) );
1
0
0
0
Alexandre Julliard : include: Add 64-bit versions of the TEB and PEB for WoW64 mode.
by Alexandre Julliard
24 Jul '20
24 Jul '20
Module: wine Branch: master Commit: 0e3f8c54c1178edde7baa1889b474bfcdd81ea64 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=0e3f8c54c1178edde7baa188…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Jul 24 10:30:59 2020 +0200 include: Add 64-bit versions of the TEB and PEB for WoW64 mode. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/winternl.h | 224 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 224 insertions(+) Diff:
https://source.winehq.org/git/wine.git/?a=commitdiff;h=0e3f8c54c1178edde7ba…
1
0
0
0
Zebediah Figura : quartz/vmr9: Allow AdviseSurfaceAllocator() to be called multiple times.
by Alexandre Julliard
24 Jul '20
24 Jul '20
Module: wine Branch: master Commit: 1ce2cae3e931a027aa0aee01ddd11bcbff6433c6 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=1ce2cae3e931a027aa0aee01…
Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Thu Jul 23 19:30:16 2020 -0500 quartz/vmr9: Allow AdviseSurfaceAllocator() to be called multiple times. Wine-Bug:
https://bugs.winehq.org/show_bug.cgi?id=47161
Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/quartz/tests/vmr9.c | 132 ++++++++++++++++++++++++++++++++--------------- dlls/quartz/vmr9.c | 21 +++++++- 2 files changed, 109 insertions(+), 44 deletions(-) Diff:
https://source.winehq.org/git/wine.git/?a=commitdiff;h=1ce2cae3e931a027aa0a…
1
0
0
0
Zebediah Figura : quartz: Don't pause the graph in IMediaSeeking::SetPositions if it hasn't finished running yet.
by Alexandre Julliard
24 Jul '20
24 Jul '20
Module: wine Branch: master Commit: 41a9f828704c64548e7cfc3c34804e5019d7202e URL:
https://source.winehq.org/git/wine.git/?a=commit;h=41a9f828704c64548e7cfc3c…
Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Thu Jul 23 19:29:24 2020 -0500 quartz: Don't pause the graph in IMediaSeeking::SetPositions if it hasn't finished running yet. Wine-Bug:
https://bugs.winehq.org/show_bug.cgi?id=49604
Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/quartz/filtergraph.c | 4 ++-- dlls/quartz/tests/filtergraph.c | 13 ++++++++++++- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/dlls/quartz/filtergraph.c b/dlls/quartz/filtergraph.c index b691fd79fc..2c32b3bc43 100644 --- a/dlls/quartz/filtergraph.c +++ b/dlls/quartz/filtergraph.c @@ -2398,7 +2398,7 @@ static HRESULT WINAPI MediaSeeking_SetPositions(IMediaSeeking *iface, LONGLONG * EnterCriticalSection(&graph->cs); state = graph->state; - if (state == State_Running) + if (state == State_Running && !graph->needs_async_run) IMediaControl_Pause(&graph->IMediaControl_iface); LIST_FOR_EACH_ENTRY(filter, &graph->filters, struct filter, entry) @@ -2434,7 +2434,7 @@ static HRESULT WINAPI MediaSeeking_SetPositions(IMediaSeeking *iface, LONGLONG * graph->stream_elapsed = 0; } - if (state == State_Running) + if (state == State_Running && !graph->needs_async_run) IMediaControl_Run(&graph->IMediaControl_iface); LeaveCriticalSection(&graph->cs); diff --git a/dlls/quartz/tests/filtergraph.c b/dlls/quartz/tests/filtergraph.c index 4fcd27b291..cf641a4306 100644 --- a/dlls/quartz/tests/filtergraph.c +++ b/dlls/quartz/tests/filtergraph.c @@ -3205,9 +3205,10 @@ static void test_filter_state(void) struct testpin source_pin, sink_pin; IFilterGraph2 *graph = create_graph(); - REFERENCE_TIME start_time; + REFERENCE_TIME start_time, time; IReferenceClock *clock; IMediaControl *control; + IMediaSeeking *seeking; FILTER_STATE mf_state; IMediaFilter *filter; OAFilterState state; @@ -3219,6 +3220,7 @@ static void test_filter_state(void) testfilter_init(&source, &source_pin, 1); testfilter_init(&sink, &sink_pin, 1); testfilter_init(&dummy, NULL, 0); + sink.IMediaSeeking_iface.lpVtbl = &testseek_vtbl; IFilterGraph2_QueryInterface(graph, &IID_IMediaFilter, (void **)&filter); IFilterGraph2_QueryInterface(graph, &IID_IMediaControl, (void **)&control); @@ -3350,6 +3352,7 @@ static void test_filter_state(void) graph = create_graph(); IFilterGraph2_QueryInterface(graph, &IID_IMediaFilter, (void **)&filter); IFilterGraph2_QueryInterface(graph, &IID_IMediaControl, (void **)&control); + IFilterGraph2_QueryInterface(graph, &IID_IMediaSeeking, (void **)&seeking); /* Add the filters in reverse order this time. */ IFilterGraph2_AddFilter(graph, &sink.IBaseFilter_iface, NULL); @@ -3511,6 +3514,13 @@ todo_wine ok(sink.state == State_Paused, "Got state %u.\n", sink.state); ok(source.state == State_Paused, "Got state %u.\n", source.state); + /* SetPositions() does not pause the graph in this case, since it is + * already in a paused state. */ + time = 0; + hr = IMediaSeeking_SetPositions(seeking, &time, AM_SEEKING_AbsolutePositioning, + NULL, AM_SEEKING_NoPositioning); + ok(hr == S_OK, "Got hr %#x.\n", hr); + hr = IMediaControl_Run(control); todo_wine ok(hr == S_FALSE, "Got hr %#x.\n", hr); @@ -3684,6 +3694,7 @@ todo_wine source.expect_stop_prev = sink.expect_stop_prev = State_Running; IMediaFilter_Release(filter); IMediaControl_Release(control); + IMediaSeeking_Release(seeking); ref = IFilterGraph2_Release(graph); ok(!ref, "Got outstanding refcount %d.\n", ref); ok(source.ref == 1, "Got outstanding refcount %d.\n", source.ref);
1
0
0
0
Zebediah Figura : quartz/dsoundrender: Clear the DirectSound buffer on EOS.
by Alexandre Julliard
24 Jul '20
24 Jul '20
Module: wine Branch: master Commit: 79129db1cdcb3117bc24f02c5d4a219bb9e28e0f URL:
https://source.winehq.org/git/wine.git/?a=commit;h=79129db1cdcb3117bc24f02c…
Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Thu Jul 23 19:29:23 2020 -0500 quartz/dsoundrender: Clear the DirectSound buffer on EOS. "Zero Escape: Nine Hours, Nine Persons, Nine Doors" does not stop or destroy the graph after it is finished running, so the last second of audio repeats otherwise. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/quartz/dsoundrender.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/dlls/quartz/dsoundrender.c b/dlls/quartz/dsoundrender.c index a3155477fd..8b914751e1 100644 --- a/dlls/quartz/dsoundrender.c +++ b/dlls/quartz/dsoundrender.c @@ -477,6 +477,8 @@ static HRESULT dsound_render_sink_eos(struct strmbase_sink *iface) struct dsound_render *filter = impl_from_strmbase_pin(&iface->pin); IFilterGraph *graph = filter->filter.graph; IMediaEventSink *event_sink; + void *buffer; + DWORD size; EnterCriticalSection(&filter->stream_cs); @@ -494,6 +496,10 @@ static HRESULT dsound_render_sink_eos(struct strmbase_sink *iface) DSoundRender_HandleEndOfStream(filter); + IDirectSoundBuffer_Lock(filter->dsbuffer, 0, 0, &buffer, &size, NULL, NULL, DSBLOCK_ENTIREBUFFER); + memset(buffer, 0, size); + IDirectSoundBuffer_Unlock(filter->dsbuffer, buffer, size, NULL, 0); + LeaveCriticalSection(&filter->stream_cs); return S_OK; }
1
0
0
0
← Newer
1
...
10
11
12
13
14
15
16
...
83
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
Results per page:
10
25
50
100
200