winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
October 2021
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
1165 discussions
Start a n
N
ew thread
Hans Leidekker : winhttp: Use ws.ifelse.io for websocket tests.
by Alexandre Julliard
26 Oct '21
26 Oct '21
Module: wine Branch: stable Commit: 2ed9701ab95c455efe1d3483b45e23ef03383f44 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=2ed9701ab95c455efe1d3483…
Author: Hans Leidekker <hans(a)codeweavers.com> Date: Wed Sep 22 12:44:14 2021 +0200 winhttp: Use ws.ifelse.io for websocket tests. Wine-Bug:
https://bugs.winehq.org/show_bug.cgi?id=51631
Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> (cherry picked from commit 9f6e39e8b945466180080d470e1272ba4f807b3a) Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> --- dlls/winhttp/tests/notification.c | 16 ++++++++++++++-- dlls/winhttp/tests/winhttp.c | 19 ++++++++++++++----- 2 files changed, 28 insertions(+), 7 deletions(-) diff --git a/dlls/winhttp/tests/notification.c b/dlls/winhttp/tests/notification.c index 98e4024867f..e567ed758ee 100644 --- a/dlls/winhttp/tests/notification.c +++ b/dlls/winhttp/tests/notification.c @@ -644,6 +644,7 @@ static const struct notification websocket_test[] = { winhttp_websocket_complete_upgrade, WINHTTP_CALLBACK_STATUS_HANDLE_CREATED, NF_SIGNAL }, { winhttp_websocket_send, WINHTTP_CALLBACK_STATUS_WRITE_COMPLETE, NF_SIGNAL }, { winhttp_websocket_receive, WINHTTP_CALLBACK_STATUS_READ_COMPLETE, NF_SIGNAL }, + { winhttp_websocket_receive, WINHTTP_CALLBACK_STATUS_READ_COMPLETE, NF_SIGNAL }, { winhttp_websocket_shutdown, WINHTTP_CALLBACK_STATUS_SHUTDOWN_COMPLETE, NF_SIGNAL }, { winhttp_websocket_close, WINHTTP_CALLBACK_STATUS_CLOSE_COMPLETE, NF_SIGNAL }, { winhttp_close_handle, WINHTTP_CALLBACK_STATUS_HANDLE_CLOSING }, @@ -699,7 +700,7 @@ static void test_websocket(void) setup_test( &info, winhttp_connect, __LINE__ ); SetLastError( 0xdeadbeef ); - connection = WinHttpConnect( session, L"
echo.websocket.org
", 0, 0 ); + connection = WinHttpConnect( session, L"ws.ifelse.io", 0, 0 ); err = GetLastError(); ok( connection != NULL, "got %u\n", err); ok( err == ERROR_SUCCESS || broken(err == WSAEINVAL) /* < win7 */, "got %u\n", err ); @@ -769,7 +770,18 @@ static void test_websocket(void) WaitForSingleObject( info.wait, INFINITE ); ok( size == 0xdeadbeef, "got %u\n", size ); ok( type == 0xdeadbeef, "got %u\n", type ); - ok( buffer[0], "unexpected data\n" ); + ok( buffer[0] == 'R', "unexpected data\n" ); + + setup_test( &info, winhttp_websocket_receive, __LINE__ ); + buffer[0] = 0; + size = 0xdeadbeef; + type = 0xdeadbeef; + err = pWinHttpWebSocketReceive( socket, buffer, sizeof(buffer), &size, &type ); + ok( err == ERROR_SUCCESS, "got %u\n", err ); + WaitForSingleObject( info.wait, INFINITE ); + ok( size == 0xdeadbeef, "got %u\n", size ); + ok( type == 0xdeadbeef, "got %u\n", type ); + ok( buffer[0] == 'h', "unexpected data\n" ); setup_test( &info, winhttp_websocket_shutdown, __LINE__ ); err = pWinHttpWebSocketShutdown( socket, 1000, (void *)"success", sizeof("success") ); diff --git a/dlls/winhttp/tests/winhttp.c b/dlls/winhttp/tests/winhttp.c index 5379640d5fc..6bae45ce6da 100644 --- a/dlls/winhttp/tests/winhttp.c +++ b/dlls/winhttp/tests/winhttp.c @@ -3291,7 +3291,7 @@ static void test_websocket(int port) session = WinHttpOpen(L"winetest", 0, NULL, NULL, 0); ok(session != NULL, "got %u\n", GetLastError()); - connection = WinHttpConnect(session, L"
echo.websocket.org
", 0, 0); + connection = WinHttpConnect(session, L"ws.ifelse.io", 0, 0); ok(connection != NULL, "got %u\n", GetLastError()); request = WinHttpOpenRequest(connection, L"GET", L"/", NULL, NULL, NULL, 0); @@ -3316,6 +3316,15 @@ static void test_websocket(int port) socket = pWinHttpWebSocketCompleteUpgrade(request, 0); ok(socket != NULL, "got %u\n", GetLastError()); + buf[0] = 0; + count = 0; + type = 0xdeadbeef; + error = pWinHttpWebSocketReceive(socket, buf, sizeof(buf), &count, &type); + ok(!error, "got %u\n", error); + ok(buf[0] == 'R', "got %c\n", buf[0]); + ok(count == 26, "got %u\n", count); + ok(type == WINHTTP_WEB_SOCKET_UTF8_MESSAGE_BUFFER_TYPE, "got %u\n", type); + error = pWinHttpWebSocketSend(socket, WINHTTP_WEB_SOCKET_BINARY_MESSAGE_BUFFER_TYPE, NULL, 1); ok(error == ERROR_INVALID_PARAMETER, "got %u\n", error); @@ -3388,10 +3397,10 @@ static void test_websocket(int port) error = pWinHttpWebSocketQueryCloseStatus(socket, NULL, NULL, 0, &len); ok(error == ERROR_INVALID_PARAMETER, "got %u\n", error); - len = 0; + len = 0xdeadbeef; error = pWinHttpWebSocketQueryCloseStatus(socket, &close_status, NULL, 0, &len); - ok(error == ERROR_INSUFFICIENT_BUFFER, "got %u\n", error); - ok(len, "len not set\n"); + ok(!error, "got %u\n", error); + ok(!len, "got %u\n", len); error = pWinHttpWebSocketQueryCloseStatus(socket, &close_status, NULL, 1, &len); ok(error == ERROR_INVALID_PARAMETER, "got %u\n", error); @@ -3402,7 +3411,7 @@ static void test_websocket(int port) error = pWinHttpWebSocketQueryCloseStatus(socket, &close_status, buf, sizeof(buf), &len); ok(!error, "got %u\n", error); ok(close_status == 1000, "got %08x\n", close_status); - ok(len == sizeof("success"), "got %u\n", len); + ok(!len, "got %u\n", len); WinHttpCloseHandle(socket); WinHttpCloseHandle(request);
1
0
0
0
Zebediah Figura : wine.inf: Install the protocol database at etc\protocol.
by Alexandre Julliard
26 Oct '21
26 Oct '21
Module: wine Branch: stable Commit: f61a3b7d152c04924eace53e58eb37d596138307 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=f61a3b7d152c04924eace53e…
Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Fri Apr 16 11:08:20 2021 -0500 wine.inf: Install the protocol database at etc\protocol. Unlike Unix, on Windows the file name is not plural. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> (cherry picked from commit 03dcb369790f6b9c60806728a26cc71debee3d53) Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> --- loader/wine.inf.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/loader/wine.inf.in b/loader/wine.inf.in index d3199d167f3..82462e492d7 100644 --- a/loader/wine.inf.in +++ b/loader/wine.inf.in @@ -4069,7 +4069,7 @@ srgb color space profile.icm,"@mscms.dll,-1" [EtcFiles] hosts,"@%11%\ws2_32.dll,-1" networks,"@%11%\ws2_32.dll,-2" -protocols,"@%11%\ws2_32.dll,-3" +protocol,"@%11%\ws2_32.dll,-3" services,"@%11%\ws2_32.dll,-4" [InfFiles]
1
0
0
0
Francois Gouget : make_unicode: Add support for the 720 codepage (Arabic, Farsi and Urdu).
by Alexandre Julliard
26 Oct '21
26 Oct '21
Module: wine Branch: stable Commit: cd5311958c719e948105822ad11cbac02de7e010 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=cd5311958c719e948105822a…
Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Tue Jun 8 12:30:57 2021 +0200 make_unicode: Add support for the 720 codepage (Arabic, Farsi and Urdu). Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> (cherry picked from commit a1bae9f288a53d21a60dca5460b376a493585e07) Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> --- dlls/kernelbase/kernelbase.rgs | 1 + dlls/kernelbase/locale.c | 1 + loader/wine.inf.in | 1 + nls/Makefile.in | 1 + nls/c_720.nls | Bin 0 -> 66594 bytes tools/make_unicode | 1 + 6 files changed, 5 insertions(+) diff --git a/dlls/kernelbase/kernelbase.rgs b/dlls/kernelbase/kernelbase.rgs index 0d9dbd29c43..7b63b681f53 100644 --- a/dlls/kernelbase/kernelbase.rgs +++ b/dlls/kernelbase/kernelbase.rgs @@ -57,6 +57,7 @@ HKLM val '437' = s 'c_437.nls' val '500' = s 'c_500.nls' val '708' = s 'c_708.nls' + val '720' = s 'c_720.nls' val '737' = s 'c_737.nls' val '775' = s 'c_775.nls' val '850' = s 'c_850.nls' diff --git a/dlls/kernelbase/locale.c b/dlls/kernelbase/locale.c index a2925c5203d..250c81de5e4 100644 --- a/dlls/kernelbase/locale.c +++ b/dlls/kernelbase/locale.c @@ -108,6 +108,7 @@ static const struct { UINT cp; const WCHAR *name; } codepage_names[] = { 437, L"OEM United States" }, { 500, L"IBM EBCDIC International" }, { 708, L"Arabic ASMO" }, + { 720, L"Arabic (Transparent ASMO)" }, { 737, L"OEM Greek 437G" }, { 775, L"OEM Baltic" }, { 850, L"OEM Multilingual Latin 1" }, diff --git a/loader/wine.inf.in b/loader/wine.inf.in index 8e5798f754b..d3199d167f3 100644 --- a/loader/wine.inf.in +++ b/loader/wine.inf.in @@ -4125,6 +4125,7 @@ c_28605.nls c_437.nls c_500.nls c_708.nls +c_720.nls c_737.nls c_775.nls c_850.nls diff --git a/nls/Makefile.in b/nls/Makefile.in index 4352becac5f..456822aaa83 100644 --- a/nls/Makefile.in +++ b/nls/Makefile.in @@ -46,6 +46,7 @@ SOURCES = \ c_437.nls \ c_500.nls \ c_708.nls \ + c_720.nls \ c_737.nls \ c_775.nls \ c_850.nls \ diff --git a/nls/c_720.nls b/nls/c_720.nls new file mode 100644 index 00000000000..8d3d950e70a Binary files /dev/null and b/nls/c_720.nls differ diff --git a/tools/make_unicode b/tools/make_unicode index 69ce845b26a..5afc11ec68c 100755 --- a/tools/make_unicode +++ b/tools/make_unicode @@ -46,6 +46,7 @@ my @allfiles = "CodpageFiles/437.txt", "CodpageFiles/500.txt", "CodpageFiles/708.txt", + "CodpageFiles/720.txt", "CodpageFiles/737.txt", "CodpageFiles/775.txt", "CodpageFiles/850.txt",
1
0
0
0
Anton Baskanov : fonts: Fix dotaccent glyph position in Small Fonts.
by Alexandre Julliard
26 Oct '21
26 Oct '21
Module: wine Branch: stable Commit: 40b962f9ef34f166b637b1ee6c545d000c7815ac URL:
https://source.winehq.org/git/wine.git/?a=commit;h=40b962f9ef34f166b637b1ee…
Author: Anton Baskanov <baskanov(a)gmail.com> Date: Sun Aug 29 21:06:25 2021 +0700 fonts: Fix dotaccent glyph position in Small Fonts. Signed-off-by: Anton Baskanov <baskanov(a)gmail.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> (cherry picked from commit 80ef009fc123773ea118f3df57d54f727cab6893) Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> --- fonts/small_fonts.sfd | 2 +- fonts/small_fonts.ttf | Bin 19068 -> 19068 bytes 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/fonts/small_fonts.sfd b/fonts/small_fonts.sfd index 28dcee28e12..e8494c8dc8e 100644 --- a/fonts/small_fonts.sfd +++ b/fonts/small_fonts.sfd @@ -4638,7 +4638,7 @@ BDFChar: 281 369 5 1 4 0 7 :nRfMOH>QC BDFChar: 282 355 3 1 2 -2 5 JA?\cJ3ZB8 -BDFChar: 283 729 2 0 0 10 10 +BDFChar: 283 729 2 0 0 8 8 J,fQL BDFChar: 284 8470 9 0 8 0 6 `;mo.V#[:kQ[k;#MuWhX diff --git a/fonts/small_fonts.ttf b/fonts/small_fonts.ttf index a35230941a7..0e5e7f4127b 100644 Binary files a/fonts/small_fonts.ttf and b/fonts/small_fonts.ttf differ
1
0
0
0
Anton Baskanov : fonts: Fix breve glyph position in 16px MS Sans Serif.
by Alexandre Julliard
26 Oct '21
26 Oct '21
Module: wine Branch: stable Commit: 7347cbd07a8a3d2fe2af4e9935b8d058d4ea12c2 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=7347cbd07a8a3d2fe2af4e99…
Author: Anton Baskanov <baskanov(a)gmail.com> Date: Sun Aug 29 21:06:24 2021 +0700 fonts: Fix breve glyph position in 16px MS Sans Serif. Signed-off-by: Anton Baskanov <baskanov(a)gmail.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> (cherry picked from commit 9ecca23a32a14976641e44e88f79ffa81050f4f9) Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> --- fonts/ms_sans_serif.sfd | 2 +- fonts/ms_sans_serif.ttf | Bin 38536 -> 38536 bytes 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/fonts/ms_sans_serif.sfd b/fonts/ms_sans_serif.sfd index e8c720b528c..f2de1843448 100644 --- a/fonts/ms_sans_serif.sfd +++ b/fonts/ms_sans_serif.sfd @@ -5448,7 +5448,7 @@ BDFChar: 291 710 4 1 2 0 9 ^qdb$^qdb$^q]pM BDFChar: 292 711 5 0 3 11 12 OC/%g -BDFChar: 293 728 5 0 4 14 15 +BDFChar: 293 728 5 0 4 11 12 Li<=o BDFChar: 294 729 3 1 1 12 12 J,fQL diff --git a/fonts/ms_sans_serif.ttf b/fonts/ms_sans_serif.ttf index fd20edb4595..8c492c7d310 100644 Binary files a/fonts/ms_sans_serif.ttf and b/fonts/ms_sans_serif.ttf differ
1
0
0
0
Haidong Yu : shell32: Fix a memory leak.
by Alexandre Julliard
26 Oct '21
26 Oct '21
Module: wine Branch: stable Commit: bd11172b7aac3eb0d32df45b1adeb6b5009a8294 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=bd11172b7aac3eb0d32df45b…
Author: Haidong Yu <yuhaidong(a)uniontech.com> Date: Wed Jun 9 20:53:59 2021 +0800 shell32: Fix a memory leak. Signed-off-by: Haidong Yu <yuhaidong(a)uniontech.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> (cherry picked from commit 56976159ab792563e1e3ce237dce39d0ea68d0b8) Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> --- dlls/shell32/shlexec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/shell32/shlexec.c b/dlls/shell32/shlexec.c index ce0b8f6d2be..ee1e832df33 100644 --- a/dlls/shell32/shlexec.c +++ b/dlls/shell32/shlexec.c @@ -1763,7 +1763,8 @@ static BOOL SHELL_execute( LPSHELLEXECUTEINFOW sei, SHELL_ExecuteW32 execfunc ) buf = heap_alloc(size * sizeof(WCHAR)); if (!buf || FAILED(PathCreateFromUrlW(sei_tmp.lpFile, buf, &size, 0))) { heap_free(buf); - return SE_ERR_OOM; + retval = SE_ERR_OOM; + goto end; } heap_free(wszApplicationName);
1
0
0
0
Haidong Yu : shell32: Fix a memory leak.
by Alexandre Julliard
26 Oct '21
26 Oct '21
Module: wine Branch: stable Commit: ef54f3c22772ab1598d091a2747b7a12efd7cd5a URL:
https://source.winehq.org/git/wine.git/?a=commit;h=ef54f3c22772ab1598d091a2…
Author: Haidong Yu <yuhaidong(a)uniontech.com> Date: Mon Jun 7 17:47:33 2021 +0800 shell32: Fix a memory leak. Signed-off-by: Haidong Yu <yuhaidong(a)uniontech.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> (cherry picked from commit 479b6594630c32b345aeb1cfd3c4c9cd8e214f95) Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> --- dlls/shell32/shelllink.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/dlls/shell32/shelllink.c b/dlls/shell32/shelllink.c index 5b044d4be1d..10b4769d970 100644 --- a/dlls/shell32/shelllink.c +++ b/dlls/shell32/shelllink.c @@ -2150,7 +2150,10 @@ static HRESULT WINAPI IShellLinkW_fnSetPath(IShellLinkW * iface, LPCWSTR pszFile if (*pszFile == '\0') *buffer = '\0'; else if (!GetFullPathNameW(pszFile, MAX_PATH, buffer, &fname)) - return E_FAIL; + { + heap_free(unquoted); + return E_FAIL; + } else if(!PathFileExistsW(buffer) && !SearchPathW(NULL, pszFile, NULL, MAX_PATH, buffer, NULL)) hr = S_FALSE;
1
0
0
0
Rémi Bernon : dinput: Prevent a device interface leak when enumerating.
by Alexandre Julliard
26 Oct '21
26 Oct '21
Module: wine Branch: stable Commit: 531247b84e5f95ee565701f5c3f7fe85e543ecef URL:
https://source.winehq.org/git/wine.git/?a=commit;h=531247b84e5f95ee565701f5…
Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Mon May 31 10:23:57 2021 +0200 dinput: Prevent a device interface leak when enumerating. Wine-Bug:
https://bugs.winehq.org//show_bug.cgi?id=36263
Signed-off-by: Rémi Bernon <rbernon(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> (cherry picked from commit 52aacd2377c68097ea165fdfff188fd6768fcc4c) Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> --- dlls/dinput/dinput_main.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/dlls/dinput/dinput_main.c b/dlls/dinput/dinput_main.c index 5da60cf1f7c..17768df319a 100644 --- a/dlls/dinput/dinput_main.c +++ b/dlls/dinput/dinput_main.c @@ -1268,8 +1268,10 @@ static HRESULT WINAPI IDirectInput8WImpl_EnumDevicesBySemantics( if (lpCallback(&didevis[i], lpdid, callbackFlags, --remain, pvRef) == DIENUM_STOP) { HeapFree(GetProcessHeap(), 0, didevis); + IDirectInputDevice_Release(lpdid); return DI_OK; } + IDirectInputDevice_Release(lpdid); } HeapFree(GetProcessHeap(), 0, didevis); @@ -1287,7 +1289,11 @@ static HRESULT WINAPI IDirectInput8WImpl_EnumDevicesBySemantics( IDirectInputDevice_GetDeviceInfo(lpdid, &didevi); if (lpCallback(&didevi, lpdid, callbackFlags, --remain, pvRef) == DIENUM_STOP) + { + IDirectInputDevice_Release(lpdid); return DI_OK; + } + IDirectInputDevice_Release(lpdid); } }
1
0
0
0
Damjan Jovanovic : shell32: Fix a lock leak.
by Alexandre Julliard
26 Oct '21
26 Oct '21
Module: wine Branch: stable Commit: e35da6ed015f3ae1bd1b75c9c97e4f89779e7807 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=e35da6ed015f3ae1bd1b75c9…
Author: Damjan Jovanovic <damjan.jov(a)gmail.com> Date: Tue May 25 07:53:08 2021 +0200 shell32: Fix a lock leak. Signed-off-by: Damjan Jovanovic <damjan.jov(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> (cherry picked from commit 401de24b89d751f553b5c62c867da2956e9d4bc0) Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> --- dlls/shell32/shlview_cmenu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/shell32/shlview_cmenu.c b/dlls/shell32/shlview_cmenu.c index e7c1cf16e10..e6963a13d8c 100644 --- a/dlls/shell32/shlview_cmenu.c +++ b/dlls/shell32/shlview_cmenu.c @@ -1189,6 +1189,7 @@ static BOOL DoPaste(ContextMenu *This) _ILFreeaPidl(apidl, lpcida->cidl); SHFree(pidl); + GlobalUnlock(medium.u.hGlobal); /* release the medium*/ ReleaseStgMedium(&medium);
1
0
0
0
Torge Matthies : winex11.drv: Avoid race condition in X11 error handling.
by Alexandre Julliard
26 Oct '21
26 Oct '21
Module: wine Branch: stable Commit: 96a1855bb92d8ee080f3505245f1fda3368ebf70 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=96a1855bb92d8ee080f35052…
Author: Torge Matthies <openglfreak(a)googlemail.com> Date: Mon Jun 7 01:05:16 2021 +0200 winex11.drv: Avoid race condition in X11 error handling. The err_callback* globals need to be protected from being overwritten before X11DRV_check_error is called, otherwise no or the wrong error handler might be called. Signed-off-by: Torge Matthies <openglfreak(a)googlemail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> (cherry picked from commit 2e4bfa642e31f9690365d6daf42ef87a74331cf7) Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> --- dlls/winex11.drv/x11drv_main.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/dlls/winex11.drv/x11drv_main.c b/dlls/winex11.drv/x11drv_main.c index 9ec4c7a98f6..2fac560556b 100644 --- a/dlls/winex11.drv/x11drv_main.c +++ b/dlls/winex11.drv/x11drv_main.c @@ -108,6 +108,15 @@ static CRITICAL_SECTION_DEBUG critsect_debug = }; static CRITICAL_SECTION x11drv_section = { &critsect_debug, -1, 0, 0, 0, 0 }; +static CRITICAL_SECTION x11drv_error_section; +static CRITICAL_SECTION_DEBUG x11drv_error_section_debug = +{ + 0, 0, &x11drv_error_section, + { &x11drv_error_section_debug.ProcessLocksList, &x11drv_error_section_debug.ProcessLocksList }, + 0, 0, { (DWORD_PTR)(__FILE__ ": x11drv_error_section") } +}; +static CRITICAL_SECTION x11drv_error_section = { &x11drv_error_section_debug, -1, 0, 0, 0, 0 }; + struct d3dkmt_vidpn_source { D3DKMT_VIDPNSOURCEOWNER_TYPE type; /* VidPN source owner type */ @@ -256,6 +265,7 @@ static inline BOOL ignore_error( Display *display, XErrorEvent *event ) */ void X11DRV_expect_error( Display *display, x11drv_error_callback callback, void *arg ) { + EnterCriticalSection( &x11drv_error_section ); err_callback = callback; err_callback_display = display; err_callback_arg = arg; @@ -272,8 +282,10 @@ void X11DRV_expect_error( Display *display, x11drv_error_callback callback, void */ int X11DRV_check_error(void) { + int res = err_callback_result; err_callback = NULL; - return err_callback_result; + LeaveCriticalSection( &x11drv_error_section ); + return res; }
1
0
0
0
← Newer
1
...
17
18
19
20
21
22
23
...
117
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
Results per page:
10
25
50
100
200