winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
October 2021
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
1165 discussions
Start a n
N
ew thread
Eric Pouech : winedump: Fix incorrect alignment.
by Alexandre Julliard
13 Oct '21
13 Oct '21
Module: wine Branch: master Commit: bad368750e5881683574250df3ad7db75b0607ac URL:
https://source.winehq.org/git/wine.git/?a=commit;h=bad368750e5881683574250d…
Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Wed Oct 13 15:17:08 2021 +0200 winedump: Fix incorrect alignment. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- tools/winedump/msc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/winedump/msc.c b/tools/winedump/msc.c index 2c3d406347e..b7b7eb435ff 100644 --- a/tools/winedump/msc.c +++ b/tools/winedump/msc.c @@ -1161,7 +1161,7 @@ BOOL codeview_dump_types_from_block(const void* table, unsigned long len) codeview_dump_one_type(curr_type, type); curr_type++; - ptr += (type->generic.len + 2 + 3) & ~3; + ptr += type->generic.len + 2; } return TRUE;
1
0
0
0
Eric Pouech : mscoree/tests: Remove unused parameter in sprintf.
by Alexandre Julliard
13 Oct '21
13 Oct '21
Module: wine Branch: master Commit: 7b5e8ef1d84a3f1c78a1dc467a671d5b8785116f URL:
https://source.winehq.org/git/wine.git/?a=commit;h=7b5e8ef1d84a3f1c78a1dc46…
Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Wed Oct 13 15:15:24 2021 +0200 mscoree/tests: Remove unused parameter in sprintf. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> Signed-off-by: Esme Povirk <esme(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mscoree/tests/comtest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/mscoree/tests/comtest.c b/dlls/mscoree/tests/comtest.c index 6c0d081cbd3..f6dc93c1070 100644 --- a/dlls/mscoree/tests/comtest.c +++ b/dlls/mscoree/tests/comtest.c @@ -166,7 +166,7 @@ static void run_registry_test(run_type run) if (run == run_type_exe_directory) result_expected = S_OK; else result_expected = HRESULT_FROM_WIN32(ERROR_FILE_NOT_FOUND); - sprintf(buffer, "CLSID\\%s", wine_dbgstr_guid(&CLSID_Test), ""); + sprintf(buffer, "CLSID\\%s", wine_dbgstr_guid(&CLSID_Test)); ret = RegCreateKeyA( HKEY_CLASSES_ROOT, buffer, &hkey ); if (ret == ERROR_ACCESS_DENIED && !IsUserAnAdmin()) {
1
0
0
0
Jacek Caban : make_unicode: Update vertical.c path.
by Alexandre Julliard
13 Oct '21
13 Oct '21
Module: wine Branch: master Commit: 5740b091b941bc156acf61fe2e8e9505c708da36 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=5740b091b941bc156acf61fe…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Oct 13 17:08:37 2021 +0200 make_unicode: Update vertical.c path. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- tools/make_unicode | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/make_unicode b/tools/make_unicode index c5c804b678b..4c9d3d6d988 100755 --- a/tools/make_unicode +++ b/tools/make_unicode @@ -2828,7 +2828,7 @@ dump_linebreak( "dlls/gdi32/uniscribe/linebreak.c" ); dump_linebreak( "dlls/dwrite/linebreak.c" ); dump_scripts( "dlls/dwrite/scripts" ); dump_indic( "dlls/gdi32/uniscribe/indicsyllable.c" ); -dump_vertical( "dlls/gdi32/vertical.c", 1 ); +dump_vertical( "dlls/win32u/vertical.c", 1 ); dump_vertical( "dlls/wineps.drv/vertical.c", 0 ); dump_intl_nls("nls/l_intl.nls"); dump_norm_table( "nls/normnfc.nls" );
1
0
0
0
Jacek Caban : win32u: Move NtUserSetObjectInformation implementation from user32.
by Alexandre Julliard
13 Oct '21
13 Oct '21
Module: wine Branch: master Commit: 9f041bb21e1140825a2cea72bf7c795800ee1609 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=9f041bb21e1140825a2cea72…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Oct 13 14:56:22 2021 +0200 win32u: Move NtUserSetObjectInformation implementation from user32. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/user32/user32.spec | 2 +- dlls/user32/user_main.c | 2 +- dlls/user32/winstation.c | 28 +--------------------------- dlls/win32u/syscall.c | 1 + dlls/win32u/win32u.spec | 2 +- dlls/win32u/winstation.c | 25 +++++++++++++++++++++++++ dlls/wow64win/syscall.h | 1 + dlls/wow64win/user.c | 10 ++++++++++ include/ntuser.h | 1 + 9 files changed, 42 insertions(+), 30 deletions(-) diff --git a/dlls/user32/user32.spec b/dlls/user32/user32.spec index 97ad596e518..306f955b2a2 100644 --- a/dlls/user32/user32.spec +++ b/dlls/user32/user32.spec @@ -713,7 +713,7 @@ @ stdcall SetThreadDpiAwarenessContext(ptr) @ stdcall SetTimer(long long long ptr) @ stdcall SetUserObjectInformationA(long long ptr long) -@ stdcall SetUserObjectInformationW(long long ptr long) +@ stdcall SetUserObjectInformationW(long long ptr long) NtUserSetObjectInformation @ stdcall SetUserObjectSecurity(long ptr ptr) @ stdcall SetWinEventHook(long long long ptr long long long) @ stdcall SetWindowCompositionAttribute(ptr ptr) diff --git a/dlls/user32/user_main.c b/dlls/user32/user_main.c index 5a786ad7f83..0046d475fbc 100644 --- a/dlls/user32/user_main.c +++ b/dlls/user32/user_main.c @@ -303,7 +303,7 @@ static void winstation_init(void) flags.fInherit = FALSE; flags.fReserved = FALSE; flags.dwFlags = WSF_VISIBLE; - SetUserObjectInformationW( handle, UOI_FLAGS, &flags, sizeof(flags) ); + NtUserSetObjectInformation( handle, UOI_FLAGS, &flags, sizeof(flags) ); } } } diff --git a/dlls/user32/winstation.c b/dlls/user32/winstation.c index 1a955879f3d..e2c4f0f251f 100644 --- a/dlls/user32/winstation.c +++ b/dlls/user32/winstation.c @@ -461,33 +461,7 @@ BOOL WINAPI GetUserObjectInformationA( HANDLE handle, INT index, LPVOID info, DW */ BOOL WINAPI SetUserObjectInformationA( HANDLE handle, INT index, LPVOID info, DWORD len ) { - return SetUserObjectInformationW( handle, index, info, len ); -} - - -/****************************************************************************** - * SetUserObjectInformationW (USER32.@) - */ -BOOL WINAPI SetUserObjectInformationW( HANDLE handle, INT index, LPVOID info, DWORD len ) -{ - BOOL ret; - const USEROBJECTFLAGS *obj_flags = info; - - if (index != UOI_FLAGS || !info || len < sizeof(*obj_flags)) - { - SetLastError( ERROR_INVALID_PARAMETER ); - return FALSE; - } - /* FIXME: inherit flag */ - SERVER_START_REQ( set_user_object_info ) - { - req->handle = wine_server_obj_handle( handle ); - req->flags = SET_USER_OBJECT_SET_FLAGS; - req->obj_flags = obj_flags->dwFlags; - ret = !wine_server_call_err( req ); - } - SERVER_END_REQ; - return ret; + return NtUserSetObjectInformation( handle, index, info, len ); } diff --git a/dlls/win32u/syscall.c b/dlls/win32u/syscall.c index 06fc68f00cf..f54098c5d4f 100644 --- a/dlls/win32u/syscall.c +++ b/dlls/win32u/syscall.c @@ -100,6 +100,7 @@ static void * const syscalls[] = NtUserGetProcessWindowStation, NtUserGetThreadDesktop, NtUserOpenInputDesktop, + NtUserSetObjectInformation, NtUserSetProcessWindowStation, NtUserSetThreadDesktop, }; diff --git a/dlls/win32u/win32u.spec b/dlls/win32u/win32u.spec index 5c477f75bfd..c82e974be04 100644 --- a/dlls/win32u/win32u.spec +++ b/dlls/win32u/win32u.spec @@ -1213,7 +1213,7 @@ @ stub NtUserSetMirrorRendering @ stub NtUserSetMonitorWorkArea @ stub NtUserSetMouseInputRateLimitingTimer -@ stub NtUserSetObjectInformation +@ stdcall -syscall NtUserSetObjectInformation(long long ptr long) @ stub NtUserSetParent @ stub NtUserSetPrecisionTouchPadConfiguration @ stub NtUserSetProcessDpiAwarenessContext diff --git a/dlls/win32u/winstation.c b/dlls/win32u/winstation.c index 6bf2cd5e2c1..e787cc3884c 100644 --- a/dlls/win32u/winstation.c +++ b/dlls/win32u/winstation.c @@ -246,3 +246,28 @@ BOOL WINAPI NtUserGetObjectInformation( HANDLE handle, INT index, void *info, return FALSE; } } + +/*********************************************************************** + * NtUserSetObjectInformation (win32u.@) + */ +BOOL WINAPI NtUserSetObjectInformation( HANDLE handle, INT index, void *info, DWORD len ) +{ + BOOL ret; + const USEROBJECTFLAGS *obj_flags = info; + + if (index != UOI_FLAGS || !info || len < sizeof(*obj_flags)) + { + SetLastError( ERROR_INVALID_PARAMETER ); + return FALSE; + } + /* FIXME: inherit flag */ + SERVER_START_REQ( set_user_object_info ) + { + req->handle = wine_server_obj_handle( handle ); + req->flags = SET_USER_OBJECT_SET_FLAGS; + req->obj_flags = obj_flags->dwFlags; + ret = !wine_server_call_err( req ); + } + SERVER_END_REQ; + return ret; +} diff --git a/dlls/wow64win/syscall.h b/dlls/wow64win/syscall.h index 154c21e5cc6..303bdf08c57 100644 --- a/dlls/wow64win/syscall.h +++ b/dlls/wow64win/syscall.h @@ -86,6 +86,7 @@ SYSCALL_ENTRY( NtUserGetProcessWindowStation ) \ SYSCALL_ENTRY( NtUserGetThreadDesktop ) \ SYSCALL_ENTRY( NtUserOpenInputDesktop ) \ + SYSCALL_ENTRY( NtUserSetObjectInformation ) \ SYSCALL_ENTRY( NtUserSetProcessWindowStation ) \ SYSCALL_ENTRY( NtUserSetThreadDesktop ) diff --git a/dlls/wow64win/user.c b/dlls/wow64win/user.c index 47a7263ab46..59286969283 100644 --- a/dlls/wow64win/user.c +++ b/dlls/wow64win/user.c @@ -86,3 +86,13 @@ NTSTATUS WINAPI wow64_NtUserGetObjectInformation( UINT *args ) return NtUserGetObjectInformation( handle, index, info, len, needed ); } + +NTSTATUS WINAPI wow64_NtUserSetObjectInformation( UINT *args ) +{ + HANDLE handle = get_handle( &args ); + INT index = get_ulong( &args ); + void *info = get_ptr( &args ); + DWORD len = get_ulong( &args ); + + return NtUserSetObjectInformation( handle, index, info, len ); +} diff --git a/include/ntuser.h b/include/ntuser.h index 0478ab69967..e5d16afdd53 100644 --- a/include/ntuser.h +++ b/include/ntuser.h @@ -28,6 +28,7 @@ BOOL WINAPI NtUserGetObjectInformation( HANDLE handle, INT index, void *info, DWORD len, DWORD *needed ); HWINSTA WINAPI NtUserGetProcessWindowStation(void); HDESK WINAPI NtUserGetThreadDesktop( DWORD thread ); +BOOL WINAPI NtUserSetObjectInformation( HANDLE handle, INT index, void *info, DWORD len ); HDESK WINAPI NtUserOpenInputDesktop( DWORD flags, BOOL inherit, ACCESS_MASK access ); BOOL WINAPI NtUserSetProcessWindowStation( HWINSTA handle ); BOOL WINAPI NtUserSetThreadDesktop( HDESK handle );
1
0
0
0
Jacek Caban : win32u: Move NtUserGetObjectInformation implementation from user32.
by Alexandre Julliard
13 Oct '21
13 Oct '21
Module: wine Branch: master Commit: b55abd072e3cc8c8e1627c00b18a0893bafeb9dd URL:
https://source.winehq.org/git/wine.git/?a=commit;h=b55abd072e3cc8c8e1627c00…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Oct 13 14:55:30 2021 +0200 win32u: Move NtUserGetObjectInformation implementation from user32. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/user32/sysparams.c | 2 +- dlls/user32/user32.spec | 2 +- dlls/user32/winstation.c | 95 +----------------------------------------------- dlls/win32u/syscall.c | 1 + dlls/win32u/win32u.spec | 2 +- dlls/win32u/winstation.c | 94 +++++++++++++++++++++++++++++++++++++++++++++++ dlls/wow64win/user.c | 11 ++++++ include/ntuser.h | 2 + 8 files changed, 113 insertions(+), 96 deletions(-) Diff:
https://source.winehq.org/git/wine.git/?a=commitdiff;h=b55abd072e3cc8c8e162…
1
0
0
0
Jacek Caban : win32u: Move NtUserOpenInputDesktop implementation from user32.
by Alexandre Julliard
13 Oct '21
13 Oct '21
Module: wine Branch: master Commit: af7ed8a538a51c120a7c0b82b2838c6310827b4e URL:
https://source.winehq.org/git/wine.git/?a=commit;h=af7ed8a538a51c120a7c0b82…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Oct 13 14:54:56 2021 +0200 win32u: Move NtUserOpenInputDesktop implementation from user32. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/user32/user32.spec | 2 +- dlls/user32/winstation.c | 25 ------------------------- dlls/win32u/syscall.c | 1 + dlls/win32u/win32u.spec | 2 +- dlls/win32u/winstation.c | 28 ++++++++++++++++++++++++++++ dlls/wow64win/syscall.h | 1 + dlls/wow64win/user.c | 9 +++++++++ include/ntuser.h | 1 + 8 files changed, 42 insertions(+), 27 deletions(-) diff --git a/dlls/user32/user32.spec b/dlls/user32/user32.spec index ecc7675403c..0c1066bc895 100644 --- a/dlls/user32/user32.spec +++ b/dlls/user32/user32.spec @@ -556,7 +556,7 @@ @ stdcall OpenDesktopA(str long long long) @ stdcall OpenDesktopW(wstr long long long) @ stdcall OpenIcon(long) -@ stdcall OpenInputDesktop(long long long) +@ stdcall OpenInputDesktop(long long long) NtUserOpenInputDesktop @ stdcall OpenWindowStationA(str long long) @ stdcall OpenWindowStationW(wstr long long) @ stdcall PackDDElParam(long long long) diff --git a/dlls/user32/winstation.c b/dlls/user32/winstation.c index a8140c34b8d..1899feb6a28 100644 --- a/dlls/user32/winstation.c +++ b/dlls/user32/winstation.c @@ -426,31 +426,6 @@ BOOL WINAPI EnumDesktopsW( HWINSTA winsta, DESKTOPENUMPROCW func, LPARAM lparam } -/****************************************************************************** - * OpenInputDesktop (USER32.@) - */ -HDESK WINAPI OpenInputDesktop( DWORD flags, BOOL inherit, ACCESS_MASK access ) -{ - HANDLE ret = 0; - - TRACE( "(%x,%i,%x)\n", flags, inherit, access ); - - if (flags) - FIXME( "partial stub flags %08x\n", flags ); - - SERVER_START_REQ( open_input_desktop ) - { - req->flags = flags; - req->access = access; - req->attributes = inherit ? OBJ_INHERIT : 0; - if (!wine_server_call_err( req )) ret = wine_server_ptr_handle( reply->handle ); - } - SERVER_END_REQ; - - return ret; -} - - /*********************************************************************** * GetUserObjectInformationA (USER32.@) */ diff --git a/dlls/win32u/syscall.c b/dlls/win32u/syscall.c index 7ea1f30e3f9..2b54fddfb1a 100644 --- a/dlls/win32u/syscall.c +++ b/dlls/win32u/syscall.c @@ -98,6 +98,7 @@ static void * const syscalls[] = NtUserCloseWindowStation, NtUserGetProcessWindowStation, NtUserGetThreadDesktop, + NtUserOpenInputDesktop, NtUserSetProcessWindowStation, NtUserSetThreadDesktop, }; diff --git a/dlls/win32u/win32u.spec b/dlls/win32u/win32u.spec index c24957a224c..dc380b84c34 100644 --- a/dlls/win32u/win32u.spec +++ b/dlls/win32u/win32u.spec @@ -1092,7 +1092,7 @@ @ stub NtUserNotifyWinEvent @ stub NtUserOpenClipboard @ stub NtUserOpenDesktop -@ stub NtUserOpenInputDesktop +@ stdcall -syscall NtUserOpenInputDesktop(long long long) @ stub NtUserOpenThreadDesktop @ stub NtUserOpenWindowStation @ stub NtUserPaintDesktop diff --git a/dlls/win32u/winstation.c b/dlls/win32u/winstation.c index 7cebe5d44d7..af744ce89eb 100644 --- a/dlls/win32u/winstation.c +++ b/dlls/win32u/winstation.c @@ -28,6 +28,10 @@ #include "ntuser.h" #include "winternl.h" #include "wine/server.h" +#include "wine/debug.h" + +WINE_DEFAULT_DEBUG_CHANNEL(winstation); + /*********************************************************************** * NtUserCloseWindowStation (win32u.@) @@ -124,3 +128,27 @@ BOOL WINAPI NtUserSetThreadDesktop( HDESK handle ) /* FIXME: reset uset thread info */ return ret; } + +/*********************************************************************** + * NtUserOpenInputDesktop (win32u.@) + */ +HDESK WINAPI NtUserOpenInputDesktop( DWORD flags, BOOL inherit, ACCESS_MASK access ) +{ + HANDLE ret = 0; + + TRACE( "(%x,%i,%x)\n", flags, inherit, access ); + + if (flags) + FIXME( "partial stub flags %08x\n", flags ); + + SERVER_START_REQ( open_input_desktop ) + { + req->flags = flags; + req->access = access; + req->attributes = inherit ? OBJ_INHERIT : 0; + if (!wine_server_call_err( req )) ret = wine_server_ptr_handle( reply->handle ); + } + SERVER_END_REQ; + + return ret; +} diff --git a/dlls/wow64win/syscall.h b/dlls/wow64win/syscall.h index d6c4c5856bd..154c21e5cc6 100644 --- a/dlls/wow64win/syscall.h +++ b/dlls/wow64win/syscall.h @@ -85,6 +85,7 @@ SYSCALL_ENTRY( NtUserCloseWindowStation ) \ SYSCALL_ENTRY( NtUserGetProcessWindowStation ) \ SYSCALL_ENTRY( NtUserGetThreadDesktop ) \ + SYSCALL_ENTRY( NtUserOpenInputDesktop ) \ SYSCALL_ENTRY( NtUserSetProcessWindowStation ) \ SYSCALL_ENTRY( NtUserSetThreadDesktop ) diff --git a/dlls/wow64win/user.c b/dlls/wow64win/user.c index a4b26c5ac96..9dca44286e3 100644 --- a/dlls/wow64win/user.c +++ b/dlls/wow64win/user.c @@ -66,3 +66,12 @@ NTSTATUS WINAPI wow64_NtUserSetThreadDesktop( UINT *args ) return NtUserSetThreadDesktop( handle ); } + +NTSTATUS WINAPI wow64_NtUserOpenInputDesktop( UINT *args ) +{ + DWORD flags = get_ulong( &args ); + BOOL inherit = get_ulong( &args ); + ACCESS_MASK access = get_ulong( &args ); + + return HandleToUlong( NtUserOpenInputDesktop( flags, inherit, access )); +} diff --git a/include/ntuser.h b/include/ntuser.h index b9d94ce66de..d253c127ad3 100644 --- a/include/ntuser.h +++ b/include/ntuser.h @@ -26,6 +26,7 @@ BOOL WINAPI NtUserCloseDesktop( HDESK handle ); BOOL WINAPI NtUserCloseWindowStation( HWINSTA handle ); HWINSTA WINAPI NtUserGetProcessWindowStation(void); HDESK WINAPI NtUserGetThreadDesktop( DWORD thread ); +HDESK WINAPI NtUserOpenInputDesktop( DWORD flags, BOOL inherit, ACCESS_MASK access ); BOOL WINAPI NtUserSetProcessWindowStation( HWINSTA handle ); BOOL WINAPI NtUserSetThreadDesktop( HDESK handle );
1
0
0
0
Jacek Caban : win32u: Move NtUserSetThreadDesktop implementation from user32.
by Alexandre Julliard
13 Oct '21
13 Oct '21
Module: wine Branch: master Commit: ce9fc213a734a636fdfd020f0551affaf67411da URL:
https://source.winehq.org/git/wine.git/?a=commit;h=ce9fc213a734a636fdfd020f…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Oct 13 14:54:21 2021 +0200 win32u: Move NtUserSetThreadDesktop implementation from user32. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/user32/user_main.c | 2 +- dlls/user32/winstation.c | 8 +------- dlls/win32u/syscall.c | 1 + dlls/win32u/win32u.spec | 2 +- dlls/win32u/winstation.c | 18 ++++++++++++++++++ dlls/wow64win/syscall.h | 3 ++- dlls/wow64win/user.c | 7 +++++++ include/ntuser.h | 1 + 8 files changed, 32 insertions(+), 10 deletions(-) diff --git a/dlls/user32/user_main.c b/dlls/user32/user_main.c index 0bf9eac434f..5a786ad7f83 100644 --- a/dlls/user32/user_main.c +++ b/dlls/user32/user_main.c @@ -311,7 +311,7 @@ static void winstation_init(void) { handle = CreateDesktopW( desktop ? desktop : get_default_desktop(), NULL, NULL, 0, DESKTOP_ALL_ACCESS, NULL ); - if (handle) SetThreadDesktop( handle ); + if (handle) NtUserSetThreadDesktop( handle ); } HeapFree( GetProcessHeap(), 0, buffer ); diff --git a/dlls/user32/winstation.c b/dlls/user32/winstation.c index 8150a7c87ec..a8140c34b8d 100644 --- a/dlls/user32/winstation.c +++ b/dlls/user32/winstation.c @@ -362,14 +362,8 @@ HDESK WINAPI OpenDesktopW( LPCWSTR name, DWORD flags, BOOL inherit, ACCESS_MASK */ BOOL WINAPI SetThreadDesktop( HDESK handle ) { - BOOL ret; + BOOL ret = NtUserSetThreadDesktop( handle ); - SERVER_START_REQ( set_thread_desktop ) - { - req->handle = wine_server_obj_handle( handle ); - ret = !wine_server_call_err( req ); - } - SERVER_END_REQ; if (ret) /* reset the desktop windows */ { struct user_thread_info *thread_info = get_user_thread_info(); diff --git a/dlls/win32u/syscall.c b/dlls/win32u/syscall.c index a6e5be579fc..7ea1f30e3f9 100644 --- a/dlls/win32u/syscall.c +++ b/dlls/win32u/syscall.c @@ -99,6 +99,7 @@ static void * const syscalls[] = NtUserGetProcessWindowStation, NtUserGetThreadDesktop, NtUserSetProcessWindowStation, + NtUserSetThreadDesktop, }; static BYTE arguments[ARRAY_SIZE(syscalls)]; diff --git a/dlls/win32u/win32u.spec b/dlls/win32u/win32u.spec index 88b30cfae28..c24957a224c 100644 --- a/dlls/win32u/win32u.spec +++ b/dlls/win32u/win32u.spec @@ -1232,7 +1232,7 @@ @ stub NtUserSetSystemMenu @ stub NtUserSetSystemTimer @ stub NtUserSetTargetForResourceBrokering -@ stub NtUserSetThreadDesktop +@ stdcall -syscall NtUserSetThreadDesktop(long) @ stub NtUserSetThreadInputBlocked @ stub NtUserSetThreadLayoutHandles @ stub NtUserSetThreadState diff --git a/dlls/win32u/winstation.c b/dlls/win32u/winstation.c index 54046c646c0..7cebe5d44d7 100644 --- a/dlls/win32u/winstation.c +++ b/dlls/win32u/winstation.c @@ -106,3 +106,21 @@ HDESK WINAPI NtUserGetThreadDesktop( DWORD thread ) SERVER_END_REQ; return ret; } + +/*********************************************************************** + * NtUserSetThreadDesktop (win32u.@) + */ +BOOL WINAPI NtUserSetThreadDesktop( HDESK handle ) +{ + BOOL ret; + + SERVER_START_REQ( set_thread_desktop ) + { + req->handle = wine_server_obj_handle( handle ); + ret = !wine_server_call_err( req ); + } + SERVER_END_REQ; + + /* FIXME: reset uset thread info */ + return ret; +} diff --git a/dlls/wow64win/syscall.h b/dlls/wow64win/syscall.h index 3f01ce4f192..d6c4c5856bd 100644 --- a/dlls/wow64win/syscall.h +++ b/dlls/wow64win/syscall.h @@ -85,6 +85,7 @@ SYSCALL_ENTRY( NtUserCloseWindowStation ) \ SYSCALL_ENTRY( NtUserGetProcessWindowStation ) \ SYSCALL_ENTRY( NtUserGetThreadDesktop ) \ - SYSCALL_ENTRY( NtUserSetProcessWindowStation ) + SYSCALL_ENTRY( NtUserSetProcessWindowStation ) \ + SYSCALL_ENTRY( NtUserSetThreadDesktop ) #endif /* __WOW64WIN_SYSCALL_H */ diff --git a/dlls/wow64win/user.c b/dlls/wow64win/user.c index 93e31ad89a1..a4b26c5ac96 100644 --- a/dlls/wow64win/user.c +++ b/dlls/wow64win/user.c @@ -59,3 +59,10 @@ NTSTATUS WINAPI wow64_NtUserGetThreadDesktop( UINT *args ) return HandleToUlong( NtUserGetThreadDesktop( thread )); } + +NTSTATUS WINAPI wow64_NtUserSetThreadDesktop( UINT *args ) +{ + HDESK handle = get_handle( &args ); + + return NtUserSetThreadDesktop( handle ); +} diff --git a/include/ntuser.h b/include/ntuser.h index 5d7f22c47d6..b9d94ce66de 100644 --- a/include/ntuser.h +++ b/include/ntuser.h @@ -27,5 +27,6 @@ BOOL WINAPI NtUserCloseWindowStation( HWINSTA handle ); HWINSTA WINAPI NtUserGetProcessWindowStation(void); HDESK WINAPI NtUserGetThreadDesktop( DWORD thread ); BOOL WINAPI NtUserSetProcessWindowStation( HWINSTA handle ); +BOOL WINAPI NtUserSetThreadDesktop( HDESK handle ); #endif /* _NTUSER_ */
1
0
0
0
Jacek Caban : win32u: Move NtUserGetThreadDesktop implementation from user32.
by Alexandre Julliard
13 Oct '21
13 Oct '21
Module: wine Branch: master Commit: 915fb5681e5f77b5f2698e159332dd879216ea79 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=915fb5681e5f77b5f2698e15…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Oct 13 14:54:00 2021 +0200 win32u: Move NtUserGetThreadDesktop implementation from user32. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/user32/user32.spec | 2 +- dlls/user32/user_main.c | 2 +- dlls/user32/win.c | 2 +- dlls/user32/winstation.c | 17 ----------------- dlls/win32u/syscall.c | 1 + dlls/win32u/win32u.spec | 2 +- dlls/win32u/winstation.c | 16 ++++++++++++++++ dlls/wow64win/syscall.h | 1 + dlls/wow64win/user.c | 7 +++++++ include/ntuser.h | 1 + 10 files changed, 30 insertions(+), 21 deletions(-) diff --git a/dlls/user32/user32.spec b/dlls/user32/user32.spec index 7686e4ed14d..ecc7675403c 100644 --- a/dlls/user32/user32.spec +++ b/dlls/user32/user32.spec @@ -387,7 +387,7 @@ @ stdcall GetTabbedTextExtentA(long str long long ptr) @ stdcall GetTabbedTextExtentW(long wstr long long ptr) @ stdcall GetTaskmanWindow () -@ stdcall GetThreadDesktop(long) +@ stdcall GetThreadDesktop(long) NtUserGetThreadDesktop @ stdcall GetThreadDpiAwarenessContext() @ stdcall GetTitleBarInfo(long ptr) @ stdcall GetTopWindow(long) diff --git a/dlls/user32/user_main.c b/dlls/user32/user_main.c index d7f320575cb..0bf9eac434f 100644 --- a/dlls/user32/user_main.c +++ b/dlls/user32/user_main.c @@ -307,7 +307,7 @@ static void winstation_init(void) } } } - if (buffer || !GetThreadDesktop( GetCurrentThreadId() )) + if (buffer || !NtUserGetThreadDesktop( GetCurrentThreadId() )) { handle = CreateDesktopW( desktop ? desktop : get_default_desktop(), NULL, NULL, 0, DESKTOP_ALL_ACCESS, NULL ); diff --git a/dlls/user32/win.c b/dlls/user32/win.c index 5e89f4c2c97..e07b7d39e4b 100644 --- a/dlls/user32/win.c +++ b/dlls/user32/win.c @@ -2231,7 +2231,7 @@ HWND WINAPI GetDesktopWindow(void) SERVER_START_REQ( set_user_object_info ) { - req->handle = wine_server_obj_handle( GetThreadDesktop(GetCurrentThreadId()) ); + req->handle = wine_server_obj_handle( NtUserGetThreadDesktop(GetCurrentThreadId()) ); req->flags = SET_USER_OBJECT_GET_FULL_NAME; wine_server_set_reply( req, desktop, sizeof(desktop) - sizeof(WCHAR) ); if (!wine_server_call( req )) diff --git a/dlls/user32/winstation.c b/dlls/user32/winstation.c index 1f847ca8b8f..8150a7c87ec 100644 --- a/dlls/user32/winstation.c +++ b/dlls/user32/winstation.c @@ -357,23 +357,6 @@ HDESK WINAPI OpenDesktopW( LPCWSTR name, DWORD flags, BOOL inherit, ACCESS_MASK } -/****************************************************************************** - * GetThreadDesktop (USER32.@) - */ -HDESK WINAPI GetThreadDesktop( DWORD thread ) -{ - HDESK ret = 0; - - SERVER_START_REQ( get_thread_desktop ) - { - req->tid = thread; - if (!wine_server_call_err( req )) ret = wine_server_ptr_handle( reply->handle ); - } - SERVER_END_REQ; - return ret; -} - - /****************************************************************************** * SetThreadDesktop (USER32.@) */ diff --git a/dlls/win32u/syscall.c b/dlls/win32u/syscall.c index 2f4269104dd..a6e5be579fc 100644 --- a/dlls/win32u/syscall.c +++ b/dlls/win32u/syscall.c @@ -97,6 +97,7 @@ static void * const syscalls[] = NtUserCloseDesktop, NtUserCloseWindowStation, NtUserGetProcessWindowStation, + NtUserGetThreadDesktop, NtUserSetProcessWindowStation, }; diff --git a/dlls/win32u/win32u.spec b/dlls/win32u/win32u.spec index 69a48236d84..88b30cfae28 100644 --- a/dlls/win32u/win32u.spec +++ b/dlls/win32u/win32u.spec @@ -995,7 +995,7 @@ @ stub NtUserGetSharedWindowData @ stub NtUserGetSystemDpiForProcess @ stub NtUserGetSystemMenu -@ stub NtUserGetThreadDesktop +@ stdcall -syscall NtUserGetThreadDesktop(long) @ stub NtUserGetThreadState @ stub NtUserGetTitleBarInfo @ stub NtUserGetTopLevelWindow diff --git a/dlls/win32u/winstation.c b/dlls/win32u/winstation.c index 3b0df303821..54046c646c0 100644 --- a/dlls/win32u/winstation.c +++ b/dlls/win32u/winstation.c @@ -90,3 +90,19 @@ BOOL WINAPI NtUserCloseDesktop( HDESK handle ) SERVER_END_REQ; return ret; } + +/*********************************************************************** + * NtUserGetThreadDesktop (win32u.@) + */ +HDESK WINAPI NtUserGetThreadDesktop( DWORD thread ) +{ + HDESK ret = 0; + + SERVER_START_REQ( get_thread_desktop ) + { + req->tid = thread; + if (!wine_server_call_err( req )) ret = wine_server_ptr_handle( reply->handle ); + } + SERVER_END_REQ; + return ret; +} diff --git a/dlls/wow64win/syscall.h b/dlls/wow64win/syscall.h index ebb88f7013d..3f01ce4f192 100644 --- a/dlls/wow64win/syscall.h +++ b/dlls/wow64win/syscall.h @@ -84,6 +84,7 @@ SYSCALL_ENTRY( NtUserCloseDesktop ) \ SYSCALL_ENTRY( NtUserCloseWindowStation ) \ SYSCALL_ENTRY( NtUserGetProcessWindowStation ) \ + SYSCALL_ENTRY( NtUserGetThreadDesktop ) \ SYSCALL_ENTRY( NtUserSetProcessWindowStation ) #endif /* __WOW64WIN_SYSCALL_H */ diff --git a/dlls/wow64win/user.c b/dlls/wow64win/user.c index 60fd8921b81..93e31ad89a1 100644 --- a/dlls/wow64win/user.c +++ b/dlls/wow64win/user.c @@ -52,3 +52,10 @@ NTSTATUS WINAPI wow64_NtUserCloseDesktop( UINT *args ) return NtUserCloseDesktop( handle ); } + +NTSTATUS WINAPI wow64_NtUserGetThreadDesktop( UINT *args ) +{ + DWORD thread = get_ulong( &args ); + + return HandleToUlong( NtUserGetThreadDesktop( thread )); +} diff --git a/include/ntuser.h b/include/ntuser.h index f791af40232..5d7f22c47d6 100644 --- a/include/ntuser.h +++ b/include/ntuser.h @@ -25,6 +25,7 @@ BOOL WINAPI NtUserCloseDesktop( HDESK handle ); BOOL WINAPI NtUserCloseWindowStation( HWINSTA handle ); HWINSTA WINAPI NtUserGetProcessWindowStation(void); +HDESK WINAPI NtUserGetThreadDesktop( DWORD thread ); BOOL WINAPI NtUserSetProcessWindowStation( HWINSTA handle ); #endif /* _NTUSER_ */
1
0
0
0
Jacek Caban : win32u: Move NtUserCloseDesktop implementation from user32.
by Alexandre Julliard
13 Oct '21
13 Oct '21
Module: wine Branch: master Commit: ccf00c6d954f1f08fa371c211f8d42473f772e51 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=ccf00c6d954f1f08fa371c21…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Oct 13 14:53:36 2021 +0200 win32u: Move NtUserCloseDesktop implementation from user32. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/user32/message.c | 2 +- dlls/user32/user32.spec | 2 +- dlls/user32/winstation.c | 16 ---------------- dlls/win32u/syscall.c | 1 + dlls/win32u/win32u.spec | 2 +- dlls/win32u/winstation.c | 15 +++++++++++++++ dlls/wow64win/syscall.h | 1 + dlls/wow64win/user.c | 7 +++++++ include/ntuser.h | 1 + 9 files changed, 28 insertions(+), 19 deletions(-) diff --git a/dlls/user32/message.c b/dlls/user32/message.c index 7e6b660b8af..e5ea0735ed2 100644 --- a/dlls/user32/message.c +++ b/dlls/user32/message.c @@ -4321,7 +4321,7 @@ static BOOL CALLBACK bcast_desktop( LPWSTR desktop, LPARAM lp ) } ret = EnumDesktopWindows( hdesktop, bcast_childwindow, lp ); - CloseDesktop(hdesktop); + NtUserCloseDesktop( hdesktop ); TRACE("-->%d\n", ret); return parm->success; } diff --git a/dlls/user32/user32.spec b/dlls/user32/user32.spec index 19bf5ce1b8e..7686e4ed14d 100644 --- a/dlls/user32/user32.spec +++ b/dlls/user32/user32.spec @@ -74,7 +74,7 @@ @ stdcall ClientToScreen(long ptr) @ stdcall ClipCursor(ptr) @ stdcall CloseClipboard() -@ stdcall CloseDesktop(long) +@ stdcall CloseDesktop(long) NtUserCloseDesktop @ stdcall CloseTouchInputHandle(long) @ stdcall CloseWindow(long) @ stdcall CloseWindowStation(long) NtUserCloseWindowStation diff --git a/dlls/user32/winstation.c b/dlls/user32/winstation.c index 37ae9e9ceb2..1f847ca8b8f 100644 --- a/dlls/user32/winstation.c +++ b/dlls/user32/winstation.c @@ -357,22 +357,6 @@ HDESK WINAPI OpenDesktopW( LPCWSTR name, DWORD flags, BOOL inherit, ACCESS_MASK } -/*********************************************************************** - * CloseDesktop (USER32.@) - */ -BOOL WINAPI CloseDesktop( HDESK handle ) -{ - BOOL ret; - SERVER_START_REQ( close_desktop ) - { - req->handle = wine_server_obj_handle( handle ); - ret = !wine_server_call_err( req ); - } - SERVER_END_REQ; - return ret; -} - - /****************************************************************************** * GetThreadDesktop (USER32.@) */ diff --git a/dlls/win32u/syscall.c b/dlls/win32u/syscall.c index 132c55117a7..2f4269104dd 100644 --- a/dlls/win32u/syscall.c +++ b/dlls/win32u/syscall.c @@ -94,6 +94,7 @@ static void * const syscalls[] = NtGdiSetVirtualResolution, NtGdiSwapBuffers, NtGdiTransformPoints, + NtUserCloseDesktop, NtUserCloseWindowStation, NtUserGetProcessWindowStation, NtUserSetProcessWindowStation, diff --git a/dlls/win32u/win32u.spec b/dlls/win32u/win32u.spec index 24625316f9e..69a48236d84 100644 --- a/dlls/win32u/win32u.spec +++ b/dlls/win32u/win32u.spec @@ -794,7 +794,7 @@ @ stub NtUserClearForeground @ stub NtUserClipCursor @ stub NtUserCloseClipboard -@ stub NtUserCloseDesktop +@ stdcall -syscall NtUserCloseDesktop(long) @ stdcall -syscall NtUserCloseWindowStation(long) @ stub NtUserCompositionInputSinkLuidFromPoint @ stub NtUserCompositionInputSinkViewInstanceIdFromPoint diff --git a/dlls/win32u/winstation.c b/dlls/win32u/winstation.c index 153a83e313d..3b0df303821 100644 --- a/dlls/win32u/winstation.c +++ b/dlls/win32u/winstation.c @@ -75,3 +75,18 @@ BOOL WINAPI NtUserSetProcessWindowStation( HWINSTA handle ) SERVER_END_REQ; return ret; } + +/*********************************************************************** + * NtUserCloseDesktop (win32u.@) + */ +BOOL WINAPI NtUserCloseDesktop( HDESK handle ) +{ + BOOL ret; + SERVER_START_REQ( close_desktop ) + { + req->handle = wine_server_obj_handle( handle ); + ret = !wine_server_call_err( req ); + } + SERVER_END_REQ; + return ret; +} diff --git a/dlls/wow64win/syscall.h b/dlls/wow64win/syscall.h index ccf0574c639..ebb88f7013d 100644 --- a/dlls/wow64win/syscall.h +++ b/dlls/wow64win/syscall.h @@ -81,6 +81,7 @@ SYSCALL_ENTRY( NtGdiSetVirtualResolution ) \ SYSCALL_ENTRY( NtGdiSwapBuffers ) \ SYSCALL_ENTRY( NtGdiTransformPoints ) \ + SYSCALL_ENTRY( NtUserCloseDesktop ) \ SYSCALL_ENTRY( NtUserCloseWindowStation ) \ SYSCALL_ENTRY( NtUserGetProcessWindowStation ) \ SYSCALL_ENTRY( NtUserSetProcessWindowStation ) diff --git a/dlls/wow64win/user.c b/dlls/wow64win/user.c index cf028383c21..60fd8921b81 100644 --- a/dlls/wow64win/user.c +++ b/dlls/wow64win/user.c @@ -45,3 +45,10 @@ NTSTATUS WINAPI wow64_NtUserSetProcessWindowStation( UINT *args ) return NtUserSetProcessWindowStation( handle ); } + +NTSTATUS WINAPI wow64_NtUserCloseDesktop( UINT *args ) +{ + HDESK handle = get_handle( &args ); + + return NtUserCloseDesktop( handle ); +} diff --git a/include/ntuser.h b/include/ntuser.h index eac4f0da092..f791af40232 100644 --- a/include/ntuser.h +++ b/include/ntuser.h @@ -22,6 +22,7 @@ #include <winuser.h> #include <winternl.h> +BOOL WINAPI NtUserCloseDesktop( HDESK handle ); BOOL WINAPI NtUserCloseWindowStation( HWINSTA handle ); HWINSTA WINAPI NtUserGetProcessWindowStation(void); BOOL WINAPI NtUserSetProcessWindowStation( HWINSTA handle );
1
0
0
0
Jacek Caban : win32u: Move NtUserSetProcessWindowStation implementation from user32.
by Alexandre Julliard
13 Oct '21
13 Oct '21
Module: wine Branch: master Commit: 187b3e2cdf4697f566d6f75c04ae7b7d597ea06c URL:
https://source.winehq.org/git/wine.git/?a=commit;h=187b3e2cdf4697f566d6f75c…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Oct 13 14:53:22 2021 +0200 win32u: Move NtUserSetProcessWindowStation implementation from user32. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/user32/user32.spec | 2 +- dlls/user32/user_main.c | 2 +- dlls/user32/winstation.c | 17 ----------------- dlls/win32u/syscall.c | 1 + dlls/win32u/win32u.spec | 2 +- dlls/win32u/winstation.c | 16 ++++++++++++++++ dlls/wow64win/syscall.h | 3 ++- dlls/wow64win/user.c | 7 +++++++ include/ntuser.h | 1 + 9 files changed, 30 insertions(+), 21 deletions(-) diff --git a/dlls/user32/user32.spec b/dlls/user32/user32.spec index c50740732e2..19bf5ce1b8e 100644 --- a/dlls/user32/user32.spec +++ b/dlls/user32/user32.spec @@ -692,7 +692,7 @@ @ stdcall SetProcessDefaultLayout(long) @ stdcall SetProcessDpiAwarenessContext(long) @ stdcall SetProcessDpiAwarenessInternal(long) -@ stdcall SetProcessWindowStation(long) +@ stdcall SetProcessWindowStation(long) NtUserSetProcessWindowStation @ stdcall SetProgmanWindow (long) @ stdcall SetPropA(long str long) @ stdcall SetPropW(long wstr long) diff --git a/dlls/user32/user_main.c b/dlls/user32/user_main.c index f037d1684c4..d7f320575cb 100644 --- a/dlls/user32/user_main.c +++ b/dlls/user32/user_main.c @@ -295,7 +295,7 @@ static void winstation_init(void) handle = CreateWindowStationW( winstation ? winstation : L"WinSta0", 0, WINSTA_ALL_ACCESS, NULL ); if (handle) { - SetProcessWindowStation( handle ); + NtUserSetProcessWindowStation( handle ); /* only WinSta0 is visible */ if (!winstation || !wcsicmp( winstation, L"WinSta0" )) { diff --git a/dlls/user32/winstation.c b/dlls/user32/winstation.c index 245cd6c0f40..37ae9e9ceb2 100644 --- a/dlls/user32/winstation.c +++ b/dlls/user32/winstation.c @@ -203,23 +203,6 @@ HWINSTA WINAPI OpenWindowStationW( LPCWSTR name, BOOL inherit, ACCESS_MASK acces } -/*********************************************************************** - * SetProcessWindowStation (USER32.@) - */ -BOOL WINAPI SetProcessWindowStation( HWINSTA handle ) -{ - BOOL ret; - - SERVER_START_REQ( set_process_winstation ) - { - req->handle = wine_server_obj_handle( handle ); - ret = !wine_server_call_err( req ); - } - SERVER_END_REQ; - return ret; -} - - /****************************************************************************** * EnumWindowStationsA (USER32.@) */ diff --git a/dlls/win32u/syscall.c b/dlls/win32u/syscall.c index 859dda9780d..132c55117a7 100644 --- a/dlls/win32u/syscall.c +++ b/dlls/win32u/syscall.c @@ -96,6 +96,7 @@ static void * const syscalls[] = NtGdiTransformPoints, NtUserCloseWindowStation, NtUserGetProcessWindowStation, + NtUserSetProcessWindowStation, }; static BYTE arguments[ARRAY_SIZE(syscalls)]; diff --git a/dlls/win32u/win32u.spec b/dlls/win32u/win32u.spec index 7427c8e10d0..24625316f9e 100644 --- a/dlls/win32u/win32u.spec +++ b/dlls/win32u/win32u.spec @@ -1221,7 +1221,7 @@ @ stub NtUserSetProcessMousewheelRoutingMode @ stub NtUserSetProcessRestrictionExemption @ stub NtUserSetProcessUIAccessZorder -@ stub NtUserSetProcessWindowStation +@ stdcall -syscall NtUserSetProcessWindowStation(long) @ stub NtUserSetProp @ stub NtUserSetScrollInfo @ stub NtUserSetSensorPresence diff --git a/dlls/win32u/winstation.c b/dlls/win32u/winstation.c index 3a6ef8059b4..153a83e313d 100644 --- a/dlls/win32u/winstation.c +++ b/dlls/win32u/winstation.c @@ -59,3 +59,19 @@ HWINSTA WINAPI NtUserGetProcessWindowStation(void) SERVER_END_REQ; return ret; } + +/*********************************************************************** + * NtUserSetProcessWindowStation (win32u.@) + */ +BOOL WINAPI NtUserSetProcessWindowStation( HWINSTA handle ) +{ + BOOL ret; + + SERVER_START_REQ( set_process_winstation ) + { + req->handle = wine_server_obj_handle( handle ); + ret = !wine_server_call_err( req ); + } + SERVER_END_REQ; + return ret; +} diff --git a/dlls/wow64win/syscall.h b/dlls/wow64win/syscall.h index 0a905e131d8..ccf0574c639 100644 --- a/dlls/wow64win/syscall.h +++ b/dlls/wow64win/syscall.h @@ -82,6 +82,7 @@ SYSCALL_ENTRY( NtGdiSwapBuffers ) \ SYSCALL_ENTRY( NtGdiTransformPoints ) \ SYSCALL_ENTRY( NtUserCloseWindowStation ) \ - SYSCALL_ENTRY( NtUserGetProcessWindowStation ) + SYSCALL_ENTRY( NtUserGetProcessWindowStation ) \ + SYSCALL_ENTRY( NtUserSetProcessWindowStation ) #endif /* __WOW64WIN_SYSCALL_H */ diff --git a/dlls/wow64win/user.c b/dlls/wow64win/user.c index 56156e6fdeb..cf028383c21 100644 --- a/dlls/wow64win/user.c +++ b/dlls/wow64win/user.c @@ -38,3 +38,10 @@ NTSTATUS WINAPI wow64_NtUserGetProcessWindowStation( UINT *args ) { return HandleToUlong( NtUserGetProcessWindowStation() ); } + +NTSTATUS WINAPI wow64_NtUserSetProcessWindowStation( UINT *args ) +{ + HWINSTA handle = get_handle( &args ); + + return NtUserSetProcessWindowStation( handle ); +} diff --git a/include/ntuser.h b/include/ntuser.h index 7ea4ccd4bdf..eac4f0da092 100644 --- a/include/ntuser.h +++ b/include/ntuser.h @@ -24,5 +24,6 @@ BOOL WINAPI NtUserCloseWindowStation( HWINSTA handle ); HWINSTA WINAPI NtUserGetProcessWindowStation(void); +BOOL WINAPI NtUserSetProcessWindowStation( HWINSTA handle ); #endif /* _NTUSER_ */
1
0
0
0
← Newer
1
...
65
66
67
68
69
70
71
...
117
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
Results per page:
10
25
50
100
200