wine-commits February 2021

wine-commits@winehq.org

2 participants
915 discussions

Zebediah Figura : vkd3d-shader: Implement hlsl_note().
by Alexandre Julliard 23 Feb '21

23 Feb '21

Module: vkd3d Branch: master Commit: 87a371292d7cdb5b7eb2159b49c24d3fdfb4c2e6 URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=87a371292d7cdb5b7eb2159… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Sun Feb 21 22:04:38 2021 -0600 vkd3d-shader: Implement hlsl_note(). Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- libs/vkd3d-shader/hlsl.c | 6 +++++- libs/vkd3d-shader/vkd3d_shader_main.c | 20 ++++++++++++++++++++ libs/vkd3d-shader/vkd3d_shader_private.h | 2 ++ 3 files changed, 27 insertions(+), 1 deletion(-) diff --git a/libs/vkd3d-shader/hlsl.c b/libs/vkd3d-shader/hlsl.c index dbc6954..52b3dd1 100644 --- a/libs/vkd3d-shader/hlsl.c +++ b/libs/vkd3d-shader/hlsl.c @@ -23,7 +23,11 @@ void hlsl_note(struct hlsl_ctx *ctx, const struct vkd3d_shader_location loc, enum vkd3d_shader_log_level level, const char *fmt, ...) { - /* FIXME */ + va_list args; + + va_start(args, fmt); + vkd3d_shader_vnote(ctx->message_context, &loc, level, fmt, args); + va_end(args); } void hlsl_error(struct hlsl_ctx *ctx, const struct vkd3d_shader_location loc, diff --git a/libs/vkd3d-shader/vkd3d_shader_main.c b/libs/vkd3d-shader/vkd3d_shader_main.c index 6f1482a..bae2852 100644 --- a/libs/vkd3d-shader/vkd3d_shader_main.c +++ b/libs/vkd3d-shader/vkd3d_shader_main.c @@ -144,6 +144,26 @@ bool vkd3d_shader_message_context_copy_messages(struct vkd3d_shader_message_cont return true; } +void vkd3d_shader_vnote(struct vkd3d_shader_message_context *context, const struct vkd3d_shader_location *location, + enum vkd3d_shader_log_level level, const char *format, va_list args) +{ + if (context->log_level < level) + return; + + if (location) + { + const char *source_name = location->source_name ? location->source_name : "<anonymous>"; + + if (location->line) + vkd3d_string_buffer_printf(&context->messages, "%s:%u:%u: ", + source_name, location->line, location->column); + else + vkd3d_string_buffer_printf(&context->messages, "%s: ", source_name); + } + vkd3d_string_buffer_vprintf(&context->messages, format, args); + vkd3d_string_buffer_printf(&context->messages, "\n"); +} + void vkd3d_shader_vwarning(struct vkd3d_shader_message_context *context, const struct vkd3d_shader_location *location, enum vkd3d_shader_error error, const char *format, va_list args) { diff --git a/libs/vkd3d-shader/vkd3d_shader_private.h b/libs/vkd3d-shader/vkd3d_shader_private.h index 2d7eb05..e837dbc 100644 --- a/libs/vkd3d-shader/vkd3d_shader_private.h +++ b/libs/vkd3d-shader/vkd3d_shader_private.h @@ -906,6 +906,8 @@ void vkd3d_shader_error(struct vkd3d_shader_message_context *context, const stru enum vkd3d_shader_error error, const char *format, ...) VKD3D_PRINTF_FUNC(4, 5) DECLSPEC_HIDDEN; void vkd3d_shader_verror(struct vkd3d_shader_message_context *context, const struct vkd3d_shader_location *location, enum vkd3d_shader_error error, const char *format, va_list args) DECLSPEC_HIDDEN; +void vkd3d_shader_vnote(struct vkd3d_shader_message_context *context, const struct vkd3d_shader_location *location, + enum vkd3d_shader_log_level level, const char *format, va_list args) DECLSPEC_HIDDEN; void vkd3d_shader_vwarning(struct vkd3d_shader_message_context *context, const struct vkd3d_shader_location *location, enum vkd3d_shader_error error, const char *format, va_list args) DECLSPEC_HIDDEN;

1 0

Zebediah Figura : vkd3d-shader: Replace hlsl_message() with hlsl_error().
by Alexandre Julliard 23 Feb '21

23 Feb '21

Module: vkd3d Branch: master Commit: 7069fa1c40f8762581336b57b06f0f41c5ca6161 URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=7069fa1c40f8762581336b5… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Sun Feb 21 22:04:37 2021 -0600 vkd3d-shader: Replace hlsl_message() with hlsl_error(). Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- libs/vkd3d-shader/hlsl.c | 5 ----- libs/vkd3d-shader/hlsl.h | 2 -- libs/vkd3d-shader/hlsl.y | 4 +++- 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/libs/vkd3d-shader/hlsl.c b/libs/vkd3d-shader/hlsl.c index 1f9a392..dbc6954 100644 --- a/libs/vkd3d-shader/hlsl.c +++ b/libs/vkd3d-shader/hlsl.c @@ -20,11 +20,6 @@ #include "hlsl.h" #include <stdio.h> -void hlsl_message(const char *fmt, ...) -{ - /* FIXME */ -} - void hlsl_note(struct hlsl_ctx *ctx, const struct vkd3d_shader_location loc, enum vkd3d_shader_log_level level, const char *fmt, ...) { diff --git a/libs/vkd3d-shader/hlsl.h b/libs/vkd3d-shader/hlsl.h index 9122b09..a374f54 100644 --- a/libs/vkd3d-shader/hlsl.h +++ b/libs/vkd3d-shader/hlsl.h @@ -544,8 +544,6 @@ struct hlsl_ir_var *hlsl_new_var(const char *name, struct hlsl_type *type, const const struct hlsl_reg_reservation *reg_reservation) DECLSPEC_HIDDEN; struct hlsl_ir_load *hlsl_new_var_load(struct hlsl_ir_var *var, const struct vkd3d_shader_location loc) DECLSPEC_HIDDEN; -void hlsl_message(const char *fmt, ...) VKD3D_PRINTF_FUNC(1,2) DECLSPEC_HIDDEN; - void hlsl_error(struct hlsl_ctx *ctx, const struct vkd3d_shader_location loc, enum vkd3d_shader_error error, const char *fmt, ...) VKD3D_PRINTF_FUNC(4, 5) DECLSPEC_HIDDEN; void hlsl_warning(struct hlsl_ctx *ctx, const struct vkd3d_shader_location loc, enum vkd3d_shader_error error, diff --git a/libs/vkd3d-shader/hlsl.y b/libs/vkd3d-shader/hlsl.y index b6d0324..ea640b9 100644 --- a/libs/vkd3d-shader/hlsl.y +++ b/libs/vkd3d-shader/hlsl.y @@ -3110,7 +3110,9 @@ int hlsl_parser_compile(struct hlsl_ctx *ctx, const char *entrypoint) if (!(entry_func = get_func_entry(ctx, entrypoint))) { - hlsl_message("error: entry point \"%s\" is not defined\n", entrypoint); + const struct vkd3d_shader_location loc = {.source_name = ctx->location.source_name}; + + hlsl_error(ctx, loc, VKD3D_SHADER_ERROR_HLSL_NOT_DEFINED, "Entry point \"%s\" is not defined.", entrypoint); return VKD3D_ERROR_INVALID_SHADER; }

1 0

Zebediah Figura : vkd3d-shader: Implement hlsl_error() and hlsl_warning().
by Alexandre Julliard 23 Feb '21

23 Feb '21

Module: vkd3d Branch: master Commit: 6124aa664fc3aa45f4f39732b1ea66b25ef88d00 URL: https://source.winehq.org/git/vkd3d.git/?a=commit;h=6124aa664fc3aa45f4f3973… Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Sun Feb 21 22:04:36 2021 -0600 vkd3d-shader: Implement hlsl_error() and hlsl_warning(). Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- Makefile.am | 1 - libs/vkd3d-shader/hlsl.c | 18 ++- libs/vkd3d-shader/hlsl.h | 8 +- libs/vkd3d-shader/hlsl.l | 3 +- libs/vkd3d-shader/hlsl.y | 204 +++++++++++++++++-------------- libs/vkd3d-shader/vkd3d_shader_private.h | 18 +++ 6 files changed, 147 insertions(+), 105 deletions(-) Diff: https://source.winehq.org/git/vkd3d.git/?a=commitdiff;h=6124aa664fc3aa45f4f…

1 0

Gijs Vermeulen : msvcirt: Implement remainder of fstream class.
by Alexandre Julliard 22 Feb '21

22 Feb '21

Module: wine Branch: master Commit: 4981785f0fbcafbdc6a9dc4f71d06b137d558597 URL: https://source.winehq.org/git/wine.git/?a=commit;h=4981785f0fbcafbdc6a9dc4f… Author: Gijs Vermeulen <gijsvrm(a)gmail.com> Date: Sun Feb 21 18:05:02 2021 +0100 msvcirt: Implement remainder of fstream class. Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Gijs Vermeulen <gijsvrm(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcirt/msvcirt.c | 157 +++++++++++++++++ dlls/msvcirt/msvcirt.spec | 52 +++--- dlls/msvcirt/tests/msvcirt.c | 397 ++++++++++++++++++++++++++++++++++++++++++- dlls/msvcrt20/msvcrt20.spec | 52 +++--- dlls/msvcrt40/msvcrt40.spec | 52 +++--- 5 files changed, 625 insertions(+), 85 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=4981785f0fbcafbdc6a9…

1 0

Zhiyi Zhang : uxtheme: Remove unused code.
by Alexandre Julliard 22 Feb '21

22 Feb '21

Module: wine Branch: master Commit: c6b100ef98a48585214b501aa93b2cc5c46f1057 URL: https://source.winehq.org/git/wine.git/?a=commit;h=c6b100ef98a48585214b501a… Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Mon Feb 22 22:33:08 2021 +0800 uxtheme: Remove unused code. Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/uxtheme/buffer.c | 2 -- dlls/uxtheme/msstyles.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/dlls/uxtheme/buffer.c b/dlls/uxtheme/buffer.c index b07284f8e06..f159d5c1be0 100644 --- a/dlls/uxtheme/buffer.c +++ b/dlls/uxtheme/buffer.c @@ -52,8 +52,6 @@ static void free_paintbuffer(struct paintbuffer *buffer) static struct paintbuffer *get_buffer_obj(HPAINTBUFFER handle) { - if (!handle) - return NULL; return handle; } diff --git a/dlls/uxtheme/msstyles.c b/dlls/uxtheme/msstyles.c index cd7677e5783..ed22d923250 100644 --- a/dlls/uxtheme/msstyles.c +++ b/dlls/uxtheme/msstyles.c @@ -46,8 +46,6 @@ static BOOL MSSTYLES_GetNextToken(LPCWSTR lpStringStart, LPCWSTR lpStringEnd, LP static void MSSTYLES_ParseThemeIni(PTHEME_FILE tf, BOOL setMetrics); static HRESULT MSSTYLES_GetFont (LPCWSTR lpStringStart, LPCWSTR lpStringEnd, LPCWSTR *lpValEnd, LOGFONTW* logfont); -extern int alphaBlendMode; - #define MSSTYLES_VERSION 0x0003 static PTHEME_FILE tfActiveTheme;

1 0

Zhiyi Zhang : uxtheme: Support DTT_FONTPROP for DrawThemeTextEx().
by Alexandre Julliard 22 Feb '21

22 Feb '21

Module: wine Branch: master Commit: 300ecff14545a508d42f97406c5ba5130a5d9c76 URL: https://source.winehq.org/git/wine.git/?a=commit;h=300ecff14545a508d42f9740… Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Mon Feb 22 22:32:56 2021 +0800 uxtheme: Support DTT_FONTPROP for DrawThemeTextEx(). Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/uxtheme/draw.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/dlls/uxtheme/draw.c b/dlls/uxtheme/draw.c index 023b2dfd61b..8c3c4ae2218 100644 --- a/dlls/uxtheme/draw.c +++ b/dlls/uxtheme/draw.c @@ -1660,6 +1660,7 @@ HRESULT WINAPI DrawThemeTextEx(HTHEME hTheme, HDC hdc, int iPartId, int iStateId COLORREF textColor; COLORREF oldTextColor; int oldBkMode; + int fontProp; TRACE("%p %p %d %d %s:%d 0x%08x %p %p\n", hTheme, hdc, iPartId, iStateId, debugstr_wn(pszText, iCharCount), iCharCount, flags, rect, options); @@ -1667,10 +1668,15 @@ HRESULT WINAPI DrawThemeTextEx(HTHEME hTheme, HDC hdc, int iPartId, int iStateId if(!hTheme) return E_HANDLE; - if (options->dwFlags & ~DTT_TEXTCOLOR) + if (options->dwFlags & ~(DTT_TEXTCOLOR | DTT_FONTPROP)) FIXME("unsupported flags 0x%08x\n", options->dwFlags); - - hr = GetThemeFont(hTheme, hdc, iPartId, iStateId, TMT_FONT, &logfont); + + if (options->dwFlags & DTT_FONTPROP) + fontProp = options->iFontPropId; + else + fontProp = TMT_FONT; + + hr = GetThemeFont(hTheme, hdc, iPartId, iStateId, fontProp, &logfont); if(SUCCEEDED(hr)) { hFont = CreateFontIndirectW(&logfont); if(!hFont)

1 0

Zhiyi Zhang : uxtheme: Support more font properties.
by Alexandre Julliard 22 Feb '21

22 Feb '21

Module: wine Branch: master Commit: a18df3a412095344ffdc65d21c6198d858be960a URL: https://source.winehq.org/git/wine.git/?a=commit;h=a18df3a412095344ffdc65d2… Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Mon Feb 22 22:32:44 2021 +0800 uxtheme: Support more font properties. Add support for TMT_HEADING1FONT, TMT_HEADING2FONT and TMT_BODYFONT. TMT_BODYFONT is used by Command Links. Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/uxtheme/stylemap.c | 3 +++ include/tmschema.h | 5 ++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/dlls/uxtheme/stylemap.c b/dlls/uxtheme/stylemap.c index 1949028581c..20ed1305da8 100644 --- a/dlls/uxtheme/stylemap.c +++ b/dlls/uxtheme/stylemap.c @@ -83,6 +83,9 @@ static const MSSTYLES_PROPERTY_MAP mapProperty[] = { {TMT_FONT, TMT_STATUSFONT, L"STATUSFONT"}, {TMT_FONT, TMT_MSGBOXFONT, L"MSGBOXFONT"}, {TMT_FONT, TMT_ICONTITLEFONT, L"ICONTITLEFONT"}, + {TMT_FONT, TMT_HEADING1FONT, L"HEADING1FONT"}, + {TMT_FONT, TMT_HEADING2FONT, L"HEADING2FONT"}, + {TMT_FONT, TMT_BODYFONT, L"BODYFONT"}, {TMT_BOOL, TMT_FLATMENUS, L"FLATMENUS"}, {TMT_SIZE, TMT_SIZINGBORDERWIDTH, L"SIZINGBORDERWIDTH"}, {TMT_SIZE, TMT_SCROLLBARWIDTH, L"SCROLLBARWIDTH"}, diff --git a/include/tmschema.h b/include/tmschema.h index 15afc48d5cc..2d2eccce11e 100644 --- a/include/tmschema.h +++ b/include/tmschema.h @@ -188,8 +188,11 @@ BEGIN_TM_PROPS() TM_PROP(804, TMT, STATUSFONT, FONT) TM_PROP(805, TMT, MSGBOXFONT, FONT) TM_PROP(806, TMT, ICONTITLEFONT, FONT) + TM_PROP(807, TMT, HEADING1FONT, FONT) + TM_PROP(808, TMT, HEADING2FONT, FONT) + TM_PROP(809, TMT, BODYFONT, FONT) # define TMT_FIRSTFONT TMT_CAPTIONFONT -# define TMT_LASTFONT TMT_ICONTITLEFONT +# define TMT_LASTFONT TMT_BODYFONT /* Bool theme metric properties */ TM_PROP(1001, TMT, FLATMENUS, BOOL)

1 0

Zhiyi Zhang : uxtheme: Add Command Link part and state definitions.
by Alexandre Julliard 22 Feb '21

22 Feb '21

Module: wine Branch: master Commit: 061ac08d6b5710db43cccaba3226c0d185e8ff6f URL: https://source.winehq.org/git/wine.git/?a=commit;h=061ac08d6b5710db43cccaba… Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Mon Feb 22 22:32:36 2021 +0800 uxtheme: Add Command Link part and state definitions. Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/uxtheme/stylemap.c | 13 +++++++++++++ include/tmschema.h | 21 +++++++++++++++++++++ 2 files changed, 34 insertions(+) diff --git a/dlls/uxtheme/stylemap.c b/dlls/uxtheme/stylemap.c index b38b18b623d..1949028581c 100644 --- a/dlls/uxtheme/stylemap.c +++ b/dlls/uxtheme/stylemap.c @@ -374,6 +374,19 @@ static const MSSTYLES_CLASS_MAP classButton[] = { {BP_RADIOBUTTON, GBS_NORMAL, L"NORMAL"}, {BP_RADIOBUTTON, GBS_DISABLED, L"DISABLED"}, {BP_USERBUTTON, 0, L"USERBUTTON"}, + {BP_COMMANDLINK, 0, L"COMMANDLINK"}, + {BP_COMMANDLINK, CMDLS_NORMAL, L"NORMAL"}, + {BP_COMMANDLINK, CMDLS_HOT, L"HOT"}, + {BP_COMMANDLINK, CMDLS_PRESSED, L"PRESSED"}, + {BP_COMMANDLINK, CMDLS_DISABLED, L"DISABLED"}, + {BP_COMMANDLINK, CMDLS_DEFAULTED, L"DEFAULTED"}, + {BP_COMMANDLINK, CMDLS_DEFAULTED_ANIMATING, L"DEFAULTED_ANIMATING"}, + {BP_COMMANDLINKGLYPH, 0, L"COMMANDLINKGLYPH"}, + {BP_COMMANDLINKGLYPH, CMDLGS_NORMAL, L"NORMAL"}, + {BP_COMMANDLINKGLYPH, CMDLGS_HOT, L"HOT"}, + {BP_COMMANDLINKGLYPH, CMDLGS_PRESSED, L"PRESSED"}, + {BP_COMMANDLINKGLYPH, CMDLGS_DISABLED, L"DISABLED"}, + {BP_COMMANDLINKGLYPH, CMDLGS_DEFAULTED, L"DEFAULTED"}, {0, 0, L""} }; diff --git a/include/tmschema.h b/include/tmschema.h index 910de19e2a6..15afc48d5cc 100644 --- a/include/tmschema.h +++ b/include/tmschema.h @@ -411,6 +411,8 @@ BEGIN_TM_CLASS_PARTS(BUTTON) TM_PART(3, BP, CHECKBOX) TM_PART(4, BP, GROUPBOX) TM_PART(5, BP, USERBUTTON) + TM_PART(6, BP, COMMANDLINK) + TM_PART(7, BP, COMMANDLINKGLYPH) END_TM_CLASS_PARTS() /* BUTTON - PUSHBUTTON states */ @@ -456,6 +458,25 @@ BEGIN_TM_PART_STATES(GROUPBOX) TM_STATE(2, GBS, DISABLED) END_TM_PART_STATES() +/* BUTTON - COMMANDLINK states */ +BEGIN_TM_PART_STATES(COMMANDLINK) + TM_STATE(1, CMDLS, NORMAL) + TM_STATE(2, CMDLS, HOT) + TM_STATE(3, CMDLS, PRESSED) + TM_STATE(4, CMDLS, DISABLED) + TM_STATE(5, CMDLS, DEFAULTED) + TM_STATE(6, CMDLS, DEFAULTED_ANIMATING) +END_TM_PART_STATES() + +/* BUTTON - COMMANDLINKGLYPH states */ +BEGIN_TM_PART_STATES(COMMANDLINKGLYPH) + TM_STATE(1, CMDLGS, NORMAL) + TM_STATE(2, CMDLGS, HOT) + TM_STATE(3, CMDLGS, PRESSED) + TM_STATE(4, CMDLGS, DISABLED) + TM_STATE(5, CMDLGS, DEFAULTED) +END_TM_PART_STATES() + /* CLOCK parts */ BEGIN_TM_CLASS_PARTS(CLOCK) TM_PART(1, CLP, TIME)

1 0

Zhiyi Zhang : comctl32/button: Turn off themed painting if parts are unavailable for Command Links.
by Alexandre Julliard 22 Feb '21

22 Feb '21

Module: wine Branch: master Commit: b08c622e22428effc4c0e47446a06e12d3532f40 URL: https://source.winehq.org/git/wine.git/?a=commit;h=b08c622e22428effc4c0e474… Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Mon Feb 22 22:32:28 2021 +0800 comctl32/button: Turn off themed painting if parts are unavailable for Command Links. Themed painting for Command Links requires BP_COMMANDLINK and BP_COMMANDLINKGLYPH to be defined in the theme. However, Wine currently only supports the v3 theme file format used by XP, which doesn't support Command Links. So turn off themed painting for Command Links if user uses a third party theme that doesn't have the required parts. Otherwise, only plain text is drawn. Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/comctl32/button.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/dlls/comctl32/button.c b/dlls/comctl32/button.c index 67bf5ceae48..0dcbb38d202 100644 --- a/dlls/comctl32/button.c +++ b/dlls/comctl32/button.c @@ -276,6 +276,20 @@ static LONG get_default_glyph_size(const BUTTON_INFO *infoPtr) return GetSystemMetrics(SM_CYMENUCHECK); } +static BOOL is_themed_paint_supported(HTHEME theme, UINT btn_type) +{ + if (!theme || !btnThemedPaintFunc[btn_type]) + return FALSE; + + if (btn_type == BS_COMMANDLINK || btn_type == BS_DEFCOMMANDLINK) + { + if (!IsThemePartDefined(theme, BP_COMMANDLINK, 0)) + return FALSE; + } + + return TRUE; +} + static void init_custom_draw(NMCUSTOMDRAW *nmcd, const BUTTON_INFO *infoPtr, HDC hdc, const RECT *rc) { nmcd->hdr.hwndFrom = infoPtr->hwnd; @@ -548,7 +562,7 @@ static LRESULT CALLBACK BUTTON_WindowProc(HWND hWnd, UINT uMsg, WPARAM wParam, L theme = GetWindowTheme( hWnd ); hdc = wParam ? (HDC)wParam : BeginPaint( hWnd, &ps ); - if (theme && btnThemedPaintFunc[btn_type]) + if (is_themed_paint_supported(theme, btn_type)) { int drawState = get_draw_state(infoPtr); UINT dtflags = BUTTON_BStoDT(style, GetWindowLongW(hWnd, GWL_EXSTYLE));

1 0

Zhiyi Zhang : comctl32/theme_scrollbar: Remove an unused variable.
by Alexandre Julliard 22 Feb '21

22 Feb '21

Module: wine Branch: master Commit: d9b47aa303705c61c0b469363c5dfd05d2e34b11 URL: https://source.winehq.org/git/wine.git/?a=commit;h=d9b47aa303705c61c0b46936… Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Mon Feb 22 22:32:21 2021 +0800 comctl32/theme_scrollbar: Remove an unused variable. Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/comctl32/theme_scrollbar.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/dlls/comctl32/theme_scrollbar.c b/dlls/comctl32/theme_scrollbar.c index bb42267bf21..27d31bd4ac5 100644 --- a/dlls/comctl32/theme_scrollbar.c +++ b/dlls/comctl32/theme_scrollbar.c @@ -334,16 +334,12 @@ static void paint_scrollbar(HWND hwnd, HTHEME theme) DrawThemeBackground(theme, dc, SBP_SIZEBOX, state, &r, NULL); } else { - SCROLLBARINFO sbi; SCROLLINFO si; unsigned int thumbpos, thumbsize; int uppertrackstate, lowertrackstate, thumbstate; RECT partrect, trackrect; SIZE grippersize; - sbi.cbSize = sizeof(sbi); - GetScrollBarInfo(hwnd, OBJID_CLIENT, &sbi); - si.cbSize = sizeof(si); si.fMask = SIF_ALL; GetScrollInfo(hwnd, SB_CTL, &si);

1 0

← Newer
1
...
17
18
19
20
21
22
23
...
92
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits February 2021