winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
April 2021
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
865 discussions
Start a n
N
ew thread
Jacek Caban : jscript: Support non-extensible objects.
by Alexandre Julliard
01 Apr '21
01 Apr '21
Module: wine Branch: master Commit: 7750753758693cbd09b978dfb53557c3b0715335 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=7750753758693cbd09b978df…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Apr 1 18:18:40 2021 +0200 jscript: Support non-extensible objects. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/jscript/dispex.c | 12 +++++++++--- dlls/jscript/jscript.h | 1 + dlls/jscript/object.c | 3 ++- dlls/mshtml/tests/es5.js | 8 +++++++- 4 files changed, 19 insertions(+), 5 deletions(-) diff --git a/dlls/jscript/dispex.c b/dlls/jscript/dispex.c index 0f0907063f8..303e5bb8c99 100644 --- a/dlls/jscript/dispex.c +++ b/dlls/jscript/dispex.c @@ -474,6 +474,8 @@ static HRESULT prop_put(jsdisp_t *This, dispex_prop_t *prop, jsval_t val) return prop->u.p->setter(This->ctx, This, val); case PROP_PROTREF: case PROP_DELETED: + if(!This->extensible) + return S_OK; prop->type = PROP_JSVAL; prop->flags = PROPF_ENUMERABLE | PROPF_CONFIGURABLE | PROPF_WRITABLE; prop->u.val = jsval_undefined(); @@ -1747,6 +1749,7 @@ HRESULT init_dispex(jsdisp_t *dispex, script_ctx_t *ctx, const builtin_info_t *b dispex->IDispatchEx_iface.lpVtbl = &DispatchExVtbl; dispex->ref = 1; dispex->builtin_info = builtin_info; + dispex->extensible = TRUE; dispex->props = heap_alloc_zero(sizeof(dispex_prop_t)*(dispex->buf_size=4)); if(!dispex->props) @@ -1894,7 +1897,7 @@ HRESULT jsdisp_get_id(jsdisp_t *jsdisp, const WCHAR *name, DWORD flags, DISPID * dispex_prop_t *prop; HRESULT hres; - if(flags & fdexNameEnsure) + if(jsdisp->extensible && (flags & fdexNameEnsure)) hres = ensure_prop_name(jsdisp, name, PROPF_ENUMERABLE | PROPF_CONFIGURABLE | PROPF_WRITABLE, &prop); else @@ -2147,8 +2150,11 @@ HRESULT jsdisp_propput(jsdisp_t *obj, const WCHAR *name, DWORD flags, jsval_t va dispex_prop_t *prop; HRESULT hres; - hres = ensure_prop_name(obj, name, flags, &prop); - if(FAILED(hres)) + if(obj->extensible) + hres = ensure_prop_name(obj, name, flags, &prop); + else + hres = find_prop_name_prot(obj, string_hash(name), name, &prop); + if(FAILED(hres) || !prop) return hres; return prop_put(obj, prop, val); diff --git a/dlls/jscript/jscript.h b/dlls/jscript/jscript.h index c8ec7622caf..f27f660d802 100644 --- a/dlls/jscript/jscript.h +++ b/dlls/jscript/jscript.h @@ -247,6 +247,7 @@ struct jsdisp_t { DWORD prop_cnt; dispex_prop_t *props; script_ctx_t *ctx; + BOOL extensible; jsdisp_t *prototype; diff --git a/dlls/jscript/object.c b/dlls/jscript/object.c index 1e94f163446..da91b744128 100644 --- a/dlls/jscript/object.c +++ b/dlls/jscript/object.c @@ -680,7 +680,7 @@ static HRESULT Object_preventExtensions(script_ctx_t *ctx, vdisp_t *jsthis, WORD return E_NOTIMPL; } - FIXME("(%s) semi-stub\n", debugstr_jsval(argv[0])); + TRACE("(%s)\n", debugstr_jsval(argv[0])); obj = to_jsdisp(get_object(argv[0])); if(!obj) { @@ -688,6 +688,7 @@ static HRESULT Object_preventExtensions(script_ctx_t *ctx, vdisp_t *jsthis, WORD return E_NOTIMPL; } + obj->extensible = FALSE; if(r) *r = jsval_obj(jsdisp_addref(obj)); return S_OK; } diff --git a/dlls/mshtml/tests/es5.js b/dlls/mshtml/tests/es5.js index e8c523b0bf7..3eccc38fada 100644 --- a/dlls/mshtml/tests/es5.js +++ b/dlls/mshtml/tests/es5.js @@ -947,7 +947,6 @@ sync_test("preventExtensions", function() { var r = Object.preventExtensions(o); ok(r === o, "r != o"); o.x = 1; - todo_wine. ok(!("x" in o), "x property added to o"); try { Object.defineProperty(o, "y", { value: true }); @@ -960,6 +959,13 @@ sync_test("preventExtensions", function() { r = Object.preventExtensions(o); ok(r === o, "r != o"); + function Constr() {} + o = Object.preventExtensions(new Constr()); + Constr.prototype.prop = 1; + ok(o.prop === 1, "o.prop = " + o.prop); + o.prop = 2; + ok(o.prop === 1, "o.prop = " + o.prop); + ok(Object.preventExtensions.length === 1, "Object.preventExtensions.length = " + Object.preventExtensions.length); });
1
0
0
0
Jacek Caban : jscript: Get dispid and call invoke in a single step when setting a member property.
by Alexandre Julliard
01 Apr '21
01 Apr '21
Module: wine Branch: master Commit: f568b48e66dea7198afab67b81aa45bbeb575fc6 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=f568b48e66dea7198afab67b…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Apr 1 18:18:31 2021 +0200 jscript: Get dispid and call invoke in a single step when setting a member property. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/jscript/compile.c | 89 ++++++++++++++++++++++------------------------ dlls/jscript/dispex.c | 32 +++++++++++++++++ dlls/jscript/engine.c | 54 ++++++++++++++++++++++++++++ dlls/jscript/engine.h | 2 ++ dlls/jscript/jscript.h | 1 + dlls/jscript/tests/lang.js | 6 ++++ dlls/jscript/tests/run.c | 19 ++++++++++ 7 files changed, 156 insertions(+), 47 deletions(-) Diff:
https://source.winehq.org/git/wine.git/?a=commitdiff;h=f568b48e66dea7198afa…
1
0
0
0
Hugh McMaster : reg: Better indicate when a registry value is not found.
by Alexandre Julliard
01 Apr '21
01 Apr '21
Module: wine Branch: master Commit: b80da20656feda99f9c6e749f5cd6d6f3c242cd3 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=b80da20656feda99f9c6e749…
Author: Hugh McMaster <hugh.mcmaster(a)outlook.com> Date: Thu Apr 1 23:20:52 2021 +1100 reg: Better indicate when a registry value is not found. Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- po/ar.po | 3 +-- po/ast.po | 7 ++++--- po/bg.po | 7 ++++--- po/ca.po | 6 ++++-- po/cs.po | 3 +-- po/da.po | 3 +-- po/de.po | 6 ++++-- po/el.po | 6 +++--- po/en.po | 6 ++---- po/en_US.po | 6 ++---- po/eo.po | 7 ++++--- po/es.po | 6 ++++-- po/fa.po | 6 +++--- po/fi.po | 6 ++++-- po/fr.po | 6 ++++-- po/he.po | 3 +-- po/hi.po | 3 +-- po/hr.po | 3 +-- po/hu.po | 3 +-- po/it.po | 3 +-- po/ja.po | 6 ++++-- po/ko.po | 6 ++++-- po/lt.po | 6 ++++-- po/ml.po | 3 +-- po/nb_NO.po | 6 ++++-- po/nl.po | 6 ++++-- po/or.po | 3 +-- po/pa.po | 3 +-- po/pl.po | 6 ++++-- po/pt_BR.po | 6 ++++-- po/pt_PT.po | 6 ++++-- po/rm.po | 6 +++--- po/ro.po | 6 ++++-- po/ru.po | 6 ++++-- po/si.po | 7 ++++--- po/sk.po | 7 ++++--- po/sl.po | 3 +-- po/sr_RS(a)cyrillic.po | 7 ++++--- po/sr_RS(a)latin.po | 7 ++++--- po/sv.po | 6 ++++-- po/ta.po | 3 +-- po/te.po | 3 +-- po/th.po | 6 +++--- po/tr.po | 6 ++++-- po/uk.po | 6 ++++-- po/wa.po | 6 +++--- po/wine.pot | 3 +-- po/zh_CN.po | 6 ++++-- po/zh_TW.po | 3 +-- programs/reg/delete.c | 2 +- programs/reg/query.c | 2 +- programs/reg/reg.rc | 2 +- programs/reg/resource.h | 2 +- 53 files changed, 143 insertions(+), 118 deletions(-) Diff:
https://source.winehq.org/git/wine.git/?a=commitdiff;h=b80da20656feda99f9c6…
1
0
0
0
Hugh McMaster : reg: Prepend 'reg:' to two message strings.
by Alexandre Julliard
01 Apr '21
01 Apr '21
Module: wine Branch: master Commit: fbecd56db8889f9d349c2f807348cdddf397eab1 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=fbecd56db8889f9d349c2f80…
Author: Hugh McMaster <hugh.mcmaster(a)outlook.com> Date: Thu Apr 1 23:20:51 2021 +1100 reg: Prepend 'reg:' to two message strings. Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- po/ar.po | 10 +++++++--- po/ast.po | 10 +++++++--- po/bg.po | 7 ++++--- po/ca.po | 8 ++++++-- po/cs.po | 8 ++++++-- po/da.po | 10 +++++++--- po/de.po | 8 ++++++-- po/el.po | 7 ++++--- po/en.po | 8 ++++---- po/en_US.po | 8 ++++---- po/eo.po | 8 +++++--- po/es.po | 10 +++++++--- po/fa.po | 7 ++++--- po/fi.po | 8 ++++++-- po/fr.po | 8 ++++++-- po/he.po | 9 ++++++--- po/hi.po | 4 ++-- po/hr.po | 10 +++++++--- po/hu.po | 10 +++++++--- po/it.po | 10 +++++++--- po/ja.po | 8 ++++++-- po/ko.po | 8 ++++++-- po/lt.po | 8 ++++++-- po/ml.po | 4 ++-- po/nb_NO.po | 8 ++++++-- po/nl.po | 8 ++++++-- po/or.po | 4 ++-- po/pa.po | 4 ++-- po/pl.po | 8 ++++++-- po/pt_BR.po | 8 ++++++-- po/pt_PT.po | 8 ++++++-- po/rm.po | 7 ++++--- po/ro.po | 8 ++++++-- po/ru.po | 8 ++++++-- po/si.po | 8 ++++++-- po/sk.po | 8 +++++--- po/sl.po | 10 +++++++--- po/sr_RS(a)cyrillic.po | 7 ++++--- po/sr_RS(a)latin.po | 7 ++++--- po/sv.po | 8 ++++++-- po/ta.po | 4 ++-- po/te.po | 4 ++-- po/th.po | 7 ++++--- po/tr.po | 8 ++++++-- po/uk.po | 8 ++++++-- po/wa.po | 7 ++++--- po/wine.pot | 4 ++-- po/zh_CN.po | 8 ++++++-- po/zh_TW.po | 10 +++++++--- programs/reg/reg.rc | 4 ++-- 50 files changed, 255 insertions(+), 124 deletions(-) Diff:
https://source.winehq.org/git/wine.git/?a=commitdiff;h=fbecd56db8889f9d349c…
1
0
0
0
Hugh McMaster : reg: Add a new message to indicate when a registry key fails to import.
by Alexandre Julliard
01 Apr '21
01 Apr '21
Module: wine Branch: master Commit: 9b7a5cfb0e709e4434575daf960f803338bdf6bd URL:
https://source.winehq.org/git/wine.git/?a=commit;h=9b7a5cfb0e709e4434575daf…
Author: Hugh McMaster <hugh.mcmaster(a)outlook.com> Date: Thu Apr 1 23:20:50 2021 +1100 reg: Add a new message to indicate when a registry key fails to import. Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- po/ar.po | 6 ++++++ po/ast.po | 6 ++++++ po/bg.po | 6 ++++++ po/ca.po | 6 ++++++ po/cs.po | 6 ++++++ po/da.po | 6 ++++++ po/de.po | 6 ++++++ po/el.po | 5 +++++ po/en.po | 4 ++++ po/en_US.po | 4 ++++ po/eo.po | 6 ++++++ po/es.po | 6 ++++++ po/fa.po | 5 +++++ po/fi.po | 6 ++++++ po/fr.po | 6 ++++++ po/he.po | 6 ++++++ po/hi.po | 4 ++++ po/hr.po | 6 ++++++ po/hu.po | 6 ++++++ po/it.po | 6 ++++++ po/ja.po | 6 ++++++ po/ko.po | 6 ++++++ po/lt.po | 6 ++++++ po/ml.po | 4 ++++ po/nb_NO.po | 6 ++++++ po/nl.po | 6 ++++++ po/or.po | 4 ++++ po/pa.po | 4 ++++ po/pl.po | 6 ++++++ po/pt_BR.po | 6 ++++++ po/pt_PT.po | 6 ++++++ po/rm.po | 5 +++++ po/ro.po | 6 ++++++ po/ru.po | 6 ++++++ po/si.po | 6 ++++++ po/sk.po | 6 ++++++ po/sl.po | 6 ++++++ po/sr_RS(a)cyrillic.po | 6 ++++++ po/sr_RS(a)latin.po | 6 ++++++ po/sv.po | 6 ++++++ po/ta.po | 4 ++++ po/te.po | 4 ++++ po/th.po | 5 +++++ po/tr.po | 6 ++++++ po/uk.po | 6 ++++++ po/wa.po | 5 +++++ po/wine.pot | 4 ++++ po/zh_CN.po | 6 ++++++ po/zh_TW.po | 6 ++++++ programs/reg/import.c | 4 ++-- programs/reg/reg.rc | 1 + programs/reg/resource.h | 1 + 52 files changed, 275 insertions(+), 2 deletions(-) Diff:
https://source.winehq.org/git/wine.git/?a=commitdiff;h=9b7a5cfb0e709e443457…
1
0
0
0
Hugh McMaster : reg: Add a message to better indicate when a specified registry key is not found.
by Alexandre Julliard
01 Apr '21
01 Apr '21
Module: wine Branch: master Commit: fa2ed01352f8f027625d464915cd953e10766d73 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=fa2ed01352f8f027625d4649…
Author: Hugh McMaster <hugh.mcmaster(a)outlook.com> Date: Thu Apr 1 23:20:49 2021 +1100 reg: Add a message to better indicate when a specified registry key is not found. Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- po/ar.po | 7 +++++++ po/ast.po | 6 ++++++ po/bg.po | 6 ++++++ po/ca.po | 9 +++++++++ po/cs.po | 7 +++++++ po/da.po | 9 +++++++++ po/de.po | 8 ++++++++ po/el.po | 5 +++++ po/en.po | 4 ++++ po/en_US.po | 4 ++++ po/eo.po | 6 ++++++ po/es.po | 9 +++++++++ po/fa.po | 5 +++++ po/fi.po | 7 +++++++ po/fr.po | 8 ++++++++ po/he.po | 8 ++++++++ po/hi.po | 4 ++++ po/hr.po | 8 ++++++++ po/hu.po | 8 ++++++++ po/it.po | 9 +++++++++ po/ja.po | 8 ++++++++ po/ko.po | 7 +++++++ po/lt.po | 7 +++++++ po/ml.po | 4 ++++ po/nb_NO.po | 8 ++++++++ po/nl.po | 9 +++++++++ po/or.po | 4 ++++ po/pa.po | 4 ++++ po/pl.po | 7 +++++++ po/pt_BR.po | 9 +++++++++ po/pt_PT.po | 9 +++++++++ po/rm.po | 5 +++++ po/ro.po | 8 ++++++++ po/ru.po | 7 +++++++ po/si.po | 6 ++++++ po/sk.po | 6 ++++++ po/sl.po | 7 +++++++ po/sr_RS(a)cyrillic.po | 6 ++++++ po/sr_RS(a)latin.po | 6 ++++++ po/sv.po | 8 ++++++++ po/ta.po | 4 ++++ po/te.po | 4 ++++ po/th.po | 5 +++++ po/tr.po | 8 ++++++++ po/uk.po | 7 +++++++ po/wa.po | 5 +++++ po/wine.pot | 4 ++++ po/zh_CN.po | 7 +++++++ po/zh_TW.po | 7 +++++++ programs/reg/delete.c | 4 ++-- programs/reg/export.c | 2 +- programs/reg/query.c | 2 +- programs/reg/reg.rc | 1 + programs/reg/resource.h | 1 + 54 files changed, 329 insertions(+), 4 deletions(-) Diff:
https://source.winehq.org/git/wine.git/?a=commitdiff;h=fa2ed01352f8f027625d…
1
0
0
0
Hugh McMaster : reg: Improve initial syntax checks during the 'export' operation.
by Alexandre Julliard
01 Apr '21
01 Apr '21
Module: wine Branch: master Commit: 4df5c1641e7091f42c2313b275d999f2b9d25eff URL:
https://source.winehq.org/git/wine.git/?a=commit;h=4df5c1641e7091f42c2313b2…
Author: Hugh McMaster <hugh.mcmaster(a)outlook.com> Date: Thu Apr 1 23:20:48 2021 +1100 reg: Improve initial syntax checks during the 'export' operation. Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/reg/export.c | 28 +++++++++++++++++----------- programs/reg/reg.c | 10 ++++++---- programs/reg/reg.h | 1 + 3 files changed, 24 insertions(+), 15 deletions(-) diff --git a/programs/reg/export.c b/programs/reg/export.c index 3150c075f26..79f055c691f 100644 --- a/programs/reg/export.c +++ b/programs/reg/export.c @@ -344,27 +344,33 @@ static HANDLE get_file_handle(WCHAR *filename, BOOL overwrite_file) return hFile; } -static BOOL is_overwrite_switch(const WCHAR *s) -{ - return is_switch(s, 'y'); -} - int reg_export(int argc, WCHAR *argvW[]) { HKEY root, hkey; WCHAR *path, *long_key; BOOL overwrite_file = FALSE; HANDLE hFile; - int ret; + int i, ret; - if (argc == 3 || argc > 5) - goto error; + if (argc < 4) goto invalid; if (!parse_registry_key(argvW[2], &root, &path, &long_key)) return 1; - if (argc == 5 && !(overwrite_file = is_overwrite_switch(argvW[4]))) - goto error; + for (i = 4; i < argc; i++) + { + WCHAR *str; + + if (argvW[i][0] != '/' && argvW[i][0] != '-') + goto invalid; + + str = &argvW[i][1]; + + if (is_char(*str, 'y') && !str[1]) + overwrite_file = TRUE; + else + goto invalid; + } if (RegOpenKeyExW(root, path, 0, KEY_READ, &hkey)) { @@ -382,7 +388,7 @@ int reg_export(int argc, WCHAR *argvW[]) return ret; -error: +invalid: output_message(STRING_INVALID_SYNTAX); output_message(STRING_FUNC_HELP, wcsupr(argvW[1])); return 1; diff --git a/programs/reg/reg.c b/programs/reg/reg.c index 10aaabf92da..6b337f5d415 100644 --- a/programs/reg/reg.c +++ b/programs/reg/reg.c @@ -250,15 +250,17 @@ BOOL parse_registry_key(const WCHAR *key, HKEY *root, WCHAR **path, WCHAR **long return TRUE; } +BOOL is_char(const WCHAR s, const WCHAR c) +{ + return (s == c || s == towupper(c)); +} + BOOL is_switch(const WCHAR *s, const WCHAR c) { if (lstrlenW(s) > 2) return FALSE; - if ((s[0] == '/' || s[0] == '-') && (s[1] == c || s[1] == towupper(c))) - return TRUE; - - return FALSE; + return ((s[0] == '/' || s[0] == '-') && is_char(s[1], c)); } static BOOL is_help_switch(const WCHAR *s) diff --git a/programs/reg/reg.h b/programs/reg/reg.h index 3525bed75b8..c7719a6e4f0 100644 --- a/programs/reg/reg.h +++ b/programs/reg/reg.h @@ -40,6 +40,7 @@ BOOL ask_confirm(unsigned int msgid, WCHAR *reg_info); HKEY path_get_rootkey(const WCHAR *path); WCHAR *build_subkey_path(WCHAR *path, DWORD path_len, WCHAR *subkey_name, DWORD subkey_len); BOOL parse_registry_key(const WCHAR *key, HKEY *root, WCHAR **path, WCHAR **long_key); +BOOL is_char(const WCHAR s, const WCHAR c); BOOL is_switch(const WCHAR *s, const WCHAR c); /* add.c */
1
0
0
0
Hugh McMaster : reg: Use wide-char string literals in export.c.
by Alexandre Julliard
01 Apr '21
01 Apr '21
Module: wine Branch: master Commit: 1b746c1e1c4da4a07a1293fe9e60429867c86697 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=1b746c1e1c4da4a07a1293fe…
Author: Hugh McMaster <hugh.mcmaster(a)outlook.com> Date: Thu Apr 1 23:20:47 2021 +1100 reg: Use wide-char string literals in export.c. Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/reg/export.c | 32 +++++++++++--------------------- 1 file changed, 11 insertions(+), 21 deletions(-) diff --git a/programs/reg/export.c b/programs/reg/export.c index 30f01c8b94f..3150c075f26 100644 --- a/programs/reg/export.c +++ b/programs/reg/export.c @@ -79,15 +79,14 @@ static WCHAR *escape_string(WCHAR *str, size_t str_len, size_t *line_len) static size_t export_value_name(HANDLE hFile, WCHAR *name, size_t len) { - static const WCHAR quoted_fmt[] = {'"','%','s','"','=',0}; - static const WCHAR default_name[] = {'@','=',0}; + static const WCHAR *default_name = L"@="; size_t line_len; if (name && *name) { WCHAR *str = escape_string(name, len, &line_len); WCHAR *buf = malloc((line_len + 4) * sizeof(WCHAR)); - line_len = swprintf(buf, line_len + 4, quoted_fmt, str); + line_len = swprintf(buf, line_len + 4, L"\"%s\"=", str); write_file(hFile, buf); free(buf); free(str); @@ -105,28 +104,24 @@ static void export_string_data(WCHAR **buf, WCHAR *data, size_t size) { size_t len = 0, line_len; WCHAR *str; - static const WCHAR fmt[] = {'"','%','s','"',0}; if (size) len = size / sizeof(WCHAR) - 1; str = escape_string(data, len, &line_len); *buf = malloc((line_len + 3) * sizeof(WCHAR)); - swprintf(*buf, line_len + 3, fmt, str); + swprintf(*buf, line_len + 3, L"\"%s\"", str); free(str); } static void export_dword_data(WCHAR **buf, DWORD *data) { - static const WCHAR fmt[] = {'d','w','o','r','d',':','%','0','8','x',0}; - *buf = malloc(15 * sizeof(WCHAR)); - swprintf(*buf, 15, fmt, *data); + swprintf(*buf, 15, L"dword:%08x", *data); } static size_t export_hex_data_type(HANDLE hFile, DWORD type) { - static const WCHAR hex[] = {'h','e','x',':',0}; - static const WCHAR hexp_fmt[] = {'h','e','x','(','%','x',')',':',0}; + static const WCHAR *hex = L"hex:"; size_t line_len; if (type == REG_BINARY) @@ -137,7 +132,7 @@ static size_t export_hex_data_type(HANDLE hFile, DWORD type) else { WCHAR *buf = malloc(15 * sizeof(WCHAR)); - line_len = swprintf(buf, 15, hexp_fmt, type); + line_len = swprintf(buf, 15, L"hex(%x):", type); write_file(hFile, buf); free(buf); } @@ -150,8 +145,6 @@ static size_t export_hex_data_type(HANDLE hFile, DWORD type) static void export_hex_data(HANDLE hFile, WCHAR **buf, DWORD type, DWORD line_len, void *data, DWORD size) { - static const WCHAR fmt[] = {'%','0','2','x',0}; - static const WCHAR hex_concat[] = {'\\','\r','\n',' ',' ',0}; size_t num_commas, i, pos; line_len += export_hex_data_type(hFile, type); @@ -163,7 +156,7 @@ static void export_hex_data(HANDLE hFile, WCHAR **buf, DWORD type, for (i = 0, pos = 0; i < size; i++) { - pos += swprintf(*buf + pos, 3, fmt, ((BYTE *)data)[i]); + pos += swprintf(*buf + pos, 3, L"%02x", ((BYTE *)data)[i]); if (i == num_commas) break; (*buf)[pos++] = ','; (*buf)[pos] = 0; @@ -172,7 +165,7 @@ static void export_hex_data(HANDLE hFile, WCHAR **buf, DWORD type, if (line_len >= MAX_HEX_CHARS) { write_file(hFile, *buf); - write_file(hFile, hex_concat); + write_file(hFile, L"\\\r\n "); line_len = 2; pos = 0; } @@ -181,7 +174,7 @@ static void export_hex_data(HANDLE hFile, WCHAR **buf, DWORD type, static void export_newline(HANDLE hFile) { - static const WCHAR newline[] = {'\r','\n',0}; + static const WCHAR *newline = L"\r\n"; write_file(hFile, newline); } @@ -224,11 +217,10 @@ static void export_data(HANDLE hFile, WCHAR *value_name, DWORD value_len, static void export_key_name(HANDLE hFile, WCHAR *name) { - static const WCHAR fmt[] = {'\r','\n','[','%','s',']','\r','\n',0}; WCHAR *buf; buf = malloc((lstrlenW(name) + 7) * sizeof(WCHAR)); - swprintf(buf, lstrlenW(name) + 7, fmt, name); + swprintf(buf, lstrlenW(name) + 7, L"\r\n[%s]\r\n", name); write_file(hFile, buf); free(buf); } @@ -309,9 +301,7 @@ static int export_registry_data(HANDLE hFile, HKEY key, WCHAR *path) static void export_file_header(HANDLE hFile) { - static const WCHAR header[] = { 0xfeff,'W','i','n','d','o','w','s',' ', - 'R','e','g','i','s','t','r','y',' ','E','d','i','t','o','r',' ', - 'V','e','r','s','i','o','n',' ','5','.','0','0','\r','\n',0}; + static const WCHAR *header = L"\uFEFFWindows Registry Editor Version 5.00\r\n"; write_file(hFile, header); }
1
0
0
0
Nikolay Sivov : combase: Return initial values for global options.
by Alexandre Julliard
01 Apr '21
01 Apr '21
Module: wine Branch: master Commit: d63ed91c280b7af30b498735a2d8924e58fdcfe7 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=d63ed91c280b7af30b498735…
Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Apr 1 13:24:53 2021 +0300 combase: Return initial values for global options. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/combase/combase.c | 11 +++++++++-- dlls/ole32/tests/compobj.c | 13 +++++++++++++ include/objidlbase.idl | 28 +++++++++++++++++++++++++++- 3 files changed, 49 insertions(+), 3 deletions(-) diff --git a/dlls/combase/combase.c b/dlls/combase/combase.c index cda0d52f579..4677972656f 100644 --- a/dlls/combase/combase.c +++ b/dlls/combase/combase.c @@ -38,6 +38,8 @@ WINE_DEFAULT_DEBUG_CHANNEL(ole); HINSTANCE hProxyDll; +static ULONG_PTR global_options[COMGLB_PROPERTIES_RESERVED3 + 1]; + /* Ole32 exports */ extern void WINAPI DestroyRunningObjectTable(void); extern HRESULT WINAPI Ole32DllGetClassObject(REFCLSID rclsid, REFIID riid, void **obj); @@ -490,9 +492,14 @@ static HRESULT WINAPI global_options_Set(IGlobalOptions *iface, GLOBALOPT_PROPER static HRESULT WINAPI global_options_Query(IGlobalOptions *iface, GLOBALOPT_PROPERTIES property, ULONG_PTR *value) { - FIXME("%p, %u, %p.\n", iface, property, value); + TRACE("%p, %u, %p.\n", iface, property, value); - return E_NOTIMPL; + if (property < COMGLB_EXCEPTION_HANDLING || property > COMGLB_PROPERTIES_RESERVED3) + return E_INVALIDARG; + + *value = global_options[property]; + + return S_OK; } static const IGlobalOptionsVtbl global_options_vtbl = diff --git a/dlls/ole32/tests/compobj.c b/dlls/ole32/tests/compobj.c index 2e5006463da..d1e947e393f 100644 --- a/dlls/ole32/tests/compobj.c +++ b/dlls/ole32/tests/compobj.c @@ -3919,6 +3919,7 @@ todo_wine { static void test_GlobalOptions(void) { IGlobalOptions *global_options; + ULONG_PTR value; HRESULT hres; CoInitialize(NULL); @@ -3933,6 +3934,18 @@ static void test_GlobalOptions(void) return; } + hres = IGlobalOptions_Query(global_options, 0, &value); + ok(FAILED(hres), "Unexpected hr %#x.\n", hres); + + hres = IGlobalOptions_Query(global_options, COMGLB_PROPERTIES_RESERVED3 + 1, &value); + ok(FAILED(hres), "Unexpected hr %#x.\n", hres); + + value = ~0u; + hres = IGlobalOptions_Query(global_options, COMGLB_EXCEPTION_HANDLING, &value); + ok(hres == S_OK || broken(hres == E_FAIL) /* Vista */, "Unexpected hr %#x.\n", hres); + if (SUCCEEDED(hres)) + ok(value == COMGLB_EXCEPTION_HANDLE, "Unexpected value %ld.\n", value); + IGlobalOptions_Release(global_options); hres = CoCreateInstance(&CLSID_GlobalOptions, (IUnknown*)0xdeadbeef, CLSCTX_INPROC_SERVER, diff --git a/include/objidlbase.idl b/include/objidlbase.idl index 6449be8417b..bd5a9b12409 100644 --- a/include/objidlbase.idl +++ b/include/objidlbase.idl @@ -1095,7 +1095,12 @@ typedef enum tagGLOBALOPT_PROPERTIES { COMGLB_EXCEPTION_HANDLING = 1, COMGLB_APPID = 2, - COMGLB_RPC_THREADPOOL_SETTING = 3 + COMGLB_RPC_THREADPOOL_SETTING = 3, + COMGLB_RO_SETTINGS = 4, + COMGLB_UNMARSHALING_POLICY = 5, + COMGLB_PROPERTIES_RESERVED1 = 6, + COMGLB_PROPERTIES_RESERVED2 = 7, + COMGLB_PROPERTIES_RESERVED3 = 8, } GLOBALOPT_PROPERTIES; typedef enum tagGLOBALOPT_EH_VALUES @@ -1112,6 +1117,27 @@ typedef enum tagGLOBALOPT_RPCTP_VALUES COMGLB_RPC_THREADPOOL_SETTING_PRIVATE_POOL = 1 } GLOBALOPT_RPCTP_VALUES; +typedef enum tagGLOBALOPT_RO_FLAGS +{ + COMGLB_STA_MODALLOOP_REMOVE_TOUCH_MESSAGES = 0x1, + COMGLB_STA_MODALLOOP_SHARED_QUEUE_REMOVE_INPUT_MESSAGES = 0x2, + COMGLB_STA_MODALLOOP_SHARED_QUEUE_DONOT_REMOVE_INPUT_MESSAGES = 0x4, + COMGLB_FAST_RUNDOWN = 0x8, + COMGLB_RESERVED1 = 0x10, + COMGLB_RESERVED2 = 0x20, + COMGLB_RESERVED3 = 0x40, + COMGLB_STA_MODALLOOP_SHARED_QUEUE_REORDER_POINTER_MESSAGES = 0x80, + COMGLB_RESERVED4 = 0x100, + COMGLB_RESERVED5 = 0x200, + COMGLB_RESERVED6 = 0x400, +} GLOBALOPT_RO_FLAGS; + +typedef enum tagGLOBALOPT_UNMARSHALING_POLICY_VALUES +{ + COMGLB_UNMARSHALING_POLICY_NORMAL = 0, + COMGLB_UNMARSHALING_POLICY_STRONG = 1, + COMGLB_UNMARSHALING_POLICY_HYBRID = 2, +} GLOBALOPT_UNMARSHALING_POLICY_VALUES; [ object,
1
0
0
0
Nikolay Sivov : include: Add ID2D1DeviceContext1 definition.
by Alexandre Julliard
01 Apr '21
01 Apr '21
Module: wine Branch: master Commit: 583d2cbfb7322f6f16341ab17e37404ef134aef2 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=583d2cbfb7322f6f16341ab1…
Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed Mar 31 22:34:49 2021 +0300 include: Add ID2D1DeviceContext1 definition. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/d2d1_2.idl | 36 ++++++++++++++++++++++++++++++++++-- 1 file changed, 34 insertions(+), 2 deletions(-) diff --git a/include/d2d1_2.idl b/include/d2d1_2.idl index 3506c796ccb..39e285dc221 100644 --- a/include/d2d1_2.idl +++ b/include/d2d1_2.idl @@ -18,8 +18,6 @@ import "d2d1_1.idl"; -interface ID2D1DeviceContext1; - typedef enum D2D1_RENDERING_PRIORITY { D2D1_RENDERING_PRIORITY_NORMAL = 0, @@ -27,6 +25,40 @@ typedef enum D2D1_RENDERING_PRIORITY D2D1_RENDERING_PRIORITY_FORCE_DWORD = 0xffffffff, } D2D1_RENDERING_PRIORITY; +[ + object, + uuid(a16907d7-bc02-4801-99e8-8cf7f485f774), + local, +] +interface ID2D1GeometryRealization : ID2D1Resource +{ +} + +[ + object, + uuid(d37f57e4-6908-459f-a199-e72f24f79987), + local, +] +interface ID2D1DeviceContext1 : ID2D1DeviceContext +{ + HRESULT CreateFilledGeometryRealization( + [in] ID2D1Geometry *geometry, + [in] float tolerance, + [out] ID2D1GeometryRealization **realization + ); + HRESULT CreateStrokedGeometryRealization( + [in] ID2D1Geometry *geometry, + [in] float tolerance, + [in] float stroke_width, + [in] ID2D1StrokeStyle *stroke_style, + [out] ID2D1GeometryRealization **realization + ); + void DrawGeometryRealization( + [in] ID2D1GeometryRealization *realization, + [in] ID2D1Brush *brush + ); +} + [ object, uuid(d21768e1-23a4-4823-a14b-7c3eba85d658),
1
0
0
0
← Newer
1
...
83
84
85
86
87
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
Results per page:
10
25
50
100
200