winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
May 2021
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
770 discussions
Start a n
N
ew thread
Nikolay Sivov : evr/presenter: Use correct sample size attribute value when setting output mixer type.
by Alexandre Julliard
31 May '21
31 May '21
Module: wine Branch: master Commit: a00a09c470322875ff7db58e3376c30ff08b7793 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=a00a09c470322875ff7db58e…
Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Mon May 31 13:31:13 2021 +0300 evr/presenter: Use correct sample size attribute value when setting output mixer type. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/evr/presenter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/evr/presenter.c b/dlls/evr/presenter.c index 414ba5bcaa0..e9890c9f6e4 100644 --- a/dlls/evr/presenter.c +++ b/dlls/evr/presenter.c @@ -334,7 +334,7 @@ static HRESULT video_presenter_configure_output_type(struct video_presenter *pre if (SUCCEEDED(hr)) hr = IMFMediaType_SetUINT32(media_type, &MF_MT_DEFAULT_STRIDE, stride); if (SUCCEEDED(hr)) - hr = IMFMediaType_SetUINT32(media_type, &MF_MT_SAMPLE_SIZE, stride); + hr = IMFMediaType_SetUINT32(media_type, &MF_MT_SAMPLE_SIZE, size); } return hr;
1
0
0
0
Nikolay Sivov : evr/mixer: Set aperture attributes for output type candidates.
by Alexandre Julliard
31 May '21
31 May '21
Module: wine Branch: master Commit: 5d83662217364447dab7278610068e055673d510 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=5d83662217364447dab72786…
Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Mon May 31 13:31:12 2021 +0300 evr/mixer: Set aperture attributes for output type candidates. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/evr/mixer.c | 38 +++++++++++++++++++++----------------- 1 file changed, 21 insertions(+), 17 deletions(-) diff --git a/dlls/evr/mixer.c b/dlls/evr/mixer.c index c18bf0450bf..187a13be364 100644 --- a/dlls/evr/mixer.c +++ b/dlls/evr/mixer.c @@ -664,6 +664,7 @@ static HRESULT video_mixer_collect_output_types(struct video_mixer *mixer, const unsigned int i, j, format_count, count; struct rt_format *rt_formats = NULL, *ptr; HRESULT hr = MF_E_INVALIDMEDIATYPE; + MFVideoArea aperture; D3DFORMAT *formats; GUID subtype; @@ -691,29 +692,32 @@ static HRESULT video_mixer_collect_output_types(struct video_mixer *mixer, const if (count && !(flags & MFT_SET_TYPE_TEST_ONLY)) { + if (!(mixer->output.rt_formats = calloc(count, sizeof(*mixer->output.rt_formats)))) + { + free(rt_formats); + return E_OUTOFMEMORY; + } + memcpy(&subtype, &MFVideoFormat_Base, sizeof(subtype)); - if ((mixer->output.rt_formats = calloc(count, sizeof(*mixer->output.rt_formats)))) + memset(&aperture, 0, sizeof(aperture)); + aperture.Area.cx = video_desc->SampleWidth; + aperture.Area.cy = video_desc->SampleHeight; + for (i = 0; i < count; ++i) { - for (i = 0; i < count; ++i) - { - IMFMediaType *rt_media_type; + IMFMediaType *rt_media_type; - subtype.Data1 = rt_formats[i].format; - mixer->output.rt_formats[i] = rt_formats[i]; + subtype.Data1 = rt_formats[i].format; + mixer->output.rt_formats[i] = rt_formats[i]; - MFCreateMediaType(&rt_media_type); - IMFMediaType_CopyAllItems(media_type, (IMFAttributes *)rt_media_type); - IMFMediaType_SetGUID(rt_media_type, &MF_MT_SUBTYPE, &subtype); + MFCreateMediaType(&rt_media_type); + IMFMediaType_CopyAllItems(media_type, (IMFAttributes *)rt_media_type); + IMFMediaType_SetGUID(rt_media_type, &MF_MT_SUBTYPE, &subtype); + IMFMediaType_SetBlob(rt_media_type, &MF_MT_GEOMETRIC_APERTURE, (const UINT8 *)&aperture, sizeof(aperture)); + IMFMediaType_SetBlob(rt_media_type, &MF_MT_MINIMUM_DISPLAY_APERTURE, (const UINT8 *)&aperture, sizeof(aperture)); - mixer->output.rt_formats[i].media_type = rt_media_type; - } - mixer->output.rt_formats_count = count; - } - else - { - hr = E_OUTOFMEMORY; - count = 0; + mixer->output.rt_formats[i].media_type = rt_media_type; } + mixer->output.rt_formats_count = count; } free(rt_formats);
1
0
0
0
Nikolay Sivov : propsys: Add support for VT_VECTOR|VT_UI1 type in PropVariantCompareEx().
by Alexandre Julliard
31 May '21
31 May '21
Module: wine Branch: master Commit: e91b05bb5be6fd70a767bea9991e818a49cc5547 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=e91b05bb5be6fd70a767bea9…
Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Mon May 31 13:31:11 2021 +0300 propsys: Add support for VT_VECTOR|VT_UI1 type in PropVariantCompareEx(). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/propsys/propvar.c | 13 +++++++- dlls/propsys/tests/propsys.c | 75 ++++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 85 insertions(+), 3 deletions(-) diff --git a/dlls/propsys/propvar.c b/dlls/propsys/propvar.c index a18d83eabab..977fbebb918 100644 --- a/dlls/propsys/propvar.c +++ b/dlls/propsys/propvar.c @@ -798,7 +798,10 @@ static BOOL isemptyornull(const PROPVARIANT *propvar) if (propvar->vt == VT_CLSID) return !propvar->puuid; - /* FIXME: vectors, byrefs, errors? */ + if (propvar->vt & VT_VECTOR) + return !propvar->caub.cElems; + + /* FIXME: byrefs, errors? */ return FALSE; } @@ -807,6 +810,7 @@ INT WINAPI PropVariantCompareEx(REFPROPVARIANT propvar1, REFPROPVARIANT propvar2 { const PROPVARIANT *propvar2_converted; PROPVARIANT propvar2_static; + unsigned int count; HRESULT hr; INT res=-1; @@ -894,6 +898,13 @@ INT WINAPI PropVariantCompareEx(REFPROPVARIANT propvar1, REFPROPVARIANT propvar2 res = memcmp(propvar1->puuid, propvar2->puuid, sizeof(*propvar1->puuid)); if (res) res = res > 0 ? 1 : -1; break; + case VT_VECTOR | VT_UI1: + count = min(propvar1->caub.cElems, propvar2->caub.cElems); + res = count ? memcmp(propvar1->caub.pElems, propvar2->caub.pElems, sizeof(*propvar1->caub.pElems) * count) : 0; + if (res) res = res > 0 ? 1 : -1; + if (!res && propvar1->caub.cElems != propvar2->caub.cElems) + res = propvar1->caub.cElems > propvar2->caub.cElems ? 1 : -1; + break; default: FIXME("vartype %#x not handled\n", propvar1->vt); res = -1; diff --git a/dlls/propsys/tests/propsys.c b/dlls/propsys/tests/propsys.c index 07d035376d9..9ffa048a8b7 100644 --- a/dlls/propsys/tests/propsys.c +++ b/dlls/propsys/tests/propsys.c @@ -666,15 +666,18 @@ static void test_PropVariantToStringAlloc(void) CoTaskMemFree(str); } -static void test_PropVariantCompare(void) +static void test_PropVariantCompareEx(void) { PROPVARIANT empty, null, emptyarray, i2_0, i2_2, i4_large, i4_largeneg, i4_2, str_2, str_02, str_b; PROPVARIANT clsid_null, clsid, clsid2, r4_0, r4_2, r8_0, r8_2; + PROPVARIANT var1, var2; INT res; static const WCHAR str_2W[] = {'2', 0}; static const WCHAR str_02W[] = {'0', '2', 0}; static const WCHAR str_bW[] = {'b', 0}; SAFEARRAY emptysafearray; + unsigned char bytevector1[] = {1,2,3}; + unsigned char bytevector2[] = {4,5,6}; PropVariantInit(&empty); PropVariantInit(&null); @@ -847,6 +850,74 @@ todo_wine res = PropVariantCompareEx(&r8_2, &r8_0, 0, 0); ok(res == 1, "res=%i\n", res); + /* VT_VECTOR | VT_UI1 */ + var1.vt = VT_VECTOR | VT_UI1; + var1.caub.cElems = 1; + var1.caub.pElems = bytevector1; + var2.vt = VT_VECTOR | VT_UI1; + var2.caub.cElems = 1; + var2.caub.pElems = bytevector2; + + res = PropVariantCompareEx(&var1, &var2, 0, 0); + ok(res == -1, "res=%i\n", res); + + res = PropVariantCompareEx(&var2, &var1, 0, 0); + ok(res == 1, "res=%i\n", res); + + /* Vector length mismatch */ + var1.caub.cElems = 2; + res = PropVariantCompareEx(&var1, &var2, 0, 0); + ok(res == -1, "res=%i\n", res); + + res = PropVariantCompareEx(&var2, &var1, 0, 0); + ok(res == 1, "res=%i\n", res); + + var1.caub.pElems = bytevector2; + var2.caub.pElems = bytevector1; + res = PropVariantCompareEx(&var1, &var2, 0, 0); + ok(res == 1, "res=%i\n", res); + + var1.caub.pElems = bytevector1; + var2.caub.pElems = bytevector2; + + var1.caub.cElems = 1; + var2.caub.cElems = 2; + res = PropVariantCompareEx(&var1, &var2, 0, 0); + ok(res == -1, "res=%i\n", res); + + res = PropVariantCompareEx(&var2, &var1, 0, 0); + ok(res == 1, "res=%i\n", res); + + /* Length mismatch over same data */ + var1.caub.pElems = bytevector1; + var2.caub.pElems = bytevector1; + + res = PropVariantCompareEx(&var1, &var2, 0, 0); + ok(res == -1, "res=%i\n", res); + + res = PropVariantCompareEx(&var2, &var1, 0, 0); + ok(res == 1, "res=%i\n", res); + + var1.caub.cElems = 1; + var2.caub.cElems = 1; + res = PropVariantCompareEx(&var1, &var2, 0, 0); + ok(res == 0, "res=%i\n", res); + + var1.caub.cElems = 0; + res = PropVariantCompareEx(&var1, &var2, 0, PVCF_TREATEMPTYASGREATERTHAN); + ok(res == 1, "res=%i\n", res); + res = PropVariantCompareEx(&var2, &var1, 0, PVCF_TREATEMPTYASGREATERTHAN); + ok(res == -1, "res=%i\n", res); + + res = PropVariantCompareEx(&var1, &var2, 0, 0); + ok(res == -1, "res=%i\n", res); + res = PropVariantCompareEx(&var2, &var1, 0, 0); + ok(res == 1, "res=%i\n", res); + + var2.caub.cElems = 0; + res = PropVariantCompareEx(&var1, &var2, 0, 0); + ok(res == 0, "res=%i\n", res); + SysFreeString(str_2.bstrVal); SysFreeString(str_02.bstrVal); SysFreeString(str_b.bstrVal); @@ -1957,7 +2028,7 @@ START_TEST(propsys) test_InitPropVariantFromBuffer(); test_PropVariantToGUID(); test_PropVariantToStringAlloc(); - test_PropVariantCompare(); + test_PropVariantCompareEx(); test_intconversions(); test_PropVariantChangeType_LPWSTR(); test_PropVariantToBoolean();
1
0
0
0
Nikolay Sivov : mfmediaengine: Add missing initialization of vertex buffer components (Coverity).
by Alexandre Julliard
31 May '21
31 May '21
Module: wine Branch: master Commit: c7339d62813b9b911c746160350b1bfc6172758f URL:
https://source.winehq.org/git/wine.git/?a=commit;h=c7339d62813b9b911c746160…
Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Mon May 31 13:29:36 2021 +0300 mfmediaengine: Add missing initialization of vertex buffer components (Coverity). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mfmediaengine/main.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/dlls/mfmediaengine/main.c b/dlls/mfmediaengine/main.c index 4f01f6ddada..510b1c5885f 100644 --- a/dlls/mfmediaengine/main.c +++ b/dlls/mfmediaengine/main.c @@ -2054,15 +2054,19 @@ static HRESULT media_engine_transfer_to_d3d11_texture(struct media_engine *engin quad[0].x = 2.0f * rect.left / desc.Width - 1.0f; quad[0].y = -2.0f * rect.bottom / desc.Height + 1.0f; + quad[0].z = 0.0f; quad[1].x = quad[0].x; quad[1].y = -2.0f * rect.top / desc.Height + 1.0f; + quad[1].z = 0.0f; quad[2].x = 2.0f * rect.right / desc.Width - 1.0f; quad[2].y = quad[0].y; + quad[2].z = 0.0f; quad[3].x = quad[2].x; quad[3].y = quad[1].y; + quad[3].z = 0.0f; set_rect(&dst, dst_rect->left, dst_rect->top, dst_rect->right, dst_rect->bottom); }
1
0
0
0
Nikolay Sivov : mf/topology: Implement MF_CONNECT_RESOLVE_INDEPENDENT_OUTPUTTYPES connection method.
by Alexandre Julliard
31 May '21
31 May '21
Module: wine Branch: master Commit: 33ea3fc8060b55b074a6234c3cb681685a023580 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=33ea3fc8060b55b074a6234c…
Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Mon May 31 13:28:45 2021 +0300 mf/topology: Implement MF_CONNECT_RESOLVE_INDEPENDENT_OUTPUTTYPES connection method. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mf/topology.c | 99 ++++++++++++++++++++++++++++++++++++++++++++---------- 1 file changed, 81 insertions(+), 18 deletions(-) diff --git a/dlls/mf/topology.c b/dlls/mf/topology.c index bbed2cba893..a054eca27e1 100644 --- a/dlls/mf/topology.c +++ b/dlls/mf/topology.c @@ -2010,7 +2010,10 @@ struct connect_context IMFTopologyNode *upstream_node; IMFTopologyNode *sink; IMFMediaTypeHandler *sink_handler; - const GUID *converter_category; + unsigned int output_index; + unsigned int input_index; + GUID converter_category; + GUID decoder_category; }; typedef HRESULT (*p_connect_func)(struct transform_output_type *output_type, struct connect_context *context); @@ -2142,7 +2145,7 @@ static HRESULT connect_to_converter(struct transform_output_type *output_type, s sink_ctx = *context; sink_ctx.upstream_node = node; - if (SUCCEEDED(hr = topology_loader_enumerate_output_types(context->converter_category, output_type->type, + if (SUCCEEDED(hr = topology_loader_enumerate_output_types(&context->converter_category, output_type->type, connect_to_sink, &sink_ctx))) { hr = IMFTopology_AddNode(context->context->output_topology, node); @@ -2225,13 +2228,62 @@ static HRESULT topology_loader_get_mft_categories(IMFMediaTypeHandler *handler, return S_OK; } +static HRESULT topology_loader_connect(IMFMediaTypeHandler *sink_handler, unsigned int sink_method, + struct connect_context *sink_ctx, struct connect_context *convert_ctx, IMFMediaType *media_type) +{ + HRESULT hr; + + if (SUCCEEDED(hr = IMFMediaTypeHandler_IsMediaTypeSupported(sink_handler, media_type, NULL)) + && SUCCEEDED(hr = IMFMediaTypeHandler_SetCurrentMediaType(sink_handler, media_type))) + { + hr = IMFTopologyNode_ConnectOutput(sink_ctx->upstream_node, sink_ctx->output_index, sink_ctx->sink, sink_ctx->input_index); + } + + if (FAILED(hr) && sink_method & MF_CONNECT_ALLOW_CONVERTER) + { + hr = topology_loader_enumerate_output_types(&convert_ctx->converter_category, media_type, connect_to_sink, sink_ctx); + } + + if (FAILED(hr) && sink_method & MF_CONNECT_ALLOW_DECODER) + { + hr = topology_loader_enumerate_output_types(&convert_ctx->decoder_category, media_type, + connect_to_converter, convert_ctx); + } + + return hr; +} + +static HRESULT topology_loader_foreach_source_type(IMFMediaTypeHandler *sink_handler, IMFMediaTypeHandler *source_handler, + unsigned int sink_method, struct connect_context *sink_ctx, struct connect_context *convert_ctx) +{ + unsigned int index = 0; + IMFMediaType *media_type; + HRESULT hr; + + while (SUCCEEDED(hr = IMFMediaTypeHandler_GetMediaTypeByIndex(source_handler, index++, &media_type))) + { + hr = topology_loader_connect(sink_handler, sink_method, sink_ctx, convert_ctx, media_type); + if (SUCCEEDED(hr)) break; + IMFMediaType_Release(media_type); + media_type = NULL; + } + + if (media_type) + { + hr = IMFMediaTypeHandler_SetCurrentMediaType(source_handler, media_type); + IMFMediaType_Release(media_type); + } + + return hr; +} + static HRESULT topology_loader_connect_source_to_sink(struct topoloader_context *context, IMFTopologyNode *source, unsigned int output_index, IMFTopologyNode *sink, unsigned int input_index) { IMFMediaTypeHandler *source_handler = NULL, *sink_handler = NULL; struct connect_context convert_ctx, sink_ctx; MF_CONNECT_METHOD source_method, sink_method; - GUID decode_cat, convert_cat; + unsigned int enumerate_source_types = 0; IMFMediaType *media_type; HRESULT hr; @@ -2248,35 +2300,46 @@ static HRESULT topology_loader_connect_source_to_sink(struct topoloader_context if (FAILED(IMFTopologyNode_GetUINT32(sink, &MF_TOPONODE_CONNECT_METHOD, &sink_method))) sink_method = MF_CONNECT_ALLOW_DECODER; - if (FAILED(hr = topology_loader_get_mft_categories(source_handler, &decode_cat, &convert_cat))) - goto done; - sink_ctx.context = context; sink_ctx.upstream_node = source; sink_ctx.sink = sink; sink_ctx.sink_handler = sink_handler; + sink_ctx.output_index = output_index; + sink_ctx.input_index = input_index; convert_ctx = sink_ctx; - convert_ctx.converter_category = &convert_cat; + if (FAILED(hr = topology_loader_get_mft_categories(source_handler, &convert_ctx.decoder_category, + &convert_ctx.converter_category))) + goto done; - if (SUCCEEDED(hr = IMFMediaTypeHandler_GetCurrentMediaType(source_handler, &media_type))) + IMFTopology_GetUINT32(context->output_topology, &MF_TOPOLOGY_ENUMERATE_SOURCE_TYPES, &enumerate_source_types); + + if (enumerate_source_types) { - /* Direct connection. */ - if (SUCCEEDED(hr = IMFMediaTypeHandler_IsMediaTypeSupported(sink_handler, media_type, NULL)) - && SUCCEEDED(hr = IMFMediaTypeHandler_SetCurrentMediaType(sink_handler, media_type))) + if (source_method & MF_CONNECT_RESOLVE_INDEPENDENT_OUTPUTTYPES) { - hr = IMFTopologyNode_ConnectOutput(source, output_index, sink, input_index); + hr = topology_loader_foreach_source_type(sink_handler, source_handler, MF_CONNECT_ALLOW_DECODER, + &sink_ctx, &convert_ctx); } - if (FAILED(hr) && sink_method & MF_CONNECT_ALLOW_CONVERTER) + else { - hr = topology_loader_enumerate_output_types(&convert_cat, media_type, connect_to_sink, &sink_ctx); + hr = topology_loader_foreach_source_type(sink_handler, source_handler, MF_CONNECT_DIRECT, + &sink_ctx, &convert_ctx); + if (FAILED(hr)) + hr = topology_loader_foreach_source_type(sink_handler, source_handler, MF_CONNECT_ALLOW_CONVERTER, + &sink_ctx, &convert_ctx); + if (FAILED(hr)) + hr = topology_loader_foreach_source_type(sink_handler, source_handler, MF_CONNECT_ALLOW_DECODER, + &sink_ctx, &convert_ctx); } - if (FAILED(hr) && sink_method & MF_CONNECT_ALLOW_DECODER) + } + else + { + if (SUCCEEDED(hr = IMFMediaTypeHandler_GetCurrentMediaType(source_handler, &media_type))) { - hr = topology_loader_enumerate_output_types(&decode_cat, media_type, connect_to_converter, &convert_ctx); + hr = topology_loader_connect(sink_handler, sink_method, &sink_ctx, &convert_ctx, media_type); + IMFMediaType_Release(media_type); } - - IMFMediaType_Release(media_type); } done:
1
0
0
0
Hugh McMaster : reg: Fail if the source and destination keys are the same when copying.
by Alexandre Julliard
31 May '21
31 May '21
Module: wine Branch: master Commit: 0abc002a3e232be3445241e435ef17ac89d6c947 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=0abc002a3e232be3445241e4…
Author: Hugh McMaster <hugh.mcmaster(a)outlook.com> Date: Mon May 31 19:45:24 2021 +1000 reg: Fail if the source and destination keys are the same when copying. Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- po/ar.po | 4 ++++ po/ast.po | 4 ++++ po/bg.po | 4 ++++ po/ca.po | 4 ++++ po/cs.po | 4 ++++ po/da.po | 4 ++++ po/de.po | 4 ++++ po/el.po | 4 ++++ po/en.po | 4 ++++ po/en_US.po | 4 ++++ po/eo.po | 4 ++++ po/es.po | 4 ++++ po/fa.po | 4 ++++ po/fi.po | 4 ++++ po/fr.po | 4 ++++ po/he.po | 4 ++++ po/hi.po | 4 ++++ po/hr.po | 4 ++++ po/hu.po | 4 ++++ po/it.po | 4 ++++ po/ja.po | 4 ++++ po/ko.po | 4 ++++ po/lt.po | 4 ++++ po/ml.po | 4 ++++ po/nb_NO.po | 4 ++++ po/nl.po | 4 ++++ po/or.po | 4 ++++ po/pa.po | 4 ++++ po/pl.po | 4 ++++ po/pt_BR.po | 4 ++++ po/pt_PT.po | 4 ++++ po/rm.po | 4 ++++ po/ro.po | 4 ++++ po/ru.po | 4 ++++ po/si.po | 4 ++++ po/sk.po | 4 ++++ po/sl.po | 4 ++++ po/sr_RS(a)cyrillic.po | 4 ++++ po/sr_RS(a)latin.po | 4 ++++ po/sv.po | 4 ++++ po/ta.po | 4 ++++ po/te.po | 4 ++++ po/th.po | 4 ++++ po/tr.po | 4 ++++ po/uk.po | 4 ++++ po/wa.po | 4 ++++ po/wine.pot | 4 ++++ po/zh_CN.po | 4 ++++ po/zh_TW.po | 4 ++++ programs/reg/copy.c | 6 ++++++ programs/reg/reg.c | 17 +++++++---------- programs/reg/reg.rc | 2 ++ programs/reg/resource.h | 3 +++ 53 files changed, 214 insertions(+), 10 deletions(-) Diff:
https://source.winehq.org/git/wine.git/?a=commitdiff;h=0abc002a3e232be34452…
1
0
0
0
Hugh McMaster : reg: Support recursion in the 'copy' command.
by Alexandre Julliard
31 May '21
31 May '21
Module: wine Branch: master Commit: 8d9a228e99e1252a0d82c88e6a64635548c478a6 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=8d9a228e99e1252a0d82c88e…
Author: Hugh McMaster <hugh.mcmaster(a)outlook.com> Date: Mon May 31 19:45:23 2021 +1000 reg: Support recursion in the 'copy' command. Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/reg/copy.c | 19 +++++++++++++++++++ programs/reg/tests/copy.c | 4 ++-- 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/programs/reg/copy.c b/programs/reg/copy.c index 29ada63da56..34abf8ade18 100644 --- a/programs/reg/copy.c +++ b/programs/reg/copy.c @@ -90,6 +90,25 @@ static int run_copy(struct key *src, struct key *dest, BOOL recurse, BOOL force) } } + for (i = 0; recurse; i++) + { + struct key subkey_src, subkey_dest; + + name_len = max_name_len; + + rc = RegEnumKeyExW(src->hkey, i, name, &name_len, NULL, NULL, NULL, NULL); + if (rc) break; + + subkey_src.root = src->hkey; + subkey_src.subkey = name; + + subkey_dest.root = dest->hkey; + subkey_dest.subkey = name; + + rc = run_copy(&subkey_src, &subkey_dest, TRUE, force); + if (rc) goto cleanup; + } + cleanup: free(name); free(data); diff --git a/programs/reg/tests/copy.c b/programs/reg/tests/copy.c index ef4a5f6acb8..70f9496b149 100644 --- a/programs/reg/tests/copy.c +++ b/programs/reg/tests/copy.c @@ -322,7 +322,7 @@ static void test_copy_complex_data(void) run_reg_exe("reg export HKEY_CURRENT_USER\\" KEY_BASE " file.reg /y", &r); ok(r == REG_EXIT_SUCCESS, "got exit code %d, expected 0\n", r); - ok(compare_export("file.reg", complex_data_test, TODO_REG_COMPARE), "compare_export() failed\n"); + ok(compare_export("file.reg", complex_data_test, 0), "compare_export() failed\n"); } static void test_copy_key_order(void) @@ -347,7 +347,7 @@ static void test_copy_key_order(void) run_reg_exe("reg export HKCU\\" KEY_BASE " file.reg /y", &r); ok(r == REG_EXIT_SUCCESS, "got exit code %d, expected 0\n", r); - ok(compare_export("file.reg", key_order_test, TODO_REG_COMPARE), "compare_export() failed\n"); + ok(compare_export("file.reg", key_order_test, 0), "compare_export() failed\n"); } static void test_copy_value_order(void)
1
0
0
0
Hugh McMaster : reg: Partially implement the 'copy' command.
by Alexandre Julliard
31 May '21
31 May '21
Module: wine Branch: master Commit: b1ccb87d9debb1a07e35263a76b6e34a7dd6ee49 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=b1ccb87d9debb1a07e35263a…
Author: Hugh McMaster <hugh.mcmaster(a)outlook.com> Date: Mon May 31 19:45:22 2021 +1000 reg: Partially implement the 'copy' command. Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/reg/copy.c | 129 +++++++++++++++++++++++++++++++++ programs/reg/tests/copy.c | 178 +++++++++++++++++++++++----------------------- 2 files changed, 218 insertions(+), 89 deletions(-) Diff:
https://source.winehq.org/git/wine.git/?a=commitdiff;h=b1ccb87d9debb1a07e35…
1
0
0
0
Hugh McMaster : reg: Group resource IDs by source location.
by Alexandre Julliard
31 May '21
31 May '21
Module: wine Branch: master Commit: 8f997a8b9b75320449711d3b05241b5f1f580ac3 URL:
https://source.winehq.org/git/wine.git/?a=commit;h=8f997a8b9b75320449711d3b…
Author: Hugh McMaster <hugh.mcmaster(a)outlook.com> Date: Mon May 31 19:45:21 2021 +1000 reg: Group resource IDs by source location. Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- po/ar.po | 344 ++++++++++++++++----------------- po/ast.po | 314 +++++++++++++++--------------- po/bg.po | 318 +++++++++++++++--------------- po/ca.po | 342 ++++++++++++++++---------------- po/cs.po | 338 ++++++++++++++++---------------- po/da.po | 354 +++++++++++++++++----------------- po/de.po | 504 ++++++++++++++++++++++++------------------------ po/el.po | 310 ++++++++++++++--------------- po/en.po | 444 +++++++++++++++++++++--------------------- po/en_US.po | 444 +++++++++++++++++++++--------------------- po/eo.po | 330 +++++++++++++++---------------- po/es.po | 338 ++++++++++++++++---------------- po/fa.po | 298 ++++++++++++++-------------- po/fi.po | 490 +++++++++++++++++++++++----------------------- po/fr.po | 344 ++++++++++++++++----------------- po/he.po | 346 ++++++++++++++++----------------- po/hi.po | 286 +++++++++++++-------------- po/hr.po | 350 ++++++++++++++++----------------- po/hu.po | 348 ++++++++++++++++----------------- po/it.po | 354 +++++++++++++++++----------------- po/ja.po | 478 ++++++++++++++++++++++----------------------- po/ko.po | 330 +++++++++++++++---------------- po/lt.po | 446 +++++++++++++++++++++--------------------- po/ml.po | 286 +++++++++++++-------------- po/nb_NO.po | 336 ++++++++++++++++---------------- po/nl.po | 456 +++++++++++++++++++++---------------------- po/or.po | 286 +++++++++++++-------------- po/pa.po | 286 +++++++++++++-------------- po/pl.po | 502 +++++++++++++++++++++++------------------------ po/pt_BR.po | 452 +++++++++++++++++++++---------------------- po/pt_PT.po | 344 ++++++++++++++++----------------- po/rm.po | 296 ++++++++++++++-------------- po/ro.po | 340 ++++++++++++++++---------------- po/ru.po | 330 +++++++++++++++---------------- po/si.po | 322 +++++++++++++++---------------- po/sk.po | 330 +++++++++++++++---------------- po/sl.po | 344 ++++++++++++++++----------------- po/sr_RS(a)cyrillic.po | 328 +++++++++++++++---------------- po/sr_RS(a)latin.po | 334 ++++++++++++++++---------------- po/sv.po | 336 ++++++++++++++++---------------- po/ta.po | 286 +++++++++++++-------------- po/te.po | 286 +++++++++++++-------------- po/th.po | 302 ++++++++++++++--------------- po/tr.po | 336 ++++++++++++++++---------------- po/uk.po | 330 +++++++++++++++---------------- po/wa.po | 296 ++++++++++++++-------------- po/wine.pot | 286 +++++++++++++-------------- po/zh_CN.po | 330 +++++++++++++++---------------- po/zh_TW.po | 344 ++++++++++++++++----------------- programs/reg/resource.h | 98 ++++++---- 50 files changed, 8633 insertions(+), 8619 deletions(-) Diff:
https://source.winehq.org/git/wine.git/?a=commitdiff;h=8f997a8b9b7532044971…
1
0
0
0
Hugh McMaster : reg: Remove two unused string resources.
by Alexandre Julliard
31 May '21
31 May '21
Module: wine Branch: master Commit: e4f3d51fdde4b762d2317ce7b2aa140ac030989b URL:
https://source.winehq.org/git/wine.git/?a=commit;h=e4f3d51fdde4b762d2317ce7…
Author: Hugh McMaster <hugh.mcmaster(a)outlook.com> Date: Mon May 31 19:45:20 2021 +1000 reg: Remove two unused string resources. Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- po/ar.po | 44 ++++++++++++++++---------------------------- po/ast.po | 42 ++++++++++++++++-------------------------- po/bg.po | 44 ++++++++++++++++---------------------------- po/ca.po | 44 ++++++++++++++++---------------------------- po/cs.po | 44 ++++++++++++++++---------------------------- po/da.po | 44 ++++++++++++++++---------------------------- po/de.po | 44 ++++++++++++++++---------------------------- po/el.po | 42 ++++++++++++++++-------------------------- po/en.po | 44 ++++++++++++++++---------------------------- po/en_US.po | 44 ++++++++++++++++---------------------------- po/eo.po | 44 ++++++++++++++++---------------------------- po/es.po | 42 ++++++++++++++++-------------------------- po/fa.po | 43 ++++++++++++++++--------------------------- po/fi.po | 44 ++++++++++++++++---------------------------- po/fr.po | 46 ++++++++++++++++------------------------------ po/he.po | 44 ++++++++++++++++---------------------------- po/hi.po | 42 ++++++++++++++++-------------------------- po/hr.po | 44 ++++++++++++++++---------------------------- po/hu.po | 44 ++++++++++++++++---------------------------- po/it.po | 44 ++++++++++++++++---------------------------- po/ja.po | 43 ++++++++++++++++--------------------------- po/ko.po | 43 ++++++++++++++++--------------------------- po/lt.po | 42 ++++++++++++++++-------------------------- po/ml.po | 42 ++++++++++++++++-------------------------- po/nb_NO.po | 44 ++++++++++++++++---------------------------- po/nl.po | 44 ++++++++++++++++---------------------------- po/or.po | 42 ++++++++++++++++-------------------------- po/pa.po | 42 ++++++++++++++++-------------------------- po/pl.po | 44 ++++++++++++++++---------------------------- po/pt_BR.po | 44 ++++++++++++++++---------------------------- po/pt_PT.po | 44 ++++++++++++++++---------------------------- po/rm.po | 43 ++++++++++++++++--------------------------- po/ro.po | 44 ++++++++++++++++---------------------------- po/ru.po | 42 ++++++++++++++++-------------------------- po/si.po | 42 ++++++++++++++++-------------------------- po/sk.po | 44 ++++++++++++++++---------------------------- po/sl.po | 44 ++++++++++++++++---------------------------- po/sr_RS(a)cyrillic.po | 44 ++++++++++++++++---------------------------- po/sr_RS(a)latin.po | 44 ++++++++++++++++---------------------------- po/sv.po | 43 ++++++++++++++++--------------------------- po/ta.po | 42 ++++++++++++++++-------------------------- po/te.po | 42 ++++++++++++++++-------------------------- po/th.po | 43 ++++++++++++++++--------------------------- po/tr.po | 42 ++++++++++++++++-------------------------- po/uk.po | 43 ++++++++++++++++--------------------------- po/wa.po | 43 ++++++++++++++++--------------------------- po/wine.pot | 42 ++++++++++++++++-------------------------- po/zh_CN.po | 42 ++++++++++++++++-------------------------- po/zh_TW.po | 44 ++++++++++++++++---------------------------- programs/reg/reg.rc | 2 -- programs/reg/resource.h | 2 -- 51 files changed, 784 insertions(+), 1340 deletions(-) Diff:
https://source.winehq.org/git/wine.git/?a=commitdiff;h=e4f3d51fdde4b762d231…
1
0
0
0
← Newer
1
2
3
4
5
...
77
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
Results per page:
10
25
50
100
200