wine-commits July 2021

wine-commits@winehq.org

1 participants
728 discussions

Jacek Caban : gdi32: Use ntgdi name for GetPixel.
by Alexandre Julliard 23 Jul '21

23 Jul '21

Module: wine Branch: master Commit: ccb6fbba76d4259adafa634874219672ec6c6d93 URL: https://source.winehq.org/git/wine.git/?a=commit;h=ccb6fbba76d4259adafa6348… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Jul 23 10:52:06 2021 +0200 gdi32: Use ntgdi name for GetPixel. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdi32/gdi32.spec | 2 +- dlls/gdi32/painting.c | 4 ++-- include/ntgdi.h | 3 ++- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/dlls/gdi32/gdi32.spec b/dlls/gdi32/gdi32.spec index 6974f3cb873..299b84268a5 100644 --- a/dlls/gdi32/gdi32.spec +++ b/dlls/gdi32/gdi32.spec @@ -327,7 +327,7 @@ @ stdcall GetOutlineTextMetricsW(long long ptr) @ stdcall GetPaletteEntries(long long long ptr) @ stdcall GetPath(long ptr ptr long) -@ stdcall GetPixel(long long long) +@ stdcall GetPixel(long long long) NtGdiGetPixel @ stdcall GetPixelFormat(long) @ stdcall GetPolyFillMode(long) @ stdcall GetROP2(long) diff --git a/dlls/gdi32/painting.c b/dlls/gdi32/painting.c index 21c3c853998..c879aeb9582 100644 --- a/dlls/gdi32/painting.c +++ b/dlls/gdi32/painting.c @@ -416,9 +416,9 @@ COLORREF WINAPI NtGdiSetPixel( HDC hdc, INT x, INT y, COLORREF color ) } /*********************************************************************** - * GetPixel (GDI32.@) + * NtGdiGetPixel (win32u.@) */ -COLORREF WINAPI GetPixel( HDC hdc, INT x, INT y ) +COLORREF WINAPI NtGdiGetPixel( HDC hdc, INT x, INT y ) { PHYSDEV physdev; COLORREF ret; diff --git a/include/ntgdi.h b/include/ntgdi.h index 56921d68fc3..2cf0a6f681e 100644 --- a/include/ntgdi.h +++ b/include/ntgdi.h @@ -166,8 +166,9 @@ BOOL WINAPI NtGdiGetMiterLimit( HDC hdc, FLOAT *limit ); COLORREF WINAPI NtGdiGetNearestColor( HDC hdc, COLORREF color ); UINT WINAPI NtGdiGetNearestPaletteIndex( HPALETTE hpalette, COLORREF color ); UINT WINAPI NtGdiGetOutlineTextMetricsInternalW( HDC hdc, UINT cbData, - OUTLINETEXTMETRICW *otm, ULONG opts); + OUTLINETEXTMETRICW *otm, ULONG opts ); INT WINAPI NtGdiGetPath( HDC hdc, POINT *points, BYTE *types, INT size ); +COLORREF WINAPI NtGdiGetPixel( HDC hdc, INT x, INT y ); INT WINAPI NtGdiGetRandomRgn( HDC hdc, HRGN region, INT code ); DWORD WINAPI NtGdiGetRegionData( HRGN hrgn, DWORD count, RGNDATA *data ); INT WINAPI NtGdiGetRgnBox( HRGN hrgn, RECT *rect );

1 0

Jacek Caban : gdi32: Use SetPixel for SetPixelV implementation.
by Alexandre Julliard 23 Jul '21

23 Jul '21

Module: wine Branch: master Commit: e7b9a16bc2d3beb457c219be7878cded46b738c2 URL: https://source.winehq.org/git/wine.git/?a=commit;h=e7b9a16bc2d3beb457c219be… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Jul 23 10:51:51 2021 +0200 gdi32: Use SetPixel for SetPixelV implementation. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdi32/gdidc.c | 8 ++++++++ dlls/gdi32/painting.c | 16 ---------------- dlls/gdi32/tests/metafile.c | 1 - 3 files changed, 8 insertions(+), 17 deletions(-) diff --git a/dlls/gdi32/gdidc.c b/dlls/gdi32/gdidc.c index 0bfc48f3fcc..74280bc34b5 100644 --- a/dlls/gdi32/gdidc.c +++ b/dlls/gdi32/gdidc.c @@ -70,6 +70,14 @@ COLORREF WINAPI SetPixel( HDC hdc, INT x, INT y, COLORREF color ) return NtGdiSetPixel( hdc, x, y, color ); } +/*********************************************************************** + * SetPixelV (GDI32.@) + */ +BOOL WINAPI SetPixelV( HDC hdc, INT x, INT y, COLORREF color ) +{ + return SetPixel( hdc, x, y, color ) != CLR_INVALID; +} + /*********************************************************************** * LineTo (GDI32.@) */ diff --git a/dlls/gdi32/painting.c b/dlls/gdi32/painting.c index 1e03a2046d9..21c3c853998 100644 --- a/dlls/gdi32/painting.c +++ b/dlls/gdi32/painting.c @@ -415,22 +415,6 @@ COLORREF WINAPI NtGdiSetPixel( HDC hdc, INT x, INT y, COLORREF color ) return ret; } -/*********************************************************************** - * SetPixelV (GDI32.@) - */ -BOOL WINAPI SetPixelV( HDC hdc, INT x, INT y, COLORREF color ) -{ - PHYSDEV physdev; - DC * dc = get_dc_ptr( hdc ); - - if (!dc) return FALSE; - update_dc( dc ); - physdev = GET_DC_PHYSDEV( dc, pSetPixel ); - physdev->funcs->pSetPixel( physdev, x, y, color ); - release_dc_ptr( dc ); - return TRUE; -} - /*********************************************************************** * GetPixel (GDI32.@) */ diff --git a/dlls/gdi32/tests/metafile.c b/dlls/gdi32/tests/metafile.c index d310eb47fa2..5f626e83901 100644 --- a/dlls/gdi32/tests/metafile.c +++ b/dlls/gdi32/tests/metafile.c @@ -3231,7 +3231,6 @@ static void test_emf_SetPixel(void) ok(c == CLR_INVALID, "c = %x\n", c); ret = SetPixelV(hdc, 5, 5, RGB(1,2,3)); - todo_wine ok(!ret, "ret = %x\n", ret); c = GetPixel(hdc, 5, 5);

1 0

Jacek Caban : gdi32: Use NtGdiSetPixel for SetPixel implementation.
by Alexandre Julliard 23 Jul '21

23 Jul '21

Module: wine Branch: master Commit: 5a71d8415e82f62661006431d92139bbc5349093 URL: https://source.winehq.org/git/wine.git/?a=commit;h=5a71d8415e82f62661006431… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Jul 23 10:51:16 2021 +0200 gdi32: Use NtGdiSetPixel for SetPixel implementation. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdi32/enhmfdrv/graphics.c | 24 ++++++++------ dlls/gdi32/gdi_private.h | 2 ++ dlls/gdi32/gdidc.c | 13 ++++++++ dlls/gdi32/mfdrv/graphics.c | 7 ++-- dlls/gdi32/mfdrv/init.c | 2 +- dlls/gdi32/mfdrv/metafiledrv.h | 1 - dlls/gdi32/painting.c | 6 ++-- dlls/gdi32/tests/metafile.c | 72 ++++++++++++++++++++++++++++++++++++++++++ 8 files changed, 108 insertions(+), 19 deletions(-) diff --git a/dlls/gdi32/enhmfdrv/graphics.c b/dlls/gdi32/enhmfdrv/graphics.c index d4fd2b482ef..fcaf432b57e 100644 --- a/dlls/gdi32/enhmfdrv/graphics.c +++ b/dlls/gdi32/enhmfdrv/graphics.c @@ -524,9 +524,9 @@ BOOL CDECL EMFDRV_RoundRect( PHYSDEV dev, INT left, INT top, INT right, } /*********************************************************************** - * EMFDRV_SetPixel + * EMFDC_SetPixel */ -COLORREF CDECL EMFDRV_SetPixel( PHYSDEV dev, INT x, INT y, COLORREF color ) +BOOL EMFDC_SetPixel( DC_ATTR *dc_attr, INT x, INT y, COLORREF color ) { EMRSETPIXELV emr; @@ -535,15 +535,19 @@ COLORREF CDECL EMFDRV_SetPixel( PHYSDEV dev, INT x, INT y, COLORREF color ) emr.ptlPixel.x = x; emr.ptlPixel.y = y; emr.crColor = color; + return EMFDRV_WriteRecord( dc_attr->emf, &emr.emr ); +} - if (EMFDRV_WriteRecord( dev, &emr.emr )) { - RECTL bounds; - bounds.left = bounds.right = x; - bounds.top = bounds.bottom = y; - EMFDRV_UpdateBBox( dev, &bounds ); - return color; - } - return -1; +/*********************************************************************** + * EMFDRV_SetPixel + */ +COLORREF CDECL EMFDRV_SetPixel( PHYSDEV dev, INT x, INT y, COLORREF color ) +{ + RECTL bounds; + bounds.left = bounds.right = x; + bounds.top = bounds.bottom = y; + EMFDRV_UpdateBBox( dev, &bounds ); + return CLR_INVALID; } /********************************************************************** diff --git a/dlls/gdi32/gdi_private.h b/dlls/gdi32/gdi_private.h index a95053ea44c..481bc14d7f3 100644 --- a/dlls/gdi32/gdi_private.h +++ b/dlls/gdi32/gdi_private.h @@ -60,6 +60,7 @@ extern BOOL METADC_Polyline( HDC hdc, const POINT *points,INT count) DECLSPEC_HI extern BOOL METADC_Rectangle( HDC hdc, INT left, INT top, INT right, INT bottom) DECLSPEC_HIDDEN; extern BOOL METADC_RoundRect( HDC hdc, INT left, INT top, INT right, INT bottom, INT ell_width, INT ell_height ) DECLSPEC_HIDDEN; +extern BOOL METADC_SetPixel( HDC hdc, INT x, INT y, COLORREF color ) DECLSPEC_HIDDEN; /* enhanced metafiles */ extern BOOL EMFDC_AbortPath( DC_ATTR *dc_attr ) DECLSPEC_HIDDEN; @@ -92,5 +93,6 @@ extern BOOL EMFDC_Rectangle( DC_ATTR *dc_attr, INT left, INT top, INT right, INT bottom) DECLSPEC_HIDDEN; extern BOOL EMFDC_RoundRect( DC_ATTR *dc_attr, INT left, INT top, INT right, INT bottom, INT ell_width, INT ell_height ) DECLSPEC_HIDDEN; +extern BOOL EMFDC_SetPixel( DC_ATTR *dc_attr, INT x, INT y, COLORREF color ) DECLSPEC_HIDDEN; #endif /* __WINE_GDI_PRIVATE_H */ diff --git a/dlls/gdi32/gdidc.c b/dlls/gdi32/gdidc.c index 04d90a5e0ba..0bfc48f3fcc 100644 --- a/dlls/gdi32/gdidc.c +++ b/dlls/gdi32/gdidc.c @@ -57,6 +57,19 @@ BOOL WINAPI GetCurrentPositionEx( HDC hdc, POINT *point ) return TRUE; } +/*********************************************************************** + * SetPixel (GDI32.@) + */ +COLORREF WINAPI SetPixel( HDC hdc, INT x, INT y, COLORREF color ) +{ + DC_ATTR *dc_attr; + + if (is_meta_dc( hdc )) return METADC_SetPixel( hdc, x, y, color ); + if (!(dc_attr = get_dc_attr( hdc ))) return CLR_INVALID; + if (dc_attr->emf && !EMFDC_SetPixel( dc_attr, x, y, color )) return CLR_INVALID; + return NtGdiSetPixel( hdc, x, y, color ); +} + /*********************************************************************** * LineTo (GDI32.@) */ diff --git a/dlls/gdi32/mfdrv/graphics.c b/dlls/gdi32/mfdrv/graphics.c index d5f256346f9..8b74c1a3696 100644 --- a/dlls/gdi32/mfdrv/graphics.c +++ b/dlls/gdi32/mfdrv/graphics.c @@ -116,12 +116,11 @@ BOOL METADC_RoundRect( HDC hdc, INT left, INT top, INT right, } /*********************************************************************** - * MFDRV_SetPixel + * METADC_SetPixel */ -COLORREF CDECL MFDRV_SetPixel( PHYSDEV dev, INT x, INT y, COLORREF color ) +BOOL METADC_SetPixel( HDC hdc, INT x, INT y, COLORREF color ) { - return MFDRV_MetaParam4(dev, META_SETPIXEL, x, y,HIWORD(color), - LOWORD(color)); + return metadc_param4( hdc, META_SETPIXEL, x, y, HIWORD(color), LOWORD(color) ); } diff --git a/dlls/gdi32/mfdrv/init.c b/dlls/gdi32/mfdrv/init.c index b37dc5c6d92..f53f8304a8e 100644 --- a/dlls/gdi32/mfdrv/init.c +++ b/dlls/gdi32/mfdrv/init.c @@ -202,7 +202,7 @@ static const struct gdi_dc_funcs MFDRV_Funcs = MFDRV_SetLayout, /* pSetLayout */ MFDRV_SetMapMode, /* pSetMapMode */ MFDRV_SetMapperFlags, /* pSetMapperFlags */ - MFDRV_SetPixel, /* pSetPixel */ + NULL, /* pSetPixel */ MFDRV_SetPolyFillMode, /* pSetPolyFillMode */ MFDRV_SetROP2, /* pSetROP2 */ MFDRV_SetRelAbs, /* pSetRelAbs */ diff --git a/dlls/gdi32/mfdrv/metafiledrv.h b/dlls/gdi32/mfdrv/metafiledrv.h index 3fad2970e64..6b4984854ed 100644 --- a/dlls/gdi32/mfdrv/metafiledrv.h +++ b/dlls/gdi32/mfdrv/metafiledrv.h @@ -112,7 +112,6 @@ extern COLORREF CDECL MFDRV_SetDCPenColor( PHYSDEV dev, COLORREF color ) DECLSPE extern DWORD CDECL MFDRV_SetLayout( PHYSDEV dev, DWORD layout ) DECLSPEC_HIDDEN; extern INT CDECL MFDRV_SetMapMode( PHYSDEV dev, INT mode ) DECLSPEC_HIDDEN; extern DWORD CDECL MFDRV_SetMapperFlags( PHYSDEV dev, DWORD flags ) DECLSPEC_HIDDEN; -extern COLORREF CDECL MFDRV_SetPixel( PHYSDEV dev, INT x, INT y, COLORREF color ) DECLSPEC_HIDDEN; extern INT CDECL MFDRV_SetPolyFillMode( PHYSDEV dev, INT mode ) DECLSPEC_HIDDEN; extern INT CDECL MFDRV_SetROP2( PHYSDEV dev, INT rop ) DECLSPEC_HIDDEN; extern INT CDECL MFDRV_SetRelAbs( PHYSDEV dev, INT mode ) DECLSPEC_HIDDEN; diff --git a/dlls/gdi32/painting.c b/dlls/gdi32/painting.c index 803b9797736..1e03a2046d9 100644 --- a/dlls/gdi32/painting.c +++ b/dlls/gdi32/painting.c @@ -399,15 +399,15 @@ BOOL WINAPI NtGdiRoundRect( HDC hdc, INT left, INT top, INT right, } /*********************************************************************** - * SetPixel (GDI32.@) + * NtGdiSetPixel (win32u.@) */ -COLORREF WINAPI SetPixel( HDC hdc, INT x, INT y, COLORREF color ) +COLORREF WINAPI NtGdiSetPixel( HDC hdc, INT x, INT y, COLORREF color ) { PHYSDEV physdev; COLORREF ret; DC * dc = get_dc_ptr( hdc ); - if (!dc) return ~0; + if (!dc) return CLR_INVALID; update_dc( dc ); physdev = GET_DC_PHYSDEV( dc, pSetPixel ); ret = physdev->funcs->pSetPixel( physdev, x, y, color ); diff --git a/dlls/gdi32/tests/metafile.c b/dlls/gdi32/tests/metafile.c index 34de9518f2a..d310eb47fa2 100644 --- a/dlls/gdi32/tests/metafile.c +++ b/dlls/gdi32/tests/metafile.c @@ -3077,6 +3077,42 @@ static void test_metafile_file(void) ok(GetLastError() == ERROR_INVALID_HANDLE, "GetLastError() = %u\n", GetLastError()); } +static void test_mf_SetPixel(void) +{ + HMETAFILE mf; + COLORREF c; + BOOL ret; + HDC hdc; + + hdc = CreateMetaFileW(NULL); + ok(hdc != 0, "CreateEnhMetaFile failed\n"); + + c = GetPixel(hdc, 5, 5); + ok(c == CLR_INVALID, "c = %x\n", c); + + c = SetPixel(hdc, 5, 5, RGB(1,2,3)); + ok(c == 1, "c = %x\n", c); + + c = SetPixel(hdc, 5, 5, RGB(1,2,3)); + ok(c == 1, "c = %x\n", c); + + ret = SetPixelV(hdc, 5, 5, RGB(1,2,3)); + ok(ret, "ret = %x\n", ret); + + c = GetPixel(hdc, 5, 5); + ok(c == CLR_INVALID, "c = %x\n", c); + + ret = Rectangle(hdc, 1, 1, 10, 10); + ok(ret, "Rectangle failed\n"); + + c = GetPixel(hdc, 5, 5); + ok(c == CLR_INVALID, "c = %x\n", c); + + mf = CloseMetaFile(hdc); + ok(mf != 0, "CloseEnhMetaFile failed\n"); + DeleteMetaFile(mf); +} + static void test_enhmetafile_file(void) { char temp_path[MAX_PATH]; @@ -3178,6 +3214,40 @@ static void test_enhmetafile_file(void) ok(GetLastError() == ERROR_INVALID_HANDLE, "GetLastError() = %u\n", GetLastError()); } +static void test_emf_SetPixel(void) +{ + HENHMETAFILE emf; + COLORREF c; + BOOL ret; + HDC hdc; + + hdc = CreateEnhMetaFileW(NULL, L"test.emf", NULL, NULL); + ok(hdc != 0, "CreateEnhMetaFile failed\n"); + + c = GetPixel(hdc, 5, 5); + ok(c == CLR_INVALID, "c = %x\n", c); + + c = SetPixel(hdc, 5, 5, RGB(1,2,3)); + ok(c == CLR_INVALID, "c = %x\n", c); + + ret = SetPixelV(hdc, 5, 5, RGB(1,2,3)); + todo_wine + ok(!ret, "ret = %x\n", ret); + + c = GetPixel(hdc, 5, 5); + ok(c == CLR_INVALID, "c = %x\n", c); + + ret = Rectangle(hdc, 1, 1, 10, 10); + ok(ret, "Rectangle failed\n"); + + c = GetPixel(hdc, 5, 5); + ok(c == CLR_INVALID, "c = %x\n", c); + + emf = CloseEnhMetaFile(hdc); + ok(emf != 0, "CloseEnhMetaFile failed\n"); + DeleteEnhMetaFile(emf); +} + static void test_CopyMetaFile(void) { HDC hdcMetafile; @@ -6272,6 +6342,7 @@ START_TEST(metafile) test_emf_WorldTransform(); test_emf_text_extents(); test_enhmetafile_file(); + test_emf_SetPixel(); /* For win-format metafiles (mfdrv) */ test_mf_SaveDC(); @@ -6286,6 +6357,7 @@ START_TEST(metafile) test_mf_GetPath(); test_mf_SetLayout(); test_metafile_file(); + test_mf_SetPixel(); /* For metafile conversions */ test_mf_conversions();

1 0

Jacek Caban : gdi32: Remove no longer used EMF path driver.
by Alexandre Julliard 23 Jul '21

23 Jul '21

Module: wine Branch: master Commit: 0bc43b3a920288b6c39fd1492440d0805f49f5c8 URL: https://source.winehq.org/git/wine.git/?a=commit;h=0bc43b3a920288b6c39fd149… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Jul 23 10:50:59 2021 +0200 gdi32: Remove no longer used EMF path driver. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdi32/enhmfdrv/dc.c | 204 ----------------------------------- dlls/gdi32/enhmfdrv/enhmetafiledrv.h | 1 - 2 files changed, 205 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=0bc43b3a920288b6c39f…

1 0

Jacek Caban : gdi32: Use ntgdi interface for path functions.
by Alexandre Julliard 23 Jul '21

23 Jul '21

Module: wine Branch: master Commit: 972cfaca1fd58bf399e033ee0b576e789404797a URL: https://source.winehq.org/git/wine.git/?a=commit;h=972cfaca1fd58bf399e033ee… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Jul 23 10:50:37 2021 +0200 gdi32: Use ntgdi interface for path functions. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdi32/enhmfdrv/dc.c | 27 ++++++++++++--------------- dlls/gdi32/enhmfdrv/enhmetafiledrv.h | 3 --- dlls/gdi32/enhmfdrv/init.c | 6 +++--- dlls/gdi32/gdi_private.h | 3 +++ dlls/gdi32/gdidc.c | 36 ++++++++++++++++++++++++++++++++++++ dlls/gdi32/path.c | 29 +++++++++-------------------- dlls/gdi32/tests/metafile.c | 22 ++++++++++++++-------- 7 files changed, 77 insertions(+), 49 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=972cfaca1fd58bf399e0…

1 0

Jacek Caban : gdi32: Use NtGdiCloseFigure for CloseFigure implementation.
by Alexandre Julliard 23 Jul '21

23 Jul '21

Module: wine Branch: master Commit: 0f3173e7d97bfcd4a189cee1916f1bc1e0fb47b7 URL: https://source.winehq.org/git/wine.git/?a=commit;h=0f3173e7d97bfcd4a189cee1… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Jul 23 10:50:13 2021 +0200 gdi32: Use NtGdiCloseFigure for CloseFigure implementation. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdi32/enhmfdrv/dc.c | 19 +++---------------- dlls/gdi32/enhmfdrv/enhmetafiledrv.h | 1 - dlls/gdi32/enhmfdrv/init.c | 4 ++-- dlls/gdi32/gdi_private.h | 1 + dlls/gdi32/gdidc.c | 12 ++++++++++++ dlls/gdi32/path.c | 6 ++---- 6 files changed, 20 insertions(+), 23 deletions(-) diff --git a/dlls/gdi32/enhmfdrv/dc.c b/dlls/gdi32/enhmfdrv/dc.c index 7c7c060a53b..855f01970d4 100644 --- a/dlls/gdi32/enhmfdrv/dc.c +++ b/dlls/gdi32/enhmfdrv/dc.c @@ -513,15 +513,14 @@ BOOL CDECL EMFDRV_BeginPath( PHYSDEV dev ) return TRUE; } -BOOL CDECL EMFDRV_CloseFigure( PHYSDEV dev ) +BOOL EMFDC_CloseFigure( DC_ATTR *dc_attr ) { EMRCLOSEFIGURE emr; emr.emr.iType = EMR_CLOSEFIGURE; emr.emr.nSize = sizeof(emr); - EMFDRV_WriteRecord( dev, &emr.emr ); - return FALSE; /* always fails without a path */ + return EMFDRV_WriteRecord( dc_attr->emf, &emr.emr ); } BOOL CDECL EMFDRV_EndPath( PHYSDEV dev ) @@ -611,18 +610,6 @@ static BOOL CDECL emfpathdrv_BeginPath( PHYSDEV dev ) return (emfdev->funcs->pBeginPath( emfdev ) && next->funcs->pBeginPath( next )); } -/*********************************************************************** - * emfpathdrv_CloseFigure - */ -static BOOL CDECL emfpathdrv_CloseFigure( PHYSDEV dev ) -{ - PHYSDEV emfdev = get_emfdev( dev ); - PHYSDEV next = GET_NEXT_PHYSDEV( dev, pCloseFigure ); - - emfdev->funcs->pCloseFigure( emfdev ); - return next->funcs->pCloseFigure( next ); -} - /*********************************************************************** * emfpathdrv_CreateDC */ @@ -670,7 +657,7 @@ static const struct gdi_dc_funcs emfpath_driver = emfpathdrv_BeginPath, /* pBeginPath */ NULL, /* pBlendImage */ NULL, /* pChord */ - emfpathdrv_CloseFigure, /* pCloseFigure */ + NULL, /* pCloseFigure */ NULL, /* pCreateCompatibleDC */ emfpathdrv_CreateDC, /* pCreateDC */ emfpathdrv_DeleteDC, /* pDeleteDC */ diff --git a/dlls/gdi32/enhmfdrv/enhmetafiledrv.h b/dlls/gdi32/enhmfdrv/enhmetafiledrv.h index 128b157c45a..554f55973f6 100644 --- a/dlls/gdi32/enhmfdrv/enhmetafiledrv.h +++ b/dlls/gdi32/enhmfdrv/enhmetafiledrv.h @@ -71,7 +71,6 @@ extern BOOL CDECL EMFDRV_BitBlt( PHYSDEV devDst, INT xDst, INT yDst, INT wid PHYSDEV devSrc, INT xSrc, INT ySrc, DWORD rop ) DECLSPEC_HIDDEN; extern BOOL CDECL EMFDRV_Chord( PHYSDEV dev, INT left, INT top, INT right, INT bottom, INT xstart, INT ystart, INT xend, INT yend ) DECLSPEC_HIDDEN; -extern BOOL CDECL EMFDRV_CloseFigure( PHYSDEV dev ) DECLSPEC_HIDDEN; extern BOOL CDECL EMFDRV_DeleteObject( PHYSDEV dev, HGDIOBJ obj ) DECLSPEC_HIDDEN; extern BOOL CDECL EMFDRV_Ellipse( PHYSDEV dev, INT left, INT top, INT right, INT bottom ) DECLSPEC_HIDDEN; extern BOOL CDECL EMFDRV_EndPath( PHYSDEV dev ) DECLSPEC_HIDDEN; diff --git a/dlls/gdi32/enhmfdrv/init.c b/dlls/gdi32/enhmfdrv/init.c index 0aac934a87b..4e7105b1b80 100644 --- a/dlls/gdi32/enhmfdrv/init.c +++ b/dlls/gdi32/enhmfdrv/init.c @@ -44,8 +44,8 @@ static const struct gdi_dc_funcs emfdrv_driver = EMFDRV_ArcTo, /* pArcTo */ EMFDRV_BeginPath, /* pBeginPath */ NULL, /* pBlendImage */ - EMFDRV_Chord, /* pChord */ - EMFDRV_CloseFigure, /* pCloseFigure */ + NULL, /* pChord */ + NULL, /* pCloseFigure */ NULL, /* pCreateCompatibleDC */ NULL, /* pCreateDC */ EMFDRV_DeleteDC, /* pDeleteDC */ diff --git a/dlls/gdi32/gdi_private.h b/dlls/gdi32/gdi_private.h index ea670732f96..829dacd073c 100644 --- a/dlls/gdi32/gdi_private.h +++ b/dlls/gdi32/gdi_private.h @@ -67,6 +67,7 @@ extern BOOL EMFDC_AngleArc( DC_ATTR *dc_attr, INT x, INT y, DWORD radius, FLOAT extern BOOL EMFDC_ArcChordPie( DC_ATTR *dc_attr, INT left, INT top, INT right, INT bottom, INT xstart, INT ystart, INT xend, INT yend, DWORD type ) DECLSPEC_HIDDEN; +extern BOOL EMFDC_CloseFigure( DC_ATTR *dc_attr ) DECLSPEC_HIDDEN; extern BOOL EMFDC_Ellipse( DC_ATTR *dc_attr, INT left, INT top, INT right, INT bottom ) DECLSPEC_HIDDEN; extern BOOL EMFDC_ExtTextOut( DC_ATTR *dc_attr, INT x, INT y, UINT flags, const RECT *rect, diff --git a/dlls/gdi32/gdidc.c b/dlls/gdi32/gdidc.c index 9200803b6f0..1d2ad9766c4 100644 --- a/dlls/gdi32/gdidc.c +++ b/dlls/gdi32/gdidc.c @@ -375,3 +375,15 @@ BOOL WINAPI ExtTextOutW( HDC hdc, INT x, INT y, UINT flags, const RECT *rect, return FALSE; return NtGdiExtTextOutW( hdc, x, y, flags, rect, str, count, dx, 0 ); } + +/*********************************************************************** + * CloseFigure (GDI32.@) + */ +BOOL WINAPI CloseFigure( HDC hdc ) +{ + DC_ATTR *dc_attr; + + if (!(dc_attr = get_dc_attr( hdc ))) return FALSE; + if (dc_attr->emf && !EMFDC_CloseFigure( dc_attr )) return FALSE; + return NtGdiCloseFigure( hdc ); +} diff --git a/dlls/gdi32/path.c b/dlls/gdi32/path.c index 3646ba91079..fc9a4d4721f 100644 --- a/dlls/gdi32/path.c +++ b/dlls/gdi32/path.c @@ -617,11 +617,9 @@ BOOL WINAPI AbortPath( HDC hdc ) /*********************************************************************** - * CloseFigure (GDI32.@) - * - * FIXME: Check that SetLastError is being called correctly + * NtGdiCloseFigure (win32u.@) */ -BOOL WINAPI CloseFigure(HDC hdc) +BOOL WINAPI NtGdiCloseFigure( HDC hdc ) { BOOL ret = FALSE; DC *dc = get_dc_ptr( hdc );

1 0

Jacek Caban : gdi32: Use NtGdiExtTextOutW for ExtTextOutW implementation.
by Alexandre Julliard 23 Jul '21

23 Jul '21

Module: wine Branch: master Commit: cc7e7002ef8f92f47fe047d598dce057fcc2885b URL: https://source.winehq.org/git/wine.git/?a=commit;h=cc7e7002ef8f92f47fe047d5… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Jul 23 10:49:42 2021 +0200 gdi32: Use NtGdiExtTextOutW for ExtTextOutW implementation. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdi32/enhmfdrv/dc.c | 15 +-------------- dlls/gdi32/enhmfdrv/graphics.c | 41 +++++++++++++++++++++++++---------------- dlls/gdi32/font.c | 6 +++--- dlls/gdi32/gdi_private.h | 4 ++++ dlls/gdi32/gdidc.c | 15 +++++++++++++++ dlls/gdi32/mfdrv/init.c | 2 +- dlls/gdi32/mfdrv/metafiledrv.h | 2 -- dlls/gdi32/mfdrv/text.c | 20 ++++++++++---------- include/ntgdi.h | 2 ++ 9 files changed, 61 insertions(+), 46 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=cc7e7002ef8f92f47fe0…

1 0

Jacek Caban : gdi32: Store text alignment in DC_ATTR.
by Alexandre Julliard 23 Jul '21

23 Jul '21

Module: wine Branch: master Commit: aca66fb50399b862ca91a6a2e6a56a81f8bcdfdb URL: https://source.winehq.org/git/wine.git/?a=commit;h=aca66fb50399b862ca91a6a2… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Jul 23 10:49:19 2021 +0200 gdi32: Store text alignment in DC_ATTR. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdi32/dc.c | 26 +++++--------------------- dlls/gdi32/enhmfdrv/graphics.c | 2 +- dlls/gdi32/font.c | 2 +- dlls/gdi32/gdidc.c | 9 +++++++++ dlls/gdi32/ntgdi_private.h | 1 - include/ntgdi.h | 1 + 6 files changed, 17 insertions(+), 24 deletions(-) diff --git a/dlls/gdi32/dc.c b/dlls/gdi32/dc.c index 2573390c6f2..deca9510f20 100644 --- a/dlls/gdi32/dc.c +++ b/dlls/gdi32/dc.c @@ -94,7 +94,7 @@ static void set_initial_dc_state( DC *dc ) dc->brush_org.x = 0; dc->brush_org.y = 0; dc->mapperFlags = 0; - dc->textAlign = TA_LEFT | TA_TOP | TA_NOUPDATECP; + dc->attr->text_align = TA_LEFT | TA_TOP | TA_NOUPDATECP; dc->charExtra = 0; dc->breakExtra = 0; dc->breakRem = 0; @@ -409,7 +409,7 @@ INT CDECL nulldrv_SaveDC( PHYSDEV dev ) newdc->dcPenColor = dc->dcPenColor; newdc->brush_org = dc->brush_org; newdc->mapperFlags = dc->mapperFlags; - newdc->textAlign = dc->textAlign; + newdc->attr->text_align = dc->attr->text_align; newdc->charExtra = dc->charExtra; newdc->breakExtra = dc->breakExtra; newdc->breakRem = dc->breakRem; @@ -486,7 +486,7 @@ BOOL CDECL nulldrv_RestoreDC( PHYSDEV dev, INT level ) dc->dcPenColor = dcs->dcPenColor; dc->brush_org = dcs->brush_org; dc->mapperFlags = dcs->mapperFlags; - dc->textAlign = dcs->textAlign; + dc->attr->text_align = dcs->attr->text_align; dc->charExtra = dcs->charExtra; dc->breakExtra = dcs->breakExtra; dc->breakRem = dcs->breakRem; @@ -988,22 +988,6 @@ COLORREF WINAPI SetTextColor( HDC hdc, COLORREF color ) } -/*********************************************************************** - * GetTextAlign (GDI32.@) - */ -UINT WINAPI GetTextAlign( HDC hdc ) -{ - UINT ret = 0; - DC * dc = get_dc_ptr( hdc ); - if (dc) - { - ret = dc->textAlign; - release_dc_ptr( dc ); - } - return ret; -} - - /*********************************************************************** * SetTextAlign (GDI32.@) */ @@ -1020,8 +1004,8 @@ UINT WINAPI SetTextAlign( HDC hdc, UINT align ) align = physdev->funcs->pSetTextAlign( physdev, align ); if (align != GDI_ERROR) { - ret = dc->textAlign; - dc->textAlign = align; + ret = dc->attr->text_align; + dc->attr->text_align = align; } release_dc_ptr( dc ); } diff --git a/dlls/gdi32/enhmfdrv/graphics.c b/dlls/gdi32/enhmfdrv/graphics.c index 7c800148cf8..67def307f1e 100644 --- a/dlls/gdi32/enhmfdrv/graphics.c +++ b/dlls/gdi32/enhmfdrv/graphics.c @@ -936,7 +936,7 @@ BOOL CDECL EMFDRV_ExtTextOut( PHYSDEV dev, INT x, INT y, UINT flags, const RECT BOOL ret; int textHeight = 0; int textWidth = 0; - const UINT textAlign = dc->textAlign; + const UINT textAlign = dc->attr->text_align; const INT graphicsMode = dc->attr->graphics_mode; FLOAT exScale, eyScale; diff --git a/dlls/gdi32/font.c b/dlls/gdi32/font.c index 41d6f9dda69..d89f9182b9b 100644 --- a/dlls/gdi32/font.c +++ b/dlls/gdi32/font.c @@ -5949,7 +5949,7 @@ BOOL WINAPI ExtTextOutW( HDC hdc, INT x, INT y, UINT flags, if (!dc) return FALSE; if (count > INT_MAX) return FALSE; - align = dc->textAlign; + align = dc->attr->text_align; breakRem = dc->breakRem; layout = dc->layout; diff --git a/dlls/gdi32/gdidc.c b/dlls/gdi32/gdidc.c index c6a8cbd567f..e2161d062b8 100644 --- a/dlls/gdi32/gdidc.c +++ b/dlls/gdi32/gdidc.c @@ -37,6 +37,15 @@ static DC_ATTR *get_dc_attr( HDC hdc ) return dc_attr; } +/*********************************************************************** + * GetTextAlign (GDI32.@) + */ +UINT WINAPI GetTextAlign( HDC hdc ) +{ + DC_ATTR *dc_attr = get_dc_attr( hdc ); + return dc_attr ? dc_attr->text_align : 0; +} + /*********************************************************************** * GetCurrentPositionEx (GDI32.@) */ diff --git a/dlls/gdi32/ntgdi_private.h b/dlls/gdi32/ntgdi_private.h index 4527651bb33..dc36789fdec 100644 --- a/dlls/gdi32/ntgdi_private.h +++ b/dlls/gdi32/ntgdi_private.h @@ -130,7 +130,6 @@ typedef struct tagDC POINT brush_org; DWORD mapperFlags; /* Font mapper flags */ - WORD textAlign; /* Text alignment from SetTextAlign() */ INT charExtra; /* Spacing from SetTextCharacterExtra() */ INT breakExtra; /* breakTotalExtra / breakCount */ INT breakRem; /* breakTotalExtra % breakCount */ diff --git a/include/ntgdi.h b/include/ntgdi.h index dce35a8b0b8..33c5b53f50f 100644 --- a/include/ntgdi.h +++ b/include/ntgdi.h @@ -100,6 +100,7 @@ typedef struct DC_ATTR { POINT cur_pos; INT graphics_mode; + WORD text_align; void *emf; } DC_ATTR;

1 0

Jacek Caban : gdi32: Use NtGdiPolyPolyDraw for CreatePolyPolygonRgn implementation.
by Alexandre Julliard 23 Jul '21

23 Jul '21

Module: wine Branch: master Commit: 607733af0e02312e17a72d9bda64ed881207f38b URL: https://source.winehq.org/git/wine.git/?a=commit;h=607733af0e02312e17a72d9b… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Jul 23 10:49:00 2021 +0200 gdi32: Use NtGdiPolyPolyDraw for CreatePolyPolygonRgn implementation. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdi32/objects.c | 10 ++++++++++ dlls/gdi32/painting.c | 4 ++++ dlls/gdi32/region.c | 9 --------- 3 files changed, 14 insertions(+), 9 deletions(-) diff --git a/dlls/gdi32/objects.c b/dlls/gdi32/objects.c index e614a9d6a52..84ed2377954 100644 --- a/dlls/gdi32/objects.c +++ b/dlls/gdi32/objects.c @@ -281,6 +281,16 @@ HRGN WINAPI ExtCreateRegion( const XFORM *xform, DWORD count, const RGNDATA *dat return NtGdiExtCreateRegion( xform, count, data ); } +/*********************************************************************** + * CreatePolyPolygonRgn (GDI32.@) + */ +HRGN WINAPI CreatePolyPolygonRgn( const POINT *points, const INT *counts, INT count, INT mode ) +{ + ULONG ret = NtGdiPolyPolyDraw( ULongToHandle(mode), points, (const UINT *)counts, + count, NtGdiPolyPolygonRgn ); + return ULongToHandle( ret ); +} + /*********************************************************************** * CreateRectRgnIndirect (GDI32.@) * diff --git a/dlls/gdi32/painting.c b/dlls/gdi32/painting.c index f9fa18c4de0..803b9797736 100644 --- a/dlls/gdi32/painting.c +++ b/dlls/gdi32/painting.c @@ -585,6 +585,10 @@ ULONG WINAPI NtGdiPolyPolyDraw( HDC hdc, const POINT *points, const UINT *counts ULONG ret; DC *dc; + if (function == NtGdiPolyPolygonRgn) + return HandleToULong( create_polypolygon_region( points, (const INT *)counts, count, + HandleToULong(hdc), NULL )); + if (!(dc = get_dc_ptr( hdc ))) return FALSE; update_dc( dc ); diff --git a/dlls/gdi32/region.c b/dlls/gdi32/region.c index 502ce108a8f..4df48209de5 100644 --- a/dlls/gdi32/region.c +++ b/dlls/gdi32/region.c @@ -2692,12 +2692,3 @@ HRGN create_polypolygon_region( const POINT *Pts, const INT *Count, INT nbpolygo HeapFree( GetProcessHeap(), 0, pETEs ); return hrgn; } - - -/*********************************************************************** - * CreatePolyPolygonRgn (GDI32.@) - */ -HRGN WINAPI CreatePolyPolygonRgn( const POINT *pts, const INT *count, INT nbpolygons, INT mode ) -{ - return create_polypolygon_region( pts, count, nbpolygons, mode, NULL ); -}

1 0

Jacek Caban : gdi32: Use NtGdiPolyDraw for PolyDraw implementation.
by Alexandre Julliard 23 Jul '21

23 Jul '21

Module: wine Branch: master Commit: 11f09c2d74d0eaeeaba5f93544166f87881b7f40 URL: https://source.winehq.org/git/wine.git/?a=commit;h=11f09c2d74d0eaeeaba5f935… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Jul 23 10:48:48 2021 +0200 gdi32: Use NtGdiPolyDraw for PolyDraw implementation. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdi32/enhmfdrv/dc.c | 14 +------------- dlls/gdi32/enhmfdrv/graphics.c | 22 ++++++++++++++++------ dlls/gdi32/gdi_private.h | 2 ++ dlls/gdi32/gdidc.c | 14 ++++++++++++++ dlls/gdi32/painting.c | 13 +++++-------- dlls/gdi32/tests/metafile.c | 9 +++++++++ 6 files changed, 47 insertions(+), 27 deletions(-) diff --git a/dlls/gdi32/enhmfdrv/dc.c b/dlls/gdi32/enhmfdrv/dc.c index b2b6bb4866e..7af63eed23b 100644 --- a/dlls/gdi32/enhmfdrv/dc.c +++ b/dlls/gdi32/enhmfdrv/dc.c @@ -671,18 +671,6 @@ static BOOL CDECL emfpathdrv_ExtTextOut( PHYSDEV dev, INT x, INT y, UINT flags, next->funcs->pExtTextOut( next, x, y, flags, rect, str, count, dx )); } -/*********************************************************************** - * emfpathdrv_PolyDraw - */ -static BOOL CDECL emfpathdrv_PolyDraw( PHYSDEV dev, const POINT *pts, const BYTE *types, DWORD count ) -{ - PHYSDEV emfdev = get_emfdev( dev ); - PHYSDEV next = GET_NEXT_PHYSDEV( dev, pPolyDraw ); - - return (emfdev->funcs->pPolyDraw( emfdev, pts, types, count ) && - next->funcs->pPolyDraw( next, pts, types, count )); -} - static const struct gdi_dc_funcs emfpath_driver = { @@ -757,7 +745,7 @@ static const struct gdi_dc_funcs emfpath_driver = NULL, /* pPie */ NULL, /* pPolyBezier */ NULL, /* pPolyBezierTo */ - emfpathdrv_PolyDraw, /* pPolyDraw */ + NULL, /* pPolyDraw */ NULL, /* pPolyPolygon */ NULL, /* pPolyPolyline */ NULL, /* pPolylineTo */ diff --git a/dlls/gdi32/enhmfdrv/graphics.c b/dlls/gdi32/enhmfdrv/graphics.c index 80cffdbdebf..7c800148cf8 100644 --- a/dlls/gdi32/enhmfdrv/graphics.c +++ b/dlls/gdi32/enhmfdrv/graphics.c @@ -741,11 +741,11 @@ BOOL CDECL EMFDRV_PolyPolygon( PHYSDEV dev, const POINT* pt, const INT* counts, } /********************************************************************** - * EMFDRV_PolyDraw + * EMFDC_PolyDraw */ -BOOL CDECL EMFDRV_PolyDraw( PHYSDEV dev, const POINT *pts, const BYTE *types, DWORD count ) +BOOL EMFDC_PolyDraw( DC_ATTR *dc_attr, const POINT *pts, const BYTE *types, DWORD count ) { - EMFDRV_PDEVICE *physDev = get_emf_physdev( dev ); + EMFDRV_PDEVICE *emf = dc_attr->emf; EMRPOLYDRAW *emr; BOOL ret; BYTE *types_dest; @@ -765,18 +765,28 @@ BOOL CDECL EMFDRV_PolyDraw( PHYSDEV dev, const POINT *pts, const BYTE *types, DW memcpy( types_dest, types, count ); if (count & 3) memset( types_dest + count, 0, 4 - (count & 3) ); - if (!physDev->path) + if (!emf->path) get_points_bounds( &emr->rclBounds, pts, count, 0 ); else emr->rclBounds = empty_bounds; - ret = EMFDRV_WriteRecord( dev, &emr->emr ); - if (ret && !physDev->path) EMFDRV_UpdateBBox( dev, &emr->rclBounds ); + ret = EMFDRV_WriteRecord( &emf->dev, &emr->emr ); + if (ret && !emf->path) EMFDRV_UpdateBBox( &emf->dev, &emr->rclBounds ); HeapFree( GetProcessHeap(), 0, emr ); return ret; } +/********************************************************************** + * EMFDRV_PolyDraw + */ +BOOL CDECL EMFDRV_PolyDraw( PHYSDEV dev, const POINT *pts, const BYTE *types, DWORD count ) +{ + /* FIXME: update bounding rect */ + return TRUE; +} + + /********************************************************************** * EMFDRV_ExtFloodFill */ diff --git a/dlls/gdi32/gdi_private.h b/dlls/gdi32/gdi_private.h index fd36712dfbc..f7b04be18dc 100644 --- a/dlls/gdi32/gdi_private.h +++ b/dlls/gdi32/gdi_private.h @@ -71,6 +71,8 @@ extern BOOL EMFDC_LineTo( DC_ATTR *dc_attr, INT x, INT y ) DECLSPEC_HIDDEN; extern BOOL EMFDC_MoveTo( DC_ATTR *dc_attr, INT x, INT y ) DECLSPEC_HIDDEN; extern BOOL EMFDC_PolyBezier( DC_ATTR *dc_attr, const POINT *points, DWORD count ) DECLSPEC_HIDDEN; extern BOOL EMFDC_PolyBezierTo( DC_ATTR *dc_attr, const POINT *points, DWORD count ) DECLSPEC_HIDDEN; +extern BOOL EMFDC_PolyDraw( DC_ATTR *dc_attr, const POINT *points, const BYTE *types, + DWORD count ) DECLSPEC_HIDDEN; extern BOOL EMFDC_PolyPolyline( DC_ATTR *dc_attr, const POINT *points, const DWORD *counts, DWORD polys ) DECLSPEC_HIDDEN; extern BOOL EMFDC_PolyPolygon( DC_ATTR *dc_attr, const POINT *points, const INT *counts, diff --git a/dlls/gdi32/gdidc.c b/dlls/gdi32/gdidc.c index c51892d3a9e..c6a8cbd567f 100644 --- a/dlls/gdi32/gdidc.c +++ b/dlls/gdi32/gdidc.c @@ -337,3 +337,17 @@ BOOL WINAPI PolylineTo( HDC hdc, const POINT *points, DWORD count ) if (dc_attr->emf && !EMFDC_PolylineTo( dc_attr, points, count )) return FALSE; return NtGdiPolyPolyDraw( hdc, points, &count, 1, NtGdiPolylineTo ); } + +/*********************************************************************** + * PolyDraw (GDI32.@) + */ +BOOL WINAPI PolyDraw( HDC hdc, const POINT *points, const BYTE *types, DWORD count ) +{ + DC_ATTR *dc_attr; + + TRACE( "%p, %p, %p, %u\n", hdc, points, types, count ); + + if (!(dc_attr = get_dc_attr( hdc ))) return FALSE; + if (dc_attr->emf && !EMFDC_PolyDraw( dc_attr, points, types, count )) return FALSE; + return NtGdiPolyDraw( hdc, points, types, count ); +} diff --git a/dlls/gdi32/painting.c b/dlls/gdi32/painting.c index 9c7081296df..f9fa18c4de0 100644 --- a/dlls/gdi32/painting.c +++ b/dlls/gdi32/painting.c @@ -699,24 +699,21 @@ BOOL WINAPI NtGdiAngleArc( HDC hdc, INT x, INT y, DWORD dwRadius, FLOAT eStartAn } /*********************************************************************** - * PolyDraw (GDI32.@) + * NtGdiPolyDraw (win32u.@) */ -BOOL WINAPI PolyDraw(HDC hdc, const POINT *lppt, const BYTE *lpbTypes, - DWORD cCount) +BOOL WINAPI NtGdiPolyDraw( HDC hdc, const POINT *points, const BYTE *types, DWORD count ) { DC *dc = get_dc_ptr( hdc ); PHYSDEV physdev; BOOL result; - TRACE( "%p, %p, %p, %u\n", hdc, lppt, lpbTypes, cCount ); - if(!dc) return FALSE; update_dc( dc ); physdev = GET_DC_PHYSDEV( dc, pPolyDraw ); - result = physdev->funcs->pPolyDraw( physdev, lppt, lpbTypes, cCount ); - if (result && cCount) - dc->attr->cur_pos = lppt[cCount - 1]; + result = physdev->funcs->pPolyDraw( physdev, points, types, count ); + if (result && count) + dc->attr->cur_pos = points[count - 1]; release_dc_ptr( dc ); return result; diff --git a/dlls/gdi32/tests/metafile.c b/dlls/gdi32/tests/metafile.c index 4f72079a615..d9d43b80fc4 100644 --- a/dlls/gdi32/tests/metafile.c +++ b/dlls/gdi32/tests/metafile.c @@ -3324,6 +3324,9 @@ static void test_mf_Graphics(void) INT type; BOOL ret; + static const POINT points[] = { {1, 1}, {2, 2} }; + static const BYTE types[] = { PT_MOVETO, PT_LINETO }; + hdcMetafile = CreateMetaFileA(NULL); ok(hdcMetafile != 0, "CreateMetaFileA(NULL) error %d\n", GetLastError()); @@ -3344,6 +3347,12 @@ static void test_mf_Graphics(void) ret = ArcTo(hdcMetafile, 1, 2, 30, 40, 11, 12, 23, 24 ); ok( !ret, "ArcTo succeeded\n" ); + SetLastError(0xdeadbeef); + ret = PolyDraw(hdcMetafile, points, types, ARRAY_SIZE(points)); + ok(!ret, "PolyDraw succeeded\n"); + todo_wine + ok(GetLastError() == 0xdeadbeef, "GetLastError() = %u\n", GetLastError()); + hMetafile = CloseMetaFile(hdcMetafile); ok(hMetafile != 0, "CloseMetaFile error %d\n", GetLastError()); type = GetObjectType(hdcMetafile);

1 0

← Newer
1
...
19
20
21
22
23
24
25
...
73
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits July 2021