wine-commits July 2021

wine-commits@winehq.org

1 participants
728 discussions

Huw Davies : nsiproxy: Introduce IOCTL_NSIPROXY_WINE_GET_ALL_PARAMETERS.
by Alexandre Julliard 01 Jul '21

01 Jul '21

Module: wine Branch: master Commit: 25a582cf320a036a32f65cccd8dd95ddc62544d0 URL: https://source.winehq.org/git/wine.git/?a=commit;h=25a582cf320a036a32f65ccc… Author: Huw Davies <huw(a)codeweavers.com> Date: Thu Jul 1 09:27:03 2021 +0100 nsiproxy: Introduce IOCTL_NSIPROXY_WINE_GET_ALL_PARAMETERS. Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/nsiproxy.sys/device.c | 45 ++++++++++++++++++++++++++++++++++++ dlls/nsiproxy.sys/nsi.c | 25 ++++++++++++++++++++ dlls/nsiproxy.sys/nsiproxy_private.h | 4 ++++ include/wine/nsi.h | 14 +++++++++++ 4 files changed, 88 insertions(+) diff --git a/dlls/nsiproxy.sys/device.c b/dlls/nsiproxy.sys/device.c index 4ce5ddd6d83..88c65ff4602 100644 --- a/dlls/nsiproxy.sys/device.c +++ b/dlls/nsiproxy.sys/device.c @@ -82,6 +82,47 @@ static void nsiproxy_enumerate_all( IRP *irp ) else irp->IoStatus.Information = 0; } +static void nsiproxy_get_all_parameters( IRP *irp ) +{ + IO_STACK_LOCATION *irpsp = IoGetCurrentIrpStackLocation( irp ); + struct nsiproxy_get_all_parameters *in = (struct nsiproxy_get_all_parameters *)irp->AssociatedIrp.SystemBuffer; + DWORD in_len = irpsp->Parameters.DeviceIoControl.InputBufferLength; + BYTE *out = irp->AssociatedIrp.SystemBuffer; + DWORD out_len = irpsp->Parameters.DeviceIoControl.OutputBufferLength; + struct nsi_get_all_parameters_ex get_all; + + if (in_len < FIELD_OFFSET(struct nsiproxy_get_all_parameters, key[0]) || + in_len < FIELD_OFFSET(struct nsiproxy_get_all_parameters, key[in->key_size])) + { + irp->IoStatus.u.Status = STATUS_INVALID_PARAMETER; + return; + } + + if (out_len < in->rw_size + in->dynamic_size + in->static_size) + { + irp->IoStatus.u.Status = STATUS_INVALID_PARAMETER; + return; + } + + get_all.unknown[0] = 0; + get_all.unknown[1] = 0; + get_all.first_arg = in->first_arg; + get_all.unknown2 = 0; + get_all.module = &in->module; + get_all.table = in->table; + get_all.key = in->key; + get_all.key_size = in->key_size; + get_all.rw_data = out; + get_all.rw_size = in->rw_size; + get_all.dynamic_data = out + in->rw_size; + get_all.dynamic_size = in->dynamic_size; + get_all.static_data = out + in->rw_size + in->dynamic_size; + get_all.static_size = in->static_size; + + irp->IoStatus.u.Status = nsi_get_all_parameters_ex( &get_all ); + irp->IoStatus.Information = (irp->IoStatus.u.Status == STATUS_SUCCESS) ? out_len : 0; +} + static NTSTATUS WINAPI nsi_ioctl( DEVICE_OBJECT *device, IRP *irp ) { IO_STACK_LOCATION *irpsp = IoGetCurrentIrpStackLocation( irp ); @@ -97,6 +138,10 @@ static NTSTATUS WINAPI nsi_ioctl( DEVICE_OBJECT *device, IRP *irp ) nsiproxy_enumerate_all( irp ); break; + case IOCTL_NSIPROXY_WINE_GET_ALL_PARAMETERS: + nsiproxy_get_all_parameters( irp ); + break; + default: FIXME( "ioctl %x not supported\n", irpsp->Parameters.DeviceIoControl.IoControlCode ); irp->IoStatus.u.Status = STATUS_NOT_SUPPORTED; diff --git a/dlls/nsiproxy.sys/nsi.c b/dlls/nsiproxy.sys/nsi.c index 85b9be1e587..2bd8f32fdd7 100644 --- a/dlls/nsiproxy.sys/nsi.c +++ b/dlls/nsiproxy.sys/nsi.c @@ -74,3 +74,28 @@ NTSTATUS nsi_enumerate_all_ex( struct nsi_enumerate_all_ex *params ) return entry->enumerate_all( data[0], sizes[0], data[1], sizes[1], data[2], sizes[2], data[3], sizes[3], &params->count ); } + +NTSTATUS nsi_get_all_parameters_ex( struct nsi_get_all_parameters_ex *params ) +{ + const struct module_table *entry = get_module_table( params->module, params->table ); + void *rw = params->rw_data; + void *dyn = params->dynamic_data; + void *stat = params->static_data; + + if (!entry || !entry->get_all_parameters) + { + WARN( "table not found\n" ); + return STATUS_INVALID_PARAMETER; + } + + if (params->key_size != entry->sizes[0]) return STATUS_INVALID_PARAMETER; + if (!params->rw_size) rw = NULL; + else if (params->rw_size != entry->sizes[1]) return STATUS_INVALID_PARAMETER; + if (!params->dynamic_size) dyn = NULL; + else if (params->dynamic_size != entry->sizes[2]) return STATUS_INVALID_PARAMETER; + if (!params->static_size) stat = NULL; + else if (params->static_size != entry->sizes[3]) return STATUS_INVALID_PARAMETER; + + return entry->get_all_parameters( params->key, params->key_size, rw, params->rw_size, + dyn, params->dynamic_size, stat, params->static_size ); +} diff --git a/dlls/nsiproxy.sys/nsiproxy_private.h b/dlls/nsiproxy.sys/nsiproxy_private.h index 6745dbc6b56..37cbbd118c0 100644 --- a/dlls/nsiproxy.sys/nsiproxy_private.h +++ b/dlls/nsiproxy.sys/nsiproxy_private.h @@ -19,6 +19,7 @@ */ NTSTATUS nsi_enumerate_all_ex( struct nsi_enumerate_all_ex *params ) DECLSPEC_HIDDEN; +NTSTATUS nsi_get_all_parameters_ex( struct nsi_get_all_parameters_ex *params ) DECLSPEC_HIDDEN; struct module_table { @@ -27,6 +28,9 @@ struct module_table NTSTATUS (*enumerate_all)( void *key_data, DWORD key_size, void *rw_data, DWORD rw_size, void *dynamic_data, DWORD dynamic_size, void *static_data, DWORD static_size, DWORD_PTR *count ); + NTSTATUS (*get_all_parameters)( const void *key, DWORD key_size, void *rw_data, DWORD rw_size, + void *dynamic_data, DWORD dynamic_size, + void *static_data, DWORD static_size ); }; struct module diff --git a/include/wine/nsi.h b/include/wine/nsi.h index 799485fc284..82183d78190 100644 --- a/include/wine/nsi.h +++ b/include/wine/nsi.h @@ -97,6 +97,7 @@ struct nsi_ndis_ifinfo_static /* Wine specific ioctl interface */ #define IOCTL_NSIPROXY_WINE_ENUMERATE_ALL CTL_CODE(FILE_DEVICE_NETWORK, 0x400, METHOD_BUFFERED, 0) +#define IOCTL_NSIPROXY_WINE_GET_ALL_PARAMETERS CTL_CODE(FILE_DEVICE_NETWORK, 0x401, METHOD_BUFFERED, 0) /* input for IOCTL_NSIPROXY_WINE_ENUMERATE_ALL */ struct nsiproxy_enumerate_all @@ -112,6 +113,19 @@ struct nsiproxy_enumerate_all DWORD count; }; +/* input for IOCTL_NSIPROXY_WINE_GET_ALL_PARAMETERS */ +struct nsiproxy_get_all_parameters +{ + NPI_MODULEID module; + DWORD first_arg; + DWORD table; + DWORD key_size; + DWORD rw_size; + DWORD dynamic_size; + DWORD static_size; + BYTE key[1]; /* key_size */ +}; + /* Undocumented Nsi api */ #define NSI_PARAM_TYPE_RW 0

1 0

Zebediah Figura : ntdll/tests: Add more tests for deleted keys.
by Alexandre Julliard 01 Jul '21

01 Jul '21

Module: wine Branch: master Commit: 151370c4789ae956ec62637340b640af596d0ba6 URL: https://source.winehq.org/git/wine.git/?a=commit;h=151370c4789ae956ec626373… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Wed Jun 30 22:08:10 2021 -0500 ntdll/tests: Add more tests for deleted keys. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/tests/reg.c | 53 +++++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 50 insertions(+), 3 deletions(-) diff --git a/dlls/ntdll/tests/reg.c b/dlls/ntdll/tests/reg.c index 7463f98aa29..91b752ac069 100644 --- a/dlls/ntdll/tests/reg.c +++ b/dlls/ntdll/tests/reg.c @@ -125,6 +125,8 @@ static NTSTATUS (WINAPI * pRtlOpenCurrentUser)(IN ACCESS_MASK, PHANDLE); static NTSTATUS (WINAPI * pNtOpenKey)(PHANDLE, IN ACCESS_MASK, IN POBJECT_ATTRIBUTES); static NTSTATUS (WINAPI * pNtOpenKeyEx)(PHANDLE, ACCESS_MASK, POBJECT_ATTRIBUTES, ULONG); static NTSTATUS (WINAPI * pNtClose)(IN HANDLE); +static NTSTATUS (WINAPI * pNtEnumerateKey)(HANDLE, ULONG, KEY_INFORMATION_CLASS, void *, DWORD, DWORD *); +static NTSTATUS (WINAPI * pNtEnumerateValueKey)(HANDLE, ULONG, KEY_VALUE_INFORMATION_CLASS, void *, DWORD, DWORD *); static NTSTATUS (WINAPI * pNtFlushKey)(HANDLE); static NTSTATUS (WINAPI * pNtDeleteKey)(HANDLE); static NTSTATUS (WINAPI * pNtCreateKey)( PHANDLE retkey, ACCESS_MASK access, const OBJECT_ATTRIBUTES *attr, @@ -132,6 +134,7 @@ static NTSTATUS (WINAPI * pNtCreateKey)( PHANDLE retkey, ACCESS_MASK access, con PULONG dispos ); static NTSTATUS (WINAPI * pNtQueryKey)(HANDLE,KEY_INFORMATION_CLASS,PVOID,ULONG,PULONG); static NTSTATUS (WINAPI * pNtQueryLicenseValue)(const UNICODE_STRING *,ULONG *,PVOID,ULONG,ULONG *); +static NTSTATUS (WINAPI * pNtQueryObject)(HANDLE, OBJECT_INFORMATION_CLASS, void *, ULONG, ULONG *); static NTSTATUS (WINAPI * pNtQueryValueKey)(HANDLE,const UNICODE_STRING *,KEY_VALUE_INFORMATION_CLASS,void *,DWORD,DWORD *); static NTSTATUS (WINAPI * pNtSetValueKey)(HANDLE, const PUNICODE_STRING, ULONG, ULONG, const void*, ULONG ); @@ -181,9 +184,12 @@ static BOOL InitFunctionPtrs(void) NTDLL_GET_PROC(NtClose) NTDLL_GET_PROC(NtDeleteValueKey) NTDLL_GET_PROC(NtCreateKey) + NTDLL_GET_PROC(NtEnumerateKey) + NTDLL_GET_PROC(NtEnumerateValueKey) NTDLL_GET_PROC(NtFlushKey) NTDLL_GET_PROC(NtDeleteKey) NTDLL_GET_PROC(NtQueryKey) + NTDLL_GET_PROC(NtQueryObject) NTDLL_GET_PROC(NtQueryValueKey) NTDLL_GET_PROC(NtQueryInformationProcess) NTDLL_GET_PROC(NtSetValueKey) @@ -844,20 +850,61 @@ static void test_NtQueryValueKey(void) static void test_NtDeleteKey(void) { + UNICODE_STRING string; + char buffer[200]; NTSTATUS status; - HANDLE hkey; + HANDLE hkey, hkey2; OBJECT_ATTRIBUTES attr; - ACCESS_MASK am = KEY_ALL_ACCESS; + DWORD size; status = pNtDeleteKey(NULL); ok(status == STATUS_INVALID_HANDLE, "Expected STATUS_INVALID_HANDLE, got: 0x%08x\n", status); InitializeObjectAttributes(&attr, &winetestpath, 0, 0, 0); - status = pNtOpenKey(&hkey, am, &attr); + status = pNtOpenKey(&hkey, KEY_ALL_ACCESS, &attr); ok(status == STATUS_SUCCESS, "NtOpenKey Failed: 0x%08x\n", status); status = pNtDeleteKey(hkey); ok(status == STATUS_SUCCESS, "NtDeleteKey Failed: 0x%08x\n", status); + + status = pNtQueryKey(hkey, KeyNameInformation, buffer, sizeof(buffer), &size); + ok(status == STATUS_KEY_DELETED, "got %#x\n", status); + + status = pNtEnumerateKey(hkey, 0, KeyFullInformation, buffer, sizeof(buffer), &size); + ok(status == STATUS_KEY_DELETED, "got %#x\n", status); + + pRtlInitUnicodeString(&string, L"value"); + status = pNtQueryValueKey(hkey, &string, KeyValueBasicInformation, buffer, sizeof(buffer), &size); + ok(status == STATUS_KEY_DELETED, "got %#x\n", status); + + status = pNtEnumerateValueKey(hkey, 0, KeyValuePartialInformation, buffer, sizeof(buffer), &size); + ok(status == STATUS_KEY_DELETED, "got %#x\n", status); + + status = pNtSetValueKey(hkey, &string, 0, REG_SZ, "test", 5); + ok(status == STATUS_KEY_DELETED, "got %#x\n", status); + + status = pNtDeleteValueKey(hkey, &string); + ok(status == STATUS_KEY_DELETED, "got %#x\n", status); + + status = pNtDeleteKey(hkey); + todo_wine ok(!status, "got %#x\n", status); + + RtlInitUnicodeString(&string, L"subkey"); + InitializeObjectAttributes(&attr, &string, OBJ_CASE_INSENSITIVE, hkey, NULL); + status = pNtOpenKey(&hkey2, KEY_READ, &attr); + ok(status == STATUS_KEY_DELETED, "got %#x\n", status); + + status = pNtCreateKey(&hkey2, KEY_ALL_ACCESS, &attr, 0, NULL, 0, NULL); + ok(status == STATUS_KEY_DELETED, "got %#x\n", status); + + status = pNtQueryObject(hkey, ObjectNameInformation, buffer, sizeof(buffer), &size); + ok(status == STATUS_KEY_DELETED, "got %#x\n", status); + + status = pNtQueryObject(hkey, ObjectBasicInformation, buffer, sizeof(OBJECT_BASIC_INFORMATION), &size); + ok(!status, "got %#x\n", status); + + status = pNtClose(hkey); + ok(status == STATUS_SUCCESS, "got %#x\n", status); } static void test_NtQueryLicenseKey(void)

1 0

Zebediah Figura : server: Return STATUS_KEY_DELETED when trying to retrieve the full name of a deleted key.
by Alexandre Julliard 01 Jul '21

01 Jul '21

Module: wine Branch: master Commit: 089b2528c2c933e3c9b45a5f559fa4b5f830872a URL: https://source.winehq.org/git/wine.git/?a=commit;h=089b2528c2c933e3c9b45a5f… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Wed Jun 30 22:08:09 2021 -0500 server: Return STATUS_KEY_DELETED when trying to retrieve the full name of a deleted key. This fixes a server crash that can be triggered by deleting a key and then trying to retrieve its name. In that case key->parent is NULL. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- server/registry.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/server/registry.c b/server/registry.c index f36760e6cc1..b7971770728 100644 --- a/server/registry.c +++ b/server/registry.c @@ -413,6 +413,12 @@ static WCHAR *key_get_full_name( struct object *obj, data_size_t *ret_len ) data_size_t len = sizeof(root_name) - sizeof(WCHAR); char *ret; + if (key->flags & KEY_DELETED) + { + set_error( STATUS_KEY_DELETED ); + return NULL; + } + for (key = (struct key *)obj; key != root_key; key = key->parent) len += key->namelen + sizeof(WCHAR); if (!(ret = malloc( len ))) return NULL;

1 0

Zebediah Figura : server: Use a separate request to retrieve the object name.
by Alexandre Julliard 01 Jul '21

01 Jul '21

Module: wine Branch: master Commit: e759da260eb87f464b4964c6f4a00b16226e834f URL: https://source.winehq.org/git/wine.git/?a=commit;h=e759da260eb87f464b4964c6… Author: Zebediah Figura <z.figura12(a)gmail.com> Date: Wed Jun 30 22:08:08 2021 -0500 server: Use a separate request to retrieve the object name. A deleted key returns STATUS_KEY_DELETED when ObjectNameInformation is requested, but succeeds when ObjectBasicInformation is requested. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/unix/file.c | 2 +- include/wine/server_protocol.h | 19 ++++++++++++++++++- server/handle.c | 11 ++++++++++- server/protocol.def | 7 +++++++ server/request.h | 7 ++++++- server/trace.c | 14 +++++++++++++- 6 files changed, 55 insertions(+), 5 deletions(-) diff --git a/dlls/ntdll/unix/file.c b/dlls/ntdll/unix/file.c index 1a57a112a59..21bcb215385 100644 --- a/dlls/ntdll/unix/file.c +++ b/dlls/ntdll/unix/file.c @@ -6772,7 +6772,7 @@ NTSTATUS WINAPI NtQueryObject( HANDLE handle, OBJECT_INFORMATION_CLASS info_clas /* not a file, treat as a generic object */ - SERVER_START_REQ( get_object_info ) + SERVER_START_REQ( get_object_name ) { req->handle = wine_server_obj_handle( handle ); if (len > sizeof(*p)) wine_server_set_reply( req, p + 1, len - sizeof(*p) ); diff --git a/include/wine/server_protocol.h b/include/wine/server_protocol.h index 1720eef506e..d73f493edd3 100644 --- a/include/wine/server_protocol.h +++ b/include/wine/server_protocol.h @@ -4687,8 +4687,22 @@ struct get_object_info_reply unsigned int access; unsigned int ref_count; unsigned int handle_count; + char __pad_20[4]; +}; + + + +struct get_object_name_request +{ + struct request_header __header; + obj_handle_t handle; +}; +struct get_object_name_reply +{ + struct reply_header __header; data_size_t total; /* VARARG(name,unicode_str); */ + char __pad_12[4]; }; @@ -5626,6 +5640,7 @@ enum request REQ_open_symlink, REQ_query_symlink, REQ_get_object_info, + REQ_get_object_name, REQ_get_object_type, REQ_get_object_types, REQ_allocate_locally_unique_id, @@ -5906,6 +5921,7 @@ union generic_request struct open_symlink_request open_symlink_request; struct query_symlink_request query_symlink_request; struct get_object_info_request get_object_info_request; + struct get_object_name_request get_object_name_request; struct get_object_type_request get_object_type_request; struct get_object_types_request get_object_types_request; struct allocate_locally_unique_id_request allocate_locally_unique_id_request; @@ -6184,6 +6200,7 @@ union generic_reply struct open_symlink_reply open_symlink_reply; struct query_symlink_reply query_symlink_reply; struct get_object_info_reply get_object_info_reply; + struct get_object_name_reply get_object_name_reply; struct get_object_type_reply get_object_type_reply; struct get_object_types_reply get_object_types_reply; struct allocate_locally_unique_id_reply allocate_locally_unique_id_reply; @@ -6234,7 +6251,7 @@ union generic_reply /* ### protocol_version begin ### */ -#define SERVER_PROTOCOL_VERSION 719 +#define SERVER_PROTOCOL_VERSION 720 /* ### protocol_version end ### */ diff --git a/server/handle.c b/server/handle.c index d86f0960ccf..6efd82f2ff9 100644 --- a/server/handle.c +++ b/server/handle.c @@ -686,13 +686,22 @@ DECL_HANDLER(dup_handle) DECL_HANDLER(get_object_info) { struct object *obj; - WCHAR *name; if (!(obj = get_handle_obj( current->process, req->handle, 0, NULL ))) return; reply->access = get_handle_access( current->process, req->handle ); reply->ref_count = obj->refcount; reply->handle_count = obj->handle_count; + release_object( obj ); +} + +DECL_HANDLER(get_object_name) +{ + struct object *obj; + WCHAR *name; + + if (!(obj = get_handle_obj( current->process, req->handle, 0, NULL ))) return; + if ((name = obj->ops->get_full_name( obj, &reply->total ))) set_reply_data_ptr( name, min( reply->total, get_reply_max_size() )); release_object( obj ); diff --git a/server/protocol.def b/server/protocol.def index 762be1fa7c0..59ed5632503 100644 --- a/server/protocol.def +++ b/server/protocol.def @@ -3299,6 +3299,13 @@ struct handle_info unsigned int access; /* granted access mask */ unsigned int ref_count; /* object ref count */ unsigned int handle_count; /* object handle count */ +@END + + +/* Query the full name of an object */ +@REQ(get_object_name) + obj_handle_t handle; /* handle to the object */ +@REPLY data_size_t total; /* total needed size for name */ VARARG(name,unicode_str); /* object name */ @END diff --git a/server/request.h b/server/request.h index 1c45ac34cc7..63b09358612 100644 --- a/server/request.h +++ b/server/request.h @@ -346,6 +346,7 @@ DECL_HANDLER(create_symlink); DECL_HANDLER(open_symlink); DECL_HANDLER(query_symlink); DECL_HANDLER(get_object_info); +DECL_HANDLER(get_object_name); DECL_HANDLER(get_object_type); DECL_HANDLER(get_object_types); DECL_HANDLER(allocate_locally_unique_id); @@ -625,6 +626,7 @@ static const req_handler req_handlers[REQ_NB_REQUESTS] = (req_handler)req_open_symlink, (req_handler)req_query_symlink, (req_handler)req_get_object_info, + (req_handler)req_get_object_name, (req_handler)req_get_object_type, (req_handler)req_get_object_types, (req_handler)req_allocate_locally_unique_id, @@ -2018,8 +2020,11 @@ C_ASSERT( sizeof(struct get_object_info_request) == 16 ); C_ASSERT( FIELD_OFFSET(struct get_object_info_reply, access) == 8 ); C_ASSERT( FIELD_OFFSET(struct get_object_info_reply, ref_count) == 12 ); C_ASSERT( FIELD_OFFSET(struct get_object_info_reply, handle_count) == 16 ); -C_ASSERT( FIELD_OFFSET(struct get_object_info_reply, total) == 20 ); C_ASSERT( sizeof(struct get_object_info_reply) == 24 ); +C_ASSERT( FIELD_OFFSET(struct get_object_name_request, handle) == 12 ); +C_ASSERT( sizeof(struct get_object_name_request) == 16 ); +C_ASSERT( FIELD_OFFSET(struct get_object_name_reply, total) == 8 ); +C_ASSERT( sizeof(struct get_object_name_reply) == 16 ); C_ASSERT( FIELD_OFFSET(struct get_object_type_request, handle) == 12 ); C_ASSERT( sizeof(struct get_object_type_request) == 16 ); C_ASSERT( sizeof(struct get_object_type_reply) == 8 ); diff --git a/server/trace.c b/server/trace.c index 55068d1179b..b3eea846453 100644 --- a/server/trace.c +++ b/server/trace.c @@ -4103,7 +4103,16 @@ static void dump_get_object_info_reply( const struct get_object_info_reply *req fprintf( stderr, " access=%08x", req->access ); fprintf( stderr, ", ref_count=%08x", req->ref_count ); fprintf( stderr, ", handle_count=%08x", req->handle_count ); - fprintf( stderr, ", total=%u", req->total ); +} + +static void dump_get_object_name_request( const struct get_object_name_request *req ) +{ + fprintf( stderr, " handle=%04x", req->handle ); +} + +static void dump_get_object_name_reply( const struct get_object_name_reply *req ) +{ + fprintf( stderr, " total=%u", req->total ); dump_varargs_unicode_str( ", name=", cur_size ); } @@ -4771,6 +4780,7 @@ static const dump_func req_dumpers[REQ_NB_REQUESTS] = { (dump_func)dump_open_symlink_request, (dump_func)dump_query_symlink_request, (dump_func)dump_get_object_info_request, + (dump_func)dump_get_object_name_request, (dump_func)dump_get_object_type_request, (dump_func)dump_get_object_types_request, (dump_func)dump_allocate_locally_unique_id_request, @@ -5047,6 +5057,7 @@ static const dump_func reply_dumpers[REQ_NB_REQUESTS] = { (dump_func)dump_open_symlink_reply, (dump_func)dump_query_symlink_reply, (dump_func)dump_get_object_info_reply, + (dump_func)dump_get_object_name_reply, (dump_func)dump_get_object_type_reply, (dump_func)dump_get_object_types_reply, (dump_func)dump_allocate_locally_unique_id_reply, @@ -5323,6 +5334,7 @@ static const char * const req_names[REQ_NB_REQUESTS] = { "open_symlink", "query_symlink", "get_object_info", + "get_object_name", "get_object_type", "get_object_types", "allocate_locally_unique_id",

1 0

Jacek Caban : gdi32: Initialize GdiSharedHandleTable in PEB.
by Alexandre Julliard 01 Jul '21

01 Jul '21

Module: wine Branch: master Commit: e82332f2b24b16d4c320a8bd924ed90bab5ded3a URL: https://source.winehq.org/git/wine.git/?a=commit;h=e82332f2b24b16d4c320a8bd… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Jun 30 17:38:00 2021 +0200 gdi32: Initialize GdiSharedHandleTable in PEB. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdi32/gdiobj.c | 16 ++++++++++++ dlls/gdi32/tests/gdiobj.c | 62 ++++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 77 insertions(+), 1 deletion(-) diff --git a/dlls/gdi32/gdiobj.c b/dlls/gdi32/gdiobj.c index d0c1f0c8230..b0fad2660ee 100644 --- a/dlls/gdi32/gdiobj.c +++ b/dlls/gdi32/gdiobj.c @@ -598,6 +598,21 @@ static HFONT create_scaled_font( const LOGFONTW *deffont ) return CreateFontIndirectW( &lf ); } +static void set_gdi_shared(void) +{ +#ifndef _WIN64 + if (NtCurrentTeb()->GdiBatchCount) + { + TEB64 *teb64 = (TEB64 *)(UINT_PTR)NtCurrentTeb()->GdiBatchCount; + PEB64 *peb64 = (PEB64 *)(UINT_PTR)teb64->Peb; + peb64->GdiSharedHandleTable = (UINT_PTR)&gdi_shared; + return; + } +#endif + /* NOTE: Windows uses 32-bit for 32-bit kernel */ + NtCurrentTeb()->Peb->GdiSharedHandleTable = &gdi_shared; +} + /*********************************************************************** * DllMain * @@ -612,6 +627,7 @@ BOOL WINAPI DllMain( HINSTANCE inst, DWORD reason, LPVOID reserved ) gdi32_module = inst; DisableThreadLibraryCalls( inst ); + set_gdi_shared(); font_init(); /* create stock objects */ diff --git a/dlls/gdi32/tests/gdiobj.c b/dlls/gdi32/tests/gdiobj.c index 8f3d01c27df..80c8b284c62 100644 --- a/dlls/gdi32/tests/gdiobj.c +++ b/dlls/gdi32/tests/gdiobj.c @@ -24,11 +24,14 @@ #include "windef.h" #include "winbase.h" -#include "wingdi.h" +#include "ntgdi.h" #include "winuser.h" +#include "winternl.h" #include "wine/test.h" +static BOOL is_wow64; + static void test_gdi_objects(void) { BYTE buff[256]; @@ -362,11 +365,68 @@ static void test_handles_on_win64(void) } } +static GDI_SHARED_MEMORY *get_gdi_shared(void) +{ +#ifndef _WIN64 + if (NtCurrentTeb()->GdiBatchCount) + { + TEB64 *teb64 = (TEB64 *)(UINT_PTR)NtCurrentTeb()->GdiBatchCount; + PEB64 *peb64 = (PEB64 *)(UINT_PTR)teb64->Peb; + return (GDI_SHARED_MEMORY *)(UINT_PTR)peb64->GdiSharedHandleTable; + } +#endif + return (GDI_SHARED_MEMORY *)NtCurrentTeb()->Peb->GdiSharedHandleTable; +} + +static void test_shared_handle_table(void) +{ + GDI_SHARED_MEMORY *gdi_shared; + GDI_HANDLE_ENTRY *entry; + unsigned int handle; + HRGN hrgn; + + if (sizeof(void *) == 4 && !is_wow64) + { + skip("Skipping shared memory tests on 32-bit Windows\n"); + return; + } + gdi_shared = get_gdi_shared(); + + hrgn = CreateRectRgn(10, 10, 20, 20); + ok(hrgn != 0, "CreateRectRgn failed\n"); + + handle = (UINT_PTR)hrgn; + entry = &gdi_shared->Handles[handle & 0xffff]; + ok(entry->Unique == handle >> 16, "Unique = %x, expected %x\n", + entry->Unique, handle >> 16); + todo_wine + ok(entry->Type == 4, "Type = %x\n", entry->Type); + ok(entry->Object, "Object = NULL\n"); + todo_wine + ok(entry->Owner.ProcessId == GetCurrentProcessId(), "ProcessId = %x, expected %x\n", + entry->Owner.ProcessId, GetCurrentProcessId()); + ok(entry->Owner.Count == 0, "Count = %u\n", entry->Owner.Count); + + DeleteObject(hrgn); + ok(entry->Unique == handle >> 16, "Unique = %x, expected %x\n", + entry->Unique, handle >> 16); + todo_wine + ok(entry->Type == 4, "Type = %x\n", entry->Type); + ok(entry->Object, "Object = NULL\n"); + todo_wine + ok(entry->Owner.ProcessId == GetCurrentProcessId(), "ProcessId = %x, expected %x\n", + entry->Owner.ProcessId, GetCurrentProcessId()); + ok(entry->Owner.Count == 0, "Count = %u\n", entry->Owner.Count); +} + START_TEST(gdiobj) { + if (!IsWow64Process( GetCurrentProcess(), &is_wow64 )) is_wow64 = FALSE; + test_gdi_objects(); test_thread_objects(); test_GetCurrentObject(); test_region(); test_handles_on_win64(); + test_shared_handle_table(); }

1 0

Jacek Caban : gdi32: Use handle layout compatible with GdiSharedHandleTable to store handles.
by Alexandre Julliard 01 Jul '21

01 Jul '21

Module: wine Branch: master Commit: 7f819ea4e955848c8945c2d3ecaeeed54c611f2c URL: https://source.winehq.org/git/wine.git/?a=commit;h=7f819ea4e955848c8945c2d3… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Jun 30 17:37:51 2021 +0200 gdi32: Use handle layout compatible with GdiSharedHandleTable to store handles. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdi32/gdi_private.h | 2 +- dlls/gdi32/gdiobj.c | 110 ++++++++++++++++++++++------------------------- 2 files changed, 53 insertions(+), 59 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=7f819ea4e955848c8945…

1 0

Jacek Caban : include: Add ntgdi.h file.
by Alexandre Julliard 01 Jul '21

01 Jul '21

Module: wine Branch: master Commit: 0cfbeb5520c9de0381b2f727120adcdb9b5f0d94 URL: https://source.winehq.org/git/wine.git/?a=commit;h=0cfbeb5520c9de0381b2f727… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Jun 30 17:37:41 2021 +0200 include: Add ntgdi.h file. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/Makefile.in | 1 + include/ntgdi.h | 172 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 173 insertions(+) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=0cfbeb5520c9de0381b2…

1 0

Jacek Caban : gdi32: Move more fields from gdi_handle_entry to gdi_obj_header.
by Alexandre Julliard 01 Jul '21

01 Jul '21

Module: wine Branch: master Commit: d02eb26413381dbde6d12db50a4cdf80a4fe8a93 URL: https://source.winehq.org/git/wine.git/?a=commit;h=d02eb26413381dbde6d12db5… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Jun 30 17:36:30 2021 +0200 gdi32: Move more fields from gdi_handle_entry to gdi_obj_header. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdi32/gdi_private.h | 10 ++++++++ dlls/gdi32/gdiobj.c | 61 +++++++++++++++++++++--------------------------- 2 files changed, 37 insertions(+), 34 deletions(-) diff --git a/dlls/gdi32/gdi_private.h b/dlls/gdi32/gdi_private.h index 9ad99db394b..8a753c0820f 100644 --- a/dlls/gdi32/gdi_private.h +++ b/dlls/gdi32/gdi_private.h @@ -57,9 +57,19 @@ struct gdi_obj_funcs BOOL (*pDeleteObject)( HGDIOBJ handle ); }; +struct hdc_list +{ + HDC hdc; + struct hdc_list *next; +}; + struct gdi_obj_header { const struct gdi_obj_funcs *funcs; /* type-specific functions */ + struct hdc_list *hdcs; /* list of HDCs interested in this object */ + WORD selcount; /* number of times the object is selected in a DC */ + WORD system : 1; /* system object flag */ + WORD deleted : 1; /* whether DeleteObject has been called on this object */ }; typedef struct tagDC diff --git a/dlls/gdi32/gdiobj.c b/dlls/gdi32/gdiobj.c index cfad39a6923..3e6b268ad72 100644 --- a/dlls/gdi32/gdiobj.c +++ b/dlls/gdi32/gdiobj.c @@ -39,21 +39,11 @@ WINE_DEFAULT_DEBUG_CHANNEL(gdi); #define FIRST_GDI_HANDLE 32 #define MAX_GDI_HANDLES 16384 -struct hdc_list -{ - HDC hdc; - struct hdc_list *next; -}; - struct gdi_handle_entry { void *obj; /* pointer to the object-specific data */ - struct hdc_list *hdcs; /* list of HDCs interested in this object */ WORD generation; /* generation count for reusing handle values */ WORD type; /* object type (one of the OBJ_* constants) */ - WORD selcount; /* number of times the object is selected in a DC */ - WORD system : 1; /* system object flag */ - WORD deleted : 1; /* whether DeleteObject has been called on this object */ }; static struct gdi_handle_entry gdi_handles[MAX_GDI_HANDLES]; @@ -436,7 +426,7 @@ void CDECL __wine_make_gdi_object_system( HGDIOBJ handle, BOOL set) struct gdi_handle_entry *entry; EnterCriticalSection( &gdi_section ); - if ((entry = handle_entry( handle ))) entry->system = !!set; + if ((entry = handle_entry( handle ))) entry_obj( entry )->system = !!set; LeaveCriticalSection( &gdi_section ); } @@ -492,7 +482,7 @@ UINT GDI_get_ref_count( HGDIOBJ handle ) UINT ret = 0; EnterCriticalSection( &gdi_section ); - if ((entry = handle_entry( handle ))) ret = entry->selcount; + if ((entry = handle_entry( handle ))) ret = entry_obj( entry )->selcount; LeaveCriticalSection( &gdi_section ); return ret; } @@ -508,7 +498,7 @@ HGDIOBJ GDI_inc_ref_count( HGDIOBJ handle ) struct gdi_handle_entry *entry; EnterCriticalSection( &gdi_section ); - if ((entry = handle_entry( handle ))) entry->selcount++; + if ((entry = handle_entry( handle ))) entry_obj( entry )->selcount++; else handle = 0; LeaveCriticalSection( &gdi_section ); return handle; @@ -527,11 +517,11 @@ BOOL GDI_dec_ref_count( HGDIOBJ handle ) EnterCriticalSection( &gdi_section ); if ((entry = handle_entry( handle ))) { - assert( entry->selcount ); - if (!--entry->selcount && entry->deleted) + assert( entry_obj( entry )->selcount ); + if (!--entry_obj( entry )->selcount && entry_obj( entry )->deleted) { /* handle delayed DeleteObject*/ - entry->deleted = 0; + entry_obj( entry )->deleted = 0; LeaveCriticalSection( &gdi_section ); TRACE( "executing delayed DeleteObject for %p\n", handle ); DeleteObject( handle ); @@ -725,7 +715,7 @@ static void dump_gdi_objects( void ) else TRACE( "handle %p obj %p type %s selcount %u deleted %u\n", entry_to_handle( entry ), entry->obj, gdi_obj_type( entry->type ), - entry->selcount, entry->deleted ); + entry_obj( entry )->selcount, entry_obj( entry )->deleted ); } LeaveCriticalSection( &gdi_section ); } @@ -757,12 +747,12 @@ HGDIOBJ alloc_gdi_handle( struct gdi_obj_header *obj, WORD type, const struct gd return 0; } obj->funcs = funcs; + obj->hdcs = NULL; + obj->selcount = 0; + obj->system = 0; + obj->deleted = 0; entry->obj = obj; - entry->hdcs = NULL; entry->type = type; - entry->selcount = 0; - entry->system = 0; - entry->deleted = 0; if (++entry->generation == 0xffff) entry->generation = 1; ret = entry_to_handle( entry ); LeaveCriticalSection( &gdi_section ); @@ -900,6 +890,7 @@ BOOL WINAPI DeleteObject( HGDIOBJ obj ) struct gdi_handle_entry *entry; struct hdc_list *hdcs_head; const struct gdi_obj_funcs *funcs = NULL; + struct gdi_obj_header *header; EnterCriticalSection( &gdi_section ); if (!(entry = handle_entry( obj ))) @@ -908,7 +899,8 @@ BOOL WINAPI DeleteObject( HGDIOBJ obj ) return FALSE; } - if (entry->system) + header = entry_obj( entry ); + if (header->system) { TRACE("Preserving system object %p\n", obj); LeaveCriticalSection( &gdi_section ); @@ -917,15 +909,15 @@ BOOL WINAPI DeleteObject( HGDIOBJ obj ) obj = entry_to_handle( entry ); /* make it a full handle */ - hdcs_head = entry->hdcs; - entry->hdcs = NULL; + hdcs_head = header->hdcs; + header->hdcs = NULL; - if (entry->selcount) + if (header->selcount) { - TRACE("delayed for %p because object in use, count %u\n", obj, entry->selcount ); - entry->deleted = 1; /* mark for delete */ + TRACE("delayed for %p because object in use, count %u\n", obj, header->selcount ); + header->deleted = 1; /* mark for delete */ } - else funcs = entry_obj( entry )->funcs; + else funcs = header->funcs; LeaveCriticalSection( &gdi_section ); @@ -964,17 +956,18 @@ void GDI_hdc_using_object(HGDIOBJ obj, HDC hdc) TRACE("obj %p hdc %p\n", obj, hdc); EnterCriticalSection( &gdi_section ); - if ((entry = handle_entry( obj )) && !entry->system) + if ((entry = handle_entry( obj )) && !entry_obj( entry )->system) { - for (phdc = entry->hdcs; phdc; phdc = phdc->next) + struct gdi_obj_header *header = entry_obj( entry ); + for (phdc = header->hdcs; phdc; phdc = phdc->next) if (phdc->hdc == hdc) break; if (!phdc) { phdc = HeapAlloc(GetProcessHeap(), 0, sizeof(*phdc)); phdc->hdc = hdc; - phdc->next = entry->hdcs; - entry->hdcs = phdc; + phdc->next = header->hdcs; + header->hdcs = phdc; } } LeaveCriticalSection( &gdi_section ); @@ -992,9 +985,9 @@ void GDI_hdc_not_using_object(HGDIOBJ obj, HDC hdc) TRACE("obj %p hdc %p\n", obj, hdc); EnterCriticalSection( &gdi_section ); - if ((entry = handle_entry( obj )) && !entry->system) + if ((entry = handle_entry( obj )) && !entry_obj( entry )->system) { - for (pphdc = &entry->hdcs; *pphdc; pphdc = &(*pphdc)->next) + for (pphdc = &entry_obj( entry )->hdcs; *pphdc; pphdc = &(*pphdc)->next) if ((*pphdc)->hdc == hdc) { struct hdc_list *phdc = *pphdc;

1 0

Jacek Caban : gdi32: Introduce gdi_obj_header and use it to store gdi_obj_funcs.
by Alexandre Julliard 01 Jul '21

01 Jul '21

Module: wine Branch: master Commit: a96fcf21b083157d53c90add9a85db16d4028483 URL: https://source.winehq.org/git/wine.git/?a=commit;h=a96fcf21b083157d53c90add… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Jun 30 17:36:19 2021 +0200 gdi32: Introduce gdi_obj_header and use it to store gdi_obj_funcs. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Huw Davies <huw(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdi32/bitmap.c | 2 +- dlls/gdi32/brush.c | 3 ++- dlls/gdi32/dc.c | 2 +- dlls/gdi32/dib.c | 4 ++-- dlls/gdi32/enhmetafile.c | 7 ++++--- dlls/gdi32/font.c | 5 +++-- dlls/gdi32/gdi_private.h | 17 +++++++++++++---- dlls/gdi32/gdiobj.c | 20 ++++++++++++-------- dlls/gdi32/metafile.c | 40 ++++++++++++++++++++++++++-------------- dlls/gdi32/palette.c | 11 ++++++----- dlls/gdi32/pen.c | 9 +++++---- dlls/gdi32/region.c | 8 ++++---- 12 files changed, 79 insertions(+), 49 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=a96fcf21b083157d53c9…

1 0

Alexandre Julliard : kernel32: Fix the DLL check in GetBinaryTypeW().
by Alexandre Julliard 01 Jul '21

01 Jul '21

Module: wine Branch: master Commit: 02268cb290493c899b56996405ca7c65a8046e3c URL: https://source.winehq.org/git/wine.git/?a=commit;h=02268cb290493c899b569964… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Jul 1 10:47:08 2021 +0200 kernel32: Fix the DLL check in GetBinaryTypeW(). Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51375 Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/kernel32/module.c b/dlls/kernel32/module.c index adf6b3c9a60..415f7f65714 100644 --- a/dlls/kernel32/module.c +++ b/dlls/kernel32/module.c @@ -190,7 +190,7 @@ BOOL WINAPI GetBinaryTypeW( LPCWSTR name, LPDWORD type ) status = NtQuerySection( mapping, SectionImageInformation, &info, sizeof(info), NULL ); CloseHandle( mapping ); if (status) return FALSE; - if (!(info.ImageCharacteristics & IMAGE_FILE_DLL)) return FALSE; + if (info.ImageCharacteristics & IMAGE_FILE_DLL) return FALSE; switch (info.Machine) { case IMAGE_FILE_MACHINE_I386:

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits July 2021