wine-commits January 2022

wine-commits@winehq.org

2 participants
726 discussions

Alex Henrie : wined3d: Fix memory leak on error path in wined3d_buffer_vk_create_buffer_object (Coverity).
by Alexandre Julliard 03 Jan '22

03 Jan '22

Module: wine Branch: master Commit: 29c9cf6429ab64d14831b97ad710e47575fe0d81 URL: https://source.winehq.org/git/wine.git/?a=commit;h=29c9cf6429ab64d14831b97a… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Tue Dec 28 21:02:03 2021 -0700 wined3d: Fix memory leak on error path in wined3d_buffer_vk_create_buffer_object (Coverity). Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/buffer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/wined3d/buffer.c b/dlls/wined3d/buffer.c index c078ba7e634..b42c7bd919a 100644 --- a/dlls/wined3d/buffer.c +++ b/dlls/wined3d/buffer.c @@ -1498,6 +1498,7 @@ static BOOL wined3d_buffer_vk_create_buffer_object(struct wined3d_buffer_vk *buf vk_memory_type_from_access_flags(resource->access, resource->usage), bo_vk))) { WARN("Failed to create Vulkan buffer.\n"); + heap_free(bo_vk); return FALSE; }

1 0

Eric Pouech : dbghelp: Don't use .debug_frame section if non present when unwinding.
by Alexandre Julliard 03 Jan '22

03 Jan '22

Module: wine Branch: master Commit: 00a11ff73d22d1392b372cc387f42c9bffc974cd URL: https://source.winehq.org/git/wine.git/?a=commit;h=00a11ff73d22d1392b372cc3… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Mon Jan 3 12:02:14 2022 +0100 dbghelp: Don't use .debug_frame section if non present when unwinding. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52295 Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dbghelp/dwarf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/dbghelp/dwarf.c b/dlls/dbghelp/dwarf.c index 7515e540778..7472b6070e6 100644 --- a/dlls/dbghelp/dwarf.c +++ b/dlls/dbghelp/dwarf.c @@ -3774,7 +3774,8 @@ static BOOL dwarf2_fetch_frame_info(struct module* module, struct cpu* cpu, LONG fde_ctx.data = modfmt->u.dwarf2_info->debug_frame.address; fde_ctx.end_data = fde_ctx.data + modfmt->u.dwarf2_info->debug_frame.size; delta = module->reloc_delta; - if (!dwarf2_get_cie(ip, module, delta, &fde_ctx, &cie_ctx, info, FALSE)) + if (modfmt->u.dwarf2_info->debug_frame.address == IMAGE_NO_MAP || + !dwarf2_get_cie(ip, module, delta, &fde_ctx, &cie_ctx, info, FALSE)) { TRACE("Couldn't find information for %lx\n", ip); return FALSE;

1 0

Alex Henrie : faultrep/tests: Remove registry writability check.
by Alexandre Julliard 03 Jan '22

03 Jan '22

Module: wine Branch: master Commit: 3084624fbe4ebbd947b5b97ab9dabe64f15fa891 URL: https://source.winehq.org/git/wine.git/?a=commit;h=3084624fbe4ebbd947b5b97a… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Sun Jan 2 21:52:11 2022 -0700 faultrep/tests: Remove registry writability check. This check isn't needed anymore either. Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/faultrep/tests/faultrep.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/dlls/faultrep/tests/faultrep.c b/dlls/faultrep/tests/faultrep.c index c71db80cdbb..41f03ee8870 100644 --- a/dlls/faultrep/tests/faultrep.c +++ b/dlls/faultrep/tests/faultrep.c @@ -72,11 +72,6 @@ static void test_AddERExcludedApplicationA(void) /* clean state */ lres = RegCreateKeyA(HKEY_LOCAL_MACHINE, regpath_root, &hroot); - if (lres == ERROR_ACCESS_DENIED) - { - skip("Not enough access rights\n"); - return; - } if (!lres) lres = RegOpenKeyA(hroot, regpath_exclude, &hexclude);

1 0

Michael Stefaniuc : dmsynth/tests: Clarify the sink init / synth latency clock relationship.
by Alexandre Julliard 03 Jan '22

03 Jan '22

Module: wine Branch: master Commit: 56034f1f0959102e096c70a50ccaa259c6d3ea1b URL: https://source.winehq.org/git/wine.git/?a=commit;h=56034f1f0959102e096c70a5… Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Mon Jan 3 00:16:03 2022 +0100 dmsynth/tests: Clarify the sink init / synth latency clock relationship. Signed-off-by: Michael Stefaniuc <mstefani(a)winehq.org> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dmsynth/tests/dmsynth.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/dlls/dmsynth/tests/dmsynth.c b/dlls/dmsynth/tests/dmsynth.c index 3ddf40817a5..3970933cb6f 100644 --- a/dlls/dmsynth/tests/dmsynth.c +++ b/dlls/dmsynth/tests/dmsynth.c @@ -44,6 +44,13 @@ static BOOL missing_dmsynth(void) return TRUE; } +static ULONG get_refcount(void *iface) +{ + IUnknown *unknown = iface; + IUnknown_AddRef(unknown); + return IUnknown_Release(unknown); +} + static void test_dmsynth(void) { IDirectMusicSynth *dmsynth = NULL; @@ -52,6 +59,7 @@ static void test_dmsynth(void) IReferenceClock* clock_sink = NULL; IKsControl* control_synth = NULL; IKsControl* control_sink = NULL; + ULONG ref_clock_synth, ref_clock_sink; HRESULT hr; KSPROPERTY property; ULONG value; @@ -104,6 +112,10 @@ static void test_dmsynth(void) ok(bytes == sizeof(DWORD), "Returned bytes: %u, should be 4\n", bytes); ok(value == TRUE, "Return value: %u, should be 1\n", value); + /* Synth isn't fully initialized yet */ + hr = IDirectMusicSynth_Activate(dmsynth, TRUE); + todo_wine ok(hr == DMUS_E_NOSYNTHSINK, "IDirectMusicSynth_Activate returned: %x\n", hr); + /* Synth has no default clock */ hr = IDirectMusicSynth_GetLatencyClock(dmsynth, &clock_synth); ok(hr == DMUS_E_NOSYNTHSINK, "IDirectMusicSynth_GetLatencyClock returned: %x\n", hr); @@ -112,8 +124,9 @@ static void test_dmsynth(void) hr = IDirectMusicSynthSink_GetLatencyClock(dmsynth_sink, &clock_sink); ok(hr == S_OK, "IDirectMusicSynth_GetLatencyClock returned: %x\n", hr); ok(clock_sink != NULL, "No clock returned\n"); + ref_clock_sink = get_refcount(clock_sink); - /* This will set clock to Synth */ + /* This will Init() the SynthSink and finish initializing the Synth */ hr = IDirectMusicSynth_SetSynthSink(dmsynth, dmsynth_sink); ok(hr == S_OK, "IDirectMusicSynth_SetSynthSink returned: %x\n", hr); @@ -122,6 +135,8 @@ static void test_dmsynth(void) ok(hr == S_OK, "IDirectMusicSynth_GetLatencyClock returned: %x\n", hr); ok(clock_synth != NULL, "No clock returned\n"); ok(clock_synth == clock_sink, "Synth and SynthSink clocks are not the same\n"); + ref_clock_synth = get_refcount(clock_synth); + ok(ref_clock_synth > ref_clock_sink + 1, "Latency clock refcount didn't increase\n"); if (control_synth) IDirectMusicSynth_Release(control_synth);

1 0

Roman Pišl : comctl32: Fix return type of ImageList_WriteEx.
by Alexandre Julliard 03 Jan '22

03 Jan '22

Module: wine Branch: master Commit: dd7d344f292d860eb2b9a4512bb9b69a682856ab URL: https://source.winehq.org/git/wine.git/?a=commit;h=dd7d344f292d860eb2b9a451… Author: Roman Pišl <rpisl(a)seznam.cz> Date: Sun Jan 2 22:27:05 2022 +0100 comctl32: Fix return type of ImageList_WriteEx. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52323 Signed-off-by: Roman Pišl <rpisl(a)seznam.cz> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/comctl32/imagelist.c | 4 ++-- include/commctrl.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/comctl32/imagelist.c b/dlls/comctl32/imagelist.c index 8da8beec1e0..155d4b2a956 100644 --- a/dlls/comctl32/imagelist.c +++ b/dlls/comctl32/imagelist.c @@ -3061,10 +3061,10 @@ failed: /************************************************************************* * ImageList_WriteEx [COMCTL32.@] */ -BOOL WINAPI ImageList_WriteEx(HIMAGELIST himl, DWORD flags, IStream *pstm) +HRESULT WINAPI ImageList_WriteEx(HIMAGELIST himl, DWORD flags, IStream *pstm) { FIXME("%p %08x %p: semi-stub\n", himl, flags, pstm); - return ImageList_Write(himl, pstm); + return ImageList_Write(himl, pstm) ? S_OK : E_FAIL; } /************************************************************************* diff --git a/include/commctrl.h b/include/commctrl.h index 025eb328c32..c6d9dd32928 100644 --- a/include/commctrl.h +++ b/include/commctrl.h @@ -602,7 +602,7 @@ BOOL WINAPI ImageList_SetOverlayImage(HIMAGELIST,INT,INT); #ifdef __IStream_INTERFACE_DEFINED__ HIMAGELIST WINAPI ImageList_Read(LPSTREAM); BOOL WINAPI ImageList_Write(HIMAGELIST,IStream*); -BOOL WINAPI ImageList_WriteEx(HIMAGELIST,DWORD,IStream*); +HRESULT WINAPI ImageList_WriteEx(HIMAGELIST,DWORD,IStream*); #endif #define ImageList_AddIcon(himl,hicon) ImageList_ReplaceIcon(himl,-1,hicon)

1 0

Alexandre Julliard : Wine release 7.0-rc4
by Alexandre Julliard 02 Jan '22

02 Jan '22

Module: website Branch: master Commit: 719acbc64c09b7ef5cee0d144d9f0993548e0beb URL: https://source.winehq.org/git/website.git/?a=commit;h=719acbc64c09b7ef5cee0… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Sun Jan 2 22:29:29 2022 +0100 Wine release 7.0-rc4 Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- news/en/2022010201.xml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/news/en/2022010201.xml b/news/en/2022010201.xml new file mode 100644 index 00000000..a75005c0 --- /dev/null +++ b/news/en/2022010201.xml @@ -0,0 +1,13 @@ +<news> +<date>January 2, 2022</date> +<title>Wine 7.0-rc4 Released</title> +<body> + The Wine development release 7.0-rc4 is now available. + <a href="{$root}/announce/7.0-rc4">What's new</a> in this release: +<ul> + <li>Bug fixes only, we are in code freeze.</li> +</ul> + +The source is <a href="//dl.winehq.org/wine/source/7.0/wine-7.0-rc4.tar.xz">available now</a>. +Binary packages are in the process of being built, and will appear soon at their respective <a href="{$root}/download">download locations</a>. +</body></news>

1 0

Tag wine-7.0-rc4 : Alexandre Julliard : Release 7.0-rc4
by Alexandre Julliard 02 Jan '22

02 Jan '22

Module: wine Branch: refs/tags/wine-7.0-rc4 Tag: 18608b67448a21747396c166d7d2abed41a5b215 URL: https://source.winehq.org/git/wine.git/?a=tag;h=18608b67448a21747396c166d7d… Tagger: Alexandre Julliard <julliard(a)winehq.org> Date: Sun Jan 2 22:27:12 2022 +0100 Release 7.0-rc4

1 0

Alexandre Julliard : Release 7.0-rc4.
by Alexandre Julliard 02 Jan '22

02 Jan '22

Module: wine Branch: master Commit: 2318484e1e33cb30f00eb9a62cb9aa5f83e5dc99 URL: https://source.winehq.org/git/wine.git/?a=commit;h=2318484e1e33cb30f00eb9a6… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Sun Jan 2 22:27:12 2022 +0100 Release 7.0-rc4. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- ANNOUNCE | 240 ++++++++++++++++++++++++++++++-------------------------------- VERSION | 2 +- configure | 18 ++--- 3 files changed, 126 insertions(+), 134 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=2318484e1e33cb30f00e…

1 0

Jactry Zeng : po: Update Simplified Chinese translation.
by Alexandre Julliard 02 Jan '22

02 Jan '22

Module: wine Branch: master Commit: 46516cf0038fd7cd0fc0480d79e767c215ba84fc URL: https://source.winehq.org/git/wine.git/?a=commit;h=46516cf0038fd7cd0fc0480d… Author: Jactry Zeng <jzeng(a)codeweavers.com> Date: Sun Jan 2 11:26:27 2022 -0600 po: Update Simplified Chinese translation. Signed-off-by: Jactry Zeng <jzeng(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- po/zh_CN.po | 1868 ++++++++++++++++++++++++++--------------------------------- 1 file changed, 808 insertions(+), 1060 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=46516cf0038fd7cd0fc0…

1 0

Eric Pouech : po: Some more French translations.
by Alexandre Julliard 02 Jan '22

02 Jan '22

Module: wine Branch: master Commit: a38ced9354aa7d74f396fb91372dbbb7dccd2e2e URL: https://source.winehq.org/git/wine.git/?a=commit;h=a38ced9354aa7d74f396fb91… Author: Eric Pouech <eric.pouech(a)gmail.com> Date: Sun Jan 2 15:49:09 2022 +0100 po: Some more French translations. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- po/fr.po | 970 ++++++++++++++++++++++++++++++++------------------------------- 1 file changed, 489 insertions(+), 481 deletions(-) Diff: https://source.winehq.org/git/wine.git/?a=commitdiff;h=a38ced9354aa7d74f396…

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits January 2022