wine-commits December 2022

wine-commits@winehq.org

1 participants
539 discussions

Francois Gouget : testbot/LogUtils: Track the known new failures and warnings.
by Alexandre Julliard 07 Dec '22

07 Dec '22

Module: tools Branch: master Commit: d7f66da4f6092ecb26ff40a3111a9208406f1f73 URL: https://gitlab.winehq.org/winehq/tools/-/commit/d7f66da4f6092ecb26ff40a3111… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Thu Nov 3 03:10:54 2022 +0100 testbot/LogUtils: Track the known new failures and warnings. This adds a per-message-type KnownNew counter to the $LogInfo structure which allows callers to quickly discount the new but known failures and warnings. --- testbot/lib/WineTestBot/LogUtils.pm | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/testbot/lib/WineTestBot/LogUtils.pm b/testbot/lib/WineTestBot/LogUtils.pm index c381906d..e4145628 100644 --- a/testbot/lib/WineTestBot/LogUtils.pm +++ b/testbot/lib/WineTestBot/LogUtils.pm @@ -1047,7 +1047,15 @@ sub LoadLogErrorsFromFh($$) } elsif ($Type eq "f") { - $LogInfo->{CurGroup}->{Failures}->{$Property} = [ split / /, $Value ]; + my $MsgIndex = $Property; + my $CurGroup = $LogInfo->{CurGroup}; + $CurGroup->{Failures}->{$Property} = [ split / /, $Value ]; + if ($CurGroup->{IsNew}->[$MsgIndex]) + { + my $Type = $CurGroup->{Types}->[$MsgIndex]; + $CurGroup->{"${Type}KnownNew"}++; + $LogInfo->{"${Type}KnownNew"}++; + } } else { @@ -1514,6 +1522,12 @@ sub MatchLogFailures($$) my $LineFailures = $Group->{Failures}->{$MsgIndex} ||= []; push @$LineFailures, $UnitFailure->Id; + if ($Group->{IsNew}->[$MsgIndex]) + { + my $Type = $Group->{Types}->[$MsgIndex]; + $Group->{"${Type}KnownNew"}++; + $LogInfo->{"${Type}KnownNew"}++; + } my $LogFailure = $LogFailures->{Failures}->{$UnitFailure->Id}; if (!$LogFailure)

1 0

Francois Gouget : testbot: Add Task fields to track warnings, failures and bad test units.
by Alexandre Julliard 07 Dec '22

07 Dec '22

Module: tools Branch: master Commit: cc2b971a9c02838154cf94171e539a846133faf7 URL: https://gitlab.winehq.org/winehq/tools/-/commit/cc2b971a9c02838154cf94171e5… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Fri Oct 28 02:56:25 2022 +0200 testbot: Add Task fields to track warnings, failures and bad test units. So far the tasks have a TestFailures field which tracks the number of failures for that task, but not whether any of them is new. This adds a field to keep track of the number of new failures and another pair to do the same for warnings. This further adds a field to track the numbder of failed test units. These fields can then be used in the web pages to indicate whether there are new failures / warnings, and how many test units have failed. But until there is support for setting these fields, they are hidden. --- testbot/bin/Engine.pl | 4 ++++ testbot/ddl/update48.sql | 11 +++++++++++ testbot/ddl/winetestbot.sql | 4 ++++ testbot/lib/WineTestBot/Jobs.pm | 4 ++++ testbot/lib/WineTestBot/StepsTasks.pm | 8 ++++++++ testbot/lib/WineTestBot/Tasks.pm | 4 ++++ testbot/web/JobDetails.pl | 2 +- 7 files changed, 36 insertions(+), 1 deletion(-) diff --git a/testbot/bin/Engine.pl b/testbot/bin/Engine.pl index 39577d14..d51adcb4 100755 --- a/testbot/bin/Engine.pl +++ b/testbot/bin/Engine.pl @@ -147,7 +147,11 @@ sub Cleanup($;$$) $Task->Status("queued"); $Task->Started(undef); $Task->Ended(undef); + $Task->NewWarnings(undef); + $Task->Warnings(undef); + $Task->NewTestFailures(undef); $Task->TestFailures(undef); + $Task->FailedTestUnits(undef); $Task->Save(); $CallUpdateStatus = 1; } diff --git a/testbot/ddl/update48.sql b/testbot/ddl/update48.sql new file mode 100644 index 00000000..79b14d06 --- /dev/null +++ b/testbot/ddl/update48.sql @@ -0,0 +1,11 @@ +USE winetestbot; + +ALTER TABLE Tasks + ADD NewWarnings INT(6) NULL + AFTER Ended, + ADD Warnings INT(6) NULL + AFTER NewWarnings, + ADD NewTestFailures INT(6) NULL + AFTER Warnings, + ADD FailedTestUnits INT(6) NULL + AFTER TestFailures; diff --git a/testbot/ddl/winetestbot.sql b/testbot/ddl/winetestbot.sql index 0cf70484..3c4f32a0 100644 --- a/testbot/ddl/winetestbot.sql +++ b/testbot/ddl/winetestbot.sql @@ -158,7 +158,11 @@ CREATE TABLE Tasks CmdLineArg VARCHAR(256) NULL, Started DATETIME NULL, Ended DATETIME NULL, + NewWarnings INT(6) NULL, + Warnings INT(6) NULL, + NewTestFailures INT(6) NULL, TestFailures INT(6) NULL, + FailedTestUnits INT(6) NULL, PRIMARY KEY (JobId, StepNo, No), FOREIGN KEY(VMName) REFERENCES VMs(Name) ) diff --git a/testbot/lib/WineTestBot/Jobs.pm b/testbot/lib/WineTestBot/Jobs.pm index b54f864d..c5becbef 100644 --- a/testbot/lib/WineTestBot/Jobs.pm +++ b/testbot/lib/WineTestBot/Jobs.pm @@ -412,7 +412,11 @@ sub Restart($) $Task->Status("queued"); $Task->Started(undef); $Task->Ended(undef); + $Task->NewWarnings(undef); + $Task->Warnings(undef); + $Task->NewTestFailures(undef); $Task->TestFailures(undef); + $Task->FailedTestUnits(undef); } $Step->Status("queued"); $Step->RmTree(); diff --git a/testbot/lib/WineTestBot/StepsTasks.pm b/testbot/lib/WineTestBot/StepsTasks.pm index 87146b27..928d33a4 100644 --- a/testbot/lib/WineTestBot/StepsTasks.pm +++ b/testbot/lib/WineTestBot/StepsTasks.pm @@ -157,7 +157,11 @@ sub _initialize($$) $StepTask->CmdLineArg($Task->CmdLineArg); $StepTask->Started($Task->Started); $StepTask->Ended($Task->Ended); + $StepTask->NewWarnings($Task->NewWarnings); + $StepTask->Warnings($Task->Warnings); + $StepTask->NewTestFailures($Task->NewTestFailures); $StepTask->TestFailures($Task->TestFailures); + $StepTask->FailedTestUnits($Task->FailedTestUnits); $self->{Items}{$StepTask->GetKey()} = $StepTask; } @@ -190,7 +194,11 @@ my @PropertyDescriptors = ( CreateBasicPropertyDescriptor("CmdLineArg", "Command line args", !1, !1, "A", 256), CreateBasicPropertyDescriptor("Started", "Started", !1, !1, "DT", 19), CreateBasicPropertyDescriptor("Ended", "Ended", !1, !1, "DT", 19), + CreateBasicPropertyDescriptor("NewWarnings", "New Warnings", !1, !1, "N", 6), + CreateBasicPropertyDescriptor("Warnings", "Warnings", !1, !1, "N", 6), + CreateBasicPropertyDescriptor("NewTestFailures", "New Failures", !1, !1, "N", 6), CreateBasicPropertyDescriptor("TestFailures", "Failures", !1, !1, "N", 6), + CreateBasicPropertyDescriptor("FailedTestUnits", "Bad Test Units", !1, !1, "N", 6), ); SetupItemrefColumns(\@PropertyDescriptors); diff --git a/testbot/lib/WineTestBot/Tasks.pm b/testbot/lib/WineTestBot/Tasks.pm index 5b87c782..b6332d2d 100644 --- a/testbot/lib/WineTestBot/Tasks.pm +++ b/testbot/lib/WineTestBot/Tasks.pm @@ -363,7 +363,11 @@ my @PropertyDescriptors = ( CreateBasicPropertyDescriptor("CmdLineArg", "Command line args", !1, !1, "A", 256), CreateBasicPropertyDescriptor("Started", "Started", !1, !1, "DT", 19), CreateBasicPropertyDescriptor("Ended", "Ended", !1, !1, "DT", 19), + CreateBasicPropertyDescriptor("NewWarnings", "New Warnings", !1, !1, "N", 6), + CreateBasicPropertyDescriptor("Warnings", "Warnings", !1, !1, "N", 6), + CreateBasicPropertyDescriptor("NewTestFailures", "New Failures", !1, !1, "N", 6), CreateBasicPropertyDescriptor("TestFailures", "Failures", !1, !1, "N", 6), + CreateBasicPropertyDescriptor("FailedTestUnits", "Bad Test Units", !1, !1, "N", 6), CreateDetailrefPropertyDescriptor("Failures", "Known failures", \&CreateTaskFailures), ); SetupItemrefColumns(\@PropertyDescriptors); diff --git a/testbot/web/JobDetails.pl b/testbot/web/JobDetails.pl index 0b42aea5..035cba8c 100644 --- a/testbot/web/JobDetails.pl +++ b/testbot/web/JobDetails.pl @@ -50,7 +50,7 @@ sub DisplayProperty($$) my ($self, $PropertyDescriptor) = @_; my $PropertyName = $PropertyDescriptor->GetName(); - return $PropertyName =~ /^(?:Id|PreviousNo|Type|VM|FileType|Missions)$/ ? "" : + return $PropertyName =~ /^(?:Id|PreviousNo|Type|VM|FileType|Missions|NewWarnings|Warnings|NewTestFailures|FailedTestUnits)$/ ? "" : $PropertyName eq "Started" ? ("ro", "timetipdate") : $self->SUPER::DisplayProperty($PropertyDescriptor); }

1 0

Francois Gouget : testbot/orm: Fix a minor formatting issues.
by Alexandre Julliard 07 Dec '22

07 Dec '22

Module: tools Branch: master Commit: 1e840275b5d08e4b0fb15541e5dfa8f80489fc4b URL: https://gitlab.winehq.org/winehq/tools/-/commit/1e840275b5d08e4b0fb15541e5d… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Wed Nov 30 16:21:30 2022 +0100 testbot/orm: Fix a minor formatting issues. --- testbot/lib/ObjectModel/Collection.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testbot/lib/ObjectModel/Collection.pm b/testbot/lib/ObjectModel/Collection.pm index 9dcaf33d..222c26a1 100644 --- a/testbot/lib/ObjectModel/Collection.pm +++ b/testbot/lib/ObjectModel/Collection.pm @@ -894,7 +894,7 @@ sub PrepareFilter($$) sub AddFilter($$;$$) { my $self = shift; - my $Filter =@_ == 1 ? $_[0] : FilterValue($_[0], $_[2] || "=", $_[1]); + my $Filter = @_ == 1 ? $_[0] : FilterValue($_[0], $_[2] || "=", $_[1]); $self->PrepareFilter($Filter); if (!$self->{Filter})

1 0

Francois Gouget : testbot/LogUtils: Don't try to match deleted known failures.
by Alexandre Julliard 07 Dec '22

07 Dec '22

Module: tools Branch: master Commit: 9201d1b1a63397c14e009993b05a0f8012198ba1 URL: https://gitlab.winehq.org/winehq/tools/-/commit/9201d1b1a63397c14e009993b05… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Wed Nov 30 16:19:47 2022 +0100 testbot/LogUtils: Don't try to match deleted known failures. Entries marked deleted will actually be deleted once nothing references them anymore. But that may not happen if the TestBot keeps trying to match them and potentially adding new references. --- testbot/lib/WineTestBot/LogUtils.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/testbot/lib/WineTestBot/LogUtils.pm b/testbot/lib/WineTestBot/LogUtils.pm index 241eda46..c381906d 100644 --- a/testbot/lib/WineTestBot/LogUtils.pm +++ b/testbot/lib/WineTestBot/LogUtils.pm @@ -1469,6 +1469,7 @@ sub MatchLogFailures($$) my $ConfigName = $Task->VMName .":$LogInfo->{LogName}"; $LogFailures->{Collection} = CreateFailures(); + $LogFailures->{Collection}->AddFilter("BugStatus", ["deleted"], "<>"); foreach my $Failure (@{$LogFailures->{Collection}->GetItems()}) { # Ignore failures that don't apply to this configuration

1 0

Alexandre Julliard : packaging: Remove Fedora 35.
by Alexandre Julliard 07 Dec '22

07 Dec '22

Module: tools Branch: master Commit: e46e9bf8f59511d69c68fbb2e61eb2cc1f21637d URL: https://gitlab.winehq.org/winehq/tools/-/commit/e46e9bf8f59511d69c68fbb2e61… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Nov 14 20:19:11 2022 +0100 packaging: Remove Fedora 35. --- packaging/obs/obs-sync | 2 +- packaging/obs/rsync-filter | 1 - packaging/obs/yum.conf | 4 ---- 3 files changed, 1 insertion(+), 6 deletions(-) diff --git a/packaging/obs/obs-sync b/packaging/obs/obs-sync index 722a8659..33bfcebd 100755 --- a/packaging/obs/obs-sync +++ b/packaging/obs/obs-sync @@ -198,7 +198,7 @@ publish_files () cd $basedir -distros="35 36 37 bullseye bookworm bionic focal jammy kinetic" +distros="36 37 bullseye bookworm bionic focal jammy kinetic" dry_run= build=1 diff --git a/packaging/obs/rsync-filter b/packaging/obs/rsync-filter index 0c565b8b..c174ff25 100644 --- a/packaging/obs/rsync-filter +++ b/packaging/obs/rsync-filter @@ -1,5 +1,4 @@ + /fedora -+ /fedora/35 + /fedora/36 + /fedora/37 - /fedora/* diff --git a/packaging/obs/yum.conf b/packaging/obs/yum.conf index a75b7960..c600e2c4 100644 --- a/packaging/obs/yum.conf +++ b/packaging/obs/yum.conf @@ -4,10 +4,6 @@ debuglevel=0 logfile=/var/log/yum.log gpgcheck=1 -[fedora-35] -name = Fedora 35 -baseurl=https://download.opensuse.org/repositories/Emulators:/Wine:/Fedora/Fedora_35 - [fedora-36] name = Fedora 36 baseurl=https://download.opensuse.org/repositories/Emulators:/Wine:/Fedora/…

1 0

Tag vkd3d-1.6 : Alexandre Julliard : Release 1.6
by Alexandre Julliard 07 Dec '22

07 Dec '22

Module: vkd3d Branch: refs/tags/vkd3d-1.6 Tag: 5513cc393d787e68d936f69794b3fcbc2685c724 URL: https://gitlab.winehq.org/wine/vkd3d/-/tags/5513cc393d787e68d936f69794b3fcb… Tagger: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Dec 7 16:20:25 2022 +0100 Release 1.6

1 0

Henri Verbeet : Release 1.6.
by Alexandre Julliard 07 Dec '22

07 Dec '22

Module: vkd3d Branch: master Commit: 1eaf73147cd370e2d721285ed6f62ee3c6661a6d URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/1eaf73147cd370e2d721285ed6f62… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Tue Nov 29 12:58:11 2022 +0100 Release 1.6. --- ANNOUNCE | 54 ++++++++++++++++++++++--------------- AUTHORS | 1 + Makefile.am | 6 ++--- configure.ac | 2 +- demos/demo_xcb.h | 2 +- include/vkd3d.h | 1 + include/vkd3d_shader.h | 1 + libs/vkd3d-shader/spirv.c | 2 +- libs/vkd3d-utils/vkd3d_utils_main.c | 4 +-- libs/vkd3d/state.c | 4 +-- programs/vkd3d-compiler/main.c | 2 +- 11 files changed, 46 insertions(+), 33 deletions(-)

1 0

Henri Verbeet : build: Add the demo shaders to the distribution.
by Alexandre Julliard 07 Dec '22

07 Dec '22

Module: vkd3d Branch: master Commit: d5f810068b37a062aa9f538e62a8490286b71eaf URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/d5f810068b37a062aa9f538e62a84… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Tue Dec 6 11:58:24 2022 +0100 build: Add the demo shaders to the distribution. --- Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 00e7e40e..e877c502 100644 --- a/Makefile.am +++ b/Makefile.am @@ -342,11 +342,11 @@ DEMOS_LDADD = $(LDADD) libvkd3d-shader.la @DL_LIBS@ @DEMO_LIBS@ DEMOS_CFLAGS = $(AM_CFLAGS) @DEMO_CFLAGS@ bin_PROGRAMS += $(vkd3d_demos) -demos_vkd3d_gears_SOURCES = demos/gears.c +demos_vkd3d_gears_SOURCES = demos/gears.c demos/gears_hlsl.h demos_vkd3d_gears_CFLAGS = $(DEMOS_CFLAGS) demos_vkd3d_gears_LDADD = $(DEMOS_LDADD) -lm -demos_vkd3d_triangle_SOURCES = demos/triangle.c +demos_vkd3d_triangle_SOURCES = demos/triangle.c demos/triangle_hlsl.h demos_vkd3d_triangle_CFLAGS = $(DEMOS_CFLAGS) demos_vkd3d_triangle_LDADD = $(DEMOS_LDADD) endif

1 0

Henri Verbeet : build: Remove $(vkd3d_demos_shaders) from the distribution.
by Alexandre Julliard 07 Dec '22

07 Dec '22

Module: vkd3d Branch: master Commit: 21302c09eb5d5912c09d95265d20481584ca3457 URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/21302c09eb5d5912c09d95265d204… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Tue Dec 6 11:54:39 2022 +0100 build: Remove $(vkd3d_demos_shaders) from the distribution. These were removed in commits 3d85d77cedfd9e8aece1c1feb622d82425f7e9ee and 763f7dfa6196344da7c4fbb94dad9af42c26ac5b. --- Makefile.am | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/Makefile.am b/Makefile.am index 85cd4642..00e7e40e 100644 --- a/Makefile.am +++ b/Makefile.am @@ -31,15 +31,6 @@ vkd3d_public_headers = \ include/vkd3d_utils.h \ include/vkd3d_windows.h -vkd3d_demos_shaders = \ - demos/gears.hlsl \ - demos/gears_ps_flat.h \ - demos/gears_ps_smooth.h \ - demos/gears_vs.h \ - demos/triangle.hlsl \ - demos/triangle_ps.h \ - demos/triangle_vs.h - vkd3d_tests = \ tests/vkd3d_api \ tests/vkd3d_common \ @@ -378,8 +369,6 @@ else @echo "widl is required to generate $@" endif -EXTRA_DIST += $(vkd3d_demos_shaders) - libvkd3d-utils.pc: $(srcdir)/libs/vkd3d-utils/libvkd3d-utils.pc.in Makefile $(AM_V_GEN)$(SED) -e 's![@]prefix[@]!$(prefix)!g' \ -e 's![@]exec_prefix[@]!$(exec_prefix)!g' \

1 0

Paul Gofman : windows.devices.enumeration/tests: Make test handlers structure static.
by Alexandre Julliard 06 Dec '22

06 Dec '22

Module: wine Branch: master Commit: 0da7ad35f130a2ea59380dcad2179b972b3a909d URL: https://gitlab.winehq.org/wine/wine/-/commit/0da7ad35f130a2ea59380dcad2179b… Author: Paul Gofman <pgofman(a)codeweavers.com> Date: Tue Dec 6 09:55:01 2022 -0600 windows.devices.enumeration/tests: Make test handlers structure static. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54085 --- dlls/windows.devices.enumeration/tests/devices.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/windows.devices.enumeration/tests/devices.c b/dlls/windows.devices.enumeration/tests/devices.c index 72bce374410..c65312ea800 100644 --- a/dlls/windows.devices.enumeration/tests/devices.c +++ b/dlls/windows.devices.enumeration/tests/devices.c @@ -139,7 +139,7 @@ static void test_DeviceInformation( void ) { static const WCHAR *device_info_name = L"Windows.Devices.Enumeration.DeviceInformation"; - struct device_watcher_handler stopped_handler, added_handler; + static struct device_watcher_handler stopped_handler, added_handler; EventRegistrationToken stopped_token, added_token; IInspectable *inspectable, *inspectable2; IActivationFactory *factory;

1 0

← Newer
1
...
30
31
32
33
34
35
36
...
54
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits December 2022