wine-commits April 2022

wine-commits@winehq.org

2 participants
1024 discussions

Francois Gouget : testbot/cgi: Remove a stray single quote from textarea fields.
by Alexandre Julliard 01 Apr '22

01 Apr '22

Module: tools Branch: master Commit: 462c1cc80db09fbe9d21cf375d048baf83838e7e URL: https://source.winehq.org/git/tools.git/?a=commit;h=462c1cc80db09fbe9d21cf3… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Fri Apr 1 17:09:51 2022 +0200 testbot/cgi: Remove a stray single quote from textarea fields. It would set the default value of textareas to a single quote. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/ObjectModel/CGI/FormPage.pm | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/testbot/lib/ObjectModel/CGI/FormPage.pm b/testbot/lib/ObjectModel/CGI/FormPage.pm index 9ce9fa9..dfcd55e 100644 --- a/testbot/lib/ObjectModel/CGI/FormPage.pm +++ b/testbot/lib/ObjectModel/CGI/FormPage.pm @@ -300,10 +300,7 @@ sub GenerateField($$$) print "50' rows='", int(($MaxLength + 49) / 50); } print "'>"; - if (defined $Value) - { - print $self->escapeHTML($Value), "'"; - } + print $self->escapeHTML($Value) if (defined $Value); print "</textarea>"; $self->GenerateRequired($PropertyDescriptor); }

1 0

Francois Gouget : testbot: Document SecureConnection() and MakeSecureURL().
by Alexandre Julliard 01 Apr '22

01 Apr '22

Module: tools Branch: master Commit: 00fe5045513e213d54c87f1a1e43d8f38a6d6a48 URL: https://source.winehq.org/git/tools.git/?a=commit;h=00fe5045513e213d54c87f1… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Fri Apr 1 17:09:41 2022 +0200 testbot: Document SecureConnection() and MakeSecureURL(). Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/WineTestBot/Utils.pm | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/testbot/lib/WineTestBot/Utils.pm b/testbot/lib/WineTestBot/Utils.pm index 5315c75..d93a938 100644 --- a/testbot/lib/WineTestBot/Utils.pm +++ b/testbot/lib/WineTestBot/Utils.pm @@ -42,11 +42,38 @@ use WineTestBot::Config; # Web helpers # +=pod +=over 12 + +=item C<SecureConnection()> + +Returns true if the user accessed the website over a secure connection. + +This relies on the web server setting the $HTTPS environment variable. + +=back +=cut + sub SecureConnection() { return defined($ENV{"HTTPS"}) && $ENV{"HTTPS"} eq "on"; } +=pod +=over 12 + +=item C<MakeSecureURL()> + +Builds a URL that accesses this website using https if possible. +The parameter should be an absolute path that includes neither the protocol +nor the hostname. + +Note that this method uses $HTTP_HOST which may not match the official website +hostname. As such this should only be used for providing URLs back to the user +accessing the website, not for URLs sent to third-parties. + +=back +=cut sub MakeSecureURL($) { my ($URL) = @_;

1 0

Francois Gouget : testbot/TestAgent: Simplify the implementation for commands with no argument.
by Alexandre Julliard 01 Apr '22

01 Apr '22

Module: tools Branch: master Commit: c923c74ac05d42d8f18e484be337a93164f42ded URL: https://source.winehq.org/git/tools.git/?a=commit;h=c923c74ac05d42d8f18e484… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Fri Apr 1 17:09:18 2022 +0200 testbot/TestAgent: Simplify the implementation for commands with no argument. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/scripts/TestAgent | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/testbot/scripts/TestAgent b/testbot/scripts/TestAgent index 10bdc63..8691f47 100755 --- a/testbot/scripts/TestAgent +++ b/testbot/scripts/TestAgent @@ -210,15 +210,7 @@ while (@ARGV) @Rm = @ARGV; last; } - elsif ($arg eq "getcwd") - { - $Cmd = $arg; - } - elsif ($arg eq "getversion") - { - set_cmd($arg); - } - elsif ($arg eq "ping" or $arg eq "settime") + elsif ($arg =~ /^(?:getcwd|getversion|ping|settime)$/) { set_cmd($arg); }

1 0

Francois Gouget : testbot/TestAgent: Fix the spelling of a comment in the module.
by Alexandre Julliard 01 Apr '22

01 Apr '22

Module: tools Branch: master Commit: d33367a150aa6cc66032b97b0e4e617e5c0d0dfd URL: https://source.winehq.org/git/tools.git/?a=commit;h=d33367a150aa6cc66032b97… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Fri Apr 1 17:09:07 2022 +0200 testbot/TestAgent: Fix the spelling of a comment in the module. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/WineTestBot/TestAgent.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testbot/lib/WineTestBot/TestAgent.pm b/testbot/lib/WineTestBot/TestAgent.pm index 6457b4d..2d60021 100644 --- a/testbot/lib/WineTestBot/TestAgent.pm +++ b/testbot/lib/WineTestBot/TestAgent.pm @@ -1526,7 +1526,7 @@ sub Upgrade($$) my $rc = $self->_RecvList(''); # The server has quit and thus the connection is no longer usable. - # So disconnect now to force the next RPC to reconnect, instead or letting it + # So disconnect now to force the next RPC to reconnect instead of letting it # try to reuse the broken connection and fail. $self->Disconnect();

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits April 2022