wine-commits August 2022

wine-commits@winehq.org

1 participants
596 discussions

Alexandre Julliard : winetest: Disable the crash dialog in non-interactive mode.
by Alexandre Julliard 16 Aug '22

16 Aug '22

Module: wine Branch: master Commit: 3deabed43d73695d0829a7b7fd4cec8c516f84a3 URL: https://gitlab.winehq.org/wine/wine/-/commit/3deabed43d73695d0829a7b7fd4cec… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Aug 16 17:41:31 2022 +0200 winetest: Disable the crash dialog in non-interactive mode. --- programs/winetest/main.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/programs/winetest/main.c b/programs/winetest/main.c index 13a5c5ab294..7caa20d862a 100644 --- a/programs/winetest/main.c +++ b/programs/winetest/main.c @@ -362,6 +362,34 @@ static BOOL is_stub_dll(const char *filename) return isstub; } +static int disable_crash_dialog(void) +{ + HKEY key; + DWORD type, data, size; + int ret = 0; + + if (RegCreateKeyA( HKEY_CURRENT_USER, "Software\\Wine\\WineDbg", &key )) return 0; + size = sizeof(data); + if (RegQueryValueExA( key, "ShowCrashDialog", NULL, &type, (BYTE *)&data, &size )) ret = 1; + else if (type != REG_DWORD || data) ret = 2; + data = 0; + RegSetValueExA( key, "ShowCrashDialog", 0, REG_DWORD, (BYTE *)&data, sizeof(data) ); + RegCloseKey( key ); + return ret; +} + +static void restore_crash_dialog( int prev ) +{ + HKEY key; + DWORD data = 1; + + if (!prev) return; + if (RegOpenKeyA( HKEY_CURRENT_USER, "Software\\Wine\\WineDbg", &key )) return; + if (prev == 1) RegDeleteKeyValueA( key, NULL, "ShowCrashDialog" ); + else RegSetValueExA( key, "ShowCrashDialog", 0, REG_DWORD, (BYTE *)&data, sizeof(data) ); + RegCloseKey( key ); +} + static void print_version (void) { #ifdef __i386__ @@ -1286,6 +1314,7 @@ int __cdecl main( int argc, char *argv[] ) int reset_env = 1; int poweroff = 0; int interactive = 1; + int prev_crash_dialog = 0; int i; InitCommonControls(); @@ -1430,6 +1459,8 @@ int __cdecl main( int argc, char *argv[] ) if (!check_display_driver()) report (R_FATAL, "Unable to create a window, the display driver is not working."); + + if (!interactive) prev_crash_dialog = disable_crash_dialog(); } SetConsoleCtrlHandler(ctrl_handler, TRUE); @@ -1485,6 +1516,7 @@ int __cdecl main( int argc, char *argv[] ) report (R_WARNING, "Can't remove logfile: %u", GetLastError()); } else run_tests (logname, outdir); report (R_STATUS, "Finished - %u failures", failures); + if (prev_crash_dialog) restore_crash_dialog( prev_crash_dialog ); } if (poweroff) {

1 0

Alexandre Julliard : winetest: Support loading the list of tests from a file.
by Alexandre Julliard 16 Aug '22

16 Aug '22

Module: wine Branch: master Commit: 6ae99e4da0a396297f934b9a969d6549f344c4a9 URL: https://gitlab.winehq.org/wine/wine/-/commit/6ae99e4da0a396297f934b9a969d65… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Aug 16 12:14:21 2022 +0200 winetest: Support loading the list of tests from a file. --- programs/winetest/main.c | 42 ++++++++++++++++++++++++++++++++++-------- 1 file changed, 34 insertions(+), 8 deletions(-) diff --git a/programs/winetest/main.c b/programs/winetest/main.c index 92bfacaa2c5..13a5c5ab294 100644 --- a/programs/winetest/main.c +++ b/programs/winetest/main.c @@ -66,8 +66,9 @@ static BOOL is_wow64; static int failures; /* filters for running only specific tests */ -static char *filters[64]; -static unsigned int nb_filters = 0; +static char **filters; +static unsigned int nb_filters; +static unsigned int alloc_filters; static BOOL exclude_tests = FALSE; /* Needed to check for .NET dlls */ @@ -109,6 +110,36 @@ static BOOL test_filtered_out( LPCSTR module, LPCSTR testname ) return !exclude_tests; } +static void add_filter( const char *name ) +{ + if (name[0] == '@') + { + char *p, *str, buffer[256]; + FILE *f = fopen( name + 1, "rt" ); + if (!f) return; + + while (fgets( buffer, sizeof(buffer), f )) + { + p = buffer; + while (*p == ' ' || *p == '\t') p++; + if (*p == '#') continue; + str = p; + while (*p && *p != ' ' && *p != '\t' && *p != '\r' && *p != '\n') p++; + *p = 0; + add_filter( str ); + } + fclose( f ); + return; + } + + if (nb_filters >= alloc_filters) + { + alloc_filters = max( alloc_filters * 2, 64 ); + filters = xrealloc( filters, alloc_filters * sizeof(*filters) ); + } + filters[nb_filters++] = xstrdup(name); +} + static char * get_file_version(char * file_name) { static char version[32]; @@ -1275,12 +1306,7 @@ int __cdecl main( int argc, char *argv[] ) exit (0); } else if ((argv[i][0] != '-' && argv[i][0] != '/') || argv[i][2]) { - if (nb_filters == ARRAY_SIZE(filters)) - { - report (R_ERROR, "Too many test filters specified"); - exit (2); - } - filters[nb_filters++] = argv[i]; + add_filter( argv[i] ); } else switch (argv[i][1]) { case 'c':

1 0

Alexandre Julliard : winetest: Use CRT allocation functions.
by Alexandre Julliard 16 Aug '22

16 Aug '22

Module: wine Branch: master Commit: 22aceb44e738c51e169fffc669223da5952d8072 URL: https://gitlab.winehq.org/wine/wine/-/commit/22aceb44e738c51e169fffc669223d… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Aug 16 11:57:39 2022 +0200 winetest: Use CRT allocation functions. --- programs/winetest/gui.c | 32 +++++++-------- programs/winetest/main.c | 93 ++++++++++++++++++-------------------------- programs/winetest/send.c | 45 +++++++++++---------- programs/winetest/util.c | 34 +++++----------- programs/winetest/winetest.h | 7 ++-- 5 files changed, 88 insertions(+), 123 deletions(-)

1 0

Jacek Caban : user32: Always use original parameter values in dispatch_send_message.
by Alexandre Julliard 15 Aug '22

15 Aug '22

Module: wine Branch: master Commit: b4a5556da983c7ebc8a25b228100c08947024c59 URL: https://gitlab.winehq.org/wine/wine/-/commit/b4a5556da983c7ebc8a25b228100c0… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Aug 5 17:26:37 2022 +0200 user32: Always use original parameter values in dispatch_send_message. --- dlls/user32/message.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/dlls/user32/message.c b/dlls/user32/message.c index f6431e0c28a..7be93d94e39 100644 --- a/dlls/user32/message.c +++ b/dlls/user32/message.c @@ -588,7 +588,7 @@ LRESULT WINAPI SendMessageTimeoutA( HWND hwnd, UINT msg, WPARAM wparam, LPARAM l } -static LRESULT dispatch_send_message( struct win_proc_params *params ) +static LRESULT dispatch_send_message( struct win_proc_params *params, WPARAM wparam, LPARAM lparam ) { struct ntuser_thread_info *thread_info = NtUserGetThreadInfo(); INPUT_MESSAGE_SOURCE prev_source = thread_info->msg_source; @@ -596,6 +596,10 @@ static LRESULT dispatch_send_message( struct win_proc_params *params ) static const INPUT_MESSAGE_SOURCE msg_source_unavailable = { IMDT_UNAVAILABLE, IMO_UNAVAILABLE }; + /* params may contain arguments modified by wow, use original parameters instead */ + params->wparam = wparam; + params->lparam = lparam; + thread_info->recursion_count++; params->result = &retval; @@ -621,7 +625,7 @@ LRESULT WINAPI SendMessageW( HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam ) params.hwnd = 0; retval = NtUserMessageCall( hwnd, msg, wparam, lparam, &params, NtUserSendMessage, FALSE ); - if (params.hwnd) retval = dispatch_send_message( &params ); + if (params.hwnd) retval = dispatch_send_message( &params, wparam, lparam ); return retval; } @@ -643,7 +647,7 @@ LRESULT WINAPI SendMessageA( HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam ) params.hwnd = 0; retval = NtUserMessageCall( hwnd, msg, wparam, lparam, &params, NtUserSendMessage, TRUE ); - if (params.hwnd) retval = dispatch_send_message( &params ); + if (params.hwnd) retval = dispatch_send_message( &params, wparam, lparam ); return retval; }

1 0

Jacek Caban : wow64win: Implement wow64_NtUserMessageCall.
by Alexandre Julliard 15 Aug '22

15 Aug '22

Module: wine Branch: master Commit: cdcd773efe0e3669570d71d814f265a55835a772 URL: https://gitlab.winehq.org/wine/wine/-/commit/cdcd773efe0e3669570d71d814f265… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Aug 15 01:07:13 2022 +0200 wow64win: Implement wow64_NtUserMessageCall. --- dlls/wow64win/user.c | 427 ++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 423 insertions(+), 4 deletions(-)

1 0

Jacek Caban : wow64win: Implement wow64_NtUserCallWinProc.
by Alexandre Julliard 15 Aug '22

15 Aug '22

Module: wine Branch: master Commit: 9f63cbc052e72bbe16398cf45c8a1a43dc27ed4f URL: https://gitlab.winehq.org/wine/wine/-/commit/9f63cbc052e72bbe16398cf45c8a1a… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Aug 15 00:11:49 2022 +0200 wow64win: Implement wow64_NtUserCallWinProc. --- dlls/user32/winproc.c | 16 +++++++++---- dlls/win32u/message.c | 1 + dlls/wow64win/user.c | 65 +++++++++++++++++++++++++++++++++++++++++++++++++-- 3 files changed, 76 insertions(+), 6 deletions(-) diff --git a/dlls/user32/winproc.c b/dlls/user32/winproc.c index ab28eecb67c..a22262b037b 100644 --- a/dlls/user32/winproc.c +++ b/dlls/user32/winproc.c @@ -1176,12 +1176,13 @@ static BOOL unpack_message( HWND hwnd, UINT message, WPARAM *wparam, LPARAM *lpa BOOL WINAPI User32CallWindowProc( struct win_proc_params *params, ULONG size ) { + LRESULT result, *result_ptr = params->result; + params->result = &result; if (params->needs_unpack) { char stack_buffer[128]; void *buffer; - LRESULT result; if (size > sizeof(*params)) { @@ -1196,8 +1197,6 @@ BOOL WINAPI User32CallWindowProc( struct win_proc_params *params, ULONG size ) if (!unpack_message( params->hwnd, params->msg, &params->wparam, &params->lparam, &buffer, size )) return 0; - params->result = &result; - dispatch_win_proc_params( params ); @@ -1206,7 +1205,16 @@ BOOL WINAPI User32CallWindowProc( struct win_proc_params *params, ULONG size ) if (buffer != stack_buffer && buffer != params + 1) HeapFree( GetProcessHeap(), 0, buffer ); } - else dispatch_win_proc_params( params ); + else + { + dispatch_win_proc_params( params ); + if (result_ptr) + { + *result_ptr = result; + return TRUE; + } + NtCallbackReturn( &result, sizeof(result), TRUE ); + } return TRUE; } diff --git a/dlls/win32u/message.c b/dlls/win32u/message.c index a19b6bab230..bc932c5c820 100644 --- a/dlls/win32u/message.c +++ b/dlls/win32u/message.c @@ -265,6 +265,7 @@ static BOOL dispatch_win_proc_params( struct win_proc_params *params, size_t siz thread_info->recursion_count++; KeUserModeCallback( NtUserCallWinProc, params, size, &ret_ptr, &ret_len ); + if (ret_len == sizeof(*params->result)) *params->result = *(LRESULT *)ret_ptr; thread_info->recursion_count--; return TRUE; diff --git a/dlls/wow64win/user.c b/dlls/wow64win/user.c index 6aecdacda39..ef817025dda 100644 --- a/dlls/wow64win/user.c +++ b/dlls/wow64win/user.c @@ -152,6 +152,23 @@ struct client_menu_name32 ULONG nameUS; }; +struct win_proc_params32 +{ + ULONG func; + ULONG hwnd; + UINT msg; + ULONG wparam; + ULONG lparam; + ULONG result; + BOOL ansi; + BOOL ansi_dst; + BOOL needs_unpack; + enum wm_char_mapping mapping; + ULONG dpi_awareness; + ULONG procA; + ULONG procW; +}; + static MSG *msg_32to64( MSG *msg, const MSG32 *msg32 ) { if (!msg32) return NULL; @@ -200,6 +217,24 @@ static struct client_menu_name32 *client_menu_name_64to32( const struct client_m return name32; } +static void win_proc_params_64to32( const struct win_proc_params *src, struct win_proc_params32 *dst, + ULONG *result ) +{ + dst->func = PtrToUlong( src->func ); + dst->hwnd = HandleToUlong( src->hwnd ); + dst->msg = src->msg; + dst->wparam = src->wparam; + dst->lparam = src->lparam; + dst->result = PtrToUlong( result ); + dst->ansi = src->ansi; + dst->ansi_dst = src->ansi_dst; + dst->needs_unpack = src->needs_unpack; + dst->mapping = src->mapping; + dst->dpi_awareness = HandleToUlong( src->dpi_awareness ); + dst->procA = PtrToUlong( src->procA ); + dst->procW = PtrToUlong( src->procW ); +} + static NTSTATUS dispatch_callback( ULONG id, void *args, ULONG len ) { void *ret_ptr; @@ -256,8 +291,34 @@ static NTSTATUS WINAPI wow64_NtUserCallWinEventHook( void *arg, ULONG size ) static NTSTATUS WINAPI wow64_NtUserCallWinProc( void *arg, ULONG size ) { - FIXME( "\n" ); - return 0; + struct win_proc_params *params = arg; + struct win_proc_params32 params32_buf, *params32 = &params32_buf; + LONG result32 = 0; + LRESULT result; + void *ret_ptr; + ULONG ret_len; + NTSTATUS status; + + if (size > sizeof(*params)) + { + if (!(params32 = Wow64AllocateTemp( size - sizeof(*params) + sizeof(*params32) ))) + return 0; + memcpy( params32 + 1, params + 1, size - sizeof(*params) ); + } + win_proc_params_64to32( params, params32, NULL ); + + status = Wow64KiUserCallbackDispatcher( NtUserCallWinProc, params32, + size - sizeof(*params) + sizeof(*params32), + &ret_ptr, &ret_len ); + if (ret_len == sizeof(result32)) result32 = *(LONG *)ret_ptr; + result = result32; + + if (params->result) + { + *params->result = result; + return status; + } + return NtCallbackReturn( &result, sizeof(result), status ); } static NTSTATUS WINAPI wow64_NtUserCallWindowsHook( void *arg, ULONG size )

1 0

Jacek Caban : win32u: Remove no longer needed unicode call_hooks argument.
by Alexandre Julliard 15 Aug '22

15 Aug '22

Module: wine Branch: master Commit: 85012b910227dcd9394acce1d4f12d6253f643b3 URL: https://gitlab.winehq.org/wine/wine/-/commit/85012b910227dcd9394acce1d4f12d… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Aug 15 01:42:43 2022 +0200 win32u: Remove no longer needed unicode call_hooks argument. --- dlls/win32u/defwnd.c | 6 +++--- dlls/win32u/hook.c | 8 ++++---- dlls/win32u/input.c | 6 +++--- dlls/win32u/message.c | 24 ++++++++++++------------ dlls/win32u/win32u_private.h | 2 +- dlls/win32u/window.c | 10 +++++----- 6 files changed, 28 insertions(+), 28 deletions(-)

1 0

Jacek Caban : win32u: Use send_message_timeout for WM_CREATE and WM_NCCREATE.
by Alexandre Julliard 15 Aug '22

15 Aug '22

Module: wine Branch: master Commit: e41c255be6ba66d1eec7affe674b8cc7699226b8 URL: https://gitlab.winehq.org/wine/wine/-/commit/e41c255be6ba66d1eec7affe674b8c… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Sun Aug 14 23:41:53 2022 +0200 win32u: Use send_message_timeout for WM_CREATE and WM_NCCREATE. --- dlls/user32/win.c | 4 +--- dlls/win32u/window.c | 38 +++++++++++--------------------------- 2 files changed, 12 insertions(+), 30 deletions(-) diff --git a/dlls/user32/win.c b/dlls/user32/win.c index 77bd2bfa3fe..d0a34841ce0 100644 --- a/dlls/user32/win.c +++ b/dlls/user32/win.c @@ -303,7 +303,6 @@ HWND WIN_CreateWindowEx( CREATESTRUCTW *cs, LPCWSTR className, HINSTANCE module, UNICODE_STRING class, window_name; HWND hwnd, top_child = 0; MDICREATESTRUCTW mdi_cs; - CBT_CREATEWNDW cbtc; WNDCLASSEXW info; HMENU menu; @@ -408,10 +407,9 @@ HWND WIN_CreateWindowEx( CREATESTRUCTW *cs, LPCWSTR className, HINSTANCE module, if (!menu && info.lpszMenuName && (cs->style & (WS_CHILD | WS_POPUP)) != WS_CHILD) menu = LoadMenuW( cs->hInstance, info.lpszMenuName ); - cbtc.lpcs = cs; hwnd = NtUserCreateWindowEx( cs->dwExStyle, &class, NULL, &window_name, cs->style, cs->x, cs->y, cs->cx, cs->cy, cs->hwndParent, menu, module, - cs->lpCreateParams, 0, &cbtc, 0, !unicode ); + cs->lpCreateParams, 0, NULL, 0, !unicode ); if (!hwnd && menu && menu != cs->hMenu) NtUserDestroyMenu( menu ); if (!unicode) RtlFreeUnicodeString( &window_name ); return hwnd; diff --git a/dlls/win32u/window.c b/dlls/win32u/window.c index 6e41bc8d27f..0eac0a6320b 100644 --- a/dlls/win32u/window.c +++ b/dlls/win32u/window.c @@ -5050,41 +5050,27 @@ HWND WINAPI NtUserCreateWindowEx( DWORD ex_style, UNICODE_STRING *class_name, UNICODE_STRING *version, UNICODE_STRING *window_name, DWORD style, INT x, INT y, INT cx, INT cy, HWND parent, HMENU menu, HINSTANCE instance, void *params, - DWORD flags, CBT_CREATEWNDW *cbtc, DWORD unk, BOOL ansi ) + DWORD flags, CBT_CREATEWNDW *client_cbtc, DWORD unk, BOOL ansi ) { - CREATESTRUCTW cs, *client_cs, cs_buf; UINT win_dpi, thread_dpi = get_thread_dpi(); DPI_AWARENESS_CONTEXT context; - CBT_CREATEWNDW cbtc_buf; + CBT_CREATEWNDW cbtc; HWND hwnd, owner = 0; + CREATESTRUCTW cs; INT sw = SW_SHOW; RECT rect; WND *win; static const WCHAR messageW[] = {'M','e','s','s','a','g','e'}; - /* FIXME: We should pass a packed struct to client instead of using client_cs */ - if (cbtc) - { - client_cs = cbtc->lpcs; - cs.lpszName = client_cs->lpszName; - cs.lpszClass = client_cs->lpszClass; - cs.hInstance = client_cs->hInstance; /* may be different than instance for win16 */ - } - else - { - cbtc = &cbtc_buf; - client_cs = cbtc->lpcs = &cs_buf; - cs.lpszName = window_name ? window_name->Buffer : NULL; - cs.lpszClass = class_name->Buffer; - cs.hInstance = instance; - } - cs.lpCreateParams = params; + cs.hInstance = instance; cs.hMenu = menu; cs.hwndParent = parent; cs.style = style; cs.dwExStyle = ex_style; + cs.lpszName = window_name ? window_name->Buffer : NULL; + cs.lpszClass = class_name ? class_name->Buffer : NULL; cs.x = x; cs.y = y; cs.cx = cx; @@ -5166,9 +5152,9 @@ HWND WINAPI NtUserCreateWindowEx( DWORD ex_style, UNICODE_STRING *class_name, /* call the WH_CBT hook */ release_win_ptr( win ); - *client_cs = cs; - cbtc->hwndInsertAfter = HWND_TOP; - if (call_hooks( WH_CBT, HCBT_CREATEWND, (WPARAM)hwnd, (LPARAM)cbtc, !ansi )) + cbtc.hwndInsertAfter = HWND_TOP; + cbtc.lpcs = &cs; + if (call_hooks( WH_CBT, HCBT_CREATEWND, (WPARAM)hwnd, (LPARAM)&cbtc, TRUE )) { free_window_handle( hwnd ); return 0; @@ -5250,8 +5236,7 @@ HWND WINAPI NtUserCreateWindowEx( DWORD ex_style, UNICODE_STRING *class_name, /* send WM_NCCREATE */ TRACE( "hwnd %p cs %d,%d %dx%d %s\n", hwnd, cs.x, cs.y, cs.cx, cs.cy, wine_dbgstr_rect(&rect) ); - *client_cs = cs; - if (!NtUserMessageCall( hwnd, WM_NCCREATE, 0, (LPARAM)client_cs, NULL, NtUserSendMessage, ansi )) + if (!send_message_timeout( hwnd, WM_NCCREATE, 0, (LPARAM)&cs, SMTO_NORMAL, 0, ansi )) { WARN( "%p: aborted by WM_NCCREATE\n", hwnd ); goto failed; @@ -5283,9 +5268,8 @@ HWND WINAPI NtUserCreateWindowEx( DWORD ex_style, UNICODE_STRING *class_name, else goto failed; /* send WM_CREATE */ - if (NtUserMessageCall( hwnd, WM_CREATE, 0, (LPARAM)client_cs, 0, NtUserSendMessage, ansi ) == -1) + if (send_message_timeout( hwnd, WM_CREATE, 0, (LPARAM)&cs, SMTO_NORMAL, 0, ansi ) == -1) goto failed; - cs = *client_cs; /* call the driver */

1 0

Jacek Caban : user32: Pass window name as UNICODE_STRING to NtUserCreateWindowEx.
by Alexandre Julliard 15 Aug '22

15 Aug '22

Module: wine Branch: master Commit: 0d0f2067f89545539ab3ae0ccd802239a2dce98e URL: https://gitlab.winehq.org/wine/wine/-/commit/0d0f2067f89545539ab3ae0ccd8022… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Sun Aug 14 23:24:04 2022 +0200 user32: Pass window name as UNICODE_STRING to NtUserCreateWindowEx. --- dlls/user32/win.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/dlls/user32/win.c b/dlls/user32/win.c index e246d112383..77bd2bfa3fe 100644 --- a/dlls/user32/win.c +++ b/dlls/user32/win.c @@ -300,9 +300,9 @@ static BOOL is_default_coord( int x ) */ HWND WIN_CreateWindowEx( CREATESTRUCTW *cs, LPCWSTR className, HINSTANCE module, BOOL unicode ) { + UNICODE_STRING class, window_name; HWND hwnd, top_child = 0; MDICREATESTRUCTW mdi_cs; - UNICODE_STRING class; CBT_CREATEWNDW cbtc; WNDCLASSEXW info; HMENU menu; @@ -399,15 +399,21 @@ HWND WIN_CreateWindowEx( CREATESTRUCTW *cs, LPCWSTR className, HINSTANCE module, } } + if (unicode || !cs->lpszName) + RtlInitUnicodeString( &window_name, cs->lpszName ); + else if (!RtlCreateUnicodeStringFromAsciiz( &window_name, (const char *)cs->lpszName )) + return 0; + menu = cs->hMenu; if (!menu && info.lpszMenuName && (cs->style & (WS_CHILD | WS_POPUP)) != WS_CHILD) menu = LoadMenuW( cs->hInstance, info.lpszMenuName ); cbtc.lpcs = cs; - hwnd = NtUserCreateWindowEx( cs->dwExStyle, &class, NULL, NULL, cs->style, cs->x, cs->y, - cs->cx, cs->cy, cs->hwndParent, menu, module, + hwnd = NtUserCreateWindowEx( cs->dwExStyle, &class, NULL, &window_name, cs->style, + cs->x, cs->y, cs->cx, cs->cy, cs->hwndParent, menu, module, cs->lpCreateParams, 0, &cbtc, 0, !unicode ); if (!hwnd && menu && menu != cs->hMenu) NtUserDestroyMenu( menu ); + if (!unicode) RtlFreeUnicodeString( &window_name ); return hwnd; }

1 0

Jacek Caban : win32u: Pack messages sent directly from win32u.
by Alexandre Julliard 15 Aug '22

15 Aug '22

Module: wine Branch: master Commit: 0ad2db66a109b4c0a46d04ff8231706fff540941 URL: https://gitlab.winehq.org/wine/wine/-/commit/0ad2db66a109b4c0a46d04ff823170… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Sun Aug 14 20:49:53 2022 +0200 win32u: Pack messages sent directly from win32u. Instead of leaking kernel pointers. --- dlls/win32u/message.c | 216 +++++++++++++++++++++++++++++++++++++++++-- dlls/win32u/ntuser_private.h | 9 -- 2 files changed, 208 insertions(+), 17 deletions(-)

1 0

← Newer
1
...
28
29
30
31
32
33
34
...
60
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits August 2022