wine-commits February 2024

wine-commits@winehq.org

1 participants
716 discussions

Conor McCarthy : vkd3d: Return DXGI_ERROR_NOT_FOUND from GetProtectedResourceSession().
by Alexandre Julliard 15 Feb '24

15 Feb '24

Module: vkd3d Branch: master Commit: 46682718721d815bb3d699c049007429bb422f2e URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/46682718721d815bb3d699c049007… Author: Conor McCarthy <cmccarthy(a)codeweavers.com> Date: Mon Feb 5 13:55:07 2024 +1000 vkd3d: Return DXGI_ERROR_NOT_FOUND from GetProtectedResourceSession(). --- libs/vkd3d/resource.c | 2 +- tests/d3d12.c | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/libs/vkd3d/resource.c b/libs/vkd3d/resource.c index 8f4d1835..c37ab5f4 100644 --- a/libs/vkd3d/resource.c +++ b/libs/vkd3d/resource.c @@ -1725,7 +1725,7 @@ static HRESULT STDMETHODCALLTYPE d3d12_resource_GetProtectedResourceSession(ID3D { FIXME("iface %p, iid %s, session %p stub!\n", iface, debugstr_guid(iid), session); - return E_NOTIMPL; + return DXGI_ERROR_NOT_FOUND; } static const struct ID3D12Resource1Vtbl d3d12_resource_vtbl = diff --git a/tests/d3d12.c b/tests/d3d12.c index 33efa0f2..ac40c641 100644 --- a/tests/d3d12.c +++ b/tests/d3d12.c @@ -1893,7 +1893,6 @@ static void test_create_committed_resource(void) hr = ID3D12Resource1_GetProtectedResourceSession(resource1, &IID_ID3D12ProtectedResourceSession, (void **)&protected_session); - todo ok(hr == DXGI_ERROR_NOT_FOUND, "Got unexpected hr %#x.\n", hr); ID3D12Resource1_Release(resource1); @@ -2241,7 +2240,6 @@ static void test_create_placed_resource(void) { hr = ID3D12Resource1_GetProtectedResourceSession(resource1, &IID_ID3D12ProtectedResourceSession, (void **)&protected_session); - todo ok(hr == DXGI_ERROR_NOT_FOUND, "Got unexpected hr %#x.\n", hr); ID3D12Resource1_Release(resource1); }

1 0

Conor McCarthy : tests/d3d12: Add tests for GetProtectedResourceSession().
by Alexandre Julliard 15 Feb '24

15 Feb '24

Module: vkd3d Branch: master Commit: e38f3995fdea7e1b0f20a6a715f6d4fe11163b68 URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/e38f3995fdea7e1b0f20a6a715f6d… Author: Conor McCarthy <cmccarthy(a)codeweavers.com> Date: Mon Feb 5 13:53:49 2024 +1000 tests/d3d12: Add tests for GetProtectedResourceSession(). --- tests/d3d12.c | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/tests/d3d12.c b/tests/d3d12.c index 51ee7877..33efa0f2 100644 --- a/tests/d3d12.c +++ b/tests/d3d12.c @@ -1545,12 +1545,14 @@ static void test_create_command_signature(void) static void test_create_committed_resource(void) { + ID3D12ProtectedResourceSession *protected_session; D3D12_GPU_VIRTUAL_ADDRESS gpu_address; D3D12_HEAP_PROPERTIES heap_properties; D3D12_RESOURCE_DESC resource_desc; ID3D12Device *device, *tmp_device; D3D12_CLEAR_VALUE clear_value; D3D12_RESOURCE_STATES state; + ID3D12Resource1 *resource1; ID3D12Resource *resource; ID3D12Device4 *device4; unsigned int i; @@ -1884,10 +1886,17 @@ static void test_create_committed_resource(void) hr = ID3D12Device4_CreateCommittedResource1(device4, &heap_properties, D3D12_HEAP_FLAG_NONE, &resource_desc, D3D12_RESOURCE_STATE_RENDER_TARGET, &clear_value, NULL, - &IID_ID3D12Resource, (void **)&resource); + &IID_ID3D12Resource1, (void **)&resource1); ok(hr == S_OK, "Failed to create committed resource, hr %#x.\n", hr); - ID3D12Resource_Release(resource); + check_interface(resource1, &IID_ID3D12Resource1, true); + + hr = ID3D12Resource1_GetProtectedResourceSession(resource1, &IID_ID3D12ProtectedResourceSession, + (void **)&protected_session); + todo + ok(hr == DXGI_ERROR_NOT_FOUND, "Got unexpected hr %#x.\n", hr); + + ID3D12Resource1_Release(resource1); ID3D12Device4_Release(device4); } @@ -2140,12 +2149,14 @@ done: static void test_create_placed_resource(void) { + ID3D12ProtectedResourceSession *protected_session; D3D12_GPU_VIRTUAL_ADDRESS gpu_address; ID3D12Resource *resource, *resource2; D3D12_RESOURCE_DESC resource_desc; ID3D12Device *device, *tmp_device; D3D12_CLEAR_VALUE clear_value; D3D12_RESOURCE_STATES state; + ID3D12Resource1 *resource1; D3D12_HEAP_DESC heap_desc; ID3D12Heap *heap; unsigned int i; @@ -2226,6 +2237,15 @@ static void test_create_placed_resource(void) gpu_address = ID3D12Resource_GetGPUVirtualAddress(resource); ok(gpu_address, "Got unexpected GPU virtual address %#"PRIx64".\n", gpu_address); + if (SUCCEEDED(ID3D12Resource_QueryInterface(resource, &IID_ID3D12Resource1, (void **)&resource1))) + { + hr = ID3D12Resource1_GetProtectedResourceSession(resource1, &IID_ID3D12ProtectedResourceSession, + (void **)&protected_session); + todo + ok(hr == DXGI_ERROR_NOT_FOUND, "Got unexpected hr %#x.\n", hr); + ID3D12Resource1_Release(resource1); + } + refcount = ID3D12Resource_Release(resource); ok(!refcount, "ID3D12Resource has %u references left.\n", (unsigned int)refcount);

1 0

Eric Pouech : winedump: Don't crash on non-effective runtime function entries.
by Alexandre Julliard 15 Feb '24

15 Feb '24

Module: wine Branch: master Commit: 9119e3102b2477a93ab97ec900ec35495b5c9a7a URL: https://gitlab.winehq.org/wine/wine/-/commit/9119e3102b2477a93ab97ec900ec35… Author: Eric Pouech <epouech(a)codeweavers.com> Date: Tue Feb 13 08:58:37 2024 +0100 winedump: Don't crash on non-effective runtime function entries. MSVC generates zeroed out entries when EditAndContinue (aka HotPatch) is enabled. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> --- tools/winedump/pe.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/winedump/pe.c b/tools/winedump/pe.c index 1879dd0ce2a..1104072a2c2 100644 --- a/tools/winedump/pe.c +++ b/tools/winedump/pe.c @@ -863,6 +863,11 @@ static void dump_x86_64_unwind_info( const struct runtime_function_x86_64 *funct } info = RVA( function->UnwindData, sizeof(*info) ); + if (!info) + { + printf( " no unwind info (%x)\n", function->UnwindData ); + return; + } printf( " unwind info at %08x\n", function->UnwindData ); if (info->version > 2) {

1 0

Gabriel Ivăncescu : explorer: Set layered style on systray icons before calling into the driver.
by Alexandre Julliard 15 Feb '24

15 Feb '24

Module: wine Branch: master Commit: 8a71a4a30495635bdc905af41869d8ed9e43009f URL: https://gitlab.winehq.org/wine/wine/-/commit/8a71a4a30495635bdc905af41869d8… Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Thu Feb 15 17:41:43 2024 +0200 explorer: Set layered style on systray icons before calling into the driver. Fixes a regression introduced by b5c57b9a62c396068d18237bd6e82b37c169fdc5, which broke the systray integration outside of virtual desktops on some DEs like XFCE. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- programs/explorer/systray.c | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/programs/explorer/systray.c b/programs/explorer/systray.c index c76ebdd0c92..275c683e3ff 100644 --- a/programs/explorer/systray.c +++ b/programs/explorer/systray.c @@ -619,13 +619,23 @@ static BOOL show_icon(struct icon *icon) if (icon->display != ICON_DISPLAY_HIDDEN) return TRUE; /* already displayed */ - if (!enable_taskbar && NtUserMessageCall( icon->window, WINE_SYSTRAY_DOCK_INSERT, icon_cx, icon_cy, - icon, NtUserSystemTrayCall, FALSE )) + if (!enable_taskbar) { - icon->display = ICON_DISPLAY_DOCKED; - icon->layered = TRUE; - SetWindowLongW( icon->window, GWL_EXSTYLE, GetWindowLongW( icon->window, GWL_EXSTYLE ) | WS_EX_LAYERED ); - SendMessageW( icon->window, WM_SIZE, SIZE_RESTORED, MAKELONG( icon_cx, icon_cy ) ); + DWORD old_exstyle = GetWindowLongW( icon->window, GWL_EXSTYLE ); + + /* make sure it is layered before calling into the driver */ + SetWindowLongW( icon->window, GWL_EXSTYLE, old_exstyle | WS_EX_LAYERED ); + paint_layered_icon( icon ); + + if (!NtUserMessageCall( icon->window, WINE_SYSTRAY_DOCK_INSERT, icon_cx, icon_cy, + icon, NtUserSystemTrayCall, FALSE )) + SetWindowLongW( icon->window, GWL_EXSTYLE, old_exstyle ); + else + { + icon->display = ICON_DISPLAY_DOCKED; + icon->layered = TRUE; + SendMessageW( icon->window, WM_SIZE, SIZE_RESTORED, MAKELONG( icon_cx, icon_cy ) ); + } } systray_add_icon( icon );

1 0

Krzysztof Bogacki : win32u: Implement NtGdiDdDDIEnumAdapters2.
by Alexandre Julliard 15 Feb '24

15 Feb '24

Module: wine Branch: master Commit: 223292da029ed1a807a00a46c5fc4cc1e7c2cc72 URL: https://gitlab.winehq.org/wine/wine/-/commit/223292da029ed1a807a00a46c5fc4c… Author: Krzysztof Bogacki <krzysztof.bogacki(a)leancode.pl> Date: Mon Jan 15 19:16:23 2024 +0100 win32u: Implement NtGdiDdDDIEnumAdapters2. Signed-off-by: Krzysztof Bogacki <krzysztof.bogacki(a)leancode.pl> --- dlls/gdi32/tests/driver.c | 2 +- dlls/win32u/sysparams.c | 78 +++++++++++++++++++++++++++++++++++++++++++++-- 2 files changed, 77 insertions(+), 3 deletions(-) diff --git a/dlls/gdi32/tests/driver.c b/dlls/gdi32/tests/driver.c index f42595126c2..3a7944e9c02 100644 --- a/dlls/gdi32/tests/driver.c +++ b/dlls/gdi32/tests/driver.c @@ -199,7 +199,7 @@ static void test_D3DKMTEnumAdapters2(void) if (!pD3DKMTEnumAdapters2 || pD3DKMTEnumAdapters2(&enum_adapters_2_desc) == STATUS_PROCEDURE_NOT_FOUND) { - skip("D3DKMTEnumAdapters2() is unavailable.\n"); + win_skip("D3DKMTEnumAdapters2() is unavailable.\n"); return; } diff --git a/dlls/win32u/sysparams.c b/dlls/win32u/sysparams.c index bb31ddc23b5..1573edf069f 100644 --- a/dlls/win32u/sysparams.c +++ b/dlls/win32u/sysparams.c @@ -6656,6 +6656,80 @@ NTSTATUS WINAPI NtUserDisplayConfigGetDeviceInfo( DISPLAYCONFIG_DEVICE_INFO_HEAD */ NTSTATUS WINAPI NtGdiDdDDIEnumAdapters2( D3DKMT_ENUMADAPTERS2 *desc ) { - FIXME(" (%p): stub\n", desc ); - return STATUS_PROCEDURE_NOT_FOUND; + D3DKMT_OPENADAPTERFROMLUID open_adapter_from_luid; + static const ULONG max_adapters = 34; + D3DKMT_CLOSEADAPTER close_adapter; + NTSTATUS status = STATUS_SUCCESS; + ULONG idx = 0, count; + struct gpu *gpu; + + TRACE( "(%p)\n", desc ); + + if (!desc) return STATUS_INVALID_PARAMETER; + + if (!desc->pAdapters) + { + desc->NumAdapters = max_adapters; + return STATUS_SUCCESS; + } + + if (!lock_display_devices()) return STATUS_UNSUCCESSFUL; + + if ((count = list_count( &gpus )) > max_adapters) + { + WARN( "Too many adapters (%u), only up to %u can be enumerated.\n", + (unsigned int)count, (unsigned int)max_adapters ); + count = max_adapters; + } + + if (count > desc->NumAdapters) + { + status = STATUS_BUFFER_TOO_SMALL; + goto done; + } + + LIST_FOR_EACH_ENTRY( gpu, &gpus, struct gpu, entry ) + { + if (gpu->luid.LowPart || gpu->luid.HighPart) + { + open_adapter_from_luid.AdapterLuid = gpu->luid; + + /* give the GDI driver a chance to be notified about new adapter handle */ + if (NT_SUCCESS( NtGdiDdDDIOpenAdapterFromLuid( &open_adapter_from_luid ) )) + { + desc->pAdapters[idx].hAdapter = open_adapter_from_luid.hAdapter; + desc->pAdapters[idx].AdapterLuid = gpu->luid; + desc->pAdapters[idx].NumOfSources = gpu->adapter_count; + desc->pAdapters[idx].bPrecisePresentRegionsPreferred = FALSE; + idx += 1; + continue; + } + else + { + ERR( "Failed to open adapter %u from LUID.\n", (unsigned int)idx ); + } + } + else + { + ERR( "Adapter %u does not have a LUID.\n", (unsigned int)idx ); + } + + while (idx--) + { + close_adapter.hAdapter = desc->pAdapters[idx].hAdapter; + NtGdiDdDDICloseAdapter( &close_adapter ); + } + + memset( desc->pAdapters, 0, desc->NumAdapters * sizeof(D3DKMT_ADAPTERINFO) ); + status = STATUS_UNSUCCESSFUL; + break; + } + +done: + if (status == STATUS_SUCCESS) + desc->NumAdapters = idx; + + unlock_display_devices(); + + return status; }

1 0

Krzysztof Bogacki : win32u: Maintain a list of GPUs in cache.
by Alexandre Julliard 15 Feb '24

15 Feb '24

Module: wine Branch: master Commit: 800b5e44fc3106930b424ffa852699e499da1993 URL: https://gitlab.winehq.org/wine/wine/-/commit/800b5e44fc3106930b424ffa852699… Author: Krzysztof Bogacki <krzysztof.bogacki(a)leancode.pl> Date: Sat Jan 27 16:27:27 2024 +0100 win32u: Maintain a list of GPUs in cache. Signed-off-by: Krzysztof Bogacki <krzysztof.bogacki(a)leancode.pl> --- dlls/win32u/sysparams.c | 78 ++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 77 insertions(+), 1 deletion(-) diff --git a/dlls/win32u/sysparams.c b/dlls/win32u/sysparams.c index 710dc6f18c3..bb31ddc23b5 100644 --- a/dlls/win32u/sysparams.c +++ b/dlls/win32u/sysparams.c @@ -233,6 +233,13 @@ struct display_device WCHAR device_key[128]; /* DeviceKey in DISPLAY_DEVICEW */ }; +struct gpu +{ + struct list entry; + LUID luid; + unsigned int adapter_count; +}; + struct adapter { LONG refcount; @@ -275,6 +282,7 @@ struct monitor struct edid_monitor_info edid_info; }; +static struct list gpus = LIST_INIT(gpus); static struct list adapters = LIST_INIT(adapters); static struct list monitors = LIST_INIT(monitors); static INT64 last_query_display_time; @@ -1672,6 +1680,7 @@ static void clear_display_devices(void) { struct adapter *adapter; struct monitor *monitor; + struct gpu *gpu; if (list_head( &monitors ) == &virtual_monitor.entry) { @@ -1693,19 +1702,32 @@ static void clear_display_devices(void) list_remove( &adapter->entry ); adapter_release( adapter ); } + + while (!list_empty( &gpus )) + { + gpu = LIST_ENTRY( list_head( &gpus ), struct gpu, entry ); + list_remove( &gpu->entry ); + free( gpu ); + } } static BOOL update_display_cache_from_registry(void) { + char buffer[1024]; DWORD adapter_id, monitor_id, monitor_count = 0, size; - KEY_BASIC_INFORMATION key; + KEY_VALUE_PARTIAL_INFORMATION *value = (void *)buffer; + KEY_BASIC_INFORMATION key, *key2 = (void *)buffer; + HKEY pci_key, device_key, gpu_key, prop_key; struct adapter *adapter; struct monitor *monitor, *monitor2; HANDLE mutex = NULL; NTSTATUS status; + struct gpu *gpu; BOOL ret; /* If user driver did initialize the registry, then exit */ + if (!enum_key && !(enum_key = reg_open_key( NULL, enum_keyW, sizeof(enum_keyW) ))) + return FALSE; if (!video_key && !(video_key = reg_open_key( NULL, devicemap_video_keyW, sizeof(devicemap_video_keyW) ))) return FALSE; @@ -1761,6 +1783,60 @@ static BOOL update_display_cache_from_registry(void) } } + if ((pci_key = reg_open_key( enum_key, pciW, sizeof(pciW) ))) + { + unsigned int i = 0; + + while (!NtEnumerateKey( pci_key, i++, KeyBasicInformation, key2, sizeof(buffer), &size )) + { + unsigned int j = 0; + + if (!(device_key = reg_open_key( pci_key, key2->Name, key2->NameLength ))) + continue; + + while (!NtEnumerateKey( device_key, j++, KeyBasicInformation, key2, sizeof(buffer), &size )) + { + if (!(gpu_key = reg_open_key( device_key, key2->Name, key2->NameLength ))) + continue; + + size = query_reg_value( gpu_key, class_guidW, value, sizeof(buffer) ); + if (size != sizeof(guid_devclass_displayW) + || wcscmp( (WCHAR *)value->Data, guid_devclass_displayW )) + { + NtClose( gpu_key ); + continue; + } + + if (!(gpu = calloc( 1, sizeof(*gpu) ))) + { + NtClose( gpu_key ); + continue; + } + + if ((prop_key = reg_open_key( gpu_key, devpropkey_gpu_luidW, + sizeof(devpropkey_gpu_luidW) ))) + { + if (query_reg_value( prop_key, NULL, value, sizeof(buffer) ) == sizeof(LUID)) + gpu->luid = *(const LUID *)value->Data; + NtClose( prop_key ); + } + + LIST_FOR_EACH_ENTRY(adapter, &adapters, struct adapter, entry) + { + if (!memcmp( &adapter->gpu_luid, &gpu->luid, sizeof(LUID) )) + gpu->adapter_count++; + } + + list_add_tail( &gpus, &gpu->entry ); + NtClose( gpu_key ); + } + + NtClose( device_key ); + } + + NtClose( pci_key ); + } + if ((ret = !list_empty( &adapters ) && !list_empty( &monitors ))) last_query_display_time = key.LastWriteTime.QuadPart; pthread_mutex_unlock( &display_lock );

1 0

Krzysztof Bogacki : gdi32: Add D3DKMTEnumAdapters2() stub.
by Alexandre Julliard 15 Feb '24

15 Feb '24

Module: wine Branch: master Commit: 10db5b67b83f75423a06852de492ba8e81b0ab98 URL: https://gitlab.winehq.org/wine/wine/-/commit/10db5b67b83f75423a06852de492ba… Author: Krzysztof Bogacki <krzysztof.bogacki(a)leancode.pl> Date: Fri Jan 5 19:45:53 2024 +0100 gdi32: Add D3DKMTEnumAdapters2() stub. Signed-off-by: Krzysztof Bogacki <krzysztof.bogacki(a)leancode.pl> --- dlls/gdi32/gdi32.spec | 1 + dlls/win32u/main.c | 5 + dlls/win32u/sysparams.c | 9 + dlls/win32u/win32syscalls.h | 1466 ++++++++++++++++++++++--------------------- dlls/win32u/win32u.spec | 2 +- dlls/wow64win/gdi.c | 22 + include/ddk/d3dkmthk.h | 1 + include/ntgdi.h | 1 + 8 files changed, 774 insertions(+), 733 deletions(-)

1 0

Krzysztof Bogacki : gdi32/tests: Add D3DKMTEnumAdapters2 tests.
by Alexandre Julliard 15 Feb '24

15 Feb '24

Module: wine Branch: master Commit: 842461979cc8da2155e466cf83b33de574062749 URL: https://gitlab.winehq.org/wine/wine/-/commit/842461979cc8da2155e466cf83b33d… Author: Krzysztof Bogacki <krzysztof.bogacki(a)leancode.pl> Date: Fri Jan 5 19:29:30 2024 +0100 gdi32/tests: Add D3DKMTEnumAdapters2 tests. Signed-off-by: Krzysztof Bogacki <krzysztof.bogacki(a)leancode.pl> --- dlls/gdi32/tests/driver.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+) diff --git a/dlls/gdi32/tests/driver.c b/dlls/gdi32/tests/driver.c index 0c976a87c62..f42595126c2 100644 --- a/dlls/gdi32/tests/driver.c +++ b/dlls/gdi32/tests/driver.c @@ -46,6 +46,7 @@ static NTSTATUS (WINAPI *pD3DKMTCheckVidPnExclusiveOwnership)(const D3DKMT_CHECK static NTSTATUS (WINAPI *pD3DKMTCloseAdapter)(const D3DKMT_CLOSEADAPTER *); static NTSTATUS (WINAPI *pD3DKMTCreateDevice)(D3DKMT_CREATEDEVICE *); static NTSTATUS (WINAPI *pD3DKMTDestroyDevice)(const D3DKMT_DESTROYDEVICE *); +static NTSTATUS (WINAPI *pD3DKMTEnumAdapters2)(D3DKMT_ENUMADAPTERS2 *); static NTSTATUS (WINAPI *pD3DKMTOpenAdapterFromDeviceName)(D3DKMT_OPENADAPTERFROMDEVICENAME *); static NTSTATUS (WINAPI *pD3DKMTOpenAdapterFromGdiDisplayName)(D3DKMT_OPENADAPTERFROMGDIDISPLAYNAME *); static NTSTATUS (WINAPI *pD3DKMTOpenAdapterFromHdc)(D3DKMT_OPENADAPTERFROMHDC *); @@ -189,6 +190,58 @@ static void test_D3DKMTOpenAdapterFromHdc(void) } } +static void test_D3DKMTEnumAdapters2(void) +{ + D3DKMT_ENUMADAPTERS2 enum_adapters_2_desc = {0}; + D3DKMT_CLOSEADAPTER close_adapter_desc; + NTSTATUS status; + UINT i; + + if (!pD3DKMTEnumAdapters2 || pD3DKMTEnumAdapters2(&enum_adapters_2_desc) == STATUS_PROCEDURE_NOT_FOUND) + { + skip("D3DKMTEnumAdapters2() is unavailable.\n"); + return; + } + + /* Invalid parameters */ + status = pD3DKMTEnumAdapters2(NULL); + ok(status == STATUS_INVALID_PARAMETER, "Got unexpected return code %#lx.\n", status); + + /* Query the array to allocate */ + memset(&enum_adapters_2_desc, 0, sizeof(enum_adapters_2_desc)); + status = pD3DKMTEnumAdapters2(&enum_adapters_2_desc); + ok(status == STATUS_SUCCESS, "Got unexpected return code %#lx.\n", status); + ok(enum_adapters_2_desc.NumAdapters == 32 /* win10 and older */ || enum_adapters_2_desc.NumAdapters == 34 /* win11 */, + "Got unexpected value %lu.\n", enum_adapters_2_desc.NumAdapters); + + /* Allocate the array */ + enum_adapters_2_desc.pAdapters = calloc(enum_adapters_2_desc.NumAdapters, sizeof(D3DKMT_ADAPTERINFO)); + ok(!!enum_adapters_2_desc.pAdapters, "Expect not null.\n"); + + /* Enumerate adapters */ + status = pD3DKMTEnumAdapters2(&enum_adapters_2_desc); + ok(status == STATUS_SUCCESS, "Got unexpected return code %#lx.\n", status); + ok(enum_adapters_2_desc.NumAdapters, "Expect not zero.\n"); + + for (i = 0; i < enum_adapters_2_desc.NumAdapters; ++i) + { + ok(enum_adapters_2_desc.pAdapters[i].hAdapter, "Expect not null.\n"); + ok(enum_adapters_2_desc.pAdapters[i].AdapterLuid.LowPart || enum_adapters_2_desc.pAdapters[i].AdapterLuid.HighPart, + "Expect LUID not zero.\n"); + + close_adapter_desc.hAdapter = enum_adapters_2_desc.pAdapters[i].hAdapter; + status = pD3DKMTCloseAdapter(&close_adapter_desc); + ok(status == STATUS_SUCCESS, "Got unexpected return code %#lx.\n", status); + } + + /* Check for insufficient buffer */ + enum_adapters_2_desc.NumAdapters = 0; + status = pD3DKMTEnumAdapters2(&enum_adapters_2_desc); + ok(status == STATUS_BUFFER_TOO_SMALL, "Got unexpected return code %#lx.\n", status); + + free(enum_adapters_2_desc.pAdapters); +} + static void test_D3DKMTCloseAdapter(void) { D3DKMT_CLOSEADAPTER close_adapter_desc; @@ -1077,6 +1130,7 @@ START_TEST(driver) pD3DKMTCloseAdapter = (void *)GetProcAddress(gdi32, "D3DKMTCloseAdapter"); pD3DKMTCreateDevice = (void *)GetProcAddress(gdi32, "D3DKMTCreateDevice"); pD3DKMTDestroyDevice = (void *)GetProcAddress(gdi32, "D3DKMTDestroyDevice"); + pD3DKMTEnumAdapters2 = (void *)GetProcAddress(gdi32, "D3DKMTEnumAdapters2"); pD3DKMTOpenAdapterFromDeviceName = (void *)GetProcAddress(gdi32, "D3DKMTOpenAdapterFromDeviceName"); pD3DKMTOpenAdapterFromGdiDisplayName = (void *)GetProcAddress(gdi32, "D3DKMTOpenAdapterFromGdiDisplayName"); pD3DKMTOpenAdapterFromHdc = (void *)GetProcAddress(gdi32, "D3DKMTOpenAdapterFromHdc"); @@ -1088,6 +1142,7 @@ START_TEST(driver) test_D3DKMTOpenAdapterFromGdiDisplayName(); test_D3DKMTOpenAdapterFromHdc(); + test_D3DKMTEnumAdapters2(); test_D3DKMTCloseAdapter(); test_D3DKMTCreateDevice(); test_D3DKMTDestroyDevice();

1 0

Nikola Kuburović : kernelbase: Reduce FIXME to TRACE if params is null.
by Alexandre Julliard 15 Feb '24

15 Feb '24

Module: wine Branch: master Commit: fddea5da0130e0457fe09028eed1fda7a295bba0 URL: https://gitlab.winehq.org/wine/wine/-/commit/fddea5da0130e0457fe09028eed1fd… Author: Nikola Kuburović <nikola.kuburovic123(a)gmail.com> Date: Thu Feb 15 12:59:26 2024 +0100 kernelbase: Reduce FIXME to TRACE if params is null. If CREATEFILE2_EXTENDED_PARAMS struct pointer is null, we just forward to CreateFileW and we don't need FIXME's. --- dlls/kernelbase/file.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/kernelbase/file.c b/dlls/kernelbase/file.c index cef861492e0..67a7a34249a 100644 --- a/dlls/kernelbase/file.c +++ b/dlls/kernelbase/file.c @@ -687,7 +687,8 @@ HANDLE WINAPI DECLSPEC_HOTPATCH CreateFile2( LPCWSTR name, DWORD access, DWORD s DWORD attributes = params ? params->dwFileAttributes : 0; DWORD flags = params ? params->dwFileFlags : 0; - FIXME( "(%s %lx %lx %lx %p), partial stub\n", debugstr_w(name), access, sharing, creation, params ); + TRACE( "%s %#lx %#lx %#lx %p", debugstr_w(name), access, sharing, creation, params ); + if (params) FIXME( "Ignoring extended parameters %p\n", params ); if (attributes & ~attributes_mask) FIXME( "unsupported attributes %#lx\n", attributes ); if (flags & ~flags_mask) FIXME( "unsupported flags %#lx\n", flags );

1 0

Fabian Maurer : mmdevapi/tests: Add test for invalid format with exclusive mode.
by Alexandre Julliard 15 Feb '24

15 Feb '24

Module: wine Branch: master Commit: 231670e8998202c1d2f1f881e98c4092f76fb2c8 URL: https://gitlab.winehq.org/wine/wine/-/commit/231670e8998202c1d2f1f881e98c40… Author: Fabian Maurer <dark.shadow4(a)web.de> Date: Mon Jun 19 21:04:29 2023 +0200 mmdevapi/tests: Add test for invalid format with exclusive mode. --- dlls/mmdevapi/tests/render.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/dlls/mmdevapi/tests/render.c b/dlls/mmdevapi/tests/render.c index 8e000f03acb..3e24ac45944 100644 --- a/dlls/mmdevapi/tests/render.c +++ b/dlls/mmdevapi/tests/render.c @@ -139,11 +139,23 @@ static void test_audioclient(void) HRESULT hr; ULONG ref; WAVEFORMATEX *pwfx, *pwfx2; + WAVEFORMATEXTENSIBLE format_float_error; REFERENCE_TIME t1, t2; HANDLE handle; BOOL offload_capable; AudioClientProperties client_props; + format_float_error.Format.cbSize = sizeof(WAVEFORMATEXTENSIBLE); + format_float_error.Format.wFormatTag = WAVE_FORMAT_EXTENSIBLE; + format_float_error.Format.nAvgBytesPerSec = 384000; + format_float_error.Format.nBlockAlign = 8; + format_float_error.Format.nChannels = 2; + format_float_error.Format.nSamplesPerSec = 48000; + format_float_error.Format.wBitsPerSample = 32; + format_float_error.Samples.wValidBitsPerSample = 4; + format_float_error.dwChannelMask = 3; + format_float_error.SubFormat = KSDATAFORMAT_SUBTYPE_IEEE_FLOAT; + hr = IMMDevice_Activate(dev, &IID_IAudioClient3, CLSCTX_INPROC_SERVER, NULL, (void**)&ac3); ok(hr == S_OK || @@ -258,6 +270,10 @@ static void test_audioclient(void) "IsFormatSupported(Exclusive) call returns %08lx\n", hr); hexcl = hr; + hr = IAudioClient_IsFormatSupported(ac, AUDCLNT_SHAREMODE_EXCLUSIVE, &format_float_error.Format, NULL); + ok(hr == S_OK || hr == AUDCLNT_E_UNSUPPORTED_FORMAT || hr == AUDCLNT_E_EXCLUSIVE_MODE_NOT_ALLOWED, + "IsFormatSupported(Exclusive) call returns %08lx\n", hr); + pwfx2 = (WAVEFORMATEX*)0xDEADF00D; hr = IAudioClient_IsFormatSupported(ac, AUDCLNT_SHAREMODE_EXCLUSIVE, pwfx, &pwfx2); ok(hr == hexcl, "IsFormatSupported(Exclusive) call returns %08lx\n", hr);

1 0

← Newer
1
...
34
35
36
37
38
39
40
...
72
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits February 2024