wine-commits February 2024

wine-commits@winehq.org

1 participants
716 discussions

Alex Henrie : rpcrt4/tests: Use CRT allocation functions.
by Alexandre Julliard 14 Feb '24

14 Feb '24

Module: wine Branch: master Commit: a38e05636df9596ff3e41301c771fe93523808f1 URL: https://gitlab.winehq.org/wine/wine/-/commit/a38e05636df9596ff3e41301c771fe… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Mon Nov 6 00:10:47 2023 -0700 rpcrt4/tests: Use CRT allocation functions. --- dlls/rpcrt4/tests/cstub.c | 7 +-- dlls/rpcrt4/tests/ndr_marshall.c | 116 +++++++++++++++++++-------------------- dlls/rpcrt4/tests/rpc.c | 4 +- dlls/rpcrt4/tests/server.c | 116 ++++++++++++++++++--------------------- 4 files changed, 116 insertions(+), 127 deletions(-)

1 0

Rastislav Stanik : iphlpapi: Add stub for GetAnycastIpAddressTable().
by Alexandre Julliard 14 Feb '24

14 Feb '24

Module: wine Branch: master Commit: 1bab7ea25e2c1e7bad6940c63c83ec0c1ef5c8f6 URL: https://gitlab.winehq.org/wine/wine/-/commit/1bab7ea25e2c1e7bad6940c63c83ec… Author: Rastislav Stanik <gitlab(a)rastos.org> Date: Thu Jan 25 21:14:20 2024 +0100 iphlpapi: Add stub for GetAnycastIpAddressTable(). This change adds an implementation of Win32 API function GetAnycastIpAddressTable() that does not return real information, it just says "no entries found". Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56065 --- dlls/iphlpapi/iphlpapi.spec | 2 +- dlls/iphlpapi/iphlpapi_main.c | 12 ++++++++++++ include/netioapi.h | 15 +++++++++++++++ 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/dlls/iphlpapi/iphlpapi.spec b/dlls/iphlpapi/iphlpapi.spec index ef2c576947d..dcc15a2753e 100644 --- a/dlls/iphlpapi/iphlpapi.spec +++ b/dlls/iphlpapi/iphlpapi.spec @@ -73,7 +73,7 @@ @ stdcall GetAdaptersAddresses( long long ptr ptr ptr ) @ stdcall GetAdaptersInfo( ptr ptr ) #@ stub GetAnycastIpAddressEntry -#@ stub GetAnycastIpAddressTable +@ stdcall GetAnycastIpAddressTable( long ptr ) @ stdcall GetBestInterface( long ptr ) @ stdcall GetBestInterfaceEx( ptr ptr ) @ stub GetBestInterfaceFromStack diff --git a/dlls/iphlpapi/iphlpapi_main.c b/dlls/iphlpapi/iphlpapi_main.c index 9c451500fa5..343cc2345d2 100644 --- a/dlls/iphlpapi/iphlpapi_main.c +++ b/dlls/iphlpapi/iphlpapi_main.c @@ -3734,6 +3734,18 @@ err: return err; } +DWORD WINAPI GetAnycastIpAddressTable(ADDRESS_FAMILY family, MIB_ANYCASTIPADDRESS_TABLE **table) +{ + FIXME( "(%u, %p) stub\n", family, table ); + if (!table || (family != AF_INET && family != AF_INET6 && family != AF_UNSPEC)) + return ERROR_INVALID_PARAMETER; + + *table = heap_alloc_zero(sizeof(MIB_ANYCASTIPADDRESS_TABLE)); + if (!*table) return ERROR_NOT_ENOUGH_MEMORY; + (*table)->NumEntries = 0; + return NO_ERROR; +} + /****************************************************************** * GetUniDirectionalAdapterInfo (IPHLPAPI.@) * diff --git a/include/netioapi.h b/include/netioapi.h index 8c1491f9efa..f49c670dac6 100644 --- a/include/netioapi.h +++ b/include/netioapi.h @@ -172,6 +172,20 @@ typedef struct _MIB_UNICASTIPADDRESS_TABLE MIB_UNICASTIPADDRESS_ROW Table[1]; } MIB_UNICASTIPADDRESS_TABLE, *PMIB_UNICASTIPADDRESS_TABLE; +typedef struct _MIB_ANYCASTIPADDRESS_ROW +{ + SOCKADDR_INET Address; + NET_LUID InterfaceLuid; + NET_IFINDEX InterfaceIndex; + SCOPE_ID ScopeId; +} MIB_ANYCASTIPADDRESS_ROW, *PMIB_ANYCASTIPADDRESS_ROW; + +typedef struct _MIB_ANYCASTIPADDRESS_TABLE +{ + ULONG NumEntries; + MIB_ANYCASTIPADDRESS_ROW Table[ANY_SIZE]; +} MIB_ANYCASTIPADDRESS_TABLE, *PMIB_ANYCASTIPADDRESS_TABLE; + typedef struct _IP_ADDRESS_PREFIX { SOCKADDR_INET Prefix; @@ -254,6 +268,7 @@ IPHLPAPI_DLL_LINKAGE DWORD WINAPI ConvertInterfaceNameToLuidA(const char*,NET_LU IPHLPAPI_DLL_LINKAGE DWORD WINAPI ConvertInterfaceNameToLuidW(const WCHAR*,NET_LUID*); IPHLPAPI_DLL_LINKAGE DWORD WINAPI ConvertLengthToIpv4Mask(ULONG,ULONG*); IPHLPAPI_DLL_LINKAGE void WINAPI FreeMibTable(void*); +IPHLPAPI_DLL_LINKAGE DWORD WINAPI GetAnycastIpAddressTable(ADDRESS_FAMILY,MIB_ANYCASTIPADDRESS_TABLE**); IPHLPAPI_DLL_LINKAGE NET_IF_COMPARTMENT_ID WINAPI GetCurrentThreadCompartmentId(void); IPHLPAPI_DLL_LINKAGE DWORD WINAPI GetIfEntry2(MIB_IF_ROW2*); IPHLPAPI_DLL_LINKAGE DWORD WINAPI GetIfEntry2Ex(MIB_IF_TABLE_LEVEL,MIB_IF_ROW2*);

1 0

Alex Henrie : ntdll: Include alloc_type argument in NtMapViewOfSection(Ex) traces.
by Alexandre Julliard 14 Feb '24

14 Feb '24

Module: wine Branch: master Commit: fb2ebbbb4024286a692dfc7c5424c8e1ee50096d URL: https://gitlab.winehq.org/wine/wine/-/commit/fb2ebbbb4024286a692dfc7c5424c8… Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Sun Jan 7 14:51:25 2024 -0700 ntdll: Include alloc_type argument in NtMapViewOfSection(Ex) traces. LANCommander calls NtMapViewOfSectionEx with alloc_type=MEM_REPLACE_PLACEHOLDER, but you couldn't tell from the trace. --- dlls/ntdll/unix/virtual.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/ntdll/unix/virtual.c b/dlls/ntdll/unix/virtual.c index 02c0bebe879..2b6ce543531 100644 --- a/dlls/ntdll/unix/virtual.c +++ b/dlls/ntdll/unix/virtual.c @@ -5444,8 +5444,8 @@ NTSTATUS WINAPI NtMapViewOfSection( HANDLE handle, HANDLE process, PVOID *addr_p offset.QuadPart = offset_ptr ? offset_ptr->QuadPart : 0; - TRACE("handle=%p process=%p addr=%p off=%s size=%lx access=%x\n", - handle, process, *addr_ptr, wine_dbgstr_longlong(offset.QuadPart), *size_ptr, (int)protect ); + TRACE("handle=%p process=%p addr=%p off=%s size=0x%lx alloc_type=0x%x access=0x%x\n", + handle, process, *addr_ptr, wine_dbgstr_longlong(offset.QuadPart), *size_ptr, (int)alloc_type, (int)protect ); /* Check parameters */ if (zero_bits > 21 && zero_bits < 32) @@ -5525,8 +5525,8 @@ NTSTATUS WINAPI NtMapViewOfSectionEx( HANDLE handle, HANDLE process, PVOID *addr offset.QuadPart = offset_ptr ? offset_ptr->QuadPart : 0; - TRACE( "handle=%p process=%p addr=%p off=%s size=%lx access=%x\n", - handle, process, *addr_ptr, wine_dbgstr_longlong(offset.QuadPart), *size_ptr, (int)protect ); + TRACE( "handle=%p process=%p addr=%p off=%s size=0x%lx alloc_type=0x%x access=0x%x\n", + handle, process, *addr_ptr, wine_dbgstr_longlong(offset.QuadPart), *size_ptr, (int)alloc_type, (int)protect ); status = get_extended_params( parameters, count, &limit_low, &limit_high, &align, &attributes, &machine );

1 0

Marc-Aurel Zent : iphlpapi: Implement GetRTTAndHopCount().
by Alexandre Julliard 14 Feb '24

14 Feb '24

Module: wine Branch: master Commit: cd2570c28d0f3351795d3b926a068e6b2585fb71 URL: https://gitlab.winehq.org/wine/wine/-/commit/cd2570c28d0f3351795d3b926a068e… Author: Marc-Aurel Zent <mzent(a)codeweavers.com> Date: Thu Jan 11 23:54:49 2024 +0100 iphlpapi: Implement GetRTTAndHopCount(). --- dlls/iphlpapi/iphlpapi_main.c | 50 +++++++++++++++++++++++++++++++++++++------ 1 file changed, 43 insertions(+), 7 deletions(-) diff --git a/dlls/iphlpapi/iphlpapi_main.c b/dlls/iphlpapi/iphlpapi_main.c index 9c7582b71fb..9c451500fa5 100644 --- a/dlls/iphlpapi/iphlpapi_main.c +++ b/dlls/iphlpapi/iphlpapi_main.c @@ -2781,15 +2781,51 @@ DWORD WINAPI GetPerAdapterInfo( ULONG index, IP_PER_ADAPTER_INFO *info, ULONG *s * RETURNS * Success: TRUE * Failure: FALSE - * - * FIXME - * Stub, returns FALSE. */ -BOOL WINAPI GetRTTAndHopCount(IPAddr DestIpAddress, PULONG HopCount, ULONG MaxHops, PULONG RTT) +BOOL WINAPI GetRTTAndHopCount( IPAddr dest_ip_address, ULONG *hop_count, ULONG max_hops, ULONG *rtt ) { - FIXME("(DestIpAddress 0x%08lx, HopCount %p, MaxHops %ld, RTT %p): stub\n", - DestIpAddress, HopCount, MaxHops, RTT); - return FALSE; + char send_buffer[0x20] = { 0xDE, 0xAD, 0xBE, 0xEF }; + char receive_buffer[sizeof(ICMP_ECHO_REPLY) + sizeof(send_buffer)]; + const DWORD timeout = 5000; + DWORD replies; + IP_OPTION_INFORMATION send_options = { 0 }; + ICMP_ECHO_REPLY *reply; + HANDLE icmp_handle; + + TRACE( "(dest_ip_address 0x%08lx, hop_count %p, max_hops %ld, rtt %p)\n", + dest_ip_address, hop_count, max_hops, rtt ); + + if (!hop_count || !rtt || dest_ip_address == INADDR_NONE) + return FALSE; + + if ((icmp_handle = IcmpCreateFile()) == INVALID_HANDLE_VALUE) + return FALSE; + + for (send_options.Ttl = 1; send_options.Ttl <= max_hops; send_options.Ttl++) + { + replies = IcmpSendEcho( icmp_handle, dest_ip_address, send_buffer, sizeof(send_buffer), + &send_options, receive_buffer, sizeof(receive_buffer), timeout ); + + if (!replies) + { + if (GetLastError() == IP_TTL_EXPIRED_TRANSIT) continue; + if (GetLastError() == IP_REQ_TIMED_OUT) continue; + break; + } + + reply = (PICMP_ECHO_REPLY)receive_buffer; + + if (reply->Status == IP_SUCCESS) + { + *hop_count = send_options.Ttl; + *rtt = reply->RoundTripTime; + IcmpCloseHandle( icmp_handle ); + return TRUE; + } + } + + IcmpCloseHandle( icmp_handle ); + return FALSE; } /******************************************************************

1 0

Henri Verbeet : tests: Implement check_requirements() for the OpenGL shader runner.
by Alexandre Julliard 13 Feb '24

13 Feb '24

Module: vkd3d Branch: master Commit: 0f3a42c34b3d8d8b38564f79029e9ac8758d22dc URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/0f3a42c34b3d8d8b38564f79029e9… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Feb 12 19:57:42 2024 +0100 tests: Implement check_requirements() for the OpenGL shader runner. --- tests/shader_runner.c | 4 +--- tests/shader_runner_gl.c | 32 ++++++++++++++++++++++++++++++-- 2 files changed, 31 insertions(+), 5 deletions(-) diff --git a/tests/shader_runner.c b/tests/shader_runner.c index a683866c..c645e6c0 100644 --- a/tests/shader_runner.c +++ b/tests/shader_runner.c @@ -1350,10 +1350,8 @@ void run_shader_tests(struct shader_runner *runner, const struct shader_runner_o case STATE_REQUIRE: if (runner->maximum_shader_model < runner->minimum_shader_model - || (runner->ops->check_requirements && !runner->ops->check_requirements(runner))) - { + || !runner->ops->check_requirements(runner)) skip_tests = true; - } break; case STATE_RESOURCE: diff --git a/tests/shader_runner_gl.c b/tests/shader_runner_gl.c index a898d021..881ca77a 100644 --- a/tests/shader_runner_gl.c +++ b/tests/shader_runner_gl.c @@ -59,6 +59,12 @@ struct gl_runner { struct shader_runner r; + struct + { + bool float64; + bool int64; + } caps; + EGLDisplay display; EGLContext context; @@ -93,7 +99,7 @@ static bool check_gl_extension(const char *extension, GLint extension_count) return false; } -static bool check_gl_extensions(void) +static bool check_gl_extensions(struct gl_runner *runner) { GLint count; @@ -114,6 +120,11 @@ static bool check_gl_extensions(void) return false; } + if (check_gl_extension("GL_ARB_gpu_shader_fp64", count)) + runner->caps.float64 = true; + if (check_gl_extension("GL_ARB_gpu_shader_int64", count)) + runner->caps.int64 = true; + return true; } @@ -210,7 +221,8 @@ static bool gl_runner_init(struct gl_runner *runner) continue; } - if (!check_gl_extensions()) + memset(&runner->caps, 0, sizeof(runner->caps)); + if (!check_gl_extensions(runner)) { trace("Device %u lacks required extensions.\n", i); eglMakeCurrent(display, EGL_NO_SURFACE, EGL_NO_SURFACE, EGL_NO_CONTEXT); @@ -237,6 +249,9 @@ static bool gl_runner_init(struct gl_runner *runner) trace("GL_RENDERER: %s\n", glGetString(GL_RENDERER)); trace(" GL_VERSION: %s\n", glGetString(GL_VERSION)); + trace(" float64: %u.\n", runner->caps.float64); + trace(" int64: %u.\n", runner->caps.int64); + p_glSpecializeShader = (void *)eglGetProcAddress("glSpecializeShader"); glDebugMessageControl(GL_DONT_CARE, GL_DONT_CARE, GL_DEBUG_SEVERITY_NOTIFICATION, 0, NULL, GL_FALSE); @@ -274,6 +289,18 @@ static void gl_runner_cleanup(struct gl_runner *runner) ok(ret, "Failed to terminate EGL display connection.\n"); } +static bool gl_runner_check_requirements(struct shader_runner *r) +{ + struct gl_runner *runner = gl_runner(r); + + if (r->require_float64 && !runner->caps.float64) + return false; + if (r->require_int64 && !runner->caps.int64) + return false; + + return true; +} + static const struct format_info *get_format_info(enum DXGI_FORMAT format) { size_t i; @@ -979,6 +1006,7 @@ static void gl_runner_release_readback(struct shader_runner *runner, struct reso static const struct shader_runner_ops gl_runner_ops = { + .check_requirements = gl_runner_check_requirements, .create_resource = gl_runner_create_resource, .destroy_resource = gl_runner_destroy_resource, .dispatch = gl_runner_dispatch,

1 0

Conor McCarthy : vkd3d: Handle D3D12_FEATURE_D3D12_OPTIONS13 in CheckFeatureSupport().
by Alexandre Julliard 13 Feb '24

13 Feb '24

Module: vkd3d Branch: master Commit: aac3916fcfa7169898557dfa6c3658d7239cccc7 URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/aac3916fcfa7169898557dfa6c365… Author: Conor McCarthy <cmccarthy(a)codeweavers.com> Date: Fri Feb 9 23:39:20 2024 +1000 vkd3d: Handle D3D12_FEATURE_D3D12_OPTIONS13 in CheckFeatureSupport(). --- libs/vkd3d/device.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/libs/vkd3d/device.c b/libs/vkd3d/device.c index 414714d4..f5a57ad3 100644 --- a/libs/vkd3d/device.c +++ b/libs/vkd3d/device.c @@ -3488,6 +3488,32 @@ static HRESULT STDMETHODCALLTYPE d3d12_device_CheckFeatureSupport(ID3D12Device7 return S_OK; } + case D3D12_FEATURE_D3D12_OPTIONS13: + { + D3D12_FEATURE_DATA_D3D12_OPTIONS13 *data = feature_data; + + if (feature_data_size != sizeof(*data)) + { + WARN("Invalid size %u.\n", feature_data_size); + return E_INVALIDARG; + } + + data->UnrestrictedBufferTextureCopyPitchSupported = FALSE; + data->UnrestrictedVertexElementAlignmentSupported = FALSE; + data->InvertedViewportHeightFlipsYSupported = FALSE; + data->InvertedViewportDepthFlipsZSupported = FALSE; + data->TextureCopyBetweenDimensionsSupported = FALSE; + data->AlphaBlendFactorSupported = FALSE; + + TRACE("Unrestricted buffer-texture copy pitch %#x.\n", data->UnrestrictedBufferTextureCopyPitchSupported); + TRACE("Unrestricted vertex element alignment %#x.\n", data->UnrestrictedVertexElementAlignmentSupported); + TRACE("Inverted viewport height flips Y %#x.\n", data->InvertedViewportHeightFlipsYSupported); + TRACE("Inverted viewport depth flips Z %#x.\n", data->InvertedViewportDepthFlipsZSupported); + TRACE("Texture copy between dimensions %#x.\n", data->TextureCopyBetweenDimensionsSupported); + TRACE("Alpha blend factor support %#x.\n", data->AlphaBlendFactorSupported); + return S_OK; + } + default: FIXME("Unhandled feature %#x.\n", feature); return E_NOTIMPL;

1 0

Conor McCarthy : vkd3d: Handle D3D12_FEATURE_D3D12_OPTIONS12 in CheckFeatureSupport().
by Alexandre Julliard 13 Feb '24

13 Feb '24

Module: vkd3d Branch: master Commit: 7b4e731aa53f6e9ec0d40afab74ff207374fbb5e URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/7b4e731aa53f6e9ec0d40afab74ff… Author: Conor McCarthy <cmccarthy(a)codeweavers.com> Date: Fri Feb 9 23:34:11 2024 +1000 vkd3d: Handle D3D12_FEATURE_D3D12_OPTIONS12 in CheckFeatureSupport(). --- libs/vkd3d/device.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/libs/vkd3d/device.c b/libs/vkd3d/device.c index 40e42913..414714d4 100644 --- a/libs/vkd3d/device.c +++ b/libs/vkd3d/device.c @@ -3467,6 +3467,27 @@ static HRESULT STDMETHODCALLTYPE d3d12_device_CheckFeatureSupport(ID3D12Device7 return S_OK; } + case D3D12_FEATURE_D3D12_OPTIONS12: + { + D3D12_FEATURE_DATA_D3D12_OPTIONS12 *data = feature_data; + + if (feature_data_size != sizeof(*data)) + { + WARN("Invalid size %u.\n", feature_data_size); + return E_INVALIDARG; + } + + data->MSPrimitivesPipelineStatisticIncludesCulledPrimitives = D3D12_TRI_STATE_UNKNOWN; + data->EnhancedBarriersSupported = FALSE; + data->RelaxedFormatCastingSupported = FALSE; + + TRACE("Mesh shader primitives pipeline stats include cull primitives %#x.\n", + data->MSPrimitivesPipelineStatisticIncludesCulledPrimitives); + TRACE("Enhanced barriers %#x.\n", data->EnhancedBarriersSupported); + TRACE("Relaxed format casting %#x.\n", data->RelaxedFormatCastingSupported); + return S_OK; + } + default: FIXME("Unhandled feature %#x.\n", feature); return E_NOTIMPL;

1 0

Conor McCarthy : vkd3d: Handle D3D12_FEATURE_D3D12_OPTIONS11 in CheckFeatureSupport().
by Alexandre Julliard 13 Feb '24

13 Feb '24

Module: vkd3d Branch: master Commit: 68663b4fefef422ea6a37c4d55eda7a567e67bb6 URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/68663b4fefef422ea6a37c4d55eda… Author: Conor McCarthy <cmccarthy(a)codeweavers.com> Date: Fri Feb 9 23:29:59 2024 +1000 vkd3d: Handle D3D12_FEATURE_D3D12_OPTIONS11 in CheckFeatureSupport(). --- libs/vkd3d/device.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/libs/vkd3d/device.c b/libs/vkd3d/device.c index 98e21ed3..40e42913 100644 --- a/libs/vkd3d/device.c +++ b/libs/vkd3d/device.c @@ -3451,6 +3451,22 @@ static HRESULT STDMETHODCALLTYPE d3d12_device_CheckFeatureSupport(ID3D12Device7 return S_OK; } + case D3D12_FEATURE_D3D12_OPTIONS11: + { + D3D12_FEATURE_DATA_D3D12_OPTIONS11 *data = feature_data; + + if (feature_data_size != sizeof(*data)) + { + WARN("Invalid size %u.\n", feature_data_size); + return E_INVALIDARG; + } + + data->AtomicInt64OnDescriptorHeapResourceSupported = FALSE; + + TRACE("Atomic int64 on descriptor heap resource %#x.\n", data->AtomicInt64OnDescriptorHeapResourceSupported); + return S_OK; + } + default: FIXME("Unhandled feature %#x.\n", feature); return E_NOTIMPL;

1 0

Conor McCarthy : vkd3d: Handle D3D12_FEATURE_D3D12_OPTIONS10 in CheckFeatureSupport().
by Alexandre Julliard 13 Feb '24

13 Feb '24

Module: vkd3d Branch: master Commit: a0bb055ad25a4a4d4a8badf9e79fb27c1965b847 URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/a0bb055ad25a4a4d4a8badf9e79fb… Author: Conor McCarthy <cmccarthy(a)codeweavers.com> Date: Fri Feb 9 23:27:24 2024 +1000 vkd3d: Handle D3D12_FEATURE_D3D12_OPTIONS10 in CheckFeatureSupport(). --- libs/vkd3d/device.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/libs/vkd3d/device.c b/libs/vkd3d/device.c index 1e094690..98e21ed3 100644 --- a/libs/vkd3d/device.c +++ b/libs/vkd3d/device.c @@ -3433,6 +3433,24 @@ static HRESULT STDMETHODCALLTYPE d3d12_device_CheckFeatureSupport(ID3D12Device7 return S_OK; } + case D3D12_FEATURE_D3D12_OPTIONS10: + { + D3D12_FEATURE_DATA_D3D12_OPTIONS10 *data = feature_data; + + if (feature_data_size != sizeof(*data)) + { + WARN("Invalid size %u.\n", feature_data_size); + return E_INVALIDARG; + } + + data->VariableRateShadingSumCombinerSupported = FALSE; + data->MeshShaderPerPrimitiveShadingRateSupported = FALSE; + + TRACE("Variable rate shading sum combiner %#x.\n", data->VariableRateShadingSumCombinerSupported); + TRACE("Mesh shader per primitive shading rate %#x.\n", data->MeshShaderPerPrimitiveShadingRateSupported); + return S_OK; + } + default: FIXME("Unhandled feature %#x.\n", feature); return E_NOTIMPL;

1 0

Zhiyi Zhang : server: Inherit internal desktop flags when creating desktops.
by Alexandre Julliard 13 Feb '24

13 Feb '24

Module: wine Branch: master Commit: ca97cb87008293f7893a5dd4d082b50c2cfbfb81 URL: https://gitlab.winehq.org/wine/wine/-/commit/ca97cb87008293f7893a5dd4d082b5… Author: Zhiyi Zhang <zzhang(a)codeweavers.com> Date: Sun Jan 7 22:25:24 2024 +0800 server: Inherit internal desktop flags when creating desktops. Based on Rémi's idea. CEF applications create their own desktops and so is_virtual_desktop() could incorrectly report that virtual desktop is off if DF_WINE_VIRTUAL_DESKTOP is not inherited. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55810 --- dlls/user32/winstation.c | 3 ++- include/ntuser.h | 1 + programs/explorer/desktop.c | 2 +- server/winstation.c | 14 ++++++++++++-- 4 files changed, 16 insertions(+), 4 deletions(-) diff --git a/dlls/user32/winstation.c b/dlls/user32/winstation.c index c433ea6ec88..ec8be243b32 100644 --- a/dlls/user32/winstation.c +++ b/dlls/user32/winstation.c @@ -256,7 +256,8 @@ HDESK WINAPI CreateDesktopW( LPCWSTR name, LPCWSTR device, LPDEVMODEW devmode, OBJECT_ATTRIBUTES attr; UNICODE_STRING str; - if (device || (devmode && !(flags & DF_WINE_VIRTUAL_DESKTOP))) + if (device || (devmode && !(flags & DF_WINE_VIRTUAL_DESKTOP)) + || (flags & DF_WINE_ROOT_DESKTOP && flags & DF_WINE_VIRTUAL_DESKTOP)) { SetLastError( ERROR_INVALID_PARAMETER ); return 0; diff --git a/include/ntuser.h b/include/ntuser.h index e60efc11b6f..86f847b8b83 100644 --- a/include/ntuser.h +++ b/include/ntuser.h @@ -297,6 +297,7 @@ struct unpack_dde_message_result #define SPY_RESULT_DEFWND 0x0002 /* CreateDesktop wine specific flag */ +#define DF_WINE_ROOT_DESKTOP 0x40000000 #define DF_WINE_VIRTUAL_DESKTOP 0x80000000 /* NtUserMessageCall codes */ diff --git a/programs/explorer/desktop.c b/programs/explorer/desktop.c index aa80e353143..4e8f9a84c07 100644 --- a/programs/explorer/desktop.c +++ b/programs/explorer/desktop.c @@ -1094,7 +1094,7 @@ void manage_desktop( WCHAR *arg ) { DEVMODEW devmode = {.dmPelsWidth = width, .dmPelsHeight = height}; /* magic: desktop "root" means use the root window */ - if ((using_root = !wcsicmp( name, L"root" ))) desktop = CreateDesktopW( name, NULL, NULL, 0, DESKTOP_ALL_ACCESS, NULL ); + if ((using_root = !wcsicmp( name, L"root" ))) desktop = CreateDesktopW( name, NULL, NULL, DF_WINE_ROOT_DESKTOP, DESKTOP_ALL_ACCESS, NULL ); else desktop = CreateDesktopW( name, NULL, &devmode, DF_WINE_VIRTUAL_DESKTOP, DESKTOP_ALL_ACCESS, NULL ); if (!desktop) { diff --git a/server/winstation.c b/server/winstation.c index 5c59fbffae1..930c5c90d97 100644 --- a/server/winstation.c +++ b/server/winstation.c @@ -221,14 +221,24 @@ struct desktop *get_desktop_obj( struct process *process, obj_handle_t handle, u static struct desktop *create_desktop( const struct unicode_str *name, unsigned int attr, unsigned int flags, struct winstation *winstation ) { - struct desktop *desktop; + struct desktop *desktop, *current_desktop; if ((desktop = create_named_object( &winstation->obj, &desktop_ops, name, attr, NULL ))) { if (get_error() != STATUS_OBJECT_NAME_EXISTS) { /* initialize it if it didn't already exist */ + desktop->flags = flags; + + /* inherit DF_WINE_*_DESKTOP flags if none of them are specified */ + if (!(flags & (DF_WINE_ROOT_DESKTOP | DF_WINE_VIRTUAL_DESKTOP)) + && (current_desktop = get_thread_desktop( current, 0 ))) + { + desktop->flags |= current_desktop->flags & (DF_WINE_VIRTUAL_DESKTOP | DF_WINE_ROOT_DESKTOP); + release_object( current_desktop ); + } + desktop->winstation = (struct winstation *)grab_object( winstation ); desktop->top_window = NULL; desktop->msg_window = NULL; @@ -243,7 +253,7 @@ static struct desktop *create_desktop( const struct unicode_str *name, unsigned } else { - desktop->flags |= (flags & DF_WINE_VIRTUAL_DESKTOP); + desktop->flags |= flags & (DF_WINE_VIRTUAL_DESKTOP | DF_WINE_ROOT_DESKTOP); clear_error(); } }

1 0

← Newer
1
...
41
42
43
44
45
46
47
...
72
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits February 2024