wine-commits February 2024

wine-commits@winehq.org

1 participants
716 discussions

Piotr Caban : wininet: Fix memory leak when loading proxy information.
by Alexandre Julliard 28 Feb '24

28 Feb '24

Module: wine Branch: master Commit: da84d77353dfcd32bb941ac1ec61f42fb798433d URL: https://gitlab.winehq.org/wine/wine/-/commit/da84d77353dfcd32bb941ac1ec61f4… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Tue Feb 27 14:15:17 2024 +0100 wininet: Fix memory leak when loading proxy information. --- dlls/wininet/internet.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/wininet/internet.c b/dlls/wininet/internet.c index 5ee1242da1b..fe016e29cd5 100644 --- a/dlls/wininet/internet.c +++ b/dlls/wininet/internet.c @@ -710,6 +710,7 @@ static LONG load_connection_settings( HKEY key, const WCHAR *connection, proxyin res = connection_settings_read( settings, &pos, size, &lpwpi->proxyBypass ); if (!res) res = connection_settings_read( settings, &pos, size, &lpwpi->autoconf_url ); + free( settings ); if (res) { FreeProxyInfo( lpwpi );

1 0

Yuxuan Shui : dmime: Add a stub chordtrack for MIDI segments.
by Alexandre Julliard 28 Feb '24

28 Feb '24

Module: wine Branch: master Commit: 29f73d6669c8538a9043afbc5a952b220af11203 URL: https://gitlab.winehq.org/wine/wine/-/commit/29f73d6669c8538a9043afbc5a952b… Author: Yuxuan Shui <yshui(a)codeweavers.com> Date: Thu Feb 15 16:54:54 2024 +0000 dmime: Add a stub chordtrack for MIDI segments. --- dlls/dmime/midi.c | 20 +++++++++++--------- dlls/dmime/tests/dmime.c | 10 +++++----- 2 files changed, 16 insertions(+), 14 deletions(-) diff --git a/dlls/dmime/midi.c b/dlls/dmime/midi.c index 439511d15cc..647ef1d123c 100644 --- a/dlls/dmime/midi.c +++ b/dlls/dmime/midi.c @@ -40,6 +40,7 @@ struct midi_event struct midi_parser { + IDirectMusicTrack *chordtrack; IDirectMusicTrack *bandtrack; MUSIC_TIME time; IStream *stream; @@ -221,13 +222,16 @@ static HRESULT midi_parser_parse(struct midi_parser *parser, IDirectMusicSegment music_length = (ULONGLONG)music_length * DMUS_PPQ / parser->division + 1; if (SUCCEEDED(hr)) hr = IDirectMusicSegment8_SetLength(segment, music_length); if (SUCCEEDED(hr)) hr = IDirectMusicSegment8_InsertTrack(segment, parser->bandtrack, 0xffff); + if (SUCCEEDED(hr)) hr = IDirectMusicSegment8_InsertTrack(segment, parser->chordtrack, 0xffff); + return hr; } static void midi_parser_destroy(struct midi_parser *parser) { IStream_Release(parser->stream); - IDirectMusicTrack_Release(parser->bandtrack); + if (parser->bandtrack) IDirectMusicTrack_Release(parser->bandtrack); + if (parser->chordtrack) IDirectMusicTrack_Release(parser->chordtrack); free(parser); } @@ -267,18 +271,16 @@ static HRESULT midi_parser_new(IStream *stream, struct midi_parser **out_parser) parser = calloc(1, sizeof(struct midi_parser)); if (!parser) return E_OUTOFMEMORY; + IStream_AddRef(stream); parser->stream = stream; parser->division = division; hr = CoCreateInstance(&CLSID_DirectMusicBandTrack, NULL, CLSCTX_INPROC_SERVER, &IID_IDirectMusicTrack, (void **)&parser->bandtrack); - if (FAILED(hr)) - { - free(parser); - return hr; - } - - *out_parser = parser; - IStream_AddRef(stream); + if (SUCCEEDED(hr)) + hr = CoCreateInstance(&CLSID_DirectMusicChordTrack, NULL, CLSCTX_INPROC_SERVER, + &IID_IDirectMusicTrack, (void **)&parser->chordtrack); + if (FAILED(hr)) midi_parser_destroy(parser); + else *out_parser = parser; return hr; } diff --git a/dlls/dmime/tests/dmime.c b/dlls/dmime/tests/dmime.c index 41b34944f9d..97a6088936e 100644 --- a/dlls/dmime/tests/dmime.c +++ b/dlls/dmime/tests/dmime.c @@ -1681,7 +1681,7 @@ static void test_midi(void) ok(hr == S_OK, "got %#lx\n", hr); expect_track(segment, BandTrack, -1, 0); - todo_wine expect_track(segment, ChordTrack, -1, 1); + expect_track(segment, ChordTrack, -1, 1); todo_wine expect_track(segment, TempoTrack, -1, 2); todo_wine expect_track(segment, TimeSigTrack, -1, 3); todo_wine expect_track(segment, SeqTrack, -1, 4); @@ -1723,7 +1723,7 @@ static void test_midi(void) IStream_Release(stream); /* TempoTrack and TimeSigTrack seems to be optional. */ expect_track(segment, BandTrack, -1, 0); - todo_wine expect_track(segment, ChordTrack, -1, 1); + expect_track(segment, ChordTrack, -1, 1); todo_wine expect_track(segment, SeqTrack, -1, 2); IDirectMusicSegment_Release(segment); @@ -1759,7 +1759,7 @@ static void test_midi(void) IPersistStream_Release(persist); IStream_Release(stream); expect_track(segment, BandTrack, -1, 0); - todo_wine expect_track(segment, ChordTrack, -1, 1); + expect_track(segment, ChordTrack, -1, 1); todo_wine expect_track(segment, TempoTrack, -1, 2); todo_wine expect_track(segment, SeqTrack, -1, 3); IDirectMusicSegment_Release(segment); @@ -1795,7 +1795,7 @@ static void test_midi(void) IPersistStream_Release(persist); IStream_Release(stream); expect_track(segment, BandTrack, -1, 0); - todo_wine expect_track(segment, ChordTrack, -1, 1); + expect_track(segment, ChordTrack, -1, 1); /* there is no tempo track. */ todo_wine expect_track(segment, SeqTrack, -1, 2); IDirectMusicSegment_Release(segment); @@ -1832,7 +1832,7 @@ static void test_midi(void) IPersistStream_Release(persist); IStream_Release(stream); expect_track(segment, BandTrack, -1, 0); - todo_wine expect_track(segment, ChordTrack, -1, 1); + expect_track(segment, ChordTrack, -1, 1); todo_wine expect_track(segment, SeqTrack, -1, 2); hr = test_tool_create(message_types, ARRAY_SIZE(message_types), &tool);

1 0

Yuxuan Shui : dmime: Parse MIDI program change events and generate a bandtrack.
by Alexandre Julliard 28 Feb '24

28 Feb '24

Module: wine Branch: master Commit: 05347b9703f12876efe53843f8a1d8360bdcfbb4 URL: https://gitlab.winehq.org/wine/wine/-/commit/05347b9703f12876efe53843f8a1d8… Author: Yuxuan Shui <yshui(a)codeweavers.com> Date: Tue Feb 27 15:43:52 2024 +0000 dmime: Parse MIDI program change events and generate a bandtrack. --- dlls/dmime/Makefile.in | 1 + dlls/dmime/midi.c | 112 ++++++++++++++++++++++++++++++++------- dlls/dmime/tests/dmime.c | 130 ++++++++++++++++++++++++++++++++++++++++++++-- dlls/dmusic/band.c | 14 +++++ dlls/dmusic/dmusic_band.h | 2 + 5 files changed, 236 insertions(+), 23 deletions(-)

1 0

Yuxuan Shui : dmime: Better MIDI parsing interface.
by Alexandre Julliard 28 Feb '24

28 Feb '24

Module: wine Branch: master Commit: aebcb1a996724aadc2fc02f913c10bdc1e711faf URL: https://gitlab.winehq.org/wine/wine/-/commit/aebcb1a996724aadc2fc02f913c10b… Author: Yuxuan Shui <yshui(a)codeweavers.com> Date: Tue Feb 27 15:42:52 2024 +0000 dmime: Better MIDI parsing interface. MIDI tracks don't map one-to-one to segment tracks, so it doesn't make sense to use a "get_next_track()" interface. --- dlls/dmime/dmime_private.h | 7 ++----- dlls/dmime/midi.c | 23 +++++++++++++++++------ dlls/dmime/segment.c | 16 +--------------- 3 files changed, 20 insertions(+), 26 deletions(-) diff --git a/dlls/dmime/dmime_private.h b/dlls/dmime/dmime_private.h index cdf0810381d..1c030dc314d 100644 --- a/dlls/dmime/dmime_private.h +++ b/dlls/dmime/dmime_private.h @@ -70,11 +70,8 @@ extern HRESULT create_dmtempotrack(REFIID riid, void **ret_iface); extern HRESULT create_dmtimesigtrack(REFIID riid, void **ret_iface); extern HRESULT create_dmwavetrack(REFIID riid, void **ret_iface); -/* Create a new MIDI file parser. Note the stream might still be modified even - * when this function fails. */ -extern HRESULT midi_parser_new(IStream *stream, struct midi_parser **out_parser); -extern HRESULT midi_parser_next_track(struct midi_parser *parser, IDirectMusicTrack **out_track, MUSIC_TIME *out_length); -extern void midi_parser_destroy(struct midi_parser *parser); +/* Parse a MIDI file. Note the stream might still be modified even when this function fails. */ +extern HRESULT parse_midi(IStream *stream, IDirectMusicSegment8 *segment); extern void set_audiopath_perf_pointer(IDirectMusicAudioPath*,IDirectMusicPerformance8*); extern void set_audiopath_dsound_buffer(IDirectMusicAudioPath*,IDirectSoundBuffer*); diff --git a/dlls/dmime/midi.c b/dlls/dmime/midi.c index a31146e636f..40db1d2232c 100644 --- a/dlls/dmime/midi.c +++ b/dlls/dmime/midi.c @@ -125,10 +125,10 @@ static HRESULT read_midi_event(IStream *stream, BYTE *last_status, ULONG *bytes_ return S_OK; } -HRESULT midi_parser_next_track(struct midi_parser *parser, IDirectMusicTrack **out_track, MUSIC_TIME *out_length) +static HRESULT midi_parser_parse(struct midi_parser *parser, IDirectMusicSegment8 *segment) { WORD i = 0; - TRACE("(%p, %p): stub\n", parser, out_length); + TRACE("(%p, %p): stub\n", parser, segment); for (i = 0;; i++) { HRESULT hr; @@ -159,7 +159,13 @@ HRESULT midi_parser_next_track(struct midi_parser *parser, IDirectMusicTrack **o return S_FALSE; } -HRESULT midi_parser_new(IStream *stream, struct midi_parser **out_parser) +static void midi_parser_destroy(struct midi_parser *parser) +{ + IStream_Release(parser->stream); + free(parser); +} + +static HRESULT midi_parser_new(IStream *stream, struct midi_parser **out_parser) { LARGE_INTEGER offset; DWORD length; @@ -202,8 +208,13 @@ HRESULT midi_parser_new(IStream *stream, struct midi_parser **out_parser) return hr; } -void midi_parser_destroy(struct midi_parser *parser) +HRESULT parse_midi(IStream *stream, IDirectMusicSegment8 *segment) { - IStream_Release(parser->stream); - free(parser); + struct midi_parser *parser; + HRESULT hr; + + if (FAILED(hr = midi_parser_new(stream, &parser))) return hr; + hr = midi_parser_parse(parser, segment); + midi_parser_destroy(parser); + return hr; } diff --git a/dlls/dmime/segment.c b/dlls/dmime/segment.c index b0485aaedd9..b96f0e2e401 100644 --- a/dlls/dmime/segment.c +++ b/dlls/dmime/segment.c @@ -791,10 +791,7 @@ static inline struct segment *impl_from_IPersistStream(IPersistStream *iface) static HRESULT WINAPI segment_persist_stream_Load(IPersistStream *iface, IStream *stream) { struct segment *This = impl_from_IPersistStream(iface); - IDirectMusicTrack *track; - MUSIC_TIME length; struct chunk_entry chunk = {0}; - struct midi_parser *midi_parser; HRESULT hr; TRACE("(%p, %p): Loading\n", This, stream); @@ -810,18 +807,7 @@ static HRESULT WINAPI segment_persist_stream_Load(IPersistStream *iface, IStream break; case mmioFOURCC('M','T','h','d'): - hr = midi_parser_new(stream, &midi_parser); - if (FAILED(hr)) break; - This->header.mtLength = 0; - while ((hr = midi_parser_next_track(midi_parser, &track, &length)) == S_OK) - { - hr = segment_append_track(This, track, 1, 0); - IDirectMusicTrack_Release(track); - if (FAILED(hr)) break; - if (length > This->header.mtLength) - This->header.mtLength = length; - } - midi_parser_destroy(midi_parser); + hr = parse_midi(stream, &This->IDirectMusicSegment8_iface); break; case MAKE_IDTYPE(FOURCC_RIFF, mmioFOURCC('W','A','V','E')):

1 0

Yuxuan Shui : dmband: Move band.c to dmusic.
by Alexandre Julliard 28 Feb '24

28 Feb '24

Module: wine Branch: master Commit: 09c6f48b1295b900df5a7d104996e0e69b7f23b0 URL: https://gitlab.winehq.org/wine/wine/-/commit/09c6f48b1295b900df5a7d104996e0… Author: Yuxuan Shui <yshui(a)codeweavers.com> Date: Wed Jan 31 15:48:30 2024 +0000 dmband: Move band.c to dmusic. --- dlls/dmband/bandtrack.c | 1 + dlls/dmband/dmband_main.c | 1 + dlls/dmband/dmband_private.h | 10 ---------- dlls/dmusic/Makefile.in | 1 + dlls/{dmband => dmusic}/band.c | 3 +-- dlls/dmusic/dmusic_band.h | 25 +++++++++++++++++++++++++ 6 files changed, 29 insertions(+), 12 deletions(-) diff --git a/dlls/dmband/bandtrack.c b/dlls/dmband/bandtrack.c index b410cf81d3a..45346ad1f7a 100644 --- a/dlls/dmband/bandtrack.c +++ b/dlls/dmband/bandtrack.c @@ -17,6 +17,7 @@ */ #include "dmband_private.h" +#include "dmusic_band.h" #include "dmobject.h" WINE_DEFAULT_DEBUG_CHANNEL(dmband); diff --git a/dlls/dmband/dmband_main.c b/dlls/dmband/dmband_main.c index 55f979e3fbc..43790fbff61 100644 --- a/dlls/dmband/dmband_main.c +++ b/dlls/dmband/dmband_main.c @@ -20,6 +20,7 @@ #include "initguid.h" #include "dmband_private.h" #include "rpcproxy.h" +#include "dmusic_band.h" #include "dmobject.h" WINE_DEFAULT_DEBUG_CHANNEL(dmband); diff --git a/dlls/dmband/dmband_private.h b/dlls/dmband/dmband_private.h index 48c5ec02aeb..3b2617322fe 100644 --- a/dlls/dmband/dmband_private.h +++ b/dlls/dmband/dmband_private.h @@ -20,21 +20,16 @@ #ifndef __WINE_DMBAND_PRIVATE_H #define __WINE_DMBAND_PRIVATE_H -#include <stdio.h> #include <stdarg.h> -#include <string.h> #define COBJMACROS #include "windef.h" #include "winbase.h" #include "winnt.h" -#include "wingdi.h" -#include "winuser.h" #include "wine/debug.h" #include "wine/list.h" -#include "winreg.h" #include "objbase.h" #include "dmusici.h" @@ -44,11 +39,6 @@ /***************************************************************************** * ClassFactory */ -extern HRESULT create_dmband(REFIID riid, void **ret_iface); extern HRESULT create_dmbandtrack(REFIID riid, void **ret_iface); -extern HRESULT band_connect_to_collection(IDirectMusicBand *iface, IDirectMusicCollection *collection); -extern HRESULT band_send_messages(IDirectMusicBand *iface, IDirectMusicPerformance *performance, - IDirectMusicGraph *graph, MUSIC_TIME time, DWORD track_id); - #endif /* __WINE_DMBAND_PRIVATE_H */ diff --git a/dlls/dmusic/Makefile.in b/dlls/dmusic/Makefile.in index 8e1c07e90a7..446eca15543 100644 --- a/dlls/dmusic/Makefile.in +++ b/dlls/dmusic/Makefile.in @@ -2,6 +2,7 @@ MODULE = dmusic.dll IMPORTS = dxguid uuid ole32 advapi32 dsound user32 winmm SOURCES = \ + band.c \ buffer.c \ clock.c \ collection.c \ diff --git a/dlls/dmband/band.c b/dlls/dmusic/band.c similarity index 99% rename from dlls/dmband/band.c rename to dlls/dmusic/band.c index 78ec68ae035..370b85c2941 100644 --- a/dlls/dmband/band.c +++ b/dlls/dmusic/band.c @@ -17,8 +17,7 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ -#include "dmband_private.h" -#include "dmobject.h" +#include "dmusic_private.h" WINE_DEFAULT_DEBUG_CHANNEL(dmband); diff --git a/dlls/dmusic/dmusic_band.h b/dlls/dmusic/dmusic_band.h new file mode 100644 index 00000000000..e189acb7230 --- /dev/null +++ b/dlls/dmusic/dmusic_band.h @@ -0,0 +1,25 @@ +/* DirectMusicBand Private Include + * + * Copyright (C) 2024 Yuxuan Shui for CodeWeavers + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#include "dmusici.h" + +extern HRESULT create_dmband(REFIID riid, void **ret_iface); +extern HRESULT band_connect_to_collection(IDirectMusicBand *iface, IDirectMusicCollection *collection); +extern HRESULT band_send_messages(IDirectMusicBand *iface, IDirectMusicPerformance *performance, + IDirectMusicGraph *graph, MUSIC_TIME time, DWORD track_id);

1 0

Alexandros Frantzis : winex11.drv: Remove unused refresh_drawables field.
by Alexandre Julliard 28 Feb '24

28 Feb '24

Module: wine Branch: master Commit: 8e0a00db04e2f860197da14ebcf01853a58b6638 URL: https://gitlab.winehq.org/wine/wine/-/commit/8e0a00db04e2f860197da14ebcf018… Author: Alexandros Frantzis <alexandros.frantzis(a)collabora.com> Date: Wed Feb 28 09:23:40 2024 +0200 winex11.drv: Remove unused refresh_drawables field. The field is set but no longer read from. --- dlls/winex11.drv/opengl.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/dlls/winex11.drv/opengl.c b/dlls/winex11.drv/opengl.c index d70f1928655..afedfb38af3 100644 --- a/dlls/winex11.drv/opengl.c +++ b/dlls/winex11.drv/opengl.c @@ -205,7 +205,6 @@ struct wgl_context GLXContext ctx; struct gl_drawable *drawables[2]; struct gl_drawable *new_drawables[2]; - BOOL refresh_drawables; struct list entry; }; @@ -1870,7 +1869,6 @@ static BOOL glxdrv_wglMakeCurrent(HDC hdc, struct wgl_context *ctx) ctx->has_been_current = TRUE; ctx->hdc = hdc; set_context_drawables( ctx, gl, gl ); - ctx->refresh_drawables = FALSE; pthread_mutex_unlock( &context_mutex ); goto done; } @@ -1915,7 +1913,6 @@ static BOOL X11DRV_wglMakeContextCurrentARB( HDC draw_hdc, HDC read_hdc, struct ctx->has_been_current = TRUE; ctx->hdc = draw_hdc; set_context_drawables( ctx, draw_gl, read_gl ); - ctx->refresh_drawables = FALSE; NtCurrentTeb()->glContext = ctx; pthread_mutex_unlock( &context_mutex ); goto done;

1 0

Rémi Bernon : winevulkan: Remove unnecessary WINEVULKAN_QUIRK_ADJUST_MAX_IMAGE_COUNT quirk.
by Alexandre Julliard 28 Feb '24

28 Feb '24

Module: wine Branch: master Commit: 72c228a3ab6913930d19b926a971cb93345113be URL: https://gitlab.winehq.org/wine/wine/-/commit/72c228a3ab6913930d19b926a971cb… Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Fri Feb 23 10:23:11 2024 +0100 winevulkan: Remove unnecessary WINEVULKAN_QUIRK_ADJUST_MAX_IMAGE_COUNT quirk. --- dlls/winevulkan/vulkan.c | 4 +--- dlls/winevulkan/vulkan_loader.h | 1 - 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/dlls/winevulkan/vulkan.c b/dlls/winevulkan/vulkan.c index de7f7282c4e..01d2a0c20a0 100644 --- a/dlls/winevulkan/vulkan.c +++ b/dlls/winevulkan/vulkan.c @@ -893,8 +893,6 @@ VkResult wine_vkCreateInstance(const VkInstanceCreateInfo *create_info, object->quirks |= WINEVULKAN_QUIRK_GET_DEVICE_PROC_ADDR; } - object->quirks |= WINEVULKAN_QUIRK_ADJUST_MAX_IMAGE_COUNT; - client_instance->base.unix_handle = (uintptr_t)object; *instance = client_instance; TRACE("Created instance %p, host_instance %p.\n", object, object->host_instance); @@ -1866,7 +1864,7 @@ static void adjust_surface_capabilities(struct wine_instance *instance, struct w * https://vulkan.gpuinfo.org/displayreport.php?id=9122#surface * https://vulkan.gpuinfo.org/displayreport.php?id=9121#surface */ - if ((instance->quirks & WINEVULKAN_QUIRK_ADJUST_MAX_IMAGE_COUNT) && !capabilities->maxImageCount) + if (!capabilities->maxImageCount) capabilities->maxImageCount = max(capabilities->minImageCount, 16); /* Update the image extents to match what the Win32 WSI would provide. */ diff --git a/dlls/winevulkan/vulkan_loader.h b/dlls/winevulkan/vulkan_loader.h index 6f62201f503..710c07772fc 100644 --- a/dlls/winevulkan/vulkan_loader.h +++ b/dlls/winevulkan/vulkan_loader.h @@ -39,7 +39,6 @@ #define VULKAN_ICD_MAGIC_VALUE 0x01CDC0DE #define WINEVULKAN_QUIRK_GET_DEVICE_PROC_ADDR 0x00000001 -#define WINEVULKAN_QUIRK_ADJUST_MAX_IMAGE_COUNT 0x00000002 /* Base 'class' for our Vulkan dispatchable objects such as VkDevice and VkInstance. * This structure MUST be the first element of a dispatchable object as the ICD

1 0

Esme Povirk : gdiplus: Fix crash in GdipAddPathString.
by Alexandre Julliard 28 Feb '24

28 Feb '24

Module: wine Branch: master Commit: 1ee1f2e9d78fb3c8da21618c8fef1b4129f200f3 URL: https://gitlab.winehq.org/wine/wine/-/commit/1ee1f2e9d78fb3c8da21618c8fef1b… Author: Esme Povirk <esme(a)codeweavers.com> Date: Wed Feb 28 16:40:50 2024 +0000 gdiplus: Fix crash in GdipAddPathString. Apparently, 1454ffe7ddf01226aacec07836d4afa62fecd3fa introduced the assumption that the font passed to gdip_format_string is non-NULL, and GdipAddPathString wasn't passing it in. --- dlls/gdiplus/graphicspath.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/dlls/gdiplus/graphicspath.c b/dlls/gdiplus/graphicspath.c index 54d9f252c2f..23a9be25055 100644 --- a/dlls/gdiplus/graphicspath.c +++ b/dlls/gdiplus/graphicspath.c @@ -1141,7 +1141,6 @@ GpStatus WINGDIPAPI GdipAddPathString(GpPath* path, GDIPCONST WCHAR* string, INT } get_log_fontW(font, graphics, &lfw); - GdipDeleteFont(font); GdipDeleteGraphics(graphics); hfont = CreateFontIndirectW(&lfw); @@ -1150,6 +1149,7 @@ GpStatus WINGDIPAPI GdipAddPathString(GpPath* path, GDIPCONST WCHAR* string, INT WARN("Failed to create font\n"); DeleteDC(dc); GdipDeletePath(backup); + GdipDeleteFont(font); return GenericError; } @@ -1161,11 +1161,12 @@ GpStatus WINGDIPAPI GdipAddPathString(GpPath* path, GDIPCONST WCHAR* string, INT args.maxY = 0; args.scale = emSize / native_height; args.ascent = textmetric.tmAscent * args.scale; - status = gdip_format_string(graphics, dc, string, length, NULL, &scaled_layout_rect, + status = gdip_format_string(graphics, dc, string, length, font, &scaled_layout_rect, format, TRUE, format_string_callback, &args); DeleteDC(dc); DeleteObject(hfont); + GdipDeleteFont(font); if (status != Ok) /* free backup */ {

1 0

Alexandre Julliard : winedump: Print the correct register names for exception info on ARM64.
by Alexandre Julliard 28 Feb '24

28 Feb '24

Module: wine Branch: master Commit: ebaa47dcee08cb58d407a8dd15323258e8e5aa79 URL: https://gitlab.winehq.org/wine/wine/-/commit/ebaa47dcee08cb58d407a8dd153232… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Feb 28 19:03:14 2024 +0100 winedump: Print the correct register names for exception info on ARM64. --- tools/winedump/pe.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tools/winedump/pe.c b/tools/winedump/pe.c index 1104072a2c2..d4bf46c5307 100644 --- a/tools/winedump/pe.c +++ b/tools/winedump/pe.c @@ -1424,15 +1424,15 @@ static void dump_arm64_codes( const BYTE *ptr, unsigned int count ) } else if (ptr[i] < 0x40) /* save_r19r20_x */ { - printf( "stp r19,r20,[sp,-#%#x]!\n", 8 * (val & 0x1f) ); + printf( "stp x19,x20,[sp,-#%#x]!\n", 8 * (val & 0x1f) ); } else if (ptr[i] < 0x80) /* save_fplr */ { - printf( "stp r29,lr,[sp,#%#x]\n", 8 * (val & 0x3f) ); + printf( "stp x29,lr,[sp,#%#x]\n", 8 * (val & 0x3f) ); } else if (ptr[i] < 0xc0) /* save_fplr_x */ { - printf( "stp r29,lr,[sp,-#%#x]!\n", 8 * (val & 0x3f) + 8 ); + printf( "stp x29,lr,[sp,-#%#x]!\n", 8 * (val & 0x3f) + 8 ); } else if (ptr[i] < 0xc8) /* alloc_m */ { @@ -1441,27 +1441,27 @@ static void dump_arm64_codes( const BYTE *ptr, unsigned int count ) else if (ptr[i] < 0xcc) /* save_regp */ { int reg = 19 + ((val >> 6) & 0xf); - printf( "stp r%u,r%u,[sp,#%#x]\n", reg, reg + 1, 8 * (val & 0x3f) ); + printf( "stp x%u,x%u,[sp,#%#x]\n", reg, reg + 1, 8 * (val & 0x3f) ); } else if (ptr[i] < 0xd0) /* save_regp_x */ { int reg = 19 + ((val >> 6) & 0xf); - printf( "stp r%u,r%u,[sp,-#%#x]!\n", reg, reg + 1, 8 * (val & 0x3f) + 8 ); + printf( "stp x%u,x%u,[sp,-#%#x]!\n", reg, reg + 1, 8 * (val & 0x3f) + 8 ); } else if (ptr[i] < 0xd4) /* save_reg */ { int reg = 19 + ((val >> 6) & 0xf); - printf( "str r%u,[sp,#%#x]\n", reg, 8 * (val & 0x3f) ); + printf( "str x%u,[sp,#%#x]\n", reg, 8 * (val & 0x3f) ); } else if (ptr[i] < 0xd6) /* save_reg_x */ { int reg = 19 + ((val >> 5) & 0xf); - printf( "str r%u,[sp,-#%#x]!\n", reg, 8 * (val & 0x1f) + 8 ); + printf( "str x%u,[sp,-#%#x]!\n", reg, 8 * (val & 0x1f) + 8 ); } else if (ptr[i] < 0xd8) /* save_lrpair */ { int reg = 19 + 2 * ((val >> 6) & 0x7); - printf( "stp r%u,lr,[sp,#%#x]\n", reg, 8 * (val & 0x3f) ); + printf( "stp x%u,lr,[sp,#%#x]\n", reg, 8 * (val & 0x3f) ); } else if (ptr[i] < 0xda) /* save_fregp */ {

1 0

Alexandre Julliard : ntdll: Remove no longer needed definitions from the private header.
by Alexandre Julliard 28 Feb '24

28 Feb '24

Module: wine Branch: master Commit: 3de0f99d4eec174a66faf454f55577636b46a523 URL: https://gitlab.winehq.org/wine/wine/-/commit/3de0f99d4eec174a66faf454f55577… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Feb 28 14:25:24 2024 +0100 ntdll: Remove no longer needed definitions from the private header. --- dlls/ntdll/loader.c | 2 +- dlls/ntdll/ntdll_misc.h | 13 +------------ 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c index 8f7097a2460..ef3fafd994c 100644 --- a/dlls/ntdll/loader.c +++ b/dlls/ntdll/loader.c @@ -138,7 +138,7 @@ typedef struct _wine_modref static UINT tls_module_count; /* number of modules with TLS directory */ static IMAGE_TLS_DIRECTORY *tls_dirs; /* array of TLS directories */ -LIST_ENTRY tls_links = { &tls_links, &tls_links }; +static LIST_ENTRY tls_links = { &tls_links, &tls_links }; static RTL_CRITICAL_SECTION loader_section; static RTL_CRITICAL_SECTION_DEBUG critsect_debug = diff --git a/dlls/ntdll/ntdll_misc.h b/dlls/ntdll/ntdll_misc.h index 50a3dde574c..24c583dd159 100644 --- a/dlls/ntdll/ntdll_misc.h +++ b/dlls/ntdll/ntdll_misc.h @@ -30,13 +30,6 @@ #include "unixlib.h" #include "wine/asm.h" -#define DECLARE_CRITICAL_SECTION(cs) \ - static RTL_CRITICAL_SECTION cs; \ - static RTL_CRITICAL_SECTION_DEBUG cs##_debug = \ - { 0, 0, &cs, { &cs##_debug.ProcessLocksList, &cs##_debug.ProcessLocksList }, \ - 0, 0, { (DWORD_PTR)(__FILE__ ": " # cs) }}; \ - static RTL_CRITICAL_SECTION cs = { &cs##_debug, -1, 0, 0, 0, 0 }; - #define MAX_NT_PATH_LENGTH 277 #define NTDLL_TLS_ERRNO 16 /* TLS slot for _errno() */ @@ -79,7 +72,7 @@ static inline BOOL is_valid_frame( ULONG_PTR frame ) } extern void WINAPI LdrInitializeThunk(CONTEXT*,ULONG_PTR,ULONG_PTR,ULONG_PTR); -extern NTSTATUS WINAPI KiUserExceptionDispatcher(EXCEPTION_RECORD*,CONTEXT*); +extern void WINAPI KiUserExceptionDispatcher(EXCEPTION_RECORD*,CONTEXT*); extern void WINAPI KiUserApcDispatcher(CONTEXT*,ULONG_PTR,ULONG_PTR,ULONG_PTR,PNTAPCFUNC); extern void WINAPI KiUserCallbackDispatcher(ULONG,void*,ULONG); extern void WINAPI KiUserCallbackDispatcherReturn(void); @@ -99,7 +92,6 @@ extern void init_user_process_params(void); extern void get_resource_lcids( LANGID *user, LANGID *user_neutral, LANGID *system ); /* module handling */ -extern LIST_ENTRY tls_links; extern FARPROC RELAY_GetProcAddress( HMODULE module, const IMAGE_EXPORT_DIRECTORY *exports, DWORD exp_size, FARPROC proc, DWORD ordinal, const WCHAR *user ); extern FARPROC SNOOP_GetProcAddress( HMODULE hmod, const IMAGE_EXPORT_DIRECTORY *exports, DWORD exp_size, @@ -113,9 +105,6 @@ extern void (FASTCALL *pBaseThreadInitThunk)(DWORD,LPTHREAD_START_ROUTINE,void * extern struct _KUSER_SHARED_DATA *user_shared_data; -extern int CDECL NTDLL__vsnprintf( char *str, SIZE_T len, const char *format, va_list args ); -extern int CDECL NTDLL__vsnwprintf( WCHAR *str, SIZE_T len, const WCHAR *format, va_list args ); - #ifdef _WIN64 static inline TEB64 *NtCurrentTeb64(void) { return NULL; } #else

1 0

← Newer
1
2
3
4
5
6
7
8
...
72
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits February 2024