winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
June 2024
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
1 participants
613 discussions
Start a n
N
ew thread
Rémi Bernon : win32u: Avoid setting the SWP_NOSIZE flag on the initial WM_DISPLAYCHANGE.
by Alexandre Julliard
17 Jun '24
17 Jun '24
Module: wine Branch: master Commit: 6b1becc3e0731357f81963c7630fbb2cf1ab2bfd URL:
https://gitlab.winehq.org/wine/wine/-/commit/6b1becc3e0731357f81963c7630fbb…
Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Mon Jun 17 10:31:15 2024 +0200 win32u: Avoid setting the SWP_NOSIZE flag on the initial WM_DISPLAYCHANGE. By initializing the desktop window proc virtual rect cache. Wine-Bug:
https://bugs.winehq.org/show_bug.cgi?id=56841
--- dlls/win32u/defwnd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/win32u/defwnd.c b/dlls/win32u/defwnd.c index f549f922fd7..003ba7c0846 100644 --- a/dlls/win32u/defwnd.c +++ b/dlls/win32u/defwnd.c @@ -2977,7 +2977,7 @@ LRESULT desktop_window_proc( HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam ) return 0; case WM_DISPLAYCHANGE: { - static RECT virtual_rect; + static RECT virtual_rect = {INT_MIN,INT_MIN,INT_MAX,INT_MAX}; RECT new_rect = NtUserGetVirtualScreenRect(), old_rect = virtual_rect; UINT context, flags = 0;
1
0
0
0
Rémi Bernon : winewayland: Avoid crashing when the dummy window surface is used.
by Alexandre Julliard
17 Jun '24
17 Jun '24
Module: wine Branch: master Commit: 1e701a6b3798ecfd688ad1ff405dbb62b3d214c6 URL:
https://gitlab.winehq.org/wine/wine/-/commit/1e701a6b3798ecfd688ad1ff405dbb…
Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Sat Jun 15 18:36:50 2024 +0200 winewayland: Avoid crashing when the dummy window surface is used. Wine-Bug:
https://bugs.winehq.org/show_bug.cgi?id=56840
--- dlls/winewayland.drv/window_surface.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/dlls/winewayland.drv/window_surface.c b/dlls/winewayland.drv/window_surface.c index fb3b8750001..888fa74c085 100644 --- a/dlls/winewayland.drv/window_surface.c +++ b/dlls/winewayland.drv/window_surface.c @@ -489,8 +489,12 @@ failed: void wayland_window_surface_update_wayland_surface(struct window_surface *window_surface, struct wayland_surface *wayland_surface) { - struct wayland_window_surface *wws = wayland_window_surface_cast(window_surface); + struct wayland_window_surface *wws; + + /* ignore calls with the dummy surface */ + if (window_surface->funcs != &wayland_window_surface_funcs) return; + wws = wayland_window_surface_cast(window_surface); window_surface_lock(window_surface); TRACE("surface=%p hwnd=%p wayland_surface=%p\n", wws, window_surface->hwnd, wayland_surface);
1
0
0
0
Alex Henrie : ntdll: Double-null-terminate multi-strings when using RTL_QUERY_REGISTRY_DIRECT.
by Alexandre Julliard
17 Jun '24
17 Jun '24
Module: wine Branch: master Commit: 2821a850d401dfabc5d76a4f40b0d6a42045fc5e URL:
https://gitlab.winehq.org/wine/wine/-/commit/2821a850d401dfabc5d76a4f40b0d6…
Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Fri Jun 14 23:26:38 2024 -0600 ntdll: Double-null-terminate multi-strings when using RTL_QUERY_REGISTRY_DIRECT. --- dlls/ntdll/reg.c | 3 +++ dlls/ntdll/tests/reg.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/dlls/ntdll/reg.c b/dlls/ntdll/reg.c index ec4ec41c5fb..41dd1853c17 100644 --- a/dlls/ntdll/reg.c +++ b/dlls/ntdll/reg.c @@ -321,13 +321,16 @@ static NTSTATUS RTL_ReportRegistryValue(PKEY_VALUE_FULL_INFORMATION pInfo, if (!(pQuery->Flags & RTL_QUERY_REGISTRY_NOEXPAND)) return STATUS_INVALID_PARAMETER; + len += sizeof(WCHAR); if (str->Buffer == NULL) { str->Buffer = RtlAllocateHeap(GetProcessHeap(), 0, len); str->MaximumLength = len; } len = min(len, str->MaximumLength); + len -= sizeof(WCHAR); memcpy(str->Buffer, ((CHAR*)pInfo) + pInfo->DataOffset, len); + str->Buffer[len / sizeof(WCHAR)] = 0; str->Length = len; break; diff --git a/dlls/ntdll/tests/reg.c b/dlls/ntdll/tests/reg.c index 50e32cf901a..85bcaf5ba7d 100644 --- a/dlls/ntdll/tests/reg.c +++ b/dlls/ntdll/tests/reg.c @@ -2686,7 +2686,7 @@ static struct query_reg_values_test query_reg_values_tests[] = { {{ NULL, RTL_QUERY_REGISTRY_DIRECT | RTL_QUERY_REGISTRY_NOEXPAND, (WCHAR*)L"CapitalsOfEurope", &query_reg_values_direct_str }}, - STATUS_SUCCESS, 0, WINE_TODO_DATA, REG_SZ, L"Brussels\0Paris\0%PATH%\0", sizeof(L"Brussels\0Paris\0%PATH%\0") + STATUS_SUCCESS, 0, 0, REG_SZ, L"Brussels\0Paris\0%PATH%\0", sizeof(L"Brussels\0Paris\0%PATH%\0") }, /* DIRECT with a null buffer crashes on Windows */ /* {
1
0
0
0
Alex Henrie : ntdll: Fix multi-string callbacks in RtlQueryRegistryValues.
by Alexandre Julliard
17 Jun '24
17 Jun '24
Module: wine Branch: master Commit: 0b51dbf7eb09e42b9b5b079c82aade8252581b7e URL:
https://gitlab.winehq.org/wine/wine/-/commit/0b51dbf7eb09e42b9b5b079c82aade…
Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Fri Jun 14 23:26:38 2024 -0600 ntdll: Fix multi-string callbacks in RtlQueryRegistryValues. --- dlls/ntdll/reg.c | 39 ++++++--------------------------------- dlls/ntdll/tests/reg.c | 14 +++++++------- 2 files changed, 13 insertions(+), 40 deletions(-) diff --git a/dlls/ntdll/reg.c b/dlls/ntdll/reg.c index 3cbd055f367..ec4ec41c5fb 100644 --- a/dlls/ntdll/reg.c +++ b/dlls/ntdll/reg.c @@ -250,8 +250,6 @@ static NTSTATUS RTL_ReportRegistryValue(PKEY_VALUE_FULL_INFORMATION pInfo, DWORD res; NTSTATUS status = STATUS_SUCCESS; ULONG len; - LPWSTR String; - ULONG count = 0; if (pInfo == NULL) { @@ -381,38 +379,13 @@ static NTSTATUS RTL_ReportRegistryValue(PKEY_VALUE_FULL_INFORMATION pInfo, } else /* REG_MULTI_SZ */ { - if(pQuery->Flags & RTL_QUERY_REGISTRY_NOEXPAND) + for (offset = 0; offset < pInfo->DataLength; offset += len) { - for (offset = 0; offset <= pInfo->DataLength; offset += len + sizeof(WCHAR)) - { - wstr = (WCHAR*)(((CHAR*)pInfo) + offset); - len = wcslen(wstr) * sizeof(WCHAR); - status = pQuery->QueryRoutine(pQuery->Name, pInfo->Type, wstr, len, - pContext, pQuery->EntryContext); - if(status != STATUS_SUCCESS && status != STATUS_BUFFER_TOO_SMALL) - return status; - } - } - else - { - while(count<=pInfo->DataLength) - { - String = (WCHAR*)(((CHAR*)pInfo) + pInfo->DataOffset)+count; - count+=wcslen(String)+1; - RtlInitUnicodeString(&src, (WCHAR*)(((CHAR*)pInfo) + pInfo->DataOffset)); - res = 0; - dst.MaximumLength = 0; - RtlExpandEnvironmentStrings_U(pEnvironment, &src, &dst, &res); - dst.Length = 0; - dst.MaximumLength = res; - dst.Buffer = RtlAllocateHeap(GetProcessHeap(), 0, res * sizeof(WCHAR)); - RtlExpandEnvironmentStrings_U(pEnvironment, &src, &dst, &res); - status = pQuery->QueryRoutine(pQuery->Name, pInfo->Type, dst.Buffer, - dst.Length, pContext, pQuery->EntryContext); - RtlFreeHeap(GetProcessHeap(), 0, dst.Buffer); - if(status != STATUS_SUCCESS && status != STATUS_BUFFER_TOO_SMALL) - return status; - } + wstr = (WCHAR*)((char*)pInfo + pInfo->DataOffset + offset); + len = (wcslen(wstr) + 1) * sizeof(WCHAR); + status = pQuery->QueryRoutine(pQuery->Name, REG_SZ, wstr, len, pContext, pQuery->EntryContext); + if (status != STATUS_SUCCESS && status != STATUS_BUFFER_TOO_SMALL) + return status; } } } diff --git a/dlls/ntdll/tests/reg.c b/dlls/ntdll/tests/reg.c index 14227db755c..50e32cf901a 100644 --- a/dlls/ntdll/tests/reg.c +++ b/dlls/ntdll/tests/reg.c @@ -2644,7 +2644,7 @@ static struct query_reg_values_test query_reg_values_tests[] = /* The query routine is called for every value in current key */ { {{ query_routine }}, - STATUS_SUCCESS, 4, SKIP_NAME_CHECK | SKIP_DATA_CHECK | WINE_TODO_CALLS + STATUS_SUCCESS, 4, SKIP_NAME_CHECK | SKIP_DATA_CHECK }, /* NOVALUE is ignored when the name is not null */ { @@ -2686,7 +2686,7 @@ static struct query_reg_values_test query_reg_values_tests[] = { {{ NULL, RTL_QUERY_REGISTRY_DIRECT | RTL_QUERY_REGISTRY_NOEXPAND, (WCHAR*)L"CapitalsOfEurope", &query_reg_values_direct_str }}, - STATUS_SUCCESS, 0, WINE_TODO_DATA, REG_SZ, L"Brussels\0Paris\0Madrid\0", sizeof(L"Brussels\0Paris\0Madrid\0") + STATUS_SUCCESS, 0, WINE_TODO_DATA, REG_SZ, L"Brussels\0Paris\0%PATH%\0", sizeof(L"Brussels\0Paris\0%PATH%\0") }, /* DIRECT with a null buffer crashes on Windows */ /* { @@ -2710,14 +2710,14 @@ static struct query_reg_values_test query_reg_values_tests[] = {{ query_routine, RTL_QUERY_REGISTRY_NOEXPAND, (WCHAR*)L"WindowsDrive" }}, STATUS_SUCCESS, 1, 0, REG_EXPAND_SZ, L"%SYSTEMDRIVE%" }, - /* NOEXPAND calls the query routine once for each string in a multi-string */ + /* NOEXPAND calls the query routine only once instead of once for each string in a multi-string */ { {{ query_routine, 0, (WCHAR*)L"CapitalsOfEurope" }}, - STATUS_SUCCESS, 3, SPLIT_MULTI | WINE_TODO_CALLS | WINE_TODO_TYPE | WINE_TODO_SIZE | WINE_TODO_DATA, REG_SZ, L"Brussels\0Paris\0Madrid\0" + STATUS_SUCCESS, 3, SPLIT_MULTI, REG_SZ, L"Brussels\0Paris\0%PATH%\0" }, { {{ query_routine, RTL_QUERY_REGISTRY_NOEXPAND, (WCHAR*)L"CapitalsOfEurope" }}, - STATUS_SUCCESS, 1, WINE_TODO_SIZE, REG_MULTI_SZ, L"Brussels\0Paris\0Madrid\0", sizeof(L"Brussels\0Paris\0Madrid\0") + STATUS_SUCCESS, 1, WINE_TODO_SIZE, REG_MULTI_SZ, L"Brussels\0Paris\0%PATH%\0", sizeof(L"Brussels\0Paris\0%PATH%\0") }, /* The default value is used if the registry value does not exist */ { @@ -2733,7 +2733,7 @@ static struct query_reg_values_test query_reg_values_tests[] = STATUS_SUCCESS, 1, WINE_TODO_TYPE | WINE_TODO_SIZE, REG_SZ, L"C:" }, { - {{ query_routine, 0, (WCHAR*)L"I don't exist", NULL, REG_MULTI_SZ, (WCHAR*)L"Brussels\0Paris\0Madrid\0" }}, + {{ query_routine, 0, (WCHAR*)L"I don't exist", NULL, REG_MULTI_SZ, (WCHAR*)L"Brussels\0Paris\0%PATH%\0" }}, STATUS_SUCCESS, 3, EXPECT_DEFAULT_DATA | SPLIT_MULTI | WINE_TODO_CALLS | WINE_TODO_TYPE | WINE_TODO_SIZE }, { @@ -2818,7 +2818,7 @@ static void test_RtlQueryRegistryValues(void) ok(status == ERROR_SUCCESS, "Failed to create registry value WindowsDrive: %lu\n", status); status = RegSetKeyValueW(HKEY_CURRENT_USER, L"WineTest", L"CapitalsOfEurope", REG_MULTI_SZ, - L"Brussels\0Paris\0Madrid", sizeof(L"Brussels\0Paris\0Madrid")); + L"Brussels\0Paris\0%PATH%", sizeof(L"Brussels\0Paris\0%PATH%")); ok(status == ERROR_SUCCESS, "Failed to create registry value CapitalsOfEurope: %lu\n", status); status = RegSetKeyValueW(HKEY_CURRENT_USER, L"WineTest\\subkey", L"Color", REG_SZ,
1
0
0
0
Esme Povirk : user32/tests: Fix spurious "Failed sequence" reports on Windows.
by Alexandre Julliard
17 Jun '24
17 Jun '24
Module: wine Branch: master Commit: a11e2bc8c81481043fc13ea1a32c85d5a6fa35e7 URL:
https://gitlab.winehq.org/wine/wine/-/commit/a11e2bc8c81481043fc13ea1a32c85…
Author: Esme Povirk <esme(a)codeweavers.com> Date: Sat Jun 15 19:37:27 2024 +0000 user32/tests: Fix spurious "Failed sequence" reports on Windows. --- dlls/user32/tests/msg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c index 71da1494291..398bb0a69ed 100644 --- a/dlls/user32/tests/msg.c +++ b/dlls/user32/tests/msg.c @@ -2666,6 +2666,8 @@ static BOOL can_skip_message(const struct message *expected) if ((expected->flags & msg_todo) && !strcmp(winetest_platform, "wine")) return TRUE; + if ((expected->flags & wine_only) && strcmp(winetest_platform, "wine")) return TRUE; + return FALSE; }
1
0
0
0
Davide Beatrici : winepulse: Don't set a floor for the period(s).
by Alexandre Julliard
17 Jun '24
17 Jun '24
Module: wine Branch: master Commit: 28818e6bd58512530b339a1a9232af82c252c7c9 URL:
https://gitlab.winehq.org/wine/wine/-/commit/28818e6bd58512530b339a1a9232af…
Author: Davide Beatrici <git(a)davidebeatrici.dev> Date: Fri Jun 7 20:12:58 2024 +0200 winepulse: Don't set a floor for the period(s). This driver, unlike the others, queries the engine for the actual device period. The default period floor is not needed anymore because it now lives in mmdevapi. The minimum period floor never mattered because exclusive mode is not supported. --- dlls/winepulse.drv/pulse.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/dlls/winepulse.drv/pulse.c b/dlls/winepulse.drv/pulse.c index dd8d0b4441d..068245f03b2 100644 --- a/dlls/winepulse.drv/pulse.c +++ b/dlls/winepulse.drv/pulse.c @@ -113,9 +113,6 @@ static pa_mainloop *pulse_ml; static struct list g_phys_speakers = LIST_INIT(g_phys_speakers); static struct list g_phys_sources = LIST_INIT(g_phys_sources); -static const REFERENCE_TIME MinimumPeriod = 30000; -static const REFERENCE_TIME DefaultPeriod = 100000; - static pthread_mutex_t pulse_mutex; static pthread_cond_t pulse_cond = PTHREAD_COND_INITIALIZER; @@ -750,12 +747,6 @@ static void pulse_probe_settings(int render, const char *pulse_name, WAVEFORMATE if (length) *def_period = *min_period = pa_bytes_to_usec(10 * length, &ss); - if (*min_period < MinimumPeriod) - *min_period = MinimumPeriod; - - if (*def_period < DefaultPeriod) - *def_period = DefaultPeriod; - wfx->wFormatTag = WAVE_FORMAT_EXTENSIBLE; wfx->cbSize = sizeof(WAVEFORMATEXTENSIBLE) - sizeof(WAVEFORMATEX);
1
0
0
0
Davide Beatrici : mmdevapi: Set the default period to a minimum of 10 ms.
by Alexandre Julliard
17 Jun '24
17 Jun '24
Module: wine Branch: master Commit: 86ac5f5638f90388d5f484aea1cb8e0b1c945e4c URL:
https://gitlab.winehq.org/wine/wine/-/commit/86ac5f5638f90388d5f484aea1cb8e…
Author: Davide Beatrici <git(a)davidebeatrici.dev> Date: Fri Jun 14 22:41:15 2024 +0200 mmdevapi: Set the default period to a minimum of 10 ms. --- dlls/mmdevapi/client.c | 55 ++++++++++++++++++++++++++------------------------ 1 file changed, 29 insertions(+), 26 deletions(-) diff --git a/dlls/mmdevapi/client.c b/dlls/mmdevapi/client.c index 0b849e47e3d..ed635bcf98a 100644 --- a/dlls/mmdevapi/client.c +++ b/dlls/mmdevapi/client.c @@ -99,25 +99,36 @@ static inline struct audio_client *impl_from_IAudioStreamVolume(IAudioStreamVolu return CONTAINING_RECORD(iface, struct audio_client, IAudioStreamVolume_iface); } -static HRESULT adjust_timing(struct audio_client *This, +static HRESULT get_periods(struct audio_client *client, + REFERENCE_TIME *def_period, REFERENCE_TIME *min_period) +{ + static const REFERENCE_TIME min_def_period = 100000; /* 10 ms */ + struct get_device_period_params params; + + params.device = client->device_name; + params.flow = client->dataflow; + params.def_period = def_period; + params.min_period = min_period; + + wine_unix_call(get_device_period, ¶ms); + + if (def_period) *def_period = max(*def_period, min_def_period); + + return params.result; +} + +static HRESULT adjust_timing(struct audio_client *client, REFERENCE_TIME *duration, REFERENCE_TIME *period, const AUDCLNT_SHAREMODE mode, const DWORD flags, const WAVEFORMATEX *fmt) { - struct get_device_period_params params; REFERENCE_TIME def_period, min_period; + HRESULT hr; TRACE("Requested duration %lu and period %lu\n", (ULONG)*duration, (ULONG)*period); - params.device = This->device_name; - params.flow = This->dataflow; - params.def_period = &def_period; - params.min_period = &min_period; - - wine_unix_call(get_device_period, ¶ms); - - if (FAILED(params.result)) - return params.result; + if (FAILED(hr = get_periods(client, &def_period, &min_period))) + return hr; TRACE("Device periods: %lu default and %lu minimum\n", (ULONG)def_period, (ULONG)min_period); @@ -129,21 +140,21 @@ static HRESULT adjust_timing(struct audio_client *This, const WAVEFORMATEXTENSIBLE *fmtex = (WAVEFORMATEXTENSIBLE *)fmt; if (fmtex->Format.wFormatTag == WAVE_FORMAT_EXTENSIBLE && (fmtex->dwChannelMask == 0 || fmtex->dwChannelMask & SPEAKER_RESERVED)) - params.result = AUDCLNT_E_UNSUPPORTED_FORMAT; + hr = AUDCLNT_E_UNSUPPORTED_FORMAT; else { if (*period == 0) *period = def_period; if (*period < min_period || *period > 5000000) - params.result = AUDCLNT_E_INVALID_DEVICE_PERIOD; + hr = AUDCLNT_E_INVALID_DEVICE_PERIOD; else if (*duration > 20000000) /* The smaller the period, the lower this limit. */ - params.result = AUDCLNT_E_BUFFER_SIZE_ERROR; + hr = AUDCLNT_E_BUFFER_SIZE_ERROR; else if (flags & AUDCLNT_STREAMFLAGS_EVENTCALLBACK) { if (*duration != *period) - params.result = AUDCLNT_E_BUFDURATION_PERIOD_NOT_EQUAL; + hr = AUDCLNT_E_BUFDURATION_PERIOD_NOT_EQUAL; FIXME("EXCLUSIVE mode with EVENTCALLBACK\n"); - params.result = AUDCLNT_E_DEVICE_IN_USE; + hr = AUDCLNT_E_DEVICE_IN_USE; } else if (*duration < 8 * *period) *duration = 8 * *period; /* May grow above 2s. */ } @@ -151,7 +162,7 @@ static HRESULT adjust_timing(struct audio_client *This, TRACE("Adjusted duration %lu and period %lu\n", (ULONG)*duration, (ULONG)*period); - return params.result; + return hr; } static void dump_fmt(const WAVEFORMATEX *fmt) @@ -748,21 +759,13 @@ static HRESULT WINAPI client_GetDevicePeriod(IAudioClient3 *iface, REFERENCE_TIM REFERENCE_TIME *minperiod) { struct audio_client *This = impl_from_IAudioClient3(iface); - struct get_device_period_params params; TRACE("(%p)->(%p, %p)\n", This, defperiod, minperiod); if (!defperiod && !minperiod) return E_POINTER; - params.device = This->device_name; - params.flow = This->dataflow; - params.def_period = defperiod; - params.min_period = minperiod; - - wine_unix_call(get_device_period, ¶ms); - - return params.result; + return get_periods(This, defperiod, minperiod); } static HRESULT WINAPI client_Start(IAudioClient3 *iface)
1
0
0
0
Giovanni Mascellani : ci: Assume an Apple Silicon-based environment for the macOS CI job.
by Alexandre Julliard
17 Jun '24
17 Jun '24
Module: vkd3d Branch: master Commit: 46a1b66df74f34693eed06859944f584a0ec2711 URL:
https://gitlab.winehq.org/wine/vkd3d/-/commit/46a1b66df74f34693eed06859944f…
Author: Giovanni Mascellani <gmascellani(a)codeweavers.com> Date: Wed Jun 12 15:51:22 2024 +0200 ci: Assume an Apple Silicon-based environment for the macOS CI job. The previous Intel-based macOS runner was replaced with another one running as a virtual machine on top of an Apple Silicon host. Since the current macOS runner is not yet able to deal with different exit codes, we temporarily allow failure unconditionally. This will be reverted as soon as the runner issue is fixed. --- gitlab/build-mac | 2 +- gitlab/build.yml | 24 ++++++++++++------------ gitlab/image.yml | 28 +++++++++++++++++++++------- gitlab/patch_moltenvk_icd.sh | 12 ------------ 4 files changed, 34 insertions(+), 32 deletions(-) diff --git a/gitlab/build-mac b/gitlab/build-mac index c0efbdf0..5d7d5845 100755 --- a/gitlab/build-mac +++ b/gitlab/build-mac @@ -10,7 +10,7 @@ set -Eeuxo pipefail rm -fr build mkdir build cd build -if ../configure CFLAGS="-g -O2 -Wno-implicit-fallthrough -Werror" && \ +if ../configure CFLAGS="-I/opt/homebrew/opt/vulkan-headers/include -I/opt/homebrew/opt/spirv-headers/include -g -O2 -Wno-implicit-fallthrough -Wno-ignored-attributes -Wno-unknown-attributes -Wno-unused-but-set-variable -Werror" VULKAN_LIBS=-L/opt/homebrew/opt/vulkan-loader/lib --with-spirv-tools && \ make -j$(sysctl -n hw.ncpu) ; then make -j$(sysctl -n hw.ncpu) AM_COLOR_TESTS=always check || \ touch ../tests_failed diff --git a/gitlab/build.yml b/gitlab/build.yml index fb8a6879..c6ce6b62 100644 --- a/gitlab/build.yml +++ b/gitlab/build.yml @@ -137,9 +137,11 @@ build-mac: stage: build rules: - if: $CI_PIPELINE_SOURCE == 'merge_request_event' - allow_failure: - exit_codes: - - 2 + image: winehq-sonoma-pristine + variables: + TART_EXECUTOR_SSH_USERNAME: "gitlab" + TART_EXECUTOR_SSH_PASSWORD: "gitlab" + allow_failure: true interruptible: true needs: - job: image-mac @@ -148,28 +150,26 @@ build-mac: tags: - mac script: + - brew install vulkan-tools libtool spirv-headers vulkan-loader - git config --global --add safe.directory $CI_PROJECT_DIR - git clean -fdx - git reset --hard - rm -fr .git/rebase-merge - # We use a custom ICD which is not marked as a portability driver, - # so that test programs are not confused. - - ./gitlab/patch_moltenvk_icd.sh - - export VK_DRIVER_FILES="$PWD/gitlab/MoltenVK_icd.json" + - curl -o image.zip
https://gitlab.winehq.org/api/v4/projects/giomasce%2Fvkd3d/jobs/artifacts/c…
+ - unzip image.zip - mkdir artifacts + - export PATH="/opt/homebrew/opt/bison/bin:/opt/homebrew/opt/flex/bin:$PWD/image/bin:$PATH" + - export VK_DRIVER_FILES="$PWD/image/moltenvk/MoltenVK_icd.json" - system_profiler SPSoftwareDataType SPHardwareDataType > artifacts/systeminfo.txt - vulkaninfo > artifacts/vulkaninfo.txt - - export PATH="/usr/local/opt/bison/bin:/usr/local/opt/flex/bin:$PATH" - - curl -o image.zip
https://gitlab.winehq.org/api/v4/projects/wine%2Fvkd3d/jobs/artifacts/maste…
- - unzip image.zip - - export PATH="$PWD/image/bin:$PATH" - git rebase $CI_MERGE_REQUEST_DIFF_BASE_SHA --exec ./gitlab/build-mac - if [ -f build_failed ] ; then exit 1 ; fi - if [ -f tests_failed ] ; then exit 2 ; fi variables: VKD3D_DISABLE_EXTENSIONS: "VK_EXT_descriptor_indexing" VKD3D_SHADER_CONFIG: 'force_validation' - MVK_CONFIG_LOG_LEVEL: 1 + MVK_CONFIG_LOG_LEVEL: 2 + SONAME_LIBVULKAN: "/opt/homebrew/opt/vulkan-loader/lib/libvulkan.1.dylib" artifacts: when: always paths: diff --git a/gitlab/image.yml b/gitlab/image.yml index 8b235a66..5cf64d07 100644 --- a/gitlab/image.yml +++ b/gitlab/image.yml @@ -31,24 +31,38 @@ image-mac: - .gitlab-ci.yml - gitlab/image.yml - gitlab/image.docker + image: winehq-sonoma-pristine + variables: + TART_EXECUTOR_SSH_USERNAME: "gitlab" + TART_EXECUTOR_SSH_PASSWORD: "gitlab" interruptible: true tags: - mac script: - mkdir image - - cd image - - mkdir bin + - mkdir image/bin + - mkdir image/moltenvk - export PATH="/usr/local/opt/bison/bin:/usr/local/opt/flex/bin:$PATH" + + - git clone --depth 1 --branch v1.2.9
https://github.com/KhronosGroup/MoltenVK.git
+ - cd MoltenVK + - ./fetchDependencies --macos + - make macos + # Do not mark MoltenVK as a portability driver, otherwise it will be harder for vkd3d to find + # it. Since editing JSON properly is hard, we just rename the key. + - 'sed -i -e "s|is_portability_driver|_is_portability_driver|g" Package/Release/MoltenVK/dylib/macOS/MoltenVK_icd.json' + - cd .. + - cp MoltenVK/Package/Release/MoltenVK/dylib/macOS/MoltenVK_icd.json image/moltenvk + - cp MoltenVK/Package/Release/MoltenVK/dylib/macOS/libMoltenVK.dylib image/moltenvk + - git clone --depth 1 --branch wine-3.21
https://gitlab.winehq.org/wine/wine.git
- cd wine - mkdir build - cd build - - ../configure --enable-win64 --without-x --without-freetype - - make tools/widl/widl + - arch -x86_64 ../configure --enable-win64 --without-x --without-freetype + - arch -x86_64 make tools/widl/widl - cd ../.. - - cp wine/build/tools/widl/widl bin - - rm -fr wine - - cd .. + - cp wine/build/tools/widl/widl image/bin artifacts: paths: - image diff --git a/gitlab/patch_moltenvk_icd.sh b/gitlab/patch_moltenvk_icd.sh deleted file mode 100755 index ad90a4ea..00000000 --- a/gitlab/patch_moltenvk_icd.sh +++ /dev/null @@ -1,12 +0,0 @@ -#!/bin/bash - -BASE_PATH="/usr/local/opt/molten-vk/share/vulkan/icd.d" - -cp "$BASE_PATH/MoltenVK_icd.json" gitlab/MoltenVK_icd.json - -# The driver path is relative -sed -i -e 's|"library_path" *: "|"library_path" : "'"$BASE_PATH/"'|g' gitlab/MoltenVK_icd.json - -# We pretend this is not a portability driver, otherwise vkd3d won't -# find it -sed -i -e 's|"is_portability_driver" *: *true|"is_portability_driver" : false|g' gitlab/MoltenVK_icd.json
1
0
0
0
Tag wine-9.11 : Alexandre Julliard : Release 9.11
by Alexandre Julliard
14 Jun '24
14 Jun '24
Module: wine Branch: refs/tags/wine-9.11 Tag: 49c7765b5e2b06d1dcd4d14e6c487b41876653e3 URL:
https://gitlab.winehq.org/wine/wine/-/tags/49c7765b5e2b06d1dcd4d14e6c487b41…
Tagger: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Jun 14 23:30:18 2024 +0200 Release 9.11
1
0
0
0
Alexandre Julliard : Release 9.11.
by Alexandre Julliard
14 Jun '24
14 Jun '24
Module: wine Branch: master Commit: 63e25f9edaf319529e87b380d01bff5cafa17f06 URL:
https://gitlab.winehq.org/wine/wine/-/commit/63e25f9edaf319529e87b380d01bff…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Jun 14 23:30:18 2024 +0200 Release 9.11. --- ANNOUNCE.md | 674 ++++++++++++++++++++++++++++++------------------------------ AUTHORS | 5 + VERSION | 2 +- configure | 18 +- 4 files changed, 357 insertions(+), 342 deletions(-)
1
0
0
0
← Newer
1
...
29
30
31
32
33
34
35
...
62
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
Results per page:
10
25
50
100
200