Francois Gouget : winetest/dissect: Improve the documentation of the missing start line handling.

[Alexandre Julliard]

Module: tools
Branch: master
Commit: 7846c95f79bdbde997f62a6ae5a5facdbeb50186
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=7846c95f79bdbde997f62a6a...

Author: Francois Gouget 
Date:   Fri Jan 29 06:20:10 2021 +0100

winetest/dissect: Improve the documentation of the missing start line handling.

Signed-off-by: Francois Gouget 
Signed-off-by: Alexandre Julliard

---

winetest/dissect | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/winetest/dissect b/winetest/dissect
index e9729db..27bcf17 100755
--- a/winetest/dissect
+++ b/winetest/dissect
@@ -717,23 +717,28 @@ while ($line = <IN>) {

if ($l_dll ne $dll or $l_unit ne $unit)
         {
-            # First close the current test unit taking into account
-            # it may have been polluted by the new one.
+            # Warn about the missing start line in the current test unit box.
             add_test_line("end", "The $l_dll:$l_unit start line is missing (or it is garbled)");
             $extra_failures++;
+
+            # And close the current test unit taking into account
+            # it may have been polluted by the new one.
             $broken = 1;
             close_test_unit(0);

-            # Then switch to the new one, warning it's missing a start line,
-            # and that its results may be inconsistent.
+            # Then switch to the new test unit, not for the past lines, but for
+            # those before the next 'start' line. This 'new' test unit may have
+            # inconsistent results too.
             ($dll, $unit, $source, $rev) = ($l_dll, $l_unit, "-", "-");
             %units = ($unit => 1);
             $units_re = $unit;
+            $broken = 1;

$testbox = create_test_unit_box();
+            # Finally, warn about the missing start line in the new test unit
+            # box.
             add_test_line("end", "The $l_dll:$l_unit start line is missing (or it is garbled)");
             $extra_failures++;
-            $broken = 1;
         }

my $class = $l_rc ? "failed" : "";