Module: vkd3d Branch: master Commit: bb2fa97c33fd1591097741b809854763c0623697 URL: https://gitlab.winehq.org/wine/vkd3d/-/commit/bb2fa97c33fd1591097741b8098547...
Author: Giovanni Mascellani gmascellani@codeweavers.com Date: Thu Feb 9 12:16:34 2023 +0100
vkd3d: Do not keep the CS queue locked while processing it.
d3d12_command_queue_flush_ops() can renter itself while processing signal events. Since we don't use recursive mutexes, we currently have to check some of the queue variables without holding the mutex, which is not safe.
This is solved by allowing the queue to release its mutex while it is processing entries: when flushing, the queue is briefly locked, the is_flushing flag is set, the queue content is copied away and the queue is unlocked again. After having processed the entries, the queue is locked again to check is something else was added in the meantime. This is repeated until the queue is empty (or a wait operation is blocking it).
This should also remove some latency when a thread pushes to the queue while another one is processing it, but I didn't try to measure any impact. While it is expected that with this patch the queue mutex will be locked and unlocked more frequently, it should also remain locked for less time, hopefully creating little contention.
---
libs/vkd3d/command.c | 170 +++++++++++++++++++++++++++++++-------------- libs/vkd3d/vkd3d_private.h | 18 ++++- 2 files changed, 134 insertions(+), 54 deletions(-)