Francois Gouget : testbot/web: Tweak the failures page columns.

[Alexandre Julliard]

Module: tools
Branch: master
Commit: e49b4c5231fca6973fe70b86c4c2435987cc9a7d
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=e49b4c5231fca6973fe70b86...

Author: Francois Gouget 
Date:   Thu Jun 16 17:18:23 2022 +0200

testbot/web: Tweak the failures page columns.

Show the bug id in the failure list: this makes it easier to find all
the failures related to a given bug.
Shorten some column labels so they don't make the column too wide.

Signed-off-by: Francois Gouget 
Signed-off-by: Alexandre Julliard

---

testbot/lib/WineTestBot/Failures.pm | 6 +++---
 testbot/web/FailuresList.pl         | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/testbot/lib/WineTestBot/Failures.pm b/testbot/lib/WineTestBot/Failures.pm
index b37b9e04..344af756 100644
--- a/testbot/lib/WineTestBot/Failures.pm
+++ b/testbot/lib/WineTestBot/Failures.pm
@@ -156,9 +156,9 @@ my @PropertyDescriptors = (
   # Every entry must be associated with a Wine bug.
   # Note: The 'deleted' bug status means this failure entry should be
   # deleted as soon as it is not referenced anymore.
-  CreateBasicPropertyDescriptor("BugId", "WineHQ bug id", !1, 1, "N", 10),
-  CreateBasicPropertyDescriptor("BugStatus", "WineHQ bug status", !1, !1, "A", 32),
-  CreateBasicPropertyDescriptor("BugDescription", "WineHQ bug description", !1, !1, "A", 128),
+  CreateBasicPropertyDescriptor("BugId", "Bug id", !1, 1, "N", 10),
+  CreateBasicPropertyDescriptor("BugStatus", "Bug status", !1, !1, "A", 32),
+  CreateBasicPropertyDescriptor("BugDescription", "WineHQ Bug description", !1, !1, "A", 128),

CreateDetailrefPropertyDescriptor("TaskFailures", "Tasks", &CreateTaskFailures),
 );
diff --git a/testbot/web/FailuresList.pl b/testbot/web/FailuresList.pl
index f2608dc4..f763413f 100644
--- a/testbot/web/FailuresList.pl
+++ b/testbot/web/FailuresList.pl
@@ -55,7 +55,7 @@ sub DisplayProperty($$)
   my ($self, $PropertyDescriptor) = @_;

my $PropertyName = $PropertyDescriptor->GetName();
-  return $PropertyName =~ /^(?:Notes|ConfigRegExp|FailureRegExp|BugId)$/ ? "" :
+  return $PropertyName =~ /^(?:Notes|ConfigRegExp|FailureRegExp)$/ ? "" :
          $self->SUPER::DisplayProperty($PropertyDescriptor);
 }

@@ -79,7 +79,7 @@ sub GenerateDataView($$$)
   my ($self, $Row, $Col) = @_;

my $PropertyName = $Col->{Descriptor}->GetName();
-  if ($PropertyName =~ /^Test(?:Module|Unit)$/)
+  if ($PropertyName eq "TestUnit")
   {
     print "<a href='", $self->escapeHTML($self->GetDetailsLink($Row)), "'>",
           $self->escapeHTML($Row->{Item}->$PropertyName), "</a>";