Hugh McMaster : regedit: Allow export_key() to return TRUE.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: f5fe9a6cf9121004ecdf5c0b285fcd88ec8a0d94
URL:    https://gitlab.winehq.org/wine/wine/-/commit/f5fe9a6cf9121004ecdf5c0b285fcd8...

Author: Hugh McMaster 
Date:   Thu Mar  9 21:22:48 2023 +1100

regedit: Allow export_key() to return TRUE.

We don't handle errors in export_registry_data() anyway.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54491

---

programs/regedit/framewnd.c | 2 +-
 programs/regedit/regproc.c  | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/programs/regedit/framewnd.c b/programs/regedit/framewnd.c
index d821d4dad77..3bc60ee0f75 100644
--- a/programs/regedit/framewnd.c
+++ b/programs/regedit/framewnd.c
@@ -500,7 +500,7 @@ static BOOL ExportRegistryFile(HWND hWnd)
         BOOL result;
         result = export_registry_key(ofn.lpstrFile, (LPWSTR)ofn.lCustData, ofn.nFilterIndex);
         if (!result) {
-            /*printf("Can't open file "%s"\n", ofn.lpstrFile);*/
+            FIXME("Registry export failed.\n");
             return FALSE;
         }
     } else {
diff --git a/programs/regedit/regproc.c b/programs/regedit/regproc.c
index 4f84c5883be..30106380241 100644
--- a/programs/regedit/regproc.c
+++ b/programs/regedit/regproc.c
@@ -1328,7 +1328,7 @@ static void export_key_name(FILE *fp, WCHAR *name, BOOL unicode)

#define MAX_SUBKEY_LEN   257

-static int export_registry_data(FILE *fp, HKEY key, WCHAR *path, BOOL unicode)
+static void export_registry_data(FILE *fp, HKEY key, WCHAR *path, BOOL unicode)
 {
     LONG rc;
     DWORD max_value_len = 256, value_len;
@@ -1398,7 +1398,6 @@ static int export_registry_data(FILE *fp, HKEY key, WCHAR *path, BOOL unicode)
     }

free(subkey_name);
-    return 0;
 }

static FILE *REGPROC_open_export_file(WCHAR *file_name, BOOL unicode)
@@ -1450,7 +1449,6 @@ static BOOL export_key(WCHAR *file_name, WCHAR *path, BOOL unicode)
     HKEY key_class, key;
     WCHAR *subkey;
     FILE *fp;
-    BOOL ret;

if (!(key_class = parse_key_name(path, &subkey)))
     {
@@ -1463,12 +1461,12 @@ static BOOL export_key(WCHAR *file_name, WCHAR *path, BOOL unicode)
         return FALSE;

fp = REGPROC_open_export_file(file_name, unicode);
-    ret = export_registry_data(fp, key, path, unicode);
+    export_registry_data(fp, key, path, unicode);
     export_newline(fp, unicode);
     fclose(fp);

RegCloseKey(key);
-    return ret;
+    return TRUE;
 }

static BOOL export_all(WCHAR *file_name, WCHAR *path, BOOL unicode)