Module: wine Branch: master Commit: 7562292ceae1b36b5e7ac2402ac0fba7486acd7a URL: https://gitlab.winehq.org/wine/wine/-/commit/7562292ceae1b36b5e7ac2402ac0fba...
Author: Eric Pouech epouech@codeweavers.com Date: Tue Nov 7 19:12:39 2023 +0100
user32: Use SecureZeroMemory to clear magic fields.
Signed-off-by: Eric Pouech epouech@codeweavers.com
---
dlls/user32/dde_misc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/dlls/user32/dde_misc.c b/dlls/user32/dde_misc.c index 39b439976cd..b5ccf449692 100644 --- a/dlls/user32/dde_misc.c +++ b/dlls/user32/dde_misc.c @@ -2113,7 +2113,8 @@ void WDML_RemoveConv(WDML_CONV* pRef, WDML_SIDE side) { pPrev->next = pCurrent->next; } - pCurrent->magic = 0; + /* Ensure compiler doesn't optimize out the assignment with 0. */ + SecureZeroMemory(&pCurrent->magic, sizeof(pCurrent->magic)); HeapFree(GetProcessHeap(), 0, pCurrent); break; }