Jacek Caban : wininet: Use _ltow instead of sprintf for port number in InternetCreateUrl.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 9fe900532eb310d114c04d15a8d0b986ec831552
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=9fe900532eb310d114c04d15a...

Author: Jacek Caban 
Date:   Fri Mar 20 14:35:43 2020 +0100

wininet: Use _ltow instead of sprintf for port number in InternetCreateUrl.

Signed-off-by: Jacek Caban 
Signed-off-by: Alexandre Julliard

---

dlls/wininet/internet.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/dlls/wininet/internet.c b/dlls/wininet/internet.c
index cdafbfa139..4b7cdad66e 100644
--- a/dlls/wininet/internet.c
+++ b/dlls/wininet/internet.c
@@ -4263,9 +4263,10 @@ static BOOL calc_url_length(LPURL_COMPONENTSW lpUrlComponents,

if (!url_uses_default_port(nScheme, lpUrlComponents->nPort))
         {
-            char szPort[MAX_WORD_DIGITS+1];
+            WCHAR port[MAX_WORD_DIGITS + 1];

-            *lpdwUrlLength += sprintf(szPort, "%d", lpUrlComponents->nPort);
+            _ltow(lpUrlComponents->nPort, port, 10);
+            *lpdwUrlLength += lstrlenW(port);
             *lpdwUrlLength += strlen(":");
         }

@@ -4421,10 +4422,8 @@ BOOL WINAPI InternetCreateUrlW(LPURL_COMPONENTSW lpUrlComponents, DWORD dwFlags,
 {
     DWORD dwLen;
     INTERNET_SCHEME nScheme;
-    WCHAR *start = lpszUrl;

static const WCHAR slashSlashW[] = {'/','/'};
-    static const WCHAR fmtW[] = {'%','u',0};

TRACE("(%p,%d,%p,%p)\n", lpUrlComponents, dwFlags, lpszUrl, lpdwUrlLength);

@@ -4509,9 +4508,9 @@ BOOL WINAPI InternetCreateUrlW(LPURL_COMPONENTSW lpUrlComponents, DWORD dwFlags,

if (!url_uses_default_port(nScheme, lpUrlComponents->nPort))
         {
-            *lpszUrl = ':';
-            lpszUrl++;
-            lpszUrl += swprintf(lpszUrl, *lpdwUrlLength - (lpszUrl - start), fmtW, lpUrlComponents->nPort);
+            *lpszUrl++ = ':';
+            _ltow(lpUrlComponents->nPort, lpszUrl, 10);
+            lpszUrl += lstrlenW(lpszUrl);
         }

/* add slash between hostname and path if necessary */