Nikolay Sivov : shell32: Fix interface leak (Valgrind).

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 52dc1bcd370398317ae928f6edb6cc9ec6e3f703
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=52dc1bcd370398317ae928f6ed...

Author: Nikolay Sivov 
Date:   Tue Jan 18 22:45:03 2011 +0300

shell32: Fix interface leak (Valgrind).

---

dlls/shell32/shfldr_fs.c |   11 ++++++-----
 1 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/dlls/shell32/shfldr_fs.c b/dlls/shell32/shfldr_fs.c
index 084dffd..c0e9ae5 100644
--- a/dlls/shell32/shfldr_fs.c
+++ b/dlls/shell32/shfldr_fs.c
@@ -314,8 +314,7 @@ LPITEMIDLIST SHELL32_CreatePidlFromBindCtx(IBindCtx *pbc, LPCWSTR path)
         'B','i','n','d',' ','D','a','t','a',0 };
     IFileSystemBindData *fsbd = NULL;
     LPITEMIDLIST pidl = NULL;
-    IUnknown *param = NULL;
-    WIN32_FIND_DATAW wfd;
+    IUnknown *unk = NULL;
     HRESULT r;

TRACE("%p %s\n", pbc, debugstr_w(path));
@@ -324,14 +323,15 @@ LPITEMIDLIST SHELL32_CreatePidlFromBindCtx(IBindCtx *pbc, LPCWSTR path)
         return NULL;

/* see if the caller bound File System Bind Data */
-    r = IBindCtx_GetObjectParam( pbc, szfsbc, &param );
+    r = IBindCtx_GetObjectParam( pbc, szfsbc, &unk );
     if (FAILED(r))
         return NULL;

-    r = IUnknown_QueryInterface( param, &IID_IFileSystemBindData,
-                                 (LPVOID*) &fsbd );
+    r = IUnknown_QueryInterface( unk, &IID_IFileSystemBindData, (void**)&fsbd );
     if (SUCCEEDED(r))
     {
+        WIN32_FIND_DATAW wfd;
+
         r = IFileSystemBindData_GetFindData( fsbd, &wfd );
         if (SUCCEEDED(r))
         {
@@ -340,6 +340,7 @@ LPITEMIDLIST SHELL32_CreatePidlFromBindCtx(IBindCtx *pbc, LPCWSTR path)
         }
         IFileSystemBindData_Release( fsbd );
     }
+    IUnknown_Release( unk );

return pidl;
 }