Francois Gouget : testbot/web: Deprecate the patchprograms Step file type.

[Alexandre Julliard]

Module: tools
Branch: master
Commit: a70473532c96cae75bf50c54632bcc063d659d27
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=a70473532c96cae75bf50c54...

Author: Francois Gouget 
Date:   Thu Jun 14 10:37:44 2018 +0200

testbot/web: Deprecate the patchprograms Step file type.

The patchdlls / patchprograms Step::FileType distinction is obsolete
since build steps may now have to handle patches that include both.
So as a first step standardize on patchdlls to identify patch files.
Later on support for patchprograms can be removed altogether.

Signed-off-by: Francois Gouget 
Signed-off-by: Alexandre Julliard

---

testbot/lib/WineTestBot/PatchUtils.pm |  1 -
 testbot/web/Submit.pl                 | 19 +++++++------------
 2 files changed, 7 insertions(+), 13 deletions(-)

diff --git a/testbot/lib/WineTestBot/PatchUtils.pm b/testbot/lib/WineTestBot/PatchUtils.pm
index 14a5985..ec609d9 100644
--- a/testbot/lib/WineTestBot/PatchUtils.pm
+++ b/testbot/lib/WineTestBot/PatchUtils.pm
@@ -115,7 +115,6 @@ sub _AddTest($$$)
     my $ExeBase = ($Root eq "programs") ? "${Module}.exe_test" :
                                           "${Module}_test";
     $Tests->{$Module} = {
-      "Type"    => "patch$Root",
       "Module"  => $Module,
       "Path"    => "$Root/$Module/tests",
       "ExeBase" => $ExeBase,
diff --git a/testbot/web/Submit.pl b/testbot/web/Submit.pl
index 97f31d1..1425301 100644
--- a/testbot/web/Submit.pl
+++ b/testbot/web/Submit.pl
@@ -118,8 +118,7 @@ sub GetPropertyDescriptors($)
   }
   elsif ($self->{Page} == 3)
   {
-    my $IsPatch = ($self->GetParam("FileType") eq "patchdlls" ||
-                   $self->GetParam("FileType") eq "patchprograms");
+    my $IsPatch = ($self->GetParam("FileType") eq "patchdlls");
     $self->{PropertyDescriptors3}[0]->{IsRequired} = $IsPatch;
     return $self->{PropertyDescriptors3};
   }
@@ -386,8 +385,7 @@ sub DisplayProperty($$)
   if ($self->{Page} == 3)
   {
     my $PropertyName = $PropertyDescriptor->GetName();
-    if ($self->GetParam("FileType") eq "patchdlls" ||
-        $self->GetParam("FileType") eq "patchprograms")
+    if ($self->GetParam("FileType") eq "patchdlls")
     {
       if ($PropertyName eq "Run64")
       {
@@ -477,8 +475,6 @@ sub Validate($)
   {
     if (($self->GetParam("FileType") eq "patchdlls" &&
          $self->GetParam("TestExecutable") !~ m/^[\w_.]+_test.exe$/) ||
-        ($self->GetParam("FileType") eq "patchprograms" &&
-         $self->GetParam("TestExecutable") !~ m/^[\w_.]+.exe_test.exe$/) ||
         ($self->GetParam("TestExecutable") =~ m=(?:[a-z]:|[/\])=i))
     {
       $self->{ErrField} = "TestExecutable";
@@ -603,7 +599,7 @@ sub DetermineFileType($$)
     else
     {
       my $TestInfo = (values %{$Impacts->{Tests}})[0];
-      $FileType = $TestInfo->{Type};
+      $FileType = "patchdlls";
       $ExeBase = $TestInfo->{ExeBase};
       $TestUnit = (keys %{$TestInfo->{Units}})[0];
     }
@@ -651,8 +647,7 @@ sub OnPage1Next($)
       $self->{ErrMessage} = $ErrMessage;
       return !1;
     }
-    if ($FileType ne "patchdlls" && $FileType ne "patchprograms" &&
-        $FileType ne "exe32" && $FileType ne "exe64")
+    if ($FileType !~ /^(?:exe32|exe64|patchdlls)$/)
     {
       $self->{ErrField} = "File";
       $self->{ErrMessage} = "Unrecognized file type";
@@ -772,7 +767,7 @@ sub OnSubmit($)

my $BuildStep;
   my $FileType = $self->GetParam("FileType");
-  if ($FileType eq "patchdlls" || $FileType eq "patchprograms")
+  if ($FileType eq "patchdlls")
   {
     # This is a patch so add a build step...
     $BuildStep = $Steps->Add();
@@ -805,7 +800,7 @@ sub OnSubmit($)
   {
     next if ($Bits eq "32" && $FileType eq "exe64");
     next if ($Bits eq "64" && $FileType eq "exe32");
-    next if ($Bits eq "64" && $FileType =~ /^patch/ && !defined($self->GetParam("Run64")));
+    next if ($Bits eq "64" && $FileType eq "patchdlls" && !defined($self->GetParam("Run64")));
     my $Tasks;

my $VMs = CreateVMs();
@@ -821,7 +816,7 @@ sub OnSubmit($)
       {
         # First create the test step
         my $TestStep = $Steps->Add();
-        if ($FileType eq "patchdlls" || $FileType eq "patchprograms")
+        if ($FileType eq "patchdlls")
         {
           $TestStep->PreviousNo($BuildStep->No);
           my $TestExe = basename($self->GetParam("TestExecutable"));