Davide Beatrici : winecoreaudio: Use mmdevapi's AudioClient's Initialize.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: f5d89202393384637ce54bfa477a4d84c40a80d3
URL:    https://gitlab.winehq.org/wine/wine/-/commit/f5d89202393384637ce54bfa477a4d8...

Author: Davide Beatrici 
Date:   Tue Jun 20 06:02:44 2023 +0200

winecoreaudio: Use mmdevapi's AudioClient's Initialize.

---

dlls/winecoreaudio.drv/mmdevdrv.c | 139 +-------------------------------------
 1 file changed, 3 insertions(+), 136 deletions(-)

diff --git a/dlls/winecoreaudio.drv/mmdevdrv.c b/dlls/winecoreaudio.drv/mmdevdrv.c
index 43c1a7a4cf9..b8c320563e6 100644
--- a/dlls/winecoreaudio.drv/mmdevdrv.c
+++ b/dlls/winecoreaudio.drv/mmdevdrv.c
@@ -70,17 +70,11 @@ static CRITICAL_SECTION_DEBUG g_sessions_lock_debug =
 static CRITICAL_SECTION g_sessions_lock = { &g_sessions_lock_debug, -1, 0, 0, 0, 0 };
 static struct list g_sessions = LIST_INIT(g_sessions);

-extern HRESULT main_loop_start(void) DECLSPEC_HIDDEN;
-
 extern struct audio_session_wrapper *session_wrapper_create(
     struct audio_client *client) DECLSPEC_HIDDEN;

extern HRESULT stream_release(stream_handle stream, HANDLE timer_thread);

-extern WCHAR *get_application_name(void);
-
-extern void set_stream_volumes(struct audio_client *This);
-
 void DECLSPEC_HIDDEN sessions_lock(void)
 {
     EnterCriticalSection(&g_sessions_lock);
@@ -424,40 +418,6 @@ static ULONG WINAPI AudioClient_Release(IAudioClient3 *iface)
     return ref;
 }

-static void dump_fmt(const WAVEFORMATEX *fmt)
-{
-    TRACE("wFormatTag: 0x%x (", fmt->wFormatTag);
-    switch(fmt->wFormatTag){
-    case WAVE_FORMAT_PCM:
-        TRACE("WAVE_FORMAT_PCM");
-        break;
-    case WAVE_FORMAT_IEEE_FLOAT:
-        TRACE("WAVE_FORMAT_IEEE_FLOAT");
-        break;
-    case WAVE_FORMAT_EXTENSIBLE:
-        TRACE("WAVE_FORMAT_EXTENSIBLE");
-        break;
-    default:
-        TRACE("Unknown");
-        break;
-    }
-    TRACE(")\n");
-
-    TRACE("nChannels: %u\n", fmt->nChannels);
-    TRACE("nSamplesPerSec: %lu\n", fmt->nSamplesPerSec);
-    TRACE("nAvgBytesPerSec: %lu\n", fmt->nAvgBytesPerSec);
-    TRACE("nBlockAlign: %u\n", fmt->nBlockAlign);
-    TRACE("wBitsPerSample: %u\n", fmt->wBitsPerSample);
-    TRACE("cbSize: %u\n", fmt->cbSize);
-
-    if(fmt->wFormatTag == WAVE_FORMAT_EXTENSIBLE){
-        WAVEFORMATEXTENSIBLE *fmtex = (void*)fmt;
-        TRACE("dwChannelMask: %08lx\n", fmtex->dwChannelMask);
-        TRACE("Samples: %04x\n", fmtex->Samples.wReserved);
-        TRACE("SubFormat: %s\n", wine_dbgstr_guid(&fmtex->SubFormat));
-    }
-}
-
 static void session_init_vols(AudioSession *session, UINT channels)
 {
     if(session->channel_count < channels){
@@ -537,103 +497,10 @@ HRESULT get_audio_session(const GUID *sessionguid,
     return S_OK;
 }

-static HRESULT WINAPI AudioClient_Initialize(IAudioClient3 *iface,
+extern HRESULT WINAPI client_Initialize(IAudioClient3 *iface,
         AUDCLNT_SHAREMODE mode, DWORD flags, REFERENCE_TIME duration,
         REFERENCE_TIME period, const WAVEFORMATEX *fmt,
-        const GUID *sessionguid)
-{
-    ACImpl *This = impl_from_IAudioClient3(iface);
-    struct create_stream_params params;
-    stream_handle stream;
-    UINT32 i, channel_count;
-    WCHAR *name;
-
-    TRACE("(%p)->(%x, %lx, %s, %s, %p, %s)\n", This, mode, flags,
-          wine_dbgstr_longlong(duration), wine_dbgstr_longlong(period), fmt, debugstr_guid(sessionguid));
-
-    if(!fmt)
-        return E_POINTER;
-
-    dump_fmt(fmt);
-
-    if(mode != AUDCLNT_SHAREMODE_SHARED && mode != AUDCLNT_SHAREMODE_EXCLUSIVE)
-        return E_INVALIDARG;
-
-    if(flags & ~(AUDCLNT_STREAMFLAGS_CROSSPROCESS |
-                AUDCLNT_STREAMFLAGS_LOOPBACK |
-                AUDCLNT_STREAMFLAGS_EVENTCALLBACK |
-                AUDCLNT_STREAMFLAGS_NOPERSIST |
-                AUDCLNT_STREAMFLAGS_RATEADJUST |
-                AUDCLNT_SESSIONFLAGS_EXPIREWHENUNOWNED |
-                AUDCLNT_SESSIONFLAGS_DISPLAY_HIDE |
-                AUDCLNT_SESSIONFLAGS_DISPLAY_HIDEWHENEXPIRED |
-                AUDCLNT_STREAMFLAGS_SRC_DEFAULT_QUALITY |
-                AUDCLNT_STREAMFLAGS_AUTOCONVERTPCM)){
-        FIXME("Unknown flags: %08lx\n", flags);
-        return E_INVALIDARG;
-    }
-
-    sessions_lock();
-
-    if(This->stream){
-        sessions_unlock();
-        return AUDCLNT_E_ALREADY_INITIALIZED;
-    }
-
-    if(FAILED(params.result = main_loop_start())){
-        sessions_unlock();
-        return params.result;
-    }
-
-    params.name = name = get_application_name();
-    params.device = This->device_name;
-    params.flow = This->dataflow;
-    params.share = mode;
-    params.flags = flags;
-    params.duration = duration;
-    params.period = period;
-    params.fmt = fmt;
-    params.channel_count = &channel_count;
-    params.stream = &stream;
-
-    UNIX_CALL(create_stream, &params);
-
-    free(name);
-
-    if(FAILED(params.result)){
-        sessions_unlock();
-        return params.result;
-    }
-
-    This->vols = malloc(channel_count * sizeof(float));
-    if(!This->vols){
-        params.result = E_OUTOFMEMORY;
-        goto end;
-    }
-
-    for(i = 0; i < channel_count; ++i)
-        This->vols[i] = 1.f;
-
-    params.result = get_audio_session(sessionguid, This->parent, channel_count, &This->session);
-    if(FAILED(params.result)) goto end;
-
-    list_add_tail(&This->session->clients, &This->entry);
-
-end:
-    if(FAILED(params.result)){
-        stream_release(stream, NULL);
-        free(This->vols);
-        This->vols = NULL;
-    }else{
-        This->stream = stream;
-        This->channel_count = channel_count;
-        set_stream_volumes(This);
-    }
-
-    sessions_unlock();
-
-    return params.result;
-}
+        const GUID *sessionguid);

extern HRESULT WINAPI client_GetBufferSize(IAudioClient3 *iface,
         UINT32 *frames);
@@ -692,7 +559,7 @@ static const IAudioClient3Vtbl AudioClient3_Vtbl =
     AudioClient_QueryInterface,
     AudioClient_AddRef,
     AudioClient_Release,
-    AudioClient_Initialize,
+    client_Initialize,
     client_GetBufferSize,
     client_GetStreamLatency,
     client_GetCurrentPadding,