Hans Leidekker : bcrypt: Stop passing a dummy public key to gnutls_privkey_import_dsa_raw().

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 777cbf06d2e8db298313982b7823acbc40dc05db
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=777cbf06d2e8db298313982b7...

Author: Hans Leidekker 
Date:   Mon Mar 21 09:50:11 2022 +0100

bcrypt: Stop passing a dummy public key to gnutls_privkey_import_dsa_raw().

Signed-off-by: Hans Leidekker 
Signed-off-by: Alexandre Julliard

---

dlls/bcrypt/gnutls.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/dlls/bcrypt/gnutls.c b/dlls/bcrypt/gnutls.c
index 6a55c84efef..884f4b1d37e 100644
--- a/dlls/bcrypt/gnutls.c
+++ b/dlls/bcrypt/gnutls.c
@@ -1145,8 +1145,7 @@ static NTSTATUS key_import_dsa_capi( struct key *key, UCHAR *buf, ULONG len )
     BLOBHEADER *hdr = (BLOBHEADER *)buf;
     DSSPUBKEY *pubkey;
     gnutls_privkey_t handle;
-    gnutls_datum_t p, q, g, y, x;
-    unsigned char dummy[128];
+    gnutls_datum_t p, q, g, x;
     unsigned char *data, p_data[128], q_data[20], g_data[128], x_data[20];
     int i, ret, size;

@@ -1185,12 +1184,7 @@ static NTSTATUS key_import_dsa_capi( struct key *key, UCHAR *buf, ULONG len )
     for (i = 0; i < x.size; i++) x.data[i] = data[x.size - i - 1];
     data += x.size;

-    WARN( "using dummy public key\n" );
-    memset( dummy, 1, sizeof(dummy) );
-    y.data = dummy;
-    y.size = min( p.size, sizeof(dummy) );
-
-    if ((ret = pgnutls_privkey_import_dsa_raw( handle, &p, &q, &g, &y, &x )))
+    if ((ret = pgnutls_privkey_import_dsa_raw( handle, &p, &q, &g, NULL, &x )))
     {
         pgnutls_perror( ret );
         pgnutls_privkey_deinit( handle );