Paul Gofman : ntdll: Match wildcard recursively in match_filename().

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 5f31aacbe8c86f431e8bd7fcf962e829dce74e38
URL:    https://gitlab.winehq.org/wine/wine/-/commit/5f31aacbe8c86f431e8bd7fcf962e82...

Author: Paul Gofman 
Date:   Wed Jun  5 17:34:48 2024 -0600

ntdll: Match wildcard recursively in match_filename().

---

dlls/ntdll/unix/file.c | 82 ++++++++++++++++++--------------------------------
 1 file changed, 29 insertions(+), 53 deletions(-)

diff --git a/dlls/ntdll/unix/file.c b/dlls/ntdll/unix/file.c
index b5bf6f9801d..724a9d99b00 100644
--- a/dlls/ntdll/unix/file.c
+++ b/dlls/ntdll/unix/file.c
@@ -1421,30 +1421,13 @@ static ULONG hash_short_file_name( const WCHAR *name, int length, LPWSTR buffer

/***********************************************************************
- *           match_filename
+ *           match_filename_part
  *
- * Check a long file name against a mask.
+ * Recursive helper for match_filename().
  *
- * Tests (done in W95 DOS shell - case insensitive):
- * *.txt			test1.test.txt				*
- * *st1*			test1.txt				*
- * *.t??????.t*			test1.ta.tornado.txt			*
- * *tornado*			test1.ta.tornado.txt			*
- * t*t				test1.ta.tornado.txt			*
- * ?est*			test1.txt				*
- * ?est???			test1.txt				-
- * *test1.txt*			test1.txt				*
- * h?l?o*t.dat			hellothisisatest.dat			*
  */
-static BOOLEAN match_filename( const WCHAR *name, int length, const UNICODE_STRING *mask_str )
+static BOOLEAN match_filename_part( const WCHAR *name, const WCHAR *name_end, const WCHAR *mask, const WCHAR *mask_end )
 {
-    BOOL mismatch;
-    const WCHAR *mask = mask_str->Buffer;
-    const WCHAR *name_end = name + length;
-    const WCHAR *mask_end = mask + mask_str->Length / sizeof(WCHAR);
-    const WCHAR *lastjoker = NULL;
-    const WCHAR *next_to_retry = NULL;
-
     while (name < name_end && mask < mask_end)
     {
         switch(*mask)
@@ -1453,14 +1436,16 @@ static BOOLEAN match_filename( const WCHAR *name, int length, const UNICODE_STRI
             mask++;
             while (mask < mask_end && *mask == '*') mask++;  /* Skip consecutive '*' */
             if (mask == mask_end) return TRUE; /* end of mask is all '*', so match */
-            lastjoker = mask;

-            /* skip to the next match after the joker(s) */
-            if (is_case_sensitive)
-                while (name < name_end && (*name != *mask)) name++;
-            else
-                while (name < name_end && (towupper(*name) != towupper(*mask))) name++;
-            next_to_retry = name;
+            while (name < name_end)
+            {
+                if (is_case_sensitive)
+                    while (name < name_end && (*name != *mask)) name++;
+                else
+                    while (name < name_end && (towupper(*name) != towupper(*mask))) name++;
+                if (match_filename_part( name, name_end, mask, mask_end )) return TRUE;
+                ++name;
+            }
             break;
         case '?':
         case '>':
@@ -1468,32 +1453,10 @@ static BOOLEAN match_filename( const WCHAR *name, int length, const UNICODE_STRI
             name++;
             break;
         default:
-            if (is_case_sensitive) mismatch = (*mask != *name);
-            else mismatch = (towupper(*mask) != towupper(*name));
-
-            if (!mismatch)
-            {
-                mask++;
-                name++;
-                if (mask == mask_end)
-                {
-                    if (name == name_end) return TRUE;
-                    if (lastjoker) mask = lastjoker;
-                }
-            }
-            else /* mismatch ! */
-            {
-                if (lastjoker) /* we had an '*', so we can try unlimitedly */
-                {
-                    mask = lastjoker;
-
-                    /* this scan sequence was a mismatch, so restart
-                     * 1 char after the first char we checked last time */
-                    next_to_retry++;
-                    name = next_to_retry;
-                }
-                else return FALSE; /* bad luck */
-            }
+            if (is_case_sensitive && *mask != *name) return FALSE;
+            if (!is_case_sensitive && towupper(*mask) != towupper(*name)) return FALSE;
+            mask++;
+            name++;
             break;
         }
     }
@@ -1503,6 +1466,19 @@ static BOOLEAN match_filename( const WCHAR *name, int length, const UNICODE_STRI
 }

+/***********************************************************************
+ *           match_filename
+ *
+ * Check a file name against a mask.
+ *
+ */
+static BOOLEAN match_filename( const WCHAR *name, int length, const UNICODE_STRING *mask_str )
+{
+    return match_filename_part( name, name + length, mask_str->Buffer,
+                                mask_str->Buffer + mask_str->Length / sizeof(WCHAR));
+}
+
+
 /***********************************************************************
  *           is_legal_8dot3_name
  *