Module: tools Branch: master Commit: 1ae97e538a6dbfbc6a3b96bcaa5866f333f027ee URL: http://source.winehq.org/git/tools.git/?a=commit;h=1ae97e538a6dbfbc6a3b96bca...
Author: Francois Gouget fgouget@codeweavers.com Date: Tue Oct 10 23:56:44 2017 +0200
testbot: Remove redundant calls to RescheduleJobs().
Modifying a VM's Status field already triggers a rescheduling ($VM->Save() triggers $VM->OnSaved() which calls VMStatusChange() to notify the Engine's HandleVMStatusChange() which calls ScheduleJobs()). So there is no need to call RescheduleJobs() right after saving the VM's new status.
Signed-off-by: Francois Gouget fgouget@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
---
testbot/bin/WineRunBuild.pl | 1 - testbot/bin/WineRunReconfig.pl | 1 - testbot/bin/WineRunTask.pl | 1 - 3 files changed, 3 deletions(-)
diff --git a/testbot/bin/WineRunBuild.pl b/testbot/bin/WineRunBuild.pl index 326ac0c..85fe568 100755 --- a/testbot/bin/WineRunBuild.pl +++ b/testbot/bin/WineRunBuild.pl @@ -241,7 +241,6 @@ sub WrapUpAndExit($;$) { $VM->Status($NewVMStatus); $VM->Save(); - RescheduleJobs(); }
my $Result = $VM->Name .": ". $VM->Status ." Status: $Status Failures: ". (defined $TestFailures ? $TestFailures : "unset"); diff --git a/testbot/bin/WineRunReconfig.pl b/testbot/bin/WineRunReconfig.pl index d8e007d..b2071cd 100755 --- a/testbot/bin/WineRunReconfig.pl +++ b/testbot/bin/WineRunReconfig.pl @@ -242,7 +242,6 @@ sub WrapUpAndExit($;$) { $VM->Status($NewVMStatus); $VM->Save(); - RescheduleJobs(); }
my $Result = $VM->Name .": ". $VM->Status ." Status: $Status Failures: ". (defined $TestFailures ? $TestFailures : "unset"); diff --git a/testbot/bin/WineRunTask.pl b/testbot/bin/WineRunTask.pl index 618ef8f..2328b31 100755 --- a/testbot/bin/WineRunTask.pl +++ b/testbot/bin/WineRunTask.pl @@ -270,7 +270,6 @@ sub WrapUpAndExit($;$$) { $VM->Status($NewVMStatus); $VM->Save(); - RescheduleJobs(); }
if ($Status eq 'completed' and $Step->Type eq 'suite')