James Hawkins : advapi32: Fix a few memory leaks. Use the correct API to free SIDs (FreeSid).

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 621a772d48e944e33520639729c02865ffdde9e5
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=621a772d48e944e33520639729...

Author: James Hawkins 
Date:   Wed Jan  6 18:26:39 2010 -0800

advapi32: Fix a few memory leaks. Use the correct API to free SIDs (FreeSid).

---

dlls/advapi32/tests/security.c |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/dlls/advapi32/tests/security.c b/dlls/advapi32/tests/security.c
index 8c986e5..029568c 100644
--- a/dlls/advapi32/tests/security.c
+++ b/dlls/advapi32/tests/security.c
@@ -1490,7 +1490,7 @@ static void test_CreateWellKnownSid(void)
         }
     }

-    LocalFree(domainsid);
+    FreeSid(domainsid);
 }

static void test_LookupAccountSid(void)
@@ -1812,7 +1812,7 @@ static BOOL get_sid_info(PSID psid, LPSTR *user, LPSTR *dom)
 static void check_wellknown_name(const char* name, WELL_KNOWN_SID_TYPE result)
 {
     SID_IDENTIFIER_AUTHORITY ident = { SECURITY_NT_AUTHORITY };
-    PSID domainsid;
+    PSID domainsid = NULL;
     char wk_sid[SECURITY_MAX_SID_SIZE];
     DWORD cb;

@@ -1862,6 +1862,7 @@ static void check_wellknown_name(const char* name, WELL_KNOWN_SID_TYPE result)
     ok(sid_use == SidTypeWellKnownGroup , "Expected Use (5), got %d\n", sid_use);

cleanup:
+    FreeSid(domainsid);
     HeapFree(GetProcessHeap(),0,psid);
     HeapFree(GetProcessHeap(),0,domain);
 }
@@ -2615,8 +2616,8 @@ static void test_SetEntriesInAcl(void)
     ok(NewAcl != NULL, "returned acl was NULL\n");
     LocalFree(NewAcl);

-    LocalFree(UsersSid);
-    LocalFree(EveryoneSid);
+    FreeSid(UsersSid);
+    FreeSid(EveryoneSid);
     HeapFree(GetProcessHeap(), 0, OldAcl);
 }