Zhiyi Zhang : winegstreamer: Always check the return value from mf_media_type_from_wg_format().

[Alexandre Julliard]

Module: wine
Branch: oldstable
Commit: b2c3fce40b222d1fd97823ad3ae301a0dee93e89
URL:    https://gitlab.winehq.org/wine/wine/-/commit/b2c3fce40b222d1fd97823ad3ae301a...

Author: Zhiyi Zhang 
Date:   Mon Aug  1 17:19:48 2022 +0800

winegstreamer: Always check the return value from mf_media_type_from_wg_format().

mf_media_type_from_wg_format() may return NULL.

Fix Airborne Kingdom crash at start because WG_AUDIO_FORMAT_UNKNOWN is passed to
mf_media_type_from_wg_format().

Signed-off-by: Zhiyi Zhang 
(cherry picked from commit 6f8990b4318b25709cd90f6e10e8f3fdaa89c4c4)
Signed-off-by: Michael Stefaniuc

---

dlls/winegstreamer/media_source.c | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/dlls/winegstreamer/media_source.c b/dlls/winegstreamer/media_source.c
index 5e36ef391da..5f7c6a35f5d 100644
--- a/dlls/winegstreamer/media_source.c
+++ b/dlls/winegstreamer/media_source.c
@@ -902,6 +902,12 @@ static HRESULT media_stream_init_desc(struct media_stream *stream)
         IMFMediaType *base_type = mf_media_type_from_wg_format(&format);
         GUID base_subtype;

+        if (!base_type)
+        {
+            hr = MF_E_INVALIDMEDIATYPE;
+            goto done;
+        }
+
         IMFMediaType_GetGUID(base_type, &MF_MT_SUBTYPE, &base_subtype);

stream_types[0] = base_type;
@@ -934,8 +940,8 @@ static HRESULT media_stream_init_desc(struct media_stream *stream)
             WG_AUDIO_FORMAT_F32LE,
         };

-        stream_types[0] = mf_media_type_from_wg_format(&format);
-        type_count = 1;
+        if ((stream_types[0] = mf_media_type_from_wg_format(&format)))
+            type_count = 1;

for (i = 0; i < ARRAY_SIZE(audio_types); i++)
         {
@@ -944,7 +950,8 @@ static HRESULT media_stream_init_desc(struct media_stream *stream)
                 continue;
             new_format = format;
             new_format.u.audio.format = audio_types[i];
-            stream_types[type_count++] = mf_media_type_from_wg_format(&new_format);
+            if ((stream_types[type_count] = mf_media_type_from_wg_format(&new_format)))
+                type_count++;
         }
     }
     else