Henri Verbeet pushed to branch master at wine / vkd3d
Commits: 6a3f360a by Giovanni Mascellani at 2025-12-02T13:39:44+01:00 vkd3d-shader/dxil: Move the function emission state outside the opcode switch.
- - - - - 3b9fbe3e by Giovanni Mascellani at 2025-12-02T13:39:44+01:00 vkd3d-shader/dxil: Pass function emission state to sm6_parser_emit_alloca().
- - - - - 26f9644f by Giovanni Mascellani at 2025-12-02T13:39:44+01:00 vkd3d-shader/dxil: Allocate instructions directly in sm6_parser_emit_alloca().
I think the main argument for preallocating instructions and passing them to helpers is that this simplifies error handling. However it seems that the simplification is close to negligible, while the current solution makes it harder to use the iterator abstraction layer for the instruction array, and it also makes the code harder to read and check.
- - - - - 9457dc9c by Giovanni Mascellani at 2025-12-02T13:39:44+01:00 vkd3d-shader/dxil: Take the record from the function emission state in sm6_parser_emit_atomicrmw().
- - - - - eeb35923 by Giovanni Mascellani at 2025-12-02T13:39:44+01:00 vkd3d-shader/dxil: Handle allocation failure in sm6_parser_emit_atomicrmw().
- - - - - 3058958d by Giovanni Mascellani at 2025-12-02T13:39:44+01:00 vkd3d-shader/dxil: Allocate instructions directly in sm6_parser_emit_atomicrmw().
- - - - -
1 changed file:
- libs/vkd3d-shader/dxil.c
View it on GitLab: https://gitlab.winehq.org/wine/vkd3d/-/compare/fdfb74b20b08144e144299bc0b7b2...