Paul Gofman : ws2_32: Return success for setting SO_ERROR.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 5925a2eeb002d899a1a2ff9966faedf4dd10ca25
URL:    https://gitlab.winehq.org/wine/wine/-/commit/5925a2eeb002d899a1a2ff9966faedf...

Author: Paul Gofman 
Date:   Mon Nov 14 16:00:50 2022 -0600

ws2_32: Return success for setting SO_ERROR.

---

dlls/ws2_32/socket.c     | 6 +++---
 dlls/ws2_32/tests/sock.c | 1 -
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c
index 09684f25b25..115451c3b58 100644
--- a/dlls/ws2_32/socket.c
+++ b/dlls/ws2_32/socket.c
@@ -3173,9 +3173,9 @@ int WINAPI setsockopt( SOCKET s, int level, int optname, const char *optval, int
         }

case SO_ERROR:
-            FIXME( "SO_ERROR, stub!\n" );
-            SetLastError( WSAENOPROTOOPT );
-            return -1;
+            FIXME( "SO_ERROR, stub.\n" );
+            SetLastError( ERROR_SUCCESS );
+            return 0;

case SO_KEEPALIVE:
             if (optlen <= 0 || !optval)
diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c
index d4d92b58c41..bcccaef9bc6 100644
--- a/dlls/ws2_32/tests/sock.c
+++ b/dlls/ws2_32/tests/sock.c
@@ -1431,7 +1431,6 @@ static void test_set_getsockopt(void)
     SetLastError(0xdeadbeef);
     i = 1234;
     err = setsockopt(s, SOL_SOCKET, SO_ERROR, (char *) &i, size);
-    todo_wine
     ok( !err && !WSAGetLastError(),
         "got %d with %d (expected 0 with 0)\n",
         err, WSAGetLastError());