Module: tools Branch: master Commit: fd3a4476ca1c4d1c9293419c108f5ef57ab0494a URL: https://source.winehq.org/git/tools.git/?a=commit;h=fd3a4476ca1c4d1c9293419c...
Author: Francois Gouget fgouget@codeweavers.com Date: Wed May 2 14:49:46 2018 +0200
testbot: Tweak some comments in VMs::Run().
Signed-off-by: Francois Gouget fgouget@codeweavers.com Signed-off-by: Alexandre Julliard julliard@winehq.org
---
testbot/lib/WineTestBot/VMs.pm | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/testbot/lib/WineTestBot/VMs.pm b/testbot/lib/WineTestBot/VMs.pm index c3a4a30..839986b 100644 --- a/testbot/lib/WineTestBot/VMs.pm +++ b/testbot/lib/WineTestBot/VMs.pm @@ -340,14 +340,14 @@ sub Run($$$$$) # We cannot leave setting ChildPid to the child process because then it # may still not be set by the time the next ScheduleJobs() call happens, # which would result in a new child being started. - # Note that the status is not guaranteed to change in _RunVMTool() so it - # cannot be relied on to avoid this race. - # - Between _RunVMTool() and the exit of the child process. - # The child process may exit before _RunVMTool() gets around to setting - # ChildPid after the fork(). This would result in ChildPid remaining set + # Note that the status is not guaranteed to change in Run() so it cannot + # be relied on to avoid this race. + # - Between Run() and the exit of the child process. + # The child process may exit before Run() gets around to setting ChildPid + # after the fork(). This would result in ChildPid remaining set # indefinitely. # So set ChildPid in the parent and synchronize with the child so it only - # starts once this is done. + # execs once this is done.
use Fcntl; my ($fd_read, $fd_write); @@ -362,6 +362,7 @@ sub Run($$$$$) } if ($Pid) { + ### Parent process close($fd_read);
# Set the Status and ChildPid @@ -380,6 +381,8 @@ sub Run($$$$$) return undef; }
+ ### Child process + # Close the database connections CloseAllDBBackEnds();